Re: Review Request 123992: Use upcoming version of libdbusmenu-qt
On June 4, 2015, 10:33 p.m., Sebastian Kügler wrote: 5.4 or 5.3.2? I've noticed that a bunch of smaller things could be improved, though they might well be in the original code already, so can be pushed upstream independently. I'm OK with shipping this as-is, since this is really the wrong place to fix the fallout I've noticed, so if you feel comfy with it as-is (and will take care of removing the copy again once upstream has merged the changes), then go ahead and ship it. Most importantly: Fixing crashers is good, and that's why it should go in quickly. Thanks for looking into this. David Edmundson wrote: I'm wanting to go for 5.3.2 It's in a branch in davidedmundson/newdbusmenuqt if people want to give it a spin. your smaller comments look sensible; if we want to drop Qt4 upstream. Which I don't know about. I'll ask and put them in upstream's review too. I missed that window because I forgot. Pushed for 5.4. Implemented most your comments. On June 4, 2015, 10:33 p.m., Sebastian Kügler wrote: dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.cpp, line 37 https://git.reviewboard.kde.org/r/123992/diff/1/?file=378706#file378706line37 could be wrapped in more efficient ctors (QL1S, QStringLiteral) they're char*s - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123992/#review81216 --- On June 3, 2015, 4:03 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123992/ --- (Updated June 3, 2015, 4:03 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This contains a temporary fork of the dbusmenu-qt importer, with the main paths fixed. Also fixes some leaks No loner has a stupid event loop. This fixes ~5 crash reports we've had. Submitted to upstream, but they're not the fastest and it has to be an API break. Diffs - dataengines/statusnotifieritem/CMakeLists.txt e639ee351a1cc6ad0b4448bd0feadc7af0d7984d dataengines/statusnotifieritem/libdbusmenuqt/README PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.h PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.cpp PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.h PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.cpp PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.h PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.cpp PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/utils.cpp PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/utils_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123992/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma Hangout
Present: Bhushan, Martin G., Sebastian, Kai Uwe, David Date: 6 July, 2015 Bhushan: * Working demo of PMC's widget explorer here https://www.youtube.com/watch?v=J82iPaYA8jE Kai Uwe * various bugfixes, fallout from shared qml engine patches * fixed dropping folder on desktop creates folderview * sticky notes improvements: https://git.reviewboard.kde.org/r/124246/ * better support for UPS (uninterruptible power supplies) * OSX fixes Martin G: * Pluginification of some frameworks to support wayland next to X11 * kglobalaccel (done) * kwindowsystem (in review) * kidletime (in review) * actual plugins to come later (new repo for now, to go into kde/workspace) * Looking into kdeinit deadlock (reveals architectural fun) David: * libdbusmenu-qt fork is merged now * working on screenedges problems (will push for review) Sebas: * KPluginMetaData::formFactors() merged, * explanation at http://vizzzion.org/blog/2015/07/convergence-through-divergence/ -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124250: Add screenlocker docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/#review82114 --- Ship it! - Martin Gräßlin On July 6, 2015, 11:54 a.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/ --- (Updated July 6, 2015, 11:54 a.m.) Review request for Documentation and Plasma. Repository: plasma-workspace Description --- Add missing screenlocker docbook, a modified copy from kde-workspace / doc / kcontrol / screensaver / index.docbook @ KDE/4.11 Diffs - doc/CMakeLists.txt 0eb36a6 doc/kcontrol/CMakeLists.txt PRE-CREATION doc/kcontrol/screenlocker/CMakeLists.txt PRE-CREATION doc/kcontrol/screenlocker/index.docbook PRE-CREATION ksmserver/screenlocker/kcm/screenlocker.desktop 19caa3b Diff: https://git.reviewboard.kde.org/r/124250/diff/ Testing --- Builds and is opened an Help Action in KCM Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124250: Add screenlocker docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/ --- (Updated July 6, 2015, 10:42 a.m.) Status -- This change has been marked as submitted. Review request for Documentation and Plasma. Changes --- Submitted with commit d9adb0b3fccf4e2c367619a13923b0cea08625e8 by Burkhard Lück to branch master. Repository: plasma-workspace Description --- Add missing screenlocker docbook, a modified copy from kde-workspace / doc / kcontrol / screensaver / index.docbook @ KDE/4.11 Diffs - doc/CMakeLists.txt 0eb36a6 doc/kcontrol/CMakeLists.txt PRE-CREATION doc/kcontrol/screenlocker/CMakeLists.txt PRE-CREATION doc/kcontrol/screenlocker/index.docbook PRE-CREATION ksmserver/screenlocker/kcm/screenlocker.desktop 19caa3b Diff: https://git.reviewboard.kde.org/r/124250/diff/ Testing --- Builds and is opened an Help Action in KCM Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124250: Add screenlocker docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/ --- (Updated Juli 6, 2015, 9:54 vorm.) Review request for Documentation and Plasma. Changes --- Fix ussues spotted by Martin Gräßlin, thanks Repository: plasma-workspace Description --- Add missing screenlocker docbook, a modified copy from kde-workspace / doc / kcontrol / screensaver / index.docbook @ KDE/4.11 Diffs (updated) - doc/CMakeLists.txt 0eb36a6 doc/kcontrol/CMakeLists.txt PRE-CREATION doc/kcontrol/screenlocker/CMakeLists.txt PRE-CREATION doc/kcontrol/screenlocker/index.docbook PRE-CREATION ksmserver/screenlocker/kcm/screenlocker.desktop 19caa3b Diff: https://git.reviewboard.kde.org/r/124250/diff/ Testing --- Builds and is opened an Help Action in KCM Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124250: Add screenlocker docbook
On Juli 5, 2015, 12:59 nachm., Martin Gräßlin wrote: This adds a new directory called kcontrol. Would it not be better to drop this KDE 3.5 term and replace it with what it's about? E.g. lockscreen or screenlocker? No, because 1) The new directory called kcontrol is consistent with nearly all other kcm docbooks (one except is kwin - see 3) 2) Scripty needs the directory kcontrol to generate entries with the correct install path for CMakelists.txt in the language docbook directories 3) For the kwin kcm docbooks not beeing in a subdir kcontrol the file http://websvn.kde.org/trunk/l10n-kf5/scripts/documentation_paths?view=markup needs five entries to add the necessary kcontrol dir for scripty instead of one entries with kwin kcm docbooks in a subdir kcontrol - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/#review82091 --- On Juli 6, 2015, 9:54 vorm., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/ --- (Updated Juli 6, 2015, 9:54 vorm.) Review request for Documentation and Plasma. Repository: plasma-workspace Description --- Add missing screenlocker docbook, a modified copy from kde-workspace / doc / kcontrol / screensaver / index.docbook @ KDE/4.11 Diffs - doc/CMakeLists.txt 0eb36a6 doc/kcontrol/CMakeLists.txt PRE-CREATION doc/kcontrol/screenlocker/CMakeLists.txt PRE-CREATION doc/kcontrol/screenlocker/index.docbook PRE-CREATION ksmserver/screenlocker/kcm/screenlocker.desktop 19caa3b Diff: https://git.reviewboard.kde.org/r/124250/diff/ Testing --- Builds and is opened an Help Action in KCM Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123992: Use upcoming version of libdbusmenu-qt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123992/ --- (Updated July 6, 2015, 8:55 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 3d0a9cd462a7ab256b65dec7ed2035e0d7658818 by David Edmundson to branch master. Repository: plasma-workspace Description --- This contains a temporary fork of the dbusmenu-qt importer, with the main paths fixed. Also fixes some leaks No loner has a stupid event loop. This fixes ~5 crash reports we've had. Submitted to upstream, but they're not the fastest and it has to be an API break. Diffs - dataengines/statusnotifieritem/CMakeLists.txt e639ee351a1cc6ad0b4448bd0feadc7af0d7984d dataengines/statusnotifieritem/libdbusmenuqt/README PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.h PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.cpp PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.h PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.cpp PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.h PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.cpp PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/utils.cpp PRE-CREATION dataengines/statusnotifieritem/libdbusmenuqt/utils_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123992/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124255: keyboard: do not reset shortcut for changing layout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124255/ --- (Updated July 6, 2015, 2:21 p.m.) Review request for Plasma. Repository: plasma-desktop Description (updated) --- This patch solves a problem when Ctrl-Alt-K always used for Switch to Next Keyboard Layout. It solves this bug [RHBZ 1234082](https://bugzilla.redhat.com/show_bug.cgi?id=1234082) Diffs - kcms/keyboard/bindings.cpp a11941f Diff: https://git.reviewboard.kde.org/r/124255/diff/ Testing --- Thanks, Ivan Romanov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 60 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/60/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jul 2015 08:34:24 + Build duration: 10 min CHANGE SET Revision d1bf953821ca1782ebabebfae0f9ca1be3ce0bf7 by Martin Gräßlin: ([kcms] Delete bell.desktop again) change: delete kcms/bell/bell.desktop ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124268/ --- (Updated July 6, 2015, 1:46 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Compatibility code for old Qt releases. Neither Qt 4 nor Qt 5 use this property [1]. Whether this code would still work for Qt 2 or 3 at all is certainly unknown, but it clearly crashes with QT_QPA_PLATFORM=wayland. [1] checked with git grep in qt4 and qt5/qtbase Diffs - kcms/style/kcmstyle.cpp fb543972c7cc0c9c7dc8753f8917781a4de00637 Diff: https://git.reviewboard.kde.org/r/124268/diff/ Testing --- no longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124268/ --- Review request for Plasma. Repository: plasma-desktop Description --- Compatibility code for old Qt releases. Neither Qt 4 nor Qt 5 use this property [1]. Whether this code would still work for Qt 2 or 3 at all is certainly unknown, but it clearly crashes with QT_QPA_PLATFORM=wayland. [1] checked with git grep in qt4 and qt5/qtbase Diffs - kcms/style/kcmstyle.cpp fb543972c7cc0c9c7dc8753f8917781a4de00637 Diff: https://git.reviewboard.kde.org/r/124268/diff/ Testing --- no longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma Hangout
Eike * Finished refactoring the Kicker backend to (among other things) allow favorite'ing arbitrary things like contacts with realtime status information: http://wstaw.org/m/2015/07/05/contactfaves.png * Ongoing: Lean fullscreen launcher interface (to make up for old Homerun) using this backend; porting Kickoff to this backend to get feature parity between all of the launchers * Some early toying with a new version of libtaskmanager implemented as proxy models on top of the PlasmaWindowModel I put into kwayland recently Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 61 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jul 2015 11:58:17 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/38 (95%)CLASSES 36/38 (95%)LINE 2375/3422 (69%)CONDITIONAL 1798/3109 (58%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 18/34 (53%) kcms.keyboard FILES 20/22 (91%)CLASSES 20/22 (91%)LINE 808/1538 (53%)CONDITIONAL 785/1298 (60%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 511/994 (51%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 242/364 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 354/410 (86%)CONDITIONAL 108/178 (61%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 269/350 (77%)CONDITIONAL 82/137 (60%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 (100%)CONDITIONAL 52/104 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124268/#review82118 --- +1 - Aleix Pol Gonzalez On July 6, 2015, 1:46 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124268/ --- (Updated July 6, 2015, 1:46 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Compatibility code for old Qt releases. Neither Qt 4 nor Qt 5 use this property [1]. Whether this code would still work for Qt 2 or 3 at all is certainly unknown, but it clearly crashes with QT_QPA_PLATFORM=wayland. [1] checked with git grep in qt4 and qt5/qtbase Diffs - kcms/style/kcmstyle.cpp fb543972c7cc0c9c7dc8753f8917781a4de00637 Diff: https://git.reviewboard.kde.org/r/124268/diff/ Testing --- no longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124269: [kcms/access] Do nothing on non X11 platforms
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/ --- Review request for Plasma. Repository: plasma-desktop Description --- Code base is very X11 dependent and crashes on other platforms. Checks whether it's not X11 and quits. Diffs - kcms/access/kaccess.h b39558e9d5343f10204f54e9d3ff8760f803ac09 kcms/access/kaccess.cpp 4d57824f6025ccdc1e47dfbfcb0973925307bd71 kcms/access/main.cpp a4590bf135bd00eb34fca74753d43f89cabe017a Diff: https://git.reviewboard.kde.org/r/124269/diff/ Testing --- No longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124270: [kcms/input] Ensure X11 specific code doesn't crash on other platforms
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124270/ --- Review request for Plasma. Repository: plasma-desktop Description --- For the kcminit_mouse it's important to also function on Xwayland in order to set correct cursor information for X clients. Thus if it's not on platform xcb it tries to open an X connection the old way. Diffs - kcms/input/main.cpp 9703e793665ca78c2d05f4395199faa6cdf78ff4 kcms/input/mouse.h 8ec0a95f5dcb929dff87ace152357e022a5979f6 kcms/input/mouse.cpp a190effaad68390b3e3e36405b689a53895c9a98 Diff: https://git.reviewboard.kde.org/r/124270/diff/ Testing --- No longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124269: [kcms/access] Do nothing on non X11 platforms
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/#review82119 --- kcms/access/kaccess.cpp (line 147) https://git.reviewboard.kde.org/r/124269/#comment56426 Initialize with the rest of the members on line 145? /me deeply ignores what kaccess is. - Aleix Pol Gonzalez On July 6, 2015, 1:52 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/ --- (Updated July 6, 2015, 1:52 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Code base is very X11 dependent and crashes on other platforms. Checks whether it's not X11 and quits. Diffs - kcms/access/kaccess.h b39558e9d5343f10204f54e9d3ff8760f803ac09 kcms/access/kaccess.cpp 4d57824f6025ccdc1e47dfbfcb0973925307bd71 kcms/access/main.cpp a4590bf135bd00eb34fca74753d43f89cabe017a Diff: https://git.reviewboard.kde.org/r/124269/diff/ Testing --- No longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124267: Use KWin to lower/raiser panel in windows can cover mode with edge activation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124267/#review82123 --- shell/panelview.cpp (line 342) https://git.reviewboard.kde.org/r/124267/#comment56429 if (!(foo || bar)) makes my head explode - Kai Uwe Broulik On Juli 6, 2015, 12:36 nachm., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124267/ --- (Updated Juli 6, 2015, 12:36 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- Use KWin to lower/raiser panel in windows can cover mode with edge activation like autohide does. This means if you have a maxmised menu you can still open the panel by moving the mouse to the bottom of the screen -- Requires new incoming kwin patch. Diffs - shell/panelview.h a41f9883da90bf661f4963e3b2e60a1dc49ab08c shell/panelview.cpp b94673d72fa4b226613338c31eb2300f4372b5d2 Diff: https://git.reviewboard.kde.org/r/124267/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124267: Use KWin to lower/raiser panel in windows can cover mode with edge activation
On July 6, 2015, 12:51 p.m., Kai Uwe Broulik wrote: shell/panelview.cpp, line 348 https://git.reviewboard.kde.org/r/124267/diff/1/?file=383465#file383465line348 if (!(foo || bar)) makes my head explode yeah, seems not just overly complicated but also completely wrong. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124267/#review82123 --- On July 6, 2015, 12:36 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124267/ --- (Updated July 6, 2015, 12:36 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Use KWin to lower/raiser panel in windows can cover mode with edge activation like autohide does. This means if you have a maxmised menu you can still open the panel by moving the mouse to the bottom of the screen -- Requires new incoming kwin patch. Diffs - shell/panelview.h a41f9883da90bf661f4963e3b2e60a1dc49ab08c shell/panelview.cpp b94673d72fa4b226613338c31eb2300f4372b5d2 Diff: https://git.reviewboard.kde.org/r/124267/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124273: Unfocus applet when clicking empty desktop area
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124273/ --- Review request for Plasma. Repository: plasma-desktop Description --- When clicking on an empty desktop area this pulls focus away from any applet, restores the 4.x behavior. This ensures that when eg. clicking outside a sticky note, it loses focus, stops cursor blinking and also has it save the note. Diffs - containments/desktop/package/contents/ui/main.qml 1ad4b93 Diff: https://git.reviewboard.kde.org/r/124273/diff/ Testing --- Not really happy but can't think of a better approach Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124236: More sensible sizing for containment configuration
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124236/ --- (Updated July 6, 2015, 4:58 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 3d87a19d282c51271b17a60ea17c4f9f3f5a4462 by Kai Uwe Broulik to branch master. Repository: plasma-desktop Description --- That dialog is pretty tall on laptops and can hardly be resized any smaller. This gives it a sensible minimum size and keeps the preferred at the old value Diffs - desktoppackage/contents/configuration/ContainmentConfiguration.qml 09a4d22 Diff: https://git.reviewboard.kde.org/r/124236/diff/ Testing --- Nuked my plasma config, dialog looked nice initially but I could make it smaller for my preference. Please #lowdpi people test Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124275: Allow building kcminput without libusb-compat
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/ --- Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin Gräßlin. Repository: plasma-desktop Description --- Some distros are slowly targetting to get rid of the old libusb (see discussion in http://lists.opensuse.org/opensuse-factory/2015-07/msg00158.html) As the code mouse.[cpp,h] and logitechmouse.[cpp,h] is already ready for such an option, allow cmake to recognize this also. Diffs - kcms/CMakeLists.txt d8a69a3 kcms/input/CMakeLists.txt ee5c9c3 Diff: https://git.reviewboard.kde.org/r/124275/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124275: Allow building kcminput without libusb-compat
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82147 --- Looks good to me - Martin Gräßlin On July 6, 2015, 8:41 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/ --- (Updated July 6, 2015, 8:41 p.m.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin Gräßlin. Repository: plasma-desktop Description --- Some distros are slowly targetting to get rid of the old libusb (see discussion in http://lists.opensuse.org/opensuse-factory/2015-07/msg00158.html) As the code mouse.[cpp,h] and logitechmouse.[cpp,h] is already ready for such an option, allow cmake to recognize this also. Diffs - kcms/CMakeLists.txt d8a69a3 kcms/input/CMakeLists.txt ee5c9c3 Diff: https://git.reviewboard.kde.org/r/124275/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124275: Allow building kcminput without libusb-compat
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82157 --- Looks good to me too, as long as it works. OTOH, it looks like a bad reason to offer an homogeneous experience, albeit being a not really interesting bit of Plasma. - Aleix Pol Gonzalez On July 6, 2015, 8:41 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/ --- (Updated July 6, 2015, 8:41 p.m.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin Gräßlin. Repository: plasma-desktop Description --- Some distros are slowly targetting to get rid of the old libusb (see discussion in http://lists.opensuse.org/opensuse-factory/2015-07/msg00158.html) As the code mouse.[cpp,h] and logitechmouse.[cpp,h] is already ready for such an option, allow cmake to recognize this also. Diffs - kcms/CMakeLists.txt d8a69a3 kcms/input/CMakeLists.txt ee5c9c3 Diff: https://git.reviewboard.kde.org/r/124275/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124246: Improve sticky notes
On July 4, 2015, 9:01 p.m., Heiko Tietze wrote: Didn't test the workflow so just about the screenshot. Alignment looks somewhat strange. According https://techbase.kde.org/Projects/Usability/HIG/Alignment the right position is left for the longest label and all other to its right edge. Furthermore the checkbox as introduction to the function is weird. If non-custom means black you could simply omit the checkbox. Probably you adjust b/w in respect to the background. Hence the color would rather fit an indented child below the checkbox. I wonder why font size and color can be set but no other option. Either it's too much (who needs to set color to green or change the default font) or not enough (why not have comic font). Kai Uwe Broulik wrote: Formatting options like bold, italic, and the like are set in the applet using the formatting buttons similar to a word processor and not globally. Font size is a must (I often use huge sticky notes as really important reminders), not sure about font color (given you can already achieve emphasis by changing the note color) and font family. Thomas Pfeiffer wrote: I do agree with Heiko that being able to set font color and size, but not font family, is really odd. Font style (bold etc.) should indeed not be set globally because they are used for emphasis. Font family, on the other hand, are as much of a stylistic preference as color and size. As for the I want huge notes for important stuff: Why not adjusting the size automatically so that the text always fills the whole widget? That way you could use huge _notes_ (as opposed to normal-sized notes with huge text) for important stuff. Of course the font size should never shrink below minimum readable size. As for the font color: I'd rather vote for adjusting it automatically with the note color (possibly allowing e.g. Black on yellow and Red on yellow as separate options if we think both make sense). That would also ensure could contrast. So, long story short: I am against offering any font settings for the Plasmoid as such. Kai Uwe Broulik wrote: Why not adjusting the size automatically so that the text always fills the whole widget? Because I might place a lot of stuff into a note or just little. I want to have the control over the sizing to not have it look odd when I have 10 sticky notes, all with different size. I do make them huge if I want huge size but I wouldn't want an auto size. As for the font color: I'd rather vote for adjusting it automatically with the note color The font is black (well, very dark gray) by default and white for the black sticky note. possibly allowing e.g. Black on yellow and Red on yellow as separate options ? Because I might place a lot of stuff into a note or just little. I want to have the control over the sizing to not have it look odd when I have 10 sticky notes, all with different size. I do make them huge if I want huge size but I wouldn't want an auto size. Having font style (bold etc.) in the editor, size and color in the config and font family nowhere is still very inconsistent and confusing. Why not just putting text size, color and font family all in the editor, then? That way you can also use different sizes within the same note. possibly allowing e.g. Black on yellow and Red on yellow as separate options ? What I meant was that you'd not just set the background color to e.g. yellow and then the text color would automatically adjust, but if we assumed some people liked black text on yellow background and others liked red text on yellow background, we could offer both combinations in the color selection. If we allow setting the text color manually in the editor, though, this would not be necessary anymore. Bottom line: We need something more consistent than what you had in mind. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124246/#review82080 --- On July 4, 2015, 11:43 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124246/ --- (Updated July 4, 2015, 11:43 a.m.) Review request for Plasma and KDE Usability. Repository: kdeplasma-addons Description --- This patch adds the following improvements to the sticky notes applet: - A config dialog with previews of the individual colors, the ability to change the font size, and font color - are there any other important options the 4.x one had? - Ctrl+Mousewheel to change font size, I always used this feature in 4.x and
Re: Review Request 124236: More sensible sizing for containment configuration
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124236/#review82138 --- Ship it! Ship It! - Bhushan Shah On July 3, 2015, 12:24 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124236/ --- (Updated July 3, 2015, 12:24 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- That dialog is pretty tall on laptops and can hardly be resized any smaller. This gives it a sensible minimum size and keeps the preferred at the old value Diffs - desktoppackage/contents/configuration/ContainmentConfiguration.qml 09a4d22 Diff: https://git.reviewboard.kde.org/r/124236/diff/ Testing --- Nuked my plasma config, dialog looked nice initially but I could make it smaller for my preference. Please #lowdpi people test Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
