Re: Review Request 124388: Add ConsoleKit2 as a power backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82678 --- May I ask you a favor? Could you please try whether you can get kwin_wayland (drm/libinput) to work with consolekit2? That would be totally awesome! Of course I'm also interested in consolekit2 addons to screen locker if there are changes needed to get the same level of integration as with logind (it currently listens to logind for lock/unlock signals and inhibits suspend to ensure the lock screen is in place before the system goes to sleep state). - Martin Gräßlin On July 19, 2015, 11:22 a.m., Eric Koegel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated July 19, 2015, 11:22 a.m.) Review request for Plasma and Solid. Repository: powerdevil Description --- Internally, it uses the login1 interface with ConsoleKit2 since they share identical DBUS calls. It also changes the setupSystemdInhibition to setupSeatManagerInhibition so that the login1 and ConsoleKit2 inhibit calls to minimize code duplication. This patch doesn't modify the build system to keep it small. A future patch can be added to use ConsoleKit2 on BSD systems as well. ConsoleKit2's suspend/hibernate/inhibit DBUS API is documented at: http://consolekit2.github.io/ConsoleKit2/#Manager Diffs - daemon/backends/upower/powerdevilupowerbackend.h 1c4dd59 daemon/backends/upower/powerdevilupowerbackend.cpp 87b9cc7 daemon/powerdevilpolicyagent.h ef41ad7 daemon/powerdevilpolicyagent.cpp 9210a06 Diff: https://git.reviewboard.kde.org/r/124388/diff/ Testing --- Built powerdevil with patch and pkla files on a Gentoo system with OpenRC. Before patch there was no suspend option, after there was and clicking it resulted in the system properly suspending. Thanks, Eric Koegel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124380: Make System Tray use a ProxyModel rather than three independent ones
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124380/ --- (Updated July 20, 2015, 8:26 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit e64d41cc2fe549e4efcb60c7561dd83648294903 by Kai Uwe Broulik to branch master. Bugs: 347554 https://bugs.kde.org/show_bug.cgi?id=347554 Repository: plasma-workspace Description --- This makes System Tray use the all tasks model with a proxy model that filters shown or hidden tasks. This way we don't need to keep three different models in sync which has shown to often break, especially when item status change. Makes the code significantly easier to understand. One thing I noticed is that there doesn't seem to be a way for a plasmoid to specify a category, so when I uncheck Miscellaneous, all items but KMix (which is in the hardware category) disappear. Since we're moving away from most SNI apps to plasmoids, it would make sense to allow an applet so specify a category (either through Plasmoid attached object or in the desktop file (or we do a mapping from the PluginInfo-Categories to sys tray categories)) Edit: Tried the PluginInfo-Categories mapping but it doesn't really fit. Eg. Battery is System information but should show up in the Hardware category or systray, likewise for Device NOtifier, and many other systray applets. Diffs - applets/systemtray/package/contents/ui/CompactRepresentation.qml 3cf774c applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 04de968 applets/systemtray/package/contents/ui/main.qml 34b9e4d applets/systemtray/plugin/CMakeLists.txt 9e85a7a applets/systemtray/plugin/host.h adb2c64 applets/systemtray/plugin/host.cpp 6d68a43 applets/systemtray/plugin/systemtrayplugin.cpp 2c97056 applets/systemtray/plugin/tasksproxymodel.h PRE-CREATION applets/systemtray/plugin/tasksproxymodel.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124380/diff/ Testing --- - Checking and unchecking show all items works - Forcing various items shown/hidden works - An item changing its state (eg. new notification, goes from passive to active) works - Both lists (compact and expanded) look fine - Arrow properly appears/disappears depending on how many inactive items there are Touchpad kcm no longer messes up my systray. Looks like the same bug mediacontroller exposed, where the applet was briefly active during initialization and then went passive, getting the models ouf of sync. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124382: RFC: Allow plasmoid to specify X-Plasma-NotificationAreaCategory
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124382/#review82688 --- Ship it! at some point in kde4 it did try to guess it from the actual applet category, but wasn't an exact 1:1 map - Marco Martin On July 18, 2015, 5:50 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124382/ --- (Updated July 18, 2015, 5:50 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will allow a plasmoid to specify a category similar to SNIs, so we we can have KTP in the Communications category, Battery and Device Notifier under Hardware, Clipboard as SystemServices, etc. Diffs - applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 92b95d7 Diff: https://git.reviewboard.kde.org/r/124382/diff/ Testing --- Needs property def in plasma-framework but other than that the applets are now sorted differently (communication - hardware - system services - applications - misc) and hiding individual categories makes some of them disappear. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124404: kpackagetool: Fix output of non-latin text to stdout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- kpackagetool: Fix output of non-latin text to stdout Diffs - src/kpackagetool/kpackagetool.cpp 16d3f0268788d3cefff86542359e8416388542a9 Diff: https://git.reviewboard.kde.org/r/124404/diff/ Testing --- `kpackagetool5 --list-types` now has readable output with Russian localization. Thanks, Alexander Potashev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? Bernhard Friedreich wrote: that should be possible yes.. but shouldn't it also work like this? I think you are supposed to just add TranslationSystem=kde and TranslationDomain=your-translation-domain into the kcfgc file and the rest is automagic. Emphasizes on the think. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/#review82655 --- On July 19, 2015, 4:25 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- (Updated July 19, 2015, 4:25 p.m.) Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? Bernhard Friedreich wrote: that should be possible yes.. but shouldn't it also work like this? Martin Klapetek wrote: I think you are supposed to just add TranslationSystem=kde and TranslationDomain=your-translation-domain into the kcfgc file and the rest is automagic. Emphasizes on the think. ...and then you should use label.../label or text.../text. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/#review82655 --- On July 19, 2015, 4:25 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- (Updated July 19, 2015, 4:25 p.m.) Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/#review82708 --- This is rather surprising. How does it compile? std::cout doesn't have operator for QString, and QString's implicit conversion to char * is disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the first place). I'm pretty sure that toLocal8Bit().constData() is the proper way to give a QString to cout/cerr... - David Faure On July 20, 2015, 12:11 p.m., Alexander Potashev wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- (Updated July 20, 2015, 12:11 p.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- kpackagetool: Fix output of non-latin text to stdout Diffs - src/kpackagetool/kpackagetool.cpp 16d3f0268788d3cefff86542359e8416388542a9 Diff: https://git.reviewboard.kde.org/r/124404/diff/ Testing --- `kpackagetool5 --list-types` now has readable output with Russian localization. Thanks, Alexander Potashev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout
On July 20, 2015, 12:32 p.m., David Faure wrote: This is rather surprising. How does it compile? std::cout doesn't have operator for QString, and QString's implicit conversion to char * is disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the first place). I'm pretty sure that toLocal8Bit().constData() is the proper way to give a QString to cout/cerr... Aleix Pol Gonzalez wrote: Well QDebug can provide it quite easily, which is what I assumed. Otherwise, maybe converting toStdString would be better...? Alexander Potashev wrote: Please see this definition at the beginning of the .cpp file: static QTextStream cout(stdout); Ah! I was afraid of that. It's not std::cout, it's a local (unicode-aware) cout :-) Confusing naming. The patch is definitely correct then, ship it. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/#review82708 --- On July 20, 2015, 12:11 p.m., Alexander Potashev wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- (Updated July 20, 2015, 12:11 p.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- kpackagetool: Fix output of non-latin text to stdout Diffs - src/kpackagetool/kpackagetool.cpp 16d3f0268788d3cefff86542359e8416388542a9 Diff: https://git.reviewboard.kde.org/r/124404/diff/ Testing --- `kpackagetool5 --list-types` now has readable output with Russian localization. Thanks, Alexander Potashev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- (Updated July 20, 2015, 12:59 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 695abb02fe1c9bc5e485a5841db6312e4beb2e76 by Alexander Potashev to branch master. Repository: kpackage Description --- kpackagetool: Fix output of non-latin text to stdout Diffs - src/kpackagetool/kpackagetool.cpp 16d3f0268788d3cefff86542359e8416388542a9 Diff: https://git.reviewboard.kde.org/r/124404/diff/ Testing --- `kpackagetool5 --list-types` now has readable output with Russian localization. Thanks, Alexander Potashev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/#review82704 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 20, 2015, 2:11 p.m., Alexander Potashev wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- (Updated July 20, 2015, 2:11 p.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- kpackagetool: Fix output of non-latin text to stdout Diffs - src/kpackagetool/kpackagetool.cpp 16d3f0268788d3cefff86542359e8416388542a9 Diff: https://git.reviewboard.kde.org/r/124404/diff/ Testing --- `kpackagetool5 --list-types` now has readable output with Russian localization. Thanks, Alexander Potashev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124382: RFC: Allow plasmoid to specify X-Plasma-NotificationAreaCategory
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124382/ --- (Updated July 20, 2015, 12:17 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 85450ade844e1d1657028c6db9ea96f2a2e7af1e by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- This will allow a plasmoid to specify a category similar to SNIs, so we we can have KTP in the Communications category, Battery and Device Notifier under Hardware, Clipboard as SystemServices, etc. Diffs - applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 92b95d7 Diff: https://git.reviewboard.kde.org/r/124382/diff/ Testing --- Needs property def in plasma-framework but other than that the applets are now sorted differently (communication - hardware - system services - applications - misc) and hiding individual categories makes some of them disappear. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout
On July 20, 2015, 2:32 p.m., David Faure wrote: This is rather surprising. How does it compile? std::cout doesn't have operator for QString, and QString's implicit conversion to char * is disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the first place). I'm pretty sure that toLocal8Bit().constData() is the proper way to give a QString to cout/cerr... Well QDebug can provide it quite easily, which is what I assumed. Otherwise, maybe converting toStdString would be better...? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/#review82708 --- On July 20, 2015, 2:11 p.m., Alexander Potashev wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- (Updated July 20, 2015, 2:11 p.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- kpackagetool: Fix output of non-latin text to stdout Diffs - src/kpackagetool/kpackagetool.cpp 16d3f0268788d3cefff86542359e8416388542a9 Diff: https://git.reviewboard.kde.org/r/124404/diff/ Testing --- `kpackagetool5 --list-types` now has readable output with Russian localization. Thanks, Alexander Potashev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout
On Июль 20, 2015, 12:32 п.п., David Faure wrote: This is rather surprising. How does it compile? std::cout doesn't have operator for QString, and QString's implicit conversion to char * is disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the first place). I'm pretty sure that toLocal8Bit().constData() is the proper way to give a QString to cout/cerr... Aleix Pol Gonzalez wrote: Well QDebug can provide it quite easily, which is what I assumed. Otherwise, maybe converting toStdString would be better...? Please see this definition at the beginning of the .cpp file: static QTextStream cout(stdout); - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/#review82708 --- On Июль 20, 2015, 12:11 п.п., Alexander Potashev wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- (Updated Июль 20, 2015, 12:11 п.п.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- kpackagetool: Fix output of non-latin text to stdout Diffs - src/kpackagetool/kpackagetool.cpp 16d3f0268788d3cefff86542359e8416388542a9 Diff: https://git.reviewboard.kde.org/r/124404/diff/ Testing --- `kpackagetool5 --list-types` now has readable output with Russian localization. Thanks, Alexander Potashev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124388: Add ConsoleKit2 as a power backend
On July 20, 2015, 6:22 a.m., Martin Gräßlin wrote: May I ask you a favor? Could you please try whether you can get kwin_wayland (drm/libinput) to work with consolekit2? That would be totally awesome! Of course I'm also interested in consolekit2 addons to screen locker if there are changes needed to get the same level of integration as with logind (it currently listens to logind for lock/unlock signals and inhibits suspend to ensure the lock screen is in place before the system goes to sleep state). Yes, wayland support and multi-seat are the two big things I'd like to accomplish for consolekit2. I'll look into wayland next since there seems to be more demand for that. And yes, I can look into patching the screenlocker as well. - Eric --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82678 --- On July 20, 2015, 2:04 p.m., Eric Koegel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated July 20, 2015, 2:04 p.m.) Review request for Plasma and Solid. Repository: powerdevil Description --- Internally, it uses the login1 interface with ConsoleKit2 since they share identical DBUS calls. It also changes the setupSystemdInhibition to setupSeatManagerInhibition so that the login1 and ConsoleKit2 inhibit calls to minimize code duplication. This patch doesn't modify the build system to keep it small. A future patch can be added to use ConsoleKit2 on BSD systems as well. ConsoleKit2's suspend/hibernate/inhibit DBUS API is documented at: http://consolekit2.github.io/ConsoleKit2/#Manager Diffs - daemon/backends/upower/powerdevilupowerbackend.h 3752977 daemon/backends/upower/powerdevilupowerbackend.cpp 5120d3e daemon/powerdevilpolicyagent.h ef41ad7 daemon/powerdevilpolicyagent.cpp 9210a06 Diff: https://git.reviewboard.kde.org/r/124388/diff/ Testing --- Built powerdevil with patch and pkla files on a Gentoo system with OpenRC. Before patch there was no suspend option, after there was and clicking it resulted in the system properly suspending. Thanks, Eric Koegel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124388: Add ConsoleKit2 as a power backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated July 20, 2015, 2:04 p.m.) Review request for Plasma and Solid. Changes --- Rebased on master, removed consolekit2InhibitFd. When trying to consolidate the code I noticed that daemon/actions/bundled/suspendsession.cpp calls setupSystemdInhibition and we can't easily pass in the QDBusInterface there so I promoted the managerIface to a member variable that could then be used. Repository: powerdevil Description --- Internally, it uses the login1 interface with ConsoleKit2 since they share identical DBUS calls. It also changes the setupSystemdInhibition to setupSeatManagerInhibition so that the login1 and ConsoleKit2 inhibit calls to minimize code duplication. This patch doesn't modify the build system to keep it small. A future patch can be added to use ConsoleKit2 on BSD systems as well. ConsoleKit2's suspend/hibernate/inhibit DBUS API is documented at: http://consolekit2.github.io/ConsoleKit2/#Manager Diffs (updated) - daemon/backends/upower/powerdevilupowerbackend.h 3752977 daemon/backends/upower/powerdevilupowerbackend.cpp 5120d3e daemon/powerdevilpolicyagent.h ef41ad7 daemon/powerdevilpolicyagent.cpp 9210a06 Diff: https://git.reviewboard.kde.org/r/124388/diff/ Testing --- Built powerdevil with patch and pkla files on a Gentoo system with OpenRC. Before patch there was no suspend option, after there was and clicking it resulted in the system properly suspending. Thanks, Eric Koegel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124388: Add ConsoleKit2 as a power backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82731 --- Thanks! daemon/backends/upower/powerdevilupowerbackend.cpp (line 141) https://git.reviewboard.kde.org/r/124388/#comment57051 if (!m_login1Interface …) - Kai Uwe Broulik On Juli 20, 2015, 2:04 nachm., Eric Koegel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated Juli 20, 2015, 2:04 nachm.) Review request for Plasma and Solid. Repository: powerdevil Description --- Internally, it uses the login1 interface with ConsoleKit2 since they share identical DBUS calls. It also changes the setupSystemdInhibition to setupSeatManagerInhibition so that the login1 and ConsoleKit2 inhibit calls to minimize code duplication. This patch doesn't modify the build system to keep it small. A future patch can be added to use ConsoleKit2 on BSD systems as well. ConsoleKit2's suspend/hibernate/inhibit DBUS API is documented at: http://consolekit2.github.io/ConsoleKit2/#Manager Diffs - daemon/backends/upower/powerdevilupowerbackend.h 3752977 daemon/backends/upower/powerdevilupowerbackend.cpp 5120d3e daemon/powerdevilpolicyagent.h ef41ad7 daemon/powerdevilpolicyagent.cpp 9210a06 Diff: https://git.reviewboard.kde.org/r/124388/diff/ Testing --- Built powerdevil with patch and pkla files on a Gentoo system with OpenRC. Before patch there was no suspend option, after there was and clicking it resulted in the system properly suspending. Thanks, Eric Koegel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82734 --- Ship it! Ship It! - Jens Reuterberg On juli 20, 2015, 8:19 e.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated juli 20, 2015, 8:19 e.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124388: Add ConsoleKit2 as a power backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82730 --- Looks good to me. Do you have commit access? daemon/powerdevilpolicyagent.cpp (line 175) https://git.reviewboard.kde.org/r/124388/#comment57050 just pass a parent, rather than manual deletion in the destructor? OR wrap in QScopedPointer instead of QWeakPointer? otherwise you have potential leak if onSessionHandlerRegistered is called twice (not that will realistically happen) - David Edmundson On July 20, 2015, 2:04 p.m., Eric Koegel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated July 20, 2015, 2:04 p.m.) Review request for Plasma and Solid. Repository: powerdevil Description --- Internally, it uses the login1 interface with ConsoleKit2 since they share identical DBUS calls. It also changes the setupSystemdInhibition to setupSeatManagerInhibition so that the login1 and ConsoleKit2 inhibit calls to minimize code duplication. This patch doesn't modify the build system to keep it small. A future patch can be added to use ConsoleKit2 on BSD systems as well. ConsoleKit2's suspend/hibernate/inhibit DBUS API is documented at: http://consolekit2.github.io/ConsoleKit2/#Manager Diffs - daemon/backends/upower/powerdevilupowerbackend.h 3752977 daemon/backends/upower/powerdevilupowerbackend.cpp 5120d3e daemon/powerdevilpolicyagent.h ef41ad7 daemon/powerdevilpolicyagent.cpp 9210a06 Diff: https://git.reviewboard.kde.org/r/124388/diff/ Testing --- Built powerdevil with patch and pkla files on a Gentoo system with OpenRC. Before patch there was no suspend option, after there was and clicking it resulted in the system properly suspending. Thanks, Eric Koegel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82732 --- Nice! +1 from me. - Andrew Lake On July 20, 2015, 8:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 8:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124408: Make PlasmaCore.Dialog opacity work
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/ --- Review request for Plasma. Repository: plasma-framework Description --- Dialog inherits from QQuickWindow which inherits from QWindow which has an opacity property. Unfortunately, opacity has a REVISION 1 attached to it but there doesn't seem to be a way to tell it hey, inherit Foo but please revision 1 so it says opacity is not available in plasma.core 2.0. qmlRegisterType() which you can usually use to register internal stuff doesn't have a second template parameter... Diffs - src/declarativeimports/core/corebindingsplugin.cpp 7aaba35 Diff: https://git.reviewboard.kde.org/r/124408/diff/ Testing --- I can now adjust dialog opacity. Is there anybody that thoroughly understands the QML versioning stuff? Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Kio.KRun Segmentation fault in plasma2 widget
I posted this message to the plasma5 forum
(https://forum.kde.org/viewtopic.php?f=289t=127322) and an administrator
replied to write here too.
I'm playing with plasma widget development, I am currently trying to write a
widget to launch a .desktop file. I have some problems finding the
documentation but finally I found a way to launch a program looking in the
official SystemLoadViewer sources.
[kdeplasma-addons.git] / applets / systemloadviewer / package / contents / ui
/ SystemLoadViewer.qml
Initialization at line 79 and launch at line 238.
Watching the program run I undestand that
kRun.openUrl()
accepts a string representing a file to be opened with the default associated
application or a .desktop file to launch.
I tested with various files:
- Copy-paste from the example to launch sysguard with the url obtained from
the apps DataSource: WORKS
- Using the url /usr/share/applications/org.kde.ksysguard.desktop (it is the
same string returned by the apps DataSource): WORKS
- If I try with another .desktop file inside my home folder: SEGFAULT
- If I copy the file org.kde.ksysguard.desktop in another directory and try
with the new path: SEGFAULT
- If I try to execute a bash script: WORKS
- Using the url of a PDF file will open the file with Okular: WORKS
- Using the url of a binary application /usr/bin/ksysguard don't work and
the openUrl() function returns an error value. No segfault so I think
this
is the expected behaviour.
I tested the widget directly in my plasma desktop and also using
plasmawindowed. The segfault happen in both cases but with the former I can
see the console log.
Even if I am feeding the wrong data to the function I don't think the segfault
is the expected behaviour. Maybe someone more expert can take a loot at this
problem.
I'm using:
- updated kubuntu 15.04.
- Qt: 5.4.1
- KDE Frameworks: 5.9.0
- Plasma version 5.3.1.
I'm available to give more info if needed.
Here ends the maybe important stuff, the following is a newbie question.
I don't know if this is the correct place for this but I'm still searching a
solution for the original problem.
If I can't launch an executable this way maybe this isn't the correct
function. I am unable to find a documentation or source code for the QML
implementation of Kio.KRun. Inspecting the properties with javascript shows
only three properties:
- objectName =
- objectNameChanged = function() { [code] }
- openUrl = function() { [code] }
So openUrl() appears to be the only function available, maybe KRun it's the
wrong tool.
I found the interesting Plasma2 / Service but I don't know how to find the
available DataSource ID's and the operationDescription. I'm currently stuck
and need some direction.
Thanks for the help.
--
Nicola Felice
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 350434] New: SDDM theme does not use Breeze user icons
https://bugs.kde.org/show_bug.cgi?id=350434 Bug ID: 350434 Summary: SDDM theme does not use Breeze user icons Product: Breeze Version: 5.3.2 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: kamika...@web.de Compare http://static.davidedmundson.co.uk/blog/display_managers_finale/breeze_login_screen.png to http://i1-news.softpedia-static.com/images/news2/KDE-Plasma-5-1-0-Brings-Back-Some-Old-Features-462226-6.jpg The user image in the first screenshot is not the Breeze one. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 350434] SDDM theme does not use Breeze user icons
https://bugs.kde.org/show_bug.cgi?id=350434 Markus S. kamika...@web.de changed: What|Removed |Added CC||kamika...@web.de, ||k...@davidedmundson.co.uk --- Comment #1 from Markus S. kamika...@web.de --- CC'ing David as he's listed as the author. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82738 --- lookandfeel/contents/osd/Osd.qml (line 48) https://git.reviewboard.kde.org/r/124409/#comment57055 This looks like a random wait time... Looking at the video, it seems like a slow animation. Is it intended? - Aleix Pol Gonzalez On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
