Re: Review Request 124647: Cmake fail to parse proper taglib version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/#review83759 --- Do you have commit rights or you want me to commit it for you? - Bhushan Shah On Aug. 7, 2015, 2:31 p.m., Luca Sartorelli wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/ --- (Updated Aug. 7, 2015, 2:31 p.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- taglib 1.4 is requested to build plasma-mediacenter but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the test failure Diffs - cmake/FindTaglib.cmake c23d582 Diff: https://git.reviewboard.kde.org/r/124647/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed and plasma-mediacenter succesfully build Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124647: Cmake fail to parse proper taglib version
On Aug. 13, 2015, 7:08 a.m., Bhushan Shah wrote: Do you have commit rights or you want me to commit it for you? Can you do it please, I don't have commit rigths. Thanks - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/#review83759 --- On Aug. 7, 2015, 9:01 a.m., Luca Sartorelli wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/ --- (Updated Aug. 7, 2015, 9:01 a.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- taglib 1.4 is requested to build plasma-mediacenter but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the test failure Diffs - cmake/FindTaglib.cmake c23d582 Diff: https://git.reviewboard.kde.org/r/124647/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed and plasma-mediacenter succesfully build Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124727: Documentation for PlasmaComponents Menu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/ --- Review request for Plasma. Repository: plasma-framework Description --- Add documentation for declarative menu (PlasmaComponents.Menu) Diffs - src/declarativeimports/plasmacomponents/qmenu.h 6cf0096 Diff: https://git.reviewboard.kde.org/r/124727/diff/ Testing --- Thanks, Leszek Lesner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Mobile Vision, intended personas meeting notes
So it seems the general consensus is that it's good, there were only different opinions about the unlike Android bit, so I've removed that now. Thomas is right that this doesn't warrant different versions around, and I'd rather have one clear statement which is generally agreed on than different versions. Also, I don't think the unlike Android qualification is all that important, so let's just scratch it. We want to finalize this and move on and build on it, so please have another look over it, check if everything's OK, if the wording should be fixed somewhere, and so on. This is what stands right now: On Monday, August 10, 2015 22:00:59 Jens Reuterberg wrote: VISION STATEMENT: Plasma Mobile aims to become a complete software system for mobile devices. It is designed to give privacy-aware users back the full-control over their information and communication. Plasma Mobile takes a pragmatic approach and is inclusive to 3rd party software, allowing the user to choose which applications and services to use. It provides a seamless experience across multiple devices. Plasma Mobile implements open standards, and it is developed in a transparent process that is open for the community to participate in. If it's OK with everybody let's declare it final for the time being (we can always decide to change it in the future of course), and move on to things like personas, HIG, etc., tasks which depend on having this vision statement. Also, this is not an easy thing to come up with and discuss, and I'm quite amazed how well we worked together in this process. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Aug 2015 10:56:47 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/38 (95%)CLASSES 36/38 (95%)LINE 2370/3410 (70%)CONDITIONAL 1784/3081 (58%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 18/34 (53%) kcms.keyboard FILES 20/22 (91%)CLASSES 20/22 (91%)LINE 800/1526 (52%)CONDITIONAL 771/1270 (61%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 511/994 (51%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 242/364 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 108/178 (61%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 269/350 (77%)CONDITIONAL 82/137 (60%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 (100%)CONDITIONAL 52/104 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124727: Documentation for PlasmaComponents Menu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/#review83767 --- oh RB lost my comment src/declarativeimports/plasmacomponents/qmenu.h (line 115) https://git.reviewboard.kde.org/r/124727/#comment57972 It's a more common practice to say: This does X rather than This allows doing X - David Edmundson On Aug. 13, 2015, 11:31 a.m., Leszek Lesner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/ --- (Updated Aug. 13, 2015, 11:31 a.m.) Review request for Plasma. Repository: plasma-framework Description --- Add documentation for declarative menu (PlasmaComponents.Menu) Diffs - src/declarativeimports/plasmacomponents/qmenu.h 6cf0096 Diff: https://git.reviewboard.kde.org/r/124727/diff/ Testing --- Thanks, Leszek Lesner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124647: Cmake fail to parse proper taglib version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/ --- (Updated Aug. 13, 2015, 12:38 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-mediacenter Description --- taglib 1.4 is requested to build plasma-mediacenter but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the test failure Diffs - cmake/FindTaglib.cmake c23d582 Diff: https://git.reviewboard.kde.org/r/124647/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed and plasma-mediacenter succesfully build Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124727: Documentation for PlasmaComponents Menu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/#review83766 --- Ship it! Ship It! - David Edmundson On Aug. 13, 2015, 11:31 a.m., Leszek Lesner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/ --- (Updated Aug. 13, 2015, 11:31 a.m.) Review request for Plasma. Repository: plasma-framework Description --- Add documentation for declarative menu (PlasmaComponents.Menu) Diffs - src/declarativeimports/plasmacomponents/qmenu.h 6cf0096 Diff: https://git.reviewboard.kde.org/r/124727/diff/ Testing --- Thanks, Leszek Lesner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124727: Documentation for PlasmaComponents Menu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/ --- (Updated Aug. 13, 2015, 12:44 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit a7b438ece49547be07ea10c1ed3e06dd92591967 by David Edmundson on behalf of Leszek Lesner to branch master. Repository: plasma-framework Description --- Add documentation for declarative menu (PlasmaComponents.Menu) Diffs - src/declarativeimports/plasmacomponents/qmenu.h 6cf0096 Diff: https://git.reviewboard.kde.org/r/124727/diff/ Testing --- Thanks, Leszek Lesner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124647: Cmake fail to parse proper taglib version
On Aug. 13, 2015, 12:38 p.m., Bhushan Shah wrote: Do you have commit rights or you want me to commit it for you? Luca Sartorelli wrote: Can you do it please, I don't have commit rigths. Thanks Submitted with http://commits.kde.org/plasma-mediacenter/4c242b2e04dbe6aaba5bd0766f2f5c9ebb8b23b3 Forgot to add REVIEW tag in commit message, can you close this review? - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/#review83759 --- On Aug. 7, 2015, 2:31 p.m., Luca Sartorelli wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/ --- (Updated Aug. 7, 2015, 2:31 p.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- taglib 1.4 is requested to build plasma-mediacenter but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the test failure Diffs - cmake/FindTaglib.cmake c23d582 Diff: https://git.reviewboard.kde.org/r/124647/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed and plasma-mediacenter succesfully build Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Aug 2015 11:52:17 + Build duration: 17 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 14/14 (100%)FILES 61/71 (86%)CLASSES 61/71 (86%)LINE 2473/4040 (61%)CONDITIONAL 1468/2288 (64%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 302/422 (72%)CONDITIONAL 436/495 (88%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/149 (74%)CONDITIONAL 40/70 (57%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 (68%)CONDITIONAL 109/146 (75%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 377/742 (51%) ksmserver.screenlocker FILES 8/11 (73%)CLASSES 8/11 (73%)LINE 460/977 (47%)CONDITIONAL 140/219 (64%) ksmserver.screenlocker.autotests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 165/169 (98%)CONDITIONAL 65/124 (52%) ksmserver.screenlocker.greeter FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 99/144 (69%)CONDITIONAL 36/60 (60%) ksmserver.screenlocker.greeter.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 45/45 (100%)CONDITIONAL 34/68 (50%) libkworkspace FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 28/610 (5%)CONDITIONAL 23/39 (59%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/160 (54%)CONDITIONAL 34/56 (61%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 96/100 (96%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124728: Remove unused variable.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124728/ --- Review request for Plasma. Repository: libksysguard Description --- Seems to be unused since 931d7d4b64bbe39f75060f3e61198b5b0c1126f0. Diffs - signalplotter/ksignalplotter.cpp 7932c8ef564acb7b2549d256062de52c9ee053fb Diff: https://git.reviewboard.kde.org/r/124728/diff/ Testing --- Builds. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124730: [solid-device-automounter] Port to KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124730/#review83792 --- done the KCM. not looked at kded solid-device-automounter/kcm/CMakeLists.txt (line 7) https://git.reviewboard.kde.org/r/124730/#comment58019 you missed a thing solid-device-automounter/kcm/DeviceAutomounterKCM.cpp (line 59) https://git.reviewboard.kde.org/r/124730/#comment58020 someone didn't know you can connect a signal to a signal... (probably not your code, don't feel you have to change it) solid-device-automounter/kcm/DeviceModel.cpp (line 66) https://git.reviewboard.kde.org/r/124730/#comment58021 these layoutChanged bits don't belong here layoutChange is a sort of a mini modelReset() same for the rest of this class. solid-device-automounter/kcm/DeviceModel.cpp (line 100) https://git.reviewboard.kde.org/r/124730/#comment58022 this isn't right that's inserting two things into the model Maybe the layoutChanged was hiding it. - David Edmundson On Aug. 13, 2015, 7:48 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124730/ --- (Updated Aug. 13, 2015, 7:48 p.m.) Review request for Plasma, Solid and Torrie Fischer. Repository: plasma-desktop Description --- This is a straight port of the solid-device-automounter from kde-runtime that was somehow lost to plasma-desktop. I didn't do git graft magic (can this be done later? ie. import kde-runtime folder here to there and then apply a diff on top?). Diffs - CMakeLists.txt 4717780 solid-device-automounter/CMakeLists.txt PRE-CREATION solid-device-automounter/COPYING PRE-CREATION solid-device-automounter/SETTINGS PRE-CREATION solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION solid-device-automounter/kcm/DeviceModel.h PRE-CREATION solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION solid-device-automounter/kcm/Messages.sh PRE-CREATION solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION solid-device-automounter/kded/CMakeLists.txt PRE-CREATION solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION solid-device-automounter/kded/device_automounter.desktop PRE-CREATION solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124730/diff/ Testing --- Seems to work, translations are probably broken. Told it to auto mount all the things, did that. Told it to mount just one thing automatically, did that. Somehow the list of non-attached devices grows even when I re-attach the same device. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124728: Remove unused variable.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124728/#review83793 --- Ship it! Ship It! - David Edmundson On Aug. 13, 2015, 5:25 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124728/ --- (Updated Aug. 13, 2015, 5:25 p.m.) Review request for Plasma. Repository: libksysguard Description --- Seems to be unused since 931d7d4b64bbe39f75060f3e61198b5b0c1126f0. Diffs - signalplotter/ksignalplotter.cpp 7932c8ef564acb7b2549d256062de52c9ee053fb Diff: https://git.reviewboard.kde.org/r/124728/diff/ Testing --- Builds. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124509: Use small button for session combo
On Aug. 4, 2015, 12:22 a.m., Thomas Pfeiffer wrote: Thanks for taking this up so fast! Let me check back with our icon designers regarding whether this is the best icon for that button (it always looked more like a settings icon than a menu icon to me). Otherwise, the button seems fine. I assume the fact that in the screenshot, the height of the edit box and the login button are different is unrelated tot his patch, right? Kai Uwe Broulik wrote: Yes, that is unrelated but I think I should fix that too. Though it's probably just in test mode that the difference is as significant as in the screen shot. Please use the toolbar/application-menu icon for the button. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/#review83406 --- On Aug. 13, 2015, 8:09 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/ --- (Updated Aug. 13, 2015, 8:09 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- As discussed with the VDG since it's a more of a power user feature Diffs - lookandfeel/contents/loginmanager/Main.qml 065a115 Diff: https://git.reviewboard.kde.org/r/124509/diff/ Testing --- Work, I had to employ a hack to make the button stay square, and also ComboBox doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told where it should open other than the mouse position (also why is the text field not the same height as the login button?) File Attachments Login screen https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124586: Dismiss logout dialog when clicking outside
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124586/ --- (Updated Aug. 13, 2015, 8:15 nachm.) Review request for Plasma. Changes --- Incorporate logic from plasma dialog Repository: plasma-workspace Description --- Doesn't make sense to be able to interact with windows behind it, also prevents accidental logouts when you somehow lose the window behind some others and then forget about it. Diffs (updated) - ksmserver/shutdowndlg.h d534ff6 ksmserver/shutdowndlg.cpp 373c243 Diff: https://git.reviewboard.kde.org/r/124586/diff/ Testing --- Works Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124586: Dismiss logout dialog when clicking outside
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124586/ --- (Updated Aug. 13, 2015, 8:15 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- Doesn't make sense to be able to interact with windows behind it, also prevents accidental logouts when you somehow lose the window behind some others and then forget about it. Diffs - ksmserver/shutdowndlg.h d534ff6 ksmserver/shutdowndlg.cpp 373c243 Diff: https://git.reviewboard.kde.org/r/124586/diff/ Testing --- Works Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124730: [solid-device-automounter] Port to KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124730/ --- Review request for Plasma, Solid and Torrie Fischer. Repository: plasma-desktop Description --- This is a straight port of the solid-device-automounter from kde-runtime that was somehow lost to plasma-desktop. I didn't do git graft magic (can this be done later? ie. import kde-runtime folder here to there and then apply a diff on top?). Diffs - CMakeLists.txt 4717780 solid-device-automounter/CMakeLists.txt PRE-CREATION solid-device-automounter/COPYING PRE-CREATION solid-device-automounter/SETTINGS PRE-CREATION solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION solid-device-automounter/kcm/DeviceModel.h PRE-CREATION solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION solid-device-automounter/kcm/Messages.sh PRE-CREATION solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION solid-device-automounter/kded/CMakeLists.txt PRE-CREATION solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION solid-device-automounter/kded/device_automounter.desktop PRE-CREATION solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124730/diff/ Testing --- Seems to work, translations are probably broken. Told it to auto mount all the things, did that. Told it to mount just one thing automatically, did that. Somehow the list of non-attached devices grows even when I re-attach the same device. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124509: Use small button for session combo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/ --- (Updated Aug. 13, 2015, 8:08 nachm.) Review request for Plasma and KDE Usability. Changes --- Use ToolButton's menu property and attach a QQC Menu there. Unfortunately ExclusiveGroup's current property is a QQuickAction representing the menu action rather than the menu item itself hence I need to manually override the sessionIndex when the item becomes checked. Repository: plasma-workspace Description --- As discussed with the VDG since it's a more of a power user feature Diffs (updated) - lookandfeel/contents/loginmanager/Main.qml 065a115 Diff: https://git.reviewboard.kde.org/r/124509/diff/ Testing --- Work, I had to employ a hack to make the button stay square, and also ComboBox doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told where it should open other than the mouse position (also why is the text field not the same height as the login button?) File Attachments Login screen https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124509: Use small button for session combo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/ --- (Updated Aug. 13, 2015, 8:09 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- As discussed with the VDG since it's a more of a power user feature Diffs - lookandfeel/contents/loginmanager/Main.qml 065a115 Diff: https://git.reviewboard.kde.org/r/124509/diff/ Testing --- Work, I had to employ a hack to make the button stay square, and also ComboBox doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told where it should open other than the mouse position (also why is the text field not the same height as the login button?) File Attachments Login screen https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Mobile Vision, intended personas meeting notes
On Thursday, August 13, 2015, Sebastian Kügler se...@kde.org wrote: If it's OK with everybody let's declare it final for the time being +1 for it being final for the time being (now i'll get back being in places luckily without any pesky connectivity :p) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
