Arch based plasma-mobile image for x86_64
Hello! I am happy to announce First alpha release of Arch based plasma-phone image To start plasma-mobile write this ISO file to usb stick and boot from it. Once you have booted you will be autologged in the phablet user. Enter kwinwrapper command to start the plasma-mobile md5sum : e7e47084b3e91a33a1257037dc528532 shasum : 22d8bf84aae11ee961fad3524e3d20ca6ea535bd Errata: - Less applications : this image is served as PoC currently and not all applications you see in Plasma mobile are included. But next release will have new applications - After sometime session soft-panics, this is due to less space available. Currently I enforce cow_spacesize to 2G but however this seems not to work more investigation under progress. - Autostart of plasma-mobile disabled : due to debugging purpose and above mentioned bug plasma-mobile session auto start is disabled and you have to enter kwinwrapper command to start plasma-mobile Bug reports and feature requests welcome : https://github.com/bhush9/plasma-arch/issues Enjoy! Next release on next Sunday, hopefully! :) Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Arch based plasma-mobile image for x86_64
On Sat, Aug 22, 2015 at 8:03 AM, Bhushan Shah bhus...@gmail.com wrote: Hello! I am happy to announce First alpha release of Arch based plasma-phone image To start plasma-mobile write this ISO file to usb stick and boot from it. Once you have booted you will be autologged in the phablet user. Enter kwinwrapper command to start the plasma-mobile md5sum : e7e47084b3e91a33a1257037dc528532 shasum : 22d8bf84aae11ee961fad3524e3d20ca6ea535bd Sorry forgot to add link http://arch.pangea.pub/ISO/plasma-mobile/ -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.4.0
kwin updated tda href=http://download.kde.org/stable/plasma/5.4.0/plasma-workspace-5.4.0.tar.xz;plasma-workspace-5.4.0/a/td td align=right6.6MB/td - tdtt46d44ee475c4ac9969fc84d64733458b0c8752d8a026f82cd83eee0299fc0982/tt/td + tdtt4cb906bb01f9e422cbbab22bc7b7563010a6eb4ef3867b8a2cf7fbfbab890de5/tt/td c++ is nuts https://quickgit.kde.org/?p=kwin.gita=commith=abc3c633f3829686a042bb93cda0a2cc61de51cb Jonathan On Thu, Aug 20, 2015 at 05:27:17PM +0100, Jonathan Riddell wrote: Tars are up now on depot for 5.4.0, release is due on Tuesday https://www.kde.org/info/plasma-5.4.0.php Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124867: RTL support in login manager and lock screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124867/ --- Review request for Plasma. Repository: plasma-workspace Description --- Needs a fix in combobox to look good, so will target master so we have latest frameworks. BUG: 351534 Diffs - lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 lookandfeel/contents/loginmanager/Main.qml 065a11566fcb9177ebe24155be61b0e39f0395b2 Diff: https://git.reviewboard.kde.org/r/124867/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124867: RTL support in login manager and lock screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124867/#review84143 --- +1 lookandfeel/contents/lockscreen/LockScreen.qml (line 46) https://git.reviewboard.kde.org/r/124867/#comment58263 === - Kai Uwe Broulik On Aug. 21, 2015, 1:37 nachm., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124867/ --- (Updated Aug. 21, 2015, 1:37 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- Needs a fix in combobox to look good, so will target master so we have latest frameworks. BUG: 351534 Diffs - lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 lookandfeel/contents/loginmanager/Main.qml 065a11566fcb9177ebe24155be61b0e39f0395b2 Diff: https://git.reviewboard.kde.org/r/124867/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124871: Fix opening krunner by typing on empty desktop
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124871/ --- (Updated Aug. 21, 2015, 8:18 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit d0469af1fb7ed39573d6e3c0eff048b1dbbb6289 by Kai Uwe Broulik to branch Plasma/5.4. Bugs: 347872 https://bugs.kde.org/show_bug.cgi?id=347872 Repository: plasma-workspace Description --- Let the event propagate first and if nobody accepted it we'll open KRunner Diffs - shell/desktopview.cpp aef828b Diff: https://git.reviewboard.kde.org/r/124871/diff/ Testing --- Typing into a sticky note does not bring up KRunner but typing after clicking an empty area works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Desktop Theme Details KCM
Hi all, I was just looking at the Desktop Theme Details KCM (System Settings → Workspace Design → Details) and figured it's of not much use anymore. Imho the way the interaction with it worked wasn't particularly good to begin with, suddenly creating a (Custom) theme when you edited another one, but the one you selected in the list above isn't neccessarily the theme you're using, etc. So, let's look at the options it offers: * Color Scheme: Kinda works but given it also influences the background contrast, conflicts with the dialog/panel backgrounds * Panel background: Doesn't always work (panel stays the same somtimes) * Kickoff: No effect? What should it change anyway, it's up to the applet (it changes dialogs/kickoff, if that is even used anymore..) * Task items: Completely screws up the task manager if I touch that * Widget background: Seems okay * Translucent background: also okay * Dialog background: doesn't do anything * Analog Clock: works, seems kinda valid usecase; though all other DEs I've seen just provide that in the clock itself * Sticky Notes: Dunno, should work, but then I haven't seen a theme with different sticky notes - we still use the Oxygen ones even now :) One thing I would like to see is a default color for the notes, so a dark theme can have black notes by default * Tooltip: doesn't do anything * Pager: seems to work * Run dialog: Given KRunner is a regular dialog nowadays doesn't do anything * Logout dialog: Provided by LNF theme anyway * Icons: Kinda works, mostly seems to affect only system tray, as most icons are provided by the overall icon theme What should we do with this thing? PS: Air and even more Oxygen Plasma theme are pretty broken, we should either fix them (especially task manager, potentially revert the follow theme color stuff to provide a more 4.x-esque look) or kill them. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124871: Fix opening krunner by typing on empty desktop
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124871/#review84159 --- Ship it! and now I understand why applets didn't seem to be handling the keys first like we discussed on IRC. Events go to the window object first before being dispatched to the activeFocusItem in QQuickWindow::keyPressEvent...good stuff! +100 - David Edmundson On Aug. 21, 2015, 6:24 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124871/ --- (Updated Aug. 21, 2015, 6:24 p.m.) Review request for Plasma. Bugs: 347872 https://bugs.kde.org/show_bug.cgi?id=347872 Repository: plasma-workspace Description --- Let the event propagate first and if nobody accepted it we'll open KRunner Diffs - shell/desktopview.cpp aef828b Diff: https://git.reviewboard.kde.org/r/124871/diff/ Testing --- Typing into a sticky note does not bring up KRunner but typing after clicking an empty area works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Desktop Theme Details KCM
My own opinion, having written the original code, is that we should simply remove it altogether. I consider it an extreme corner case for customization that, at best, belongs in a Plasma theme creation tool, not system settings. Andrew On Fri, Aug 21, 2015, 1:40 PM Kai Uwe Broulik k...@privat.broulik.de wrote: Hi all, I was just looking at the Desktop Theme Details KCM (System Settings → Workspace Design → Details) and figured it's of not much use anymore. Imho the way the interaction with it worked wasn't particularly good to begin with, suddenly creating a (Custom) theme when you edited another one, but the one you selected in the list above isn't neccessarily the theme you're using, etc. So, let's look at the options it offers: * Color Scheme: Kinda works but given it also influences the background contrast, conflicts with the dialog/panel backgrounds * Panel background: Doesn't always work (panel stays the same somtimes) * Kickoff: No effect? What should it change anyway, it's up to the applet (it changes dialogs/kickoff, if that is even used anymore..) * Task items: Completely screws up the task manager if I touch that * Widget background: Seems okay * Translucent background: also okay * Dialog background: doesn't do anything * Analog Clock: works, seems kinda valid usecase; though all other DEs I've seen just provide that in the clock itself * Sticky Notes: Dunno, should work, but then I haven't seen a theme with different sticky notes - we still use the Oxygen ones even now :) One thing I would like to see is a default color for the notes, so a dark theme can have black notes by default * Tooltip: doesn't do anything * Pager: seems to work * Run dialog: Given KRunner is a regular dialog nowadays doesn't do anything * Logout dialog: Provided by LNF theme anyway * Icons: Kinda works, mostly seems to affect only system tray, as most icons are provided by the overall icon theme What should we do with this thing? PS: Air and even more Oxygen Plasma theme are pretty broken, we should either fix them (especially task manager, potentially revert the follow theme color stuff to provide a more 4.x-esque look) or kill them. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124870: RTL support for Buttons and TabBar animation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124870/ --- Review request for Plasma. Repository: plasma-framework Description --- Button and ToolButton icon is now properly reversed as well as the TabBar animation (Eg. in Kickoff) now matches the Tab order Diffs - src/declarativeimports/plasmacomponents/qml/TabGroup.qml 277ca47 src/declarativeimports/plasmastyle/ButtonStyle.qml 23adbcb src/declarativeimports/plasmastyle/ToolButtonStyle.qml 4872477 Diff: https://git.reviewboard.kde.org/r/124870/diff/ Testing --- Works. I was wondering if we should place a LayoutMirroring enabled/childrenInherit into our containments or applet appearance and what not? Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124869: Fix widget explorer sometimes opening on the wrong side of the screen.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124869/ --- Review request for Plasma. Repository: plasma-desktop Description --- Work around a Qt bug. If there is no setGeometry call on QWindow the XCB backend will not pass our requested position to kwin as our window position tends to be 0, setX,setY no-ops and means we never set a position as far as QWindow is concerned by setting it to something silly and setting it back before we show the window we avoid that bug. Qt patch also filed (https://codereview.qt-project.org/123989) so hopefully this can be removed in future if that gets merged. BUG: 332702 Diffs - desktoppackage/contents/views/Desktop.qml e52108c7f2a4fd58a74642d09893c51fbf701f55 Diff: https://git.reviewboard.kde.org/r/124869/diff/ Testing --- Had a billion lines of qDebug in kwin that shows it now gets a geometry in KWin::manage. Also window is always in the right place \o/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124871: Fix opening krunner by typing on empty desktop
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124871/ --- Review request for Plasma. Bugs: 347872 https://bugs.kde.org/show_bug.cgi?id=347872 Repository: plasma-workspace Description --- Let the event propagate first and if nobody accepted it we'll open KRunner Diffs - shell/desktopview.cpp aef828b Diff: https://git.reviewboard.kde.org/r/124871/diff/ Testing --- Typing into a sticky note does not bring up KRunner but typing after clicking an empty area works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124872: Default to Breeze colors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84166 --- Ship it! Ship It! - Jeremy Whiting On Aug. 21, 2015, 3:35 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- (Updated Aug. 21, 2015, 3:35 p.m.) Review request for KDE Frameworks, Plasma and KDE Usability. Bugs: 351530 https://bugs.kde.org/show_bug.cgi?id=351530 Repository: kconfigwidgets Description --- This makes KColorScheme return Breeze colors by default, ie. choosing Default in Colors KCM is no longer Oxygen. Diffs - src/kcolorscheme.cpp f1ec1e3 Diff: https://git.reviewboard.kde.org/r/124872/diff/ Testing --- Seems to look right, typos reserved :) Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124872: Default to Breeze colors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84164 --- Maybe add a comment saying where these numbers come from? - Albert Astals Cid On ago. 21, 2015, 9:23 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- (Updated ago. 21, 2015, 9:23 p.m.) Review request for KDE Frameworks, Plasma and KDE Usability. Repository: kconfigwidgets Description --- This makes KColorScheme return Breeze colors by default, ie. choosing Default in Colors KCM is no longer Oxygen. Diffs - src/kcolorscheme.cpp f1ec1e3 Diff: https://git.reviewboard.kde.org/r/124872/diff/ Testing --- Seems to look right, typos reserved :) Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124872: Default to Breeze colors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- (Updated Aug. 21, 2015, 9:35 nachm.) Review request for KDE Frameworks, Plasma and KDE Usability. Changes --- Add comment as to where the numbers come from Bugs: 351530 https://bugs.kde.org/show_bug.cgi?id=351530 Repository: kconfigwidgets Description --- This makes KColorScheme return Breeze colors by default, ie. choosing Default in Colors KCM is no longer Oxygen. Diffs (updated) - src/kcolorscheme.cpp f1ec1e3 Diff: https://git.reviewboard.kde.org/r/124872/diff/ Testing --- Seems to look right, typos reserved :) Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124872: Default to Breeze colors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- (Updated Aug. 21, 2015, 9:23 nachm.) Review request for KDE Frameworks, Plasma and KDE Usability. Repository: kconfigwidgets Description (updated) --- This makes KColorScheme return Breeze colors by default, ie. choosing Default in Colors KCM is no longer Oxygen. Diffs - src/kcolorscheme.cpp f1ec1e3 Diff: https://git.reviewboard.kde.org/r/124872/diff/ Testing --- Seems to look right, typos reserved :) Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124872: Default to Breeze colors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- Review request for KDE Frameworks, Plasma and KDE Usability. Repository: kconfigwidgets Description --- This makes KColorScheme return Breeze colors by default. Diffs - src/kcolorscheme.cpp f1ec1e3 Diff: https://git.reviewboard.kde.org/r/124872/diff/ Testing --- Seems to look right, typos reserved :) Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124872: Default to Breeze colors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84163 --- Ship it! Ship It! - David Edmundson On Aug. 21, 2015, 9:23 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- (Updated Aug. 21, 2015, 9:23 p.m.) Review request for KDE Frameworks, Plasma and KDE Usability. Repository: kconfigwidgets Description --- This makes KColorScheme return Breeze colors by default, ie. choosing Default in Colors KCM is no longer Oxygen. Diffs - src/kcolorscheme.cpp f1ec1e3 Diff: https://git.reviewboard.kde.org/r/124872/diff/ Testing --- Seems to look right, typos reserved :) Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Desktop Theme Details KCM
On Friday, August 21, 2015 09:13:11 PM Andrew Lake wrote: My own opinion, having written the original code, is that we should simply remove it altogether. I consider it an extreme corner case for customization that, at best, belongs in a Plasma theme creation tool, not system settings. Andrew I agree but, with the caveat that we really should look into some way to get work on a theme creator tool underfoot somehow (I have no idea what the most sensible way to do that would be) On Fri, Aug 21, 2015, 1:40 PM Kai Uwe Broulik k...@privat.broulik.de wrote: Hi all, I was just looking at the Desktop Theme Details KCM (System Settings → Workspace Design → Details) and figured it's of not much use anymore. Imho the way the interaction with it worked wasn't particularly good to begin with, suddenly creating a (Custom) theme when you edited another one, but the one you selected in the list above isn't neccessarily the theme you're using, etc. So, let's look at the options it offers: * Color Scheme: Kinda works but given it also influences the background contrast, conflicts with the dialog/panel backgrounds * Panel background: Doesn't always work (panel stays the same somtimes) * Kickoff: No effect? What should it change anyway, it's up to the applet (it changes dialogs/kickoff, if that is even used anymore..) * Task items: Completely screws up the task manager if I touch that * Widget background: Seems okay * Translucent background: also okay * Dialog background: doesn't do anything * Analog Clock: works, seems kinda valid usecase; though all other DEs I've seen just provide that in the clock itself * Sticky Notes: Dunno, should work, but then I haven't seen a theme with different sticky notes - we still use the Oxygen ones even now :) One thing I would like to see is a default color for the notes, so a dark theme can have black notes by default * Tooltip: doesn't do anything * Pager: seems to work * Run dialog: Given KRunner is a regular dialog nowadays doesn't do anything * Logout dialog: Provided by LNF theme anyway * Icons: Kinda works, mostly seems to affect only system tray, as most icons are provided by the overall icon theme What should we do with this thing? PS: Air and even more Oxygen Plasma theme are pretty broken, we should either fix them (especially task manager, potentially revert the follow theme color stuff to provide a more 4.x-esque look) or kill them. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma 5.5 kickoff meeting
Time to start discussing Plasma 5.5 Please tick when you're available for a meeting Remember to set the timezone first http://doodle.com/gs27fytu3z4igv6n Add agenda items here https://notes.kde.org/p/plasma-5.5 Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124874: Fix lockup in digital clock
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124874/ --- Review request for Plasma. Repository: plasma-workspace Description --- property tooSmall depends on height If it's tool small it changes what text is shown on top of each other Whether text is shown changes the height; super complex binding loop that because it throws in a visibility change and goes via layouts isn't being caught. From what I can tell of other code when vertical we always want to show both bits of text. BUG: 351479 Diffs - applets/digital-clock/package/contents/ui/DigitalClock.qml 475ec9733a12abe2f0ced36016215ebd6adf9253 Diff: https://git.reviewboard.kde.org/r/124874/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/#review84130 --- applets/kickoff/core/favoritesmodel.cpp (line 133) https://git.reviewboard.kde.org/r/124863/#comment58254 Should we future-proof that also? - Kai Uwe Broulik On Aug. 21, 2015, 8:23 vorm., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/ --- (Updated Aug. 21, 2015, 8:23 vorm.) Review request for Plasma. Bugs: 351550 https://bugs.kde.org/show_bug.cgi?id=351550 Repository: plasma-desktop Description --- Desktop files changed name during KDE Frameworks 5 porting which renders our initial favorite list defunct. By adding the new names as well as the old ones we'll pick which ever one is actually installed on first start such that Plasma 5.4 will also behave correctly with Applications 15.08. BUG: 351550 Diffs - applets/kickoff/core/favoritesmodel.cpp 8da20f41c57c890d5383548b3cd8264373ef725f Diff: https://git.reviewboard.kde.org/r/124863/diff/ Testing --- - builds - wiped kickoffrc (and kde4 kickoffrc) - started plasmashell - only shows expected entries picking whichever is available - adding a new fav to get a new kickoffrc written - only entries are the actually found ones Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/ --- (Updated Aug. 21, 2015, 10:09 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit b2994a0f0ff3d39fecc651f9f088f5a7967e0445 by Harald Sitter to branch Plasma/5.4. Bugs: 351550 https://bugs.kde.org/show_bug.cgi?id=351550 Repository: plasma-desktop Description --- Desktop files changed name during KDE Frameworks 5 porting which renders our initial favorite list defunct. By adding the new names as well as the old ones we'll pick which ever one is actually installed on first start such that Plasma 5.4 will also behave correctly with Applications 15.08. BUG: 351550 Diffs - applets/kickoff/core/favoritesmodel.cpp 8da20f41c57c890d5383548b3cd8264373ef725f Diff: https://git.reviewboard.kde.org/r/124863/diff/ Testing --- - builds - wiped kickoffrc (and kde4 kickoffrc) - started plasmashell - only shows expected entries picking whichever is available - adding a new fav to get a new kickoffrc written - only entries are the actually found ones Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly
On Aug. 21, 2015, 8:26 a.m., Kai Uwe Broulik wrote: applets/kickoff/core/favoritesmodel.cpp, line 133 https://git.reviewboard.kde.org/r/124863/diff/1/?file=397018#file397018line133 Should we future-proof that also? Ah whoops - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/#review84130 --- On Aug. 21, 2015, 8:27 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/ --- (Updated Aug. 21, 2015, 8:27 a.m.) Review request for Plasma. Bugs: 351550 https://bugs.kde.org/show_bug.cgi?id=351550 Repository: plasma-desktop Description --- Desktop files changed name during KDE Frameworks 5 porting which renders our initial favorite list defunct. By adding the new names as well as the old ones we'll pick which ever one is actually installed on first start such that Plasma 5.4 will also behave correctly with Applications 15.08. BUG: 351550 Diffs - applets/kickoff/core/favoritesmodel.cpp 8da20f41c57c890d5383548b3cd8264373ef725f Diff: https://git.reviewboard.kde.org/r/124863/diff/ Testing --- - builds - wiped kickoffrc (and kde4 kickoffrc) - started plasmashell - only shows expected entries picking whichever is available - adding a new fav to get a new kickoffrc written - only entries are the actually found ones Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124863: [kickoff] Fix default favorites not being initialized correctly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/ --- (Updated Aug. 21, 2015, 8:27 a.m.) Review request for Plasma. Changes --- document why we have two names for each app and make sure systemsettings won't break if someone decides to rename it Bugs: 351550 https://bugs.kde.org/show_bug.cgi?id=351550 Repository: plasma-desktop Description --- Desktop files changed name during KDE Frameworks 5 porting which renders our initial favorite list defunct. By adding the new names as well as the old ones we'll pick which ever one is actually installed on first start such that Plasma 5.4 will also behave correctly with Applications 15.08. BUG: 351550 Diffs (updated) - applets/kickoff/core/favoritesmodel.cpp 8da20f41c57c890d5383548b3cd8264373ef725f Diff: https://git.reviewboard.kde.org/r/124863/diff/ Testing --- - builds - wiped kickoffrc (and kde4 kickoffrc) - started plasmashell - only shows expected entries picking whichever is available - adding a new fav to get a new kickoffrc written - only entries are the actually found ones Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124863: [kickoff] Fix default favorites not being initialized correctly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124863/ --- Review request for Plasma. Bugs: 351550 https://bugs.kde.org/show_bug.cgi?id=351550 Repository: plasma-desktop Description --- Desktop files changed name during KDE Frameworks 5 porting which renders our initial favorite list defunct. By adding the new names as well as the old ones we'll pick which ever one is actually installed on first start such that Plasma 5.4 will also behave correctly with Applications 15.08. BUG: 351550 Diffs - applets/kickoff/core/favoritesmodel.cpp 8da20f41c57c890d5383548b3cd8264373ef725f Diff: https://git.reviewboard.kde.org/r/124863/diff/ Testing --- - builds - wiped kickoffrc (and kde4 kickoffrc) - started plasmashell - only shows expected entries picking whichever is available - adding a new fav to get a new kickoffrc written - only entries are the actually found ones Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
