Review Request 124938: [panelconfiguration] Provide press feedback for Edge/SizeHandle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124938/ --- Review request for Plasma. Repository: plasma-desktop Description --- This makes the buttons look pressed when pressing the handles since the MEL steels the press from the button. This is using private API but I see no other way Diffs - desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml 0b7efd3 desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml a88fe20 Diff: https://git.reviewboard.kde.org/r/124938/diff/ Testing --- File Attachments Pressed Edge Handle https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/ee80e1d7-0974-4142-ba99-1cb6e785eb1e__pressedpanel.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124785: [Panelconfig] Reset the panel offset on alignment change
On Aug. 22, 2015, 11:42 p.m., David Edmundson wrote:
desktoppackage/contents/configuration/panelconfiguration/Ruler.qml, line 48
https://git.reviewboard.kde.org/r/124785/diff/1/?file=395466#file395466line48
PanelConfiguration.qml has this
Connections {
target: panel
onOffsetChanged: ruler.offset = panel.offset
onMinimumLengthChanged: ruler.minimumLength =
panel.minimumLength
onMaximumLengthChanged: ruler.maximumLength =
panel.maximumLength
}
my thoughts are:
1) with your change we're changing the ruler offset but not the panel
offset and they'll get out of sync. Are you sure it's the right offset to
change?
2) All of that original code is really weird and should be done as
bindings...then we can kill the Component.onCompleted in this class.
(and yeah, I know it's not yours)
1) Yes I am.
Ruler.qml, line 30 has this:
property alias offset: offsetHandle.value
and line 75 (in the new Ruler.qml) has this:
SliderHandle {
id: offsetHandle
graphicElementName: offsetslider
onValueChanged: panel.offset = value
property int position: (dialogRoot.vertical) ? y : x
}
So when I change `offset`, this means that panel.offset is changed too.
2) Yes thats right, but I think we should merge this now and do the refactoring
later, because it works for now. Or do you consider this as a merge blocker?
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124785/#review84194
---
On Aug. 17, 2015, 11:31 a.m., David Kahles wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124785/
---
(Updated Aug. 17, 2015, 11:31 a.m.)
Review request for Plasma.
Repository: plasma-desktop
Description
---
As offset and length have a different meaning in all alignments, the
panel shifts on alignment change. This could result in wrong panel
positions (e.g. panel shifted over a monitor border). The better approach
would be the recalculation of all values, so that the panel stays at it's
current position, but this would be error prone and complicated. As the
panel alignment is rarely changed, it's not worth it. The more easy
approach is just setting the panel offset to zero. This makes sure the
panel has a valid position and size.
Diffs
-
desktoppackage/contents/configuration/panelconfiguration/Ruler.qml
a31feb40598ba24a107f41ff3b3f823afaa89da6
Diff: https://git.reviewboard.kde.org/r/124785/diff/
Testing
---
When changing the alignment, the offset gets 0, so there are no invalid panel
positions on alignment change
Thanks,
David Kahles
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable
On Aug. 22, 2015, 11:31 p.m., David Edmundson wrote: desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml, line 48 https://git.reviewboard.kde.org/r/124782/diff/1/?file=395295#file395295line48 this doesn't entirely make sense. alignment == AlignLeft will also be alignment AlignLeft I assume in the third case it's AlignHCenter AlignLeft To be precise, it's (alignment != Qt.AlignRight) (alignment Qt.AlignRight) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/#review84193 --- On Aug. 26, 2015, 5:52 p.m., David Kahles wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/ --- (Updated Aug. 26, 2015, 5:52 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Add some comments to this IHMO hard to understand code. I hope I understood the code correctly... The maximum and minimum position the slider can be moved to is not relative to offset, so min/maxValue is a wrong term. Instead, use min/maxPosition as the borders are absolute. Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a Diff: https://git.reviewboard.kde.org/r/124782/diff/ Testing --- Changing the size and position works as before. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 351822] New: [Thinkpad T440] [kubuntu] (False?) notification of the removal of power when the battery has finished charging or has reached the threshold
https://bugs.kde.org/show_bug.cgi?id=351822 Bug ID: 351822 Summary: [Thinkpad T440] [kubuntu] (False?) notification of the removal of power when the battery has finished charging or has reached the threshold Product: Powerdevil Version: 5.3.2 Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: ndrgr...@gmail.com when the battery is fully charged or it reach the threshold set on TLP kde notify to me that the power is plug off. It doesn't happen immediately but I couldn't found other conditions in addition to these. The strange thing is that the unplug status lasts for a very short time like 0.5s. In fact if I set a different brightness for battery power and ac power the screen blink for a moment. I have use ubuntu gnome before kubuntu and I didn't have this problem. I try kubuntu 14.10 and 15.04 and change plasma version ( now I have KDE 5.3.2) and In all this case I have the plug-off problem. I use tlp, a energy manager write for thinkpad, but without it the problem isn't disappear. Reproducible: Always Steps to Reproduce: 1. Complete Charge of the battery 2. Wait. Actual Results: In a first time nothing but after a random time kde will notify you that ac was unplung and if you have set a different brightness in ac mode and in battery mode you will seen the screen blink for an half of a second Expected Results: when the battery is fully charged should not happen anything, at most tlp should disconnect the battery. = lshw = epr-think description: Computer width: 64 bits capabilities: smbios-2.7 vsyscall32 *-core description: Motherboard physical id: 0 *-memory description: System memory physical id: 0 size: 7711MiB *-cpu product: Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz vendor: Intel Corp. physical id: 1 bus info: cpu@0 size: 3268MHz capacity: 3400MHz width: 64 bits capabilities: fpu fpu_exception wp vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp x86-64 constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf eagerfpu pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 fma cx16 xtpr pdcm pcid sse4_1 sse4_2 movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm ida arat epb pln pts dtherm tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt cpufreq *-pci description: Host bridge product: Xeon E3-1200 v3/4th Gen Core Processor DRAM Controller vendor: Intel Corporation physical id: 100 bus info: pci@:00:00.0 version: 06 width: 32 bits clock: 33MHz *-pci:0 description: PCI bridge product: Xeon E3-1200 v3/4th Gen Core Processor PCI Express x16 Controller vendor: Intel Corporation physical id: 1 bus info: pci@:00:01.0 version: 06 width: 32 bits clock: 33MHz capabilities: pci pm msi pciexpress normal_decode bus_master cap_list configuration: driver=pcieport resources: irq:24 *-pci:1 description: PCI bridge product: Xeon E3-1200 v3/4th Gen Core Processor PCI Express x8 Controller vendor: Intel Corporation physical id: 1.1 bus info: pci@:00:01.1 version: 06 width: 32 bits clock: 33MHz capabilities: pci pm msi pciexpress normal_decode bus_master cap_list configuration: driver=pcieport resources: irq:25 ioport:3000(size=4096) memory:f000-f0ff ioport:c000(size=301989888) *-generic UNCLAIMED description: Unassigned class product: Illegal Vendor ID vendor: Illegal Vendor ID physical id: 0 bus info: pci@:02:00.0 version: ff width: 32 bits clock: 66MHz capabilities: bus_master vga_palette cap_list configuration: latency=255 maxlatency=255 mingnt=255 resources: memory:f000-f0ff memory:c000-cfff memory:d000-d1ff ioport:3000(size=128) *-display description: VGA compatible controller product: 4th Gen Core Processor Integrated Graphics Controller vendor: Intel Corporation physical id: 2 bus info: pci@:00:02.0
Re: Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124933/#review84417
---
Just place the
anchors {
horizontalCenter: parent.horizontalCenter
bottom: parent.bottom
}
into the Loader to ensure the OSD is correctly positioned. I think the OSD
should be loaded on demand, the first time it's to be shown.
Also, Loader has an active property you can set to false and then set to true
when you want the item to load. This way you can have the Loader's source where
it belongs.
- Kai Uwe Broulik
On Aug. 26, 2015, 12:58 nachm., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124933/
---
(Updated Aug. 26, 2015, 12:58 nachm.)
Review request for Plasma.
Repository: plasma-workspace
Description
---
This fixes type errors shown on startup:
TypeError: Cannot read property 'showPassword' of undefined
TypeError: Cannot read property 'ButtonLabel' of undefined
REVIEW: 124931
[screenlocker] Try to load faster by using more loaders
All UI is put into a loader to get the actual lock screen loaded faster.
This gets the creation of two views down to about 600 msec from before
around 1.8 sec. The initial startup time is extremely important to ensure
the screen is properly locked when going to suspend.
Diffs
-
ksmserver/screenlocker/greeter/greeterapp.cpp
b500ba44c2b483d7372ca46840152c90ef5f798c
lookandfeel/contents/lockscreen/ChangeSession.qml PRE-CREATION
lookandfeel/contents/lockscreen/LockOsd.qml PRE-CREATION
lookandfeel/contents/lockscreen/LockScreen.qml
4ce9a001efc2ffab2d78388e3a619d0de93f1758
lookandfeel/contents/lockscreen/MainBlock.qml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124933/diff/
Testing
---
the OSD is not anchored correctly any more.
Thanks,
Martin Gräßlin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124937: Add comment/description to keyboard kded module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- Review request for Plasma. Repository: plasma-desktop Description --- The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm. AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment: `Enables system tray for changing keyboard layout` If the module provides other functionality, we can revise the comment. Diffs - kcms/keyboard/keyboard.desktop 43ae1f1 Diff: https://git.reviewboard.kde.org/r/124937/diff/ Testing --- A description is now provided in the kded kcm. Thanks, Ragnar Thomsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124937: Add comment/description to keyboard kded module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 26, 2015, 7:41 p.m.) Review request for Plasma. Changes --- Change text according to David's suggestion. Repository: plasma-desktop Description --- The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm. AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment: `Enables system tray for changing keyboard layout` If the module provides other functionality, we can revise the comment. Diffs (updated) - kcms/keyboard/keyboard.desktop 43ae1f1 Diff: https://git.reviewboard.kde.org/r/124937/diff/ Testing --- A description is now provided in the kded kcm. File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png Thanks, Ragnar Thomsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/ --- (Updated Aug. 26, 2015, 4:02 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit d058c1d44f0d9276f3a6287513023041065afe1c by David Kahles to branch master. Repository: plasma-desktop Description --- Prevent users from moving the panel off the monitor, and prevent users from moving a panel with center alignment to the left (right) and then pull one of the right (left) sliders to the right (left). Because the left and right sliders are coupled, this would make the left (right) sliders to go off the monitor. Also fix that the left (right) sliders cannot be moved over the middle. (In fact they can by using the offset slider, but as soon as on of the left (right) handles are dragged, it sets the position back to the middle). I really don't know the reason for this behavior, and everything works fine (or even better) without it. Does someone know whether this is needed and why? Also delete the default values for min/maxPosition in the SliderHandle, as every handle sets its own min/maxPositions now. And should I add such checks also to panelview.cpp to prevent loading an invalid panel position/size from the config? (Though this should only happen when a user changes the config manually) There are some checks, but not everything is checked.. Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a Diff: https://git.reviewboard.kde.org/r/124786/diff/ Testing --- I know no way to set an invalid position/size as I could before. It works for horizontal and vertical panels. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124785: [Panelconfig] Reset the panel offset on alignment change
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124785/ --- (Updated Aug. 26, 2015, 4:02 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit bba9e301cde90e7442ed1b5f5268061ddaeaad7f by David Kahles to branch master. Repository: plasma-desktop Description --- As offset and length have a different meaning in all alignments, the panel shifts on alignment change. This could result in wrong panel positions (e.g. panel shifted over a monitor border). The better approach would be the recalculation of all values, so that the panel stays at it's current position, but this would be error prone and complicated. As the panel alignment is rarely changed, it's not worth it. The more easy approach is just setting the panel offset to zero. This makes sure the panel has a valid position and size. Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 Diff: https://git.reviewboard.kde.org/r/124785/diff/ Testing --- When changing the alignment, the offset gets 0, so there are no invalid panel positions on alignment change Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/ --- (Updated Aug. 26, 2015, 4:02 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit c4617a65b2bfdad2b0bb3274c08f3a45d2c3c4eb by David Kahles to branch master. Repository: plasma-desktop Description --- Add some comments to this IHMO hard to understand code. I hope I understood the code correctly... The maximum and minimum position the slider can be moved to is not relative to offset, so min/maxValue is a wrong term. Instead, use min/maxPosition as the borders are absolute. Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a Diff: https://git.reviewboard.kde.org/r/124782/diff/ Testing --- Changing the size and position works as before. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124937: Add comment/description to keyboard kded module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 26, 2015, 7:08 p.m.) Review request for Plasma. Changes --- Add before+after screenshots. Repository: plasma-desktop Description --- The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm. AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment: `Enables system tray for changing keyboard layout` If the module provides other functionality, we can revise the comment. Diffs - kcms/keyboard/keyboard.desktop 43ae1f1 Diff: https://git.reviewboard.kde.org/r/124937/diff/ Testing --- A description is now provided in the kded kcm. File Attachments (updated) Before https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png Thanks, Ragnar Thomsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124785: [Panelconfig] Reset the panel offset on alignment change
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124785/#review84409 --- Ship it! Ship It! - David Edmundson On Aug. 17, 2015, 9:31 a.m., David Kahles wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124785/ --- (Updated Aug. 17, 2015, 9:31 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- As offset and length have a different meaning in all alignments, the panel shifts on alignment change. This could result in wrong panel positions (e.g. panel shifted over a monitor border). The better approach would be the recalculation of all values, so that the panel stays at it's current position, but this would be error prone and complicated. As the panel alignment is rarely changed, it's not worth it. The more easy approach is just setting the panel offset to zero. This makes sure the panel has a valid position and size. Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 Diff: https://git.reviewboard.kde.org/r/124785/diff/ Testing --- When changing the alignment, the offset gets 0, so there are no invalid panel positions on alignment change Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124937: Add comment/description to keyboard kded module
On Aug. 26, 2015, 7:27 p.m., David Edmundson wrote: kcms/keyboard/keyboard.desktop, line 76 https://git.reviewboard.kde.org/r/124937/diff/1/?file=398806#file398806line76 Yes we definitely need a comment ++ Not so sure of the text, the kded is needed to handle and act on switch shortcut keys regardless of whether the setting show icon in system tray is set. We don't want people using this to hide the icon. Maybe: Enables switching keyboard layout through shortcuts or system tray Yes, that's much better... - Ragnar --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/#review84414 --- On Aug. 26, 2015, 7:41 p.m., Ragnar Thomsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 26, 2015, 7:41 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm. AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment: `Enables system tray for changing keyboard layout` If the module provides other functionality, we can revise the comment. Diffs - kcms/keyboard/keyboard.desktop 43ae1f1 Diff: https://git.reviewboard.kde.org/r/124937/diff/ Testing --- A description is now provided in the kded kcm. File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png Thanks, Ragnar Thomsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124923: Plasma 5 color picker plasmoid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/ --- (Updated Aug. 26, 2015, 6:07 nachm.) Review request for Plasma and KDE Usability. Changes --- - Pick correct coordinates with QT_DEVICE_PIXEL_RATIO - Fix first pick not being registered - Restore LaTeX color Repository: kdeplasma-addons Description --- This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier. Clicking the drop (it's color-picker, I would expect a pipette icon) enters picker mode, where you can click anywhere on the screen and have the color code (in a format you can configure) copied to your clipboard. Clicking the color blob opens the history, showing the recentmost 9 colors (so it's a nice grid) which allow copying their respective color codes in various formats. Activating the plasmoid (pressing the configured shortcut) will by default enter color picking mode, alternatively it brings up the popup like any other plasmoid. Diffs (updated) - applets/CMakeLists.txt c60c350 applets/colorpicker/CMakeLists.txt PRE-CREATION applets/colorpicker/Messages.sh PRE-CREATION applets/colorpicker/package/contents/code/logic.js PRE-CREATION applets/colorpicker/package/contents/config/config.qml PRE-CREATION applets/colorpicker/package/contents/config/main.xml PRE-CREATION applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION applets/colorpicker/package/contents/ui/main.qml PRE-CREATION applets/colorpicker/package/metadata.desktop PRE-CREATION applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION applets/colorpicker/plugin/grabwidget.h PRE-CREATION applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION applets/colorpicker/plugin/qmldir PRE-CREATION applets/kolourpicker/CMakeLists.txt 522e0de applets/kolourpicker/Messages.sh 072def0 applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc applets/kolourpicker/kolourpicker.h bde3ff7 applets/kolourpicker/kolourpicker.cpp a4b0ea4 applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 Diff: https://git.reviewboard.kde.org/r/124923/diff/ Testing (updated) --- - I have the impression that the color picker is off by one pixel horizontally (QRect weirdness? or our Breeze crosshair cursor?) - I didn't test with multiple screens File Attachments In a panel https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png On the desktop https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png History https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png Formats menu https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles
On Aug. 24, 2015, 2:06 a.m., Marco Martin wrote: the middle thing was done in order to not cross the handles, but the other check you afded should prevent this anyways That was done by `offsetHandle.position + units.gridUnit * 3` in minimumPosition: Math.max(offsetHandle.position + units.gridUnit * 3, [middle thing]) But I think it's really not needed. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/#review84238 --- On Aug. 17, 2015, 12:50 p.m., David Kahles wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/ --- (Updated Aug. 17, 2015, 12:50 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Prevent users from moving the panel off the monitor, and prevent users from moving a panel with center alignment to the left (right) and then pull one of the right (left) sliders to the right (left). Because the left and right sliders are coupled, this would make the left (right) sliders to go off the monitor. Also fix that the left (right) sliders cannot be moved over the middle. (In fact they can by using the offset slider, but as soon as on of the left (right) handles are dragged, it sets the position back to the middle). I really don't know the reason for this behavior, and everything works fine (or even better) without it. Does someone know whether this is needed and why? Also delete the default values for min/maxPosition in the SliderHandle, as every handle sets its own min/maxPositions now. And should I add such checks also to panelview.cpp to prevent loading an invalid panel position/size from the config? (Though this should only happen when a user changes the config manually) There are some checks, but not everything is checked.. Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a Diff: https://git.reviewboard.kde.org/r/124786/diff/ Testing --- I know no way to set an invalid position/size as I could before. It works for horizontal and vertical panels. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124937: Add comment/description to keyboard kded module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/#review84414 --- kcms/keyboard/keyboard.desktop (line 76) https://git.reviewboard.kde.org/r/124937/#comment58438 Yes we definitely need a comment ++ Not so sure of the text, the kded is needed to handle and act on switch shortcut keys regardless of whether the setting show icon in system tray is set. We don't want people using this to hide the icon. Maybe: Enables switching keyboard layout through shortcuts or system tray - David Edmundson On Aug. 26, 2015, 5:08 p.m., Ragnar Thomsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 26, 2015, 5:08 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm. AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment: `Enables system tray for changing keyboard layout` If the module provides other functionality, we can revise the comment. Diffs - kcms/keyboard/keyboard.desktop 43ae1f1 Diff: https://git.reviewboard.kde.org/r/124937/diff/ Testing --- A description is now provided in the kded kcm. File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png Thanks, Ragnar Thomsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124923: Plasma 5 color picker plasmoid
On Aug. 25, 2015, 9:22 p.m., Thomas Pfeiffer wrote: Great work! Two points: 1. The two icons in the Plasmoid look like they're two separate Plasmoids, which is confusing. They should be more visually connected (we're still brainstorming ideas for how to do this in the VDG) 2. Latex color doesn't have anything to do with fetish, but it's the color code that LaTeX uses (see https://en.wikibooks.org/wiki/LaTeX/Colors#Color_Models ). I don't know how many LaTeX users actually need this, but it might be premature to just remove it. Kai Uwe Broulik wrote: 2.) I already got complaints about this on IRC, so I'll bring it back :D Marco Martin wrote: I don't think it's an issue that it looks like two separate plasmoids: those are two semi independent functions that if they happen to belong to the same plasmoid or not is no concern to the user They are only _semi_-independent: They perform two different functions when clicked, but the history button has absolutely no use without the color picking button. Therefore, they still clearly belong together. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/#review84368 --- On Aug. 25, 2015, 6:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/ --- (Updated Aug. 25, 2015, 6:19 p.m.) Review request for Plasma and KDE Usability. Repository: kdeplasma-addons Description --- This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier. Clicking the drop (it's color-picker, I would expect a pipette icon) enters picker mode, where you can click anywhere on the screen and have the color code (in a format you can configure) copied to your clipboard. Clicking the color blob opens the history, showing the recentmost 9 colors (so it's a nice grid) which allow copying their respective color codes in various formats. Activating the plasmoid (pressing the configured shortcut) will by default enter color picking mode, alternatively it brings up the popup like any other plasmoid. Diffs - applets/CMakeLists.txt c60c350 applets/colorpicker/CMakeLists.txt PRE-CREATION applets/colorpicker/Messages.sh PRE-CREATION applets/colorpicker/package/contents/code/logic.js PRE-CREATION applets/colorpicker/package/contents/config/config.qml PRE-CREATION applets/colorpicker/package/contents/config/main.xml PRE-CREATION applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION applets/colorpicker/package/contents/ui/main.qml PRE-CREATION applets/colorpicker/package/metadata.desktop PRE-CREATION applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION applets/colorpicker/plugin/grabwidget.h PRE-CREATION applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION applets/colorpicker/plugin/qmldir PRE-CREATION applets/kolourpicker/CMakeLists.txt 522e0de applets/kolourpicker/Messages.sh 072def0 applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc applets/kolourpicker/kolourpicker.h bde3ff7 applets/kolourpicker/kolourpicker.cpp a4b0ea4 applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 Diff: https://git.reviewboard.kde.org/r/124923/diff/ Testing --- - I have the impression that the color picker is off by one pixel horizontally (QRect weirdness?) - It breaks with QT_DEVICE_PIXEL_RATIO (Daviid?) - I didn't test with multiple screens - The first pick after startup of plasmashell/plasmoidviewer is not added to the history for some reason I haven't figured out yet - I removed the Latex color, whatever that was, and added Qt.rgba instead :) as well as CSS colors File Attachments In a panel https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png On the desktop https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png History https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png Formats menu https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list
Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/ --- (Updated Aug. 26, 2015, 5:52 p.m.) Review request for Plasma. Changes --- Improved Comment Repository: plasma-desktop Description --- Add some comments to this IHMO hard to understand code. I hope I understood the code correctly... The maximum and minimum position the slider can be moved to is not relative to offset, so min/maxValue is a wrong term. Instead, use min/maxPosition as the borders are absolute. Diffs (updated) - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a Diff: https://git.reviewboard.kde.org/r/124782/diff/ Testing --- Changing the size and position works as before. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/#review84410 --- Ship it! - David Edmundson On Aug. 26, 2015, 3:52 p.m., David Kahles wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/ --- (Updated Aug. 26, 2015, 3:52 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Add some comments to this IHMO hard to understand code. I hope I understood the code correctly... The maximum and minimum position the slider can be moved to is not relative to offset, so min/maxValue is a wrong term. Instead, use min/maxPosition as the borders are absolute. Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a Diff: https://git.reviewboard.kde.org/r/124782/diff/ Testing --- Changing the size and position works as before. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124937: Add comment/description to keyboard kded module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/#review84430 --- Ship it! Ship It! - David Edmundson On Aug. 26, 2015, 5:41 p.m., Ragnar Thomsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 26, 2015, 5:41 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm. AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment: `Enables system tray for changing keyboard layout` If the module provides other functionality, we can revise the comment. Diffs - kcms/keyboard/keyboard.desktop 43ae1f1 Diff: https://git.reviewboard.kde.org/r/124937/diff/ Testing --- A description is now provided in the kded kcm. File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png Thanks, Ragnar Thomsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124944: Fix a crash.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/ --- Review request for Plasma. Repository: plasma-workspace Description --- We already have configDlg-setAttribute(Qt::WA_DeleteOnClose) we don't need to be quite so enthusiastic. If we remove a config action, close any open dialogs for that action BUG: 351748 Diffs - shell/currentcontainmentactionsmodel.cpp 011e4ecc363d88ed74f187528458b2f01cb5aed6 Diff: https://git.reviewboard.kde.org/r/124944/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124930: [screenlocker] Try to improve greeter to get it start up a little bit faster
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124930/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspace Description --- In a multi-screen setup we have multiple views showing the same Qml scene. Let's share the engine for all views. [screenlocker] Use one QQmlComponent for all views No need to parse the same Qml file multiple times (for each screen). Instead use one QQmlComponent and create a QQuickItem for each screen. Diffs - ksmserver/screenlocker/greeter/greeterapp.h ed278e492a9a237f65f4c1600360f84fb25bdad7 ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c Diff: https://git.reviewboard.kde.org/r/124930/diff/ Testing --- Not yet tested the fallback. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma Hangout
On Monday, August 17, 2015 05:12:00 AM Jeremy Whiting wrote: On Mon, Aug 17, 2015 at 4:42 AM, Sebastian Kügler se...@kde.org wrote: Present: Bhushan, David, Jens, Kai Uwe, Martin G, Ozark, Sebastian Date: 17 August, 2015 Bhushan: - working on apps, first off comic book reader - Looked into Plasma Moible on Archlinux: https://github.com/bhush9/plasma-arch David: - fixed some shoddy porting - Fixed translations - Fixed a bug in KScreen - 5.4 looks pretty good, probably not a log of real bugs (or too little testing!) - will fix davetray after 5.4 is out Jens: - visited GUADEC, GNOME struggles with many of the same problems as KDE does Which problems are you referring to specifically? For those of us that weren't at GUADEC and are curious. Well they have similar issues as us when it comes to things like dev-bleeding, how to attract new people, retain people who are here, how to minimize the threshold to get into KDE/GNOME and in general make our communities more pleasant places to be in, work in and be part of. That issue balloons into things like What technical methods do we employ to make contributing code easier and things like How to make sure our community remain visible and to How to make sure the community remains independent from companies and sponsors. One proposal was to see if the people in Gnome working on that issue (Sriram for example) could talk to people withing KDE who does the same thing (Like Lydia) to at least compare notes. Why do twice the work independently when we can help each other out. Other issues was how to make certain the drawbridge is down between the Gnome community and the KDE community. The fact that we know fairly little about each other in comparison how theoretically close we are (and practically close we could be) shows that we should see if we couldn't make that communication simpler (outside of bugreports that tend to go into slugfests). Just a shortlist of things... Kai Uwe: - Fixes here and there - interfaces powerdevil with his ambient light sensor in a hackish way - tried Skeyer, gesture-based keyboard which comes with a maliit plugin [1] https://saidinesh5.wordpress.com/2014/05/20/on-the-way-to-skeyer/ [2] https://bitbucket.org/skeyer/skeyer/ Martin: - Working on KWin QPA progressing well - now working on input devices - looking into the OpenGL story right now Sebas: - Worked on KScreen/Wayland wl protocol for disconnected outputs w/ Martin - Discussed merge plans with dvratil (either wayland-integration or libkscreen) - Finalized Plasma Mobile vision - Worked a lot on docs for Plasma Mobile (see wiki) - will do more docs - more phabricator (task workflow basics are there, migrate more, then move on to code reviews) - interview this afternoon - finalize -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124910: Make model param of clicked signal of var type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124910/#review84395 --- Ship it! Ship It! - Marco Martin On Aug. 24, 2015, 9:43 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124910/ --- (Updated Aug. 24, 2015, 9:43 p.m.) Review request for Plasma. Repository: plasma-framework Description --- When using ModelContextMenu with a JS array the model param of the clicked signal is null because QtObject property can only hold QObject but no JS objects. Diffs - src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml baa541a Diff: https://git.reviewboard.kde.org/r/124910/diff/ Testing --- Works. Will make a ModelContextMenu test at some point. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124917: [screenlocker] Start grace time when the greeter is shown
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124917/#review84396 --- Ship it! Ship It! - Marco Martin On Aug. 25, 2015, 10:53 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124917/ --- (Updated Aug. 25, 2015, 10:53 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- So far the grace time started with the idle timeout. Given that our greeter takes a few seconds to start it rendered a short grace time useless as it was quite likely that the grace time already ended when the first visible feedback was shown to the user. Now the grace time starts when the greeter is actually shown. Diffs - ksmserver/screenlocker/ksldapp.cpp d0636b8785101cb9896cea6399952dac0e4cd227 Diff: https://git.reviewboard.kde.org/r/124917/diff/ Testing --- * grace time of 5 sec: waited for the lock screen to show, counted to 4, moved mouse - unlocked * waited till the lock screen was shown and a few minutes more, moved mouse - no unlock Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124930: [screenlocker] Try to improve greeter to get it start up a little bit faster
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124930/#review84397 --- I can't imagine the component sharing this makes any difference there's a global component cache anyway. It won't compile the same file twice. Unless you know better, I wouldn't make that change. ksmserver/screenlocker/greeter/greeterapp.cpp (line 185) https://git.reviewboard.kde.org/r/124930/#comment58432 This change will make a difference. Though, if we're sharing the engine maybe we can use Marco's shiny new QuickViewSharedEngine. It does the engine part implicitly but handles roobObjects and such better. The engine manipulation above would change to KDeclarative::QmlObjectSharedEngine - David Edmundson On Aug. 26, 2015, 9:24 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124930/ --- (Updated Aug. 26, 2015, 9:24 a.m.) Review request for Plasma and David Edmundson. Repository: plasma-workspace Description --- In a multi-screen setup we have multiple views showing the same Qml scene. Let's share the engine for all views. [screenlocker] Use one QQmlComponent for all views No need to parse the same Qml file multiple times (for each screen). Instead use one QQmlComponent and create a QQuickItem for each screen. Diffs - ksmserver/screenlocker/greeter/greeterapp.h ed278e492a9a237f65f4c1600360f84fb25bdad7 ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c Diff: https://git.reviewboard.kde.org/r/124930/diff/ Testing --- Not yet tested the fallback. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124930: [screenlocker] Try to improve greeter to get it start up a little bit faster
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124930/ --- (Updated Aug. 26, 2015, 12:04 p.m.) Status -- This change has been discarded. Review request for Plasma and David Edmundson. Repository: plasma-workspace Description --- In a multi-screen setup we have multiple views showing the same Qml scene. Let's share the engine for all views. [screenlocker] Use one QQmlComponent for all views No need to parse the same Qml file multiple times (for each screen). Instead use one QQmlComponent and create a QQuickItem for each screen. Diffs - ksmserver/screenlocker/greeter/greeterapp.h ed278e492a9a237f65f4c1600360f84fb25bdad7 ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c Diff: https://git.reviewboard.kde.org/r/124930/diff/ Testing --- Not yet tested the fallback. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124910: Make model param of clicked signal of var type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124910/ --- (Updated Aug. 26, 2015, 8:46 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 6995193219a64fd2bce73108fbfca25a5cc7e99b by Kai Uwe Broulik to branch master. Repository: plasma-framework Description --- When using ModelContextMenu with a JS array the model param of the clicked signal is null because QtObject property can only hold QObject but no JS objects. Diffs - src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml baa541a Diff: https://git.reviewboard.kde.org/r/124910/diff/ Testing --- Works. Will make a ModelContextMenu test at some point. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-framework] src/plasma: plasma: Fix applet actions might be nullptr
On Wednesday 26 August 2015 11:27:05 Leslie Zhai wrote:
Git commit 4e9b32d80d6b43ad3d1ddd47c948ad066608b052 by Leslie
Zhai.
Committed on 26/08/2015 at 09:24.
Pushed by lesliezhai into branch 'master'.
plasma: Fix applet actions might be nullptr
BUG:351777
M +1-1src/plasma/applet.cpp
http://commits.kde.org/plasma-framework/4e9b32d80d6b43ad3d1ddd47c94
8ad066608b052
diff --git a/src/plasma/applet.cpp b/src/plasma/applet.cpp
index 89c..3716a83 100644
--- a/src/plasma/applet.cpp
+++ b/src/plasma/applet.cpp
@@ -568,7 +568,7 @@ QListQAction * Applet::contextualActions()
KActionCollection *Applet::actions() const
{
-return d-actions;
+return d-actions ? d-actions : new
KActionCollection((QObject *)this); }
Types::FormFactor Applet::formFactor() const
Doesn't this leak memory? I doubt the caller of Applet::actions() is
supposed to delete the received pointer.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library
On Aug. 25, 2015, 2:22 p.m., René J.V. Bertin wrote: When built as SHARED as in the current code, libdraganddropplugin.dylib gets installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given an OS X install_name of $PREFIX/lib/libdraganddropplugin.dylib. This mismatch can cause problems. It is also given a compatibility_version of 0.0.0. Both properties are used only when the `dylib` is used as a shared library, because AFAIK they're only used by the dynamic loader when the reference information is available (i.e. stored in the binary by the link editor). Using `dlopen` on a random file, dylib or other, does not provide such information and thus it shouldn't matter what the loaded file claims for its install_name and/or compatibility_version. By contrast, there *is* a difference between shared libraries and loadable modules (plugins or `bundles` in OS X speak) on OS X. The latter cannot be used as shared libraries by the link editor (something that certain KDE4 projects sin against) while the former can be used as plugins without any issue. However, only plugins can have automatic access to the loader's symbols but that requires the loader to be specified at link time so not of much interest for generic plugins, kparts etc. NB: the `bundle` in this context is unfortunate because they are not generally bundles in the app bundle way. NB2: those KDE projects that use modules as shared libraries (kparts, in unit tests IIRC) led me to propose a patch to MacPorts's port:cmake which made cmake create modules with the same linker options as shared libraries (i.e. `-dynamiclib` instead of `-bundle`). I've since tried to get that patch removed, but it is still out there. if this breaks on linux, it should be reverted for now - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84338 --- On Aug. 23, 2015, 9:16 p.m., Hanspeter Niederstrasser wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 23, 2015, 9:16 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, Plasma, and Harald Sitter. Bugs: 342962 https://bugs.kde.org/show_bug.cgi?id=342962 Repository: kdeclarative Description --- The kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio, kquickcontrolsprivateplugin, and kquickcontrolsaddonsplugin) are being built as shared libraries. They should be built as bundles (MODULE) in the CMakeLists.txt file. When built as SHARED as in the current code, libdraganddropplugin.dylib gets installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given an OS X install_name of $PREFIX/lib/libdraganddropplugin.dylib. This mismatch can cause problems. It is also given a compatibility_version of 0.0.0. Diffs - src/qmlcontrols/draganddrop/CMakeLists.txt e8127e4 src/qmlcontrols/kcoreaddons/CMakeLists.txt 3f77f2d src/qmlcontrols/kioplugin/CMakeLists.txt 7b258e0 src/qmlcontrols/kquickcontrols/private/CMakeLists.txt da355c1 src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 Diff: https://git.reviewboard.kde.org/r/124892/diff/ Testing --- Since the plugin is not supposed to be a linkable library, it should be built as MODULE in CMakeLists.txt. The physical install location remains the same and plugins don't have install_names. This corrects the install_name/install location mismatch. The change should not have any effect on non-OS X systems. Thanks, Hanspeter Niederstrasser ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Update on screen brightness handling for Wayland
On Wednesday, August 26, 2015 09:47:11 Martin Graesslin wrote: at Akademy we discussed some plans on how to handle screen brightness on Wayland. Unfortunately I must say that this doesn't work at all as we imagined I had a look at what Weston is doing for brightness. It uses a forked libbacklight which internally interacts with the sysfs brighness helpers. I integrated this into KWin and tried to change backlight. But this obviously did not work as only root user is allowed to write to the sysfs file. It's worse, it apparently depends on the driver, for example on the Nexus5, the brightness is world-readable, on my intel laptop, it's root-only. I then tried to open it with the logind wrapper, but logind doesn't have support for this kind of files, so that unfortunately doesn't work either. And here, poor fool, I stand once more, no wiser than I was before. We have a file only root can write to, but we are not root. Adding a KAuth helper to KWin would not gain us anything compared to having it in powerdevil. So I suggest that we drop the idea that KWin is responsible for backlight and move this feature completely to powerdevil and use the KAuth helper. Sounds like the way forward. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124933/ --- Review request for Plasma. Repository: plasma-workspace Description --- This fixes type errors shown on startup: TypeError: Cannot read property 'showPassword' of undefined TypeError: Cannot read property 'ButtonLabel' of undefined REVIEW: 124931 [screenlocker] Try to load faster by using more loaders All UI is put into a loader to get the actual lock screen loaded faster. This gets the creation of two views down to about 600 msec from before around 1.8 sec. The initial startup time is extremely important to ensure the screen is properly locked when going to suspend. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c lookandfeel/contents/lockscreen/ChangeSession.qml PRE-CREATION lookandfeel/contents/lockscreen/LockOsd.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 lookandfeel/contents/lockscreen/MainBlock.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124933/diff/ Testing --- the OSD is not anchored correctly any more. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 145 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 26 Aug 2015 10:22:56 + Build duration: 6 min 42 sec CHANGE SET Revision 1cddd74f14b5f6dd866101c5a337769617680794 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit kcms/touchpad/src/applet/qml/metadata.desktop change: edit kcms/touchpad/src/applet/dataengine.desktop change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop change: edit kcms/touchpad/src/kded/kded_touchpad.desktop change: edit kcms/touchpad/src/kcm/kcm_touchpad.desktop change: edit solid-device-automounter/kded/device_automounter.desktop change: edit kcms/desktoppaths/desktoppath.desktop change: edit kcms/touchpad/src/kded/kcm_touchpad.notifyrc JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/38 (95%)CLASSES 36/38 (95%)LINE 2370/3410 (70%)CONDITIONAL 1783/3079 (58%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 18/34 (53%) kcms.keyboard FILES 20/22 (91%)CLASSES 20/22 (91%)LINE 800/1526 (52%)CONDITIONAL 770/1268 (61%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 511/994 (51%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 242/364 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 108/178 (61%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 269/350 (77%)CONDITIONAL 82/137 (60%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 (100%)CONDITIONAL 52/104 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 145 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 26 Aug 2015 10:22:56 + Build duration: 6 min 42 sec CHANGE SET Revision 1cddd74f14b5f6dd866101c5a337769617680794 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit kcms/touchpad/src/applet/qml/metadata.desktop change: edit kcms/touchpad/src/applet/dataengine.desktop change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop change: edit kcms/touchpad/src/kded/kded_touchpad.desktop change: edit kcms/touchpad/src/kcm/kcm_touchpad.desktop change: edit solid-device-automounter/kded/device_automounter.desktop change: edit kcms/desktoppaths/desktoppath.desktop change: edit kcms/touchpad/src/kded/kcm_touchpad.notifyrc JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/38 (95%)CLASSES 36/38 (95%)LINE 2370/3410 (70%)CONDITIONAL 1783/3079 (58%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 18/34 (53%) kcms.keyboard FILES 20/22 (91%)CLASSES 20/22 (91%)LINE 800/1526 (52%)CONDITIONAL 770/1268 (61%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 511/994 (51%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 242/364 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 108/178 (61%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 269/350 (77%)CONDITIONAL 82/137 (60%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 (100%)CONDITIONAL 52/104 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124931: [lookandfeel] Fix errors on startup of lockscreen greeter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124931/ --- Review request for Plasma. Repository: plasma-workspace Description --- This fixes type errors shown on startup: TypeError: Cannot read property 'showPassword' of undefined TypeError: Cannot read property 'ButtonLabel' of undefined Diffs - lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 Diff: https://git.reviewboard.kde.org/r/124931/diff/ Testing --- run kscreenlocker_greet --testing. Error no longer shown, items's still working Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124931: [lookandfeel] Fix errors on startup of lockscreen greeter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124931/#review84399 --- lookandfeel/contents/lockscreen/LockScreen.qml (line 165) https://git.reviewboard.kde.org/r/124931/#comment58433 block.mainItem.model.get(block.mainItem.selectedIndex) ? !!block.mainItem.model.get(block.mainItem.selectedIndex).showPassword : false (Ideally we had a readonly property QtObject (var?) for that item somewhere) - Kai Uwe Broulik On Aug. 26, 2015, 10:42 vorm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124931/ --- (Updated Aug. 26, 2015, 10:42 vorm.) Review request for Plasma. Repository: plasma-workspace Description --- This fixes type errors shown on startup: TypeError: Cannot read property 'showPassword' of undefined TypeError: Cannot read property 'ButtonLabel' of undefined Diffs - lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 Diff: https://git.reviewboard.kde.org/r/124931/diff/ Testing --- run kscreenlocker_greet --testing. Error no longer shown, items's still working Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
5.5 Kickoff meeting minutes
Present: mgraesslin, notmart, andreas_k, sebas, bshah, d_ed, jensrout, mck182, kbroulik Schedule: ok final on Thuesday tag - Tuesday release, beta with tag/tar/release on Thursday 2 weeks before that, repo freeze 2 weeks before that 8 Dec final release date ok I can add in a 5.4.3 release in November (look at the changelog at the time to check it's worth it) Old Todo review done oxygen font - Oxygen has gaps and is not under developerment, VDG to look for better font options, must be freely licenced netbook design - VDG to come up with concept, netbooks are dead so maybe just a large phone UI for tablets, or convertables system settings taskforce - devs needed to help with system settings UI improvement. no immediate volunteers, ask on mailing list if there's energy developer docs - sebas has tidied some up, sebas for 5.5, I want to have a complete guide for 3rd party app and workspace devs ready review the plasmoid in plasma-framework[sebas/developerguide] to merge will plasma phone get released with 5.5? not all, too early, but some stuff will, todo item added to review what with sebas and jonathan and anyone else new todo items: several added to board https://todo.kde.org/?controller=boardaction=showproject_id=44 oxygen icons to come out of retirement, svn to move to kde/workspace, new name to be found (else version number is going down) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library
On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: I've got both Gentoo and Arch saying this causes a major problem [1]: libdraganddropplugin.so changes to draganddropplugin.so in /usr/lib/qt/qml/org/kde/draganddrop and then they don't get loaded. any ideas? Otherwise I'll have to revert this before release. [1] https://aur.archlinux.org/packages/plasma-desktop-git/ Harald Sitter wrote: I tried it this morning and it seemed to work. Now I try it again and it fails I suppose this is the point where we call for a revert hammer? :P Harald Sitter wrote: from qmldir documentation Declares a plugin to be made available by the module. Name is the plugin library name. This is usually not the same as the file name of the plugin binary, which is platform dependent; e.g. the library MyAppTypes would produce libMyAppTypes.so on Linux and MyAppTypes.dll on Windows. Harald Sitter wrote: http://www.cmake.org/cmake/help/v3.0/variable/CMAKE_SHARED_MODULE_PREFIX.html David Edmundson wrote: are we meant to set that to lib in every project? That doesn't sound right. Harald Sitter wrote: More like per-target even, since a kded plugin for example wouldn't want the prefix I suppose. It might well be that switching the qml plugins to MODULE is quite simply not the best solution to the initial problem on OSX, even though TBH they are really MODULE and not SHARED anyway so by any measure declaring them SHARED was weird all along. alexmerry might know of a better way but from my quick research it appears that either we need to set the prefix variable (supposedly via a macro wrapping add_library) or we revert back to SHARED and need to find another way to coerce cmake into producing working results on OSX. In a way I would argue that the problem is more with the qml loader not looking for a version without lib prefix if the lib prefix one is not available. So, regardless of how we proceed with kdeclarative I think it would be wortwhile to possible expand the qml loader to not require the lib prefix on unix systems. If not to resolve the issue at hand, at least to have it behave reasonably in the distant future. René J.V. Bertin wrote: find another way to coerce cmake into producing working results on OSX Are you sure that results actually do no not work on OS X (and that this has nothing to do with QStandardPaths returning unexpected locations)?! It is always possible to ensure that the plugins get the correct install_name and even a compatibility_version if there's any point in that (do these get versioning under Linux?). This can be done during the link step but also afterwards (probably more complicated to get right in CMake scripts). Whatever the approach, it should be possible to do it in the CMake macro (cmake already generates an option to set the install_name because otherwise the linker would either assume a relative install_name [just the filename] or use the full path to the output file). I presume that at least some of the plugins targeted here exists for KDE4 and if so, are still built the way they were there? Harald: you are right, Qt requiring the lib prefix is incorrect (unnecessary and confusing) on Linux, since as you say, a module is not a shared lib. QLibrary actually tries with and without the lib prefix (which is why C++ plugins like kded and others don't have it). I assume QML doesn't use QLibrary then? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84333 --- On Aug. 23, 2015, 9:16 p.m., Hanspeter Niederstrasser wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 23, 2015, 9:16 p.m.) Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, Plasma, and Harald Sitter. Bugs: 342962 https://bugs.kde.org/show_bug.cgi?id=342962 Repository: kdeclarative Description --- The kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio, kquickcontrolsprivateplugin, and kquickcontrolsaddonsplugin) are being built as shared libraries. They should be built as bundles (MODULE) in the CMakeLists.txt file. When built as SHARED as in the current code, libdraganddropplugin.dylib gets installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given an OS X install_name of $PREFIX/lib/libdraganddropplugin.dylib. This mismatch can cause problems. It is also given a compatibility_version of 0.0.0. Diffs - src/qmlcontrols/draganddrop/CMakeLists.txt e8127e4
Update on screen brightness handling for Wayland
Hi all, at Akademy we discussed some plans on how to handle screen brightness on Wayland. Unfortunately I must say that this doesn't work at all as we imagined :-( I had a look at what Weston is doing for brightness. It uses a forked libbacklight which internally interacts with the sysfs brighness helpers. I integrated this into KWin and tried to change backlight. But this obviously did not work as only root user is allowed to write to the sysfs file. I then tried to open it with the logind wrapper, but logind doesn't have support for this kind of files, so that unfortunately doesn't work either. And here, poor fool, I stand once more, no wiser than I was before. We have a file only root can write to, but we are not root. Adding a KAuth helper to KWin would not gain us anything compared to having it in powerdevil. So I suggest that we drop the idea that KWin is responsible for backlight and move this feature completely to powerdevil and use the KAuth helper. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [kubuntu-devel] Re: git moves
* Martin Klapetek martin.klape...@gmail.com [2015-08-12 12:25:27 -0400]: On Tue, Aug 11, 2015 at 7:30 AM, Jonathan Riddell j...@jriddell.org wrote: On Tue, Aug 11, 2015 at 01:18:20PM +0200, Valentin Rusu wrote: * Jonathan Riddell j...@jriddell.org [2015-08-05 18:11:56 +0200]: some changes to pkg-kde git today: I added kwallet-pam to plasma Why not include the kwallet-pam module in the kwallet framework? The src/runtime would be the perfect place for that module and users would have all the required pieces together. If nobody is against this merging - and to be sure I copy kde-frameworks-devel - then it's a matter of importing the kwallet-map repo into a directory under kwallet/src/runtime. I could help with that. This is a change in Plasma release tars (rather than Kubuntu packaging) and it was added there because Martin K said it was ported and should be released, and I think his motivation was just that enough people bugged him that he made Alex's work compile. But nobody is around who especially wants to maintain it so if you want to move it into wallet framework that would be very welcome. What Jonathan said. +1 from me to move it. Though keep in mind that this is for kwallet4 as well and so it needs to be compilable for kwallet4 too, somehow. Which might make the KWallet(5) CMake foo a bit too complicated. So, actually, it might be better off on its own as long as kwallet4 is supported. Oh, I'm against mixing code for kwallet4 in KF5::Wallet. So let it live in its own repo until we'll stop the 4 version. Cheers, -- Valentin Rusu IRC: valir ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124923: Plasma 5 color picker plasmoid
On Aug. 25, 2015, 9:22 p.m., Thomas Pfeiffer wrote: Great work! Two points: 1. The two icons in the Plasmoid look like they're two separate Plasmoids, which is confusing. They should be more visually connected (we're still brainstorming ideas for how to do this in the VDG) 2. Latex color doesn't have anything to do with fetish, but it's the color code that LaTeX uses (see https://en.wikibooks.org/wiki/LaTeX/Colors#Color_Models ). I don't know how many LaTeX users actually need this, but it might be premature to just remove it. Kai Uwe Broulik wrote: 2.) I already got complaints about this on IRC, so I'll bring it back :D I don't think it's an issue that it looks like two separate plasmoids: those are two semi independent functions that if they happen to belong to the same plasmoid or not is no concern to the user - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/#review84368 --- On Aug. 25, 2015, 6:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/ --- (Updated Aug. 25, 2015, 6:19 p.m.) Review request for Plasma and KDE Usability. Repository: kdeplasma-addons Description --- This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier. Clicking the drop (it's color-picker, I would expect a pipette icon) enters picker mode, where you can click anywhere on the screen and have the color code (in a format you can configure) copied to your clipboard. Clicking the color blob opens the history, showing the recentmost 9 colors (so it's a nice grid) which allow copying their respective color codes in various formats. Activating the plasmoid (pressing the configured shortcut) will by default enter color picking mode, alternatively it brings up the popup like any other plasmoid. Diffs - applets/CMakeLists.txt c60c350 applets/colorpicker/CMakeLists.txt PRE-CREATION applets/colorpicker/Messages.sh PRE-CREATION applets/colorpicker/package/contents/code/logic.js PRE-CREATION applets/colorpicker/package/contents/config/config.qml PRE-CREATION applets/colorpicker/package/contents/config/main.xml PRE-CREATION applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION applets/colorpicker/package/contents/ui/main.qml PRE-CREATION applets/colorpicker/package/metadata.desktop PRE-CREATION applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION applets/colorpicker/plugin/grabwidget.h PRE-CREATION applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION applets/colorpicker/plugin/qmldir PRE-CREATION applets/kolourpicker/CMakeLists.txt 522e0de applets/kolourpicker/Messages.sh 072def0 applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc applets/kolourpicker/kolourpicker.h bde3ff7 applets/kolourpicker/kolourpicker.cpp a4b0ea4 applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 Diff: https://git.reviewboard.kde.org/r/124923/diff/ Testing --- - I have the impression that the color picker is off by one pixel horizontally (QRect weirdness?) - It breaks with QT_DEVICE_PIXEL_RATIO (Daviid?) - I didn't test with multiple screens - The first pick after startup of plasmashell/plasmoidviewer is not added to the history for some reason I haven't figured out yet - I removed the Latex color, whatever that was, and added Qt.rgba instead :) as well as CSS colors File Attachments In a panel https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png On the desktop https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png History https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png Formats menu https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124944: Fix a crash.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/#review84436 --- Ship it! Ship It! - Martin Klapetek On Aug. 27, 2015, 1:03 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/ --- (Updated Aug. 27, 2015, 1:03 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- We already have configDlg-setAttribute(Qt::WA_DeleteOnClose) we don't need to be quite so enthusiastic. If we remove a config action, close any open dialogs for that action BUG: 351748 Diffs - shell/currentcontainmentactionsmodel.cpp 011e4ecc363d88ed74f187528458b2f01cb5aed6 Diff: https://git.reviewboard.kde.org/r/124944/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124944: Fix a crash.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/ --- (Updated Aug. 26, 2015, 11:36 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit a084eaa48408f907a8038fa626cb46f38396b9d6 by David Edmundson to branch Plasma/5.4. Repository: plasma-workspace Description --- We already have configDlg-setAttribute(Qt::WA_DeleteOnClose) we don't need to be quite so enthusiastic. If we remove a config action, close any open dialogs for that action BUG: 351748 Diffs - shell/currentcontainmentactionsmodel.cpp 011e4ecc363d88ed74f187528458b2f01cb5aed6 Diff: https://git.reviewboard.kde.org/r/124944/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124945: [panelconfiguration] Provide press feedback for Edge/SizeHandle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124945/ --- Review request for Plasma. Repository: plasma-desktop Description --- This makes the buttons look pressed when pressing the handles since the MEL steals the press from the button. Kai's patch gave me an idea, and by the time I tried it I had a patch. Credit goes to him (well 50% maybe) Diffs - desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml 0b7efd34a4ff3e19c5791f5c2d55098e7ce2fc12 desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml a88fe201db56e382918b31b54ff91a3f1b9eb2ae Diff: https://git.reviewboard.kde.org/r/124945/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124937: Add comment/description to keyboard kded module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 27, 2015, 5:23 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit b5d7f757c86668fb8184c2b4bc38b90adcc59d74 by Ragnar Thomsen to branch master. Repository: plasma-desktop Description --- The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm. AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment: `Enables system tray for changing keyboard layout` If the module provides other functionality, we can revise the comment. Diffs - kcms/keyboard/keyboard.desktop 43ae1f1 Diff: https://git.reviewboard.kde.org/r/124937/diff/ Testing --- A description is now provided in the kded kcm. File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png Thanks, Ragnar Thomsen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 147 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/147/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Aug 2015 05:23:44 + Build duration: 10 min CHANGE SET Revision b5d7f757c86668fb8184c2b4bc38b90adcc59d74 by Ragnar Thomsen: (Add a comment to the keyboard kded module desktop file) change: edit kcms/keyboard/keyboard.desktop ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
