Re: Review Request 125248: Display name of process which blocks umount / eject

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125248/#review86933
---

Ship it!


Good stuff. You can fix those and push directly.


dataengines/devicenotifications/ksolidnotify.cpp (line 142)


You could check the list before appending to it (contains()), I think in 
the end it might be more performant as you'll be only appending to the list, 
not removing from it and moving the items in the list.



dataengines/devicenotifications/ksolidnotify.cpp (line 162)


This should say "Could not safely remove.." to match the applet action 
description


- Martin Klapetek


On Sept. 16, 2015, 11:49 p.m., Igor Poboiko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125248/
> ---
> 
> (Updated Sept. 16, 2015, 11:49 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> An attempt to implement feature from [bug 
> 96107](https://bugs.kde.org/show_bug.cgi?id=96107) (see summary).
> 
> On umount/eject error it runs "lsof" executable, gets PIDs of blocking 
> processes and obtains names of processes via KSysGuard::Process machinery. 
> Finally it appends obtained information to error message which is shown in 
> tooltip of Device Notifier applet.
> 
> 
> Diffs
> -
> 
>   dataengines/devicenotifications/CMakeLists.txt 3f7fd83 
>   dataengines/devicenotifications/ksolidnotify.h a471d50 
>   dataengines/devicenotifications/ksolidnotify.cpp 35d49d6 
> 
> Diff: https://git.reviewboard.kde.org/r/125248/diff/
> 
> 
> Testing
> ---
> 
> Tested unmount on busy device with several processes blocking it. Did not 
> test eject, since I have no optical disc drive :(
> 
> 
> File Attachments
> 
> 
> Applet with error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/15/3b1b64fc-abff-4633-9dca-621388edf086__snapshot11.png
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

[Uri Herrera]

> On Oct. 13, 2015, 12:12 p.m., Marco Martin wrote:
> > I tried the script on some elements, doesn't work with all of the svgs but 
> > the result seems pretty good,
> > here is the theme with the questionable "wonton soup" color theme
> > http://imgur.com/g5tsNs6
> > 
> > so it seems feasible, maybe ~1 day work to get all of it done, how do we 
> > go, plasma-framework branch?
> 
> Uri Herrera wrote:
> I think that if it's not going to be included as the main theme because 
> it needs to be fixed or whatever else that needs to be done to the theme it's 
> better that it remains in my github repo and push the changes there. And then 
> when it's ready push it plasma-framework.
> 
> Martin Gräßlin wrote:
> @Uri: KDE doesn't work on github. If you want that others collaborate, it 
> would be better if the code goes into plasma-framework. This can be done 
> either by a branch or by a personal clone.
> 
> Marco Martin wrote:
> If i put it as a branch of plasma-framework is ok?

Yes.


- Uri


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125568/#review86801
---


On Oct. 11, 2015, 9:17 p.m., Uri Herrera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125568/
> ---
> 
> (Updated Oct. 11, 2015, 9:17 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> SVG elements done from scratch, reused only a small portion of the existing 
> files. Colors now match Breeze colorscheme. Buttons now match widget style. 
> Icons in the system tray are taken from the icon theme. Icons in Kickoff are 
> not monochromatic as only 16px and 22px icons are monochrome in Breeze. 
> Better padding overall for elements. New visual for both task manager widgets 
> that matches the states of the buttons. Checkboxes, radio buttons, sliders 
> and scrollbars now have the colors used in the Breeze colorscheme.
> 
> 
> Diffs
> -
> 
> 
> Diff: https://git.reviewboard.kde.org/r/125568/diff/
> 
> 
> Testing
> ---
> 
> ![Before](http://i.imgur.com/Cz2JNee.png)
> ![After](http://i.imgur.com/hiZlyrb.png)
> 
> ![Elements after](http://i.imgur.com/uMFsMzp.png)
> ![Elements before](http://i.imgur.com/pIs1CZ2.png)
> 
> 
> Thanks,
> 
> Uri Herrera
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[David Edmundson]

> On Oct. 16, 2015, 8:24 p.m., Martin Gräßlin wrote:
> > did you try whether the proxy works without compositing? I just hit the 
> > "suspend compositing" global shortcut to test something and it gave me bad 
> > rendering results in the davetray area.

I have. For me it works (for most clients at least), though I do have known bug 
reports of xembedsniproxy leaving garbage in the background behind the icon


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86935
---


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86935
---


did you try whether the proxy works without compositing? I just hit the 
"suspend compositing" global shortcut to test something and it gave me bad 
rendering results in the davetray area.

- Martin Gräßlin


On Oct. 16, 2015, 1:22 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 1:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Marco Martin]

> On Oct. 16, 2015, 3:14 p.m., Andrew Lake wrote:
> > Is it fair to interpret this as a possible path to reducing the duplication 
> > of icons between the main icon theme and the plasma theme?

yes, I want to keep some main ones in the plasma theme as some icons are 
actually composed from multiple elements in the same file and in general is 
slightly faster, but apart the main classical systray ones, some duplication 
could be removed


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86927
---


On Oct. 16, 2015, 2:48 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 2:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125654: Use shared engine in ksplashqml

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125654/#review86909
---


+1, looks good to me


ksplash/ksplashqml/splashapp.cpp (line 127)


not only is it more correct as you write in the summary, it is also wrong. 
We want the splash screen to cover everything (like a fullscreen window), so 
excluding the panels was clearly wrong.


- Martin Gräßlin


On Oct. 16, 2015, 12:18 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125654/
> ---
> 
> (Updated Oct. 16, 2015, 12:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As Martin G analysed in kscreenlocker_greet this cuts down a lot of time
> on dual monitors.
> 
> 
> -
> 
> Don't include struts in initial ksplash geometry
> 
> We initially set a ksplash window to a screen's availableGeometry then
> monitored and screen->geometry. Using a mix is definitely wrong.
> 
> Won't make any practical difference as this is all started long before
> plasmashell, but it's technically more correct.
> 
> 
> Diffs
> -
> 
>   ksplash/ksplashqml/splashwindow.h 2afda0b3523ee0a3218f711dadf391e2128ecf8b 
>   ksplash/ksplashqml/splashapp.cpp 570c65c3e4b71595977162b6ec81f2309552839e 
>   ksplash/ksplashqml/CMakeLists.txt ce55b8e6ca7e8556935325fdee86d396cdce77fb 
>   ksplash/ksplashqml/splashwindow.cpp 
> 3e00ebac617fe49d7d25c08c86ec1f8975f957e1 
> 
> Diff: https://git.reviewboard.kde.org/r/125654/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125654: Use shared engine in ksplashqml

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125654/#review86910
---

Ship it!


+2 for sharing the engine

- Marco Martin


On Oct. 16, 2015, 10:18 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125654/
> ---
> 
> (Updated Oct. 16, 2015, 10:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As Martin G analysed in kscreenlocker_greet this cuts down a lot of time
> on dual monitors.
> 
> 
> -
> 
> Don't include struts in initial ksplash geometry
> 
> We initially set a ksplash window to a screen's availableGeometry then
> monitored and screen->geometry. Using a mix is definitely wrong.
> 
> Won't make any practical difference as this is all started long before
> plasmashell, but it's technically more correct.
> 
> 
> Diffs
> -
> 
>   ksplash/ksplashqml/splashwindow.h 2afda0b3523ee0a3218f711dadf391e2128ecf8b 
>   ksplash/ksplashqml/splashapp.cpp 570c65c3e4b71595977162b6ec81f2309552839e 
>   ksplash/ksplashqml/CMakeLists.txt ce55b8e6ca7e8556935325fdee86d396cdce77fb 
>   ksplash/ksplashqml/splashwindow.cpp 
> 3e00ebac617fe49d7d25c08c86ec1f8975f957e1 
> 
> Diff: https://git.reviewboard.kde.org/r/125654/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125654: Use shared engine in ksplashqml

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125654/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

As Martin G analysed in kscreenlocker_greet this cuts down a lot of time
on dual monitors.


-

Don't include struts in initial ksplash geometry

We initially set a ksplash window to a screen's availableGeometry then
monitored and screen->geometry. Using a mix is definitely wrong.

Won't make any practical difference as this is all started long before
plasmashell, but it's technically more correct.


Diffs
-

  ksplash/ksplashqml/splashwindow.h 2afda0b3523ee0a3218f711dadf391e2128ecf8b 
  ksplash/ksplashqml/splashapp.cpp 570c65c3e4b71595977162b6ec81f2309552839e 
  ksplash/ksplashqml/CMakeLists.txt ce55b8e6ca7e8556935325fdee86d396cdce77fb 
  ksplash/ksplashqml/splashwindow.cpp 3e00ebac617fe49d7d25c08c86ec1f8975f957e1 

Diff: https://git.reviewboard.kde.org/r/125654/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 351693] Screen brightness is not restored after screen unlock (idle time)

[Fabrizio Ruggeri via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=351693

Fabrizio Ruggeri  changed:

   What|Removed |Added

 CC||fabrizio.rugg...@gmail.com

--- Comment #1 from Fabrizio Ruggeri  ---
I have exactly the same problem on a Dell latitude E6540

If I can add some more informations let me know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 351693] Screen brightness is not restored after screen unlock (idle time)

[Fabrizio Ruggeri via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=351693

--- Comment #2 from Fabrizio Ruggeri  ---
Kubuntu 15.04
Kde platform version 4.14.8
Kde plasma version 5.3.2
Qt version 5.4.1
Kernel: 3.19.0-30-generic (64bit)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: HIG and components API

[Marco Martin]

On Thursday 08 October 2015 18:18:24 Thomas Pfeiffer wrote:
> Another thing about the context drawer:
> Would it be possible to center the list of actions vertically so that it's
> easier to reach with the thumb (at least if it has only a few actions)?

Another question about the context view:
do you see those actions more completely linked with the current "page", so 
that each page has a fixed set of actions or more dependent from other things, 
like what item is selected in a list?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

[Marco Martin]

> On Oct. 13, 2015, 12:12 p.m., Marco Martin wrote:
> > I tried the script on some elements, doesn't work with all of the svgs but 
> > the result seems pretty good,
> > here is the theme with the questionable "wonton soup" color theme
> > http://imgur.com/g5tsNs6
> > 
> > so it seems feasible, maybe ~1 day work to get all of it done, how do we 
> > go, plasma-framework branch?
> 
> Uri Herrera wrote:
> I think that if it's not going to be included as the main theme because 
> it needs to be fixed or whatever else that needs to be done to the theme it's 
> better that it remains in my github repo and push the changes there. And then 
> when it's ready push it plasma-framework.
> 
> Martin Gräßlin wrote:
> @Uri: KDE doesn't work on github. If you want that others collaborate, it 
> would be better if the code goes into plasma-framework. This can be done 
> either by a branch or by a personal clone.

If i put it as a branch of plasma-framework is ok?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125568/#review86801
---


On Oct. 11, 2015, 9:17 p.m., Uri Herrera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125568/
> ---
> 
> (Updated Oct. 11, 2015, 9:17 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> SVG elements done from scratch, reused only a small portion of the existing 
> files. Colors now match Breeze colorscheme. Buttons now match widget style. 
> Icons in the system tray are taken from the icon theme. Icons in Kickoff are 
> not monochromatic as only 16px and 22px icons are monochrome in Breeze. 
> Better padding overall for elements. New visual for both task manager widgets 
> that matches the states of the buttons. Checkboxes, radio buttons, sliders 
> and scrollbars now have the colors used in the Breeze colorscheme.
> 
> 
> Diffs
> -
> 
> 
> Diff: https://git.reviewboard.kde.org/r/125568/diff/
> 
> 
> Testing
> ---
> 
> ![Before](http://i.imgur.com/Cz2JNee.png)
> ![After](http://i.imgur.com/hiZlyrb.png)
> 
> ![Elements after](http://i.imgur.com/uMFsMzp.png)
> ![Elements before](http://i.imgur.com/pIs1CZ2.png)
> 
> 
> Thanks,
> 
> Uri Herrera
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125655: Xembed SNI Proxy

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

The goal of this project is to make xembed system trays available in Plasma.

This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
available in Plasma which only supports StatusNotifierItem [2].

Ideally we also want this to work in an xwayland session, making X system tray 
icons available even when plasmashell only has a wayland connection.

How it works (in theory)

* We register a window as a system tray container
* We render embeded windows composited offscreen
* We render contents into an image and send this over DBus via the SNI protocol
* XDamage events trigger a repaint
* Activate and context menu events are replyed via X send event into the 
embedded container as left and right clicks


Code is a mix of hacks and bodges bashing client apps into place, and I happily 
acknowledge it looks pretty bad. Unfotunately most of it seems to be needed, 
but I'd love to be proved wrong on most of it.

---

CMakeLists changes are obviously currently wrong, I can strip half of 
find_packages and I need an add_subdirectory in the root file, but it's easier 
for me to sync with the separate repo mirror this way till we're close to 
merging. I expect this to take quite some revisions.


Diffs
-

  xembedsniproxy/CMakeLists.txt PRE-CREATION 
  xembedsniproxy/Readme.md PRE-CREATION 
  xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
  xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
  xembedsniproxy/main.cpp PRE-CREATION 
  xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
  xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
  xembedsniproxy/snidbus.h PRE-CREATION 
  xembedsniproxy/snidbus.cpp PRE-CREATION 
  xembedsniproxy/sniproxy.h PRE-CREATION 
  xembedsniproxy/sniproxy.cpp PRE-CREATION 
  xembedsniproxy/xcbutils.h PRE-CREATION 
  xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125655/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86912
---


Overall looks good! General comments:
* please use KSelectionOwner
* please disable cast to/from ascii
* please add unit test (yes I know, difficult, but should be possible)


xembedsniproxy/CMakeLists.txt (line 50)


are you sure you want -Wall. The last project I tried to build with that 
flag was unbuildable.

I'm mostly concerned that this causes problems when compilers start to add 
more warnings and perfectly no-warning code starts to fail to build for other 
devs.



xembedsniproxy/CMakeLists.txt (line 67)


variable called kwin_XCB_LIBS?



xembedsniproxy/fdoselectionmanager.h (line 31)


you are aware that we have a class in KWindowSystem doing that? see 
http://api.kde.org/frameworks-api/frameworks5-apidocs/kwindowsystem/html/classKSelectionOwner.html



xembedsniproxy/fdoselectionmanager.h (line 44)


suggestion: Don't use WId. Use either xcb_window_t (as those two below) or 
uint32_t or quint32. WId is just something weird for multi-platform.



xembedsniproxy/fdoselectionmanager.h (lines 50 - 51)


same here, you want xcb_window_t



xembedsniproxy/fdoselectionmanager.cpp (lines 51 - 55)


the reply->first_event should also only be read if the reply->present is 
true.

In addition: what's the strategy for damage extension not available? My 
suggestion would be: error mesage and quit.



xembedsniproxy/fdoselectionmanager.cpp (line 64)


qCDebug?



xembedsniproxy/main.cpp (line 35)


please enforce platform XCB, you are using X11 unconditionally.



xembedsniproxy/main.cpp (line 43)


QScopedPointer



xembedsniproxy/sniproxy.h (lines 42 - 50)


hmm?



xembedsniproxy/sniproxy.cpp (line 119)


please do even one more thing (if possible): render once to it with a 
translucent background. The tricky part is to get the correct depth for it.



xembedsniproxy/sniproxy.cpp (lines 180 - 183)


maybe you could use the sync protocol?



xembedsniproxy/sniproxy.cpp (line 218)


no cast from ascii please ;-)



xembedsniproxy/sniproxy.cpp (line 239)


same here: no cast from ascii


- Martin Gräßlin


On Oct. 16, 2015, 1:22 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 1:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   

Re: Qt 5.5

[Jonathan Riddell]

build.kde.org has qt 5.5 from 18 september, there are build failures since then

https://build.kde.org/view/QT/job/qt5%205.5%20kf5-qt5/

Harald says he was able to do builds on Kubuntu CI of 5.5 so we should have 
that next week.

I'll ask other distros if they have any problems

Jonathan



On Thu, Oct 15, 2015 at 11:07:33PM +0100, David Edmundson wrote:
> Yes please.
> 
> This has come up before, from the Plasma 5.5 kickoff meeting IRC log:
> 
> [Wednesday, August 26, 2015] [3:27:51 PM BST]     oooh important topic
> [Wednesday, August 26, 2015] [3:27:55 PM BST]     dependenign on Qt 5.5
> [Wednesday, August 26, 2015] [3:28:06 PM BST]     sebas: added
> [Wednesday, August 26, 2015] [3:28:16 PM BST]     d_ed: +1
> [Wednesday, August 26, 2015] [3:28:32 PM BST]     that means making
> finally that text selection thing work (qt patches are upstreamed now) and see
> how i can do in controls that would need to be completely different (like 
> Menu)
> [Wednesday, August 26, 2015] [3:28:53 PM BST]     depending on 5.5:
> sure
> [Wednesday, August 26, 2015] [3:28:56 PM BST]     notmart: 2 items
> added to todo
> [Wednesday, August 26, 2015] [3:29:02 PM BST]     we need to check
> with sysadmins that they have 5.5 before we start depending
> [Wednesday, August 26, 2015] [3:29:19 PM BST]     ok, do you want to do
> that?
> [Wednesday, August 26, 2015] [3:29:19 PM BST]     for some phone 
> stuff
> in reality even 5.5 is enough anymore tough
> [Wednesday, August 26, 2015] [3:29:31 PM BST]     anyway gotta go
> [Wednesday, August 26, 2015] [3:29:31 PM BST]     can do that
> 
> (regarding the sysadmin topic, we have that on Jenkins since Randa)
> 
> David

> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt 5.5

[David Edmundson]

​The build.k.o failure:

*18:19:49*  fatal error: error writing to /tmp/ccTA71Ud.s: No space
left on device

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

This makes IconItem try to load global icons from the theme with Plasma::Svg as 
well, making it assign the colors from the stylesheet if the breeze monochrome 
icons are treated, that should be scriptable, from some attempts i did the 
script seems to convert them correctly, without any change in rendering.

This will automatically color monochrome breeze icons only in plasmashell, and 
more specifically only those that use IconItem, not QIconItem (iconitem should 
probably have an animation-less mode to be able to be used in taskmanager and 
stuff)
perhaps in the future we'll be able somehow to hook all this stuff in 
QIconEngine to be able to use it in QWidget applications, but since QIcon does 
have any idea where it is, is not usable yet for things like the fullscreen 
fixed-dark gwenview view.


Diffs
-

  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/plasma/private/svg_p.h ab91c42 
  src/plasma/svg.h 3ad21ce 
  src/plasma/svg.cpp 37ced22 
  src/tools/apply-stylesheet.sh 797c5fd 

Diff: https://git.reviewboard.kde.org/r/125657/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[Marco Martin]

> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote:
> > xembedsniproxy/sniproxy.h, lines 42-50
> > 
> >
> > hmm?
> 
> David Edmundson wrote:
> ah right, I need some advice on here. 
> 
> There are properties that exist in the SNI spec that I can't do anything 
> with. 
> Should I return blank values, or return DBus errors?
> 
> Currently I do the latter.
> Our plasma dataengine handles that fine, but I'm not sure which is more 
> semantically correct.

maybe dbus errors are more likely to crap out on other implementations? (no 
idea how to test this on unity)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86912
---


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86919
---


finally :D


xembedsniproxy/sniproxy.cpp (line 223)


kstatusnotifieritem uses the window title for that.. even tough is not 
great at all (that reminds me we should eventually put a setter for this that 
should use reverse domains..)



xembedsniproxy/sniproxy.cpp (line 274)


else?


- Marco Martin


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125307/
---

(Updated Oct. 16, 2015, 2:07 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
---

It is now possible to set preferred icon theme in desktoptheme metadata.desktop.

As discussed on ML, this fixes using light breeze icon theme with breeze dark 
desktoptheme.


Diffs
-

  src/plasma/theme.cpp c49ad4c 
  src/plasma/private/theme_p.cpp 31a6512 
  src/plasma/theme.h 3f49719 
  src/desktoptheme/breeze/metadata.desktop 07bbfc3 
  src/plasma/private/theme_p.h 5b8f71c 
  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/desktoptheme/breeze-dark/metadata.desktop 77647a4 

Diff: https://git.reviewboard.kde.org/r/125307/diff/


Testing
---

Icon theme is picked correctly with PlasmaCore.IconItem. Changing the 
desktoptheme updates the icons.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[David Edmundson]

> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote:
> > xembedsniproxy/sniproxy.h, lines 42-50
> > 
> >
> > hmm?

ah right, I need some advice on here. 

There are properties that exist in the SNI spec that I can't do anything with. 
Should I return blank values, or return DBus errors?

Currently I do the latter.
Our plasma dataengine handles that fine, but I'm not sure which is more 
semantically correct.


> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote:
> > xembedsniproxy/CMakeLists.txt, line 50
> > 
> >
> > are you sure you want -Wall. The last project I tried to build with 
> > that flag was unbuildable.
> > 
> > I'm mostly concerned that this causes problems when compilers start to 
> > add more warnings and perfectly no-warning code starts to fail to build for 
> > other devs.

That's just turns on warnings, I think you're thinking of that "treat all 
warnings as fatal" flag.

but anyway see CMake comment in description, I'll strip this before merging.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86912
---


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[Martin Gräßlin]

> On Oct. 16, 2015, 2:34 p.m., Martin Gräßlin wrote:
> > xembedsniproxy/CMakeLists.txt, line 50
> > 
> >
> > are you sure you want -Wall. The last project I tried to build with 
> > that flag was unbuildable.
> > 
> > I'm mostly concerned that this causes problems when compilers start to 
> > add more warnings and perfectly no-warning code starts to fail to build for 
> > other devs.
> 
> David Edmundson wrote:
> That's just turns on warnings, I think you're thinking of that "treat all 
> warnings as fatal" flag.
> 
> but anyway see CMake comment in description, I'll strip this before 
> merging.

ah yes, sorry. I thought it's treat all warnings as fatal.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86912
---


On Oct. 16, 2015, 1:22 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 1:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86916
---



src/declarativeimports/core/iconitem.cpp (line 134)


update this



src/declarativeimports/core/iconitem.cpp (line 141)






src/declarativeimports/core/iconitem.cpp (lines 341 - 348)


it looks like you already do all this on line 142 of this diff.


- David Edmundson


On Oct. 16, 2015, 1:10 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 1:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
>   src/tools/apply-stylesheet.sh 797c5fd 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/
---

(Updated Oct. 16, 2015, 1:26 p.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

This makes IconItem try to load global icons from the theme with Plasma::Svg as 
well, making it assign the colors from the stylesheet if the breeze monochrome 
icons are treated, that should be scriptable, from some attempts i did the 
script seems to convert them correctly, without any change in rendering.

This will automatically color monochrome breeze icons only in plasmashell, and 
more specifically only those that use IconItem, not QIconItem (iconitem should 
probably have an animation-less mode to be able to be used in taskmanager and 
stuff)
perhaps in the future we'll be able somehow to hook all this stuff in 
QIconEngine to be able to use it in QWidget applications, but since QIcon does 
have any idea where it is, is not usable yet for things like the fullscreen 
fixed-dark gwenview view.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/plasma/private/svg_p.h ab91c42 
  src/plasma/svg.h 3ad21ce 
  src/plasma/svg.cpp 37ced22 

Diff: https://git.reviewboard.kde.org/r/125657/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86927
---


Is it fair to interpret this as a possible path to reducing the duplication of 
icons between the main icon theme and the plasma theme?

- Andrew Lake


On Oct. 16, 2015, 2:48 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 2:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[David Edmundson]

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote:
> > xembedsniproxy/sniproxy.cpp, line 274
> > 
> >
> > else?

ah yes, forgot to finish that

Does anyone have a mouse with a horizontal scroll? If so can you open "xev" and 
tell me what button index is for left and right?

The XCB docs are particularly unhelpful:

>
> XCB_BUTTON_INDEX_4
>   Scroll wheel. TODO: direction?
>
> XCB_BUTTON_INDEX_5
>   Scroll wheel. TODO: direction?
 
from
http://stuff.onse.fi/man?program=xcb_grab_button_checked=3

Thanks XCB!


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86919
---


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125660: Use PlasmaCore.IconItem in desktop toolbox

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125660/#review86921
---

Ship it!


Ship It!

- David Edmundson


On Oct. 16, 2015, 2:16 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125660/
> ---
> 
> (Updated Oct. 16, 2015, 2:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Unlike QIconItem, IconItem can use SVG icons from Plasma theme.
> 
> 
> Diffs
> -
> 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 481ae5e 
> 
> Diff: https://git.reviewboard.kde.org/r/125660/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125660: Use PlasmaCore.IconItem in desktop toolbox

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125660/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

Unlike QIconItem, IconItem can use SVG icons from Plasma theme.


Diffs
-

  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 481ae5e 

Diff: https://git.reviewboard.kde.org/r/125660/diff/


Testing
---


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[David Rosca]

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote:
> > xembedsniproxy/sniproxy.cpp, line 274
> > 
> >
> > else?
> 
> David Edmundson wrote:
> ah yes, forgot to finish that
> 
> Does anyone have a mouse with a horizontal scroll? If so can you open 
> "xev" and tell me what button index is for left and right?
> 
> The XCB docs are particularly unhelpful:
> 
> >
> > XCB_BUTTON_INDEX_4
> >   Scroll wheel. TODO: direction?
> >
> > XCB_BUTTON_INDEX_5
> >   Scroll wheel. TODO: direction?
>  
> from
> http://stuff.onse.fi/man?program=xcb_grab_button_checked=3
> 
> Thanks XCB!
> 
> Marco Martin wrote:
> emulating it with the touchpad (enabling horizontal edge scrolling) tells 
> me button 6 and 7.
> a real mouse with an horizontal wheel.. no idea if i ever seen one ;)
> 
> David Edmundson wrote:
> that's left == 6 right ==7 ?

It is button 6 and 7, indeed. I have a mouse with horizontal scrolling (that is 
I can push the wheel to left/right to scroll) :)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86919
---


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[Marco Martin]

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote:
> > xembedsniproxy/sniproxy.cpp, line 274
> > 
> >
> > else?
> 
> David Edmundson wrote:
> ah yes, forgot to finish that
> 
> Does anyone have a mouse with a horizontal scroll? If so can you open 
> "xev" and tell me what button index is for left and right?
> 
> The XCB docs are particularly unhelpful:
> 
> >
> > XCB_BUTTON_INDEX_4
> >   Scroll wheel. TODO: direction?
> >
> > XCB_BUTTON_INDEX_5
> >   Scroll wheel. TODO: direction?
>  
> from
> http://stuff.onse.fi/man?program=xcb_grab_button_checked=3
> 
> Thanks XCB!

emulating it with the touchpad (enabling horizontal edge scrolling) tells me 
button 6 and 7.
a real mouse with an horizontal wheel.. no idea if i ever seen one ;)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86919
---


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86922
---



src/declarativeimports/core/iconitem.cpp (line 144)


useSystemColors is false by default


- David Rosca


On Oct. 16, 2015, 1:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 1:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 214 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 16 Oct 2015 14:18:48 +
Build duration: 7 min 45 sec

CHANGE SET
Revision 44fb5c45abc05a8bbc19d6fe65b6c5037e5d8a5b by David Edmundson: (Use 
shared engine in ksplashqml)
  change: edit ksplash/ksplashqml/CMakeLists.txt
  change: edit ksplash/ksplashqml/splashwindow.h
  change: edit ksplash/ksplashqml/splashwindow.cpp
Revision d6ea77ca6a7574d2159235714e105ea7ba2e1a7a by David Edmundson: 
(Dont include struts in initial ksplash geometry)
  change: edit ksplash/ksplashqml/splashapp.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 14/14 (100%)FILES 61/71 (86%)CLASSES 61/71 (86%)LINE 2501/4101 
(61%)CONDITIONAL 1471/2288 (64%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 302/422 (72%)CONDITIONAL 
436/495 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/149 (74%)CONDITIONAL 
40/70 (57%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
ksmserver.screenlocker
FILES 9/11 (82%)CLASSES 9/11 (82%)LINE 489/1039 
(47%)CONDITIONAL 145/225 (64%)
ksmserver.screenlocker.autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 165/169 (98%)CONDITIONAL 
65/124 (52%)
ksmserver.screenlocker.greeter
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 99/144 (69%)CONDITIONAL 
36/60 (60%)
ksmserver.screenlocker.greeter.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 45/45 (100%)CONDITIONAL 
34/68 (50%)
libkworkspace
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 26/608 (4%)CONDITIONAL 
21/35 (60%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/160 (54%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 96/100 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 214 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 16 Oct 2015 14:18:48 +
Build duration: 7 min 45 sec

CHANGE SET
Revision 44fb5c45abc05a8bbc19d6fe65b6c5037e5d8a5b by David Edmundson: (Use 
shared engine in ksplashqml)
  change: edit ksplash/ksplashqml/CMakeLists.txt
  change: edit ksplash/ksplashqml/splashwindow.h
  change: edit ksplash/ksplashqml/splashwindow.cpp
Revision d6ea77ca6a7574d2159235714e105ea7ba2e1a7a by David Edmundson: 
(Dont include struts in initial ksplash geometry)
  change: edit ksplash/ksplashqml/splashapp.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 14/14 (100%)FILES 61/71 (86%)CLASSES 61/71 (86%)LINE 2501/4101 
(61%)CONDITIONAL 1471/2288 (64%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 302/422 (72%)CONDITIONAL 
436/495 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/149 (74%)CONDITIONAL 
40/70 (57%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
ksmserver.screenlocker
FILES 9/11 (82%)CLASSES 9/11 (82%)LINE 489/1039 
(47%)CONDITIONAL 145/225 (64%)
ksmserver.screenlocker.autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 165/169 (98%)CONDITIONAL 
65/124 (52%)
ksmserver.screenlocker.greeter
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 99/144 (69%)CONDITIONAL 
36/60 (60%)
ksmserver.screenlocker.greeter.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 45/45 (100%)CONDITIONAL 
34/68 (50%)
libkworkspace
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 26/608 (4%)CONDITIONAL 
21/35 (60%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/160 (54%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 96/100 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[David Edmundson]

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote:
> > xembedsniproxy/sniproxy.cpp, line 274
> > 
> >
> > else?
> 
> David Edmundson wrote:
> ah yes, forgot to finish that
> 
> Does anyone have a mouse with a horizontal scroll? If so can you open 
> "xev" and tell me what button index is for left and right?
> 
> The XCB docs are particularly unhelpful:
> 
> >
> > XCB_BUTTON_INDEX_4
> >   Scroll wheel. TODO: direction?
> >
> > XCB_BUTTON_INDEX_5
> >   Scroll wheel. TODO: direction?
>  
> from
> http://stuff.onse.fi/man?program=xcb_grab_button_checked=3
> 
> Thanks XCB!
> 
> Marco Martin wrote:
> emulating it with the touchpad (enabling horizontal edge scrolling) tells 
> me button 6 and 7.
> a real mouse with an horizontal wheel.. no idea if i ever seen one ;)

that's left == 6 right ==7 ?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86919
---


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125660: Use PlasmaCore.IconItem in desktop toolbox

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125660/
---

(Updated Oct. 16, 2015, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 06084ffea50612d16c7b48666dd9356a153026e0 by David Rosca 
to branch master.


Repository: plasma-desktop


Description
---

Unlike QIconItem, IconItem can use SVG icons from Plasma theme.


Diffs
-

  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 481ae5e 

Diff: https://git.reviewboard.kde.org/r/125660/diff/


Testing
---


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Not able to install on my Nexus 5

[Jonathan Riddell]

> 3. After removing these flags (I'm not sure if removing these two flags is
> right, but does nothing until removed), starts downloading, but after a few
> percentage gets out and says, " unexpected EOF".

Try using my mirror by changing the URLs in the command to 
http://mobile.edinburghlinux.co.uk/

That's on a server in europe, the default one is in australia

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125654: Use shared engine in ksplashqml

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125654/
---

(Updated Oct. 16, 2015, 2:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 44fb5c45abc05a8bbc19d6fe65b6c5037e5d8a5b by David 
Edmundson to branch master.


Repository: plasma-workspace


Description
---

As Martin G analysed in kscreenlocker_greet this cuts down a lot of time
on dual monitors.


-

Don't include struts in initial ksplash geometry

We initially set a ksplash window to a screen's availableGeometry then
monitored and screen->geometry. Using a mix is definitely wrong.

Won't make any practical difference as this is all started long before
plasmashell, but it's technically more correct.


Diffs
-

  ksplash/ksplashqml/splashwindow.h 2afda0b3523ee0a3218f711dadf391e2128ecf8b 
  ksplash/ksplashqml/splashapp.cpp 570c65c3e4b71595977162b6ec81f2309552839e 
  ksplash/ksplashqml/CMakeLists.txt ce55b8e6ca7e8556935325fdee86d396cdce77fb 
  ksplash/ksplashqml/splashwindow.cpp 3e00ebac617fe49d7d25c08c86ec1f8975f957e1 

Diff: https://git.reviewboard.kde.org/r/125654/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125655: Xembed SNI Proxy

[David Rosca]

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote:
> > xembedsniproxy/sniproxy.cpp, line 274
> > 
> >
> > else?
> 
> David Edmundson wrote:
> ah yes, forgot to finish that
> 
> Does anyone have a mouse with a horizontal scroll? If so can you open 
> "xev" and tell me what button index is for left and right?
> 
> The XCB docs are particularly unhelpful:
> 
> >
> > XCB_BUTTON_INDEX_4
> >   Scroll wheel. TODO: direction?
> >
> > XCB_BUTTON_INDEX_5
> >   Scroll wheel. TODO: direction?
>  
> from
> http://stuff.onse.fi/man?program=xcb_grab_button_checked=3
> 
> Thanks XCB!
> 
> Marco Martin wrote:
> emulating it with the touchpad (enabling horizontal edge scrolling) tells 
> me button 6 and 7.
> a real mouse with an horizontal wheel.. no idea if i ever seen one ;)
> 
> David Edmundson wrote:
> that's left == 6 right ==7 ?
> 
> David Rosca wrote:
> It is button 6 and 7, indeed. I have a mouse with horizontal scrolling 
> (that is I can push the wheel to left/right to scroll) :)

> that's left == 6 right ==7 ?

Yes


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86919
---


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> ---
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] 
> available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system 
> tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI 
> protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the 
> embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I 
> happily acknowledge it looks pretty bad. Unfotunately most of it seems to be 
> needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of 
> find_packages and I need an add_subdirectory in the root file, but it's 
> easier for me to sync with the separate repo mirror this way till we're close 
> to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Marco Martin]

> On Oct. 16, 2015, 1:19 p.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, lines 341-348
> > 
> >
> > it looks like you already do all this on line 142 of this diff.

yeah, this is due the peculiarity of icon themes, since they can have different 
images on different sizes (that happens on svgs too, breeze does this a lot) so 
I may have to reload the svg when it gets resized


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86916
---


On Oct. 16, 2015, 1:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 1:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/
---

(Updated Oct. 16, 2015, 2:48 p.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

This makes IconItem try to load global icons from the theme with Plasma::Svg as 
well, making it assign the colors from the stylesheet if the breeze monochrome 
icons are treated, that should be scriptable, from some attempts i did the 
script seems to convert them correctly, without any change in rendering.

This will automatically color monochrome breeze icons only in plasmashell, and 
more specifically only those that use IconItem, not QIconItem (iconitem should 
probably have an animation-less mode to be able to be used in taskmanager and 
stuff)
perhaps in the future we'll be able somehow to hook all this stuff in 
QIconEngine to be able to use it in QWidget applications, but since QIcon does 
have any idea where it is, is not usable yet for things like the fullscreen 
fixed-dark gwenview view.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/plasma/private/svg_p.h ab91c42 
  src/plasma/svg.h 3ad21ce 
  src/plasma/svg.cpp 37ced22 

Diff: https://git.reviewboard.kde.org/r/125657/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125662: mangonel: Initial port to Qt5/KF5

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/
---

Review request for Plasma and Martin Tobias Holmedahl Sandsmark.


Repository: mangonel


Description
---

Port of Mangonel to Qt5/KF5


Diffs
-

  CMakeLists.txt fec95da 
  Label.cpp 136f70b 
  Mangonel.h 9c8a32f 
  Mangonel.cpp 63e10ab 
  main.cpp 1b0c4a3 
  providers/Applications.cpp 7674a97 
  providers/Paths.cpp 713aba3 

Diff: https://git.reviewboard.kde.org/r/125662/diff/


Testing
---

It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe 
we could say it's using Material design and call it good, dunno :p)


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

[Jeremy Whiting]

> On Oct. 16, 2015, 9:58 a.m., Martin Klapetek wrote:
> > Screenshots? ;)

Ok, added a screenshot with breeze dark theme, The colors look ok, but I guess 
Plasma::Dialog may have done some rounded corners or something iirc to make it 
look a bit better or added transparency or something.


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/#review86929
---


On Oct. 16, 2015, 9:42 a.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125662/
> ---
> 
> (Updated Oct. 16, 2015, 9:42 a.m.)
> 
> 
> Review request for Plasma and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: mangonel
> 
> 
> Description
> ---
> 
> Port of Mangonel to Qt5/KF5
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt fec95da 
>   Label.cpp 136f70b 
>   Mangonel.h 9c8a32f 
>   Mangonel.cpp 63e10ab 
>   main.cpp 1b0c4a3 
>   providers/Applications.cpp 7674a97 
>   providers/Paths.cpp 713aba3 
> 
> Diff: https://git.reviewboard.kde.org/r/125662/diff/
> 
> 
> Testing
> ---
> 
> It builds and runs, but looks a bit strange since it's a plani QWidget. 
> (Maybe we could say it's using Material design and call it good, dunno :p)
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/
---

(Updated Oct. 16, 2015, 10:04 a.m.)


Review request for Plasma and Martin Tobias Holmedahl Sandsmark.


Repository: mangonel


Description
---

Port of Mangonel to Qt5/KF5


Diffs
-

  CMakeLists.txt fec95da 
  Label.cpp 136f70b 
  Mangonel.h 9c8a32f 
  Mangonel.cpp 63e10ab 
  main.cpp 1b0c4a3 
  providers/Applications.cpp 7674a97 
  providers/Paths.cpp 713aba3 

Diff: https://git.reviewboard.kde.org/r/125662/diff/


Testing
---

It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe 
we could say it's using Material design and call it good, dunno :p)


File Attachments (updated)


screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png


Thanks,

Jeremy Whiting

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125662/#review86929
---


Screenshots? ;)

- Martin Klapetek


On Oct. 16, 2015, 5:42 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125662/
> ---
> 
> (Updated Oct. 16, 2015, 5:42 p.m.)
> 
> 
> Review request for Plasma and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: mangonel
> 
> 
> Description
> ---
> 
> Port of Mangonel to Qt5/KF5
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt fec95da 
>   Label.cpp 136f70b 
>   Mangonel.h 9c8a32f 
>   Mangonel.cpp 63e10ab 
>   main.cpp 1b0c4a3 
>   providers/Applications.cpp 7674a97 
>   providers/Paths.cpp 713aba3 
> 
> Diff: https://git.reviewboard.kde.org/r/125662/diff/
> 
> 
> Testing
> ---
> 
> It builds and runs, but looks a bit strange since it's a plani QWidget. 
> (Maybe we could say it's using Material design and call it good, dunno :p)
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86932
---



src/declarativeimports/core/iconitem.cpp (line 342)


spaces between operators



src/plasma/svg.h (line 401)


Mention the default (false), please


- Kai Uwe Broulik


On Okt. 16, 2015, 2:48 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Okt. 16, 2015, 2:48 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel