Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 226 - Fixed!

2015-10-25 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/226/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 25 Oct 2015 10:47:02 +
Build duration: 9 min 4 sec

CHANGE SET
Revision 6184a953b1b014070434d99152e48fd77255030e by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit freespacenotifier/freespacenotifier.desktop
  change: edit dataengines/places/plasma-dataengine-places.desktop
  change: edit applets/analog-clock/metadata.desktop
  change: edit phonon/platform_kde/phonon.notifyrc


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 14/14 (100%)FILES 61/71 (86%)CLASSES 61/71 (86%)LINE 2490/4101 
(61%)CONDITIONAL 1468/2282 (64%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 302/422 (72%)CONDITIONAL 
436/495 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/149 (74%)CONDITIONAL 
40/70 (57%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
ksmserver.screenlocker
FILES 9/11 (82%)CLASSES 9/11 (82%)LINE 478/1039 
(46%)CONDITIONAL 142/219 (65%)
ksmserver.screenlocker.autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 165/169 (98%)CONDITIONAL 
65/124 (52%)
ksmserver.screenlocker.greeter
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 99/144 (69%)CONDITIONAL 
36/60 (60%)
ksmserver.screenlocker.greeter.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 45/45 (100%)CONDITIONAL 
34/68 (50%)
libkworkspace
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 26/608 (4%)CONDITIONAL 
21/35 (60%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/160 (54%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 96/100 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 226 - Fixed!

2015-10-25 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/226/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 25 Oct 2015 10:47:02 +
Build duration: 9 min 4 sec

CHANGE SET
Revision 6184a953b1b014070434d99152e48fd77255030e by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit freespacenotifier/freespacenotifier.desktop
  change: edit dataengines/places/plasma-dataengine-places.desktop
  change: edit applets/analog-clock/metadata.desktop
  change: edit phonon/platform_kde/phonon.notifyrc


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 14/14 (100%)FILES 61/71 (86%)CLASSES 61/71 (86%)LINE 2490/4101 
(61%)CONDITIONAL 1468/2282 (64%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 302/422 (72%)CONDITIONAL 
436/495 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/149 (74%)CONDITIONAL 
40/70 (57%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
ksmserver.screenlocker
FILES 9/11 (82%)CLASSES 9/11 (82%)LINE 478/1039 
(46%)CONDITIONAL 142/219 (65%)
ksmserver.screenlocker.autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 165/169 (98%)CONDITIONAL 
65/124 (52%)
ksmserver.screenlocker.greeter
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 99/144 (69%)CONDITIONAL 
36/60 (60%)
ksmserver.screenlocker.greeter.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 45/45 (100%)CONDITIONAL 
34/68 (50%)
libkworkspace
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 26/608 (4%)CONDITIONAL 
21/35 (60%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/160 (54%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 96/100 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 18 - Failure!

2015-10-25 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 25 Oct 2015 10:44:52 +
Build duration: 4 min 36 sec

CHANGE SET
Revision a07d4bfdd1467335861dc452f996e74704be8056 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit data/konqueror_gestures_kde321.khotkeys
  change: edit data/kde32b1.khotkeys
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread Uri Herrera 


> On Oct. 25, 2015, 11:08 p.m., Uri Herrera wrote:
> > I agree with Thomas that having the button inside the thumbnail is 
> > confusing.
> > 
> > ![](http://i.imgur.com/JlZveha.png)
> > 
> > On this image I moved the button outside the thumbnail, used the actual 
> > window-close icon in the icon theme and removed the round button background.
> > 
> > ![](http://i.imgur.com/1gfju2e.png)
> > 
> > On this the button is inside and there's no button background.

I also made the button bigger, currently the button looks really tiny for me.


- Uri


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87385
---


On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> ---
> 
> (Updated Oct. 25, 2015, 9:42 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 350705
> https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I just found this patch I made a while ago. This turns the handmade close 
> button into a regular ToolButton (which is only shown when hovering) with a 
> proper size. Also, the button is always in the top right corner of the 
> *thumbnail* rather than the dialog
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> File Attachments
> 
> 
> New close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread Uri Herrera 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87385
---


I agree with Thomas that having the button inside the thumbnail is confusing.

![](http://i.imgur.com/JlZveha.png)

On this image I moved the button outside the thumbnail, used the actual 
window-close icon in the icon theme and removed the round button background.

![](http://i.imgur.com/1gfju2e.png)

On this the button is inside and there's no button background.

- Uri Herrera


On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> ---
> 
> (Updated Oct. 25, 2015, 9:42 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 350705
> https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I just found this patch I made a while ago. This turns the handmade close 
> button into a regular ToolButton (which is only shown when hovering) with a 
> proper size. Also, the button is always in the top right corner of the 
> *thumbnail* rather than the dialog
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> File Attachments
> 
> 
> New close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread Kai Uwe Broulik 


> On Okt. 25, 2015, 9:12 nachm., Thomas Pfeiffer wrote:
> > Can you please add Andrew for design review? 
> > From a usability perspective, it would be better if the button was outside 
> > the actual thumbnail, to be sure that it cannot be mistaken as part of the 
> > thumbnail.

the button only appears on hovering, so it should be obvious it's not part of 
the thumbnail


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87381
---


On Okt. 25, 2015, 5:06 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> ---
> 
> (Updated Okt. 25, 2015, 5:06 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 350705
> https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I just found this patch I made a while ago. This turns the handmade close 
> button into a regular ToolButton (which is only shown when hovering) with a 
> proper size. Also, the button is always in the top right corner of the 
> *thumbnail* rather than the dialog
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> File Attachments
> 
> 
> New close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-10-25 Thread Thomas Pfeiffer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124675/#review87384
---


As always: If you want design or usability input, please provide a screenshot. 
We cannot read the code. Thanks.

- Thomas Pfeiffer


On Oct. 23, 2015, 11:16 a.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124675/
> ---
> 
> (Updated Oct. 23, 2015, 11:16 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Jens Reuterberg.
> 
> 
> Bugs: 311991
> https://bugs.kde.org/show_bug.cgi?id=311991
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This fixes Bug 311991. Though I am not sure if there are side effects which I 
> am not aware of.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/Task.qml 
> f655801ab1f7b1a9a915f35149c858f0ede22a29 
> 
> Diff: https://git.reviewboard.kde.org/r/124675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125706: Install kconf_update script in kdelibs4 directory

2015-10-25 Thread Siddhartha Sahu 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125706/#review87392
---


The kdelibs4 data directory will usually be "/usr/share/apps/", which is a root 
protected directory. This means unpriviledged kdesrc-builds to a separate 
CMAKE_PREFIX_PATH is now failing, because it does not have permission to write 
to /usr/share/apps/kconf_update/disable_kmix.upd

Ideas on making this work without needing sudo priviledges?

- Siddhartha Sahu


On Oct. 21, 2015, 9:30 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125706/
> ---
> 
> (Updated Oct. 21, 2015, 9:30 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> ---
> 
> Install kconf_update script in kdelibs4 directory because kmix is a kdelibs4 
> application and installing it in kf5 directories won't do anything
> 
> This uses kde4-config.  I looked at using KDELibs4 cmake classes from 
> KDELibs4/KDELibsDependencies.cmake but couldn't work out how to load it in 
> cmake and it has the wrong values set for its variables anyway.
> 
> 
> Diffs
> -
> 
>   data/CMakeLists.txt b652a0f 
> 
> Diff: https://git.reviewboard.kde.org/r/125706/diff/
> 
> 
> Testing
> ---
> 
> Installs to the right place
> When installed it writes the new kmixrc that turns off autostart
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87395
---


Proper close button is welcome. Generally looks good to me, though I do think 
the close button works better with the consistency of the normal background 
rather than the randomness of the thumbnail as a background. Other than that, 
thumbs up from me!

- Andrew Lake


On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> ---
> 
> (Updated Oct. 25, 2015, 9:42 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 350705
> https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I just found this patch I made a while ago. This turns the handmade close 
> button into a regular ToolButton (which is only shown when hovering) with a 
> proper size. Also, the button is always in the top right corner of the 
> *thumbnail* rather than the dialog
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> File Attachments
> 
> 
> New close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125771: Use ecm to allow configuring the install location

2015-10-25 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125771/#review87387
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Oct. 24, 2015, 4:09 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125771/
> ---
> 
> (Updated Oct. 24, 2015, 4:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> This is helpful on a multiarch layout where the prefix is /usr/${host}
> but arch-independent files should still be installed to /usr/share.
> 
> 
> I do not know if it's acceptable for this project to depend on 
> extra-cmake-modules. If not an alternative approach could be introducing a 
> variable like SHARE_INSTALL_PREFIX.
> 
> 
> Diffs
> -
> 
>   Breeze-dark-gtk/CMakeLists.txt c1a4c46 
>   Breeze-gtk/CMakeLists.txt cbd03aa 
>   CMakeLists.txt b977da8 
> 
> Diff: https://git.reviewboard.kde.org/r/125771/diff/
> 
> 
> Testing
> ---
> 
> Installed with -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and 
> -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share/
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/
---

Review request for Plasma and KDE Usability.


Bugs: 350705
https://bugs.kde.org/show_bug.cgi?id=350705


Repository: plasma-desktop


Description
---

I just found this patch I made a while ago. This turns the handmade close 
button into a regular ToolButton (which is only shown when hovering) with a 
proper size. Also, the button is always in the top right corner of the 
*thumbnail* rather than the dialog


Diffs
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/125793/diff/


Testing
---

Works.


File Attachments


New close button
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125770: Emit correct signal for notifications expiring

2015-10-25 Thread David Edmundson 


> On Oct. 24, 2015, 12:44 p.m., Kai Uwe Broulik wrote:
> > dataengines/notifications/notificationsengine.cpp, lines 375-376
> > 
> >
> > I would turn the comment around "Only if we have that notification ..."

That gets more confusing.

I want to emphasise the "we don't emit twice" rather than "we emit the first 
time"

Hopefully tidied up


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125770/#review87336
---


On Oct. 24, 2015, 12:40 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125770/
> ---
> 
> (Updated Oct. 24, 2015, 12:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Expired notifications should emit a different reason in
> NotificationClosed than manually closed notifications
> 
> See 
> https://people.gnome.org/~mccann/docs/notification-spec/notification-spec-1.1.html#signal-notification-closed
> 
> BUG: 354293
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 
> 5fd06bb4ee437e673ef9cc09907764b40cfa5a74 
>   applets/notifications/package/contents/ui/Notifications.qml 
> 13be7d49a14ebbe5399a7f0bf333862f545671a2 
>   dataengines/notifications/notificationaction.cpp 
> 5302f7808fd43c924a3f7b1fd7cfc0acba45c500 
>   dataengines/notifications/notifications.operations 
> 046776ec1af981d7fb23db9ddb9bd9d34ec55300 
>   dataengines/notifications/notificationsengine.h 
> 52590950ad1c85f427502b598e0b21d8a65e587e 
>   dataengines/notifications/notificationsengine.cpp 
> 42e56d8ab27b3a012381cbd0ce39c6322d09e152 
> 
> Diff: https://git.reviewboard.kde.org/r/125770/diff/
> 
> 
> Testing
> ---
> 
> Ran dbus-monitor & notify-send
> 
> let one notification expire
> clicked close on another
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125770: Emit correct signal for notifications expiring

2015-10-25 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125770/
---

(Updated Oct. 25, 2015, 5:16 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

Expired notifications should emit a different reason in
NotificationClosed than manually closed notifications

See 
https://people.gnome.org/~mccann/docs/notification-spec/notification-spec-1.1.html#signal-notification-closed

BUG: 354293


Diffs (updated)
-

  applets/notifications/package/contents/ui/NotificationPopup.qml 
5fd06bb4ee437e673ef9cc09907764b40cfa5a74 
  applets/notifications/package/contents/ui/Notifications.qml 
13be7d49a14ebbe5399a7f0bf333862f545671a2 
  dataengines/notifications/notificationaction.cpp 
5302f7808fd43c924a3f7b1fd7cfc0acba45c500 
  dataengines/notifications/notifications.operations 
046776ec1af981d7fb23db9ddb9bd9d34ec55300 
  dataengines/notifications/notificationsengine.h 
52590950ad1c85f427502b598e0b21d8a65e587e 
  dataengines/notifications/notificationsengine.cpp 
42e56d8ab27b3a012381cbd0ce39c6322d09e152 

Diff: https://git.reviewboard.kde.org/r/125770/diff/


Testing
---

Ran dbus-monitor & notify-send

let one notification expire
clicked close on another


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87376
---


+1

- David Edmundson


On Oct. 25, 2015, 5:06 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> ---
> 
> (Updated Oct. 25, 2015, 5:06 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 350705
> https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I just found this patch I made a while ago. This turns the handmade close 
> button into a regular ToolButton (which is only shown when hovering) with a 
> proper size. Also, the button is always in the top right corner of the 
> *thumbnail* rather than the dialog
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> File Attachments
> 
> 
> New close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 348082] monitor is randomly powered back on

2015-10-25 Thread Greg Lepore via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=348082

Greg Lepore  changed:

   What|Removed |Added

 CC||g...@rhobard.com

--- Comment #9 from Greg Lepore  ---
I am having a problem identical to this with Kubuntu 15.10. Any suggestions for
debugging?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread Thomas Pfeiffer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87381
---


Can you please add Andrew for design review? 
>From a usability perspective, it would be better if the button was outside the 
>actual thumbnail, to be sure that it cannot be mistaken as part of the 
>thumbnail.

- Thomas Pfeiffer


On Oct. 25, 2015, 5:06 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> ---
> 
> (Updated Oct. 25, 2015, 5:06 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 350705
> https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I just found this patch I made a while ago. This turns the handmade close 
> button into a regular ToolButton (which is only shown when hovering) with a 
> proper size. Also, the button is always in the top right corner of the 
> *thumbnail* rather than the dialog
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> File Attachments
> 
> 
> New close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.5 Kickoff meeting minutes

2015-10-25 Thread Jonathan Riddell 
On Fri, Oct 23, 2015 at 11:56:43PM +0200, Aleix Pol wrote:
> On Fri, Oct 23, 2015 at 8:25 PM, David Edmundson
>  wrote:
> >
> >> ok I can add in a 5.4.3 release in November (look at the
> >> changelog at the time to check it's worth it)
> >>
> >
> > Giving an update on this. We've got ~20 commits in Plasma/5.4 since 5.4.2
> > Some of them are super important, so it's already going to be worth it.
> 
> I've got some important patches in Plasma/5.4 in muon as well.

Like a good Singer, I shall make it sew.

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.5 Kickoff meeting minutes

2015-10-25 Thread Sebastian Kügler 
On Saturday, October 24, 2015 11:25:09 Martin Gräßlin wrote:
> Am 2015-10-23 23:56, schrieb Aleix Pol:
> > On Fri, Oct 23, 2015 at 8:25 PM, David Edmundson
> > 
> >  wrote:
> >>> ok I can add in a 5.4.3 release in November (look at the
> >>> 
> >>> changelog at the time to check it's worth it)
> >> 
> >> Giving an update on this. We've got ~20 commits in Plasma/5.4 since
> >> 5.4.2
> >> Some of them are super important, so it's already going to be worth
> >> it.
> >> 
> >> David
> > 
> > I've got some important patches in Plasma/5.4 in muon as well.
> 
> I fixed two crashers with > 70 duplicates this week. I think we
> definately should make a 5.4.3 release and maybe also consider a 5.4.4
> release.

+1

Jonathan, could you prepare a 5.4.3?
-- 
sebas

Sebastian Kügler|http://vizZzion.org| http://kde.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel