Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126022/
---

Review request for Plasma and Bhushan Shah.


Repository: plasma-workspace


Description
---

On Wayland ksmserver should not be responsible for the lockscreen,
but the compositor takes care of providing the lock screen. To prevent
conflicts KSMServer gets a new command line option to enable it.

The code is slightly changed to not pass a series of boolean flags to
KSMServer, but a flags type.

The startplasma script for Wayland is adjusted to start ksmserver with
the new command line option.


Diffs
-

  ksmserver/main.cpp b1f1b68fe41b86da42d7bea2c088db6d89f0d844 
  ksmserver/server.h 87e46cbad70913b83f976ea2938606042c653c69 
  ksmserver/server.cpp ffb15d230b927c5ee28b7196904e0061a14b2d09 
  startkde/startplasma.cmake 4fab3b1597fee40bf69551af895d5248955eadea 

Diff: https://git.reviewboard.kde.org/r/126022/diff/


Testing
---

Started a Plasma/Wayland session with the change.

* ksmserver is started with --no-lockscreen
* Using loginctl lock-session gives me one lock window, instead of two as before


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126025: Require Frameworks 5.16

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126025/
---

Review request for Plasma.


Repository: kde-cli-tools


Description
---

Needed to make use of new KAboutData feature in kcmshell.


Diffs
-

  CMakeLists.txt 9f01ce5fa3667a53a32f999b4bc774f4641ad2b8 

Diff: https://git.reviewboard.kde.org/r/126025/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

[Bhushan Shah]

I kinda don't like idea of the command line option.. For instance if
someone uses this option on X11 they are lift without lockscreen.. Any
other solution possible?

Ideally ksmserver should just retire in Wayland world imo and other
functionality of it should be split out of it..
On Nov 11, 2015 2:40 PM, "Martin Gräßlin"  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126022/
> Review request for Plasma and Bhushan Shah.
> By Martin Gräßlin.
> *Repository: * plasma-workspace
> Description
>
> On Wayland ksmserver should not be responsible for the lockscreen,
> but the compositor takes care of providing the lock screen. To prevent
> conflicts KSMServer gets a new command line option to enable it.
>
> The code is slightly changed to not pass a series of boolean flags to
> KSMServer, but a flags type.
>
> The startplasma script for Wayland is adjusted to start ksmserver with
> the new command line option.
>
> Testing
>
> Started a Plasma/Wayland session with the change.
>
>- ksmserver is started with --no-lockscreen
>- Using loginctl lock-session gives me one lock window, instead of two as 
> before
>
> Diffs
>
>- ksmserver/main.cpp (b1f1b68fe41b86da42d7bea2c088db6d89f0d844)
>- ksmserver/server.h (87e46cbad70913b83f976ea2938606042c653c69)
>- ksmserver/server.cpp (ffb15d230b927c5ee28b7196904e0061a14b2d09)
>- startkde/startplasma.cmake (4fab3b1597fee40bf69551af895d5248955eadea)
>
> View Diff 
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

[Martin Graesslin]

On Wednesday, November 11, 2015 3:45:53 PM CET Bhushan Shah wrote:
> I kinda don't like idea of the command line option.. For instance if
> someone uses this option on X11 they are lift without lockscreen.. Any
> other solution possible?

I don't think that is an actual threat. This requires modifying startkde 
(which needs root privs). If users want to shoot into their feet: sure let 
them.

> 
> Ideally ksmserver should just retire in Wayland world imo and other
> functionality of it should be split out of it..

Ideally yes. Practically: I run away from that screaming. It still has a lot 
of startup code and I don't think we will be able to migrate that code fast. 
So we need a solution till ksmserver gets retired.

Cheers
Martin

> 
> On Nov 11, 2015 2:40 PM, "Martin Gräßlin"  wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/126022/
> > Review request for Plasma and Bhushan Shah.
> > By Martin Gräßlin.
> > *Repository: * plasma-workspace
> > Description
> > 
> > On Wayland ksmserver should not be responsible for the lockscreen,
> > but the compositor takes care of providing the lock screen. To prevent
> > conflicts KSMServer gets a new command line option to enable it.
> > 
> > The code is slightly changed to not pass a series of boolean flags to
> > KSMServer, but a flags type.
> > 
> > The startplasma script for Wayland is adjusted to start ksmserver with
> > the new command line option.
> > 
> > Testing
> > 
> > Started a Plasma/Wayland session with the change.
> > 
> >- ksmserver is started with --no-lockscreen
> >- Using loginctl lock-session gives me one lock window, instead of two
> >as before> 
> > Diffs
> > 
> >- ksmserver/main.cpp (b1f1b68fe41b86da42d7bea2c088db6d89f0d844)
> >- ksmserver/server.h (87e46cbad70913b83f976ea2938606042c653c69)
> >- ksmserver/server.cpp (ffb15d230b927c5ee28b7196904e0061a14b2d09)
> >- startkde/startplasma.cmake (4fab3b1597fee40bf69551af895d5248955eadea)
> > 
> > View Diff 


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126021: Destroy allowed client in WaylandServer::stop

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126021/
---

Review request for Plasma and Bhushan Shah.


Repository: kscreenlocker


Description
---

We need to explicitly destroy the ClientConnection we created.


Diffs
-

  waylandserver.cpp f57a5f4a4859993de5ee32160bdf5f9a3fee95c1 

Diff: https://git.reviewboard.kde.org/r/126021/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126021: Destroy allowed client in WaylandServer::stop

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126021/#review88245
---

Ship it!


Ship It!

- Bhushan Shah


On Nov. 11, 2015, 2:08 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126021/
> ---
> 
> (Updated Nov. 11, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: kscreenlocker
> 
> 
> Description
> ---
> 
> We need to explicitly destroy the ClientConnection we created.
> 
> 
> Diffs
> -
> 
>   waylandserver.cpp f57a5f4a4859993de5ee32160bdf5f9a3fee95c1 
> 
> Diff: https://git.reviewboard.kde.org/r/126021/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88260
---



applets/kicker/plugin/appsmodel.cpp (line 322)


favoritesModel needs to refresh too



applets/kicker/plugin/fileentry.cpp (line 63)


url.toString(preferlocal)



applets/kicker/plugin/recentusagemodel.cpp (line 74)


same as the last review on other model.

you need something consistent otherwise new inserts are basically unsorted.



applets/kicker/plugin/recentusagemodel.cpp (line 120)


QLatin1String for all startsWith



applets/kickoff/package/contents/ui/ConfigGeneral.qml (line 49)


Either:

This should say "Custom icon:"

OR

we should show the K when we still have the default


- David Edmundson


On Nov. 11, 2015, 3:28 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 3:28 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/package/contents/code/tools.js ccfa2c5 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml 9cc316b 
>   applets/kicker/package/contents/ui/ItemGridDelegate.qml 78cd40b 
>   applets/kicker/package/contents/ui/main.qml 4634630 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 

Re: Review Request 126025: Require Frameworks 5.16

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126025/
---

(Updated Nov. 11, 2015, 2:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c675fa1dad863567fa4563b13e619a5a5ae30453 by Martin 
Gräßlin to branch master.


Repository: kde-cli-tools


Description
---

Needed to make use of new KAboutData feature in kcmshell.


Diffs
-

  CMakeLists.txt 9f01ce5fa3667a53a32f999b4bc774f4641ad2b8 

Diff: https://git.reviewboard.kde.org/r/126025/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

[Eike Hein]

> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/computermodel.cpp, line 264
> > 
> >
> > why do this? trigger is virtual

But it's not const, while QModelIndex::model() is, and I don't like using const 
casts.


> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/computermodel.cpp, line 41
> > 
> >
> > this is now the default

I prefer making things explicit, but I dropped it.


> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/computermodel.cpp, line 173
> > 
> >
> > this is unused?

No, it's used by AppEntry.


> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/computermodel.cpp, line 213
> > 
> >
> > url.toString(QUrl::PreferLocalFile)

Changed.


> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/recentusagemodel.cpp, line 60
> > 
> >
> > sourceModel->setParent(this) in the ctor might be better?
> > 
> > It would ensure sourceModel exists during the  QSortFitlerProxy 
> > destructor, which I assume is why you're doing this setSourceModel(0)

Very good idea, done.


> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/recentusagemodel.cpp, line 112
> > 
> >
> > this method can be just
> > 
> > sourceModel()->data(...)
> > 
> > if sourceModel happens to be a GroupSortProxyModel it will forward the 
> > data to the right index itself.

QSortFilterProxyModel cares about the model pointer checking out, so it needs 
to be an index created from the GroupSortProxyModel rather than the 
ForwardingModel.


> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/recentusagemodel.cpp, line 253
> > 
> >
> > why only for this KRun job, not the others?

Dunno, ask Martin why it's needed for apps.


> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/computermodel.cpp, line 83
> > 
> >
> > return QSortFilterProxyModel::lessThan()
> > 
> > I dont't think you can rely on it following the source model's order.
> > I had a look at qsortfilterproxy model code; sort() uses stable sort so 
> > it implicitly will, but the insert methods don't seem to.
> > 
> > Also without this your explicit setSortRole will do nothing.

I flipped back and forth on this because I'd prefer retaining the order and 
this at least makes sure the initial load follows user places order, but it's 
true it's not very good. I'll go with alphabetic for now and address sorting 
further after this is merged.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88252
---


On Nov. 11, 2015, 12:27 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 12:27 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   

Re: Review Request 126027: Port Kickoff to the Kicker backend

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88259
---


FYI you can force push with 

git push origin :myBranch (to delete it)
git push myBranch

so it's a delete and replace with the same name, rather than a "force push" but 
it has the same net effect

another quicker technique I do sometimes is to commit with a message that says 
"squash me" then only sort that out when I get to the final pushing

- David Edmundson


On Nov. 11, 2015, 3:28 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 3:28 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/package/contents/code/tools.js ccfa2c5 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml 9cc316b 
>   applets/kicker/package/contents/ui/ItemGridDelegate.qml 78cd40b 
>   applets/kicker/package/contents/ui/main.qml 4634630 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   applets/kickoff/core/models.h 30e80be 
>   applets/kickoff/core/models.cpp a63d363 
>   applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
>   applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
>   applets/kickoff/core/processrunner.h 5d836eb 
>   applets/kickoff/core/processrunner.cpp 6572386 
>   applets/kickoff/core/qmldir d454d1b 
>   

Re: Review Request 126021: Destroy allowed client in WaylandServer::stop

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126021/
---

(Updated Nov. 11, 2015, 2:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Bhushan Shah.


Changes
---

Submitted with commit 76e2a19e8e47f9e4e99a40a81d3e28137aae3872 by Martin 
Gräßlin to branch master.


Repository: kscreenlocker


Description
---

We need to explicitly destroy the ClientConnection we created.


Diffs
-

  waylandserver.cpp f57a5f4a4859993de5ee32160bdf5f9a3fee95c1 

Diff: https://git.reviewboard.kde.org/r/126021/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/
---

(Updated Nov. 11, 2015, 3:28 p.m.)


Review request for Plasma and Ivan Čukić.


Changes
---

Note the branch is now outdated since I can't force-push and I edited the 
relevant commits.


Repository: plasma-desktop


Description
---

This is a roll-up of the various Kicker backend and ultimately Kickoff changes 
needed to obsolete Kickoff's old backend in favor of Kicker's. It raises 
Kickoff to Kicker's feature level (much more fleshed-out context menus with 
many additional features, pervasive favoriting, etc.) along with addressing 
numerous Kickoff bugs (e.g. sorting on the Computer page) and removing some 
cruft.

Migration from kickoffrc is done using a script and supports both favorites and 
ISV-customized system apps for the Computer page.

I suggest using the hein/kickeroff branch for review instead, as things are 
nicely split out into separate commits there.


Diffs (updated)
-

  applets/kicker/CMakeLists.txt bdb6419 
  applets/kicker/package/contents/code/tools.js ccfa2c5 
  applets/kicker/package/contents/ui/DashboardRepresentation.qml 9cc316b 
  applets/kicker/package/contents/ui/ItemGridDelegate.qml 78cd40b 
  applets/kicker/package/contents/ui/main.qml 4634630 
  applets/kicker/plugin/abstractentry.h e09b3cf 
  applets/kicker/plugin/abstractentry.cpp 846a548 
  applets/kicker/plugin/abstractmodel.h 142de27 
  applets/kicker/plugin/abstractmodel.cpp 18eed03 
  applets/kicker/plugin/actionlist.h 4aaa1d5 
  applets/kicker/plugin/appentry.h 3d0b1bd 
  applets/kicker/plugin/appentry.cpp 34bab3d 
  applets/kicker/plugin/appsmodel.h 3cd0577 
  applets/kicker/plugin/appsmodel.cpp 821ae88 
  applets/kicker/plugin/computermodel.h PRE-CREATION 
  applets/kicker/plugin/computermodel.cpp PRE-CREATION 
  applets/kicker/plugin/favoritesmodel.cpp 4931a16 
  applets/kicker/plugin/fileentry.h cd4e54a 
  applets/kicker/plugin/fileentry.cpp 693816d 
  applets/kicker/plugin/kickerplugin.cpp d31043a 
  applets/kicker/plugin/recentappsmodel.h 6ee55c1 
  applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
  applets/kicker/plugin/recentdocsmodel.h df12d1b 
  applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
  applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
  applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
  applets/kicker/plugin/rootmodel.h 5acdb8e 
  applets/kicker/plugin/rootmodel.cpp fde16fd 
  applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
  applets/kicker/plugin/runnermodel.h d827e6d 
  applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
  applets/kicker/plugin/systementry.h df0712b 
  applets/kicker/plugin/systementry.cpp ec527da 
  applets/kicker/plugin/systemmodel.h 1b3eab7 
  applets/kicker/plugin/systemmodel.cpp ef02892 
  applets/kickoff/CMakeLists.txt 339316d 
  applets/kickoff/STATUS-TODO f837793 
  applets/kickoff/core/applicationmodel.h cc28656 
  applets/kickoff/core/applicationmodel.cpp a292130 
  applets/kickoff/core/favoritesmodel.h 7a5f225 
  applets/kickoff/core/favoritesmodel.cpp be47347 
  applets/kickoff/core/itemhandlers.h 8f05490 
  applets/kickoff/core/itemhandlers.cpp d0cd423 
  applets/kickoff/core/kickoffabstractmodel.h be5ce21 
  applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
  applets/kickoff/core/kickoffmodel.h dd91f9b 
  applets/kickoff/core/kickoffmodel.cpp fd5bb62 
  applets/kickoff/core/kickoffplugin.h de839b3 
  applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
  applets/kickoff/core/kickoffproxymodel.h f1af640 
  applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp f8c031b 
  applets/kickoff/core/leavemodel.h f95a271 
  applets/kickoff/core/leavemodel.cpp 154eb1c 
  applets/kickoff/core/models.h 30e80be 
  applets/kickoff/core/models.cpp a63d363 
  applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
  applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
  applets/kickoff/core/processrunner.h 5d836eb 
  applets/kickoff/core/processrunner.cpp 6572386 
  applets/kickoff/core/qmldir d454d1b 
  applets/kickoff/core/recentapplications.h b73d526 
  applets/kickoff/core/recentapplications.cpp 2dd6781 
  applets/kickoff/core/recentlyusedmodel.h 2530fb4 
  applets/kickoff/core/recentlyusedmodel.cpp afeed23 
  applets/kickoff/core/systemmodel.h 5da49ad 
  applets/kickoff/core/systemmodel.cpp 461a2ed 
  applets/kickoff/core/urlitemlauncher.h 05c414d 
  applets/kickoff/core/urlitemlauncher.cpp c350680 
  applets/kickoff/package/contents/code/tools.js PRE-CREATION 
  applets/kickoff/package/contents/config/config.qml fe059b8 
  applets/kickoff/package/contents/config/main.xml 00dfdf9 
  applets/kickoff/package/contents/ui/ActionMenu.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ApplicationsView.qml ad5272a 
  

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > libtaskmanager/taskitem.cpp, line 627
> > 
> >
> > don't we have to change to kdeinit5 here?

No. The commandline is /path/used/to/launch/kcmshell5 style. The "kcmshell5 
style" portion is eventually matched to the desktop file in 
getServiceLauncherUrl.


- Johan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

[David Edmundson]

> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote:
> > applets/kicker/plugin/computermodel.cpp, line 83
> > 
> >
> > return QSortFilterProxyModel::lessThan()
> > 
> > I dont't think you can rely on it following the source model's order.
> > I had a look at qsortfilterproxy model code; sort() uses stable sort so 
> > it implicitly will, but the insert methods don't seem to.
> > 
> > Also without this your explicit setSortRole will do nothing.
> 
> Eike Hein wrote:
> I flipped back and forth on this because I'd prefer retaining the order 
> and this at least makes sure the initial load follows user places order, but 
> it's true it's not very good. I'll go with alphabetic for now and address 
> sorting further after this is merged.

if you want to retain the order, you could check the source row in the final 
lessThan.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88252
---


On Nov. 11, 2015, 3:28 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 3:28 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/package/contents/code/tools.js ccfa2c5 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml 9cc316b 
>   applets/kicker/package/contents/ui/ItemGridDelegate.qml 78cd40b 
>   applets/kicker/package/contents/ui/main.qml 4634630 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Martin Gräßlin]

> On Nov. 11, 2015, 8:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
> 
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to 
> improve this in Plasma 5.5 and scratch the code completely.
> 
> Great and I agree that the code is not great --all those wasted service 
> lookups and subtly broken caching of the answer-- but: where is this 
> alternative code that fixes everything? ;) Right now, I think this change 
> amounts to a trivial fix (just one forgotten case in the if-clause) to an 
> existing 'feature'/workaround that has a fairly immediate benefit (something 
> works again) and little cost: it's hardly a new one.

yeah sure, this was not meant as a "blocking" comment. I think the change 
should go in, but leave the decision to Eike.

I btw. already started working on the improvement by proposing a new addition 
to the NETWM spec and implementing it in KWindowSystem.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 7:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 7:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

[Martin Gräßlin]

> On Nov. 11, 2015, 5:03 p.m., David Edmundson wrote:
> > FYI you can force push with 
> > 
> > git push origin :myBranch (to delete it)
> > git push myBranch
> > 
> > so it's a delete and replace with the same name, rather than a "force push" 
> > but it has the same net effect
> > 
> > another quicker technique I do sometimes is to commit with a message that 
> > says "squash me" then only sort that out when I get to the final pushing

or what I do: I use a clone and force push to it. On a clone it's allowed.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88259
---


On Nov. 11, 2015, 4:28 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 4:28 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/package/contents/code/tools.js ccfa2c5 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml 9cc316b 
>   applets/kicker/package/contents/ui/ItemGridDelegate.qml 78cd40b 
>   applets/kicker/package/contents/ui/main.qml 4634630 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   applets/kickoff/core/models.h 30e80be 
>   applets/kickoff/core/models.cpp a63d363 
>   applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
>   applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
>   

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Eike Hein]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.

+1, I want to get rid of hacks, not pile on them


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126025: Require Frameworks 5.16

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126025/#review88247
---


+1 for me bumping the dependency of workspace now. for me go ahead if other 
don't have significant objections.
any other comments?

- Marco Martin


On Nov. 11, 2015, 10:26 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126025/
> ---
> 
> (Updated Nov. 11, 2015, 10:26 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> Needed to make use of new KAboutData feature in kcmshell.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9f01ce5fa3667a53a32f999b4bc774f4641ad2b8 
> 
> Diff: https://git.reviewboard.kde.org/r/126025/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126027: Port Kickoff to the Kicker backend

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

This is a roll-up of the various Kicker backend and ultimately Kickoff changes 
needed to obsolete Kickoff's old backend in favor of Kicker's. It raises 
Kickoff to Kicker's feature level (much more fleshed-out context menus with 
many additional features, pervasive favoriting, etc.) along with addressing 
numerous Kickoff bugs (e.g. sorting on the Computer page) and removing some 
cruft.

Migration from kickoffrc is done using a script and supports both favorites and 
ISV-customized system apps for the Computer page.

I suggest using the hein/kickeroff branch for review instead, as things are 
nicely split out into separate commits there.


Diffs
-

  applets/kicker/CMakeLists.txt bdb6419 
  applets/kicker/plugin/abstractentry.h e09b3cf 
  applets/kicker/plugin/abstractentry.cpp 846a548 
  applets/kicker/plugin/abstractmodel.h 142de27 
  applets/kicker/plugin/abstractmodel.cpp 18eed03 
  applets/kicker/plugin/actionlist.h 4aaa1d5 
  applets/kicker/plugin/appentry.h 3d0b1bd 
  applets/kicker/plugin/appentry.cpp 34bab3d 
  applets/kicker/plugin/appsmodel.h 3cd0577 
  applets/kicker/plugin/appsmodel.cpp 821ae88 
  applets/kicker/plugin/computermodel.h PRE-CREATION 
  applets/kicker/plugin/computermodel.cpp PRE-CREATION 
  applets/kicker/plugin/favoritesmodel.cpp 4931a16 
  applets/kicker/plugin/fileentry.h cd4e54a 
  applets/kicker/plugin/fileentry.cpp 693816d 
  applets/kicker/plugin/kickerplugin.cpp d31043a 
  applets/kicker/plugin/recentappsmodel.h 6ee55c1 
  applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
  applets/kicker/plugin/recentdocsmodel.h df12d1b 
  applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
  applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
  applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
  applets/kicker/plugin/rootmodel.h 5acdb8e 
  applets/kicker/plugin/rootmodel.cpp fde16fd 
  applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
  applets/kicker/plugin/runnermodel.h d827e6d 
  applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
  applets/kicker/plugin/systementry.h df0712b 
  applets/kicker/plugin/systementry.cpp ec527da 
  applets/kicker/plugin/systemmodel.h 1b3eab7 
  applets/kicker/plugin/systemmodel.cpp ef02892 
  applets/kickoff/CMakeLists.txt 339316d 
  applets/kickoff/STATUS-TODO f837793 
  applets/kickoff/core/applicationmodel.h cc28656 
  applets/kickoff/core/applicationmodel.cpp a292130 
  applets/kickoff/core/favoritesmodel.h 7a5f225 
  applets/kickoff/core/favoritesmodel.cpp be47347 
  applets/kickoff/core/itemhandlers.h 8f05490 
  applets/kickoff/core/itemhandlers.cpp d0cd423 
  applets/kickoff/core/kickoffabstractmodel.h be5ce21 
  applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
  applets/kickoff/core/kickoffmodel.h dd91f9b 
  applets/kickoff/core/kickoffmodel.cpp fd5bb62 
  applets/kickoff/core/kickoffplugin.h de839b3 
  applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
  applets/kickoff/core/kickoffproxymodel.h f1af640 
  applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp f8c031b 
  applets/kickoff/core/leavemodel.h f95a271 
  applets/kickoff/core/leavemodel.cpp 154eb1c 
  applets/kickoff/core/models.h 30e80be 
  applets/kickoff/core/models.cpp a63d363 
  applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
  applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
  applets/kickoff/core/processrunner.h 5d836eb 
  applets/kickoff/core/processrunner.cpp 6572386 
  applets/kickoff/core/qmldir d454d1b 
  applets/kickoff/core/recentapplications.h b73d526 
  applets/kickoff/core/recentapplications.cpp 2dd6781 
  applets/kickoff/core/recentlyusedmodel.h 2530fb4 
  applets/kickoff/core/recentlyusedmodel.cpp afeed23 
  applets/kickoff/core/systemmodel.h 5da49ad 
  applets/kickoff/core/systemmodel.cpp 461a2ed 
  applets/kickoff/core/urlitemlauncher.h 05c414d 
  applets/kickoff/core/urlitemlauncher.cpp c350680 
  applets/kickoff/package/contents/code/tools.js PRE-CREATION 
  applets/kickoff/package/contents/config/config.qml fe059b8 
  applets/kickoff/package/contents/config/main.xml 00dfdf9 
  applets/kickoff/package/contents/ui/ActionMenu.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ApplicationsView.qml ad5272a 
  applets/kickoff/package/contents/ui/BaseView.qml e628614 
  applets/kickoff/package/contents/ui/Breadcrumb.qml 016cf25 
  applets/kickoff/package/contents/ui/ComputerView.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ContextMenu.qml e8f681e 
  applets/kickoff/package/contents/ui/FavoritesView.qml f286592 
  applets/kickoff/package/contents/ui/Footer.qml dcc762f 
  

Re: Review Request 126012: Fix crash if context gets unrefd

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126012/
---

(Updated Nov. 11, 2015, 12:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Harald Sitter.


Changes
---

Submitted with commit 5d46f6c2a767c25868c143ee64ef71e071a7a55b by David 
Edmundson to branch master.


Repository: plasma-pa


Description
---

Context is refcounted (using it's own internal mechanism for whatever
reason)

However, when the last ref is deleted it leaves a dangling pointer in
instance(). When a new object is created it returns that.

This unsets our static pointer when deleting the context object

BUG: 354510


Diffs
-

  src/context.h 3b4ada12c307dfa53f4f29cafae41518d8b5422d 
  src/context.cpp ac8f0326641e36f0ea7388df718ad52a3eede260 

Diff: https://git.reviewboard.kde.org/r/126012/diff/


Testing
---

Still loads as before.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88252
---


Got halfway...


applets/kicker/plugin/computermodel.cpp (line 41)


this is now the default



applets/kicker/plugin/computermodel.cpp (line 83)


return QSortFilterProxyModel::lessThan()

I dont't think you can rely on it following the source model's order.
I had a look at qsortfilterproxy model code; sort() uses stable sort so it 
implicitly will, but the insert methods don't seem to.

Also without this your explicit setSortRole will do nothing.



applets/kicker/plugin/computermodel.cpp (line 173)


this is unused?



applets/kicker/plugin/computermodel.cpp (line 213)


url.toString(QUrl::PreferLocalFile)



applets/kicker/plugin/computermodel.cpp (line 264)


why do this? trigger is virtual



applets/kicker/plugin/recentusagemodel.cpp (line 60)


sourceModel->setParent(this) in the ctor might be better?

It would ensure sourceModel exists during the  QSortFitlerProxy destructor, 
which I assume is why you're doing this setSourceModel(0)



applets/kicker/plugin/recentusagemodel.cpp (line 112)


this method can be just

sourceModel()->data(...)

if sourceModel happens to be a GroupSortProxyModel it will forward the data 
to the right index itself.



applets/kicker/plugin/recentusagemodel.cpp (line 253)


why only for this KRun job, not the others?


- David Edmundson


On Nov. 11, 2015, 12:27 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 12:27 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them

> With KF 5.16 we will have all that's needed available. Let's try to improve 
> this in Plasma 5.5 and scratch the code completely.

Great and I agree that the code is not great --all those wasted service lookups 
and subtly broken caching of the answer-- but: where is this alternative code 
that fixes everything? ;) Right now, I think this change amounts to a trivial 
fix (just one forgotten case in the if-clause) to an existing 
'feature'/workaround that has a fairly immediate benefit (something works 
again) and little cost: it's hardly a new one.


- Johan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126025: Require Frameworks 5.16

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126025/#review88250
---

Ship it!


Ship It!

- David Edmundson


On Nov. 11, 2015, 10:26 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126025/
> ---
> 
> (Updated Nov. 11, 2015, 10:26 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> Needed to make use of new KAboutData feature in kcmshell.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9f01ce5fa3667a53a32f999b4bc774f4641ad2b8 
> 
> Diff: https://git.reviewboard.kde.org/r/126025/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

[Martin Gräßlin]

> On Nov. 12, 2015, 12:46 a.m., David Edmundson wrote:
> > pretty sure this breaks slackware
> > 
> > might have to make it an option

yes it breaks slackware and probably also BSDs. So -2 on this approach.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126037/#review88275
---


On Nov. 12, 2015, 12:37 a.m., Elias Probst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126037/
> ---
> 
> (Updated Nov. 12, 2015, 12:37 a.m.)
> 
> 
> Review request for Plasma, Bhushan Shah and Martin Gräßlin.
> 
> 
> Repository: kscreenlocker
> 
> 
> Description
> ---
> 
> Drop obsolete 'setuid' of kcheckpass and fragile code using $ENV{DESTDIR}.
> 
> kcheckpass works just fine without setuid nowadays and quite a few
> distributions already dropped setuid of if since quite some time.
> 
> Also use `LIBEXEC_INSTALL_DIR` instead of one of the dozens of other variants 
> for consistency.
> 
> 
> Diffs
> -
> 
>   config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
>   greeter/CMakeLists.txt 317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d 
>   kcheckpass/CMakeLists.txt a63fa1403e897e70989dc2e1ba7eed4bc69cbb51 
> 
> Diff: https://git.reviewboard.kde.org/r/126037/diff/
> 
> 
> Testing
> ---
> 
> `kcheckpass` and `kscreenlocker_greet` end up in the expected target 
> directory (`/usr/lib64/libexec` on Gentoo). `kcheckpass` works as expected.
> I'm not sure yet about `kscreenlocker_greet` as I ended up with an 
> un-unlockable session but also saw this issue before.
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

[Elias Probst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126037/
---

Review request for Plasma, Bhushan Shah and Martin Gräßlin.


Repository: kscreenlocker


Description
---

Drop obsolete 'setuid' of kcheckpass and fragile code using $ENV{DESTDIR}.

kcheckpass works just fine without setuid nowadays and quite a few
distributions already dropped setuid of if since quite some time.

Also use `LIBEXEC_INSTALL_DIR` instead of one of the dozens of other variants 
for consistency.


Diffs
-

  config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
  greeter/CMakeLists.txt 317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d 
  kcheckpass/CMakeLists.txt a63fa1403e897e70989dc2e1ba7eed4bc69cbb51 

Diff: https://git.reviewboard.kde.org/r/126037/diff/


Testing
---

`kcheckpass` and `kscreenlocker_greet` end up in the expected target directory 
(`/usr/lib64/libexec` on Gentoo). `kcheckpass` works as expected.
I'm not sure yet about `kscreenlocker_greet` as I ended up with an 
un-unlockable session but also saw this issue before.


Thanks,

Elias Probst

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126037/#review88275
---


pretty sure this breaks slackware

might have to make it an option

- David Edmundson


On Nov. 11, 2015, 11:37 p.m., Elias Probst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126037/
> ---
> 
> (Updated Nov. 11, 2015, 11:37 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah and Martin Gräßlin.
> 
> 
> Repository: kscreenlocker
> 
> 
> Description
> ---
> 
> Drop obsolete 'setuid' of kcheckpass and fragile code using $ENV{DESTDIR}.
> 
> kcheckpass works just fine without setuid nowadays and quite a few
> distributions already dropped setuid of if since quite some time.
> 
> Also use `LIBEXEC_INSTALL_DIR` instead of one of the dozens of other variants 
> for consistency.
> 
> 
> Diffs
> -
> 
>   config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
>   greeter/CMakeLists.txt 317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d 
>   kcheckpass/CMakeLists.txt a63fa1403e897e70989dc2e1ba7eed4bc69cbb51 
> 
> Diff: https://git.reviewboard.kde.org/r/126037/diff/
> 
> 
> Testing
> ---
> 
> `kcheckpass` and `kscreenlocker_greet` end up in the expected target 
> directory (`/usr/lib64/libexec` on Gentoo). `kcheckpass` works as expected.
> I'm not sure yet about `kscreenlocker_greet` as I ended up with an 
> un-unlockable session but also saw this issue before.
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126031: [appletinterface] Allow specifying separate toolTipIcon

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126031/#review88264
---


I like the applet previews in widget explorer but making them the actual applet 
icon was a not completely thought through. The tooltip icons are a mess now, 
Kickoff doesn't have the KDE logo anymore, not to mention the clocks. System 
Tray "More Entries" config icons are useless now (you can't tell anything at 
16x16) etc. But I guess it's too late to fix that now..

- Kai Uwe Broulik


On Nov. 11, 2015, 7:39 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126031/
> ---
> 
> (Updated Nov. 11, 2015, 7:39 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> With the new applet icons it can be desireable to remove the tooltip icon. 
> This is especially prominent with the clocks where the small icon shows a 
> random date causing confusion.
> 
> Problem with Plasmoid.icon is that it also affects eg. the undo notification, 
> unsetting it would show a KDE logo there.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126031/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

[Eike Hein]

> On Nov. 11, 2015, 4:03 p.m., David Edmundson wrote:
> > FYI you can force push with 
> > 
> > git push origin :myBranch (to delete it)
> > git push myBranch
> > 
> > so it's a delete and replace with the same name, rather than a "force push" 
> > but it has the same net effect
> > 
> > another quicker technique I do sometimes is to commit with a message that 
> > says "squash me" then only sort that out when I get to the final pushing
> 
> Martin Gräßlin wrote:
> or what I do: I use a clone and force push to it. On a clone it's allowed.

Thanks. When I designed the original ACLs for git.kde.org we didn't allow 
branch deletion for non-project admin accounts, I didn't know it was allowed 
now.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88259
---


On Nov. 11, 2015, 3:28 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 3:28 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/package/contents/code/tools.js ccfa2c5 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml 9cc316b 
>   applets/kicker/package/contents/ui/ItemGridDelegate.qml 78cd40b 
>   applets/kicker/package/contents/ui/main.qml 4634630 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   

Re: Review Request 126010: [digital-clock] Split the Calendar config stuff to it's own category + load the plugins configs

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126010/
---

(Updated Nov. 11, 2015, 8:58 p.m.)


Review request for Plasma.


Changes
---

Store the enabled calendar plugins per applet in 
plasmoid.configuration.enabledCalendarPlugins


Repository: plasma-workspace


Description
---

Two commits.

Creates separate category for Calendar config, currently
only with "Show week numbers" and a list of calendar
plugins to enable/disable.

It's using groupbox but I think the groupbox looks weird
in the breeze theme, see screenshot.

---

Adds config categories from the loaded calendar plugin
configs. Needs https://git.reviewboard.kde.org/r/125966/


Diffs (updated)
-

  applets/digital-clock/package/contents/config/config.qml 877e40c 
  applets/digital-clock/package/contents/config/main.xml aacbe27 
  applets/digital-clock/package/contents/ui/configAppearance.qml fc9a09e 
  applets/digital-clock/package/contents/ui/configCalendar.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126010/diff/


Testing
---

Applet settings lists all available plugins, enabling/disabling
them dynamically un/loads the plugins. Config window also contains
all plugins configs.

For some reason QML cuts off last letters from Labels, dunno why.


File Attachments


Calendar config page
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/09/52e2e536-4e98-4272-8a48-1d4fafc17548__snapshot41.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126031: [appletinterface] Allow specifying separate toolTipIcon

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126031/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

With the new applet icons it can be desireable to remove the tooltip icon. This 
is especially prominent with the clocks where the small icon shows a random 
date causing confusion.

Problem with Plasmoid.icon is that it also affects eg. the undo notification, 
unsetting it would show a KDE logo there.


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 

Diff: https://git.reviewboard.kde.org/r/126031/diff/


Testing
---

Works


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126032: [CompactApplet] Set tooltipIcon for tooltip

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126032/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

Adjusts CompactApplet to actually use the new property


Diffs
-

  desktoppackage/contents/applet/CompactApplet.qml b5bbc70 

Diff: https://git.reviewboard.kde.org/r/126032/diff/


Testing
---

Works


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125951/
---

(Updated Nov. 11, 2015, 8:54 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Restructured things a bit
* it now ensures that the applet config is not actually loading the plugins, it 
operates only on the metadata
* the list of enabled plugins is now stored per applet in 
plasmoid.configuration.enabledCalendarPlugins (this is the applet code though 
so that's another patch)

Enabling and disabling the plugins now work correctly including adding/removing 
the events from the calendar.


Repository: plasma-framework


Description
---

This is also made a QML singleton that will be used for the applet
config view where it will add the plugin configs once we add that
possibility.

The same instance is then set to the DaysModel from QML.

(this depends on https://git.reviewboard.kde.org/r/125817/ which awaits ship it)


Diffs (updated)
-

  src/declarativeimports/calendar/qml/MonthView.qml 
f698934f850ef3a917b9611c9f9a40c369b23f6c 
  src/declarativeimports/calendar/eventpluginsmanager.cpp PRE-CREATION 
  src/declarativeimports/calendar/daysmodel.h 
a5bdac98627f7efa76bd4afd239469b53e06690b 
  src/declarativeimports/calendar/CMakeLists.txt 
40ead911ad5208cae5dbe5333d227f9f8a0d9154 
  src/declarativeimports/calendar/calendarplugin.cpp 
bafe80cf7520a08312abfd1dbd6d4648a6710175 
  src/declarativeimports/calendar/eventpluginsmanager.h PRE-CREATION 
  src/declarativeimports/calendar/daysmodel.cpp 
2d059a8e8636565adbe52811e602fff37a5eb157 

Diff: https://git.reviewboard.kde.org/r/125951/diff/


Testing
---

Calendar events are still correctly displayed


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

[Eike Hein]

> On Nov. 11, 2015, 4:03 p.m., David Edmundson wrote:
> > FYI you can force push with 
> > 
> > git push origin :myBranch (to delete it)
> > git push myBranch
> > 
> > so it's a delete and replace with the same name, rather than a "force push" 
> > but it has the same net effect
> > 
> > another quicker technique I do sometimes is to commit with a message that 
> > says "squash me" then only sort that out when I get to the final pushing
> 
> Martin Gräßlin wrote:
> or what I do: I use a clone and force push to it. On a clone it's allowed.
> 
> Eike Hein wrote:
> Thanks. When I designed the original ACLs for git.kde.org we didn't allow 
> branch deletion for non-project admin accounts, I didn't know it was allowed 
> now.

A branch deletion attempt got rejected, so I guess the ACLs didn't change after 
all.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88259
---


On Nov. 11, 2015, 3:28 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 3:28 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/package/contents/code/tools.js ccfa2c5 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml 9cc316b 
>   applets/kicker/package/contents/ui/ItemGridDelegate.qml 78cd40b 
>   applets/kicker/package/contents/ui/main.qml 4634630 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   

Re: Review Request 126027: Port Kickoff to the Kicker backend

[Eike Hein]

> On Nov. 11, 2015, 5:16 p.m., David Edmundson wrote:
> > applets/kicker/plugin/appsmodel.cpp, line 322
> > 
> >
> > favoritesModel needs to refresh too

Good catch (RootModel handles this, and AppsModel wasn't usable standalone 
before).


> On Nov. 11, 2015, 5:16 p.m., David Edmundson wrote:
> > applets/kickoff/package/contents/ui/ConfigGeneral.qml, line 49
> > 
> >
> > Either:
> > 
> > This should say "Custom icon:"
> > 
> > OR
> > 
> > we should show the K when we still have the default

Redesigning the preferences UI (or any UI) is not a logical part of this RR - 
this code is not being introduced here - and I have plans to align the launcher 
preferences at a later time (all of them need work).


> On Nov. 11, 2015, 5:16 p.m., David Edmundson wrote:
> > applets/kicker/plugin/fileentry.cpp, line 63
> > 
> >
> > url.toString(preferlocal)

Done.


> On Nov. 11, 2015, 5:16 p.m., David Edmundson wrote:
> > applets/kicker/plugin/recentusagemodel.cpp, line 120
> > 
> >
> > QLatin1String for all startsWith

Done.


> On Nov. 11, 2015, 5:16 p.m., David Edmundson wrote:
> > applets/kicker/plugin/recentusagemodel.cpp, line 74
> > 
> >
> > same as the last review on other model.
> > 
> > you need something consistent otherwise new inserts are basically 
> > unsorted.

Both models now compare the source row.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88260
---


On Nov. 11, 2015, 3:28 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 3:28 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/package/contents/code/tools.js ccfa2c5 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml 9cc316b 
>   applets/kicker/package/contents/ui/ItemGridDelegate.qml 78cd40b 
>   applets/kicker/package/contents/ui/main.qml 4634630 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   

Re: Review Request 126027: Port Kickoff to the Kicker backend

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/
---

(Updated Nov. 11, 2015, 8:51 p.m.)


Review request for Plasma and Ivan Čukić.


Changes
---

Once again the branch is currently outdated.


Repository: plasma-desktop


Description
---

This is a roll-up of the various Kicker backend and ultimately Kickoff changes 
needed to obsolete Kickoff's old backend in favor of Kicker's. It raises 
Kickoff to Kicker's feature level (much more fleshed-out context menus with 
many additional features, pervasive favoriting, etc.) along with addressing 
numerous Kickoff bugs (e.g. sorting on the Computer page) and removing some 
cruft.

Migration from kickoffrc is done using a script and supports both favorites and 
ISV-customized system apps for the Computer page.

I suggest using the hein/kickeroff branch for review instead, as things are 
nicely split out into separate commits there.


Diffs (updated)
-

  applets/kicker/CMakeLists.txt bdb6419 
  applets/kicker/plugin/abstractentry.h e09b3cf 
  applets/kicker/plugin/abstractentry.cpp 846a548 
  applets/kicker/plugin/abstractmodel.h 142de27 
  applets/kicker/plugin/abstractmodel.cpp 18eed03 
  applets/kicker/plugin/actionlist.h 4aaa1d5 
  applets/kicker/plugin/appentry.h 3d0b1bd 
  applets/kicker/plugin/appentry.cpp 34bab3d 
  applets/kicker/plugin/appsmodel.h 3cd0577 
  applets/kicker/plugin/appsmodel.cpp 821ae88 
  applets/kicker/plugin/computermodel.h PRE-CREATION 
  applets/kicker/plugin/computermodel.cpp PRE-CREATION 
  applets/kicker/plugin/favoritesmodel.cpp 4931a16 
  applets/kicker/plugin/fileentry.h cd4e54a 
  applets/kicker/plugin/fileentry.cpp 693816d 
  applets/kicker/plugin/kickerplugin.cpp d31043a 
  applets/kicker/plugin/recentappsmodel.h 6ee55c1 
  applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
  applets/kicker/plugin/recentdocsmodel.h df12d1b 
  applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
  applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
  applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
  applets/kicker/plugin/rootmodel.h 5acdb8e 
  applets/kicker/plugin/rootmodel.cpp fde16fd 
  applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
  applets/kicker/plugin/runnermodel.h d827e6d 
  applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
  applets/kicker/plugin/systementry.h df0712b 
  applets/kicker/plugin/systementry.cpp ec527da 
  applets/kicker/plugin/systemmodel.h 1b3eab7 
  applets/kicker/plugin/systemmodel.cpp ef02892 
  applets/kickoff/CMakeLists.txt 339316d 
  applets/kickoff/STATUS-TODO f837793 
  applets/kickoff/core/applicationmodel.h cc28656 
  applets/kickoff/core/applicationmodel.cpp a292130 
  applets/kickoff/core/favoritesmodel.h 7a5f225 
  applets/kickoff/core/favoritesmodel.cpp be47347 
  applets/kickoff/core/itemhandlers.h 8f05490 
  applets/kickoff/core/itemhandlers.cpp d0cd423 
  applets/kickoff/core/kickoffabstractmodel.h be5ce21 
  applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
  applets/kickoff/core/kickoffmodel.h dd91f9b 
  applets/kickoff/core/kickoffmodel.cpp fd5bb62 
  applets/kickoff/core/kickoffplugin.h de839b3 
  applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
  applets/kickoff/core/kickoffproxymodel.h f1af640 
  applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp f8c031b 
  applets/kickoff/core/leavemodel.h f95a271 
  applets/kickoff/core/leavemodel.cpp 154eb1c 
  applets/kickoff/core/models.h 30e80be 
  applets/kickoff/core/models.cpp a63d363 
  applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
  applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
  applets/kickoff/core/processrunner.h 5d836eb 
  applets/kickoff/core/processrunner.cpp 6572386 
  applets/kickoff/core/qmldir d454d1b 
  applets/kickoff/core/recentapplications.h b73d526 
  applets/kickoff/core/recentapplications.cpp 2dd6781 
  applets/kickoff/core/recentlyusedmodel.h 2530fb4 
  applets/kickoff/core/recentlyusedmodel.cpp afeed23 
  applets/kickoff/core/systemmodel.h 5da49ad 
  applets/kickoff/core/systemmodel.cpp 461a2ed 
  applets/kickoff/core/urlitemlauncher.h 05c414d 
  applets/kickoff/core/urlitemlauncher.cpp c350680 
  applets/kickoff/package/contents/code/tools.js PRE-CREATION 
  applets/kickoff/package/contents/config/config.qml fe059b8 
  applets/kickoff/package/contents/config/main.xml 00dfdf9 
  applets/kickoff/package/contents/ui/ActionMenu.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ApplicationsView.qml ad5272a 
  applets/kickoff/package/contents/ui/BaseView.qml e628614 
  applets/kickoff/package/contents/ui/Breadcrumb.qml 016cf25 
  applets/kickoff/package/contents/ui/ComputerView.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ContextMenu.qml e8f681e 
  

Re: Review Request 126027: Port Kickoff to the Kicker backend

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/
---

(Updated Nov. 11, 2015, 9 p.m.)


Review request for Plasma and Ivan Čukić.


Changes
---

Save a few lines.


Repository: plasma-desktop


Description
---

This is a roll-up of the various Kicker backend and ultimately Kickoff changes 
needed to obsolete Kickoff's old backend in favor of Kicker's. It raises 
Kickoff to Kicker's feature level (much more fleshed-out context menus with 
many additional features, pervasive favoriting, etc.) along with addressing 
numerous Kickoff bugs (e.g. sorting on the Computer page) and removing some 
cruft.

Migration from kickoffrc is done using a script and supports both favorites and 
ISV-customized system apps for the Computer page.

I suggest using the hein/kickeroff branch for review instead, as things are 
nicely split out into separate commits there.


Diffs (updated)
-

  applets/kicker/CMakeLists.txt bdb6419 
  applets/kicker/plugin/abstractentry.h e09b3cf 
  applets/kicker/plugin/abstractentry.cpp 846a548 
  applets/kicker/plugin/abstractmodel.h 142de27 
  applets/kicker/plugin/abstractmodel.cpp 18eed03 
  applets/kicker/plugin/actionlist.h 4aaa1d5 
  applets/kicker/plugin/appentry.h 3d0b1bd 
  applets/kicker/plugin/appentry.cpp 34bab3d 
  applets/kicker/plugin/appsmodel.h 3cd0577 
  applets/kicker/plugin/appsmodel.cpp 821ae88 
  applets/kicker/plugin/computermodel.h PRE-CREATION 
  applets/kicker/plugin/computermodel.cpp PRE-CREATION 
  applets/kicker/plugin/favoritesmodel.cpp 4931a16 
  applets/kicker/plugin/fileentry.h cd4e54a 
  applets/kicker/plugin/fileentry.cpp 693816d 
  applets/kicker/plugin/kickerplugin.cpp d31043a 
  applets/kicker/plugin/recentappsmodel.h 6ee55c1 
  applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
  applets/kicker/plugin/recentdocsmodel.h df12d1b 
  applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
  applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
  applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
  applets/kicker/plugin/rootmodel.h 5acdb8e 
  applets/kicker/plugin/rootmodel.cpp fde16fd 
  applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
  applets/kicker/plugin/runnermodel.h d827e6d 
  applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
  applets/kicker/plugin/systementry.h df0712b 
  applets/kicker/plugin/systementry.cpp ec527da 
  applets/kicker/plugin/systemmodel.h 1b3eab7 
  applets/kicker/plugin/systemmodel.cpp ef02892 
  applets/kickoff/CMakeLists.txt 339316d 
  applets/kickoff/STATUS-TODO f837793 
  applets/kickoff/core/applicationmodel.h cc28656 
  applets/kickoff/core/applicationmodel.cpp a292130 
  applets/kickoff/core/favoritesmodel.h 7a5f225 
  applets/kickoff/core/favoritesmodel.cpp be47347 
  applets/kickoff/core/itemhandlers.h 8f05490 
  applets/kickoff/core/itemhandlers.cpp d0cd423 
  applets/kickoff/core/kickoffabstractmodel.h be5ce21 
  applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
  applets/kickoff/core/kickoffmodel.h dd91f9b 
  applets/kickoff/core/kickoffmodel.cpp fd5bb62 
  applets/kickoff/core/kickoffplugin.h de839b3 
  applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
  applets/kickoff/core/kickoffproxymodel.h f1af640 
  applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp f8c031b 
  applets/kickoff/core/leavemodel.h f95a271 
  applets/kickoff/core/leavemodel.cpp 154eb1c 
  applets/kickoff/core/models.h 30e80be 
  applets/kickoff/core/models.cpp a63d363 
  applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
  applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
  applets/kickoff/core/processrunner.h 5d836eb 
  applets/kickoff/core/processrunner.cpp 6572386 
  applets/kickoff/core/qmldir d454d1b 
  applets/kickoff/core/recentapplications.h b73d526 
  applets/kickoff/core/recentapplications.cpp 2dd6781 
  applets/kickoff/core/recentlyusedmodel.h 2530fb4 
  applets/kickoff/core/recentlyusedmodel.cpp afeed23 
  applets/kickoff/core/systemmodel.h 5da49ad 
  applets/kickoff/core/systemmodel.cpp 461a2ed 
  applets/kickoff/core/urlitemlauncher.h 05c414d 
  applets/kickoff/core/urlitemlauncher.cpp c350680 
  applets/kickoff/package/contents/code/tools.js PRE-CREATION 
  applets/kickoff/package/contents/config/config.qml fe059b8 
  applets/kickoff/package/contents/config/main.xml 00dfdf9 
  applets/kickoff/package/contents/ui/ActionMenu.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ApplicationsView.qml ad5272a 
  applets/kickoff/package/contents/ui/BaseView.qml e628614 
  applets/kickoff/package/contents/ui/Breadcrumb.qml 016cf25 
  applets/kickoff/package/contents/ui/ComputerView.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ContextMenu.qml e8f681e 
  

Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126036/
---

Review request for Plasma.


Repository: plasma-workspace-wallpapers


Description
---

As you know I start an wallpaper contest for plasma 5.5. The VDG make an 
preselection and I hope the Plasma team will give feedback which wallpaper 
should be included in the plasma 5.5 extra wallpaper package


Diffs
-

  Alps/contents/images/1280x1024.jpg c295fdc 
  Alps/contents/images/1280x800.jpg b6edfe7 
  Alps/contents/images/1440x900.jpg c94bcaa 
  Alps/contents/images/1600x1200.jpg e09e592 
  Alps/contents/images/1638x1024.jpg 0c06524 
  Alps/contents/images/1680x1050.jpg 6c96d86 
  Alps/contents/images/1920x1080.jpg 4b974d4 
  Alps/contents/images/1920x1200.jpg 677a6aa 
  Alps/contents/images/2560x1600.jpg 9bac171 
  Alps/contents/images/2560x2440.jpg 2075d9b 
  Alps/contents/images/640x480.jpg 7f6a74e 
  Alps/contents/images/800x600.jpg 09a604d 
  Alps/contents/screenshot.jpg 54c27e9 
  Alps/metadata.desktop 002dba2 
  BlueFlower/contents/images/1280x1024.jpg 195 
  BlueFlower/contents/images/1280x800.jpg 5d9b62c 
  BlueFlower/contents/images/1440x900.jpg e2677a4 
  BlueFlower/contents/images/1600x1200.jpg da10f13 
  BlueFlower/contents/images/1638x1024.jpg 76c6fc5 
  BlueFlower/contents/images/1680x1050.jpg 79a298a 
  BlueFlower/contents/images/1920x1080.jpg 20e763b 
  BlueFlower/contents/images/1920x1200.jpg 39c4a4e 
  BlueFlower/contents/images/2560x1440.jpg 2a32989 
  BlueFlower/contents/images/2560x1600.jpg de59380 
  BlueFlower/contents/images/640x480.jpg 1d35499 
  BlueFlower/contents/images/800x600.jpg f9e9e29 
  BlueFlower/contents/screenshot.jpg 7cdf224 
  BlueFlower/metadata.desktop ed2a89a 
  Dance_of_the_Spirits/contents/images/1280x1024.jpg 458a9d3 
  Dance_of_the_Spirits/contents/images/1280x800.jpg 099dba5 
  Dance_of_the_Spirits/contents/images/1440x900.jpg 710aad5 
  Dance_of_the_Spirits/contents/images/1600x1200.jpg 369e081 
  Dance_of_the_Spirits/contents/images/1920x1080.jpg d47bc94 
  Dance_of_the_Spirits/contents/images/1920x1200.jpg 9fa01ac 
  Dance_of_the_Spirits/contents/images/2560x1440.jpg 060148e 
  Dance_of_the_Spirits/contents/images/2560x1600.jpg 28515f1 
  Dance_of_the_Spirits/contents/screenshot.png 9b9c0c5 
  Dance_of_the_Spirits/metadata.desktop 0b2f6c9 
  GereatHeron/contents/images/1280x1024.jpg 8fa95fb 
  GereatHeron/contents/images/1280x800.jpg 5f7e924 
  GereatHeron/contents/images/1440x900.jpg 0336115 
  GereatHeron/contents/images/1600x1200.jpg 6659dd6 
  GereatHeron/contents/images/1680x1050.jpg 0243a4d 
  GereatHeron/contents/images/1920x1080.jpg e3c04c0 
  GereatHeron/contents/images/1920x1200.jpg 34ced65 
  GereatHeron/contents/images/2560x1440.jpg ed5a835 
  GereatHeron/contents/images/2560x1600.jpg ccba2c0 
  GereatHeron/contents/images/640x480.jpg 8e30b41 
  GereatHeron/contents/images/800x600.jpg fb956a3 
  GereatHeron/contents/screenshot.jpg 25a514d 
  GereatHeron/metadata.desktop 4274fbd 
  Landmannalaugar/contents/images/1280x1024.jpg 83ac796 
  Landmannalaugar/contents/images/1280x800.jpg 45f8cb1 
  Landmannalaugar/contents/images/1440x900.jpg 1c28a72 
  Landmannalaugar/contents/images/1600x1200.jpg e84d18d 
  Landmannalaugar/contents/images/1638x1024.jpg dc9e4a3 
  Landmannalaugar/contents/images/1680x1050.jpg 89ed042 
  Landmannalaugar/contents/images/1920x1080.jpg be2a31e 
  Landmannalaugar/contents/images/1920x1200.jpg 409dbcf 
  Landmannalaugar/contents/images/2560x1440.jpg 70237d9 
  Landmannalaugar/contents/images/2560x1600.jpg d966604 
  Landmannalaugar/contents/images/640x480.jpg 1302268 
  Landmannalaugar/contents/images/800x600.jpg 14de9cb 
  Landmannalaugar/contents/screenshot.jpg 46be560 
  Landmannalaugar/metadata.desktop ded464b 
  Tauplitz/contents/images/1280x1024.jpg 3116e33 
  Tauplitz/contents/images/1280x800.jpg 7ac2b77 
  Tauplitz/contents/images/1440x900.jpg b13f4a2 
  Tauplitz/contents/images/1600x1200.jpg 840cba1 
  Tauplitz/contents/images/1638x1024.jpg bffefaa 
  Tauplitz/contents/images/1680x1050.jpg d1a0b2f 
  Tauplitz/contents/images/1920x1080.jpg 072cf23 
  Tauplitz/contents/images/1920x1200.jpg 729f488 
  Tauplitz/contents/images/2560x1440.jpg 19fd12d 
  Tauplitz/contents/images/2560x1600.jpg fbfdca5 
  Tauplitz/contents/images/800x600.jpg a09fbac 
  Tauplitz/contents/images/Untitled.jpg 26225ca 
  Tauplitz/contents/screenshot.jpg d98b905 
  Tauplitz/metadata.desktop 29638c6 

Diff: https://git.reviewboard.kde.org/r/126036/diff/


Testing
---

all wallpapers are located in the share.kde.org folder

https://share.kde.org/index.php/s/fvPmEjcZOR2Ya2u

move discard wallpapers in an separate folder with your username. you can also 
move wallpapers from an discard folder to the main folder. all wallpapers in 
the main folder will shiped with 5.5


Thanks,

andreas kainz

Re: Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126036/#review88272
---


This lists a file: 
Tauplitz/contents/images/Untitled.jpg

which I guess you don't want

also it says here that all the metadata.desktop files are deleted, I assume 
that's just RB being rubbish?

- David Edmundson


On Nov. 11, 2015, 10:56 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126036/
> ---
> 
> (Updated Nov. 11, 2015, 10:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace-wallpapers
> 
> 
> Description
> ---
> 
> As you know I start an wallpaper contest for plasma 5.5. The VDG make an 
> preselection and I hope the Plasma team will give feedback which wallpaper 
> should be included in the plasma 5.5 extra wallpaper package
> 
> 
> Diffs
> -
> 
>   Alps/contents/images/1280x1024.jpg c295fdc 
>   Alps/contents/images/1280x800.jpg b6edfe7 
>   Alps/contents/images/1440x900.jpg c94bcaa 
>   Alps/contents/images/1600x1200.jpg e09e592 
>   Alps/contents/images/1638x1024.jpg 0c06524 
>   Alps/contents/images/1680x1050.jpg 6c96d86 
>   Alps/contents/images/1920x1080.jpg 4b974d4 
>   Alps/contents/images/1920x1200.jpg 677a6aa 
>   Alps/contents/images/2560x1600.jpg 9bac171 
>   Alps/contents/images/2560x2440.jpg 2075d9b 
>   Alps/contents/images/640x480.jpg 7f6a74e 
>   Alps/contents/images/800x600.jpg 09a604d 
>   Alps/contents/screenshot.jpg 54c27e9 
>   Alps/metadata.desktop 002dba2 
>   BlueFlower/contents/images/1280x1024.jpg 195 
>   BlueFlower/contents/images/1280x800.jpg 5d9b62c 
>   BlueFlower/contents/images/1440x900.jpg e2677a4 
>   BlueFlower/contents/images/1600x1200.jpg da10f13 
>   BlueFlower/contents/images/1638x1024.jpg 76c6fc5 
>   BlueFlower/contents/images/1680x1050.jpg 79a298a 
>   BlueFlower/contents/images/1920x1080.jpg 20e763b 
>   BlueFlower/contents/images/1920x1200.jpg 39c4a4e 
>   BlueFlower/contents/images/2560x1440.jpg 2a32989 
>   BlueFlower/contents/images/2560x1600.jpg de59380 
>   BlueFlower/contents/images/640x480.jpg 1d35499 
>   BlueFlower/contents/images/800x600.jpg f9e9e29 
>   BlueFlower/contents/screenshot.jpg 7cdf224 
>   BlueFlower/metadata.desktop ed2a89a 
>   Dance_of_the_Spirits/contents/images/1280x1024.jpg 458a9d3 
>   Dance_of_the_Spirits/contents/images/1280x800.jpg 099dba5 
>   Dance_of_the_Spirits/contents/images/1440x900.jpg 710aad5 
>   Dance_of_the_Spirits/contents/images/1600x1200.jpg 369e081 
>   Dance_of_the_Spirits/contents/images/1920x1080.jpg d47bc94 
>   Dance_of_the_Spirits/contents/images/1920x1200.jpg 9fa01ac 
>   Dance_of_the_Spirits/contents/images/2560x1440.jpg 060148e 
>   Dance_of_the_Spirits/contents/images/2560x1600.jpg 28515f1 
>   Dance_of_the_Spirits/contents/screenshot.png 9b9c0c5 
>   Dance_of_the_Spirits/metadata.desktop 0b2f6c9 
>   GereatHeron/contents/images/1280x1024.jpg 8fa95fb 
>   GereatHeron/contents/images/1280x800.jpg 5f7e924 
>   GereatHeron/contents/images/1440x900.jpg 0336115 
>   GereatHeron/contents/images/1600x1200.jpg 6659dd6 
>   GereatHeron/contents/images/1680x1050.jpg 0243a4d 
>   GereatHeron/contents/images/1920x1080.jpg e3c04c0 
>   GereatHeron/contents/images/1920x1200.jpg 34ced65 
>   GereatHeron/contents/images/2560x1440.jpg ed5a835 
>   GereatHeron/contents/images/2560x1600.jpg ccba2c0 
>   GereatHeron/contents/images/640x480.jpg 8e30b41 
>   GereatHeron/contents/images/800x600.jpg fb956a3 
>   GereatHeron/contents/screenshot.jpg 25a514d 
>   GereatHeron/metadata.desktop 4274fbd 
>   Landmannalaugar/contents/images/1280x1024.jpg 83ac796 
>   Landmannalaugar/contents/images/1280x800.jpg 45f8cb1 
>   Landmannalaugar/contents/images/1440x900.jpg 1c28a72 
>   Landmannalaugar/contents/images/1600x1200.jpg e84d18d 
>   Landmannalaugar/contents/images/1638x1024.jpg dc9e4a3 
>   Landmannalaugar/contents/images/1680x1050.jpg 89ed042 
>   Landmannalaugar/contents/images/1920x1080.jpg be2a31e 
>   Landmannalaugar/contents/images/1920x1200.jpg 409dbcf 
>   Landmannalaugar/contents/images/2560x1440.jpg 70237d9 
>   Landmannalaugar/contents/images/2560x1600.jpg d966604 
>   Landmannalaugar/contents/images/640x480.jpg 1302268 
>   Landmannalaugar/contents/images/800x600.jpg 14de9cb 
>   Landmannalaugar/contents/screenshot.jpg 46be560 
>   Landmannalaugar/metadata.desktop ded464b 
>   Tauplitz/contents/images/1280x1024.jpg 3116e33 
>   Tauplitz/contents/images/1280x800.jpg 7ac2b77 
>   Tauplitz/contents/images/1440x900.jpg b13f4a2 
>   Tauplitz/contents/images/1600x1200.jpg 840cba1 
>   Tauplitz/contents/images/1638x1024.jpg bffefaa 
>   Tauplitz/contents/images/1680x1050.jpg d1a0b2f 
>   Tauplitz/contents/images/1920x1080.jpg 072cf23 

Re: Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126036/#review88274
---


I can't seem to create folders so I'll post my feedback here with my long years
semi-pro photography hat on:

* Colorful Cups - to me it doesn't really work as a wallpaper. It's a nice~ish 
photo,
  but the high-contrast edges of the cups are clashing with the icons and the 
icon labels
  which doesn't look very good. Overall the theme of the photo does "not feel 
right" for
  a desktop. Discard (from me).

* Evening Glow - the photo feels unbalanced, there's a high brigthness in the 
sky which
  overshines the main theme of the photo (the boats), which are in turn much 
more shadow-y
  and not entirely sharp (it looks like a hand-held hdr). Discard (from me).

* PSX_20150910_181318 (those white flowers) - it's not a very good photo and 
the blossoms
  are not that pretty. Discard (from me).

* PSX_20150910_182607 (the shack in front of the forest) - its strange 
softfocus is imo
  not very good, the trees lack details, the shack is out of focus and the 
subject matter
  is also not very good for a desktop wallpaper. Perhaps if the lawn mover 
wasn't there
  it could be nice, but other than that it's the same case as the colorful cups 
one.
  Just "doesn't feel right" (plus the low quality). Discard (from me).

* Group discards/By the water - I believe that's the a submission? It's not 
bad, has a bit
  of noise in it which could be reduced, but other than that, I'd bring it back.

* Discarded by Uri/Darkest hour - if we could tweak that photo, I think it 
could be nice.


With the rest I pretty much agree.

- Martin Klapetek


On Nov. 11, 2015, 11:56 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126036/
> ---
> 
> (Updated Nov. 11, 2015, 11:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace-wallpapers
> 
> 
> Description
> ---
> 
> As you know I start an wallpaper contest for plasma 5.5. The VDG make an 
> preselection and I hope the Plasma team will give feedback which wallpaper 
> should be included in the plasma 5.5 extra wallpaper package
> 
> 
> Diffs
> -
> 
>   Alps/contents/images/1280x1024.jpg c295fdc 
>   Alps/contents/images/1280x800.jpg b6edfe7 
>   Alps/contents/images/1440x900.jpg c94bcaa 
>   Alps/contents/images/1600x1200.jpg e09e592 
>   Alps/contents/images/1638x1024.jpg 0c06524 
>   Alps/contents/images/1680x1050.jpg 6c96d86 
>   Alps/contents/images/1920x1080.jpg 4b974d4 
>   Alps/contents/images/1920x1200.jpg 677a6aa 
>   Alps/contents/images/2560x1600.jpg 9bac171 
>   Alps/contents/images/2560x2440.jpg 2075d9b 
>   Alps/contents/images/640x480.jpg 7f6a74e 
>   Alps/contents/images/800x600.jpg 09a604d 
>   Alps/contents/screenshot.jpg 54c27e9 
>   Alps/metadata.desktop 002dba2 
>   BlueFlower/contents/images/1280x1024.jpg 195 
>   BlueFlower/contents/images/1280x800.jpg 5d9b62c 
>   BlueFlower/contents/images/1440x900.jpg e2677a4 
>   BlueFlower/contents/images/1600x1200.jpg da10f13 
>   BlueFlower/contents/images/1638x1024.jpg 76c6fc5 
>   BlueFlower/contents/images/1680x1050.jpg 79a298a 
>   BlueFlower/contents/images/1920x1080.jpg 20e763b 
>   BlueFlower/contents/images/1920x1200.jpg 39c4a4e 
>   BlueFlower/contents/images/2560x1440.jpg 2a32989 
>   BlueFlower/contents/images/2560x1600.jpg de59380 
>   BlueFlower/contents/images/640x480.jpg 1d35499 
>   BlueFlower/contents/images/800x600.jpg f9e9e29 
>   BlueFlower/contents/screenshot.jpg 7cdf224 
>   BlueFlower/metadata.desktop ed2a89a 
>   Dance_of_the_Spirits/contents/images/1280x1024.jpg 458a9d3 
>   Dance_of_the_Spirits/contents/images/1280x800.jpg 099dba5 
>   Dance_of_the_Spirits/contents/images/1440x900.jpg 710aad5 
>   Dance_of_the_Spirits/contents/images/1600x1200.jpg 369e081 
>   Dance_of_the_Spirits/contents/images/1920x1080.jpg d47bc94 
>   Dance_of_the_Spirits/contents/images/1920x1200.jpg 9fa01ac 
>   Dance_of_the_Spirits/contents/images/2560x1440.jpg 060148e 
>   Dance_of_the_Spirits/contents/images/2560x1600.jpg 28515f1 
>   Dance_of_the_Spirits/contents/screenshot.png 9b9c0c5 
>   Dance_of_the_Spirits/metadata.desktop 0b2f6c9 
>   GereatHeron/contents/images/1280x1024.jpg 8fa95fb 
>   GereatHeron/contents/images/1280x800.jpg 5f7e924 
>   GereatHeron/contents/images/1440x900.jpg 0336115 
>   GereatHeron/contents/images/1600x1200.jpg 6659dd6 
>   GereatHeron/contents/images/1680x1050.jpg 0243a4d 
>   GereatHeron/contents/images/1920x1080.jpg e3c04c0 
>   GereatHeron/contents/images/1920x1200.jpg 34ced65 
>   GereatHeron/contents/images/2560x1440.jpg ed5a835 
>   GereatHeron/contents/images/2560x1600.jpg ccba2c0 
>