Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88775
---


Ping

- David Rosca


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126163/#review88781
---


Should we convert the icons from svg to png?

- andreas kainz


On Nov. 24, 2015, 11:46 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126163/
> ---
> 
> (Updated Nov. 24, 2015, 11:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Widget Explorer takes quite a while to open. Especially now that we load 
> basically double the number of items (two columns) and significantly more 
> complex SVGs. This patch uses a couple of tricks to make it feel a lot faster:
> - Create context menu items on demand
> - Set the model for the list after a slight delay
> - Some minor cleanups
> 
> By setting the model later we let the dialog slide in first (KWin does the 
> animation anyway so it won't block) and then nicely fade in the view once we 
> have loaded it.
> 
> I have noticed that the applet item model which gets the decoration role from 
> the applet package can take quite a while blocking the explorer. It might 
> also be worth investigating whether we should keep the WidgetExplorer around 
> when it has been opened once (I mean the model, not the QML view) so we save 
> creating the model everytime we open it again.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/WidgetExplorer.qml 911d9c9 
> 
> Diff: https://git.reviewboard.kde.org/r/126163/diff/
> 
> 
> Testing
> ---
> 
> Feels a lot quicker now.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126162/
---

Review request for Plasma.


Bugs: 346348
https://bugs.kde.org/show_bug.cgi?id=346348


Repository: plasma-desktop


Description
---

This is basically patch by Fabian Vogt from the bugreport. 
But it is still not fixed, so I opened the RR myself.


Diffs
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/126162/diff/


Testing
---

Bug is now fixed, I cannot see any side-effects.

Reliable way to reproduce bug:

1. Set some launcher to always show
2. Make sure the app from step 1. is not running (so you have the launcher in 
taskmanager without running app)
3. Mouse over the launcher from step 1., let the tooltip show and then move 
mouse out to hide it.
4. Mouse over some other taskmanager entry that is for running application
5. Tooltip is shown without labels


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Heads-up: Session management issues

[Andreas Hartmetz]

Hello,

I've started a thread "Causes of session management problems in Plasma 
5" on kde-core-devel about the session management problems affecting 
Plasma 5. ksmserver is part of plasma-workspace but the other involved 
parts aren't part of Plasma.

Cheers,
Andreas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126163: [Widget Explorer] Make it feel a lot quicker

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126163/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

Widget Explorer takes quite a while to open. Especially now that we load 
basically double the number of items (two columns) and significantly more 
complex SVGs. This patch uses a couple of tricks to make it feel a lot faster:
- Create context menu items on demand
- Set the model for the list after a slight delay
- Some minor cleanups

By setting the model later we let the dialog slide in first (KWin does the 
animation anyway so it won't block) and then nicely fade in the view once we 
have loaded it.

I have noticed that the applet item model which gets the decoration role from 
the applet package can take quite a while blocking the explorer. It might also 
be worth investigating whether we should keep the WidgetExplorer around when it 
has been opened once (I mean the model, not the QML view) so we save creating 
the model everytime we open it again.


Diffs
-

  desktoppackage/contents/explorer/WidgetExplorer.qml 911d9c9 

Diff: https://git.reviewboard.kde.org/r/126163/diff/


Testing
---

Feels a lot quicker now.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126159: [Containmentinterface] Don't offer to set a wallpaper for a panel

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126159/
---

(Updated Nov. 24, 2015, 8:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c7bfe07b1cb2973c863762e01d7144668b5d980b by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

Dropping an image on the desktop will ask whether we want to set it as a 
wallpaper. The same happens on a panel which makes no sense and does nothing. 
This removes the option.


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 7632c40 

Diff: https://git.reviewboard.kde.org/r/126159/diff/


Testing
---

Dropped jpeg onto my desktop -> it asked whether I wanted to create an icon or 
set as "Image" wallpaper
Dropped jpeg onto my panel -> it created an icon right away without asking


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126159: [Containmentinterface] Don't offer to set a wallpaper for a panel

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126159/#review88770
---

Ship it!


Ship It!

- Marco Martin


On Nov. 24, 2015, 8:01 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126159/
> ---
> 
> (Updated Nov. 24, 2015, 8:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Dropping an image on the desktop will ask whether we want to set it as a 
> wallpaper. The same happens on a panel which makes no sense and does nothing. 
> This removes the option.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 7632c40 
> 
> Diff: https://git.reviewboard.kde.org/r/126159/diff/
> 
> 
> Testing
> ---
> 
> Dropped jpeg onto my desktop -> it asked whether I wanted to create an icon 
> or set as "Image" wallpaper
> Dropped jpeg onto my panel -> it created an icon right away without asking
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355860] Toggle Push-Buttons are indistinguishable

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355860

Martin Klapetek  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|hugo.pere...@free.fr
 CC||mklape...@kde.org
  Component|general |QStyle

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355860] New: Toggle Push-Buttons are indistinguishable

[M G Berberich via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355860

Bug ID: 355860
   Summary: Toggle Push-Buttons are indistinguishable
   Product: Breeze
   Version: 5.4.2
  Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: k...@oss.m-berberich.de

Created attachment 95709
  --> https://bugs.kde.org/attachment.cgi?id=95709=edit
Three QPushButtons (try to guess which are checked)

For QPushButton that are used as toggle-buttons (with
QPushButton::setCheckable(true); ) it is nearly impossible to determine if they
are checked or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126159: [Containmentinterface] Don't offer to set a wallpaper for a panel

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126159/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Dropping an image on the desktop will ask whether we want to set it as a 
wallpaper. The same happens on a panel which makes no sense and does nothing. 
This removes the option.


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 7632c40 

Diff: https://git.reviewboard.kde.org/r/126159/diff/


Testing
---

Dropped jpeg onto my desktop -> it asked whether I wanted to create an icon or 
set as "Image" wallpaper
Dropped jpeg onto my panel -> it created an icon right away without asking


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355804] Fresh boot to sddm and a few minutes of inactivity sends computer to Standby

[Gregor Mi via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355804

--- Comment #2 from Gregor Mi  ---
For me this is not expected behaviour because my machine runs on A/C power and
there is no visible configuration that says that the computer should go to to
standby.

I reported this upstream: https://github.com/sddm/sddm/issues/562

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/
---

Review request for Plasma and Martin Klapetek.


Bugs: 355798
https://bugs.kde.org/show_bug.cgi?id=355798


Repository: bluedevil


Description
---

Set the minimum window size to be twice the width of PIN label.


Diffs
-

  src/wizard/pages/pairing.cpp 6d1eac0 

Diff: https://git.reviewboard.kde.org/r/126160/diff/


Testing
---

The window gets resized now if there is not enough free space for PIN.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 353463] RFE: Make use of iio-sensor-proxy

[Vincent Petry via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=353463

Vincent Petry  changed:

   What|Removed |Added

 CC||pvinc...@yahoo.fr

--- Comment #4 from Vincent Petry  ---
I have a Dell XPS 13 9333 laptop and the acpi-als driver started working in
recent kernel versions (4.2.3).

Adding self to CC to follow progress of this interesting feature :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126150: Ensure the spinboxes in image slideshow are wide enough

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126150/
---

(Updated Nov. 24, 2015, 6:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 4d0d55e4a2910ab8b50d98c2f2fd377b6f2af83c by Martin 
Klapetek to branch Plasma/5.5.


Bugs: 33
https://bugs.kde.org/show_bug.cgi?id=33


Repository: plasma-workspace


Description
---

Should fix https://bugs.kde.org/show_bug.cgi?id=33


Diffs
-

  wallpapers/image/imagepackage/contents/ui/config.qml e66bc23 

Diff: https://git.reviewboard.kde.org/r/126150/diff/


Testing
---

Looks wide enough.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

[Kai Uwe Broulik]

> On Nov. 23, 2015, 11:59 nachm., Aleix Pol Gonzalez wrote:
> > File Attachment: Avatar gallery - usermanageravatar2.png
> > 
> >
> > Why is this not a grid? O.=

That's been like this for ages. I don't really know how QListView works, when I 
enable uniform sizes, the text is always cut off. KIconDialog has a massive 
hack to get that sizing right and I didn't want to incorporate that here.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126151/#review88746
---


On Nov. 23, 2015, 9:50 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126151/
> ---
> 
> (Updated Nov. 23, 2015, 9:50 nachm.)
> 
> 
> Review request for Plasma, KDE Usability and Jonathan Riddell.
> 
> 
> Bugs: 354001
> http://bugs.kde.org/show_bug.cgi?id=354001
> 
> 
> Repository: user-manager
> 
> 
> Description
> ---
> 
> Including the avatars, that are no longer installed into /usr/share/kdm/icons 
> but /usr/share/user-manager/avatars. I don't know if there's a FDO location 
> for these.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7267d24 
>   src/accountinfo.h c6e70b3 
>   src/accountinfo.cpp 878f683 
>   src/avatargallery.h PRE-CREATION 
>   src/avatargallery.cpp PRE-CREATION 
>   src/avatargallery.ui PRE-CREATION 
>   src/pics/Ada Lovelace.png PRE-CREATION 
>   src/pics/Alice in Wonderland.png PRE-CREATION 
>   src/pics/Blackbox.png PRE-CREATION 
>   src/pics/CMakeLists.txt PRE-CREATION 
>   src/pics/Dragon.png PRE-CREATION 
>   src/pics/Grace Hopper.png PRE-CREATION 
>   src/pics/Green.png PRE-CREATION 
>   src/pics/Happy.png PRE-CREATION 
>   src/pics/Kati.png PRE-CREATION 
>   src/pics/Konqui.png PRE-CREATION 
>   src/pics/Leonardo da Vinci.png PRE-CREATION 
>   src/pics/Listening.png PRE-CREATION 
>   src/pics/Logger.png PRE-CREATION 
>   src/pics/Mahatma Gandhi.png PRE-CREATION 
>   src/pics/Mowgli jungle book.png PRE-CREATION 
>   src/pics/Notme.png PRE-CREATION 
>   src/pics/Parley.png PRE-CREATION 
>   src/pics/Rekonqui.png PRE-CREATION 
>   src/pics/TV.png PRE-CREATION 
>   src/pics/User.png PRE-CREATION 
>   src/pics/bomb.png PRE-CREATION 
>   src/pics/sources/Ada Lovelace.svg PRE-CREATION 
>   src/pics/sources/Alice in Wonderland.svg PRE-CREATION 
>   src/pics/sources/Dragon.svg PRE-CREATION 
>   src/pics/sources/Grace Hopper.svg PRE-CREATION 
>   src/pics/sources/Kati.svg PRE-CREATION 
>   src/pics/sources/Konqui.svg PRE-CREATION 
>   src/pics/sources/Leonardo da Vinci.svg PRE-CREATION 
>   src/pics/sources/Logger.svg PRE-CREATION 
>   src/pics/sources/Mahatma Gandhi.svg PRE-CREATION 
>   src/pics/sources/Mowgli jungle book.svg PRE-CREATION 
>   src/pics/sources/Parley.svg PRE-CREATION 
>   src/pics/sources/Rekonqui.svg PRE-CREATION 
>   src/pics/sources/User.svg PRE-CREATION 
>   src/pics/sources/blackbox.svgz PRE-CREATION 
>   src/pics/sources/bomb.svgz PRE-CREATION 
>   src/pics/sources/green.svgz PRE-CREATION 
>   src/pics/sources/happy.svgz PRE-CREATION 
>   src/pics/sources/listening.svgz PRE-CREATION 
>   src/pics/sources/notme.svgz PRE-CREATION 
>   src/pics/sources/tv.svgz PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126151/diff/
> 
> 
> Testing
> ---
> 
> Opened user manager, clicked my icon, clicked "Choose from Gallery", chose an 
> icon, OK. It prompted me three times for Polkit authentication for some 
> reason but in the end it worked, Kickoff also immediately updated its icon.
> 
> 
> File Attachments
> 
> 
> New menu option
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png
> Avatar gallery
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Fabian Köster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

--- Comment #7 from Fabian Köster  ---
Nice, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126148: [plasma-framework] qstring optimizations

[Marco Martin]

> On Nov. 23, 2015, 9:53 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/core/datamodel.cpp, line 58
> > 
> >
> > Why not constBegin()/constEnd()?
> 
> Nick Shaforostoff wrote:
> because rNames is const, constBegin()/constEnd() will be called internaly 
> anyways, and begin()/end() just look nicer

if it ends up being the same thing, i would prefer it more explicit with 
constbegin/constend


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/#review88737
---


On Nov. 23, 2015, 10:19 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126148/
> ---
> 
> (Updated Nov. 23, 2015, 10:19 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> also contains fix for clazy warning regarding iterating over temporary 
> roleNames() object
> 
> note that for QRegExp constructor and for QIcon::fromTheme() i used 
> QLatin1String because QStringLiteral is known to produce crashes-on-exit if 
> the code is inside a library
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 812dc96 
>   src/declarativeimports/core/datamodel.cpp 1c83bc5 
>   src/declarativeimports/core/framesvgitem.cpp 9aab228 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
>   src/plasma/applet.cpp 89c 
>   src/plasma/containment.cpp 1d166f2 
>   src/plasma/framesvg.cpp f9379b0 
>   src/plasma/pluginloader.cpp bfa5dee 
>   src/plasma/private/applet_p.cpp e935d52 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/plasma/private/theme_p.cpp 7bf81d4 
>   src/plasma/scripting/scriptengine.cpp 5b2cf84 
>   src/plasma/svg.cpp 20cb31f 
>   src/plasma/theme.cpp c49ad4c 
>   src/plasmaquick/appletquickitem.cpp efe8611 
>   src/plasmaquick/shellpluginloader.cpp 2824760 
> 
> Diff: https://git.reviewboard.kde.org/r/126148/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

[Boudhayan Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/#review88756
---


Since there has been no negative comments from the kde-distro-packagers mailing 
list posting (in fact, no comments at all), I'm committing this to Plasma/5.5 
and merging to master.

Reference to posting: 
https://mail.kde.org/pipermail/kde-distro-packagers/2015-November/000107.html

- Boudhayan Gupta


On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126091/
> ---
> 
> (Updated Nov. 16, 2015, 10:36 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Repository: khotkeys
> 
> 
> Description
> ---
> 
> After moving KSnapshot to Extragear I've modified it to install its own 
> khotkeys file (which it does correctly). Spectacle already installs its own 
> KHotkeys file, so there's no reason anymore for KHotkeys to include its own 
> PrintScreen hotkey file.
> 
> I'll push out a special release of KSnapshot for distributions to use once 
> the Plasma 5.5 version of KHotkeys is pushed out, so printscreen 
> functionality won't be broken on the desktop (assuming, that is, distros push 
> out the updates together).
> 
> 
> Diffs
> -
> 
>   data/CMakeLists.txt f3bcb57 
>   data/printscreen.khotkeys e583311 
> 
> Diff: https://git.reviewboard.kde.org/r/126091/diff/
> 
> 
> Testing
> ---
> 
> Doesn't install the printscreen.khotkeys file anymore
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/#review88757
---


You commited it to wrong branch.. should be Plasma/5.5 then master.

- Bhushan Shah


On Nov. 24, 2015, 5:23 p.m., Boudhayan Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126091/
> ---
> 
> (Updated Nov. 24, 2015, 5:23 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Repository: khotkeys
> 
> 
> Description
> ---
> 
> After moving KSnapshot to Extragear I've modified it to install its own 
> khotkeys file (which it does correctly). Spectacle already installs its own 
> KHotkeys file, so there's no reason anymore for KHotkeys to include its own 
> PrintScreen hotkey file.
> 
> I'll push out a special release of KSnapshot for distributions to use once 
> the Plasma 5.5 version of KHotkeys is pushed out, so printscreen 
> functionality won't be broken on the desktop (assuming, that is, distros push 
> out the updates together).
> 
> 
> Diffs
> -
> 
>   data/CMakeLists.txt f3bcb57 
>   data/printscreen.khotkeys e583311 
> 
> Diff: https://git.reviewboard.kde.org/r/126091/diff/
> 
> 
> Testing
> ---
> 
> Doesn't install the printscreen.khotkeys file anymore
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

[Boudhayan Gupta]

> On Nov. 24, 2015, 5:32 p.m., Bhushan Shah wrote:
> > You commited it to wrong branch.. should be Plasma/5.5 then master.

Pushed master first, sorry :-D


- Boudhayan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/#review88757
---


On Nov. 24, 2015, 5:23 p.m., Boudhayan Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126091/
> ---
> 
> (Updated Nov. 24, 2015, 5:23 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Repository: khotkeys
> 
> 
> Description
> ---
> 
> After moving KSnapshot to Extragear I've modified it to install its own 
> khotkeys file (which it does correctly). Spectacle already installs its own 
> KHotkeys file, so there's no reason anymore for KHotkeys to include its own 
> PrintScreen hotkey file.
> 
> I'll push out a special release of KSnapshot for distributions to use once 
> the Plasma 5.5 version of KHotkeys is pushed out, so printscreen 
> functionality won't be broken on the desktop (assuming, that is, distros push 
> out the updates together).
> 
> 
> Diffs
> -
> 
>   data/CMakeLists.txt f3bcb57 
>   data/printscreen.khotkeys e583311 
> 
> Diff: https://git.reviewboard.kde.org/r/126091/diff/
> 
> 
> Testing
> ---
> 
> Doesn't install the printscreen.khotkeys file anymore
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126150: Ensure the spinboxes in image slideshow are wide enough

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126150/#review88758
---

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 23, 2015, 9:42 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126150/
> ---
> 
> (Updated Nov. 23, 2015, 9:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 33
> https://bugs.kde.org/show_bug.cgi?id=33
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Should fix https://bugs.kde.org/show_bug.cgi?id=33
> 
> 
> Diffs
> -
> 
>   wallpapers/image/imagepackage/contents/ui/config.qml e66bc23 
> 
> Diff: https://git.reviewboard.kde.org/r/126150/diff/
> 
> 
> Testing
> ---
> 
> Looks wide enough.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel