Re: Review Request 126221: Rework the notifications positioning a bit

[Kai Uwe Broulik]

> On Dez. 2, 2015, 11:36 nachm., Mark Gaiser wrote:
> > I had this issue for quite a while!
> > It's in bug #349669, i have high hopes that this change fixes my case as 
> > well :)
> > 
> > Will try this out somewhere this weekend.
> 
> Martin Klapetek wrote:
> No, unfortunately this will not fix this issue, but it is related.
> It's the same problem, in fact, but as the notifications use manual
> positioning on the screen, it needs a fix in that code first.
> 
> Afaiu the problem happens when something positions a window "out of
> bounds", ie. out of screen and/or in panel struts, then something else
> takes it (either KWin or Qt/X11 or PlasmaQuick::Dialog) and puts it
> back within bounds, but with y=0. Unfortunately I don't understand
> window placement enough to precisely pinpoint where/why it goes to y=0.

Bug 349669 should have been fixed by 
https://quickgit.kde.org/?p=plasma-framework.git&a=commit&h=8ce47c5f1e422f9093a8da0e2a548082792bbd1a


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126221/#review89064
---


On Dez. 3, 2015, 4:11 vorm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126221/
> ---
> 
> (Updated Dez. 3, 2015, 4:11 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355069
> https://bugs.kde.org/show_bug.cgi?id=355069
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The notifications popup positioning recently regressed
> by some other changes (looks like Qt) and the popups
> would fly across the screen (bug 355069).
> 
> The proper solution is using KWin effect but given how
> close the release is, this needs to be dealt with in a
> different way.
> 
> The main problem is calculating the initial popup size
> because as long as the Dialog is invisible, it has an
> incorrect geometry, so it needs to be positioned right
> after it's being displayed. The Dialog however gets the
> sizes even later, so the code now calls a slot from Dialog
> that ensures the sizes are correct before the initial
> placement on screen. It's not ideal but I'm out of ideas
> otherwise. Plus it should be only temporary until the
> KWin effect will replace it.
> 
> 
> Diffs
> -
> 
>   applets/notifications/lib/notificationsapplet.cpp aa50aef 
>   applets/notifications/package/contents/ui/Notifications.qml 306169c 
>   applets/notifications/plugin/notificationshelper.h cb9b335 
>   applets/notifications/plugin/notificationshelper.cpp 7c0dd99 
>   applets/notifications/lib/notificationsapplet.h dc31e1d 
> 
> Diff: https://git.reviewboard.kde.org/r/126221/diff/
> 
> 
> Testing
> ---
> 
> I can no longer reproduce notifications flying across
> the screen.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126221: Rework the notifications positioning a bit

[Mark Gaiser]

> On dec 2, 2015, 11:36 p.m., Mark Gaiser wrote:
> > I had this issue for quite a while!
> > It's in bug #349669, i have high hopes that this change fixes my case as 
> > well :)
> > 
> > Will try this out somewhere this weekend.
> 
> Martin Klapetek wrote:
> No, unfortunately this will not fix this issue, but it is related.
> It's the same problem, in fact, but as the notifications use manual
> positioning on the screen, it needs a fix in that code first.
> 
> Afaiu the problem happens when something positions a window "out of
> bounds", ie. out of screen and/or in panel struts, then something else
> takes it (either KWin or Qt/X11 or PlasmaQuick::Dialog) and puts it
> back within bounds, but with y=0. Unfortunately I don't understand
> window placement enough to precisely pinpoint where/why it goes to y=0.
> 
> Kai Uwe Broulik wrote:
> Bug 349669 should have been fixed by 
> https://quickgit.kde.org/?p=plasma-framework.git&a=commit&h=8ce47c5f1e422f9093a8da0e2a548082792bbd1a

Hi Kai, thank you for letting me know. I'm definitely going to test that patch 
:)


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126221/#review89064
---


On dec 3, 2015, 4:11 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126221/
> ---
> 
> (Updated dec 3, 2015, 4:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355069
> https://bugs.kde.org/show_bug.cgi?id=355069
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The notifications popup positioning recently regressed
> by some other changes (looks like Qt) and the popups
> would fly across the screen (bug 355069).
> 
> The proper solution is using KWin effect but given how
> close the release is, this needs to be dealt with in a
> different way.
> 
> The main problem is calculating the initial popup size
> because as long as the Dialog is invisible, it has an
> incorrect geometry, so it needs to be positioned right
> after it's being displayed. The Dialog however gets the
> sizes even later, so the code now calls a slot from Dialog
> that ensures the sizes are correct before the initial
> placement on screen. It's not ideal but I'm out of ideas
> otherwise. Plus it should be only temporary until the
> KWin effect will replace it.
> 
> 
> Diffs
> -
> 
>   applets/notifications/lib/notificationsapplet.cpp aa50aef 
>   applets/notifications/package/contents/ui/Notifications.qml 306169c 
>   applets/notifications/plugin/notificationshelper.h cb9b335 
>   applets/notifications/plugin/notificationshelper.cpp 7c0dd99 
>   applets/notifications/lib/notificationsapplet.h dc31e1d 
> 
> Diff: https://git.reviewboard.kde.org/r/126221/diff/
> 
> 
> Testing
> ---
> 
> I can no longer reproduce notifications flying across
> the screen.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 03 Dec 2015 10:38:35 +
Build duration: 1 min 47 sec

CHANGE SET
Revision 0ef5a3c367194d8df220ce12abaf714fbcd01913 by Martin Gräßlin: 
([startkde] Fix font prefixDir)
  change: edit startkde/startkde.cmake
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.5 video

[Jonathan Riddell]

Updated video

https://youtu.be/AAPE_G-FVBc

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Weng Xuetian]

Just tried to debug it a little bit, looks like FolderModel::drop is
not called at all.

From the observed visual behavior, plasmashell seems to takes the drop
as a new plasmoid request so FolderModel doesn't get the drop event.

Probably it is blocked by following code in desktop containment.
if (isFolder && event.mimeData.hasUrls)

On Tue, Dec 1, 2015 at 5:46 AM, Elvis Angelaccio
 wrote:
>
>
> 2015-12-01 14:13 GMT+01:00 Bhushan Shah :
>>
>> Hello,
>>
>> On Tue, Dec 1, 2015 at 6:39 PM, Marco Martin  wrote:
>> >>
>> >> In Plasma 5 this does not work anymore, as kde-base repo has not been
>> >> ported. But I see that drag-and-dropping files from Dolphin to the
>> >> desktop
>> >> works, so: where is Ark supposed to "register" this dbus method, in
>> >> Plasma
>> >> 5?
>> >
>> > Hi,
>> > folderview is now in the plasma-desktop repository, in
>> > plasma-desktop/applets/folder
>> > It has been completely rewritten so something may have been lost in
>> > translation.
>> > What was it doing exactly? was it folderview invoking a dbus method
>> > explicitly on Ark?
>
>
> Yes, it was invoking the method extractSelectedFilesTo of dbus interface
> org.kde.ark.DndExtract, from line 2362 of
> kde-base/plasma/applets/folderview/iconview.cpp
>
>
>>
>>
>> plasma-desktop still have code specific to ark
>>
>> plasma-desktop/containments/desktop/plugins/folder/foldermodel.cpp
>> L744 and ahead..
>>
>
> I see. Then I wonder what might be going wrong. From my limited dbus
> knowledge I cannot tell whether it's Ark's or Plasma's fault.
> Any help on this would be very appreciated, as dragging from Ark to the
> desktop can be considered a major feature, currently broken.
>
> Just a recap on the situation:
> - Ark defines this dbus method in: ark/part/dnddbusinterface.xml
> - Drag-and-dropping from Ark to Dolphin works
> - Drag-and-dropping from Ark to Desktop or Folder View plasmoid does not
> work - the dbus method seems to not be called at all
>
>
>
>> Also if I remember correctly, this used to work in initial plasma
>> release..
>>
>> --
>> Bhushan Shah
>>
>> http://bhush9.github.io
>> IRC Nick : bshah on Freenode
>
>
> Cheers,
> Elvis
>
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: kinfocenter Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinfocenter%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 03 Dec 2015 11:14:15 +
Build duration: 4 min 9 sec

CHANGE SET
Revision 8ac14b77bb706c8bdf16b16b36ee206f60df83aa by Jonathan Riddell: (Update 
version number for 5.5.90 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: kinfocenter Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinfocenter%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 03 Dec 2015 11:14:15 +
Build duration: 4 min 9 sec

CHANGE SET
Revision 8ac14b77bb706c8bdf16b16b36ee206f60df83aa by Jonathan Riddell: (Update 
version number for 5.5.90 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 03 Dec 2015 11:31:30 +
Build duration: 3 min 56 sec

CHANGE SET
Revision 8aa71030c2ac2f607b0ef62c309b842e162f896e by Jonathan Riddell: (Update 
version number for 5.5.0 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 03 Dec 2015 12:28:05 +
Build duration: 1 min 30 sec

CHANGE SET
Revision 4b597be8216d985798f392965f622f462fb2c841 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit klipper/org.kde.klipper.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Eike Hein]

On 12/03/2015 12:04 PM, Weng Xuetian wrote:
> Just tried to debug it a little bit, looks like FolderModel::drop is
> not called at all.
> 
> From the observed visual behavior, plasmashell seems to takes the drop
> as a new plasmoid request so FolderModel doesn't get the drop event.
> 
> Probably it is blocked by following code in desktop containment.
> if (isFolder && event.mimeData.hasUrls)

The .hasUrls prop is a recent change after changes
in plasma-framework, so it might explain the regression.


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.5 video

[Mario Fux]

Am Thursday 03 December 2015, 11.02:45 schrieb Jonathan Riddell:
> Updated video
> 
> https://youtu.be/AAPE_G-FVBc

Looks nice. Some remarks:
- Overlay text at 0:09 has a typo: "Enahanced" => "Enhanced"
- Filtering of activities doesn't really make sense with 3 of them...
- Overlay text at 0:58. Badly readable, mostly at the windows borders
- At 1:40: why is "Freedom" cropped in Muon? 
- At 1:43: same problems with overlay text (readability)

Take this as constructive feedback. I like the work and hope to see more 
videos of this kind for all the great Plasma features.

Thanks
Mario
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma 5.5 tars

[Jonathan Riddell]

5.5.0 tars are up now on depot available to packagers, will be made
public along with the release scheduled for Tuesday

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.5 tars

[Michael Palimaka]

On 04/12/15 01:30, Jonathan Riddell wrote:
> 5.5.0 tars are up now on depot available to packagers, will be made
> public along with the release scheduled for Tuesday
> 
> Jonathan
> ___
> release-team mailing list
> release-t...@kde.org
> https://mail.kde.org/mailman/listinfo/release-team
> 

Hi,

The notes widget still seems to be broken with released versions of
plasma-framework due to
https://quickgit.kde.org/?p=kdeplasma-addons.git&a=commitdiff&h=d52e64f5e87d134326cc64fe861716d341a3abc3
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Eike Hein]

4018e27a in plasma-desktop fixes the FV side.

It's still not really working for the Desktop folder though.
Ark claims to be extracting to desktop:/, but just dumps the
file into $HOME. It's the same with desktop:/ in Dolphin though.


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126166: use stylesheets in breeze icons

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126166/
---

(Updated Dec. 3, 2015, 5:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, andreas kainz and Uri Herrera.


Changes
---

Submitted with commit 6d2a8c0feb02c8d5491e27e0a2a372da750137ab by Marco Martin 
to branch master.


Repository: breeze-icons


Description
---

unfortunately the diff was about 35 megabytes, so was too big for reviewboard 
little mind ;)
a tarball of the modified icons can be found at 
http://notmart.org/misc/breeze-icons.tar.bz2
this changes the monochrome breeze icons (other icons are untouched) to use 
stylesheets instead of hardcoded colors, at least with text color for the black 
bits, background for the light bits.
This is kinda needed for icons loaded in plasma (even tough some basic icons in 
the plasma theme systray and actions are still needed, less duplication would 
be needed)
Will be needed a bit more stringently in plasma mobile, where the plasma theme 
is used as theme for applications (and probably some effects will be needed 
like changing icons from black to white on the fly)

This change is not supposed to change the look of any icon anywhere: for 
desktop applications all of them should look *exactly* the same as they did 
(please doublecheck this ;))


Diffs
-

  CMakeLists.txt 886ab74 

Diff: https://git.reviewboard.kde.org/r/126166/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.5 video

[Martin Klapetek]

On Thu, Dec 3, 2015 at 6:02 AM, Jonathan Riddell  wrote:

>
> Updated video
>
> https://youtu.be/AAPE_G-FVBc


The window that opens at 00:20 still doesn't make any sense.
As a viewer I have no idea what is that window showing me
and it quickly clicks through and stays overall 2 seconds only
on the screen. I think it adds no value other than "there is a
window you can click through".

The titles imho really need a drop-shadow-kinda effect, it's still
not very well readable.

The first and last title - they look kinda...old-school, not entirely
modern. I think simple fade-in/panning, perhaps with a logo,
would be just enough. This reminds me of wordarts :)

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126233/
---

Review request for Plasma and Elvis Angelaccio.


Repository: ark


Description
---

Ark's D-Bus service only supports extraction to local paths, which breaks 
dropping files onto a Folder View using desktop:/. Ideally Ark would use KIO 
properly (difficult though since not all the backend tools ultimately support 
it, etc.), but in lieu of that I think it's best to resolve to a local path 
whenever possible on the Ark side, since otherwise it has to be done in all the 
callers (aside from FV we also have Dolphin).

See also https://mail.kde.org/pipermail/plasma-devel/2015-December/046881.html


Diffs
-

  part/part.cpp 240b628 

Diff: https://git.reviewboard.kde.org/r/126233/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126233/
---

(Updated Dec. 3, 2015, 5:29 p.m.)


Review request for Plasma and Elvis Angelaccio.


Changes
---

Remove unnecessary include.


Repository: ark


Description
---

Ark's D-Bus service only supports extraction to local paths, which breaks 
dropping files onto a Folder View using desktop:/. Ideally Ark would use KIO 
properly (difficult though since not all the backend tools ultimately support 
it, etc.), but in lieu of that I think it's best to resolve to a local path 
whenever possible on the Ark side, since otherwise it has to be done in all the 
callers (aside from FV we also have Dolphin).

See also https://mail.kde.org/pipermail/plasma-devel/2015-December/046881.html


Diffs (updated)
-

  part/part.cpp 240b628 

Diff: https://git.reviewboard.kde.org/r/126233/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126166: use stylesheets in breeze icons

[Marco Martin]

> On Nov. 26, 2015, 5 p.m., Marco Martin wrote:
> > *please* VDG people, take a look at this asap. I already seen that new 
> > changes have been done to icons in master, which means that i'll have to 
> > redo this from scratch.
> 
> Uri Herrera wrote:
> This needs to be documented first. Properly. Once it's documented then 
> we'll go on with the change.
> 
> Marco Martin wrote:
> the documentation talking about it so far is
> 
> https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors
> 
> I know is just a small paragraph, but i'm not sure what's needed more to 
> be clearly understandable.. I can expand on that if I am explained the 
> unclear points.
> 
> Uri Herrera wrote:
> If I run apply-stylesheet.sh in icons that don't have the attribute the 
> script will add it? or would I have to run currentColorFix.sh first and then 
> apply-stylesheet.sh?.
> 
> Marco Martin wrote:
> it should add it, it depends also what are the colors used, as in those 
> icons the monochrome dark color is #4d4d4d, would need the parameters 
> --TextFrom=#4d4d4d --TextTo=#4d4d4d  that tells what color to replace with 
> the TextColor class.
> 
> Marco Martin wrote:
> anyways, if the status in the tarball is still current, would be good to 
> apply it, as I see so far only system-lock-screen has diverged (and a 
> mimetype added)
> 
> andreas kainz wrote:
> hi 
> 
> I don't know how I can test them but I would prefere an automatic 
> solution also for applications cause some applications want to use dark 
> background and than the icons should be automatic the dark ones. as we have 
> dark and light icons why you don't say plasma dark is used => use dark icons 
> and at the applications the same dark color scheme => dark icons. we can also 
> use the stylesheet script but than we should reduce the icon set to breeze 
> and breeze dark was generated via stylesheet.
> 
> sorry for the late replay I didn't have spare time in the past weeks.
> 
> Marco Martin wrote:
> the testing i'm interested in, is just to see that they don't change 
> their look when used in normal applications or opened in inkscape.
> i need this stylesheet thing in plasma as in plsma mobile we are going to 
> have different areas where the icon can be either dark or light in the same 
> application, plus applications that define their own color.
> Desktop applications have an old broken way to load icons and there is 
> nothing that can be done, but i don't want to keep being pushed back by that 
> for QML applications that don't have the same limits.
> And yeah, would be quite silly to use a patched clone of the breeze icons 
> for plasma mobile, but that's how we need monochrome icons to be done.
> 
> andreas kainz wrote:
> I open an file with inkscape delete everything say clear file and make 
> everything new. It works. so I would say ship it. but I will have an solution 
> for kde applications also.
> 
> andreas kainz wrote:
> I add some icons in icons/status/22 folder so this icons are missing in 
> your diff.

Ok, I adjusted those too


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126166/#review88869
---


On Dec. 3, 2015, 5:20 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126166/
> ---
> 
> (Updated Dec. 3, 2015, 5:20 p.m.)
> 
> 
> Review request for Plasma, andreas kainz and Uri Herrera.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> unfortunately the diff was about 35 megabytes, so was too big for reviewboard 
> little mind ;)
> a tarball of the modified icons can be found at 
> http://notmart.org/misc/breeze-icons.tar.bz2
> this changes the monochrome breeze icons (other icons are untouched) to use 
> stylesheets instead of hardcoded colors, at least with text color for the 
> black bits, background for the light bits.
> This is kinda needed for icons loaded in plasma (even tough some basic icons 
> in the plasma theme systray and actions are still needed, less duplication 
> would be needed)
> Will be needed a bit more stringently in plasma mobile, where the plasma 
> theme is used as theme for applications (and probably some effects will be 
> needed like changing icons from black to white on the fly)
> 
> This change is not supposed to change the look of any icon anywhere: for 
> desktop applications all of them should look *exactly* the same as they did 
> (please doublecheck this ;))
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 886ab74 
> 
> Diff: https://git.reviewboard.kde.org/r/126166/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco M

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Eike Hein]

This fixes the Ark side, please review:

https://git.reviewboard.kde.org/r/126233/


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126234: Fix build with Qt 5.6

[Jan Kundrát]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126234/
---

Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.


Repository: kwin


Description
---

Fix build with Qt 5.6

A recent change [1] led to Qt5PlatformSupport.pc not being installed
anymore. Pkg-config was only used for finding the paths, and the actual
include flags and library names were hardcoded in KWin's
FindQt5PlatformSupport.cmake anyway, so let's just focus on finding
Qt5Gui, the module which provides this Qt5PlatformSupport library, and
work from there.

Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream
Gerrit change.

[1] https://codereview.qt-project.org/140954/

REVIEW: 126234


Diffs
-

  cmake/modules/FindQt5PlatformSupport.cmake 
90a8438ac80e48b09463ba5f34a72b2d7567ea5d 

Diff: https://git.reviewboard.kde.org/r/126234/diff/


Testing
---


Thanks,

Jan Kundrát

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126234: Fix build with Qt 5.6

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126234/#review89090
---


2nd best solution after not using Qt5PlatformSupport at all :D

- Hrvoje Senjan


On Dec. 3, 2015, 6:37 p.m., Jan Kundrát wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126234/
> ---
> 
> (Updated Dec. 3, 2015, 6:37 p.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> Fix build with Qt 5.6
> 
> A recent change [1] led to Qt5PlatformSupport.pc not being installed
> anymore. Pkg-config was only used for finding the paths, and the actual
> include flags and library names were hardcoded in KWin's
> FindQt5PlatformSupport.cmake anyway, so let's just focus on finding
> Qt5Gui, the module which provides this Qt5PlatformSupport library, and
> work from there.
> 
> Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream
> Gerrit change.
> 
> [1] https://codereview.qt-project.org/140954/
> 
> REVIEW: 126234
> 
> 
> Diffs
> -
> 
>   cmake/modules/FindQt5PlatformSupport.cmake 
> 90a8438ac80e48b09463ba5f34a72b2d7567ea5d 
> 
> Diff: https://git.reviewboard.kde.org/r/126234/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126233/#review89091
---

Ship it!


Thanks for working on this!
This patch does fix bug 294904 [1], so you could even commit it to 
Applications/15.12 branch.

[1]: https://bugs.kde.org/show_bug.cgi?id=294904

- Elvis Angelaccio


On Dec. 3, 2015, 5:29 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126233/
> ---
> 
> (Updated Dec. 3, 2015, 5:29 p.m.)
> 
> 
> Review request for Plasma and Elvis Angelaccio.
> 
> 
> Repository: ark
> 
> 
> Description
> ---
> 
> Ark's D-Bus service only supports extraction to local paths, which breaks 
> dropping files onto a Folder View using desktop:/. Ideally Ark would use KIO 
> properly (difficult though since not all the backend tools ultimately support 
> it, etc.), but in lieu of that I think it's best to resolve to a local path 
> whenever possible on the Ark side, since otherwise it has to be done in all 
> the callers (aside from FV we also have Dolphin).
> 
> See also https://mail.kde.org/pipermail/plasma-devel/2015-December/046881.html
> 
> 
> Diffs
> -
> 
>   part/part.cpp 240b628 
> 
> Diff: https://git.reviewboard.kde.org/r/126233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

[Eike Hein]

> On Dec. 3, 2015, 5:52 p.m., Elvis Angelaccio wrote:
> > Thanks for working on this!
> > This patch does fix bug 294904 [1], so you could even commit it to 
> > Applications/15.12 branch.
> > 
> > [1]: https://bugs.kde.org/show_bug.cgi?id=294904

Will do~


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126233/#review89091
---


On Dec. 3, 2015, 5:29 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126233/
> ---
> 
> (Updated Dec. 3, 2015, 5:29 p.m.)
> 
> 
> Review request for Plasma and Elvis Angelaccio.
> 
> 
> Repository: ark
> 
> 
> Description
> ---
> 
> Ark's D-Bus service only supports extraction to local paths, which breaks 
> dropping files onto a Folder View using desktop:/. Ideally Ark would use KIO 
> properly (difficult though since not all the backend tools ultimately support 
> it, etc.), but in lieu of that I think it's best to resolve to a local path 
> whenever possible on the Ark side, since otherwise it has to be done in all 
> the callers (aside from FV we also have Dolphin).
> 
> See also https://mail.kde.org/pipermail/plasma-devel/2015-December/046881.html
> 
> 
> Diffs
> -
> 
>   part/part.cpp 240b628 
> 
> Diff: https://git.reviewboard.kde.org/r/126233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126233/
---

(Updated Dec. 3, 2015, 6:12 p.m.)


Review request for Plasma and Elvis Angelaccio.


Bugs: 294904
http://bugs.kde.org/show_bug.cgi?id=294904


Repository: ark


Description
---

Ark's D-Bus service only supports extraction to local paths, which breaks 
dropping files onto a Folder View using desktop:/. Ideally Ark would use KIO 
properly (difficult though since not all the backend tools ultimately support 
it, etc.), but in lieu of that I think it's best to resolve to a local path 
whenever possible on the Ark side, since otherwise it has to be done in all the 
callers (aside from FV we also have Dolphin).

See also https://mail.kde.org/pipermail/plasma-devel/2015-December/046881.html


Diffs
-

  part/part.cpp 240b628 

Diff: https://git.reviewboard.kde.org/r/126233/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126233/
---

(Updated Dec. 3, 2015, 6:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Elvis Angelaccio.


Changes
---

Submitted with commit fa467314a39d596ab7bd785ced637f599c4055ba by Eike Hein to 
branch Applications/15.12.


Bugs: 294904
http://bugs.kde.org/show_bug.cgi?id=294904


Repository: ark


Description
---

Ark's D-Bus service only supports extraction to local paths, which breaks 
dropping files onto a Folder View using desktop:/. Ideally Ark would use KIO 
properly (difficult though since not all the backend tools ultimately support 
it, etc.), but in lieu of that I think it's best to resolve to a local path 
whenever possible on the Ark side, since otherwise it has to be done in all the 
callers (aside from FV we also have Dolphin).

See also https://mail.kde.org/pipermail/plasma-devel/2015-December/046881.html


Diffs
-

  part/part.cpp 240b628 

Diff: https://git.reviewboard.kde.org/r/126233/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Eike Hein]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
> 
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to 
> improve this in Plasma 5.5 and scratch the code completely.
> 
> Great and I agree that the code is not great --all those wasted service 
> lookups and subtly broken caching of the answer-- but: where is this 
> alternative code that fixes everything? ;) Right now, I think this change 
> amounts to a trivial fix (just one forgotten case in the if-clause) to an 
> existing 'feature'/workaround that has a fairly immediate benefit (something 
> works again) and little cost: it's hardly a new one.
> 
> Martin Gräßlin wrote:
> yeah sure, this was not meant as a "blocking" comment. I think the change 
> should go in, but leave the decision to Eike.
> 
> I btw. already started working on the improvement by proposing a new 
> addition to the NETWM spec and implementing it in KWindowSystem.
> 
> Johan Ouwerkerk wrote:
> Eike: what's your verdict? To ship or not to ship?
> 
> (In the case of shipping it: please note that I do not have commit access 
> (just a KDE identity account) so please pull these changes because I cannot 
> commit them.)
> 
> Johan Ouwerkerk wrote:
> Now that my developer account has been approved (that took a few weeks), 
> let's revisit this:
> 
> @Eike: should I push to master or not?

Martin, what's the status of your prop-based way?


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126210: [phonon] Do not set RPATH

[Alex Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126210/#review89096
---


+1

I think RPATH stuff is already set up correctly by extra-cmake-modules so there 
should be no need for that code

- Alex Richardson


On Nov. 30, 2015, 7:16 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126210/
> ---
> 
> (Updated Nov. 30, 2015, 7:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This very old piece of code triggers a scanelf warning during build. I don't 
> know why it is there, hopefully someone knows.
> 
> 
> Diffs
> -
> 
>   phonon/platform_kde/CMakeLists.txt 281425fb6f6c1a41f14399ac17f8a94cd99507ad 
> 
> Diff: https://git.reviewboard.kde.org/r/126210/diff/
> 
> 
> Testing
> ---
> 
> Builds, and runs (unfortunately can't run the tests), phonon test playback 
> included.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89097
---



kde-modules/KDETemplateMacro.cmake (line 1)


You might want to add documentation.

You can get inspired with `kde-modules/KDEFrameworkCompilerSettings.cmake` 
or `modules/ECMInstallIcons.cmake`. Note it's also lacking the copyright header.


- Aleix Pol Gonzalez


On Dec. 3, 2015, 1:34 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 3, 2015, 1:34 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   kde-modules/KDETemplateMacro.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126237: make comment role searchable in timezone selection

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126237/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

BUG: 354238
FIXED-IN: 5.5.1


Diffs
-

  applets/digital-clock/plugin/timezonemodel.cpp 
5d2350505e286280dd59dd7964ea1819026150e4 

Diff: https://git.reviewboard.kde.org/r/126237/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126237: make comment role searchable in timezone selection

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126237/#review89098
---



applets/digital-clock/plugin/timezonemodel.cpp (line 41)


Also maybe cache the QModelIndex?


- Aleix Pol Gonzalez


On Dec. 4, 2015, 2:12 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126237/
> ---
> 
> (Updated Dec. 4, 2015, 2:12 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> BUG: 354238
> FIXED-IN: 5.5.1
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/timezonemodel.cpp 
> 5d2350505e286280dd59dd7964ea1819026150e4 
> 
> Diff: https://git.reviewboard.kde.org/r/126237/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126234: Fix build with Qt 5.6

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126234/#review89103
---

Ship it!


- Martin Gräßlin


On Dec. 3, 2015, 6:37 p.m., Jan Kundrát wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126234/
> ---
> 
> (Updated Dec. 3, 2015, 6:37 p.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> Fix build with Qt 5.6
> 
> A recent change [1] led to Qt5PlatformSupport.pc not being installed
> anymore. Pkg-config was only used for finding the paths, and the actual
> include flags and library names were hardcoded in KWin's
> FindQt5PlatformSupport.cmake anyway, so let's just focus on finding
> Qt5Gui, the module which provides this Qt5PlatformSupport library, and
> work from there.
> 
> Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream
> Gerrit change.
> 
> [1] https://codereview.qt-project.org/140954/
> 
> REVIEW: 126234
> 
> 
> Diffs
> -
> 
>   cmake/modules/FindQt5PlatformSupport.cmake 
> 90a8438ac80e48b09463ba5f34a72b2d7567ea5d 
> 
> Diff: https://git.reviewboard.kde.org/r/126234/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126234: Fix build with Qt 5.6

[Martin Gräßlin]

> On Dec. 3, 2015, 6:51 p.m., Hrvoje Senjan wrote:
> > 2nd best solution after not using Qt5PlatformSupport at all :D

well we have to :-( I wanted to not rely on it, but we need it to get working 
fonts.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126234/#review89090
---


On Dec. 3, 2015, 6:37 p.m., Jan Kundrát wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126234/
> ---
> 
> (Updated Dec. 3, 2015, 6:37 p.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> Fix build with Qt 5.6
> 
> A recent change [1] led to Qt5PlatformSupport.pc not being installed
> anymore. Pkg-config was only used for finding the paths, and the actual
> include flags and library names were hardcoded in KWin's
> FindQt5PlatformSupport.cmake anyway, so let's just focus on finding
> Qt5Gui, the module which provides this Qt5PlatformSupport library, and
> work from there.
> 
> Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream
> Gerrit change.
> 
> [1] https://codereview.qt-project.org/140954/
> 
> REVIEW: 126234
> 
> 
> Diffs
> -
> 
>   cmake/modules/FindQt5PlatformSupport.cmake 
> 90a8438ac80e48b09463ba5f34a72b2d7567ea5d 
> 
> Diff: https://git.reviewboard.kde.org/r/126234/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Martin Gräßlin]

> On Nov. 11, 2015, 8:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
> 
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to 
> improve this in Plasma 5.5 and scratch the code completely.
> 
> Great and I agree that the code is not great --all those wasted service 
> lookups and subtly broken caching of the answer-- but: where is this 
> alternative code that fixes everything? ;) Right now, I think this change 
> amounts to a trivial fix (just one forgotten case in the if-clause) to an 
> existing 'feature'/workaround that has a fairly immediate benefit (something 
> works again) and little cost: it's hardly a new one.
> 
> Martin Gräßlin wrote:
> yeah sure, this was not meant as a "blocking" comment. I think the change 
> should go in, but leave the decision to Eike.
> 
> I btw. already started working on the improvement by proposing a new 
> addition to the NETWM spec and implementing it in KWindowSystem.
> 
> Johan Ouwerkerk wrote:
> Eike: what's your verdict? To ship or not to ship?
> 
> (In the case of shipping it: please note that I do not have commit access 
> (just a KDE identity account) so please pull these changes because I cannot 
> commit them.)
> 
> Johan Ouwerkerk wrote:
> Now that my developer account has been approved (that took a few weeks), 
> let's revisit this:
> 
> @Eike: should I push to master or not?
> 
> Eike Hein wrote:
> Martin, what's the status of your prop-based way?

I need to update the proposal again to incorporate the feedback. Didn't find 
time for that yet.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 7:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 7:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel