Re: notification plasmoid for desktop

[kainz.a]

2015-12-16 17:21 GMT+01:00 Martin Klapetek :

> On Wed, Dec 16, 2015 at 4:43 AM, Marco Martin  wrote:
>
>>
>> to have a quick glance at them when the windows don't cover everything,
>> just
>> the same use case of any other desktop plasmoid.
>> in general, all plasmoid should disaplay correctly on the desktop and when
>> they don't it tends to be a bug unless there are specific reasons for
>> that. I
>> think the problem at them moment is that it doesn't switch from the
>> compact
>> representation, right?
>>
>
> It does, maybe the sizes are set too big for a default but it does
> switch.
>

what's the minimum size cause I scale the notification to something like
400x400 px


> The actual unusefulness actually comes from the fact
> that the applet does not show anything at all in 90% of the cases
> as it shows only persistent notifications _and_ they go away
> after 10 minutes from it anyway.
>

what's the reason that it will be removed after 10 minutes? wouldn't it be
nice to have also an history? grouped by date and filters for type.


> So with the current form, it sure is possible, I just don't see much
> value in it as it would be just a grey blob sitting on your desktop.
>
> As for the sidebar usecase Andreas mentioned, well, I did propose
> that two months ago, nobody liked it.
>

I like it
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126381: kwayland backend for libkscreen

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89616
---


Great job! 

I can't really comment on the actual Wayland functionality, I leave that to 
Martin ;) but the code looks pretty good overall.

As I mentioned in one of the comments, there is absolutely no requirement to 
follow the design of other backends, so if you think you would be better off 
with another approach in some places, just go ahead.

Below are mostly nitpicks.


autotests/testkwaylandbackend.cpp (line 144)


const&



autotests/testkwaylandbackend.cpp (line 240)


Use QTRY_COMPARE(configSpy.count(), 1). Hardcoding random timeouts tends to 
randomly fail on our overcrowded CI.



autotests/testkwaylandbackend.cpp (line 259)


QTRY_COMPARE here as well



autotests/testkwaylandconfig.cpp (line 102)


IMO you should QVERIFY() if your test invariants that you are testing 
actually have the expected value.



autotests/testkwaylandconfig.cpp (line 113)


QTRY_VERIFY/QTRY_COMPARE



autotests/testkwaylandconfig.cpp (line 117)


Why > 3? You do 2 changes, should not that emit exactly 2 change 
notifications?



autotests/testkwaylandconfig.cpp (line 143)


QTRY_VERIFY



autotests/testkwaylandconfig.cpp (line 147)


Shouldn't this always be equal to 1? I mean if you perform exactly one 
change on a single output, you should not get more than one 
configurationChanged notifications from ConfigMonitor...



autotests/testkwaylandconfig.cpp (line 169)


QTRY_VERIFY/QTRY_COMPARE



autotests/testkwaylandconfig.cpp (line 173)


Exact change count?



autotests/testkwaylandconfig.cpp (line 197)


QTRY_VERIFY



autotests/testkwaylandconfig.cpp (line 201)


More precise change count



backends/kwayland/waylandbackend.cpp (line 90)


Why not use the `cfg` here? WaylandConfig seems to keep a reasonably 
up-to-date copy of KScreen::ConfigPtr



backends/kwayland/waylandconfig.cpp (line 110)


if (!m_thread->wait(3000)) {
   m_thread->terminate();
   m_thread()->wait();
}



backends/kwayland/waylandconfig.cpp (line 172)


Not that I would not like lambda slots, but there should be limit on how 
much code you can stuff into them :)

IMO if it's not possible to deduce what the code is doing from a quick 
glance at it, it should not be an anonymous lambda, but a normal method with a 
descriptive name.



backends/kwayland/waylandconfig.cpp (line 228)


const&



tests/kwayland/waylandconfigreader.cpp (lines 98 - 102)


Use initializer list


- Daniel Vrátil


On Dec. 16, 2015, 3:05 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dec. 16, 2015, 3:05 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> 

Re: Review Request 126373: change the taskbar color from blue to gray

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/
---

(Updated Dec. 16, 2015, 7:23 p.m.)


Review request for Plasma, Marco Martin and Uri Herrera.


Repository: plasma-framework


Description
---

Problem
===
with the new taskbar we look that the look and feel is consistent between 
plasma and the applications therefore Uri change the selected application 
taskbar button to a blue background. The problem is that the blue background 
couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
select an element in the sidebar the text color change from "black" to white 
which isn't possible in the system tray and than the contrast isn't that good 
in the panel for selected application (gray text on blue background). In 
addition the blue is very visible. see screenshot before.

Solution

I like that we use the same color language but when you look at the dolphin 
toolbar on top selected elements (e.g. preview in the screenshot) are gray so I 
change the blue color for the selected application to gray and change minimized 
app to no border.

what do you think?


Diffs
-

  src/desktoptheme/breeze/widgets/tasks.svgz 086558b 

Diff: https://git.reviewboard.kde.org/r/126373/diff/


Testing
---

I will test the new taskbar and hope someone else can test it too before we may 
ship it.


File Attachments (updated)


taskbar style old
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
taskbar style new
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
taskbar old and new
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
tasks new blue boarder in difference to the original one
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
new draft, origin, old draft
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89621
---


I just want to say thanks for keeping at this - I feel kinda bad about the 
sheer number of changes I'm throwing at you! If you want to make me do some of 
the work, you can create a feature branch and point me at it, but I'm hoping 
this review is setting you up for an easy ride if you want to contribute 
something else to e-c-m in the future.

- Alex Merry


On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 16, 2015, 12:25 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
>   kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
>   tests/CMakeLists.txt 1a66f56 
>   tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
>   
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
>  PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: notification plasmoid for desktop

[Kai Uwe Broulik]

  Hi,> what's the reason that it will be removed after 10 minutes? wouldn't it be nice to have also an history? grouped by date and filters for type.After 10 minutes a notification is most likely outdated. Otherwise a status notifier (system tray icon) should be provided instead.  Also, they stay there indefinitely if the computer is idle so you don't miss any.> I like it
‎Me too.Cheers, Kai Uwe
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Updated 5.5 packages and ISO

[Jonathan Riddell]

I've produced an updated ISO with Plasma 5.5 in it

http://files.kde.org/snapshots/unstable-amd64-latest.iso

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: notification plasmoid for desktop

[kainz.a]

>
>
> > what's the reason that it will be removed after 10 minutes? wouldn't it
> be nice to have also an history? grouped by date and filters for type.
>
> After 10 minutes a notification is most likely outdated. Otherwise a
> status notifier (system tray icon) should be provided instead.  Also, they
> stay there indefinitely if the computer is idle so you don't miss any.
>

I know what you mean, but an history button or an setting in the plasmoid
settings would be nice. in addition plasma and kde love settings but if you
look at the plasmoids it's sometime like "why is there an config button,
when you only can add an shortcut".


>
> > I like it
> ‎
> Me too.
>

that's the reason I have a look at all plasmoids and there sizing. In
addition good scaling isn't that easy and if you have an usercase (sidebar)
it's easier.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89619
---



tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
(lines 1 - 18)


BSD code only in extra-cmake-modules, please. Frankly, your app template 
can be complete rubbish, as long as it's packaged up properly.


- Alex Merry


On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 16, 2015, 12:25 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
>   kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
>   tests/CMakeLists.txt 1a66f56 
>   tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
>   
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
>  PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #80 from mif...@gmail.com ---
(In reply to Martin Klapetek from comment #79)
> Can you check if you have 2 kded5 processes running?
Not sure, this issue is very random, but i'll try.
Also I notice that after do `sudo gdb --pid` cpu usage slightly decrease and
after quit this back to 25%.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Alex Merry]

On Dec. 16, 2015, 7:14 p.m., Marco Martin wrote:
> > You might want to generate the documentation and look at it (you need the 
> > Sphinx documentation tool installed, then you just build 
> > extra-cmake-modules, and look in docs/html in the build directory).

In particular, you'll need to add a link file in docs/kde-module.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89618
---


On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 16, 2015, 12:25 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
>   kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
>   tests/CMakeLists.txt 1a66f56 
>   tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
>   
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
>  PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/
---

(Updated Dec. 16, 2015, 7:19 p.m.)


Review request for Plasma, Marco Martin and Uri Herrera.


Changes
---

please test the tasks.svgz file the only difference it the blue active task has 
a boarder as all other tasks have.


Repository: plasma-framework


Description
---

Problem
===
with the new taskbar we look that the look and feel is consistent between 
plasma and the applications therefore Uri change the selected application 
taskbar button to a blue background. The problem is that the blue background 
couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
select an element in the sidebar the text color change from "black" to white 
which isn't possible in the system tray and than the contrast isn't that good 
in the panel for selected application (gray text on blue background). In 
addition the blue is very visible. see screenshot before.

Solution

I like that we use the same color language but when you look at the dolphin 
toolbar on top selected elements (e.g. preview in the screenshot) are gray so I 
change the blue color for the selected application to gray and change minimized 
app to no border.

what do you think?


Diffs
-

  src/desktoptheme/breeze/widgets/tasks.svgz 086558b 

Diff: https://git.reviewboard.kde.org/r/126373/diff/


Testing
---

I will test the new taskbar and hope someone else can test it too before we may 
ship it.


File Attachments (updated)


taskbar style old
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
taskbar style new
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
taskbar old and new
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
tasks new blue boarder in difference to the original one
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126381: kwayland backend for libkscreen

[Daniel Vrátil]

> On Dec. 16, 2015, 10:08 a.m., Martin Gräßlin wrote:
> > backends/kwayland/waylandbackend.cpp, line 46
> > 
> >
> > where does it get deleted?
> 
> Sebastian Kügler wrote:
> Nowhere. :/
> 
> This is in line with other backends, though. If it's to be fixed (Dan?), 
> this would need to be done globally. For this backend, it's one of the 
> idiosyncracies of libkscreen we have to live with.

WaylandBackend inherits KScreen::AbstractBackend which does have a virtual 
destructor that should get called automagically when we unload the backend - so 
you could just delete the WaylandConfig there and reset s_internalConfig to 
nullptr.


> On Dec. 16, 2015, 10:08 a.m., Martin Gräßlin wrote:
> > backends/kwayland/waylandoutput.cpp, lines 107-113
> > 
> >
> > shouldn't it cache the OutputPtr in case it gets invoked again?
> 
> Sebastian Kügler wrote:
> No, that's a kscreen idiosyncracy again.
> 
> Can't say I'm overly happy with this design, but it's in line with what 
> the library expects, and with other backends.

You could keep a copy of KScreen::OutputPtr in each WaylandOutput and keep it 
updated, then a call to toKScreenOutput() would just return the copy.

The reason I did not do it in the XRandR backend originally was mostly my 
laziness to deal with keeping modes and clones in sync constantly.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89584
---


On Dec. 16, 2015, 3:05 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dec. 16, 2015, 3:05 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.txt PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   

Re: Review Request 126381: kwayland backend for libkscreen

[Daniel Vrátil]

> On Dec. 16, 2015, 10:08 a.m., Martin Gräßlin wrote:
> > backends/kwayland/waylandbackend.cpp, line 46
> > 
> >
> > where does it get deleted?
> 
> Sebastian Kügler wrote:
> Nowhere. :/
> 
> This is in line with other backends, though. If it's to be fixed (Dan?), 
> this would need to be done globally. For this backend, it's one of the 
> idiosyncracies of libkscreen we have to live with.
> 
> Daniel Vrátil wrote:
> WaylandBackend inherits KScreen::AbstractBackend which does have a 
> virtual destructor that should get called automagically when we unload the 
> backend - so you could just delete the WaylandConfig there and reset 
> s_internalConfig to nullptr.

Looking even more into it, there's really no need for WaylandConfig to be 
static, could be just member of the WaylandBackend (as long as you have a way 
to retrieve the pointer from wherever in code you need to).

There is no need for your backend to use the same lousy architecture we have in 
XRandR and which has been around since day one (XRandR backend was originally 
very C-ish, with everything being static and global).


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89584
---


On Dec. 16, 2015, 3:05 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dec. 16, 2015, 3:05 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.txt PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   backends/kwayland/waylandscreen.h PRE-CREATION 
>   backends/kwayland/waylandscreen.cpp PRE-CREATION 
>   src/backendmanager.cpp 89ae31e 
>   src/config.cpp e8b8a8f 
>   src/screen.h 4cd1e82 
>   tests/CMakeLists.txt d5e41d5 
>   tests/kwayland/CMakeLists.txt PRE-CREATION 
>   tests/kwayland/main.cpp PRE-CREATION 
>  

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89618
---



kde-modules/KDEPackageAppTemplates.cmake (line 10)


Frameworks has a capital F.



kde-modules/KDEPackageAppTemplates.cmake (line 14)


Signature is still wrong.



kde-modules/KDEPackageAppTemplates.cmake (lines 16 - 37)


None of this should be indented.

Beware of how Sphinx formats your list of placeholders, though. Consider 
doing the list in the same way as KDEInstallDirs.cmake lists its variables.



kde-modules/KDEPackageAppTemplates.cmake (line 20)


"as if it was", instead of "as it was"?



kde-modules/KDEPackageAppTemplates.cmake (line 22)


missing closing parenthesis )?


You might want to generate the documentation and look at it (you need the 
Sphinx documentation tool installed, then you just build extra-cmake-modules, 
and look in docs/html in the build directory).

- Alex Merry


On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 16, 2015, 12:25 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
>   kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
>   tests/CMakeLists.txt 1a66f56 
>   tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
>   
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
>  PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #81 from Martin Klapetek  ---
> Also I notice that after do `sudo gdb --pid` cpu usage slightly decrease and 
> after quit this back to 25%.

Yes, attaching gdb to it makes the process actually stop,
quitting gdb makes the process continue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Alex Merry]

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote:
> > Ooh, also, please write a unit test. I can help with that if you find the 
> > idea of writing a CMake-based unit test daunting, but you can look in the 
> > tests directory for inspiration.
> 
> Marco Martin wrote:
> I'm not sure what the test should do...
> perhaps having in the repo a tarball and a source template, make it 
> generate and then compare the files?
> 
> Alex Merry wrote:
> Yes, that would work. Or you could have a source template, and check the 
> installed file can be extracted and check the extracted contents. Don't 
> forget to make sure that files you think should be excluded are in fact 
> omitted.
> 
> Marco Martin wrote:
> if i try to use kde_add_app_templates from a run_test.cmake i get the 
> message KDETemplateGenerator.cmake:97 (add_custom_target):
>   Command add_custom_target() is not scriptable
>   any idea what it could be?

Ah, you'll need to do a project-style test. See ECMPoQmToolsTest, or 
ECMInstallIconsTest. The idea is you create a CMakeLists.txt file as though it 
were a project using this module, and make, say, a check_tree.cmake script to 
check that the right things were installed in the right places. Lines 124-131 
of tests/CMakeLists.txt are what run ECMInstallIconsTest.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89391
---


On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 16, 2015, 12:25 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
>   kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
>   tests/CMakeLists.txt 1a66f56 
>   tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
>   
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
>  PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

[René Fürst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125266/
---

(Updated Dez. 16, 2015, 10:21 nachm.)


Review request for Network Management and Plasma.


Changes
---

Added a patch without indent changes


Repository: plasma-nm


Description
---

Authentication with certificates / Make MRU/MTU editable / Dialog fix


Diffs
-

  vpn/l2tp/l2tp.ui bf35d02 
  vpn/l2tp/l2t.ui 3c70165 
  vpn/l2tp/l2twidget.cpp ffe2c2b 
  vpn/l2tp/l2tpwidget.h a161b53 
  vpn/l2tp/l2tpwidget.cpp a4ff42f 
  vpn/l2tp/nm-l2tp-service.h ac2ecc9 

Diff: https://git.reviewboard.kde.org/r/125266/diff/


Testing
---

This patch contains 3 things:
1) Add authentication with certificates
2) Make MRU/MTU editable
3) Fix an issue where PPP/Advanced settings were lost when the dialogs were not 
opened

The base for 1) and 2) was added to NetworkManager-l2tp here 
https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c


File Attachments (updated)


Patch without indent changes
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/e492aabf-c098-4ea7-bff0-30a13cc3fdda__cert_mru_mtu_dialog_fix4_noindent.diff


Thanks,

René Fürst

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

plasmoid visions

[kainz.a]

Hi all,

I'd like to review the plasmoids and want to know where we can discuss it,
if you want. plasma mailing list, irc, telegram, ...?

1. Sidebar
-
Functionality is in plasma so we should use it, isn't it.

2. Plasmoid size

if you click in the system tray at an plasmoid the size is always the same.
why is the minimum plasmoid size at an plasmoid on the desktop always
different AND in some case larger than in the standard system tray popup
size

3. plasmoid form factor in panel
---
when you move a plasmoid in a panel the user can't change the size. e.g. if
you have an large sidebar [1] it would be nice to resize the clipboard link
list so that you see only 3 elements or resize the icon only tasklist from
vertical to horizontal which is possible at the desktop.

[1] https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/Sidebar.png

cheers
Andreas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126381: kwayland backend for libkscreen

[Sebastian Kügler]

> On Dec. 16, 2015, 9:08 a.m., Martin Gräßlin wrote:
> > autotests/testkwaylandbackend.cpp, line 154
> > 
> >
> > nothing is done with ids

It's used to verify that the id of the output is unique.


> On Dec. 16, 2015, 9:08 a.m., Martin Gräßlin wrote:
> > autotests/testkwaylandbackend.cpp, line 179
> > 
> >
> > nothing is done with ids

It is actually used to check uniqueness of the id.


> On Dec. 16, 2015, 9:08 a.m., Martin Gräßlin wrote:
> > backends/kwayland/waylandconfig.cpp, line 153
> > 
> >
> > don't call into low level wayland code. There is no need for this. What 
> > do you want to achieve? I can provide you the correct KWayland method to 
> > call.
> 
> Sebastian Kügler wrote:
> It hung and never arrived on the other side. I'll check again if it's 
> needed, and if so, will get back to you.

Seems to be not needed indeed, good catch. This means a few other build system 
things may be cleaned up.


> On Dec. 16, 2015, 9:08 a.m., Martin Gräßlin wrote:
> > backends/kwayland/waylandoutput.h, line 83
> > 
> >
> > a mutuable shared pointer? Are you sure about that?

m_edid is actually a left-over from a previous iteration. I've removed it 
altogether.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89584
---


On Dec. 16, 2015, 2:05 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dec. 16, 2015, 2:05 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.txt PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

[Lamarque Souza]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125266/#review89632
---

Ship it!


Ship It!

- Lamarque Souza


On Dec. 16, 2015, 10:21 p.m., René Fürst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125266/
> ---
> 
> (Updated Dec. 16, 2015, 10:21 p.m.)
> 
> 
> Review request for Network Management and Plasma.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Authentication with certificates / Make MRU/MTU editable / Dialog fix
> 
> 
> Diffs
> -
> 
>   vpn/l2tp/l2tp.ui bf35d02 
>   vpn/l2tp/l2t.ui 3c70165 
>   vpn/l2tp/l2twidget.cpp ffe2c2b 
>   vpn/l2tp/l2tpwidget.h a161b53 
>   vpn/l2tp/l2tpwidget.cpp a4ff42f 
>   vpn/l2tp/nm-l2tp-service.h ac2ecc9 
> 
> Diff: https://git.reviewboard.kde.org/r/125266/diff/
> 
> 
> Testing
> ---
> 
> This patch contains 3 things:
> 1) Add authentication with certificates
> 2) Make MRU/MTU editable
> 3) Fix an issue where PPP/Advanced settings were lost when the dialogs were 
> not opened
> 
> The base for 1) and 2) was added to NetworkManager-l2tp here 
> https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c
> 
> 
> File Attachments
> 
> 
> Patch without indent changes
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/e492aabf-c098-4ea7-bff0-30a13cc3fdda__cert_mru_mtu_dialog_fix4_noindent.diff
> 
> 
> Thanks,
> 
> René Fürst
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

[Lamarque Souza]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125266/#review89631
---



vpn/l2tp/l2tpwidget.cpp (line 177)


Code style: the identation is wrong "case" should  align vertically with 
"switch". Other than that the patch looks good to me.


- Lamarque Souza


On Dec. 16, 2015, 10:21 p.m., René Fürst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125266/
> ---
> 
> (Updated Dec. 16, 2015, 10:21 p.m.)
> 
> 
> Review request for Network Management and Plasma.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Authentication with certificates / Make MRU/MTU editable / Dialog fix
> 
> 
> Diffs
> -
> 
>   vpn/l2tp/l2tp.ui bf35d02 
>   vpn/l2tp/l2t.ui 3c70165 
>   vpn/l2tp/l2twidget.cpp ffe2c2b 
>   vpn/l2tp/l2tpwidget.h a161b53 
>   vpn/l2tp/l2tpwidget.cpp a4ff42f 
>   vpn/l2tp/nm-l2tp-service.h ac2ecc9 
> 
> Diff: https://git.reviewboard.kde.org/r/125266/diff/
> 
> 
> Testing
> ---
> 
> This patch contains 3 things:
> 1) Add authentication with certificates
> 2) Make MRU/MTU editable
> 3) Fix an issue where PPP/Advanced settings were lost when the dialogs were 
> not opened
> 
> The base for 1) and 2) was added to NetworkManager-l2tp here 
> https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c
> 
> 
> File Attachments
> 
> 
> Patch without indent changes
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/e492aabf-c098-4ea7-bff0-30a13cc3fdda__cert_mru_mtu_dialog_fix4_noindent.diff
> 
> 
> Thanks,
> 
> René Fürst
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126381: kwayland backend for libkscreen

[Sebastian Kügler]

> On Dec. 16, 2015, 7:29 p.m., Daniel Vrátil wrote:
> > autotests/testkwaylandbackend.cpp, line 240
> > 
> >
> > Use QTRY_COMPARE(configSpy.count(), 1). Hardcoding random timeouts 
> > tends to randomly fail on our overcrowded CI.

QTRY_COMPARE just hangs there until it times out. QVERIFY(configSpy.wait()) 
works. I've removed the custom timeout. Same for other places.

I'm still working on the other issues.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89616
---


On Dec. 16, 2015, 2:05 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dec. 16, 2015, 2:05 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.txt PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   backends/kwayland/waylandscreen.h PRE-CREATION 
>   backends/kwayland/waylandscreen.cpp PRE-CREATION 
>   src/backendmanager.cpp 89ae31e 
>   src/config.cpp e8b8a8f 
>   src/screen.h 4cd1e82 
>   tests/CMakeLists.txt d5e41d5 
>   tests/kwayland/CMakeLists.txt PRE-CREATION 
>   tests/kwayland/main.cpp PRE-CREATION 
>   tests/kwayland/waylandconfigreader.h PRE-CREATION 
>   tests/kwayland/waylandconfigreader.cpp PRE-CREATION 
>   tests/kwayland/waylandtestserver.h PRE-CREATION 
>   tests/kwayland/waylandtestserver.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
> 
> 
> Testing
> ---
> 
> The patch contains a test server, which is used for the autotests.
> 
> The test server uses KWayland's server classes and is set up from the json 
> config data we use for the other tests. That means that the backends runs 
> against a real server to test everything.
> 
> I also tested the kscreen UI, which also works as expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Marco Martin]

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote:
> > Ooh, also, please write a unit test. I can help with that if you find the 
> > idea of writing a CMake-based unit test daunting, but you can look in the 
> > tests directory for inspiration.
> 
> Marco Martin wrote:
> I'm not sure what the test should do...
> perhaps having in the repo a tarball and a source template, make it 
> generate and then compare the files?
> 
> Alex Merry wrote:
> Yes, that would work. Or you could have a source template, and check the 
> installed file can be extracted and check the extracted contents. Don't 
> forget to make sure that files you think should be excluded are in fact 
> omitted.

if i try to use kde_add_app_templates from a run_test.cmake i get the message 
KDETemplateGenerator.cmake:97 (add_custom_target):
  Command add_custom_target() is not scriptable
  any idea what it could be?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89391
---


On Dec. 15, 2015, 10:38 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 15, 2015, 10:38 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
>   kde-modules/KDETemplateGenerator.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126301: Add protocol for server side decoration

[Martin Gräßlin]

> On Dec. 11, 2015, 2:54 p.m., Sebastian Kügler wrote:
> > src/client/server_decoration.h, line 179
> > 
> >
> > apidocs missing
> > 
> > It would be useful to explain the modes here, and possibly mention than 
> > None means that the server expects the client to do CSD.

none means that neither client nor server should do CSD.


> On Dec. 11, 2015, 2:54 p.m., Sebastian Kügler wrote:
> > src/client/server_decoration.h, line 187
> > 
> >
> > I still don't like this "Mode", but it's probably proximity-bias of the 
> > output sort. Decorations have nothing to do with mode settings. Using the 
> > same name makes grepping harder.
> > 
> > decorationMode or decoratorMode would IMO be better.

I disagree. It's namespaced, it's not Mode, it's ServerSideDecoration::Mode. 
Similar it's OutputDevice::Mode. If we change to DecorationMode it becomes 
ServerSideDecoration::DecorationMode. We lose the advantage of namespacing.


> On Dec. 11, 2015, 2:54 p.m., Sebastian Kügler wrote:
> > src/server/CMakeLists.txt, line 100
> > 
> >
> > I don't get the name here, maybe surface_decoration would be better? 
> > (It's not about the server, it's about decoration a surface.)
> > 
> > Naming of course bleeds all over the whole protocol, so consider this a 
> > generic comment. :)

I have to think about it.


> On Dec. 11, 2015, 2:54 p.m., Sebastian Kügler wrote:
> > src/server/display.cpp, line 330
> > 
> >
> > Also, I'm confused.
> > 
> > you connect to d, so d ends up being [this], which you then don't use, 
> > but you use d, and delete that?
> > 
> > Please revisit so some muggle like me understands this. :)

I don't connect to d, d is the context. As I just read a review request by you 
where you never specified the context: please read up in the documentation 
about the meaning of the context in lambda connects. This prevents against 
"surprises"

The actual mistake is the capture of this which is not needed. That's a 
consistent copy and paste error in Display


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126301/#review89348
---


On Dec. 10, 2015, 3:03 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126301/
> ---
> 
> (Updated Dec. 10, 2015, 3:03 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> [client] Add implementation for ServerSideDecoration
> 
> 
> [server] Add implementation for server side decoration protocol
> 
> 
> [autotest] Add tests for ServerSideDecoration protocol
> 
> 
> Diffs
> -
> 
>   autotests/client/test_wayland_registry.cpp 
> 772da821d634efa1c72d13a7c081994bd78ab7fd 
>   autotests/client/CMakeLists.txt 014b5e0798618394ecf11c8b8cfa796dcf9c37f3 
>   autotests/client/test_server_side_decoration.cpp PRE-CREATION 
>   src/client/CMakeLists.txt 1d2b5492954e07fc77b2209a123ef8e43e340e8a 
>   src/client/protocols/server-decoration.xml PRE-CREATION 
>   src/client/registry.h c079852a4d96471face2a06795a531abf2e4d8c0 
>   src/client/registry.cpp 71640e184da4699bdc27a993b710b1f761c919d2 
>   src/client/server_decoration.h PRE-CREATION 
>   src/client/server_decoration.cpp PRE-CREATION 
>   src/server/CMakeLists.txt cd5c7bb1a93a470fd58cb9c6d86068da961addeb 
>   src/server/display.h 154e0f0b4c00375ca7d7f0a980392877fe743f50 
>   src/server/display.cpp 81ea7316e3b77f6db95748339d3dfaa30d33 
>   src/server/server_decoration_interface.h PRE-CREATION 
>   src/server/server_decoration_interface.cpp PRE-CREATION 
>   src/tools/mapping.txt 9dc8204d65092aa86f6ced8ae5a131a2f89018d0 
> 
> Diff: https://git.reviewboard.kde.org/r/126301/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/
---

(Updated Dec. 16, 2015, 12:25 p.m.)


Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
and Simon Wächter.


Changes
---

rename done, stuck on the failing test


Repository: extra-cmake-modules


Description
---

templates are very useful as teaching tool in order to make
a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks


Diffs (updated)
-

  kde-modules/KDEInstallDirs.cmake b7cd34d 
  kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
  tests/CMakeLists.txt 1a66f56 
  tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
  
tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
 PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126185/diff/


Testing
---

done some templates installed by plasma-framework


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.5.1

[Jonathan Riddell]

Well spotted, the plasma-workspace tar was updated shortly before
release but for some reason that didn't make it through to the server
although it did for the tar.  I've now put the correct tar up as
5.5.1.1 and linked to it from 5.5.1.  sha256 is
7e91dac2301975ae8ee788deddc9e4ac8c5f699865e85d09cefe0f9f29ac3705

Jonathan

On Tue, Dec 15, 2015 at 12:28:00PM -0800, Weng Xuetian wrote:
> I saw the 5.5.1 tag is on
> https://quickgit.kde.org/?p=plasma-workspace.git=commitdiff=a0578e6e5dbd429366e6a9837af543a4c85b5a75=1390b40b399770e7a67da714c74d172eee1bb433
> , but the tarball doesn't have this commit, can you confirm?
> 
> On Tue, Dec 15, 2015 at 5:09 AM, Jonathan Riddell  wrote:
> > Plasma 5.5.1 is now released 
> > https://www.kde.org/announcements/plasma-5.5.1.php
> > ___
> > release-team mailing list
> > release-t...@kde.org
> > https://mail.kde.org/mailman/listinfo/release-team
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126301: Add protocol for server side decoration

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126301/
---

(Updated Dec. 16, 2015, 12:07 p.m.)


Review request for Plasma and Sebastian Kügler.


Changes
---

Incorporated suggested changes except the base name - that needs more thinking


Repository: kwayland


Description
---

[client] Add implementation for ServerSideDecoration


[server] Add implementation for server side decoration protocol


[autotest] Add tests for ServerSideDecoration protocol


Diffs (updated)
-

  autotests/client/CMakeLists.txt 014b5e0798618394ecf11c8b8cfa796dcf9c37f3 
  autotests/client/test_server_side_decoration.cpp PRE-CREATION 
  autotests/client/test_wayland_registry.cpp 
772da821d634efa1c72d13a7c081994bd78ab7fd 
  src/client/CMakeLists.txt 1d2b5492954e07fc77b2209a123ef8e43e340e8a 
  src/client/protocols/server-decoration.xml PRE-CREATION 
  src/client/registry.h c079852a4d96471face2a06795a531abf2e4d8c0 
  src/client/registry.cpp 71640e184da4699bdc27a993b710b1f761c919d2 
  src/client/server_decoration.h PRE-CREATION 
  src/client/server_decoration.cpp PRE-CREATION 
  src/server/CMakeLists.txt cd5c7bb1a93a470fd58cb9c6d86068da961addeb 
  src/server/display.h 23b1972ba1081922a0b89a3b04b87f23f67d5086 
  src/server/display.cpp b236900ff9bab0f153269fd4d328ade7d44505de 
  src/server/server_decoration_interface.h PRE-CREATION 
  src/server/server_decoration_interface.cpp PRE-CREATION 
  src/tools/mapping.txt 9dc8204d65092aa86f6ced8ae5a131a2f89018d0 

Diff: https://git.reviewboard.kde.org/r/126301/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

[Lamarque Souza]

> On Dec. 13, 2015, 10:45 p.m., René Fürst wrote:
> > vpn/l2tp/l2tpwidget.cpp, line 183
> > 
> >
> > That's actually not my code. I just indented it because it went into an 
> > if. Fixed it anyway.
> 
> Lamarque Souza wrote:
> Do not do code style only changes in code that do not belong to this 
> patch. That makes reviewing more difficult for all of us that are reviewing 
> this patch.
> 
> René Fürst wrote:
> Should I then submit a patch without indention on old code that went into 
> an if and one with it? Because in the end I think a patch with correct 
> indention is required, right?

Yes, submit a second patch with the code style changes. Pure code style changes 
makes reviewing more difficult and should be avoided.


- Lamarque


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125266/#review89437
---


On Dec. 13, 2015, 10:48 p.m., René Fürst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125266/
> ---
> 
> (Updated Dec. 13, 2015, 10:48 p.m.)
> 
> 
> Review request for Network Management and Plasma.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Authentication with certificates / Make MRU/MTU editable / Dialog fix
> 
> 
> Diffs
> -
> 
>   vpn/l2tp/l2tp.ui bf35d02 
>   vpn/l2tp/l2t.ui 3c70165 
>   vpn/l2tp/l2twidget.cpp ffe2c2b 
>   vpn/l2tp/l2tpwidget.h a161b53 
>   vpn/l2tp/l2tpwidget.cpp a4ff42f 
>   vpn/l2tp/nm-l2tp-service.h ac2ecc9 
> 
> Diff: https://git.reviewboard.kde.org/r/125266/diff/
> 
> 
> Testing
> ---
> 
> This patch contains 3 things:
> 1) Add authentication with certificates
> 2) Make MRU/MTU editable
> 3) Fix an issue where PPP/Advanced settings were lost when the dialogs were 
> not opened
> 
> The base for 1) and 2) was added to NetworkManager-l2tp here 
> https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c
> 
> 
> Thanks,
> 
> René Fürst
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126380: Fix OutputDevice::edid()

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126380/
---

(Updated Dec. 16, 2015, 12:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
---

Submitted with commit 8d0debab24e4d875619a7c143de1c415b9f1e0a3 by Sebastian 
Kügler to branch Plasma/5.5.


Repository: kwayland


Description
---

This patch transports the EDID data base64-encoded over the wire.

Apparently, we can't just send random QByteArrays as "strings" over, it has to 
be encoded and decoded. So...

- base64-encode the data before sending to the client
- base64-decode it on the client side
- document the above, fix documentation woes in the xml definition
- change test accordingly

The test data used was actually invalid, it's a base64 string of the actual 
data, so fix the tests (which actually breaks it), and encode on the 
server-side and decode on the client side.

I'm not sure if base64 is the best way to go here, suggestions welcome.


Diffs
-

  autotests/client/test_wayland_outputdevice.cpp beefc45 
  src/client/outputdevice.cpp bfde34f 
  src/client/protocols/outputdevice.xml e790fdd 
  src/server/outputdevice_interface.cpp adf65a1 

Diff: https://git.reviewboard.kde.org/r/126380/diff/


Testing
---

broke test by decoding the string from base64, fixed code, tests pass again.

Also, it works in the libkscreen kwayland backend now.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Evolving Appdash

[Martin Klapetek]

On Wed, Dec 16, 2015 at 3:12 AM, Martin Graesslin 
wrote:

> On Tuesday, December 15, 2015 6:48:32 PM CET Eike Hein wrote:
> > The VDG has offered to join in with some cool mockups to maxi-
> > mize potential.
>
> it would be cool if the VDG could also look into a non-blur variant for the
> appdash. I'm still very concerned about the full screen blur as the KWin
> effect is not designed for this [1] and with increasing screen sizes the
> problem that KWin is not designed for this becomes more and more a problem.
>
> Also the appdash is almost unusable without a blur effect (which for
> example
> happens with GLES, XRender and QPainter backends).
>

How about generating blurred wallpaper at some point, storing it
and then using that as background? Blurrin a 20MPx (5472x3648)
image here with gaussian blur in gimp takes about 5 seconds,
1920x1280 then takes less than 3 seconds. I'm not sure how well
is gimp's blurring optimized and/or gpu powered, but 3 seconds
really doesn't sound bad for one-time generation in the background.

Of course there are different activities and different wallpapers
but still could be solved.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89605
---


I really think the motivation behind this change is ill-formed.

All selections we have in Plasma and in normal apps are blue (by
default), you even say that in the first paragraph. Making it a
grey one because that's how pressed button looks like is imho not
correct. Plus it changes the semantic meaning of the color we have
*just* introduced to the exact opposite meaning, this is just a no-go.

The actual problem that you're describing:

> the problem is that the blue background couldn't be the same blue
> than e.g. in the dolphin sidebar cause when you select an element
> in the sidebar the text color change from "black" to white

Could probably be solved by combination of the task manager using
colors from theme color palette (if it doesn't already) and adjusting
the color palette to use white text in selected items.

- Martin Klapetek


On Dec. 16, 2015, 9:16 a.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 9:16 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: notification plasmoid for desktop

[Martin Klapetek]

On Wed, Dec 16, 2015 at 4:43 AM, Marco Martin  wrote:

>
> to have a quick glance at them when the windows don't cover everything,
> just
> the same use case of any other desktop plasmoid.
> in general, all plasmoid should disaplay correctly on the desktop and when
> they don't it tends to be a bug unless there are specific reasons for
> that. I
> think the problem at them moment is that it doesn't switch from the compact
> representation, right?
>

It does, maybe the sizes are set too big for a default but it does
switch. The actual unusefulness actually comes from the fact
that the applet does not show anything at all in 90% of the cases
as it shows only persistent notifications _and_ they go away
after 10 minutes from it anyway.

So with the current form, it sure is possible, I just don't see much
value in it as it would be just a grey blob sitting on your desktop.

As for the sidebar usecase Andreas mentioned, well, I did propose
that two months ago, nobody liked it.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #79 from Martin Klapetek  ---
Can you check if you have 2 kded5 processes running?
Your backtrace again shows no activity at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Evolving Appdash

[Aleix Pol]

On Wed, Dec 16, 2015 at 5:00 PM, Martin Klapetek
 wrote:
> On Wed, Dec 16, 2015 at 3:12 AM, Martin Graesslin 
> wrote:
>>
>> On Tuesday, December 15, 2015 6:48:32 PM CET Eike Hein wrote:
>> > The VDG has offered to join in with some cool mockups to maxi-
>> > mize potential.
>>
>> it would be cool if the VDG could also look into a non-blur variant for
>> the
>> appdash. I'm still very concerned about the full screen blur as the KWin
>> effect is not designed for this [1] and with increasing screen sizes the
>> problem that KWin is not designed for this becomes more and more a
>> problem.
>>
>> Also the appdash is almost unusable without a blur effect (which for
>> example
>> happens with GLES, XRender and QPainter backends).
>
>
> How about generating blurred wallpaper at some point, storing it
> and then using that as background? Blurrin a 20MPx (5472x3648)
> image here with gaussian blur in gimp takes about 5 seconds,
> 1920x1280 then takes less than 3 seconds. I'm not sure how well
> is gimp's blurring optimized and/or gpu powered, but 3 seconds
> really doesn't sound bad for one-time generation in the background.
>
> Of course there are different activities and different wallpapers
> but still could be solved.

Well you'd still need to blur the windows under it, no?

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Evolving Appdash

[Eike Hein]

Some relevant IRC log:

[15:37]  mgraesslin: i wonder if we can get a kwin effect that
only blurs in the desktop layer and cuts out the windows, as a fallback
or even default for dashboard
[15:37]  mgraesslin: or we can resurrect the kde3 approach to
translucency and have plasma export the wallpaper and just blur that in
[15:38]  Sho_: then I need to ask why kwin effect at all,
Plasma has access to the wallpaper
[15:38]  in theory this doesn't solve much because we support
animated wallpapers, but in the common case ...
[15:38]  mgraesslin: yeah
[15:38]  Sho_: you could just use the "fake blurred"
wallpaper from lockscreen
[15:38]  hmm, don't know whatthis would save..
[15:39]  would just look rather broken.. a solid color would
already be better
[15:39]  notmart: mgraesslin is concerned about performance of the
blur effect on bad drivers/gpus when there are changing windows below
the dashboard
[15:39]  or no blur at all just 90-95% opacity
[15:39]  yeah, i know
[15:39]  i'm not sure it would look broken, because
[15:39]  - there's actually a user wishlist item for this
[15:39]  Sho_: the problem is not the performance, the
problem is that the effect is not meant for that
[15:39]  well, the kde3 effect sure looked very broken ;)
[15:39]  - windows added the same option to metro in 8.1 on user
request (over solid colors previously)
[15:40]  Sho_: and blur just messes up the rendering, we
need to render to FBO, read back, apply shader on it
[15:40]  Sho_: also means no chance to move it to DRM layers
[15:41]  mgraesslin: log sounds sane?
[15:41]  bshah: just pushed a new variant
http://commits.kde.org/scratch/graesslin/plasma-integration/abb1492527f1b8d77d2b23faba4eff2af64a3543
[15:41]  bshah: now with --prune-empty
[15:41] <-- _rd_ (~r...@p5b2c73db.dip0.t-ipconnect.de) has left this
server (Ping timeout: 240 seconds).
[15:42]  mgraesslin: dunno but this doesn't sound more cleaner
[15:42]  bshah: it is, consider
https://quickgit.kde.org/?p=scratch%2Fgraesslin%2Fplasma-integration.git=commitdiff=d2eecfddce21356fb2d5ec7afa1b5ab8dd6bdc89
[15:42]  I would first put this platform theme in seperate folder
in frameworkintegration
[15:43]  bshah: it already is
[15:43]  bshah: I just renamed it
[15:44]  well, there must be a way to do blur fast enough, not
supporting a feature that is universal everywhere else doesn't sound
acceptable to me, even if is for speed reasons
[15:45] <-- toscalix (~agustinbe@149.100.1.63) has left this server
(Quit: Konversation terminated!).
[15:45]  notmart: sure it can be done fast, but not with the
shader we have
[15:45]  I can make it 4 times faster in a single word.
[15:45]  notmart: our logout effect has a fast blur
[15:45] --> toscalix (~agustinbe@149.100.1.63) has joined this channel.
[15:46]  downsample - you're blurring anyway, you won't notice
[15:46]  mgraesslin: soo, can we change it to use that one?
[15:46]  d_ed: yeah, that's what logout does
[15:47]  or are there reasons why dialog has to use that one?
[15:47]  notmart: well it needs a new effect, that's the
whole point. The generic blur doesn't work for that
[15:47]  couldn't the dashboard use the exact same one as the
logout effect?
[15:47]  notmart: no, because the logout works completely
different and does the vignetting and all that
[15:49]  but should be easy enough to modify it on a new
effect, no?
[15:49]  yes
[15:49] <-- crog_ (crog@nat/redhat/x-bkuevcoegobxtsld) has left this
server (Remote host closed the connection).
[15:49]  remove the vignetting, call it fullscreenblur, profit
[15:49]  notmart: but we need to be careful, appdash is not
fullscreen
[15:50]  it's only filling a screen
[15:50]  which means on a multi-screen system only one
screen is covered
[15:50]  which affects the rendering algorithm
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Evolving Appdash

[Martin Klapetek]

On Wed, Dec 16, 2015 at 11:30 AM, Aleix Pol  wrote:

>
> Well you'd still need to blur the windows under it, no?
>

No, it wouldn't be a live blur, it would simply be a background image
for performance reasons. Possibly the live blur could stay too as
an option for those with powerful machines.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126276: Disable ptrace on kdesu

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126276/#review89585
---



CMakeLists.txt (line 93)


description needs update for kdesu


- Harald Sitter


On Dec. 8, 2015, noon, Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126276/
> ---
> 
> (Updated Dec. 8, 2015, noon)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> This change protects against other user processes attaching to the kdesu
> process to gain the root password.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 31209e049b0f054f88a8471cdfa34eb99b2d38da 
>   config-kde-cli-tools.h.cmake f7eb81e3ab541faee2d8d6a15c870c68dd649dd2 
>   kdesu/kdesu.cpp b82bdd4d7bdb3f8cf47fa46ac7d878d01f4cc551 
> 
> Diff: https://git.reviewboard.kde.org/r/126276/diff/
> 
> 
> Testing
> ---
> 
> with the change: ptrace: Operation not permitted.
> without I was able to set breakpoint in the checkPassword method.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126374: [Activity Pager] Implement drag and drop for Task Manager entries

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126374/#review89586
---

Ship it!


Ship It!

- Marco Martin


On Dec. 15, 2015, 11:45 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126374/
> ---
> 
> (Updated Dec. 15, 2015, 11:45 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Just like you can drop windows from the task manager on the virtual desktop 
> pager, you shold be able to do the same with the activity pager.
> 
> If set, this naturally unsets the "On All Activities" setting but so does 
> dragging the miniature windows.
> 
> Also enabled preventStealing so Plasma doesn't create an icon widget in 
> response to our drop.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 5a654b3 
>   applets/activitypager/CMakeLists.txt 078f8ef 
>   applets/activitypager/package/contents/ui/main.qml 15a63a5 
>   applets/activitypager/plugin/activitypager.h 976e5f1 
>   applets/activitypager/plugin/activitypager.cpp 4d1a5a6 
> 
> Diff: https://git.reviewboard.kde.org/r/126374/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> Pretty straightforward but as it introduces a new dependency master only.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: activity manager plasmoid for desktop

[Marco Martin]

On Wednesday 16 December 2015, kainz.a wrote:
> Hi Ivan,
> 
> you make a great sidebar for the activities. you can come to this "sidebar"
> via the activity manger or an shortcut. the activity manager is only
> available for the panel would it be possible to use it for the desktop too.
> so if you move the activity switcher to the desktop you get the activity
> overview from the "sidebar".

at the moment the activity manager is not a plasmoid, but a part of the shell 
itself.
it would probably be possible to put it on the desktop, but that is probably 
the one exception, as as soon you select another activity, the desktop itself 
switches, hiding the activity manager itself (and yeah, a problem currently 
with activitybar and activity pager)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126276: Disable ptrace on kdesu

[Martin Gräßlin]

> On Dec. 16, 2015, 10:15 a.m., Harald Sitter wrote:
> > CMakeLists.txt, line 93
> > 
> >
> > description needs update for kdesu

good spot!


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126276/#review89585
---


On Dec. 8, 2015, 1 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126276/
> ---
> 
> (Updated Dec. 8, 2015, 1 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> This change protects against other user processes attaching to the kdesu
> process to gain the root password.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 31209e049b0f054f88a8471cdfa34eb99b2d38da 
>   config-kde-cli-tools.h.cmake f7eb81e3ab541faee2d8d6a15c870c68dd649dd2 
>   kdesu/kdesu.cpp b82bdd4d7bdb3f8cf47fa46ac7d878d01f4cc551 
> 
> Diff: https://git.reviewboard.kde.org/r/126276/diff/
> 
> 
> Testing
> ---
> 
> with the change: ptrace: Operation not permitted.
> without I was able to set breakpoint in the checkPassword method.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: notification plasmoid for desktop

[Marco Martin]

On Wednesday 16 December 2015, Martin Klapetek wrote:
> Hey,
> 
> On Tue, Dec 15, 2015 at 7:26 PM, kainz.a  wrote:
> > Hi Martin,
> > 
> > would it be possible or a good idea to have the notifications in the
> > panel and in addition on the desktop. for the desktop the notifications
> > from the pop-up window where shown so you can have a good overview of
> > the notification history on the desktop too.
> 
> Possible, sure. Good idea, not entirely sure.
> 
> What would be the use case? Why would the user want to
> have that on the desktop? What good would it bring?

to have a quick glance at them when the windows don't cover everything, just 
the same use case of any other desktop plasmoid.
in general, all plasmoid should disaplay correctly on the desktop and when 
they don't it tends to be a bug unless there are specific reasons for that. I 
think the problem at them moment is that it doesn't switch from the compact 
representation, right?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Evolving Appdash

[Martin Graesslin]

On Tuesday, December 15, 2015 8:27:28 PM CET Marco Martin wrote:
> > Appdash from edge swipe sounds really cool. Sounds like this would
> > be combined with the hot corner KCM?
> 
> it should probably be something kwin-driven, as an invisible window to take
> the input is probably too invasive (should ideally take touch events but be
> completely transparent to mouse)

That falls in the category of "global touch gestures" [1]. IMHO it should be 
Wayland only. On X11 it becomes ugly and a difficult question on who should be 
responsible for it and there I would say: hey that doesn't fall into KWin's 
responsibility.

We might also consider touchpad gestures.

Cheers
Martin

[1] https://forum.kde.org/viewtopic.php?f=285=125570


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: notification plasmoid for desktop

[kainz.a]

the user case would be to add the plasmoid on the desktop to have something
like an dash for the desktop or and that is what I was thinking an sidebar
panel (https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/Sidebar.png)

cheers

2015-12-16 1:46 GMT+01:00 Martin Klapetek :

> Hey,
>
> On Tue, Dec 15, 2015 at 7:26 PM, kainz.a  wrote:
>
>> Hi Martin,
>>
>> would it be possible or a good idea to have the notifications in the
>> panel and in addition on the desktop. for the desktop the notifications
>> from the pop-up window where shown so you can have a good overview of the
>> notification history on the desktop too.
>>
>
> Possible, sure. Good idea, not entirely sure.
>
> What would be the use case? Why would the user want to
> have that on the desktop? What good would it bring?
>
> Cheers
> --
> Martin Klapetek | KDE Developer
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: color picker plasmoid for the desktop

[kainz.a]

when you place the color picker to the desktop it look the same than in the
panel (two buttons) as you have more space on the desktop I would like to
see the color grid on the desktop and in addition the two buttons to select
a new color.

2015-12-16 9:04 GMT+01:00 Kai Uwe Broulik :

> Hi,
>
> I don't get your question. You can just place it on your desktop if you
> like.
>
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: color picker plasmoid for the desktop

[Kai Uwe Broulik]

  Hi,I don't get your question. You can just place it on your desktop if you like.   
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/
---

(Updated Dec. 16, 2015, 8:16 a.m.)


Review request for Plasma, Marco Martin and Uri Herrera.


Changes
---

I think the difference between the old minimized tasks and the new selected 
apps is quite good.


Repository: plasma-framework


Description
---

Problem
===
with the new taskbar we look that the look and feel is consistent between 
plasma and the applications therefore Uri change the selected application 
taskbar button to a blue background. The problem is that the blue background 
couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
select an element in the sidebar the text color change from "black" to white 
which isn't possible in the system tray and than the contrast isn't that good 
in the panel for selected application (gray text on blue background). In 
addition the blue is very visible. see screenshot before.

Solution

I like that we use the same color language but when you look at the dolphin 
toolbar on top selected elements (e.g. preview in the screenshot) are gray so I 
change the blue color for the selected application to gray and change minimized 
app to no border.

what do you think?


Diffs
-

  src/desktoptheme/breeze/widgets/tasks.svgz 086558b 

Diff: https://git.reviewboard.kde.org/r/126373/diff/


Testing
---

I will test the new taskbar and hope someone else can test it too before we may 
ship it.


File Attachments (updated)


taskbar style old
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
taskbar style new
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
taskbar old and new
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126381: kwayland backend for libkscreen

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89584
---


good work! I omitted the tests/kwayland from review as I need a break after 
reading through all the unknown code.


autotests/testkwaylandbackend.cpp (lines 84 - 86)


Just as an fyi: you could also make the WaylandTestServer operate on 
anonymous sockets (through the Display::createClient) and pass it in 
WAYLAND_SOCKET env variable.



autotests/testkwaylandbackend.cpp (line 154)


nothing is done with ids



autotests/testkwaylandbackend.cpp (line 168)


QVERIFY(mode->size().isValid()) or !.isEmpty()



autotests/testkwaylandbackend.cpp (line 179)


nothing is done with ids



autotests/testkwaylandbackend.cpp (line 271)


?



autotests/testkwaylandconfig.cpp (line 82)


as you define a logging category: qCDebug?



autotests/testkwaylandconfig.cpp (line 150)


add a `_data` variant and test all possible rotation values?



autotests/testkwaylandconfig.cpp (line 169)


why 2 sec? Is there a reason to go away from the default wait timeout?



autotests/testkwaylandconfig.cpp (line 197)


and why 200 here?



backends/CMakeLists.txt (lines 5 - 6)


there should be a variable for XCB_RANDR. Is KScreen using the find xcb 
from ECM?



backends/kwayland/README.txt (line 1)


change it to README.md and use markdown syntax to encapsulate the structure?



backends/kwayland/README.txt (line 4)


enlisting sounds wrong



backends/kwayland/waylandbackend.h (line 37)


should the plugin name be .wayland or .kwayland?



backends/kwayland/waylandbackend.h (lines 45 - 51)


virtual or override?



backends/kwayland/waylandbackend.h (line 55)


why a static variable? Wouldn't it be better to design the WaylandConfig as 
a singleton?



backends/kwayland/waylandbackend.cpp (line 35)


please use nullptr or Q_NULLPTR for pointers



backends/kwayland/waylandbackend.cpp (line 44)


same here



backends/kwayland/waylandbackend.cpp (line 46)


where does it get deleted?



backends/kwayland/waylandbackend.cpp (line 64)


QStringLiteral



backends/kwayland/waylandconfig.cpp (lines 57 - 64)


do you need that? there is also a connection failed signal in 
ConnectionThread



backends/kwayland/waylandconfig.cpp (lines 87 - 97)


Important: connect before calling initConnection. Currently this is racing. 
InitConnection triggers another thread and it might have finished connecting 
before the connect is executed.



backends/kwayland/waylandconfig.cpp (line 102)


nitpicky: indentation



backends/kwayland/waylandconfig.cpp (lines 114 - 115)


I think you need to delete the connection before deleting the thread. Also 
you need to use deleteLater as m_connection lives in another thread.



backends/kwayland/waylandconfig.cpp (lines 118 - 121)


do these manage a KWayland object? If yes: delete before destroying the 
connection.



backends/kwayland/waylandconfig.cpp (lines 134 - 137)


why DirectConnection? It looks like all being in the main thread anyway.



backends/kwayland/waylandconfig.cpp (line 139)


always add a context (e.g. this) to your lambda connects. Otherwise it 
might get invoked after the this object is deleted.

Why capture everything? You seem to only use this in the lambda



backends/kwayland/waylandconfig.cpp (line 144)

Re: Evolving Appdash

[Martin Graesslin]

On Tuesday, December 15, 2015 6:48:32 PM CET Eike Hein wrote:
> The VDG has offered to join in with some cool mockups to maxi-
> mize potential.

it would be cool if the VDG could also look into a non-blur variant for the 
appdash. I'm still very concerned about the full screen blur as the KWin 
effect is not designed for this [1] and with increasing screen sizes the 
problem that KWin is not designed for this becomes more and more a problem.

Also the appdash is almost unusable without a blur effect (which for example 
happens with GLES, XRender and QPainter backends).

Cheers
Martin

[1] Of course a different (!) blur effect could also be designed which doesn't 
expose the problems that much. An example for this is in the logout effect.

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89590
---


i think it makes it look too much disabled/minimized, it would need at least a 
colored border or part of border

- Marco Martin


On Dec. 16, 2015, 8:16 a.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 8:16 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel