Re: Review Request 126562: Deal properly with symlinks in path to packages

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126562/#review90290
---

Ship it!


Ship It!

- Marco Martin


On Dec. 29, 2015, 3:08 p.m., Kevin Ottens wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126562/
> ---
> 
> (Updated Dec. 29, 2015, 3:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We receive the URL with all symlinks resolved, but internally the
> pkgRoot kept unresolved symlinks preventing matches if there was a
> symlink somewhere to get to the package.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/packageurlinterceptor.cpp 5bd600c 
> 
> Diff: https://git.reviewboard.kde.org/r/126562/diff/
> 
> 
> Testing
> ---
> 
> All applets work for me without the older patches I had:
> https://git.reviewboard.kde.org/r/124204/
> https://git.reviewboard.kde.org/r/124205/
> https://git.reviewboard.kde.org/r/124206/
> https://git.reviewboard.kde.org/r/124207/
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review90298
---


I completely screwed up my Kate desktop files :( Would it help if I set 
NoDisplay or Hidden on the desktop file copy so it's there for the icon widget 
but not shown in the Open With dialogs and so on? Or, if I copied the desktop 
file elsewhere (eg. not into the local share applications)?

Also, I should probably delete the desktop file again if the widget is removed 
:)

- Kai Uwe Broulik


On Dez. 21, 2015, 11:31 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Dez. 21, 2015, 11:31 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 349177
> https://bugs.kde.org/show_bug.cgi?id=349177
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126348: Make it possible to provide the metadata in json

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126348/#review90303
---

Ship it!


Ship It!

- Marco Martin


On Dec. 15, 2015, 3:24 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126348/
> ---
> 
> (Updated Dec. 15, 2015, 3:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> Due to KCoreAddons transition from using desktop files to json files, 
> KPackage ended in a weird state where desktop files were allowed to use 
> desktop files but not json.
> 
> This patch makes sure that manifest.json files are also acceptable.
> 
> 
> Diffs
> -
> 
>   autotests/data/testjsonmetadatapackage/contents/ui/main.qml PRE-CREATION 
>   autotests/data/testjsonmetadatapackage/metadata.json PRE-CREATION 
>   autotests/querytest.cpp 0a2f11a 
>   src/kpackage/package.cpp 8416054 
>   src/kpackage/packageloader.cpp 1e1e382 
>   src/kpackage/private/packagejobthread.cpp 444dacc 
>   src/kpackage/private/packages.cpp 2f6bbcf 
> 
> Diff: https://git.reviewboard.kde.org/r/126348/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass (except for 
> https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/,
>  that is not passing in master).
> Adds a test plugin with a json file in it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126562: Deal properly with symlinks in path to packages

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126562/
---

(Updated Dec. 29, 2015, 4:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 46c555838c81c4d73865aeab413c81bd3c146b7a by Kevin Ottens 
to branch master.


Repository: plasma-framework


Description
---

We receive the URL with all symlinks resolved, but internally the
pkgRoot kept unresolved symlinks preventing matches if there was a
symlink somewhere to get to the package.


Diffs
-

  src/plasmaquick/packageurlinterceptor.cpp 5bd600c 

Diff: https://git.reviewboard.kde.org/r/126562/diff/


Testing
---

All applets work for me without the older patches I had:
https://git.reviewboard.kde.org/r/124204/
https://git.reviewboard.kde.org/r/124205/
https://git.reviewboard.kde.org/r/124206/
https://git.reviewboard.kde.org/r/124207/


Thanks,

Kevin Ottens

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126562: Deal properly with symlinks in path to packages

[Kevin Ottens]

> On Dec. 29, 2015, 3:22 p.m., David Edmundson wrote:
> > src/plasmaquick/packageurlinterceptor.cpp, line 93
> > 
> >
> > why the +1?
> > 
> > is it that canonicalFilePath not leave a trailing slash which we had 
> > before?

Yep, that's the reason, it strips the trailing slash.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126562/#review90291
---


On Dec. 29, 2015, 3:08 p.m., Kevin Ottens wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126562/
> ---
> 
> (Updated Dec. 29, 2015, 3:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We receive the URL with all symlinks resolved, but internally the
> pkgRoot kept unresolved symlinks preventing matches if there was a
> symlink somewhere to get to the package.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/packageurlinterceptor.cpp 5bd600c 
> 
> Diff: https://git.reviewboard.kde.org/r/126562/diff/
> 
> 
> Testing
> ---
> 
> All applets work for me without the older patches I had:
> https://git.reviewboard.kde.org/r/124204/
> https://git.reviewboard.kde.org/r/124205/
> https://git.reviewboard.kde.org/r/124206/
> https://git.reviewboard.kde.org/r/124207/
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126278: [Icon Widget] Add support for Jump Lists

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126278/#review90299
---


Ping

- Kai Uwe Broulik


On Dez. 8, 2015, 12:29 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126278/
> ---
> 
> (Updated Dez. 8, 2015, 12:29 nachm.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds support for Desktop Actions aka Jump Lists to the icon widget to 
> make them on par with launchers.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126278/diff/
> 
> 
> Testing
> ---
> 
> I get New Tab/New Incognito in Chromium context menu.
> 
> I didn't test what happens if I change the URL (whether it properly updates 
> them). Also the patch has some unrelated changes from Review 126149
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/08/e6f80a92-8120-414f-840a-120c791b3ebf__jumplisticon.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #82 from mif...@gmail.com ---
Created attachment 96361
  --> https://bugs.kde.org/attachment.cgi?id=96361=edit
bt

And another bt...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126562: Deal properly with symlinks in path to packages

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126562/#review90291
---

Ship it!


Thanks for looking into this.


src/plasmaquick/packageurlinterceptor.cpp (line 93)


why the +1?

is it that canonicalFilePath not leave a trailing slash which we had before?


- David Edmundson


On Dec. 29, 2015, 3:08 p.m., Kevin Ottens wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126562/
> ---
> 
> (Updated Dec. 29, 2015, 3:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We receive the URL with all symlinks resolved, but internally the
> pkgRoot kept unresolved symlinks preventing matches if there was a
> symlink somewhere to get to the package.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/packageurlinterceptor.cpp 5bd600c 
> 
> Diff: https://git.reviewboard.kde.org/r/126562/diff/
> 
> 
> Testing
> ---
> 
> All applets work for me without the older patches I had:
> https://git.reviewboard.kde.org/r/124204/
> https://git.reviewboard.kde.org/r/124205/
> https://git.reviewboard.kde.org/r/124206/
> https://git.reviewboard.kde.org/r/124207/
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126348: Make it possible to provide the metadata in json

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126348/#review90302
---

Ship it!


Ship It!

- Sebastian Kügler


On Dec. 15, 2015, 3:24 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126348/
> ---
> 
> (Updated Dec. 15, 2015, 3:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> Due to KCoreAddons transition from using desktop files to json files, 
> KPackage ended in a weird state where desktop files were allowed to use 
> desktop files but not json.
> 
> This patch makes sure that manifest.json files are also acceptable.
> 
> 
> Diffs
> -
> 
>   autotests/data/testjsonmetadatapackage/contents/ui/main.qml PRE-CREATION 
>   autotests/data/testjsonmetadatapackage/metadata.json PRE-CREATION 
>   autotests/querytest.cpp 0a2f11a 
>   src/kpackage/package.cpp 8416054 
>   src/kpackage/packageloader.cpp 1e1e382 
>   src/kpackage/private/packagejobthread.cpp 444dacc 
>   src/kpackage/private/packages.cpp 2f6bbcf 
> 
> Diff: https://git.reviewboard.kde.org/r/126348/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass (except for 
> https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/,
>  that is not passing in master).
> Adds a test plugin with a json file in it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Gregor Mi via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

--- Comment #11 from Gregor Mi  ---
Reproduced on 5.5.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126461/
---

(Updated Dec. 29, 2015, 8:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit f639996becc2fae284d9c83273856dee510b699d by Martin 
Klapetek to branch master.


Bugs: 356653
http://bugs.kde.org/show_bug.cgi?id=356653


Repository: plasma-framework


Description
---

https://git.reviewboard.kde.org/r/126459/ introduced new
flag that allows to skip the grouping of notifications.

This should fix all bugs caused by checking for appName
being "plasma_workspace" which are all default notifications
from any plasmoid.

BUG: 356653

(this also needs to raise the KF5 dep to 5.18 which is
normally done at release time, but in order to use this
now, it needs to be bumped now, otherwise build failures
will ensue)


Diffs
-

  CMakeLists.txt a27b3ac 
  src/plasma/private/applet_p.cpp 511b451 

Diff: https://git.reviewboard.kde.org/r/126461/diff/


Testing
---


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126517/
---

(Updated Dez. 29, 2015, 11:10 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This enables the StatusNotifier option introduced in Review 126516, see Review 
126515 for more information.

When Plasma reached the recursion counter it disables the passive option since 
there will most likely be no System Tray to show this error and then 
something's really wrong in the first place.


Diffs
-

  shell/shellmanager.cpp 0a6ac5e 

Diff: https://git.reviewboard.kde.org/r/126517/diff/


Testing
---

Crashed plasma two times, it restarted and I got two SNIs, crashed it another 
time, got black screen with DrKonqi dialog.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

[Ben Cooksley]

On Tue, Dec 29, 2015 at 11:16 PM, Kevin Funk  wrote:
> On Tuesday, December 29, 2015 10:39:01 PM Ben Cooksley wrote:
>> On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher  wrote:
>> > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley  wrote:
>> >>> Is there some place where search engines can easily index our source
>> >>> code or are we shooting ourselves in the foot here?
>> >>
>> >> We could probably make it available by publishing the source trees
>> >> used by LXR / EBN.
>> >> This would only have the main branches obviously rather than everything
>> >> though.
>> >>
>> >> I haven't checked, but LXR may already make it's copy of the code
>> >> accessible...>
>> > I think making our sourcecode available to search engines is pretty
>> > important for the reasons already mentioned by others. Do you need
>> > help for it? If you write down what's needed I can help find someone
>> > to do it.
>>
>> I've now provisioned https://sources.kde.org/
>
> I'm not sure this is super useful, to be honest (as mentioned in #kde-
> sysadmins already).
>
> This is really just plain file serving, with no cross-references to either LXR
> (or apidocs). This is basically a dead-end when you follow a result on Google.
>
> Wouldn't it be possible to let robots index https://lxr.kde.org/source/
>  instead? We have the infrastructure...

We'll give it a shot.

>
> Of course we need to blacklist all the pages allowing to actively *search* LXR
> for robots, in order to avoid abuse.

Note that despite robots.txt, many spiders (including Google, Yahoo
and Bing) will actively disregard the instructions in there.
While they may not return the results - or omit snippets of the page
content - they have all been guilty (at least in the past) of
disregarding our restrictions, resulting in downtime (which have in
some cases necessitated full host reboots to fix) for numerous KDE.org
subsites in the past.

This is why QuickGit and WebSVN have extremely restrictive robots.txt
policies, in addition to blacklist rules within our web server
configurations.

>
> Cheers,
> Kevin

Regards,
Ben

>
>> > Cheers
>> > Lydia
>>
>> Regards,
>> Ben
>>
>> > --
>> > Lydia Pintscher - http://about.me/lydia.pintscher
>> > KDE e.V. Board of Directors / KDE Community Working Group
>> > http://kde.org - http://open-advice.org
>> >
>> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
>> >>> unsubscribe <<>>
>> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
>> >> <<
>
> --
> Kevin Funk | kf...@kde.org | http://kfunk.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126570/
---

Review request for Plasma, KDE Usability and Martin Klapetek.


Repository: plasma-workspace


Description
---

It's nice that we offer to configure notifications from a notification. 
Usually, however, you're lost in a dialog notifications and you have no idea 
which event you actually just saw.


Diffs
-

  applets/notifications/package/contents/ui/NotificationDelegate.qml fde115c 
  applets/notifications/package/contents/ui/NotificationPopup.qml d398027 
  applets/notifications/package/contents/ui/Notifications.qml f479a65 
  dataengines/notifications/notificationaction.cpp da5ba14 
  dataengines/notifications/notifications.operations d2a120a 
  dataengines/notifications/notificationsengine.h b275830 
  dataengines/notifications/notificationsengine.cpp 829ef4e 

Diff: https://git.reviewboard.kde.org/r/126570/diff/


Testing
---

I now get the actual notification highlighted when I press the configure button 
of one. Neat.


File Attachments


Highlighted notification
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4533273e-f4f8-43e4-b291-8ac2907e0138__Screenshot_20151229_234815a.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126570/#review90315
---


Great idea! No objections from me.

- Thomas Pfeiffer


On Dec. 29, 2015, 10:55 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126570/
> ---
> 
> (Updated Dec. 29, 2015, 10:55 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> It's nice that we offer to configure notifications from a notification. 
> Usually, however, you're lost in a dialog notifications and you have no idea 
> which event you actually just saw.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationDelegate.qml fde115c 
>   applets/notifications/package/contents/ui/NotificationPopup.qml d398027 
>   applets/notifications/package/contents/ui/Notifications.qml f479a65 
>   dataengines/notifications/notificationaction.cpp da5ba14 
>   dataengines/notifications/notifications.operations d2a120a 
>   dataengines/notifications/notificationsengine.h b275830 
>   dataengines/notifications/notificationsengine.cpp 829ef4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126570/diff/
> 
> 
> Testing
> ---
> 
> I now get the actual notification highlighted when I press the configure 
> button of one. Neat.
> 
> 
> File Attachments
> 
> 
> Highlighted notification
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4533273e-f4f8-43e4-b291-8ac2907e0138__Screenshot_20151229_234815a.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Ken Vermette]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90316
---


In regards to the message displayed (as mentioned in your G+ post) how about:

"Sorry for the inconvenience. Please report the error to help improve this 
software."

- Ken Vermette


On Dec. 29, 2015, 9:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dec. 29, 2015, 9:19 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote:
> > In regards to the message displayed (as mentioned in your G+ post) how 
> > about:
> > 
> > "Sorry for the inconvenience. Please report the error to help improve this 
> > software."

I'm quite indifferent on the wording: 
http://wstaw.org/m/2015/12/30/canadiankonqi.jpg

Btw, perhaps we could give the DrKonqi dialog a slightly cuter look with a sad 
Konqi in there, or so, similar to our about dialog. The current heart monitor 
icon we currently have at the right is a bit dated.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90316
---


On Dez. 29, 2015, 9:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 29, 2015, 9:19 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote:
> > In regards to the message displayed (as mentioned in your G+ post) how 
> > about:
> > 
> > "Sorry for the inconvenience. Please report the error to help improve this 
> > software."
> 
> Kai Uwe Broulik wrote:
> I'm quite indifferent on the wording: 
> http://wstaw.org/m/2015/12/30/canadiankonqi.jpg
> 
> Btw, perhaps we could give the DrKonqi dialog a slightly cuter look with 
> a sad Konqi in there, or so, similar to our about dialog. The current heart 
> monitor icon we currently have at the right is a bit dated.

You know, like this: http://wstaw.org/m/2015/12/30/konqikonq.jpg except with a 
less cheerful dragon :)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90316
---


On Dez. 29, 2015, 9:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 29, 2015, 9:19 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

[Martin Klapetek]

> On Dec. 21, 2015, 9:38 p.m., David Edmundson wrote:
> >

Stable too? That would require bumping the required frameworks version from 
5.15 to 5.18.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126460/#review89856
---


On Dec. 21, 2015, 9:24 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126460/
> ---
> 
> (Updated Dec. 21, 2015, 9:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://git.reviewboard.kde.org/r/126459/ introduced new
> flag that allows to skip the grouping of notifications.
> 
> This patch adapts the notifications server to that change.
> 
> 
> Diffs
> -
> 
>   dataengines/notifications/notificationsengine.cpp 829ef4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126460/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126567: [ToolButtonStyle] Always indicate activeFocus

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126567/
---

(Updated Dec. 29, 2015, 10:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 81a03ef29129f32faa41f332a4dede229b25a1a8 by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

Even when flat we should indicate that a ToolButton has active focus. This 
makes keyboard navigation much less awkward to use.

Unfortunately activeFocus stays there even if I click another button (and we 
probably don't want activeFocusOnPress by default or else we always end up with 
one strange highlighted ToolButton, ooohh QML and keyboards)


Diffs
-

  src/declarativeimports/plasmastyle/ToolButtonStyle.qml c9502e7 

Diff: https://git.reviewboard.kde.org/r/126567/diff/


Testing
---

I can tab through plasma-nm and mediacontroller and actually see where I'm going


File Attachments


Media Controller focus
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/48804e09-f3c3-42b0-8e4b-a12ff9b9c2ed__Screenshot_20151229_225847.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126566: Add "applicationcrash" notification event

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126566/
---

Review request for Plasma.


Repository: frameworkintegration


Description
---

This adds a new "applicationcrash" event to be used for the DrKonqi 
notifications in Review 126515.

The "Catastrophe" event, while mentioning "something bad happened, at least the 
app crashed", draws a lot of attention to it with its sound. Also, having a 
dedicated notification for this could allow users to specifically disable these 
DrKonqi messages in case they really don't care.


Diffs
-

  plasma_workspace.notifyrc 877096a 

Diff: https://git.reviewboard.kde.org/r/126566/diff/


Testing
---

Works, I get a Plasma notification without sound.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #83 from Martin Klapetek  ---
Can you check if you have 2 kded5 processes running?
Your backtrace again shows no activity at all.

That said, please compare the backtrace with the previous ones
before you upload a new one, there's no point uploading the same
backtrace again and again.

Lastly, the only thing of interest in the backtrace is libvlc+alsa,
hard to tell where is this coming from though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124047: Improve clock's tooltip layout

[Martin Klapetek]

> On Dec. 22, 2015, 10:53 p.m., Kai Uwe Broulik wrote:
> > It still does not shrink if timezones are removed.
> > 
> > Otherwise looking good.

Tips for the shrinking issue?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review89950
---


On Dec. 22, 2015, 8:38 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> ---
> 
> (Updated Dec. 22, 2015, 8:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348078
> https://bugs.kde.org/show_bug.cgi?id=348078
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> In kde4 times, the layout of clock's tooltip was nicely arranged using a 
> table. Now it's a bit of a mess so this brings back the table.
> 
> Also simplifies the timeForZone function which is used only for the tooltip.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
>   applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e754925 
> 
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

(Updated Dez. 29, 2015, 9:19 nachm.)


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
---

* Add context menu actions to SNI: Report Bug (to make it a bit more explicit 
in addition to just clicking it); Restart Application (in case you missed the 
notification you can still restart the app as long as the SNI is there)
* Add contexts to i18n
* Re-order code to be a bit clearer
* Use custom notification event; the Catastrophe one draws a lot of attention 
to it with its sound


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs (updated)
-

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126566: Add "applicationcrash" notification event

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126566/#review90308
---

Ship it!


Ship It!

- Martin Klapetek


On Dec. 29, 2015, 10:22 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126566/
> ---
> 
> (Updated Dec. 29, 2015, 10:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This adds a new "applicationcrash" event to be used for the DrKonqi 
> notifications in Review 126515.
> 
> The "Catastrophe" event, while mentioning "something bad happened, at least 
> the app crashed", draws a lot of attention to it with its sound. Also, having 
> a dedicated notification for this could allow users to specifically disable 
> these DrKonqi messages in case they really don't care.
> 
> 
> Diffs
> -
> 
>   plasma_workspace.notifyrc 877096a 
> 
> Diff: https://git.reviewboard.kde.org/r/126566/diff/
> 
> 
> Testing
> ---
> 
> Works, I get a Plasma notification without sound.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126566: Add "applicationcrash" notification event

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126566/#review90309
---

Ship it!


Ship It!

- David Edmundson


On Dec. 29, 2015, 9:22 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126566/
> ---
> 
> (Updated Dec. 29, 2015, 9:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This adds a new "applicationcrash" event to be used for the DrKonqi 
> notifications in Review 126515.
> 
> The "Catastrophe" event, while mentioning "something bad happened, at least 
> the app crashed", draws a lot of attention to it with its sound. Also, having 
> a dedicated notification for this could allow users to specifically disable 
> these DrKonqi messages in case they really don't care.
> 
> 
> Diffs
> -
> 
>   plasma_workspace.notifyrc 877096a 
> 
> Diff: https://git.reviewboard.kde.org/r/126566/diff/
> 
> 
> Testing
> ---
> 
> Works, I get a Plasma notification without sound.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126567: [ToolButtonStyle] Always indicate activeFocus

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126567/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Even when flat we should indicate that a ToolButton has active focus. This 
makes keyboard navigation much less awkward to use.

Unfortunately activeFocus stays there even if I click another button (and we 
probably don't want activeFocusOnPress by default or else we always end up with 
one strange highlighted ToolButton, ooohh QML and keyboards)


Diffs
-

  src/declarativeimports/plasmastyle/ToolButtonStyle.qml c9502e7 

Diff: https://git.reviewboard.kde.org/r/126567/diff/


Testing
---

I can tab through plasma-nm and mediacontroller and actually see where I'm going


File Attachments


Media Controller focus
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/48804e09-f3c3-42b0-8e4b-a12ff9b9c2ed__Screenshot_20151229_225847.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126092: Konqui based Emotion pack named eKspression

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126092/#review90304
---


Are you sure this is the updated pack? I see the exact same icons as in the 
first round.

- Martin Klapetek


On Dec. 23, 2015, 9:05 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126092/
> ---
> 
> (Updated Dec. 23, 2015, 9:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> The emoticon pack was done by Andrea Del Sarto
> 
> 
> Diffs
> -
> 
>   themes/CMakeLists.txt 657c7fc 
> 
> Diff: https://git.reviewboard.kde.org/r/126092/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> eKspression emoticon pack
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/1054a71a-4c1f-46e4-8d52-cf8bb33653bd__eKspression.zip
> konqui
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/7fc6ede6-9965-43ed-ac5f-937bf380103d__konqui.tar.gz
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126567: [ToolButtonStyle] Always indicate activeFocus

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126567/#review90314
---

Ship it!


Ship It!

- Marco Martin


On Dec. 29, 2015, 10:04 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126567/
> ---
> 
> (Updated Dec. 29, 2015, 10:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Even when flat we should indicate that a ToolButton has active focus. This 
> makes keyboard navigation much less awkward to use.
> 
> Unfortunately activeFocus stays there even if I click another button (and we 
> probably don't want activeFocusOnPress by default or else we always end up 
> with one strange highlighted ToolButton, ooohh QML and keyboards)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/ToolButtonStyle.qml c9502e7 
> 
> Diff: https://git.reviewboard.kde.org/r/126567/diff/
> 
> 
> Testing
> ---
> 
> I can tab through plasma-nm and mediacontroller and actually see where I'm 
> going
> 
> 
> File Attachments
> 
> 
> Media Controller focus
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/48804e09-f3c3-42b0-8e4b-a12ff9b9c2ed__Screenshot_20151229_225847.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126278: [Icon Widget] Add support for Jump Lists

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126278/#review90322
---

Ship it!


Ship It!

- Bhushan Shah


On Dec. 8, 2015, 5:59 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126278/
> ---
> 
> (Updated Dec. 8, 2015, 5:59 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds support for Desktop Actions aka Jump Lists to the icon widget to 
> make them on par with launchers.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126278/diff/
> 
> 
> Testing
> ---
> 
> I get New Tab/New Incognito in Chromium context menu.
> 
> I didn't test what happens if I change the URL (whether it properly updates 
> them). Also the patch has some unrelated changes from Review 126149
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/08/e6f80a92-8120-414f-840a-120c791b3ebf__jumplisticon.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90270
---


i use sleep/hibernate from there too (have neither lock/logout nor any start 
menu in my session).
either cleaning the screen brightness part, or put them in the sessions runner?

- Marco Martin


On Dec. 28, 2015, 6:28 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> ---
> 
> (Updated Dec. 28, 2015, 6:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt 48cc379 
>   runners/powerdevil/CMakeLists.txt 7c03e29 
>   runners/powerdevil/Messages.sh 99ae5dc 
>   runners/powerdevil/PowerDevilRunner.h 7995621 
>   runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
>   runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 
> 
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/
---

(Updated Dec. 29, 2015, 9:34 a.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
and Simon Wächter.


Changes
---

Submitted with commit 76377cdf5d0658672bea5cc84f1c7d5657b8aea2 by Marco Martin 
to branch master.


Repository: extra-cmake-modules


Description
---

templates are very useful as teaching tool in order to make
a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks


Diffs
-

  docs/kde-module/KDEPackageAppTemplates.rst PRE-CREATION 
  kde-modules/KDEInstallDirs.cmake b7cd34d 
  kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
  tests/CMakeLists.txt 1a66f56 
  tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/check.cmake.in PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
  
tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
 PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126185/diff/


Testing
---

done some templates installed by plasma-framework


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

[Ben Cooksley]

On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher  wrote:
> On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley  wrote:
>>> Is there some place where search engines can easily index our source
>>> code or are we shooting ourselves in the foot here?
>>
>> We could probably make it available by publishing the source trees
>> used by LXR / EBN.
>> This would only have the main branches obviously rather than everything 
>> though.
>>
>> I haven't checked, but LXR may already make it's copy of the code 
>> accessible...
>
> I think making our sourcecode available to search engines is pretty
> important for the reasons already mentioned by others. Do you need
> help for it? If you write down what's needed I can help find someone
> to do it.

I've now provisioned https://sources.kde.org/

>
>
> Cheers
> Lydia

Regards,
Ben

>
> --
> Lydia Pintscher - http://about.me/lydia.pintscher
> KDE e.V. Board of Directors / KDE Community Working Group
> http://kde.org - http://open-advice.org
>
>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 28 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 29 Dec 2015 13:54:40 +
Build duration: 1 min 38 sec

CHANGE SET
Revision 9a04a838e5e47c2b2ca17e0f3ccdb683fc28299c by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit runners/sessions/plasma-runner-sessions.desktop
  change: edit runners/activities/plasma-runner-activityrunner.desktop
  change: edit runners/windows/plasma-runner-windows.desktop
  change: edit shell/plasmashell.desktop
  change: edit 
containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.desktop
  change: edit appmenu/appmenu.desktop
  change: edit 
shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop
  change: edit runners/baloo/plasma-runner-baloosearch.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126562: Deal properly with symlinks in path to packages

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126562/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

We receive the URL with all symlinks resolved, but internally the
pkgRoot kept unresolved symlinks preventing matches if there was a
symlink somewhere to get to the package.


Diffs
-

  src/plasmaquick/packageurlinterceptor.cpp 5bd600c 

Diff: https://git.reviewboard.kde.org/r/126562/diff/


Testing
---

All applets work for me without the older patches I had:
https://git.reviewboard.kde.org/r/124204/
https://git.reviewboard.kde.org/r/124205/
https://git.reviewboard.kde.org/r/124206/
https://git.reviewboard.kde.org/r/124207/


Thanks,

Kevin Ottens

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126559: dark colorscheme option for cuttlefish

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126559/#review90279
---

Ship it!


Ship It!

- David Edmundson


On Dec. 29, 2015, 1:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126559/
> ---
> 
> (Updated Dec. 29, 2015, 1:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> Since now icons from the system theme are supposed to have the full 
> stylesheet data in order to be colorized, add a dark colorscheme option in 
> cuttlefish for a quick glance at what icons have a correct stylesheet and 
> what don't
> 
> 
> Diffs
> -
> 
>   cuttlefish/package/contents/ui/IconGridDelegate.qml 0a36b68 
>   cuttlefish/package/contents/ui/Preview.qml acdb2be 
>   cuttlefish/package/contents/ui/Tools.qml c496f55 
>   cuttlefish/package/contents/ui/cuttlefish.qml 8bfe345 
> 
> Diff: https://git.reviewboard.kde.org/r/126559/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cuttlefish.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4d705ca8-7aa0-4312-8901-0636502796f4__cuttlefish.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124204: Use proper relative paths to import js code

[David Edmundson]

> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote:
> > this still seems to cause issues for some people.
> > May this series of patches be worth to push anyways?

>this still seems to cause issues for some people.

Where have you seen that? 
I don't recall seeing any bug reports.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/#review90278
---


On June 29, 2015, 7:15 a.m., Kevin Ottens wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124204/
> ---
> 
> (Updated June 29, 2015, 7:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Use proper relative paths to import js code
> 
> 
> Diffs
> -
> 
>   src/applet/package/contents/ui/BluetoothApplet.qml 
> 4e8b9648983edd2c8db242515464ae22d1e6fbe6 
>   src/applet/package/contents/ui/CompactRepresentation.qml 
> 7085a7ec82fa88cb2d8e1a58847215845f3d5658 
> 
> Diff: https://git.reviewboard.kde.org/r/124204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

[Ashish Bansal]

On Tue, Dec 29, 2015 at 3:09 PM, Ben Cooksley  wrote:

> On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher  wrote:
> > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley 
> wrote:
> >>> Is there some place where search engines can easily index our source
> >>> code or are we shooting ourselves in the foot here?
> >>
> >> We could probably make it available by publishing the source trees
> >> used by LXR / EBN.
> >> This would only have the main branches obviously rather than everything
> though.
> >>
> >> I haven't checked, but LXR may already make it's copy of the code
> accessible...
> >
> > I think making our sourcecode available to search engines is pretty
> > important for the reasons already mentioned by others. Do you need
> > help for it? If you write down what's needed I can help find someone
> > to do it.
>
> I've now provisioned https://sources.kde.org/
>
>
Thanks a lot!


> >
> >
> > Cheers
> > Lydia
>
> Regards,
> Ben
>
> >
> > --
> > Lydia Pintscher - http://about.me/lydia.pintscher
> > KDE e.V. Board of Directors / KDE Community Working Group
> > http://kde.org - http://open-advice.org
> >
> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 

*Regards,*
*Ashish Bansal*
*http://ashish-bansal.in *
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124204: Use proper relative paths to import js code

[Marco Martin]

> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote:
> > this still seems to cause issues for some people.
> > May this series of patches be worth to push anyways?
> 
> David Edmundson wrote:
> >this still seems to cause issues for some people.
> 
> Where have you seen that? 
> I don't recall seeing any bug reports.

still happened to Kevin after qt, frameworks, and workspace were updated.
and yeah, still annoying to not have idea why that happens


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/#review90278
---


On June 29, 2015, 7:15 a.m., Kevin Ottens wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124204/
> ---
> 
> (Updated June 29, 2015, 7:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Use proper relative paths to import js code
> 
> 
> Diffs
> -
> 
>   src/applet/package/contents/ui/BluetoothApplet.qml 
> 4e8b9648983edd2c8db242515464ae22d1e6fbe6 
>   src/applet/package/contents/ui/CompactRepresentation.qml 
> 7085a7ec82fa88cb2d8e1a58847215845f3d5658 
> 
> Diff: https://git.reviewboard.kde.org/r/124204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126557/
---

(Updated Dec. 29, 2015, 2:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 3f56e63e706e299802df115be4bc52c3743760ba by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

drop local copy of the module


Diffs
-

  CMakeLists.txt a27b3ac 
  cmake/KDETemplateMacro.cmake 796c3f1 
  templates/CMakeLists.txt 773c471 

Diff: https://git.reviewboard.kde.org/r/126557/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

[Marco Martin]

> On Dec. 29, 2015, 2:37 p.m., David Edmundson wrote:
> > CMakeLists.txt, line 7
> > 
> >
> > is this still right?

hmm, nope, updating to 18


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126557/#review90286
---


On Dec. 29, 2015, 9:53 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126557/
> ---
> 
> (Updated Dec. 29, 2015, 9:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> drop local copy of the module
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27b3ac 
>   cmake/KDETemplateMacro.cmake 796c3f1 
>   templates/CMakeLists.txt 773c471 
> 
> Diff: https://git.reviewboard.kde.org/r/126557/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

[Marco Martin]

> On Dec. 29, 2015, 2:37 p.m., David Edmundson wrote:
> > CMakeLists.txt, line 7
> > 
> >
> > is this still right?
> 
> Marco Martin wrote:
> hmm, nope, updating to 18

aww, shit, mixed up the commit with unrelated stuff, sorry :/


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126557/#review90286
---


On Dec. 29, 2015, 2:42 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126557/
> ---
> 
> (Updated Dec. 29, 2015, 2:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> drop local copy of the module
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27b3ac 
>   cmake/KDETemplateMacro.cmake 796c3f1 
>   templates/CMakeLists.txt 773c471 
> 
> Diff: https://git.reviewboard.kde.org/r/126557/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124205: Use proper relative paths to import js code

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124205/
---

(Updated Dec. 29, 2015, 3:01 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: kdeplasma-addons


Description
---

Use proper relative paths to import js code


Diffs
-

  applets/weather/package/contents/ui/FiveDaysView.qml 
a39f3344680e3ed595c8f34f04c5133880255b02 
  applets/weather/package/contents/ui/WeatherListView.qml 
b29099f8298b475ade6c4f0fac08ff8d4456db27 

Diff: https://git.reviewboard.kde.org/r/124205/diff/


Testing
---


Thanks,

Kevin Ottens

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124204: Use proper relative paths to import js code

[Kevin Ottens]

> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote:
> > this still seems to cause issues for some people.
> > May this series of patches be worth to push anyways?
> 
> David Edmundson wrote:
> >this still seems to cause issues for some people.
> 
> Where have you seen that? 
> I don't recall seeing any bug reports.
> 
> Marco Martin wrote:
> still happened to Kevin after qt, frameworks, and workspace were updated.
> and yeah, still annoying to not have idea why that happens

OK, guys, found it. I'll upload a new patch for plasma-framework shortly. Those 
can be closed.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/#review90278
---


On June 29, 2015, 7:15 a.m., Kevin Ottens wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124204/
> ---
> 
> (Updated June 29, 2015, 7:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Use proper relative paths to import js code
> 
> 
> Diffs
> -
> 
>   src/applet/package/contents/ui/BluetoothApplet.qml 
> 4e8b9648983edd2c8db242515464ae22d1e6fbe6 
>   src/applet/package/contents/ui/CompactRepresentation.qml 
> 7085a7ec82fa88cb2d8e1a58847215845f3d5658 
> 
> Diff: https://git.reviewboard.kde.org/r/124204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124204: Use proper relative paths to import js code

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/
---

(Updated Dec. 29, 2015, 3:01 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: bluedevil


Description
---

Use proper relative paths to import js code


Diffs
-

  src/applet/package/contents/ui/BluetoothApplet.qml 
4e8b9648983edd2c8db242515464ae22d1e6fbe6 
  src/applet/package/contents/ui/CompactRepresentation.qml 
7085a7ec82fa88cb2d8e1a58847215845f3d5658 

Diff: https://git.reviewboard.kde.org/r/124204/diff/


Testing
---


Thanks,

Kevin Ottens

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124206: Use proper relative paths to import js code

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124206/
---

(Updated Dec. 29, 2015, 3:01 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-desktop


Description
---

Use proper relative paths to import js code


Diffs
-

  applets/pager/package/contents/ui/main.qml 
a5d99c9951ecc104a0ad36246df60ebf11a78197 
  containments/desktop/package/contents/ui/AppletAppearance.qml 
9f71c8c706b610dfada422143bd3903cf6aa3f73 
  containments/desktop/package/contents/ui/AppletHandle.qml 
a777eafc87e82cf3fa97b43fd1b22b50276faac8 
  containments/desktop/package/contents/ui/FolderView.qml 
8cc159e83b9ac139482d7c65aa25bb4f0f87bd3d 
  containments/desktop/package/contents/ui/main.qml 
2ec1f0c83bb4dc1b864d13b76004436afdc10ecb 
  containments/panel/contents/ui/ConfigOverlay.qml 
a89a5feafd04766a295932a595e788516870c2ff 
  containments/panel/contents/ui/main.qml 
1ed0dc2a79476895ebfa38eb1f52c3bcb98fa780 

Diff: https://git.reviewboard.kde.org/r/124206/diff/


Testing
---


Thanks,

Kevin Ottens

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126557: use the new KDEPackageAppTemplates ECM module

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126557/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

drop local copy of the module


Diffs
-

  CMakeLists.txt a27b3ac 
  cmake/KDETemplateMacro.cmake 796c3f1 
  templates/CMakeLists.txt 773c471 

Diff: https://git.reviewboard.kde.org/r/126557/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

[Kåre Särs]

On Tuesday, December 29, 2015 10:39:01 PM Ben Cooksley wrote:
> On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher  wrote:
> > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley  wrote:
> >>> Is there some place where search engines can easily index our source
> >>> code or are we shooting ourselves in the foot here?
> >> 
> >> We could probably make it available by publishing the source trees
> >> used by LXR / EBN.
> >> This would only have the main branches obviously rather than everything
> >> though.
> >> 
> >> I haven't checked, but LXR may already make it's copy of the code
> >> accessible...> 
> > I think making our sourcecode available to search engines is pretty
> > important for the reasons already mentioned by others. Do you need
> > help for it? If you write down what's needed I can help find someone
> > to do it.
> 
> I've now provisioned https://sources.kde.org/

You rock :)

Regards,
Kåre

> 
> > Cheers
> > Lydia
> 
> Regards,
> Ben
> 
> > --
> > Lydia Pintscher - http://about.me/lydia.pintscher
> > KDE e.V. Board of Directors / KDE Community Working Group
> > http://kde.org - http://open-advice.org
> > 
> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >>> unsubscribe <<
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124204: Use proper relative paths to import js code

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/#review90278
---


this still seems to cause issues for some people.
May this series of patches be worth to push anyways?

- Marco Martin


On June 29, 2015, 7:15 a.m., Kevin Ottens wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124204/
> ---
> 
> (Updated June 29, 2015, 7:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Use proper relative paths to import js code
> 
> 
> Diffs
> -
> 
>   src/applet/package/contents/ui/BluetoothApplet.qml 
> 4e8b9648983edd2c8db242515464ae22d1e6fbe6 
>   src/applet/package/contents/ui/CompactRepresentation.qml 
> 7085a7ec82fa88cb2d8e1a58847215845f3d5658 
> 
> Diff: https://git.reviewboard.kde.org/r/124204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126559: dark colorscheme option for cuttlefish

[Marco Martin]

> On Dec. 29, 2015, 2:32 p.m., David Edmundson wrote:
> > cuttlefish/package/contents/ui/Tools.qml, line 130
> > 
> >
> > may be better to make the text be more like: ComplementaryColorGroup
> > 
> > 
> > otherwise if you're editing a dark theme it's confusing.

inverted color scheme?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126559/#review90283
---


On Dec. 29, 2015, 1:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126559/
> ---
> 
> (Updated Dec. 29, 2015, 1:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> Since now icons from the system theme are supposed to have the full 
> stylesheet data in order to be colorized, add a dark colorscheme option in 
> cuttlefish for a quick glance at what icons have a correct stylesheet and 
> what don't
> 
> 
> Diffs
> -
> 
>   cuttlefish/package/contents/ui/IconGridDelegate.qml 0a36b68 
>   cuttlefish/package/contents/ui/Preview.qml acdb2be 
>   cuttlefish/package/contents/ui/Tools.qml c496f55 
>   cuttlefish/package/contents/ui/cuttlefish.qml 8bfe345 
> 
> Diff: https://git.reviewboard.kde.org/r/126559/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cuttlefish.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4d705ca8-7aa0-4312-8901-0636502796f4__cuttlefish.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126559: dark colorscheme option for cuttlefish

[David Edmundson]

> On Dec. 29, 2015, 2:32 p.m., David Edmundson wrote:
> > cuttlefish/package/contents/ui/Tools.qml, line 130
> > 
> >
> > may be better to make the text be more like: ComplementaryColorGroup
> > 
> > 
> > otherwise if you're editing a dark theme it's confusing.
> 
> Marco Martin wrote:
> inverted color scheme?

+1


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126559/#review90283
---


On Dec. 29, 2015, 1:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126559/
> ---
> 
> (Updated Dec. 29, 2015, 1:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> Since now icons from the system theme are supposed to have the full 
> stylesheet data in order to be colorized, add a dark colorscheme option in 
> cuttlefish for a quick glance at what icons have a correct stylesheet and 
> what don't
> 
> 
> Diffs
> -
> 
>   cuttlefish/package/contents/ui/IconGridDelegate.qml 0a36b68 
>   cuttlefish/package/contents/ui/Preview.qml acdb2be 
>   cuttlefish/package/contents/ui/Tools.qml c496f55 
>   cuttlefish/package/contents/ui/cuttlefish.qml 8bfe345 
> 
> Diff: https://git.reviewboard.kde.org/r/126559/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cuttlefish.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4d705ca8-7aa0-4312-8901-0636502796f4__cuttlefish.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124207: Use proper relative paths to import js code

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124207/
---

(Updated Dec. 29, 2015, 3:01 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Use proper relative paths to import js code


Diffs
-

  applets/analog-clock/contents/ui/analogclock.qml 
edb3af94dff70e8f846783ffe1165fc8cf83beca 
  applets/batterymonitor/package/contents/ui/BatteryItem.qml 
a91286ceb5e502fdb2995627dd0a762c843d6a7a 
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml 
b4059cbe32f549cb06f34d18ebfa3261bc7a0d0f 
  applets/batterymonitor/package/contents/ui/PopupDialog.qml 
d4952c61e701f7077b7d9dfcf084b4baf3951f0d 
  applets/batterymonitor/package/contents/ui/batterymonitor.qml 
ce3a996a8e9024ac7d8d82b546be4aeed8011c74 
  applets/lock_logout/contents/ui/lockout.qml 
635389a3ca57845ed7b0c28511c4fbd8aad1951d 
  applets/notifications/package/contents/ui/main.qml 
1fdd11abad41bc0b7f156be1409d9268f424a0ae 
  applets/systemtray/package/contents/ui/main.qml 
e794d1ca436f94c044c5f532dd6fc7d6082d3576 

Diff: https://git.reviewboard.kde.org/r/124207/diff/


Testing
---


Thanks,

Kevin Ottens

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126559: dark colorscheme option for cuttlefish

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126559/
---

Review request for Plasma.


Repository: plasma-sdk


Description
---

Since now icons from the system theme are supposed to have the full stylesheet 
data in order to be colorized, add a dark colorscheme option in cuttlefish for 
a quick glance at what icons have a correct stylesheet and what don't


Diffs
-

  cuttlefish/package/contents/ui/IconGridDelegate.qml 0a36b68 
  cuttlefish/package/contents/ui/Preview.qml acdb2be 
  cuttlefish/package/contents/ui/Tools.qml c496f55 
  cuttlefish/package/contents/ui/cuttlefish.qml 8bfe345 

Diff: https://git.reviewboard.kde.org/r/126559/diff/


Testing
---


File Attachments


cuttlefish.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4d705ca8-7aa0-4312-8901-0636502796f4__cuttlefish.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126559: dark colorscheme option for cuttlefish

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126559/#review90283
---



cuttlefish/package/contents/ui/Tools.qml (line 130)


may be better to make the text be more like: ComplementaryColorGroup

otherwise if you're editing a dark theme it's confusing.


- David Edmundson


On Dec. 29, 2015, 1:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126559/
> ---
> 
> (Updated Dec. 29, 2015, 1:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> Since now icons from the system theme are supposed to have the full 
> stylesheet data in order to be colorized, add a dark colorscheme option in 
> cuttlefish for a quick glance at what icons have a correct stylesheet and 
> what don't
> 
> 
> Diffs
> -
> 
>   cuttlefish/package/contents/ui/IconGridDelegate.qml 0a36b68 
>   cuttlefish/package/contents/ui/Preview.qml acdb2be 
>   cuttlefish/package/contents/ui/Tools.qml c496f55 
>   cuttlefish/package/contents/ui/cuttlefish.qml 8bfe345 
> 
> Diff: https://git.reviewboard.kde.org/r/126559/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> cuttlefish.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4d705ca8-7aa0-4312-8901-0636502796f4__cuttlefish.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126557/#review90286
---

Ship it!



CMakeLists.txt (line 7)


is this still right?


- David Edmundson


On Dec. 29, 2015, 9:53 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126557/
> ---
> 
> (Updated Dec. 29, 2015, 9:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> drop local copy of the module
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27b3ac 
>   cmake/KDETemplateMacro.cmake 796c3f1 
>   templates/CMakeLists.txt 773c471 
> 
> Diff: https://git.reviewboard.kde.org/r/126557/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126559: dark colorscheme option for cuttlefish

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126559/
---

(Updated Dec. 29, 2015, 2:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 237f61f2cda36493dba96dbe3d22c3048ff88fd3 by Marco Martin 
to branch master.


Repository: plasma-sdk


Description
---

Since now icons from the system theme are supposed to have the full stylesheet 
data in order to be colorized, add a dark colorscheme option in cuttlefish for 
a quick glance at what icons have a correct stylesheet and what don't


Diffs
-

  cuttlefish/package/contents/ui/IconGridDelegate.qml 0a36b68 
  cuttlefish/package/contents/ui/Preview.qml acdb2be 
  cuttlefish/package/contents/ui/Tools.qml c496f55 
  cuttlefish/package/contents/ui/cuttlefish.qml 8bfe345 

Diff: https://git.reviewboard.kde.org/r/126559/diff/


Testing
---


File Attachments


cuttlefish.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4d705ca8-7aa0-4312-8901-0636502796f4__cuttlefish.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel