Re: Window thumbnail discussion

[Martin Graesslin]

On Thursday, January 21, 2016 12:06:48 PM CET Martin Gräßlin wrote:
> I plan to write something down in the wiki next week, which should be a
> better starting point for discussions then.

Created a wiki page: https://community.kde.org/KWin/Window_Metadata

Please feel free to extend/fix as needed :-)

Cheers
Martin

The content I added is:

=Window Metadata=
==Rational==

Window Thumbnails as scaled down window content are hardly useable. Windows of 
same application are hardly distinguishable from each other which eliminates 
all advantages from thumbnails in first place.

In addition on Wayland it is difficult to get access to live-updating window 
thumbnails in the desktop shell. While the compositor has access to the window 
content, other applications do not. This would require a custom protocol to 
pass the window content from the compositor to the desktop shell. A protocol 
would be required which would be fairly close to being an own Wayland server.

This document describes how to put the application more in control of the 
window thumbnail which will be rendered.

== General Architecture ==

The protocol will be implemented using DBus to be windowing system agnostic. 
The window manager registers a DBus service "org.kde.kwin.windowmetadata1" and 
the object path "/org/kde/kwin/WindowMetadata1". On this interface there is a 
call "register" which allows an application to call it and to indicate that it 
supports the protocol.

The window manager is able to map windows to the DBus peer through the PID. On 
both X11 and Wayland the window manager has access to the PID. In case of 
Wayland this is only possible for the window manager, thus the DBus service 
must be bound on the window manager.

When a thumbnail is required the window manager informs the application for 
which window and in which size a thumbnail is needed. In addition it passes a 
filedescriptor of a pipe to the application. The application renders the 
thumbnail and writes the rendering result into the pipe and closes the pipe 
once the rendering is
finished. The application can render a thumbnail of different size if this of 
more use. To support that a small binary protocol on the pipe is required. It 
needs to describe:
 * size (width/height)
 * stride
 * image format
 * byte count
 * binary data

Obviously the server side needs to sanity check the values.

The protocol is not meant to have life-updating previews. There is a DBus call 
for the application to indicate that it has new data available, but it's the 
responsibility of the server to initiate the process. By that the server can 
control the updates to a sensible amount.

== Passing thumbnail to Desktop Shell ==

Internal implementation detail, to be defined.

== Window Actions ==

An additional idea is to allow the application to specify additional actions 
through the DBus interface. E.g. a "reload" action in a browser. This is 
intended to be implemented in a future release.

== Implementation ==

The implementation will be provided through a tier1 framework. It will be 
windowing system agnostic and only depends on DBus. For the application it 
will be as simple as just rendering to a QImage (through QPainter) or using a 
special QtQuick import.

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 358271] Some comboboxes are missing shadows and are hard to click

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358271

Hugo Pereira Da Costa  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|k...@davidedmundson.co.uk
 CC||hugo.pere...@free.fr
  Component|general |QtQuickControls

--- Comment #2 from Hugo Pereira Da Costa  ---
Reassinging to QtQuickControls
Does not happen to regular (QWidget based) comboboxes.
Haven't checked with other widget styles.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

[David Edmundson]

> On Jan. 24, 2016, 10:39 p.m., David Edmundson wrote:
> > applets/digital-clock/plugin/timezonesi18n.cpp, line 517
> > 
> >
> > may as well keep the comment from the i18n?
> 
> Pino Toscano wrote:
> Not sure what you mean. The point here is load the translations from the 
> iso_3166 domain (the .mo file, basically), and they have no context there. 
> After this patch, there will be 247 strings less to translate in the digital 
> clock messages, they won't be extracted anymore.

oh you're right.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91552
---


On Jan. 24, 2016, 9:58 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Jan. 24, 2016, 9:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

[Pino Toscano]

> On Gen. 24, 2016, 10:39 p.m., David Edmundson wrote:
> > applets/digital-clock/plugin/timezonesi18n.cpp, line 517
> > 
> >
> > may as well keep the comment from the i18n?

Not sure what you mean. The point here is load the translations from the 
iso_3166 domain (the .mo file, basically), and they have no context there. 
After this patch, there will be 247 strings less to translate in the digital 
clock messages, they won't be extracted anymore.


- Pino


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91552
---


On Gen. 24, 2016, 9:58 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Gen. 24, 2016, 9:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

[Kai Uwe Broulik]

> On Jan. 24, 2016, 10:26 nachm., Antonis Geralis wrote:
> > Hello! There is a typo in file ksolidnotify.cpp:166, also shown in third 
> > screenshot.

Well spotted. Fixed, thanks.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review91550
---


On Jan. 24, 2016, 9:40 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> ---
> 
> (Updated Jan. 24, 2016, 9:40 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of showing a detached status bar with the device name, show the 
> message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely 
> remove this device" message will show up; after 5 seconds the message and the 
> device will disappear. When trying to unmount a device and it fails, device 
> notifier will show up with an error message that will stay there until device 
> notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications 
> engine's wording (I'm open to better verbalizations) and one for the device 
> notifier
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> ---
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't 
> update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section 
> thing gets confused when the one item is already gone in the model (looks 
> like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device 
> there
> - it cannot actually highlight the device that was safely removed (it's no 
> longer part of the model and thus has no index), we could do a hack for this 
> though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon 
> but the error thing is always red, there's a smaller variant for the former 
> but not the latter apparently, also it seems we lack a proper "task done" 
> icon, Oxygen had one
> 
> 
> File Attachments
> 
> 
> Failed to mount
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> Emblem icon
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png
> Emblem-error
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png
> emblem-information
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91552
---



+1


applets/digital-clock/plugin/timezonesi18n.cpp (line 517)


may as well keep the comment from the i18n?


- David Edmundson


On Jan. 24, 2016, 9:58 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Jan. 24, 2016, 9:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

[Antonis Geralis]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review91550
---



Hello! There is a typo in file ksolidnotify.cpp:166, also shown in third 
screenshot.

- Antonis Geralis


On Jan. 24, 2016, 9:40 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> ---
> 
> (Updated Jan. 24, 2016, 9:40 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of showing a detached status bar with the device name, show the 
> message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely 
> remove this device" message will show up; after 5 seconds the message and the 
> device will disappear. When trying to unmount a device and it fails, device 
> notifier will show up with an error message that will stay there until device 
> notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications 
> engine's wording (I'm open to better verbalizations) and one for the device 
> notifier
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> ---
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't 
> update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section 
> thing gets confused when the one item is already gone in the model (looks 
> like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device 
> there
> - it cannot actually highlight the device that was safely removed (it's no 
> longer part of the model and thus has no index), we could do a hack for this 
> though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon 
> but the error thing is always red, there's a smaller variant for the former 
> but not the latter apparently, also it seems we lack a proper "task done" 
> icon, Oxygen had one
> 
> 
> File Attachments
> 
> 
> Failed to mount
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> Emblem icon
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png
> Emblem-error
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png
> emblem-information
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

[Heiko Tietze]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/#review91549
---


Ship it!




Ship It!

- Heiko Tietze


On Jan. 10, 2016, 4:33 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126300/
> ---
> 
> (Updated Jan. 10, 2016, 4:33 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> In Plasma 5 this KCM only lists the names of the available runners, with no 
> explanation of what they do.  In its previous incarnation in KDE4 (the 
> dropdown list from the runner config button), the descriptions were 
> displayed.  This change restores them.
> 
> 
> Diffs
> -
> 
>   kcms/runners/kcm.h f1239ee 
>   kcms/runners/kcm.cpp 4af82de 
> 
> Diff: https://git.reviewboard.kde.org/r/126300/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-desktop with this change, checked appearance of KCM in Breeze, 
> Oxygen and older styles.
> 
> 
> File Attachments
> 
> 
> Screenshot before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
> Screenshot after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
> Long lines elided
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

[Heiko Tietze]

> On Jan. 24, 2016, 8:58 p.m., Jonathan Marten wrote:
> > Ping anyone?
> 
> Kai Uwe Broulik wrote:
> Please if you fixed an issue raised mark is as fixed so the "open issues" 
> count drops, making it easier to see what has changed. After it's zero and 
> you already got a "Ship It" (see above, "Fix it", covered behind there's the 
> "Ship it") feel free to commit.

UX is not an exact science. I might be wrong, and always want to get at least 
one other opinion. But anyway, ship it.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/#review91537
---


On Jan. 10, 2016, 4:33 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126300/
> ---
> 
> (Updated Jan. 10, 2016, 4:33 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> In Plasma 5 this KCM only lists the names of the available runners, with no 
> explanation of what they do.  In its previous incarnation in KDE4 (the 
> dropdown list from the runner config button), the descriptions were 
> displayed.  This change restores them.
> 
> 
> Diffs
> -
> 
>   kcms/runners/kcm.h f1239ee 
>   kcms/runners/kcm.cpp 4af82de 
> 
> Diff: https://git.reviewboard.kde.org/r/126300/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-desktop with this change, checked appearance of KCM in Breeze, 
> Oxygen and older styles.
> 
> 
> File Attachments
> 
> 
> Screenshot before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
> Screenshot after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
> Long lines elided
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126879: [digital-clock] Use iso-codes for country names

[Pino Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/
---

Review request for Localization and Translation (l10n), Plasma and John Layt.


Repository: plasma-workspace


Description
---

Instead of an hardcoded list of translations of country names, look them up in 
the iso_3166 domain, provided by iso-codes.  The names of countries are changes 
to their ISO 3166 versions in iso-codes.

Look for iso-codes in cmake, but just as indication of it as runtime dependency.


Diffs
-

  applets/digital-clock/plugin/CMakeLists.txt 
c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
  applets/digital-clock/plugin/timezonesi18n.cpp 
6bb465e68bfba4695c79898d630dec5a7075a058 
  cmake/FindIsoCodes.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126879/diff/


Testing
---

With Plasma 5.3 (but this code is the same as in master), the configuration of 
timezoned in the digital clock is translated according to iso-codes.


Thanks,

Pino Toscano

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

[Kai Uwe Broulik]

> On Jan. 24, 2016, 8:58 nachm., Jonathan Marten wrote:
> > Ping anyone?

Please if you fixed an issue raised mark is as fixed so the "open issues" count 
drops, making it easier to see what has changed. After it's zero and you 
already got a "Ship It" (see above, "Fix it", covered behind there's the "Ship 
it") feel free to commit.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/#review91537
---


On Jan. 10, 2016, 4:33 nachm., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126300/
> ---
> 
> (Updated Jan. 10, 2016, 4:33 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> In Plasma 5 this KCM only lists the names of the available runners, with no 
> explanation of what they do.  In its previous incarnation in KDE4 (the 
> dropdown list from the runner config button), the descriptions were 
> displayed.  This change restores them.
> 
> 
> Diffs
> -
> 
>   kcms/runners/kcm.h f1239ee 
>   kcms/runners/kcm.cpp 4af82de 
> 
> Diff: https://git.reviewboard.kde.org/r/126300/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-desktop with this change, checked appearance of KCM in Breeze, 
> Oxygen and older styles.
> 
> 
> File Attachments
> 
> 
> Screenshot before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
> Screenshot after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
> Long lines elided
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126877: [Milou] Expose single runner name and icon

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126877/
---

Review request for Plasma and Vishesh Handa.


Repository: milou


Description
---

This exposes the name and icon of the single runner that is currently used so 
we can show this information.


Diffs
-

  lib/qml/ResultsView.qml 9b51d0b 
  lib/sourcesmodel.h ee70a03 
  lib/sourcesmodel.cpp 5187803 

Diff: https://git.reviewboard.kde.org/r/126877/diff/


Testing
---

Works.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126878: [KRunner] Show single runner name

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126878/
---

Review request for Plasma, KDE Usability and Vishesh Handa.


Repository: plasma-workspace


Description
---

When in single runner mode (ie. only use a specific runner rather than querying 
them all) show the name of the current runner.

This restores Plasma 4 behavior and is also somewhat in preparation for the 
global menu runner where it should be clear that I would currently be searching 
through the current application's menu.


Diffs
-

  lookandfeel/contents/runcommand/RunCommand.qml 43f7c55 

Diff: https://git.reviewboard.kde.org/r/126878/diff/


Testing
---

Name properly shows, layout works both ways without the window getting wider.

I just noticed I could probably hide the category label next to the search 
result, too, as it's now redundant but I don't know whether a runner can still 
set a different value for that or if that's always just the runner name?


File Attachments


Runner name label
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/
---

(Updated Jan. 25, 2016, 12:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 1ed7209f08aa69cec7847c606da8a2fc091dc603 by Kai Uwe 
Broulik to branch master.


Repository: plasma-workspace


Description
---

Instead of showing a detached status bar with the device name, show the message 
below the device.

When removing a device, device notifier will pop up and a "You can now safely 
remove this device" message will show up; after 5 seconds the message and the 
device will disappear. When trying to unmount a device and it fails, device 
notifier will show up with an error message that will stay there until device 
notifier is closed or another message appears.

This review consists of two patches: one for fixing the device notifications 
engine's wording (I'm open to better verbalizations) and one for the device 
notifier


Diffs
-

  applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
  applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
  applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca 
  dataengines/devicenotifications/ksolidnotify.h fac8cc1 
  dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 

Diff: https://git.reviewboard.kde.org/r/126688/diff/


Testing
---

There a still a couple of glitches:
- the layout doesn't properly reset at times (eg. the delegate height doesn't 
update) or fails to show certain items (also looks like a Qt bug)
- sometimes the delegates suddenly overlap each other beacuse the section thing 
gets confused when the one item is already gone in the model (looks like a Qt 
bug)
- the "no devices" heading doesn't know that there's still a pseudo-device there
- it cannot actually highlight the device that was safely removed (it's no 
longer part of the model and thus has no index), we could do a hack for this 
though
- the message doesn't disappear reliably or spontaneously re-appears
- depending on your screen dpi you sometimes get a black and white Info icon 
but the error thing is always red, there's a smaller variant for the former but 
not the latter apparently, also it seems we lack a proper "task done" icon, 
Oxygen had one


File Attachments


Failed to mount
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
Safely remove
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
Emblem icon
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png
Emblem-error
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png
emblem-information
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

[Jonathan Marten]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/#review91537
---



Ping anyone?

- Jonathan Marten


On Jan. 10, 2016, 4:33 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126300/
> ---
> 
> (Updated Jan. 10, 2016, 4:33 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> In Plasma 5 this KCM only lists the names of the available runners, with no 
> explanation of what they do.  In its previous incarnation in KDE4 (the 
> dropdown list from the runner config button), the descriptions were 
> displayed.  This change restores them.
> 
> 
> Diffs
> -
> 
>   kcms/runners/kcm.h f1239ee 
>   kcms/runners/kcm.cpp 4af82de 
> 
> Diff: https://git.reviewboard.kde.org/r/126300/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-desktop with this change, checked appearance of KCM in Breeze, 
> Oxygen and older styles.
> 
> 
> File Attachments
> 
> 
> Screenshot before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
> Screenshot after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
> Long lines elided
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[Anthony Fieroni]

> On Ян. 24, 2016, 4:43 след обяд, David Edmundson wrote:
> > >Continous usage, read as suspend/resume/use and so on, cause *cool* 
> > >tooltip animation transition between item to decrease it permormance
> > 
> > Why does QPropertyAnimation decrease in performance after suspend/restore?
> > 
> > Other than the KWindowSystem change I don't see what this is going to 
> > alter. You're removing a QPropertyAnimation when it's unused, which won't 
> > make a difference as it'll be unused anyway.
> 
> Anthony Fieroni wrote:
> It's not only 1 circle suspend/resume, it's couple of days. I cannot say 
> QPropertyAnimation is buggy, but i see it allocated once and lifetime is same 
> as panel, read fps are dropped in some summy day :) At same sunny day if you 
> add new panel, animation is great on newly panel with fresh 
> QPropertyAnimation allocated pointer, so let *refresh* the pointer :)
> 
> David Edmundson wrote:
> Do you have a link to the Qt bug for QPropertyAnimation?

No, only mine test here.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/#review91521
---


On Ян. 24, 2016, 5:20 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126870/
> ---
> 
> (Updated Ян. 24, 2016, 5:20 след обяд)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Bugs: 354353
> http://bugs.kde.org/show_bug.cgi?id=354353
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
> animation transition between item to decrease it permormance and looks quite 
> ugly. If add new panel animation is *cool* as is. The perfermonce decrease 
> can be cause due to swap use, or QPropertyAnimation issue, however we (you 
> KDE defs and i *like a user*) wants plasmashell and it's components (like 
> panel) to works *forever*
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.h 2ea8af9 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
> 
> Diff: https://git.reviewboard.kde.org/r/126870/diff/
> 
> 
> Testing
> ---
> 
> Workaround is quite simple:
> Animation is refreshed as is, pointer hasn't same lifetime as panel
> + Animation is disabled if compositing is not active
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126841: Use PlasmaCore.IconItem in Kicker, Kickoff and Folder View

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126841/#review91528
---


Ship it!




Ship It!

- Eike Hein


On Jan. 22, 2016, 11:28 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126841/
> ---
> 
> (Updated Jan. 22, 2016, 11:28 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Use PlasmaCore.IconItem with disabled animations and Plasma icon theme 
> overlay when used to display app or folder icons.
> 
> 
> Diffs
> -
> 
>   applets/kicker/package/contents/ui/ItemGridDelegate.qml fd9f5d3 
>   applets/kicker/package/contents/ui/ItemListDelegate.qml 17925ae 
>   applets/kickoff/package/contents/ui/KickoffItem.qml 98e19f9 
>   containments/desktop/package/contents/ui/FolderItemDelegate.qml 6aaa361 
>   containments/desktop/package/contents/ui/UpButtonItem.qml 83efe73 
> 
> Diff: https://git.reviewboard.kde.org/r/126841/diff/
> 
> 
> Testing
> ---
> 
> Uses exactly the same icons as before + uses correct color scheme for 
> monochrome icons.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[David Edmundson]

> On Jan. 24, 2016, 2:43 p.m., David Edmundson wrote:
> > >Continous usage, read as suspend/resume/use and so on, cause *cool* 
> > >tooltip animation transition between item to decrease it permormance
> > 
> > Why does QPropertyAnimation decrease in performance after suspend/restore?
> > 
> > Other than the KWindowSystem change I don't see what this is going to 
> > alter. You're removing a QPropertyAnimation when it's unused, which won't 
> > make a difference as it'll be unused anyway.
> 
> Anthony Fieroni wrote:
> It's not only 1 circle suspend/resume, it's couple of days. I cannot say 
> QPropertyAnimation is buggy, but i see it allocated once and lifetime is same 
> as panel, read fps are dropped in some summy day :) At same sunny day if you 
> add new panel, animation is great on newly panel with fresh 
> QPropertyAnimation allocated pointer, so let *refresh* the pointer :)

Do you have a link to the Qt bug for QPropertyAnimation?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/#review91521
---


On Jan. 24, 2016, 3:20 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126870/
> ---
> 
> (Updated Jan. 24, 2016, 3:20 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Bugs: 354353
> http://bugs.kde.org/show_bug.cgi?id=354353
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
> animation transition between item to decrease it permormance and looks quite 
> ugly. If add new panel animation is *cool* as is. The perfermonce decrease 
> can be cause due to swap use, or QPropertyAnimation issue, however we (you 
> KDE defs and i *like a user*) wants plasmashell and it's components (like 
> panel) to works *forever*
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.h 2ea8af9 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
> 
> Diff: https://git.reviewboard.kde.org/r/126870/diff/
> 
> 
> Testing
> ---
> 
> Workaround is quite simple:
> Animation is refreshed as is, pointer hasn't same lifetime as panel
> + Animation is disabled if compositing is not active
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/
---

(Updated Ян. 24, 2016, 5:20 след обяд)


Review request for KDE Frameworks, Plasma and David Edmundson.


Bugs: 354353
http://bugs.kde.org/show_bug.cgi?id=354353


Repository: plasma-framework


Description
---

Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
animation transition between item to decrease it permormance and looks quite 
ugly. If add new panel animation is *cool* as is. The perfermonce decrease can 
be cause due to swap use, or QPropertyAnimation issue, however we (you KDE defs 
and i *like a user*) wants plasmashell and it's components (like panel) to 
works *forever*


Diffs (updated)
-

  src/declarativeimports/core/tooltip.cpp a5e223b 
  src/declarativeimports/core/tooltipdialog.h 2ea8af9 
  src/declarativeimports/core/tooltipdialog.cpp 6c3712e 

Diff: https://git.reviewboard.kde.org/r/126870/diff/


Testing
---

Workaround is quite simple:
Animation is refreshed as is, pointer hasn't same lifetime as panel
+ Animation is disabled if compositing is not active


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[Anthony Fieroni]

> On Ян. 24, 2016, 4:43 след обяд, David Edmundson wrote:
> > src/declarativeimports/core/tooltipdialog.cpp, line 184
> > 
> >
> > You now have a a boolean and a potential null pointer both indicating 
> > the same thing. Data duplication is generally bad.

Potentially you're right.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/#review91521
---


On Ян. 24, 2016, 4:08 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126870/
> ---
> 
> (Updated Ян. 24, 2016, 4:08 след обяд)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Bugs: 354353
> http://bugs.kde.org/show_bug.cgi?id=354353
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
> animation transition between item to decrease it permormance and looks quite 
> ugly. If add new panel animation is *cool* as is. The perfermonce decrease 
> can be cause due to swap use, or QPropertyAnimation issue, however we (you 
> KDE defs and i *like a user*) wants plasmashell and it's components (like 
> panel) to works *forever*
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.h 2ea8af9 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
> 
> Diff: https://git.reviewboard.kde.org/r/126870/diff/
> 
> 
> Testing
> ---
> 
> Workaround is quite simple:
> Animation is refreshed as is, pointer hasn't same lifetime as panel
> + Animation is disabled if compositing is not active
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[Anthony Fieroni]

> On Ян. 24, 2016, 4:43 след обяд, David Edmundson wrote:
> > >Continous usage, read as suspend/resume/use and so on, cause *cool* 
> > >tooltip animation transition between item to decrease it permormance
> > 
> > Why does QPropertyAnimation decrease in performance after suspend/restore?
> > 
> > Other than the KWindowSystem change I don't see what this is going to 
> > alter. You're removing a QPropertyAnimation when it's unused, which won't 
> > make a difference as it'll be unused anyway.

It's not only 1 circle suspend/resume, it's couple of days. I cannot say 
QPropertyAnimation is buggy, but i see it allocated once and lifetime is same 
as panel, read fps are dropped in some summy day :) At same sunny day if you 
add new panel, animation is great on newly panel with fresh QPropertyAnimation 
allocated pointer, so let *refresh* the pointer :)


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/#review91521
---


On Ян. 24, 2016, 4:08 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126870/
> ---
> 
> (Updated Ян. 24, 2016, 4:08 след обяд)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Bugs: 354353
> http://bugs.kde.org/show_bug.cgi?id=354353
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
> animation transition between item to decrease it permormance and looks quite 
> ugly. If add new panel animation is *cool* as is. The perfermonce decrease 
> can be cause due to swap use, or QPropertyAnimation issue, however we (you 
> KDE defs and i *like a user*) wants plasmashell and it's components (like 
> panel) to works *forever*
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.h 2ea8af9 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
> 
> Diff: https://git.reviewboard.kde.org/r/126870/diff/
> 
> 
> Testing
> ---
> 
> Workaround is quite simple:
> Animation is refreshed as is, pointer hasn't same lifetime as panel
> + Animation is disabled if compositing is not active
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/#review91521
---



>Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
>animation transition between item to decrease it permormance

Why does QPropertyAnimation decrease in performance after suspend/restore?

Other than the KWindowSystem change I don't see what this is going to alter. 
You're removing a QPropertyAnimation when it's unused, which won't make a 
difference as it'll be unused anyway.


src/declarativeimports/core/tooltipdialog.cpp (line 179)


You now have a a boolean and a potential null pointer both indicating the 
same thing. Data duplication is generally bad.


- David Edmundson


On Jan. 24, 2016, 2:08 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126870/
> ---
> 
> (Updated Jan. 24, 2016, 2:08 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Bugs: 354353
> http://bugs.kde.org/show_bug.cgi?id=354353
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
> animation transition between item to decrease it permormance and looks quite 
> ugly. If add new panel animation is *cool* as is. The perfermonce decrease 
> can be cause due to swap use, or QPropertyAnimation issue, however we (you 
> KDE defs and i *like a user*) wants plasmashell and it's components (like 
> panel) to works *forever*
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.h 2ea8af9 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
> 
> Diff: https://git.reviewboard.kde.org/r/126870/diff/
> 
> 
> Testing
> ---
> 
> Workaround is quite simple:
> Animation is refreshed as is, pointer hasn't same lifetime as panel
> + Animation is disabled if compositing is not active
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/
---

Review request for KDE Frameworks, Plasma and David Edmundson.


Bugs: 354353
http://bugs.kde.org/show_bug.cgi?id=354353


Repository: plasma-framework


Description
---

Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
animation transition between item to decrease it permormance and looks quite 
ugly. If add new panel animation is *cool* as is. The perfermonce decrease can 
be cause due to swap use, or QPropertyAnimation issue, however we (you KDE defs 
and i *like a user*) wants plasmashell and it's components (like panel) to 
works *forever*


Diffs
-

  src/declarativeimports/core/tooltip.cpp a5e223b 
  src/declarativeimports/core/tooltipdialog.h 2ea8af9 
  src/declarativeimports/core/tooltipdialog.cpp 6c3712e 

Diff: https://git.reviewboard.kde.org/r/126870/diff/


Testing
---

Workaround is quite simple:
Animation is refreshed as is, pointer hasn't same lifetime as panel
+ Animation is disabled if compositing is not active


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D851: Port kded plugin to json metadata

[heikobecker (Heiko Becker)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWRITED5fd327369bc6: Port kded plugin to json metadata 
(authored by heikobecker).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D851?vs=2062&id=2081#toc

REPOSITORY
  rKWRITED KWriteD

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D851?vs=2062&id=2081

REVISION DETAIL
  https://phabricator.kde.org/D851

AFFECTED FILES
  CMakeLists.txt
  kwrited.cpp
  kwrited.json

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: heikobecker, plasma-devel, arichardson
Cc: arichardson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel