Re: Review Request 126968: Morphingpopups effect, to animate tooltips

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92010
---



I like it, bunch of nitpicky nitpicks below


effects/morphingpopups/package/contents/code/morphingpopups.js (line 48)


Superfluous space



effects/morphingpopups/package/contents/code/morphingpopups.js (lines 95 - 97)


Spaces: (foo) / 2

Also below



effects/morphingpopups/package/contents/code/morphingpopups.js (line 107)


Whitespace



effects/morphingpopups/package/metadata.desktop (line 19)


Remove



effects/morphingpopups/package/metadata.desktop (line 22)


This files doesn't exist :)



libkwineffects/kwinanimationeffect.cpp (line 250)


const?



libkwineffects/kwinanimationeffect.cpp (line 253)


auto



scripting/scriptedeffect.cpp (line 355)


QVector



scripting/scriptedeffect.cpp (lines 359 - 360)


Braces pls

Also below



scripting/scriptedeffect.cpp (lines 363 - 365)


const the list and use range-for


- Kai Uwe Broulik


On Feb. 2, 2016, 8:51 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 nachm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

[Thomas Lübking]

> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote:
> > I just wonder, does this change also fix: 
> > https://bugs.kde.org/show_bug.cgi?id=241557 ?
> > 
> > Also, I have impression that if there's a big difference between the size 
> > of two tooltip window, it will look bad.
> 
> Thomas Lübking wrote:
> No, completely unrelated issue.
> 
> Marco Martin wrote:
> tough it may help, since now blur/contrast do respect the scale factor of 
> windows as well?

My guess is that the correct regions will show up blurred, but they'll show the 
wrong content.
Could you nevertheless turn that part into a commit of its own?


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92000
---


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

[Martin Gräßlin]

> On Feb. 2, 2016, 5:40 p.m., Thomas Lübking wrote:
> > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29
> > 
> >
> > backtrace?
> 
> Martin Gräßlin wrote:
> I just created a test case for it: https://paste.kde.org/pywvjhtx9 and it 
> creates this backtrace: https://paste.kde.org/pcxthpmx3
> 
> It sounds valid to me. It deletes AnimData from JS side and the 
> AnimationEffect than tries to delete it as well. Why JS is allowed to delete 
> it, is not clear to me, though
> 
> Thomas Lübking wrote:
> The problem is the cancel call from the animationEnded emit - this causes 
> an erase of what's the present iterator... which is then erased as well.
> 
> We probably need to harden the lib code itr., but the script is of course 
> wrong:
> a) there's no point in cancelling an animation which has just ended 
> (deleting the property is fine)
> b) to know which animation has ended, the animation needs to be tagged in 
> the metadata
> 
> Martin Gräßlin wrote:
> confirmed, it's the cancel, not the delete

-> https://git.reviewboard.kde.org/r/126975/


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review91965
---


On Feb. 2, 2016, 9:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 9:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

[Marco Martin]

> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote:
> > I just wonder, does this change also fix: 
> > https://bugs.kde.org/show_bug.cgi?id=241557 ?
> > 
> > Also, I have impression that if there's a big difference between the size 
> > of two tooltip window, it will look bad.
> 
> Thomas Lübking wrote:
> No, completely unrelated issue.

tough it may help, since now blur/contrast do respect the scale factor of 
windows as well?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92000
---


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

[Marco Martin]

> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote:
> > effects/morphingpopups/package/contents/code/morphingpopups.js, line 86
> > 
> >
> > a) let's have AnimationEffect::retarget(id, values...)?! - progress is 
> > a private detail of AnimationEffect.
> > if that returns "bool", you also get around the cleanup issue.
> > 
> > b) something tells me the duration should probably shorten in this case?
> 
> Marco Martin wrote:
> will give it a try
> 
> Thomas Lübking wrote:
> I'll have to revisit the animationeffect class anyway because of the 
> segfault and will implement a function to retarget an animation, so you don't 
> have to spend too much time on it.

ok, thanks, I'll wait with this to adapt to the new method when done then


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review91965
---


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126980/#review92037
---




effects/backgroundcontrast/contrast.cpp (line 379)


QPoint pt = shape.boundingRect().topLeft();

rather than calling boundingRect() tiwce.



effects/backgroundcontrast/contrast.cpp (line 381)


you don't have to (and should not) re-assign the value, the returned 
reference if for building call chains like t.scale().translate().map()



effects/backgroundcontrast/contrast.cpp (line 382)


This looks fishy - and QTransform a tiny bit clumsy.

Does this work:

QVector shapeRects = shape.rects();
shape = QRegion(); // clear
foreach (QRect r, shapeRects) {
   r.moveTo(r.x() * data.xScale() + data.xTranslation(),
r.y() * data.yScale() + data.yTranslation());
   r.setWidth(r.width() * data.xScale());
   r.setHeight(r.height() * data.yScale());
   shape |= r;
}

the multiplications might need to be put into qRound or qCeil to avoid 
glitches.

This spares several qregion copies, conversions into and out of painter 
paths and the second shape translation.


- Thomas Lübking


On Feb. 3, 2016, 3:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126980/
> ---
> 
> (Updated Feb. 3, 2016, 3:35 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> related to https://git.reviewboard.kde.org/r/126968/
> this is only the part which adds support for scaled windows to blur and 
> contrast
> 
> 
> Diffs
> -
> 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
> 
> Diff: https://git.reviewboard.kde.org/r/126980/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

[Niall via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349750

Niall  changed:

   What|Removed |Added

 CC||irishgermanzi...@gmail.com

--- Comment #6 from Niall  ---
I can confirm this, I have noticed before but did not consider it as a major
issue as my laptop battery's life is over- effectually making it a desktop at
home.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

[Marco Martin]

> On Feb. 3, 2016, 9:38 a.m., Kai Uwe Broulik wrote:
> > effects/morphingpopups/package/metadata.desktop, line 22
> > 
> >
> > This files doesn't exist :)

i can eventually do it ;)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92010
---


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126092: Konqui based Emotion pack named eKspression

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126092/#review92039
---


Ship it!




Preview for the lazy: http://paste.opensuse.org/view/raw/39a38ece

I think the face-smile-big could still use a bit more "smily" mouth
(it looks like it's about to eat something big).

Other than that, I think it looks great! It's a ship it from me.

Good work!

- Martin Klapetek


On Jan. 28, 2016, 11:21 p.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126092/
> ---
> 
> (Updated Jan. 28, 2016, 11:21 p.m.)
> 
> 
> Review request for Plasma and Andrea Del Sarto.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> The emoticon pack was done by Andrea Del Sarto
> 
> 
> Diffs
> -
> 
>   themes/CMakeLists.txt 657c7fc 
> 
> Diff: https://git.reviewboard.kde.org/r/126092/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> eKspression emoticon pack
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/1054a71a-4c1f-46e4-8d52-cf8bb33653bd__eKspression.zip
> konqui
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/7fc6ede6-9965-43ed-ac5f-937bf380103d__konqui.tar.gz
> kemoticons update
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/28/53d99024-7d23-4194-9894-3e4c8e346329__Kemoticons.tar.gz
> kemoticons update
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/28/0ecd0245-5f2d-4d3d-9928-7f1ad6e04213__Kemoticons.tar.gz
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when KDE is running

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358957

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Kai Uwe Broulik  ---
I think it's just that we don't have an entry for that in Kickoff and the like.
Probably needs to be added in various places.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Martin Graesslin]

On Wednesday, February 3, 2016 4:59:18 PM CET Marco Martin wrote:
> Hi all,
> This is just an idea: since our branding of the desktop offer as "Plasma"
> seems to start to work, but still needs work, one of the first points that
> come to mind speaking about branding is the logo.
> 
> What I'm proposing is to change the K logo on start menus and ksplash (and
> any other place where it makes sense, being plymouth, sddm, various docs
> and websites around..) with the Plasma logo, to make more marketable as a
> stand alone product what our desktop offer is
> Either the current Plasma logo or whatever new shiny logo the VDG comes up
> with if they feel the current one isn't up to scratch.
> I had doubts about this in the past as the K logo is the trademarked one,
> but I'm starting to get convinced the time has come ;)
> 
> Opinions? Comments?

I feel the same. I had concerns about it in the past but now I'm supportive to 
the idea.

So +1

Cheers
Martin



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358957] New: laptop won't hybrid-suspend when KDE is running

[Bas Zoetekouw via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358957

Bug ID: 358957
   Summary: laptop won't hybrid-suspend when KDE is running
   Product: Powerdevil
   Version: 5.4.3
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: b...@debian.org

Even though my laptop supports hybrid-suspend very well, KDE doesn't seem to
want to use it, and there doesn't seem to be a way to configure this.

I'm quite sure hybrid suspend works as expected: "systemctl hybrid-sleep" works
as expected, and after adding "HandleLidSwitch=hybrid-sleep" to
/etc/systemd/logind.conf, the laptop automatically hybrid-sleeps when the lid
is closed.  Unless KDE is running, that is

Note that KDE seems aware that my system supports hybrid sleep:
> bas@miranda]~> qdbus org.freedesktop.PowerManagement 
> /org/freedesktop/PowerManagement 
> org.freedesktop.PowerManagement.CanHybridSuspend
> true

However, there is no way to explicitly specify hybrid-sleep in the config panel
(just sleep and hibernate).  A number of other bug reports seem to indicate
that KDE should automatically shoudl hybrid-sleep instead of sleep, if it is
available, but it is inclear if that was ever implemented.  It doesn't work
here, at least: I've added a script "echo "$(date) $0 $1 $2 >> /tmp/pmlog" to
/lib/systemd/system/sleep/, which clearly shows that systemd is running
"suspend" instead of "hybrid-sleep".

Reproducible: Always

Steps to Reproduce:
1. close laptop lid
2.
3.

Actual Results:  
system suspends

Expected Results:  
system should have hybrid-suspended.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when KDE is running

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358957

--- Comment #2 from Martin Gräßlin  ---
(In reply to Kai Uwe Broulik from comment #1)
> I think it's just that we don't have an entry for that in Kickoff and the
> like. Probably needs to be added in various places.

or maybe use HybridSuspend instead of Suspend if available. I am not sure
whether it makes sense to expose such a fine grained difference to the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

[Luca Beltrame]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126793/#review92041
---



Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see get 
in once all the issues have been addressed. Family members are depending upon 
it. ;)

- Luca Beltrame


On Gen. 18, 2016, 12:27 p.m., Lars Pontoppidan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126793/
> ---
> 
> (Updated Gen. 18, 2016, 12:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> KF5 version of the (Picture) Frame widget
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt ed938f8 
>   applets/mediaframe/CMakeLists.txt PRE-CREATION 
>   applets/mediaframe/Messages.sh PRE-CREATION 
>   applets/mediaframe/package/contents/code/utility.js PRE-CREATION 
>   applets/mediaframe/package/contents/config/config.qml PRE-CREATION 
>   applets/mediaframe/package/contents/config/main.xml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/main.qml PRE-CREATION 
>   applets/mediaframe/package/metadata.desktop PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION 
>   applets/mediaframe/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126793/diff/
> 
> 
> Testing
> ---
> 
> kdeplasma-addons builds on Kubuntu 15.10.
> 
> 
> Thanks,
> 
> Lars Pontoppidan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92023
---




effects/blur/blur.cpp (line 437)


please move data.*Translation() as well as the forth/back translation into 
the QTransform to avoid superflous region operations


- Thomas Lübking


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Martin Klapetek]

On Wed, Feb 3, 2016 at 12:16 PM, Ivan Čukić  wrote:

>
> @Offtopic: What happened to kde.org revamp?
>

>From what I understood, the neon website is supposed to be a proving ground
for the new kde.org.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when KDE is running

[Bas Zoetekouw via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358957

--- Comment #3 from Bas Zoetekouw  ---
Either solution would be fine with me.  If you could point me to the component
in which suspend/hibernate is handled, I could probably come up with a patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

[Marco Martin]

> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote:
> > I just wonder, does this change also fix: 
> > https://bugs.kde.org/show_bug.cgi?id=241557 ?
> > 
> > Also, I have impression that if there's a big difference between the size 
> > of two tooltip window, it will look bad.
> 
> Thomas Lübking wrote:
> No, completely unrelated issue.
> 
> Marco Martin wrote:
> tough it may help, since now blur/contrast do respect the scale factor of 
> windows as well?
> 
> Thomas Lübking wrote:
> My guess is that the correct regions will show up blurred, but they'll 
> show the wrong content.
> Could you nevertheless turn that part into a commit of its own?

here you go: https://git.reviewboard.kde.org/r/126980/


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92000
---


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D884: Async variant to check whether power management is inhibited

[ahartmetz (Andreas Hartmetz)]

ahartmetz added a comment.


  Excellent! That synchronous call might have caused deadlocks before.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D884

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, broulik
Cc: ahartmetz, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Marco Martin]

On Wednesday 03 February 2016 16:24:10 David Edmundson wrote:
> If you mean this one?
> https://dot.kde.org/sites/dot.kde.org/files/plasma-mobile-logo.png
> Sure.
> 
> Anything more radical I'm against as it breaks not only our current
> branding, but all screenshot based tutorials.

the problem is that the current branding is quite broken.
the problem is going the last mile to make people stop saying "I use KDE" :p

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[kainz.a]

it's funny that you discuss about branding and nobody of the plasma dev's
know HIS logo.

so the discussion should not be which logo and why nobody knows the plasma
brand. the question should be we need a brand and therefore we need logos
for defined sizes, banners, community stuff (t-shirt,...) and we need if
for the 5.6 release

so community and vdg come with examples now.

but we can also discuss why nobody don't know the plasma brand. the dev's
don't know there brand to.

cheers
Andreas
Am 03.02.2016 18:52 schrieb "Marco Martin" :

> On Wednesday 03 February 2016 16:24:10 David Edmundson wrote:
> > If you mean this one?
> > https://dot.kde.org/sites/dot.kde.org/files/plasma-mobile-logo.png
> > Sure.
> >
> > Anything more radical I'm against as it breaks not only our current
> > branding, but all screenshot based tutorials.
>
> the problem is that the current branding is quite broken.
> the problem is going the last mile to make people stop saying "I use KDE"
> :p
>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Dirk Hohndel]

On Wed, Feb 03, 2016 at 05:48:40PM +0100, Marco Martin wrote:
> On Wednesday 03 February 2016 16:24:10 David Edmundson wrote:
> > If you mean this one?
> > https://dot.kde.org/sites/dot.kde.org/files/plasma-mobile-logo.png
> > Sure.
> > 
> > Anything more radical I'm against as it breaks not only our current
> > branding, but all screenshot based tutorials.
> 
> the current one is more like
> http://4.bp.blogspot.com/-jwBzU1YZWLI/U8U2E1nDM8I/mfY/jDbBMq9GkP4/s1600/plasma-5-banner.png

As someone with a more "outside" perspective... boy that one is ugly. And
really doesn't provide a lot of "recognizability". I'm running Plasma on
ArchLinux and I see the "K in the gear" logo in the bottom left corner of
my screen; replacing this with the three different sized, oddly spaced
dots and the '>' symbol? Doesn't sound like an improvement in branding to
me.

And if I go to https://www.kde.org/workspaces/plasmadesktop/ I don't see a
consistent brand identity at all. The logo you mention here isn't even on
that site.

My 2¢ would be to come up with a strong logo that is simple and provides a
good connection to Plasma as a brand and then use that consistently
everywhere. But you first need the artwork.

/D
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

libkscreen bugs on Plasma 4

[Sebastian Kügler]

Hi all,

When going over the list of libkscreen bugs, there are some reported against 
Plasma 4. I'm planning to close them as Plasma 4 is unmaintained, and it would 
be dishonest to let people think that we're actually working on it.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: libkscreen bugs on Plasma 4

[David Edmundson]

Makes sense.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Thomas Pfeiffer]

I had wanted to CC the VDG list, but I used the wrong address. Now with the 
correct one.

On Mittwoch, 3. Februar 2016 18:16:01 CET Thomas Pfeiffer wrote:
> On Mittwoch, 3. Februar 2016 16:24:10 CET David Edmundson wrote:
 > If you mean this one?
 > https://dot.kde.org/sites/dot.kde.org/files/plasma-mobile-logo.png
 > Sure.
 
 No, not that one.
 That one: https://upload.wikimedia.org/wikipedia/commons/thumb/9/95/
 KDE_Plasma_5_banner.png/300px-KDE_Plasma_5_banner.png
 
> Not always with the name, of course.
 
 > Anything more radical I'm against as it breaks not only our current
 > branding, but all screenshot based tutorials.
 
 We are currently using the KDE logo with the Plasma brand. This is broken
 branding. If we are to establish Plasma as a brand, we need to use the
 Plasma logo.
 If we keep using the community instead of the product logo all over Plasma,
 we can never break the "KDE = the desktop" misconception.
 
 And I'm pretty sure people will still recognize that they're using the same
 workspace as shown in tutorials even if the logo in the bottom-left corner
 is different.
 
 The VDG is really clear that this is our collective advice (I've CCed the
 VDG list so anybody who objects to that could speak up).



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Ivan Čukić]

> If you mean this one?
> https://dot.kde.org/sites/dot.kde.org/files/plasma-mobile-logo.png
> Sure.

This one I'm really against. Every time someone posts it (especially
the colured version), a fairy dies. For those of you that do not
believe in fairies, just imagine kittens dying. :)

> Anything more radical I'm against as it breaks not only our current
> branding, but all screenshot based tutorials.

> the current one is more like
> http://4.bp.blogspot.com/-jwBzU1YZWLI/U8U2E1nDM8I/mfY/jDbBMq9GkP4/s1600/plasma-5-banner.png

This one is more pleasant on the eyes, but I share David's concerns.

Cheers,
Ivan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Thomas Pfeiffer]

On Mittwoch, 3. Februar 2016 16:24:10 CET David Edmundson wrote:
> If you mean this one?
> https://dot.kde.org/sites/dot.kde.org/files/plasma-mobile-logo.png
> Sure.

No, not that one. 
That one: https://upload.wikimedia.org/wikipedia/commons/thumb/9/95/
KDE_Plasma_5_banner.png/300px-KDE_Plasma_5_banner.png

Not always with the name, of course.

> Anything more radical I'm against as it breaks not only our current
> branding, but all screenshot based tutorials.

We are currently using the KDE logo with the Plasma brand. This is broken 
branding. If we are to establish Plasma as a brand, we need to use the Plasma 
logo.
If we keep using the community instead of the product logo all over Plasma, we 
can never break the "KDE = the desktop" misconception.

And I'm pretty sure people will still recognize that they're using the same 
workspace as shown in tutorials even if the logo in the bottom-left corner is 
different.

The VDG is really clear that this is our collective advice (I've CCed the VDG 
list so anybody who objects to that could speak up).

Cheers,
Thomas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Marco Martin]

On Wednesday 03 February 2016 09:10:06 Dirk Hohndel wrote:
> > http://4.bp.blogspot.com/-jwBzU1YZWLI/U8U2E1nDM8I/mfY/jDbBMq9GkP4/
> > s1600/plasma-5-banner.png
> As someone with a more "outside" perspective... boy that one is ugly. And
> really doesn't provide a lot of "recognizability". I'm running Plasma on

 "outside" perspective that makes it very, very valuable.

> ArchLinux and I see the "K in the gear" logo in the bottom left corner of
> my screen; replacing this with the three different sized, oddly spaced
> dots and the '>' symbol? Doesn't sound like an improvement in branding to
> me.

yep, if we replace the old "k with gear" it must be a really good one

> And if I go to https://www.kde.org/workspaces/plasmadesktop/ I don't see a
> consistent brand identity at all. The logo you mention here isn't even on
> that site.
> 
> My 2¢ would be to come up with a strong logo that is simple and provides a
> good connection to Plasma as a brand and then use that consistently
> everywhere. But you first need the artwork.

yep, you identified another important thing.. our web presence situation is 
quite ugh, outdated :/


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126961/
---

(Updated Feb. 3, 2016, 5:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 5a1a411b41f950e97d80ff7c898052fb6d02fb1a by David 
Edmundson to branch master.


Bugs: 351777
https://bugs.kde.org/show_bug.cgi?id=351777


Repository: plasma-workspace


Description
---

We were mixing KScreen and QScreen API badly.

Corona.cpp checks we are requesting a containment for a valid screen
if (screen >= 0 && screen < numScreens()) {

This fails as numScreens() is Qt API based, whereas the signal we're
adding the output for is ShellCorona::addOutput so we have an effective race 
condition.

BUG: 351777


Diffs
-

  shell/shellcorona.cpp 762e503bf59fe648fb0f5b76a36229aa43c563e5 

Diff: https://git.reviewboard.kde.org/r/126961/diff/


Testing
---

Started Plasma on dual screen.

Ideally we need to do more testing before backporting, as that entire codebase 
is a disgrace.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126980/
---

Review request for kwin and Plasma.


Repository: kwin


Description
---

related to https://git.reviewboard.kde.org/r/126968/
this is only the part which adds support for scaled windows to blur and contrast


Diffs
-

  effects/backgroundcontrast/contrast.cpp 168deb0 
  effects/blur/blur.cpp a360f03 

Diff: https://git.reviewboard.kde.org/r/126980/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: libkscreen bugs on Plasma 4

[Aleix Pol]

On Tue, Feb 2, 2016 at 4:01 PM, Sebastian Kügler  wrote:
> Hi all,
>
> When going over the list of libkscreen bugs, there are some reported against
> Plasma 4. I'm planning to close them as Plasma 4 is unmaintained, and it would
> be dishonest to let people think that we're actually working on it.

+1

I've seen some of those as well. I agree.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Bugs - a stricter approach

[Martin Klapetek]

On Mon, Feb 1, 2016 at 4:49 PM, David Edmundson 
wrote:

>
> Bugs are the most important part of making a quality product, which is our
> ultimate goal. Bug triage and fixing is a crucial part of being a
> maintainer. You can't just cherry-pick the fun bits.
>

At the same time, let's please not make this about the numbers.
I regularly see bugs closed as wrong duplicates, which in the end
does not help the user at all, it only helps to keep our bug count down.

Let's try to raise the quality of our handling too, not only quantity.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Ivan Čukić]

> And if I go to https://www.kde.org/workspaces/plasmadesktop/ I don't see

UGH, that *still* shows plasma 4.x :D

Cheers,
Ivan

@Offtopic: What happened to kde.org revamp?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[kainz.a]

2016-02-03 19:25 GMT+01:00 Ivan Čukić :

> p.s. Mind that when people say 'I use KDE', they usually think they
> are using Plasma, Dolphin, KTp, Okular, Konsole, etc. One of the
> /problems/ is that Linux users are spoilt, and started to consider all
> the default applications as a part of the operating system - from the
> desktop, to music players and office suites. So, having KDE logo
> instead of Plasma logo is not that wrong IMO.
>
>
so the easy way would say plasma is part of KDE (which is "only" the
community but nobody knows it) and in most distros the branding was
replaced by there branding.

So we only have to say the users plasma is part of KDE. oh now. the users
already know's that he/she use KDE. everything done. It's a little bit
sarcastic but it the end I don't have a problem to use the KDE desktop.

So are you (plasma mailing list member) part of KDE? YES
Do you develop the KDE Desktop or are you a developer of Plasma?
Are you proud to develop plasma as part of the KDE Community and want to
say I'm part of Plasma, than we need a rebrand. And rebrand mean you have
to define your requirements (what do you need, icons, logo, which sizes,
...)

+1 for Plasma brand
+ a for KDE brand

cheers

Andreas Kainz
Member of the VDG

Is VDG part of plasma or KDE?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Marco Martin]

On Wednesday 03 February 2016 16:24:10 David Edmundson wrote:
> If you mean this one?
> https://dot.kde.org/sites/dot.kde.org/files/plasma-mobile-logo.png
> Sure.
> 
> Anything more radical I'm against as it breaks not only our current
> branding, but all screenshot based tutorials.
> 
> David

the current one is more like
http://4.bp.blogspot.com/-jwBzU1YZWLI/U8U2E1nDM8I/mfY/jDbBMq9GkP4/s1600/plasma-5-banner.png

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349750

--- Comment #7 from Martin Klapetek  ---
Does not happen for me anymore.

Niall - what's your plasma version?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Ivan Čukić]

@Marco
> the problem is going the last mile to make people stop
> saying "I use KDE" :p

I'm not sure this warrants killing what we have now. As someone
mentioned before, we are not the only ones using a community/company
logo for this.

I would like a nicer KDE logo (like Gnome people did back in the day -
reshaped the foot to look saner... though, there is not much one can
do with a gear :) ), but that is another story.


@Kainz
> nobody of the plasma dev's know HIS logo.

"nobody" is a bit misguiding - most of us knew the .:> logo but I get
your point. :)


@Martin
> From what I understood, the neon website is supposed to be a proving
> ground for the new kde.org.

Thanks for the info - it looks quite nice.

Cheerio,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Ivan Čukić]

p.s. Mind that when people say 'I use KDE', they usually think they
are using Plasma, Dolphin, KTp, Okular, Konsole, etc. One of the
/problems/ is that Linux users are spoilt, and started to consider all
the default applications as a part of the operating system - from the
desktop, to music players and office suites. So, having KDE logo
instead of Plasma logo is not that wrong IMO.

Cheerio,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[David Edmundson]

If you mean this one?
https://dot.kde.org/sites/dot.kde.org/files/plasma-mobile-logo.png
Sure.

Anything more radical I'm against as it breaks not only our current
branding, but all screenshot based tutorials.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

RFC: plasma logo as start menu icon and ksplash logo

[Marco Martin]

Hi all,
This is just an idea: since our branding of the desktop offer as "Plasma" seems 
to start to work, but still needs work, one of the first points that come to 
mind speaking about branding is the logo.

What I'm proposing is to change the K logo on start menus and ksplash (and any 
other place where it makes sense, being plymouth, sddm, various docs and 
websites around..) with the Plasma logo, to make more marketable as a stand 
alone product what our desktop offer is
Either the current Plasma logo or whatever new shiny logo the VDG comes up 
with if they feel the current one isn't up to scratch.
I had doubts about this in the past as the K logo is the trademarked one, but 
I'm starting to get convinced the time has come ;)

Opinions? Comments?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel