date:20160204

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92073
---



This diff doesn't seem to have the week days row changes?

- Martin Klapetek


On Feb. 5, 2016, 12:19 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 5, 2016, 12:19 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QWeakPointer error in DrKonqi

2016-02-04 Thread Aleix Pol

On Thu, Feb 4, 2016 at 7:19 PM, René J.V.  wrote:
> Hi,
>
> Is DrKonqi under active maintenance? I'm in the process of getting it (and a 
> few select other things from plasma-workspace) to build on OS X and I'm 
> seeing errors that should have nothing to do with "Plasma isn't supposed to 
> work here" :
>
> 1) an error initialising a QWeakPointer from a QFileDialog*; 
> following the Qt 5.5.1 docs as below corrects that (I don't know yet if it 
> runs OK):
> -QWeakPointer dlg = new QFileDialog(parent, defname);
> +QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent, defname));
>
>
> 2) plasma-workspace-5.5.4/drkonqi/bugzillaintegration/bugzillalib.cpp:148:22: 
> error:
>   no member named 'fromAscii' in 'QString'
> QString::fromAscii(id));
> ~^
> plasma-workspace-5.5.4/drkonqi/bugzillaintegration/bugzillalib.cpp:249:57: 
> error:
>   no member named 'fromAscii' in 'QString'
> args.insert(QLatin1String("content_type"), 
> QString::fromAscii("text/plain"));
>~^
>
> Both appear to be errors that could stem from not having been updated for Qt 
> 5.5, hence my question about active maintenance.

Maybe you can provide the fixes in the shape of a review request? I'm
sure that if somebody found this they would have fixed it before.

I really have no idea why these issues didn't pop up on my set up but
did on yours anyway.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik



> On Feb. 4, 2016, 11:24 nachm., Heiko Tietze wrote:
> > File Attachment: How about this? #2 - How about this? #2
> > 
> >
> > Bug 299174 - Remove "week number" from system tray calendar for 
> > improved readability 
> > 
> > https://bugs.kde.org/show_bug.cgi?id=299174
> > 
> > (I disagree with the idea to remove it. But some ideas have been 
> > stressed in this thread.)

You're aware that week numbers in the calendar are optional and turned off by 
default and were only re-introduced after frequent user complaints.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92071
---


On Feb. 4, 2016, 11:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Heiko Tietze


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92071
---




File Attachment: How about this? #2 - How about this? #2


Bug 299174 - Remove "week number" from system tray calendar for improved 
readability 

https://bugs.kde.org/show_bug.cgi?id=299174

(I disagree with the idea to remove it. But some ideas have been stressed 
in this thread.)


- Heiko Tietze


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Andreas Kainz


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92070
---


Ship it!




Ship It!

- Andreas Kainz


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/
---

(Updated Feb. 4, 2016, 11:19 nachm.)


Review request for Plasma and KDE Usability.


Changes
---

Screenshots for larger week day names.


Bugs: 336124, 348362 and 358536
http://bugs.kde.org/show_bug.cgi?id=336124
http://bugs.kde.org/show_bug.cgi?id=348362
http://bugs.kde.org/show_bug.cgi?id=358536


Repository: plasma-framework


Description
---

This removes the custom label-based triangles and replaces them with proper 
ToolButtons using proper icons. It also adds a "Today" button to return to the 
current day. Also, tooltips that reflect the actual action ("Previous Month", 
"Previous Year", "Previous Decade", depending on the zoom level) were added.


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
  src/declarativeimports/calendar/qml/MonthView.qml c876e3b 

Diff: https://git.reviewboard.kde.org/r/126960/diff/


Testing
---

Works.

The weekday names look a bit awkward now


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
How about this?
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
How about this? #2
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Andreas Kainz



> On Feb. 2, 2016, 12:37 a.m., Andrew Lake wrote:
> > Nice improvement. If the week numbers look ok then +1 from me.
> 
> Kai Uwe Broulik wrote:
> I need some inspiration for how to align the week names, though.
> 
> The more I look at it now the better I like it. I tried vertically 
> centering them but that looks awful. On the other hand I really don't want to 
> touch the grid painting code (eg. reduce the height of that row)

in the existing plasmoid the week names where to small and when you make the 
plasmoid really big they doesn't scale well. can you use the same size than for 
the days and vertical align bottom horizontal align center as it is now. And I 
miss the screenshot with the week name. In addition does the plasmoid work in 
an sidebar panel (minimum size).


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91907
---


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik



> On Feb. 2, 2016, 12:37 vorm., Andrew Lake wrote:
> > Nice improvement. If the week numbers look ok then +1 from me.

I need some inspiration for how to align the week names, though.

The more I look at it now the better I like it. I tried vertically centering 
them but that looks awful. On the other hand I really don't want to touch the 
grid painting code (eg. reduce the height of that row)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91907
---


On Feb. 1, 2016, 11:12 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124397: Add today button to calendar

2016-02-04 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review92067
---



And sorry for keeping you hanging there for so long :)

- Kai Uwe Broulik


On Feb. 4, 2016, 8:30 nachm., Bernhard Friedreich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124397/
> ---
> 
> (Updated Feb. 4, 2016, 8:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 348362
> http://bugs.kde.org/show_bug.cgi?id=348362
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add button "Select Today" to calendar title bar
> 
> BUG: 348362
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 
> 35a1e202ced1c050479ed04d71d8976a4e03a12c 
> 
> Diff: https://git.reviewboard.kde.org/r/124397/diff/
> 
> 
> Testing
> ---
> 
> plasmoidviewer with digitalclock plasmoid
> added digitalclock plasmoid to desktop
> 
> clicked digital clock plasmoid to view calendar
> "Select Today" button is shown
> select different day
> clicked button -> selection changes to today
> moved to another month/month selection/year/year selection -> clicked button 
> --> jumps to today
> 
> 
> File Attachments
> 
> 
> Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126952: Set layout in kickoff config properly

2016-02-04 Thread David Edmundson



> On Feb. 2, 2016, 9:29 a.m., Marco Martin wrote:
> > applets/kickoff/package/contents/ui/ConfigGeneral.qml, line 39
> > 
> >
> > maybe look and feel package?

right, but all I'm changing here is the indentation so I don't want to adjust 
that it in this patch.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126952/#review91931
---


On Feb. 1, 2016, 11:20 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126952/
> ---
> 
> (Updated Feb. 1, 2016, 11:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Existing layout wasn't bound to anything so no labels would clip if they
> got too wide. We were just lucky all text was short.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 
> aa345a508cc9da5c148b6237d4446627cd6656a1 
> 
> Diff: https://git.reviewboard.kde.org/r/126952/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 13 lines] D908: [Baloo Runner] Add mime data to matches

2016-02-04 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added reviewers: Plasma, vhanda.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  Allows to drag and drop around found files.
  
  BUG: 249621

TEST PLAN
  Successfully dropped a bunch of music files, pictures, and documents from 
KRunner to my desktop

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D908

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp
  runners/baloo/baloosearchrunner.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, vhanda
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124397: Add today button to calendar

2016-02-04 Thread Bernhard Friedreich


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/
---

(Updated Feb. 4, 2016, 8:30 nachm.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Bugs: 348362
http://bugs.kde.org/show_bug.cgi?id=348362


Repository: plasma-framework


Description
---

Add button "Select Today" to calendar title bar

BUG: 348362


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml 
35a1e202ced1c050479ed04d71d8976a4e03a12c 

Diff: https://git.reviewboard.kde.org/r/124397/diff/


Testing
---

plasmoidviewer with digitalclock plasmoid
added digitalclock plasmoid to desktop

clicked digital clock plasmoid to view calendar
"Select Today" button is shown
select different day
clicked button -> selection changes to today
moved to another month/month selection/year/year selection -> clicked button 
--> jumps to today


File Attachments


Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png


Thanks,

Bernhard Friedreich

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D904: [Baloo Runner] Allow opening parent folder

2016-02-04 Thread broulik (Kai Uwe Broulik)

broulik updated the test plan for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D904

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, vhanda
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 23 lines] D904: [Baloo Runner] Allow opening parent folder

2016-02-04 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added reviewers: Plasma, vhanda.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  This allows opening the folder a file is located.
  
  BUG: 340302

TEST PLAN
  I'm not sure if I used the actionsForMatch API correctly, Also, looks a tad 
awful with all those folder icons; perhaps we should use half opacity for the 
runner actions?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D904

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp
  runners/baloo/baloosearchrunner.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, vhanda
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D902: [DesktopView] Allow Shift modifier for triggering KRunner

2016-02-04 Thread mart (Marco Martin)

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D902

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D901: [KRunner] Use time-based sorting rather than length for auto-completion

2016-02-04 Thread mck182 (Martin Klapetek)

mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.


  Well that was easy :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D901

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, mck182
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2 lines] D902: [DesktopView] Allow Shift modifier for triggering KRunner

2016-02-04 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  We were rejecting all key presses that had modifier in it, this included 
upper-case letters because of Shift being pressed.
  
  Accept keys where *only* the Shift modifier is pressed, too.
  
  BUG: 353959

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D902

AFFECTED FILES
  shell/desktopview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 24 lines] D901: [KRunner] Use time-based sorting rather than length for auto-completion

2016-02-04 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added reviewers: Plasma, mck182.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  This makes more recently typed queries take precedence over older ones.
  
  BUG: 358985

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D901

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, mck182
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

QWeakPointer error in DrKonqi

2016-02-04 Thread René J . V . Bertin

Hi,

Is DrKonqi under active maintenance? I'm in the process of getting it (and a 
few select other things from plasma-workspace) to build on OS X and I'm seeing 
errors that should have nothing to do with "Plasma isn't supposed to work here" 
:

1) an error initialising a QWeakPointer from a QFileDialog*; 
following the Qt 5.5.1 docs as below corrects that (I don't know yet if it runs 
OK):
-QWeakPointer dlg = new QFileDialog(parent, defname);
+QWeakPointer dlg = QSharedPointer(new 
QFileDialog(parent, defname));


2) plasma-workspace-5.5.4/drkonqi/bugzillaintegration/bugzillalib.cpp:148:22: 
error: 
  no member named 'fromAscii' in 'QString'
QString::fromAscii(id));
~^
plasma-workspace-5.5.4/drkonqi/bugzillaintegration/bugzillalib.cpp:249:57: 
error: 
  no member named 'fromAscii' in 'QString'
args.insert(QLatin1String("content_type"), 
QString::fromAscii("text/plain"));
   ~^

Both appear to be errors that could stem from not having been updated for Qt 
5.5, hence my question about active maintenance.

Thanks,
R.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 55 - Still Failing!

2016-02-04 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/55/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 04 Feb 2016 17:12:17 +
Build duration: 1 min 45 sec

CHANGE SET
Revision 5962f0602ecbe8c27c3dd02195d77948b012cc85 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit plasmawayland.desktop.cmake
Revision 4730bbaee97c65a61ca8e8adddc0811102476902 by Jonathan Riddell: (Update 
version number for 5.5.90 GIT_SILENT)
  change: edit CMakeLists.txt
Revision 1667eaf6c82a6bd727c41c40795087f2f4fac66e by Marco Martin: (set dialogs 
location according to containments)
  change: edit applets/lock_logout/contents/ui/lockout.qml
Revision de5ed6c4cdded1f2ba2ce43022be1d1a9b475bf0 by Alex Richardson: (Make 
networkmanager-qt an optional dependency)
  change: edit dataengines/CMakeLists.txt
  change: edit CMakeLists.txt
Revision d4a3f0906d4baf89977b3819e7595c65171da740 by Hrvoje Senjan: (Make 
geolocation engine build again when networkmanager-qt is there)
  change: edit dataengines/CMakeLists.txt
Revision c662902c17f8632432d488c936bf660b5a290ff7 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit xembed-sni-proxy/xembedsniproxy.desktop
Revision 57157834c747305bd4ae819227d604c7c25e6d5c by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit xembed-sni-proxy/xembedsniproxy.desktop
Revision 2fbe27fed25de823e257d852b7bfe8908bfdc107 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit xembed-sni-proxy/xembedsniproxy.desktop
Revision 0059d87b6f74f950b2aac94763c2934ec710c6c4 by jkt: (Do not produce 
negative struts on switching screens)
  change: edit shell/panelview.cpp
Revision af1122076dc46f4a410d6e4d6d88487f5b4cf7a3 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kioslave/desktop/directory.trash
  change: edit kioslave/desktop/desktopnotifier.desktop
  change: edit kioslave/desktop/Home.desktop
  change: edit klipper/org.kde.klipper.desktop
Revision 39730416663ec01ae44f78b140bde4fd22473930 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
containmentactions/switchwindow/plasma-containmentactions-switchwindow.desktop
  change: edit plasma.desktop.cmake
  change: edit dataengines/share/backends/im9/metadata.desktop
  change: edit dataengines/geolocation/plasma-geolocation-ip.desktop
  change: edit dataengines/mouse/plasma-dataengine-mouse.desktop
  change: edit 
containmentactions/contextmenu/plasma-containmentactions-contextmenu.desktop
  change: edit dataengines/keystate/plasma-dataengine-keystate.desktop
  change: edit runners/recentdocuments/recentdocuments.desktop
  change: edit applets/systemtray/package/metadata.desktop
  change: edit 
containmentactions/switchactivity/plasma-containmentactions-switchactivity.desktop
  change: edit dataengines/filebrowser/plasma-dataengine-filebrowser.desktop
  change: edit dataengines/share/backends/pasteopensuseorg/metadata.desktop
  change: edit applets/activitybar/metadata.desktop
  change: edit dataengines/dict/plasma-dataengine-dict.desktop
  change: edit dataengines/rss/plasma-dataengine-rss.desktop
  change: edit dataengines/apps/plasma-dataengine-apps.desktop
  change: edit dataengines/packagekit/plasma-dataengine-packagekit.desktop
  change: edit applets/systemmonitor/diskusage/metadata.desktop
  change: edit dataengines/geolocation/plasma-geolocation-gps.desktop
  change: edit dataengines/akonadi/plasma-engine-akonadi.desktop
  change: edit dataengines/favicons/plasma-dataengine-favicons.desktop
  change: edit dataengines/geolocation/plasma-geolocationprovider.desktop
  change: edit applets/digital-clock/package/metadata.desktop
  change: edit applets/systemmonitor/net/metadata.desktop
  change: edit kioslave/desktop/desktopnotifier.desktop
  change: edit dataengines/network/plasma-dataengine-network.desktop
  change: edit applets/clipboard/metadata.desktop
  change: edit applets/systemmonitor/cpu/metadata.desktop
  change: edit freespacenotifier/freespacenotifier.notifyrc
  change: edit applets/systemmonitor/memory/metadata.desktop
  change: edit 
containmentactions/applauncher/plasma-containmentactions-applauncher.desktop
  change: edit 
containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.desktop
  change: edit plasma-windowed/plasma-windowed.desktop
  change: edit applets/devicenotifier/package/metadata.desktop
  change: edit dataengines/places/plasma-dataengine-places.desktop
  change: edit containmentactions/paste/plasma-containmentactions-paste.desktop
  change: edit applets/panelspacer/metadata.desktop
  change: edit dataengines/calendar/plasma-dataengine-calendar.desktop
  change: edit 
dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop
  change: edit runners/kill/plasma-runner-

[Differential] [Closed] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE4819282d329f: [notifications] Make the text 
selectable in the popup too (authored by mck182).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D899?vs=2192&id=2193

REVISION DETAIL
  https://phabricator.kde.org/D899

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mck182, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mart (Marco Martin)

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  mklapetek/selectableTextInNotifications

REVISION DETAIL
  https://phabricator.kde.org/D899

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mck182, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 128 lines] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)

mck182 updated this revision to Diff 2192.
mck182 added a comment.


  Keep the MouseArea visible always as it pushes the action buttons to the side

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D899?vs=2190&id=2192

BRANCH
  mklapetek/selectableTextInNotifications

REVISION DETAIL
  https://phabricator.kde.org/D899

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mck182, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)

mck182 added a reviewer: Plasma.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D899

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mck182, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 128 lines] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)

mck182 created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  This simplifies the component by removing the Loader-property combo and
  leaves just a read-only TextEdit
  
  BUG: 358981

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  mklapetek/selectableTextInNotifications

REVISION DETAIL
  https://phabricator.kde.org/D899

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mck182
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson



> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote:
> > FYI, This may not entirely work as 
> > https://bugs.kde.org/show_bug.cgi?id=358869 shows
> 
> David Edmundson wrote:
> ack, there's a new message that we're not catching.
> 
> I don't know what the string is though.
> 
> Martin Klapetek wrote:
> I was thinking we could maybe check the GL version ourselves at the very 
> start?
> There's a glXQueryVersion function for it. That would effectively catch 
> all these
> crashes on no GL..?
> 
> Martin Gräßlin wrote:
> you can find the new string in 
> http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/items/qquickwindow.cpp?h=v5.5.1#n2566
> 
> But there seems to be a better way according to 
> http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/scenegraph/qsgrenderloop.cpp?h=v5.5.1#n233
> 
> Apparently we can get a signal on the QQuickWindow.
> 
> David Edmundson wrote:
> Worth looking into, definitely.
> 
> Though I don't know if a version check will catch the nvidia problem. The 
> library will return something valid till you try to actually make some ioctl 
> call to the missing kernel module.
> 
> With regards to version checking, Fedora have an interesting patch they 
> do with openGL version checks. See https://bugs.kde.org/show_bug.cgi?id=357755

@Martin
OOoooh, that's way better. ++


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review92059
---


On Aug. 1, 2015, 12:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> ---
> 
> (Updated Aug. 1, 2015, 12:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with 
> Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> ---
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the 
> same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson



> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote:
> > FYI, This may not entirely work as 
> > https://bugs.kde.org/show_bug.cgi?id=358869 shows
> 
> David Edmundson wrote:
> ack, there's a new message that we're not catching.
> 
> I don't know what the string is though.
> 
> Martin Klapetek wrote:
> I was thinking we could maybe check the GL version ourselves at the very 
> start?
> There's a glXQueryVersion function for it. That would effectively catch 
> all these
> crashes on no GL..?
> 
> Martin Gräßlin wrote:
> you can find the new string in 
> http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/items/qquickwindow.cpp?h=v5.5.1#n2566
> 
> But there seems to be a better way according to 
> http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/scenegraph/qsgrenderloop.cpp?h=v5.5.1#n233
> 
> Apparently we can get a signal on the QQuickWindow.

Worth looking into, definitely.

Though I don't know if a version check will catch the nvidia problem. The 
library will return something valid till you try to actually make some ioctl 
call to the missing kernel module.

With regards to version checking, Fedora have an interesting patch they do with 
openGL version checks. See https://bugs.kde.org/show_bug.cgi?id=357755


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review92059
---


On Aug. 1, 2015, 12:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> ---
> 
> (Updated Aug. 1, 2015, 12:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with 
> Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> ---
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the 
> same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Gräßlin



> On Feb. 4, 2016, 3:26 p.m., Martin Klapetek wrote:
> > FYI, This may not entirely work as 
> > https://bugs.kde.org/show_bug.cgi?id=358869 shows
> 
> David Edmundson wrote:
> ack, there's a new message that we're not catching.
> 
> I don't know what the string is though.
> 
> Martin Klapetek wrote:
> I was thinking we could maybe check the GL version ourselves at the very 
> start?
> There's a glXQueryVersion function for it. That would effectively catch 
> all these
> crashes on no GL..?

you can find the new string in 
http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/items/qquickwindow.cpp?h=v5.5.1#n2566

But there seems to be a better way according to 
http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/scenegraph/qsgrenderloop.cpp?h=v5.5.1#n233

Apparently we can get a signal on the QQuickWindow.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review92059
---


On Aug. 1, 2015, 2:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> ---
> 
> (Updated Aug. 1, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with 
> Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> ---
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the 
> same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson



> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote:
> > FYI, This may not entirely work as 
> > https://bugs.kde.org/show_bug.cgi?id=358869 shows

ack, there's a new message that we're not catching.

I don't know what the string is though.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review92059
---


On Aug. 1, 2015, 12:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> ---
> 
> (Updated Aug. 1, 2015, 12:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with 
> Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> ---
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the 
> same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Klapetek



> On Feb. 4, 2016, 3:26 p.m., Martin Klapetek wrote:
> > FYI, This may not entirely work as 
> > https://bugs.kde.org/show_bug.cgi?id=358869 shows
> 
> David Edmundson wrote:
> ack, there's a new message that we're not catching.
> 
> I don't know what the string is though.

I was thinking we could maybe check the GL version ourselves at the very start?
There's a glXQueryVersion function for it. That would effectively catch all 
these
crashes on no GL..?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review92059
---


On Aug. 1, 2015, 2:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> ---
> 
> (Updated Aug. 1, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with 
> Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> ---
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the 
> same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review92059
---



FYI, This may not entirely work as https://bugs.kde.org/show_bug.cgi?id=358869 
shows

- Martin Klapetek


On Aug. 1, 2015, 2:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> ---
> 
> (Updated Aug. 1, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with 
> Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> ---
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the 
> same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-04 Thread Martin Gräßlin



> On Feb. 4, 2016, 1:37 p.m., Anthony Fieroni wrote:
> > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22
> > 
> >
> > Make duration depend on animation speed config, pls.
> > Below also.
> 
> Marco Martin wrote:
> it does in loadConfig:
> 
> Anthony Fieroni wrote:
> I mean global animation speed config, systemsettings5 -> compositor -> 
> animations speed
> 
> Marco Martin wrote:
> is that setting reachable from the javascript bindings? (if so the 
> macimize effect i based off from should be adapted to it as well)

animationTime() considers exactly that speed. So yes the effect is absolutely 
correct in that regard.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92054
---


On Feb. 2, 2016, 9:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 9:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: libkscreen bugs on Plasma 4

2016-02-04 Thread Sebastian Kügler

On Tuesday, February 02, 2016 03:01:40 PM Sebastian Kügler wrote:
> When going over the list of libkscreen bugs, there are some reported against
> Plasma 4. I'm planning to close them as Plasma 4 is unmaintained, and it
> would be dishonest to let people think that we're actually working on it.

That's done, and surprisingly, I haven't seen a single complaint. Bug count 
has halved, and I've cleaned up the remaining bugs. It looks more manageable, 
though still scary, now.
-- 
sebas

http://www.kde.org | http://vizZzion.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-04 Thread Marco Martin



> On Feb. 4, 2016, 12:37 p.m., Anthony Fieroni wrote:
> > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22
> > 
> >
> > Make duration depend on animation speed config, pls.
> > Below also.
> 
> Marco Martin wrote:
> it does in loadConfig:
> 
> Anthony Fieroni wrote:
> I mean global animation speed config, systemsettings5 -> compositor -> 
> animations speed

is that setting reachable from the javascript bindings? (if so the macimize 
effect i based off from should be adapted to it as well)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92054
---


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-04 Thread Marco Martin



> On Feb. 4, 2016, 12:37 p.m., Anthony Fieroni wrote:
> > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22
> > 
> >
> > Make duration depend on animation speed config, pls.
> > Below also.

it does in loadConfig:


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92054
---


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126980/
---

(Updated Feb. 4, 2016, 12:46 p.m.)


Review request for kwin and Plasma.


Repository: kwin


Description
---

related to https://git.reviewboard.kde.org/r/126968/
this is only the part which adds support for scaled windows to blur and contrast


Diffs (updated)
-

  effects/backgroundcontrast/contrast.cpp 168deb0 
  effects/blur/blur.cpp a360f03 

Diff: https://git.reviewboard.kde.org/r/126980/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-04 Thread Anthony Fieroni


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92054
---




effects/morphingpopups/package/contents/code/morphingpopups.js (line 22)


Make duration depend on animation speed config, pls.
Below also.


- Anthony Fieroni


On Фев. 2, 2016, 10:51 след обяд, Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> ---
> 
> (Updated Фев. 2, 2016, 10:51 след обяд)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> this effect, derived from the Maximize one, will take the place of the manual 
> window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error 
> prone, plus it's less jarring when the tooltip sizes changes too, since that 
> gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Thomas Lübking



> On Feb. 3, 2016, 9:43 p.m., Thomas Lübking wrote:
> > effects/backgroundcontrast/contrast.cpp, line 383
> > 
> >
> > This looks fishy - and QTransform a tiny bit clumsy.
> > 
> > Does this work:
> > 
> > QVector shapeRects = shape.rects();
> > shape = QRegion(); // clear
> > foreach (QRect r, shapeRects) {
> >    r.moveTo(r.x() * data.xScale() + data.xTranslation(),
> > r.y() * data.yScale() + data.yTranslation());
> >r.setWidth(r.width() * data.xScale());
> >r.setHeight(r.height() * data.yScale());
> >shape |= r;
> > }
> > 
> > the multiplications might need to be put into qRound or qCeil to avoid 
> > glitches.
> > 
> > This spares several qregion copies, conversions into and out of painter 
> > paths and the second shape translation.
> 
> Marco Martin wrote:
> hmm, nope, translation seems off.
> investigating
> 
> Marco Martin wrote:
> to make it work, i have to do it like before:
> QPoint pt = shape.boundingRect().topLeft();
> QVector shapeRects = shape.rects();
> shape = QRegion(); // clear
> foreach (QRect r, shapeRects) {
> r.moveTo((r.x() - pt.x()) * data.xScale() + 
> data.xTranslation(),
> (r.y() -pt.y()) * data.yScale() + 
> data.yTranslation());
> r.setWidth(r.width() * data.xScale());
> r.setHeight(r.height() * data.yScale());
> shape |= r;
> }
> shape = shape.translated(pt.x(), pt.y());
> shape = shape & region;
> 
> Marco Martin wrote:
> so, doesn't seem related to qtransform, but when the region is scaled, 
> its boundingrect just has to be at 0,0 then retranslated back afterwards

r.moveTo(pt.x() + (r.x() - pt.x()) * data.xScale() + data.xTranslation()


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126980/#review92037
---


On Feb. 3, 2016, 3:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126980/
> ---
> 
> (Updated Feb. 3, 2016, 3:35 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> related to https://git.reviewboard.kde.org/r/126968/
> this is only the part which adds support for scaled windows to blur and 
> contrast
> 
> 
> Diffs
> -
> 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
> 
> Diff: https://git.reviewboard.kde.org/r/126980/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-04 Thread Marco Martin



> On Feb. 4, 2016, 6:52 a.m., Luca Beltrame wrote:
> > Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see 
> > get in once all the issues have been addressed. Family members are 
> > depending upon it. ;)
> 
> Lars Pontoppidan wrote:
> Hi Luca, I'm working through Kai's list - and have a good few fixes ready 
> already :)
> 
> I haven't committed anything yet - because I've been a bit unsure if I 
> should commit them and mark them fixed here - not having fixed all of them 
> yet. Or if it's more appropriate to wait a make 1 big commit with all of the 
> fixes? What do you guys usually do?
> 
> Luca Beltrame wrote:
> The idea would be to update the patch when you have addressed the issues. 
> As for the behavior, I've seen both - either incremental fixes, or a big 
> change. I'd go for incremental IMO (but I'm not a Plasma dev ;) as if the 
> patch is big it's easier to see what's changed.

yes, you should update the patch here.
Is it in a branch? if so, commit the fixes to the branch to keep it in sync


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126793/#review92041
---


On Jan. 18, 2016, 11:27 a.m., Lars Pontoppidan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126793/
> ---
> 
> (Updated Jan. 18, 2016, 11:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> KF5 version of the (Picture) Frame widget
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt ed938f8 
>   applets/mediaframe/CMakeLists.txt PRE-CREATION 
>   applets/mediaframe/Messages.sh PRE-CREATION 
>   applets/mediaframe/package/contents/code/utility.js PRE-CREATION 
>   applets/mediaframe/package/contents/config/config.qml PRE-CREATION 
>   applets/mediaframe/package/contents/config/main.xml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/main.qml PRE-CREATION 
>   applets/mediaframe/package/metadata.desktop PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION 
>   applets/mediaframe/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126793/diff/
> 
> 
> Testing
> ---
> 
> kdeplasma-addons builds on Kubuntu 15.10.
> 
> 
> Thanks,
> 
> Lars Pontoppidan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-02-04 Thread Sebastian Kügler via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=358957

Sebastian Kügler  changed:

   What|Removed |Added

Summary|laptop won't hybrid-suspend |laptop won't hybrid-suspend
   |when KDE is running |when Plasma is running
 CC||se...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Marco Martin



> On Feb. 3, 2016, 9:43 p.m., Thomas Lübking wrote:
> > effects/backgroundcontrast/contrast.cpp, line 383
> > 
> >
> > This looks fishy - and QTransform a tiny bit clumsy.
> > 
> > Does this work:
> > 
> > QVector shapeRects = shape.rects();
> > shape = QRegion(); // clear
> > foreach (QRect r, shapeRects) {
> >    r.moveTo(r.x() * data.xScale() + data.xTranslation(),
> > r.y() * data.yScale() + data.yTranslation());
> >r.setWidth(r.width() * data.xScale());
> >r.setHeight(r.height() * data.yScale());
> >shape |= r;
> > }
> > 
> > the multiplications might need to be put into qRound or qCeil to avoid 
> > glitches.
> > 
> > This spares several qregion copies, conversions into and out of painter 
> > paths and the second shape translation.
> 
> Marco Martin wrote:
> hmm, nope, translation seems off.
> investigating
> 
> Marco Martin wrote:
> to make it work, i have to do it like before:
> QPoint pt = shape.boundingRect().topLeft();
> QVector shapeRects = shape.rects();
> shape = QRegion(); // clear
> foreach (QRect r, shapeRects) {
> r.moveTo((r.x() - pt.x()) * data.xScale() + 
> data.xTranslation(),
> (r.y() -pt.y()) * data.yScale() + 
> data.yTranslation());
> r.setWidth(r.width() * data.xScale());
> r.setHeight(r.height() * data.yScale());
> shape |= r;
> }
> shape = shape.translated(pt.x(), pt.y());
> shape = shape & region;

so, doesn't seem related to qtransform, but when the region is scaled, its 
boundingrect just has to be at 0,0 then retranslated back afterwards


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126980/#review92037
---


On Feb. 3, 2016, 3:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126980/
> ---
> 
> (Updated Feb. 3, 2016, 3:35 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> related to https://git.reviewboard.kde.org/r/126968/
> this is only the part which adds support for scaled windows to blur and 
> contrast
> 
> 
> Diffs
> -
> 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
> 
> Diff: https://git.reviewboard.kde.org/r/126980/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Marco Martin



> On Feb. 3, 2016, 9:43 p.m., Thomas Lübking wrote:
> > effects/backgroundcontrast/contrast.cpp, line 383
> > 
> >
> > This looks fishy - and QTransform a tiny bit clumsy.
> > 
> > Does this work:
> > 
> > QVector shapeRects = shape.rects();
> > shape = QRegion(); // clear
> > foreach (QRect r, shapeRects) {
> >    r.moveTo(r.x() * data.xScale() + data.xTranslation(),
> > r.y() * data.yScale() + data.yTranslation());
> >r.setWidth(r.width() * data.xScale());
> >r.setHeight(r.height() * data.yScale());
> >shape |= r;
> > }
> > 
> > the multiplications might need to be put into qRound or qCeil to avoid 
> > glitches.
> > 
> > This spares several qregion copies, conversions into and out of painter 
> > paths and the second shape translation.
> 
> Marco Martin wrote:
> hmm, nope, translation seems off.
> investigating

to make it work, i have to do it like before:
QPoint pt = shape.boundingRect().topLeft();
QVector shapeRects = shape.rects();
shape = QRegion(); // clear
foreach (QRect r, shapeRects) {
r.moveTo((r.x() - pt.x()) * data.xScale() + data.xTranslation(),
(r.y() -pt.y()) * data.yScale() + 
data.yTranslation());
r.setWidth(r.width() * data.xScale());
r.setHeight(r.height() * data.yScale());
shape |= r;
}
shape = shape.translated(pt.x(), pt.y());
shape = shape & region;


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126980/#review92037
---


On Feb. 3, 2016, 3:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126980/
> ---
> 
> (Updated Feb. 3, 2016, 3:35 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> related to https://git.reviewboard.kde.org/r/126968/
> this is only the part which adds support for scaled windows to blur and 
> contrast
> 
> 
> Diffs
> -
> 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
> 
> Diff: https://git.reviewboard.kde.org/r/126980/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Marco Martin



> On Feb. 3, 2016, 9:43 p.m., Thomas Lübking wrote:
> > effects/backgroundcontrast/contrast.cpp, line 383
> > 
> >
> > This looks fishy - and QTransform a tiny bit clumsy.
> > 
> > Does this work:
> > 
> > QVector shapeRects = shape.rects();
> > shape = QRegion(); // clear
> > foreach (QRect r, shapeRects) {
> >    r.moveTo(r.x() * data.xScale() + data.xTranslation(),
> > r.y() * data.yScale() + data.yTranslation());
> >r.setWidth(r.width() * data.xScale());
> >r.setHeight(r.height() * data.yScale());
> >shape |= r;
> > }
> > 
> > the multiplications might need to be put into qRound or qCeil to avoid 
> > glitches.
> > 
> > This spares several qregion copies, conversions into and out of painter 
> > paths and the second shape translation.

hmm, nope, translation seems off.
investigating


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126980/#review92037
---


On Feb. 3, 2016, 3:35 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126980/
> ---
> 
> (Updated Feb. 3, 2016, 3:35 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> related to https://git.reviewboard.kde.org/r/126968/
> this is only the part which adds support for scaled windows to blur and 
> contrast
> 
> 
> Diffs
> -
> 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
> 
> Diff: https://git.reviewboard.kde.org/r/126980/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 54 - Still Failing!

2016-02-04 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 04 Feb 2016 10:57:05 +
Build duration: 1 min 43 sec

CHANGE SET
Revision 42a3d8accd4e494d343954ddaa916a6c618d94f3 by Marco Martin: (reset the 
model on list always shown/hide change)
  change: edit applets/systemtray/plugin/tasksproxymodel.h
  change: edit applets/systemtray/plugin/tasksproxymodel.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KActivities split, 2nd phase

2016-02-04 Thread Ivan Čukić

I have a cunning plan. It is as cunning as a fox what used to be a
Professor of Cunning at Oxford University but has moved on and is now
working for the U.N. at the High Commission of International Cunning
Planning. 


As previously mentioned, the problem is that someone who upgrades the
framework might get a few components missing.

kactivitymanagerd is not really a problem - it can be seen as a
dependency of the framework.

The problems are kio and kcm.

Now, if kio and kcm were to be a part of kactivitymanagerd repository
(or a separate repository**) for a short while, the problematic setups
might be avoided.

1. part: release kactivitymanagerd+kio+kcm at the same time as the frameworks
  this will make it easy to upgrade to the new version - nothing will
be missing from the setup. This release schedule can be followed until
the release of Plasma 5.x (Plasma 5.6, or if we want to give the
transition period three more months, until Plasma 5.7).

2. part: when Plasma 5.x is released, start releasing
kactivitymanagerd+others synchronized with plasma instead of with
frameworks.
In Plasma 5.(x+1), move kio and kcm away from kactivitymanagerd into
their proper destinations. (though, at this point, this might not even
be necessary - only if we still think that kio-extras, etc. are better
destinations than a kactivities-workspace)

** a separate repository kactivities-workspace would make this easier
dependency-wise

plasma <-- kactivities, kactivitymangerd, kactivities-workspace
kactivities <-- kactivitymanagerd (optional runtime dep, with cmake
check and warning)
kactivities-workspace <-- kactivities, kactivitymanagerd

^ a proper directed graph

Cheerio,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-04 Thread Luca Beltrame



> On Feb. 4, 2016, 7:52 a.m., Luca Beltrame wrote:
> > Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see 
> > get in once all the issues have been addressed. Family members are 
> > depending upon it. ;)
> 
> Lars Pontoppidan wrote:
> Hi Luca, I'm working through Kai's list - and have a good few fixes ready 
> already :)
> 
> I haven't committed anything yet - because I've been a bit unsure if I 
> should commit them and mark them fixed here - not having fixed all of them 
> yet. Or if it's more appropriate to wait a make 1 big commit with all of the 
> fixes? What do you guys usually do?

The idea would be to update the patch when you have addressed the issues. As 
for the behavior, I've seen both - either incremental fixes, or a big change. 
I'd go for incremental IMO (but I'm not a Plasma dev ;) as if the patch is big 
it's easier to see what's changed.


- Luca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126793/#review92041
---


On Gen. 18, 2016, 12:27 p.m., Lars Pontoppidan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126793/
> ---
> 
> (Updated Gen. 18, 2016, 12:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> KF5 version of the (Picture) Frame widget
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt ed938f8 
>   applets/mediaframe/CMakeLists.txt PRE-CREATION 
>   applets/mediaframe/Messages.sh PRE-CREATION 
>   applets/mediaframe/package/contents/code/utility.js PRE-CREATION 
>   applets/mediaframe/package/contents/config/config.qml PRE-CREATION 
>   applets/mediaframe/package/contents/config/main.xml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/main.qml PRE-CREATION 
>   applets/mediaframe/package/metadata.desktop PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION 
>   applets/mediaframe/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126793/diff/
> 
> 
> Testing
> ---
> 
> kdeplasma-addons builds on Kubuntu 15.10.
> 
> 
> Thanks,
> 
> Lars Pontoppidan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-04 Thread Lars Pontoppidan



> On Feb. 4, 2016, 6:52 a.m., Luca Beltrame wrote:
> > Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see 
> > get in once all the issues have been addressed. Family members are 
> > depending upon it. ;)

Hi Luca, I'm working through Kai's list - and have a good few fixes ready 
already :)

I haven't committed anything yet - because I've been a bit unsure if I should 
commit them and mark them fixed here - not having fixed all of them yet. Or if 
it's more appropriate to wait a make 1 big commit with all of the fixes? What 
do you guys usually do?


- Lars


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126793/#review92041
---


On Jan. 18, 2016, 11:27 a.m., Lars Pontoppidan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126793/
> ---
> 
> (Updated Jan. 18, 2016, 11:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> KF5 version of the (Picture) Frame widget
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt ed938f8 
>   applets/mediaframe/CMakeLists.txt PRE-CREATION 
>   applets/mediaframe/Messages.sh PRE-CREATION 
>   applets/mediaframe/package/contents/code/utility.js PRE-CREATION 
>   applets/mediaframe/package/contents/config/config.qml PRE-CREATION 
>   applets/mediaframe/package/contents/config/main.xml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/main.qml PRE-CREATION 
>   applets/mediaframe/package/metadata.desktop PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION 
>   applets/mediaframe/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126793/diff/
> 
> 
> Testing
> ---
> 
> kdeplasma-addons builds on Kubuntu 15.10.
> 
> 
> Thanks,
> 
> Lars Pontoppidan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

47 matches

Mail list logo