Review Request 127408: Remove unneeded shadows setup call

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127408/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Remove the initial call to `PanelShadows::self()->addWindow(this);`. It ends up 
in a winId call that will force a premature construction of the QPlatformWindow.


Diffs
-

  shell/panelview.cpp c8c3c71 

Diff: https://git.reviewboard.kde.org/r/127408/diff/


Testing
---

I made sure it doesn't end up calling `const_cast(this)->create();` 
within `QWindow::winId()`.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125755: Fix build with QT5.6

[David Kahles]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125755/
---

(Updated March 17, 2016, 11:18 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: sddm-kcm


Description
---

Since QT5.6, qpixmap.h pulls in qtextstream.h. Xlib.h has a
but qtextstream.h uses Status as an enum name. fixx11h.h resolves this
name clash.


Diffs
-

  src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c 
  src/cursortheme/xcursortheme.cpp 4fc70a605d5fc3165de78916db92c13bb67c0429 

Diff: https://git.reviewboard.kde.org/r/125755/diff/


Testing
---

Compiles now.


Thanks,

David Kahles

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2,262 lines] D1168: Split drm_backend.{h,cpp] into separate files

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: graesslin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  This changes splits up the monster file containing different types used
  in the DRM backend into separate files per class:
  
  - drm_backend.{h,cpp}
  - drm_buffer.{h,cpp}
  - drm_inputeventfilter.{h,cpp}
  - drm_output.{h,cpp}
  - drm_pointer.h
  
  No actual code changes other than build fixes.
  
  Clean up headers in the split files.

TEST PLAN
  Builds with GBM enabled

REPOSITORY
  rKWIN KWin

BRANCH
  sebas/drmbackend-split

REVISION DETAIL
  https://phabricator.kde.org/D1168

AFFECTED FILES
  backends/drm/CMakeLists.txt
  backends/drm/drm_backend.cpp
  backends/drm/drm_backend.h
  backends/drm/drm_buffer.cpp
  backends/drm/drm_buffer.h
  backends/drm/drm_inputeventfilter.cpp
  backends/drm/drm_inputeventfilter.h
  backends/drm/drm_output.cpp
  backends/drm/drm_output.h
  backends/drm/drm_pointer.h
  backends/drm/egl_gbm_backend.cpp
  backends/drm/scene_qpainter_drm_backend.cpp
  backends/drm/screens_drm.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1153: [plugins/qpa] Add a roundtrip platform function

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  qpa-roundtrip-5.6

REVISION DETAIL
  https://phabricator.kde.org/D1153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1171: simple cleanup in geometryByDistance

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE6687d1a5094c: simple cleanup in 
geometryByDistance (authored by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1171?vs=2834&id=2835

REVISION DETAIL
  https://phabricator.kde.org/D1171

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma, apol, mart
Cc: apol, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/
---

(Updated March 16, 2016, 12:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 6fefa27d1e3890ebef80c2a65ec90a51a7ebc068 by Aleix Pol to 
branch master.


Repository: plasma-workspace


Description
---

Makes it possible to test how/if a plasmoid behaves correctly on the most 
similar environment possible to what the user would find on a production system.

* Loads a plasmoid on a panel and the desktop.
* Lets it test his own stuff
* Notifies, when done, if failed.

There's still more to look into:

* what objects need to be passed, besides the `Plasma::AppletQuickItem`.
* good things to test
* how to test other shells than the desktop shell

Nevertheless, it looks to me that it's a step forward. Comments welcome.


Diffs
-

  applets/analog-clock/contents/tests/test.qml PRE-CREATION 
  shell/CMakeLists.txt e553133 
  shell/main.cpp d6e3640 
  shell/shellcorona.cpp 54667da 
  shell/shellmanager.h 17acbc6 
  shell/shellmanager.cpp 3c3638f 
  shell/testcorona.h PRE-CREATION 
  shell/testcorona.cpp PRE-CREATION 
  shell/tests/CMakeLists.txt PRE-CREATION 
  shell/tests/testLayout.js.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127346/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Mar 2016 12:04:26 +
Build duration: 53 sec

CHANGE SET
Revision dede99791c54303972ca4ff2cb0ef570ea790099 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit applets/lock_logout/metadata.desktop
  change: edit 
dataengines/powermanagement/plasma-dataengine-powermanagement.desktop
  change: edit lookandfeel/metadata.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: remove khelpcenter from next Plasma release?

[Luigi Toscano]

On Thursday 17 of March 2016 11:54:31 Aaron Honeycutt wrote:
> Kubuntu uses it for our Documentation but our current tools do have a PDF
> export option as well as epub so we could use a different tool to read
> those files without khelpcenter. I do thank every developer for his/her
> work and current work on that package!

Why use a different tool? KHelpCenter is (mostly) simply changing the release 
schedule...

-- 
Luigi

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Fuchs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #10 from Fuchs  ---
Augh, obviously replace 2 above with $MAX, my bad. (And in this case maybe
check for non-null, even though this should™ not be possible)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1161: PanelView length cleanup

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS
  shell/panelview.cpp:282 it does, because resize calls resizeEvent, which 
calls position.
  
  shell/panelview.h:189 the reason I keep it is because t's possible for the 
contents to want to be longer than the user set maximum, or shorter than the 
user set minimum (which will limit the window size)
  
  by keeping it if we change the min/max size we can adjust to the right value 
instantly

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1161

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma
Cc: mart, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127389: Fix the krunner KCM UI

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127389/
---

(Updated March 16, 2016, 12:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit d107292076cfcfb2df393ae1fd1e80f0cb65d13a by David 
Edmundson to branch Plasma/5.6.


Repository: plasma-desktop


Description
---

paint was changed but sizeHint wasn't implemented meaning it will only
look OK if you have icons bigger than the text.


Diffs
-

  kcms/runners/kcm.h 8f4d362dc27fcce9441b5dba2c6e1bb401669365 
  kcms/runners/kcm.cpp 6020e74590059752526f570f2a4ebb1871f4081d 

Diff: https://git.reviewboard.kde.org/r/127389/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma 5.6 tars

[Jonathan Riddell]

Plasma 5.6 tars are up on depot for packagers

Release is due on Tuesday

For proofreading:
https://www.kde.org/announcements/plasma-5.6.0.php
https://www.kde.org/announcements/plasma-5.5.5-5.6.0-changelog.php
https://www.kde.org/info/plasma-5.6.0.php
https://community.kde.org/Plasma/5.6_Errata

Packagers should note the new errata on Qt 5.6:

Freezes Using Qt 5.6

http://bugreports.qt.io/browse/QTBUG-51676
https://bugs.kde.org/show_bug.cgi?id=359611

When using Qt 5.6 Plasma loads itself incompletely and with long
delays. Deadlocks occur in kded5. A potential patch fix is available
but it is unclear how successful this is
https://codereview.qt-project.org/#/c/151459/

new is:
 grub theme breeze-grub
 plymouth theme breeze-plymouth
 kactivitiies changes with kactivitymanagerd
 split from framework-integration is plasma-integration
 and a preview of simplesystray an experimental systray replacement
 media center still in tech preview (but working looking likely for 5.7)

Happy packaging

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

[Aleix Pol Gonzalez]

> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote:
> > shell/testcorona.cpp, line 22
> > 
> >
> > PlasmaQuick doesn't have any headers installed, so the build fails.
> 
> Aleix Pol Gonzalez wrote:
> Are you sure? https://paste.kde.org/p7zxnmpr2
> 
> Hrvoje Senjan wrote:
> Well, with KF5.20.0 they aren't installed here (cmake 3.4.3).
> I see that somehow with master (and cmake 3.3.1) they are.
> Anyhow with master, the error (plasma-framework bug) is
> ```
> [  191s] In file included from 
> /usr/include/KF5/PlasmaQuick/AppletQuickItem:1:0,
> [  191s]  from 
> /home/abuild/rpmbuild/BUILD/plasma-workspace-5.5.90git~20160316T165610~e7f09ba/shell/coronatesthelper.cpp:22:
> [  191s] /usr/include/KF5/plasmaquick/appletquickitem.h:31:32: fatal 
> error: plasmaquick_export.h: No such file or directory
> [  191s] compilation terminated.
> ```

What do you mean? that some cmake versions install some headers and some others 
don't? It looks to me that there might be an issue with your installation...


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/#review93604
---


On March 16, 2016, 12:46 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127346/
> ---
> 
> (Updated March 16, 2016, 12:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Makes it possible to test how/if a plasmoid behaves correctly on the most 
> similar environment possible to what the user would find on a production 
> system.
> 
> * Loads a plasmoid on a panel and the desktop.
> * Lets it test his own stuff
> * Notifies, when done, if failed.
> 
> There's still more to look into:
> 
> * what objects need to be passed, besides the `Plasma::AppletQuickItem`.
> * good things to test
> * how to test other shells than the desktop shell
> 
> Nevertheless, it looks to me that it's a step forward. Comments welcome.
> 
> 
> Diffs
> -
> 
>   applets/analog-clock/contents/tests/test.qml PRE-CREATION 
>   shell/CMakeLists.txt e553133 
>   shell/main.cpp d6e3640 
>   shell/shellcorona.cpp 54667da 
>   shell/shellmanager.h 17acbc6 
>   shell/shellmanager.cpp 3c3638f 
>   shell/testcorona.h PRE-CREATION 
>   shell/testcorona.cpp PRE-CREATION 
>   shell/tests/CMakeLists.txt PRE-CREATION 
>   shell/tests/testLayout.js.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127346/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1152: [client] Perform ConnectionThread::roundtrip through QPA interface

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  roundtrip-qpa-5.6

REVISION DETAIL
  https://phabricator.kde.org/D1152

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1153: [plugins/qpa] Add a roundtrip platform function

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINfe745177e0f5: [plugins/qpa] Add a roundtrip platform 
function (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1153?vs=2795&id=2802

REVISION DETAIL
  https://phabricator.kde.org/D1153

AFFECTED FILES
  plugins/qpa/nativeinterface.cpp
  plugins/qpa/nativeinterface.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127352: [kstyle] Implement window shadows on Wayland

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127352/
---

(Updated March 16, 2016, 1:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Hugo Pereira Da Costa.


Changes
---

Submitted with commit 9caf0c8ab18572f2b097f999715f8094c1b3601b by Martin 
Gräßlin to branch master.


Repository: breeze


Description
---

Integrate with Wayland and create a ShadowManager if available.
With the ShadowManager it's possible to create a Shadow for a Surface.

The Wayland shadow is very similar to the X11 based one, so a lot of
code can be shared. The code is slightly refactored to share the common
code paths to create and destroy the shadow.


Diffs
-

  kstyle/CMakeLists.txt b2c6dc847fef1c7876a0ac1af9e28f47422b620b 
  kstyle/breezeshadowhelper.h 0c868d3686eec67e630ce08c36df6b4cf34d7f1c 
  kstyle/breezeshadowhelper.cpp 1eb1ddc6a154d8865b39936718f6a5d5ef8f7fdd 
  kstyle/config-breeze.h.cmake ba2b5f64c1ca855c541fd7eb0e919b8f897f481f 

Diff: https://git.reviewboard.kde.org/r/127352/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127409/#review93672
---


Ship it!




Ship It!

- David Edmundson


On March 17, 2016, 2:13 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127409/
> ---
> 
> (Updated March 17, 2016, 2:13 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Only update the properties that require a winId when visible, otherwise let 
> updateVisibility() take care about them.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp 7bb63c5 
> 
> Diff: https://git.reviewboard.kde.org/r/127409/diff/
> 
> 
> Testing
> ---
> 
> I don't get platform creations being forced on gdb.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 28 lines] D1171: simple cleanup in geometryByDistance

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  cache screenGeometry in local var
  replace size().width() with width()

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1171

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124495: Proofread ksysguard docbook for kf5

[Luigi Toscano]

> On Aug. 9, 2015, 4:38 p.m., Luigi Toscano wrote:
> > Review on terminology fine by me; waiting a bit on the maintainer for the 
> > content.

Plasma developers, any comment for this review? Can we commit it?


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124495/#review83606
---


On July 27, 2015, 8:48 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124495/
> ---
> 
> (Updated July 27, 2015, 8:48 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Proofread + replaced entity kde with plasma
> Remove launching System Activities from krunner
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 7a65b62 
> 
> Diff: https://git.reviewboard.kde.org/r/124495/diff/
> 
> 
> Testing
> ---
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127412: reintroduce dbus calls for kwin script console

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127412/
---

(Updated March 18, 2016, 10:43 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
---

Submitted with commit f841428847b46e6009cc122c1f72507f4b4aa741 by Marco Martin 
to branch master.


Repository: plasma-workspace


Description
---

to support "wm console" from the desktop scripting runner


Diffs
-

  shell/dbus/org.kde.PlasmaShell.xml cf2d0bb 
  shell/shellcorona.h 271d7bf 
  shell/shellcorona.cpp 50125bb 

Diff: https://git.reviewboard.kde.org/r/127412/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 512 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/512/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 18 Mar 2016 14:09:24 +
Build duration: 40 sec

CHANGE SET
Revision 45d58d690d423160925b4763e9670a15fbe8aa81 by Marco Martin: (allocate 
the watcher on the stack)
  change: edit shell/scripting/scriptengine.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1170: Api to rename activities in desktop scripting

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS
  shell/scripting/scriptengine.cpp:274 Edit: 
  
  doesn't this leak?
  
  why not make it on the stack.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1170

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, Plasma, davidedmundson, sebas
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 480 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/480/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 17 Mar 2016 16:09:52 +
Build duration: 1 min 52 sec

CHANGE SET
Revision 1f01ec6e4e86e395e7867e98b9461704bf6731fa by David Edmundson: (Panel 
cleanup)
  change: edit desktoppackage/contents/views/Panel.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 506 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/506/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 17 Mar 2016 17:14:02 +
Build duration: 1 min 27 sec

CHANGE SET
Revision 6f70e9f2fcd3791c0a923302f51eb6742987e1bf by David Edmundson: (Cleanup 
resize)
  change: edit shell/panelview.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 503 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/503/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 17 Mar 2016 12:46:41 +
Build duration: 1 min 4 sec

CHANGE SET
Revision 829fb30934c455de5fc8d92512561d237c58fb35 by andreas.sturmlechner: 
([phonon] Do not set RPATH)
  change: edit phonon/platform_kde/CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127422: Dialog: Set SkipTaskbar/Pager states before showing window

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127422/#review93696
---


Ship it!




Ship It!

- David Edmundson


On March 18, 2016, 8:16 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127422/
> ---
> 
> (Updated March 18, 2016, 8:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This sets the states before showing the window and is a proper fix
> for the linked bug.
> 
> Needs https://codereview.qt-project.org/#/c/149013/ - Qt 5.6.1
> 
> CCBUG: 332024
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp 7bb63c5 
> 
> Diff: https://git.reviewboard.kde.org/r/127422/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel