Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-10 Thread Anthony Fieroni 


> On Април 11, 2016, 8:45 преди обяд, Martin Gräßlin wrote:
> > > otherwise kwindowsystem::self() is nullptr
> > 
> > how can KWindowSystem::self() be null? And why should that have anything to 
> > do with KWin? KWindowSystem does not depend on a window manager running.
> 
> Thomas Lübking wrote:
> The entire thing sounds as if the problem would be that the session 
> restorage in kwin overrides the placement for restored windows (with the 
> restored position)
> 
> That's however not a bug (at least it's intended) and I've no idea why 
> that's relevant to the weird geometry handling of SNI items (which looks 
> *fr* too complex - the position of remapped windows is usually maintained 
> by QWidget ...)

I saw the code, it looks like KWindowSystem not depend on Kwin, but Kwin *must* 
be started *before* use of kwindowsystem. Thomas may right, because setGeometry 
even not work on sessions restored app.
When session was finish if start apps with kmail --session session-id 
everything wors fine.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127631/#review94513
---


On Април 10, 2016, 10:46 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127631/
> ---
> 
> (Updated Април 10, 2016, 10:46 след обяд)
> 
> 
> Review request for kwin, Plasma, David Edmundson, Martin Gräßlin, and Thomas 
> Lübking.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> We must proceed with autoStart0 when kwin process is ended otherwise 
> kwindowsystem::self() is nullptr. Every restored session app cannot use 
> kwindowsystem. This depends of cpu speed, it can be faster enough to start wm 
> before ksmserver restore apps and kwindowsystem will be usable.
> 
> 
> Diffs
> -
> 
>   ksmserver/startup.cpp f118b55 
> 
> Diff: https://git.reviewboard.kde.org/r/127631/diff/
> 
> 
> Testing
> ---
> 
> It's needed to fix this bug -> https://git.reviewboard.kde.org/r/127216/
> I don't know how to proceed if kwin fails to start in every way, can we 
> process - i think not?
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-10 Thread Thomas Lübking 


> On April 11, 2016, 5:45 vorm., Martin Gräßlin wrote:
> > > otherwise kwindowsystem::self() is nullptr
> > 
> > how can KWindowSystem::self() be null? And why should that have anything to 
> > do with KWin? KWindowSystem does not depend on a window manager running.

The entire thing sounds as if the problem would be that the session restorage 
in kwin overrides the placement for restored windows (with the restored 
position)

That's however not a bug (at least it's intended) and I've no idea why that's 
relevant to the weird geometry handling of SNI items (which looks *fr* too 
complex - the position of remapped windows is usually maintained by QWidget ...)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127631/#review94513
---


On April 10, 2016, 7:46 nachm., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127631/
> ---
> 
> (Updated April 10, 2016, 7:46 nachm.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, Martin Gräßlin, and Thomas 
> Lübking.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> We must proceed with autoStart0 when kwin process is ended otherwise 
> kwindowsystem::self() is nullptr. Every restored session app cannot use 
> kwindowsystem. This depends of cpu speed, it can be faster enough to start wm 
> before ksmserver restore apps and kwindowsystem will be usable.
> 
> 
> Diffs
> -
> 
>   ksmserver/startup.cpp f118b55 
> 
> Diff: https://git.reviewboard.kde.org/r/127631/diff/
> 
> 
> Testing
> ---
> 
> It's needed to fix this bug -> https://git.reviewboard.kde.org/r/127216/
> I don't know how to proceed if kwin fails to start in every way, can we 
> process - i think not?
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-10 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127631/#review94513
---



> otherwise kwindowsystem::self() is nullptr

how can KWindowSystem::self() be null? And why should that have anything to do 
with KWin? KWindowSystem does not depend on a window manager running.

- Martin Gräßlin


On April 10, 2016, 9:46 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127631/
> ---
> 
> (Updated April 10, 2016, 9:46 p.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, Martin Gräßlin, and Thomas 
> Lübking.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> We must proceed with autoStart0 when kwin process is ended otherwise 
> kwindowsystem::self() is nullptr. Every restored session app cannot use 
> kwindowsystem. This depends of cpu speed, it can be faster enough to start wm 
> before ksmserver restore apps and kwindowsystem will be usable.
> 
> 
> Diffs
> -
> 
>   ksmserver/startup.cpp f118b55 
> 
> Diff: https://git.reviewboard.kde.org/r/127631/diff/
> 
> 
> Testing
> ---
> 
> It's needed to fix this bug -> https://git.reviewboard.kde.org/r/127216/
> I don't know how to proceed if kwin fails to start in every way, can we 
> process - i think not?
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Kirigami.Page breaks with Loader+Component inside

2016-04-10 Thread Martin Klapetek 
Hey,

so I've ported SpaceBar to Kirigami and got stuck with Page
not rendering anything when it contains a Loader.

I've reduced it to a minimal example, attached, where it is
easily reproducible.

Running the attached qml file will show an empty page, removing
the Loader _and_ Component will show the green rectangle.
Changing the Page to say, an Item, shows both Rects.

This was working before and I have tried to look into it, but couldn't
figure out what's up with that.

Can somebody have a look?

Cheers
-- 
Martin Klapetek | KDE Developer
import QtQuick 2.1
import QtQuick.Controls 1.4 as Controls
import QtQuick.Layouts 1.2
import org.kde.kirigami 1.0 as Kirigami

Kirigami.ApplicationWindow {
id: root
width: 500
height: 800
visible: true

pageStack.initialPage: mainPageComponent

Component {
id: mainPageComponent

Kirigami.Page {
title: "Hello"

Rectangle {
color: "green"
width: 150
height: 150
}

// Comment the Loader and Component and the Rectangle
// above will appear
Loader {
active: true
sourceComponent: innerComponent
}

Component {
id: innerComponent

Rectangle {
color: "red"
width: 50
height: 50
}
}
}
}
}
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-10 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127631/
---

Review request for kwin, Plasma, David Edmundson, Martin Gräßlin, and Thomas 
Lübking.


Repository: plasma-workspace


Description
---

We must proceed with autoStart0 when kwin process is ended otherwise 
kwindowsystem::self() is nullptr. Every restored session app cannot use 
kwindowsystem. This depends of cpu speed, it can be faster enough to start wm 
before ksmserver restore apps and kwindowsystem will be usable.


Diffs
-

  ksmserver/startup.cpp f118b55 

Diff: https://git.reviewboard.kde.org/r/127631/diff/


Testing
---

It's needed to fix this bug -> https://git.reviewboard.kde.org/r/127216/
I don't know how to proceed if kwin fails to start in every way, can we process 
- i think not?


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 32 - Still Unstable!

2016-04-10 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 16:15:52 +
Build duration: 40 min

CHANGE SET
Revision e7526890ebf1491a8c79fb449c95ca41dfac1d9b by Friedrich W. H. Kossebau: 
([weather] do not leak symbols of nested Private class)
  change: edit dataengines/weather/ions/ion.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

2016-04-10 Thread broulik (Kai Uwe Broulik) 
broulik added a comment.


  Not sure about the term *event* sounds. What about *notification* sounds?

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1366

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: broulik, colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 31 - Still Unstable!

2016-04-10 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 09:41:52 +
Build duration: 42 min

CHANGE SET
Revision 16a3402428d8bf126578333f8b1c10198d90df36 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit runners/baloo/plasma-runner-baloosearch.desktop
  change: edit lookandfeel/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

2016-04-10 Thread colomar (Thomas Pfeiffer) 
colomar added a comment.


  In https://phabricator.kde.org/D1366#25480, @drosca wrote:
  
  > F106811: event-sounds.png 
  >
  > Looks like this (always first in the list). It will need different icon, 
ideas?
  
  
  Event sounds are usually notifications, right? If so, I'd just use the 
notifications icon (preferences-desktop-notification)

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1366

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127616: Digital clock applet re-write

2016-04-10 Thread Wolfgang Bauer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127616/#review94473
---




applets/digital-clock/package/contents/ui/main.qml (line 128)


This check is wrong and will cause the clock *never* to display seconds if 
seconds are part of the timeFormatString.
The last part should be removed.

Btw, this bug is present in the current applet too.
To reproduce, set the locale to "C" and enable "Show Seconds", the seconds 
won't be displayed.

See https://git.reviewboard.kde.org/r/127623/


- Wolfgang Bauer


On April 9, 2016, 5:23 nachm., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127616/
> ---
> 
> (Updated April 9, 2016, 5:23 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 360059
> https://bugs.kde.org/show_bug.cgi?id=360059
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is mostly a refactoring, removing a lot of update functions and making 
> use of QtQuick's event-driven update logic instead.
> It leads to a lot less updates and a much easier to understand code.
> All the formatting and update functions have been reduced to what's necessary 
> in oder to save some cpu time.
> 
> The layout has been refactored as well leading to some small changes:
> - The time label is now vertically centered without an offset
> - The size of the calendar has been reduced slightly
> - Labels can't have multiple lines in vertical panels any more
> - The timezone and date labels have been reduced to 2/3 of the time label size
> 
> The options in the config dialog have been re-ordered.
> 
> And a new feature has been implemented:
> - Seconds are always shown in the tooltip
> 
> And some more changes:
> - If the dates of time zones differ from the currently active time zone, the 
> full date is shown for these time zones in the tooltip
>   (Currently the full date is shown for time zones if their dates differ from 
> the local time zone)
> - Always use font.pointSize in order to get rid of pointSize vs. pixelSize 
> warnings
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/config/config.qml 877e40c 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 381bddb 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 02d55a9 
>   applets/digital-clock/package/contents/ui/MonthMenu.qml 170ce62 
>   applets/digital-clock/package/contents/ui/Tooltip.qml 2a8dda9 
>   applets/digital-clock/package/contents/ui/configAppearance.qml fc9a09e 
>   applets/digital-clock/package/contents/ui/configTimeZones.qml 3ac84a7 
>   applets/digital-clock/package/contents/ui/main.qml b86b7fe 
> 
> Diff: https://git.reviewboard.kde.org/r/127616/diff/
> 
> 
> Testing
> ---
> 
> Tested with different configurations.
> 
> 
> File Attachments
> 
> 
> Old clock on the left, new one on the right
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/d2fd6bfc-2f24-417f-a873-bc0683f6873d__clock-tooltip.png
> Tooltip with multiple time zones, current date differs from local tz date
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/4edaa035-0e69-4af2-885d-59e311ac5ac2__clock-tooltip-multi-tz.png
> Old config dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/8ca78bd7-f82d-4cfa-b919-60b713d5c557__clock-config-old.png
> New config dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/a69b5256-9353-40c8-989b-05575f07c15b__clock-config-new.png
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127623: [digital-clock] Fix display of seconds with certain locales

2016-04-10 Thread Wolfgang Bauer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127623/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Currently, "Show Seconds" has no effect with certain locales (C e.g.) that 
already contain the seconds in the ShortFormat.
The reason is that the seconds are only added to the format string that's used 
to display the time if they are not part of timeFormatString already (which is 
not used at all for the display).

This patch fixes that check and adds them only depending on the showSeconds 
config option.


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 

Diff: https://git.reviewboard.kde.org/r/127623/diff/


Testing
---

Switch locale to C, seconds are shown now or not, depending on the applet's 
configuration, they were not shown before even when enabled.
It still behaves as expected with my standard locale (de_AT).


Thanks,

Wolfgang Bauer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel