Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 208 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/208/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jun 2016 05:22:45 + Build duration: 17 min CHANGE SET Revision b227b91df8df98a6c5ed29913491eececd1ed764 by Bhushan Shah: (Fix bunch of overrides warnings) change: edit libtaskmanager/tasksmodel.h change: edit libtaskmanager/taskgroupingproxymodel.h change: edit libtaskmanager/flattentaskgroupsproxymodel.h change: edit libtaskmanager/abstracttasksmodel.h change: edit libtaskmanager/taskfilterproxymodel.h JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1972/5260 (37%)CONDITIONAL 1382/5392 (26%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/2986 (5%)CONDITIONAL 88/3119 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1962: Fix bunch of overrides warnings
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb227b91df8df: Fix bunch of overrides warnings (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1962?vs=4644=4653 REVISION DETAIL https://phabricator.kde.org/D1962 AFFECTED FILES libtaskmanager/abstracttasksmodel.h libtaskmanager/flattentaskgroupsproxymodel.h libtaskmanager/taskfilterproxymodel.h libtaskmanager/taskgroupingproxymodel.h libtaskmanager/tasksmodel.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, hein, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1962: Fix bunch of overrides warnings
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH clang-shut-up (branched from master) REVISION DETAIL https://phabricator.kde.org/D1962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, hein, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1814: Add TaskManager requestActivities
hein added a comment. +1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH activities REVISION DETAIL https://phabricator.kde.org/D1814 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, hein, #plasma Cc: hein, mart, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/#review96767 --- For 5.7 ? - Anthony Fieroni On Април 28, 2016, 11:11 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127651/ > --- > > (Updated Април 28, 2016, 11:11 преди обяд) > > > Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > > ^^ > > > Diffs > - > > applets/CMakeLists.txt e591c81 > applets/minimizeall/CMakeLists.txt PRE-CREATION > applets/minimizeall/Messages.sh PRE-CREATION > applets/minimizeall/package/contents/config/main.xml PRE-CREATION > applets/minimizeall/package/contents/ui/main.qml PRE-CREATION > applets/minimizeall/package/metadata.desktop PRE-CREATION > applets/minimizeall/plugin/minimizeall.h PRE-CREATION > applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION > applets/minimizeall/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127651/diff/ > > > Testing > --- > > > File Attachments > > > Screenshot_20160428_110625.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2dc7f4c9-c10a-4166-95d7-67418ad9ce7f__Screenshot_20160428_110625.png > > > Thanks, > > Anthony Fieroni > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128038/#review96766 --- 5.7 has same bug. - Anthony Fieroni On Юни 3, 2016, 7:41 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128038/ > --- > > (Updated Юни 3, 2016, 7:41 след обяд) > > > Review request for Plasma and Eike Hein. > > > Repository: plasma-desktop > > > Description > --- > > 1. Enable highlighted window, tooltips and grouping > 2. Open more then one in goup > 3. Close one of grouped windows by click at tooltip button > > > Diffs > - > > applets/taskmanager/plugin/backend.cpp afc6b91 > > Diff: https://git.reviewboard.kde.org/r/128038/diff/ > > > Testing > --- > > Activate window "works" because kwin stops effect on activate, however it > better to be stopped. > > > Thanks, > > Anthony Fieroni > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1893: [Panel Config Overlay] Make spacer size handles narrower
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1893 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, davidedmundson Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1907: [System Tray] Hide popup when user configuring
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1907 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128267: Include the Slab value in the Cached value
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128267/#review96764 --- Ship it! good research! Thanks. Do you have commit access? - David Edmundson On June 20, 2016, 10:54 p.m., Rob Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128267/ > --- > > (Updated June 20, 2016, 10:54 p.m.) > > > Review request for Plasma. > > > Repository: ksysguard > > > Description > --- > > Before this patch, Cached only counted the page cache. > With this patch, the slab is also included. This change is visible > through the APi in "mem/physical/application" and "mem/physical/cached". > > > Why? For the calculation of used memory (`Appl`), the Slab should not > be counted as used memory as it is a cache for kernel data structures. > > free (from procps) calculates "Used" memory as follows: > MemTotal - MemFree - (Cached + Slab) - Buffers > (you can verify this using the numbers from `cat /proc/meminfo`). > > This discrepancy in used memory was already noted before, at > https://mail.kde.org/pipermail/plasma-devel/2008-December/002984.html > > > This "Slab" value [1] is not available from the systemmonitor. It usually > > doesn't grow over 20MB at all anyway. I don't know how important this value > > is, so is it a feasable solution to simply ignore this and only show used, > > cache and buffer? > > After 10 days of usage, my slab looks like this: > > ``` > $ cat /proc/meminfo | grep Slab > Slab:2763208 kB > ``` > > Clearly, the slab is non-negligible and should be deducted. > > The immediate reason for writing this patch is that the "Memory Status" > plasmoid displayed 4G of "memory usage" even after closing all programs. > This was confusing, especially when `free -m` showed a much lower value. > > > Diffs > - > > ksysguardd/Linux/Memory.c 6b2fcab > > Diff: https://git.reviewboard.kde.org/r/128267/diff/ > > > Testing > --- > > (on ArchLinux) > > Add the "Memory Status" plasmoid to the desktop if is not already there. > Note that the displayed value for "Physical memory" does not match the "Used" > value as reported by `free -m`. > > Build and install ksysguard after applying the patch: > > ``` > cd build/ > cmake ../ -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr > -DKDE_INSTALL_LIBDIR=lib -DBUILD_TESTING=OFF > make > sudo make install > ``` > > Then restart plasmashell > > > ``` > kquitapp5 plasmashell && kstart plasmashell > ``` > > Look at the "Memory Status" widget on the desktop and observe that it > displays a sensible value (similar to the "Used" value of `free -m`). > > > Thanks, > > Rob Wu > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 5 lines] D1966: Set System Tray AppletItem width properly
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Width should not include top and bottom margins BUG: 364543 FIXED-IN: 5.7 REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1966 AFFECTED FILES applets/systemtray/package/contents/ui/items/AbstractItem.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128267: Include the Slab value in the Cached value
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128267/ --- Review request for Plasma. Repository: ksysguard Description --- Before this patch, Cached only counted the page cache. With this patch, the slab is also included. This change is visible through the APi in "mem/physical/application" and "mem/physical/cached". Why? For the calculation of used memory (`Appl`), the Slab should not be counted as used memory as it is a cache for kernel data structures. free (from procps) calculates "Used" memory as follows: MemTotal - MemFree - (Cached + Slab) - Buffers (you can verify this using the numbers from `cat /proc/meminfo`). This discrepancy in used memory was already noted before, at https://mail.kde.org/pipermail/plasma-devel/2008-December/002984.html > This "Slab" value [1] is not available from the systemmonitor. It usually > doesn't grow over 20MB at all anyway. I don't know how important this value > is, so is it a feasable solution to simply ignore this and only show used, > cache and buffer? After 10 days of usage, my slab looks like this: ``` $ cat /proc/meminfo | grep Slab Slab:2763208 kB ``` Clearly, the slab is non-negligible and should be deducted. The immediate reason for writing this patch is that the "Memory Status" plasmoid displayed 4G of "memory usage" even after closing all programs. This was confusing, especially when `free -m` showed a much lower value. Diffs - ksysguardd/Linux/Memory.c 6b2fcab Diff: https://git.reviewboard.kde.org/r/128267/diff/ Testing --- (on ArchLinux) Add the "Memory Status" plasmoid to the desktop if is not already there. Note that the displayed value for "Physical memory" does not match the "Used" value as reported by `free -m`. Build and install ksysguard after applying the patch: ``` cd build/ cmake ../ -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_LIBDIR=lib -DBUILD_TESTING=OFF make sudo make install ``` Then restart plasmashell ``` kquitapp5 plasmashell && kstart plasmashell ``` Look at the "Memory Status" widget on the desktop and observe that it displays a sensible value (similar to the "Used" value of `free -m`). Thanks, Rob Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128263: Don't include embedded contrainers in containmentAt(pos) - fix crash when adding a system tray.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128263/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Do to so means the System Tray applet ends up being placed inside the system tray container. This causes a recursive parent loop, creating a stack overflow every time parent() is called recursively This happens whenever one drags a sys tray on the desktop or simply adds a new system tray whilst running. BUG: 361777 We also need to do a hack for Plasma/5.7 in plasma-desktop somehow in all cases where this is used as this is a huge bug. Diffs - src/scriptengines/qml/plasmoid/containmentinterface.cpp db77db9abeafa508dd26c23710a657584ad1ef0b Diff: https://git.reviewboard.kde.org/r/128263/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KCM/colord-kde and it's KF5 release
Hi, I hope this is the right ml to talk about KCMs. I tried to install latest stable release (0.3) of colord-kde[1] to manage icc color profiles, but the KCM isn't loaded in SystemSettings. I can launch it with `kcmshell4 kcm_colord` but not with `kcmshell5 kcm_colord`. So I tried to compile it from git[1] and it works, it's shown in SystemSettings correctly. But since it has to be installed in offices, I'd prefer to use a package by the distro. Would it be possible to release maybe a 0.3.1 to support current SystemSettings and make distributions update their colord-kde package? I hope this is the right way to fix the issue. [1] https://quickgit.kde.org/?p=colord-kde.git Cheers, -- Alessandro Longo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D1963: Guarding the X11 calls not to appear in a wayland session
ivan marked an inline comment as done. ivan added a comment. In https://phabricator.kde.org/D1963#36110, @gladhorn wrote: > Guaring seems like a typo to me. Yes, thanks! REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1963 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, sebas, graesslin, bshah Cc: gladhorn, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D1963: Guarding the X11 calls not to appear in a wayland session
ivan retitled this revision from "Guaring the X11 calls not to appear in a wayland session" to "Guarding the X11 calls not to appear in a wayland session". REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1963 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, sebas, graesslin, bshah Cc: gladhorn, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D1963: Guaring the X11 calls not to appear in a wayland session
ivan marked an inline comment as done. ivan added inline comments. INLINE COMMENTS > bshah wrote in switcherbackend.cpp:197 > cache this value, as it is string comparison and impossible to change at > runtime. Anyone asked Qt guys whether they would like this cached in Qt? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1963 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, sebas, graesslin, bshah Cc: gladhorn, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 51 lines] D1963: Guaring the X11 calls not to appear in a wayland session
ivan updated this revision to Diff 4649. ivan added a comment. Caching the value for 'are we on X11' REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1963?vs=4645=4649 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1963 AFFECTED FILES imports/activitymanager/switcherbackend.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, sebas, graesslin, bshah Cc: gladhorn, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font
dhaumann added a comment. Maybe I should have added: Since you already contacted the Noto devs on the googlegroup, can you also ask whether a bold-face variant and italic variant exists? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, #plasma, #plasma:_design Cc: jensreuterberg, palimaka, dhaumann, mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1963: Guaring the X11 calls not to appear in a wayland session
bshah added inline comments. INLINE COMMENTS > switcherbackend.cpp:197 > { > -if (isReverseTab(m_actionShortcut[ACTION_NAME_PREVIOUS_ACTIVITY])) { > -switchToActivity(Previous); > +if (QX11Info::isPlatformX11()) { > +// If we are on X11, we have all needed features for meta+tab cache this value, as it is string comparison and impossible to change at runtime. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1963 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, sebas, graesslin, bshah Cc: gladhorn, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1963: Guaring the X11 calls not to appear in a wayland session
gladhorn added a comment. Guaring seems like a typo to me. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1963 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, sebas, graesslin, bshah Cc: gladhorn, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 207 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/207/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Jun 2016 15:34:34 + Build duration: 17 min CHANGE SET Revision fb870b6f77666ae4e7914d12b5db92fd3034ee5d by David Edmundson: (Fix krunner build without qalculate) change: edit runners/calculator/calculatorrunner.cpp JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1972/5260 (37%)CONDITIONAL 1382/5392 (26%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/2986 (5%)CONDITIONAL 88/3119 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 45 lines] D1963: Guaring the X11 calls not to appear in a wayland session
ivan created this revision. ivan added reviewers: sebas, graesslin, bshah. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY All x11 methods got the x11_ prefix to be more obvious which parts are x11-only. Added default implementation for wayland sessions, and a note that activity switching using keyboard is a regression compared to x11 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1963 AFFECTED FILES imports/activitymanager/switcherbackend.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, sebas, graesslin, bshah Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1960: Fix krunner build without qalculate
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfb870b6f7766: Fix krunner build without qalculate (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1960?vs=4640=4646 REVISION DETAIL https://phabricator.kde.org/D1960 AFFECTED FILES runners/calculator/calculatorrunner.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, sebas Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 140 lines] D1962: Fix bunch of overrides warnings
bshah created this revision. bshah added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY clang-check as well cppcheck complains about it TEST PLAN builds REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH clang-shut-up (branched from master) REVISION DETAIL https://phabricator.kde.org/D1962 AFFECTED FILES libtaskmanager/abstracttasksmodel.h libtaskmanager/flattentaskgroupsproxymodel.h libtaskmanager/taskfilterproxymodel.h libtaskmanager/taskgroupingproxymodel.h libtaskmanager/tasksmodel.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, #plasma, hein Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1960: Fix krunner build without qalculate
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1960 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, sebas Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 364478] Power settings concerning lid state are ignored / overridden
https://bugs.kde.org/show_bug.cgi?id=364478 --- Comment #3 from Bzzz--- Created attachment 99627 --> https://bugs.kde.org/attachment.cgi?id=99627=edit dbus-monitor log at hibernation cycle from running "dbus-monitor > logmebabyonemoretime.txt" while closing the laptop lid, opening again, unlocking the screen -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 364478] Power settings concerning lid state are ignored / overridden
https://bugs.kde.org/show_bug.cgi?id=364478 --- Comment #2 from Bzzz--- Well, it would be very helpful for a non-dev person to have something to check on. "logind" isn't a separate package to examine, not a single executable, doesn't have a manpage, synaptic doesn't find anything with logind in it, etc. systemd-logind as in the bug report also doesn't really pop up as executable as well. So here's the locate output: locate logind /etc/systemd/logind.conf /lib/systemd/systemd-logind /lib/systemd/system/systemd-logind.service /lib/systemd/system/multi-user.target.wants/systemd-logind.service /usr/lib/libreoffice/share/config/soffice.cfg/uui/ui/logindialog.ui /usr/share/man/man5/logind.conf.5.gz /usr/share/man/man5/logind.conf.d.5.gz /usr/share/man/man8/systemd-logind.8.gz /usr/share/man/man8/systemd-logind.service.8.gz /var/log/upstart/systemd-logind.log.1.gz /var/log/upstart/systemd-logind.log.2.gz /var/log/upstart/systemd-logind.log.3.gz /var/log/upstart/systemd-logind.log.4.gz /var/log/upstart/systemd-logind.log.5.gz /var/log/upstart/systemd-logind.log.6.gz /var/log/upstart/systemd-logind.log.7.gz The gzipped log files are pretty empty (350B max @ 14d uptime and some more power cycles) and especially without timestamps. I can however give the apt-show-versions systemd: systemd:amd64/xenial-updates 229-4ubuntu6 uptodate systemd:i386 not installed kded5 run from console: 16:24:08:~$ kded5 16:24:08:~$ Nothing else shows after closing and re-opening the lid. I'll add an dbus-monitor dump from such a cycle as well. That aside: Doing a manual hibernation now doesn't work, instead the screen lock applies and after unlocking a "Hey, someone else is logged in, now hibernating does require root permission" popup is there. No other tty or graphic session is active, though. All results from ps axo user | sort -u are system accounts plus this one that I'm using right now. So hibernating is actually broken twice: It does when it shouldn't, and it doesn't when it should. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1961: [server] Add resource check in QtExtendedSurfaceInterface::close
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND9ca4f8549f6e: [server] Add resource check in QtExtendedSurfaceInterface::close (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1961?vs=4641=4642 REVISION DETAIL https://phabricator.kde.org/D1961 AFFECTED FILES src/server/qtsurfaceextension_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1961: [server] Add resource check in QtExtendedSurfaceInterface::close
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH surfaceextension-nullptr-check REVISION DETAIL https://phabricator.kde.org/D1961 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 3 lines] D1961: [server] Add resource check in QtExtendedSurfaceInterface::close
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY The QtExtendedSurfaceInterface might be unbound and thus the resource might be null when calling into close. Thus we need to do a nullptr check. Hit a crash there. TEST PLAN Unfortunately no test case as we don't have a client side implementation for this. REPOSITORY rKWAYLAND KWayland BRANCH surfaceextension-nullptr-check REVISION DETAIL https://phabricator.kde.org/D1961 AFFECTED FILES src/server/qtsurfaceextension_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 206 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Jun 2016 13:57:03 + Build duration: 17 min CHANGE SET Revision 8e7f29e435ae142eb560248610786a801f904cdf by David Edmundson: (Find prison 1.2.2 in master) change: edit klipper/CMakeLists.txt Revision 6efdd7a14eb9a41567c2d4418f524b76a37b3a1c by David Edmundson: (Port KIO Remote to use ECM declare logging category) change: edit kioslave/remote/remoteimpl.cpp change: edit kioslave/remote/kio_remote.cpp change: edit kioslave/remote/CMakeLists.txt change: edit kioslave/remote/tests/CMakeLists.txt change: edit kioslave/remote/kdedmodule/CMakeLists.txt change: delete kioslave/remote/kio_remote_debug.cpp change: edit kioslave/remote/kdedmodule/remotedirnotify.cpp change: delete kioslave/remote/kio_remote_debug.h JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1972/5260 (37%)CONDITIONAL 1382/5392 (26%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/2986 (5%)CONDITIONAL 88/3119 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 194 lines] D1814: Add TaskManager requestActivities
davidedmundson updated this revision to Diff 4639. davidedmundson added a comment. Updated with extra proxy model REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1814?vs=4339=4639 BRANCH activities REVISION DETAIL https://phabricator.kde.org/D1814 AFFECTED FILES libtaskmanager/abstracttasksmodel.cpp libtaskmanager/abstracttasksmodel.h libtaskmanager/abstracttasksmodeliface.h libtaskmanager/activityinfo.h libtaskmanager/concatenatetasksproxymodel.cpp libtaskmanager/concatenatetasksproxymodel.h libtaskmanager/flattentaskgroupsproxymodel.cpp libtaskmanager/flattentaskgroupsproxymodel.h libtaskmanager/taskfilterproxymodel.cpp libtaskmanager/taskfilterproxymodel.h libtaskmanager/taskgroupingproxymodel.cpp libtaskmanager/taskgroupingproxymodel.h libtaskmanager/tasksmodel.cpp libtaskmanager/tasksmodel.h libtaskmanager/waylandtasksmodel.cpp libtaskmanager/waylandtasksmodel.h libtaskmanager/xwindowtasksmodel.cpp libtaskmanager/xwindowtasksmodel.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, hein, #plasma Cc: hein, mart, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 7 lines] D1960: Fix krunner build without qalculate
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Compiles, can copy text REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1960 AFFECTED FILES runners/calculator/calculatorrunner.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 205 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/205/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Jun 2016 13:39:20 + Build duration: 17 min CHANGE SET Revision 047715f1c42396d666778cf34bf55bc831bc245e by David Edmundson: (Match Prison version exactly) change: edit klipper/CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1972/5260 (37%)CONDITIONAL 1382/5392 (26%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/2986 (5%)CONDITIONAL 88/3119 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1933: Avoid appending superfluous \n
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMANM1fafa23c80a6: Avoid appending superfluous \n (authored by davidedmundson). REPOSITORY rPLASMANM Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1933?vs=4582=4638 REVISION DETAIL https://phabricator.kde.org/D1933 AFFECTED FILES libs/declarative/networkstatus.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, graesslin Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1952: Don't set width and height in a layout
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPdf9e2d1f329b: Don't set width and height in a layout (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1952?vs=4623=4637 REVISION DETAIL https://phabricator.kde.org/D1952 AFFECTED FILES toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, broulik Cc: broulik, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1954: Port KIO Remote to use ECM declare logging category
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6efdd7a14eb9: Port KIO Remote to use ECM declare logging category (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1954?vs=4625=4636 REVISION DETAIL https://phabricator.kde.org/D1954 AFFECTED FILES kioslave/remote/CMakeLists.txt kioslave/remote/kdedmodule/CMakeLists.txt kioslave/remote/kdedmodule/remotedirnotify.cpp kioslave/remote/kio_remote.cpp kioslave/remote/kio_remote_debug.cpp kioslave/remote/kio_remote_debug.h kioslave/remote/remoteimpl.cpp kioslave/remote/tests/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, graesslin Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1933: Avoid appending superfluous \n
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMANM Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D1933 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, graesslin Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.
davidedmundson closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1949 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, broulik, graesslin Cc: graesslin, broulik, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1956: Create logging categories via CMake
davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in CMakeLists.txt:10 > Why SYSTEM_TRAY and not SYSTEMTRAY? It looks like lots was touched just to > add the underscore. Good question, with a very frustrating answer. otherwise macro creates a file with the guard SYSTEMTRAY_H which is the guard of this file. see https://git.reviewboard.kde.org/r/128231/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1956 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: graesslin, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1950: Match Prison version exactly
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, bshah Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma Hangout
Minutes Plasma 'hangout', 20-6-2016, 12:00 CET Present: mgraesslin, bshah, Sho, sebas, Riddell, Jens, Andreas, d_ed mgraesslin: * Since Tuesday on Plasma/Wayland session * Major WTF moment: if a surface gets created for an id, which was used for a previous surface it will have the same wl_resource pointer on the server - this applies to all Resource sub classes. Was cause for applications exiting with errors * Fixed multi-screen positioning in KWin * Fixed a few crashers * Biggest problems of Wayland usage so far: ** lacking clipboard between X11 and Wayland ** Notifications steal focus ** ctrl-modifier shortcuts in applications do not work (Qt 5.7 regression? Works on my Qt 5.6 system) ** modifiers not cleared in XWayland * heading to openSUSE Conf tomorrow, will give presentation about how Wayland helps to improve our quality Riddell: - Plasma 5.7 beta was released (by David, also thanks to Kai for the announcement!) bshah: - got DRM drivers for Nexus5, seem to load well - needs some more adjustments, but looks promising - new mobile image is under way Jens / Andreas: - work on login screen didn't get much good feedback from beta - is an unfinished part of a greater concept, will be reintroduced when the whole thing is more complete - also has some technical problems - some work on Kirigami sebas: - kscreen bug triaging - multimonitor tests (focus shifting to docking station use cases) - still not a lot of test feedback (though some really positive) - got a new 4K screen, may need a new video card now :/ - windowmetadata thumbnails now working quite well (code is in scratch/sebas/ windowmetadata incl autotests, testapps, etc.; let me know if you're looking into it) - store sprint aftermath d_ed: - helped lots of people with Plasma - working on making ksplash more reliable - helped with the developer side of the login screen work - reviewed lots of the new taskmanager code - did some other stuff he already forgot about ;) -- sebas http://www.kde.org | http://vizZzion.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1953: Fix XembedSNIProxy Logging Category Registration
davidedmundson added a comment. In https://phabricator.kde.org/D1953#36014, @graesslin wrote: > What was wrong with it? The old code looks correct to me as well. So what does this change "Fix"? I had two Q_LOGGING_CATEGORY's one made by the marco, one done by hand. Then I was managing to not link the one in the macro. (two wrongs make a right) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1953 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: graesslin, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 204 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/204/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Jun 2016 10:51:05 + Build duration: 24 min CHANGE SET Revision c680b2ea8925271158efe1c135a1c12cc1d87fd8 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit applets/batterymonitor/package/metadata.desktop JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1972/5260 (37%)CONDITIONAL 1382/5392 (26%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/2986 (5%)CONDITIONAL 88/3119 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font
jensreuterberg added a comment. From a design perspective this is a no-brainer. Using another font is meaningless. So we in the VDG obviously approve of a switch to Noto Mono. (that said I cant comment on the technical issues only the design ones) REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, #plasma, #plasma:_design Cc: jensreuterberg, palimaka, dhaumann, mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Translation of click events to touch events in kwin.
On Thu, Jun 9, 2016 at 11:35 AM, Martin Graesslinwrote: > So the important things are: > * create a KWayland::Server::Display which is setup to use > ConnectClientsOnly > * it uses createClient on an anonymous socketpair > * it needs to create at least the following interfaces: > ** shm > ** compositor > ** seat (with at least touch) > ** shell > ** output which has a size mapped to the size of the QQuickItem > * it starts kwin_wayland with WAYLAND_SOCKET passed to the socket pair > Hello Martin, I have made some changes, however at this point I want confirmation if my changes are correct and want to clear confusion on how to start kwin. Here are rough changes I've made : https://paste.kde.org/pv2lvz7af Questions I have are: 1) The changes that i have made so far, are they correct? 2) How to start kwin_wayland? Using QProcess? Thanking you in advance. Awaiting for your earliest reply. With Regards, Bhavisha Dhruve ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 203 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Jun 2016 09:13:48 + Build duration: 9 min 42 sec CHANGE SET Revision 862880a973c9b4b4beda5c8a763adee269459603 by David Edmundson: ([System Tray] Properly position plasmoid context menu) change: edit applets/systemtray/systemtray.h change: edit applets/systemtray/systemtray.cpp change: edit applets/systemtray/package/contents/ui/items/PlasmoidItem.qml Revision 158b70c450da2881b42c9fd69819a57f48333f90 by David Edmundson: (Revert quot;Restore last selected userquot;) change: edit lookandfeel/contents/loginmanager/Login.qml Revision a8aaab211576b89450290b596b3db35aea44aaf3 by David Edmundson: (Revert quot;Fix i18nquot;) change: edit lookandfeel/contents/loginmanager/Main.qml Revision ed26041eec9701aed5ed27a0265aae26fcc04286 by David Edmundson: (Revert quot;Use correct icon for user selectquot;) change: edit lookandfeel/contents/loginmanager/UserDelegate.qml change: delete lookandfeel/contents/loginmanager/user-none.svg Revision ada6e0c5cfc34297fcc2ff21aa63bc66416fb1b8 by David Edmundson: (Revert quot;[Login Screen] Add hint about active caps lockquot;) change: edit lookandfeel/contents/loginmanager/Login.qml change: edit applets/systemtray/package/contents/ui/main.qml Revision 07d3036abcf9b6790c0b48dd1ff07e09d36fe1c9 by David Edmundson: (Revert quot;[Splash Screen] Take into account device pixel ratioquot;) change: edit lookandfeel/contents/splash/Splash.qml Revision 6d5077bb9646e00075598a444c82c8b6d9557018 by David Edmundson: (Revert quot;[Splash Screen] Change design to match new login screenquot;) change: edit lookandfeel/contents/splash/Splash.qml Revision ff8d5b59f4b796da77e7c32f9264b2585dc02c51 by David Edmundson: (Revert quot;Make faces size biggerquot;) change: edit lookandfeel/contents/loginmanager/UserDelegate.qml change: edit lookandfeel/contents/loginmanager/UserList.qml Revision abf67a41d319f750a56d394cdb0f2cf344a1cb00 by David Edmundson: (Revert quot;Correct margin for user searchquot;) change: edit lookandfeel/contents/loginmanager/UserDelegate.qml Revision bd5f0949dc32788fd8668c0bd535431341bf7807 by David Edmundson: (Revert quot;[Login Screen] Add large clockquot;) change: edit lookandfeel/contents/loginmanager/Login.qml change: edit lookandfeel/contents/loginmanager/Main.qml Revision f938ea02a15234034115f657c088c49cf5c067f3 by David Edmundson: (Revert quot;[Login Screen] Avoid binding source to visiblequot;) change: edit lookandfeel/contents/loginmanager/UserDelegate.qml Revision fbd82ca319784686a32e3f4897a61ccaa0552d2b by David Edmundson: (Revert quot;Keep forceActiveFocus hack from old SDDM theme to new themequot;) change: edit lookandfeel/contents/loginmanager/Login.qml Revision 04d82d56850e85ebeb10043c8077d25396cf2cd6 by David Edmundson: (Revert quot;[Lock Screen] Use generic Plasma blue backgroundquot;) change: edit lookandfeel/contents/lockscreen/LockScreen.qml Revision aa03e7d49d8acbaaf3796b071a5251db02d059c8 by David Edmundson: (Revert quot;New login screenquot;) change: edit lookandfeel/contents/loginmanager/Main.qml change: delete lookandfeel/contents/loginmanager/UserList.qml change: delete lookandfeel/contents/loginmanager/Login.qml change: add lookandfeel/contents/loginmanager/breeze.jpg change: edit lookandfeel/contents/loginmanager/dummydata/userModel.qml change: delete lookandfeel/contents/loginmanager/Background.qml change: delete lookandfeel/contents/loginmanager/SessionButton.qml change: edit lookandfeel/contents/loginmanager/dummydata/keyboard.qml change: edit lookandfeel/contents/loginmanager/theme.conf change: delete lookandfeel/contents/loginmanager/UserDelegate.qml change: edit lookandfeel/contents/loginmanager/dummydata/sddm.qml change: delete lookandfeel/contents/loginmanager/KeyboardButton.qml change: edit lookandfeel/contents/loginmanager/dummydata/config.qml change: edit lookandfeel/contents/loginmanager/dummydata/screenModel.qml change: edit lookandfeel/contents/loginmanager/dummydata/sessionModel.qml Revision 5e49113cd61ea43f636c7225d623b4ae871b9bf9 by David Edmundson: (keep an i18n alive after the revert as we know we#039;re going to be using) change: edit lookandfeel/contents/loginmanager/Main.qml Revision f750272512538d55644ec95b08dca3adbfd6d6c9 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit templates/ion-dataengine/src/ion-%{APPNAMELC}.desktop change: edit runners/baloo/plasma-runner-baloosearch.desktop Revision bfbf06ef8f3c6a135e4765b691696a10ad22ea84 by hein: (Fix launchers getting lost on DND resorts when using 5.6-style config.) change: edit libtaskmanager/tasksmodel.cpp JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed:
[Differential] [Closed] D1937: [server] Unset SurfaceInterface pointer in referenced objects when being destroyed
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND6f67aff9cbe1: [server] Unset SurfaceInterface pointer in referenced objects when being… (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1937?vs=4591=4635#toc REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1937?vs=4591=4635 REVISION DETAIL https://phabricator.kde.org/D1937 AFFECTED FILES autotests/client/test_plasmashell.cpp autotests/client/test_wayland_shell.cpp src/server/plasmashell_interface.cpp src/server/qtsurfaceextension_interface.cpp src/server/shell_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, bshah Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fonts rendering in titlebars with KDecoration2
On Monday June 20 2016 04:16:14 Christoph Feck wrote: > >No. Oxygen and Breeze use QPainter, not Qt Quick. Then we're back to my original question: why do their window titles look so off? R. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 202 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/202/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Jun 2016 05:56:31 + Build duration: 17 min CHANGE SET Revision 524066ca22c40c9928814a64b04d345139736e01 by kainz.a: (update alignement for system monitoring applets REVIEW: 128136) change: edit applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml change: edit applets/systemmonitor/common/contents/ui/SinglePlotter.qml change: edit applets/systemmonitor/common/contents/ui/DoublePlotter.qml change: edit applets/systemmonitor/common/contents/ui/Applet.qml change: edit applets/systemmonitor/cpu/contents/ui/cpu.qml JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1972/5260 (37%)CONDITIONAL 1382/5392 (26%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/2986 (5%)CONDITIONAL 88/3119 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Changed Subscribers] D1956: Create logging categories via CMake
graesslin added inline comments. INLINE COMMENTS > CMakeLists.txt:10 > +ecm_qt_declare_logging_category(systemtray_SRCS HEADER debug.h > +IDENTIFIER SYSTEM_TRAY > +CATEGORY_NAME kde.systemtray Why SYSTEM_TRAY and not SYSTEMTRAY? It looks like lots was touched just to add the underscore. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1956 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: graesslin, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1954: Port KIO Remote to use ECM declare logging category
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, graesslin Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1953: Fix XembedSNIProxy Logging Category Registration
graesslin added a comment. What was wrong with it? The old code looks correct to me as well. So what does this change "Fix"? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1953 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: graesslin, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.
graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. go for it REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1949 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, broulik, graesslin Cc: graesslin, broulik, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel