Re: Translation of click events to touch events in kwin.
Am 2016-06-22 11:00, schrieb Bhavisha Dhruve: On Wed, Jun 22, 2016 at 1:48 PM, Martin Gräßlin wrote: I don't like the name KWinApp, though as that can be confused with the static method kwinApp in KWin. So I'd suggest to rename it. Hello Martin, In sometime i will put the code on phabricator. Regarding name, well it would be really kind if you could give any suggestions for the same. Feel free to come up with a name by your own. I'm not very good in finding good names and have to change them quite often again ;-) Cheers Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1976: Image of the Day wallpaper plugin
graesslin added a comment. You might have seen that I have an open differential request to integrate Plasma Wallpapaer into kscreenlocker. This makes me ask the question: how will this wallpaper plugin look like if you don't have an internet connection? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bgupta, #plasma Cc: graesslin, davidedmundson, plasma-devel, #plasma, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1976: Image of the Day wallpaper plugin
bgupta added inline comments. INLINE COMMENTS > davidedmundson wrote in config.qml:27 > If you switch these to ColumnLayout / RowLayout (from QtQuick.Layouts, which > you're currently not using) you can get rid of a lot of the anchors and > widths in this code. I was initially using ColumnLayout, but the problem there was that the contents were expanding to fill the entire height of the dialog, with huge spacing between rows. Using Column just works. > davidedmundson wrote in config.qml:56 > it defeats the point of having spacing as semanticly defined macros, if > people then do maths with it to get any arbitrary value I looked at `config.qml` files from the color and image wallpaper plugins from `plasma-workspace`. They seem to do things like this, so I did the same. > davidedmundson wrote in config.qml:106 > this won't acheive anything > > you've set a width, but by default there's no eliding, so it'll just overflow > past here anyway. I don't see any overflow on my computer. Is there any? > davidedmundson wrote in config.qml:264 > why? The objectName? Setting an objectName is something that I do by force of habit since trying to add QML bits to Spectacle (to be able to get to objects from the C++ side by name), but of course there's no use for objectNames here. I'll remove them in a later pass. > davidedmundson wrote in main.qml:93 > where is resetTimer defined? Ah yes, I forgot to remove that line. > davidedmundson wrote in main.qml:105 > we generally try to avoid pixel sizes. What would be an appropriate substitute in this case? units.smallSpacing? > davidedmundson wrote in main.qml:111 > why? > > you're displaying this at a fixed size It's true that there's no regular scaling involved. I clearly misunderstood the point of mipmap scaling over regular smoothing. I'll swap this in favour of smoothing. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bgupta, #plasma Cc: davidedmundson, plasma-devel, #plasma, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 22 Jun 2016 22:22:23 + Build duration: 5 min 43 sec CHANGE SET Revision 6b18c200bba03ba876ecc886ccd78410fc4efd37 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit applets/legacyicontasks/metadata.desktop change: edit applets/legacytaskmanager/package/metadata.desktop ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 215 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/215/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 22 Jun 2016 21:58:53 + Build duration: 19 min CHANGE SET Revision 1abaaa55e908c19b82ec2ff57cbfc83bf09005ca by David Faure: (add_definitions(-DQT_NO_URL_CAST_FROM_STRING) + fix compilation) change: edit liblegacytaskmanager/taskitem.cpp change: edit CMakeLists.txt change: edit libtaskmanager/xwindowtasksmodel.cpp change: edit runners/places/placesrunner.cpp change: edit runners/recentdocuments/recentdocuments.cpp change: edit dataengines/weather/ions/wetter.com/ion_wettercom.cpp change: edit kioslave/remote/kdedmodule/remotedirnotify.cpp change: edit libtaskmanager/tasksmodel.cpp change: edit drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp change: edit libtaskmanager/autotests/launchertasksmodeltest.cpp change: edit dataengines/share/shareprovider.cpp change: edit dataengines/weather/ions/noaa/ion_noaa.cpp change: edit dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1972/5303 (37%)CONDITIONAL 1382/5460 (25%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3029 (5%)CONDITIONAL 88/3187 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1976: Image of the Day wallpaper plugin
davidedmundson added a comment.
Seems generally good.
INLINE COMMENTS
> config.qml:27
> +
> +Column {
> +id: root;
If you switch these to ColumnLayout / RowLayout (from QtQuick.Layouts, which
you're currently not using) you can get rid of a lot of the anchors and widths
in this code.
> config.qml:56
> +id: sizePositionRow;
> +spacing: units.largeSpacing / 2;
> +
it defeats the point of having spacing as semanticly defined macros, if people
then do maths with it to get any arbitrary value
> config.qml:106
> +
> +width: formAlignment - units.largeSpacing;
> +anchors.verticalCenter: bgColorButton.verticalCenter;
this won't acheive anything
you've set a width, but by default there's no eliding, so it'll just overflow
past here anyway.
> config.qml:264
> +id: bgColorDialog;
> +objectName: "bgColorDialog";
> +
why?
> main.qml:93
> +changeImage();
> +resetTimer();
> +}
where is resetTimer defined?
> main.qml:105
> +anchors.bottomMargin: Math.min((parent.height / 100) * 7.5,
> (parent.width / 100) * 7.5);
> +anchors.rightMargin: 5;
> +opacity: 0.25;
we generally try to avoid pixel sizes.
> main.qml:111
> +asynchronous: true;
> +mipmap: true;
> +}
why?
you're displaying this at a fixed size
REPOSITORY
rKDEPLASMAADDONS Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D1976
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bgupta, #plasma
Cc: davidedmundson, plasma-devel, #plasma, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 364649] Unable to configure power management
https://bugs.kde.org/show_bug.cgi?id=364649 John changed: What|Removed |Added Version|unspecified |5.5.5 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 364649] New: Unable to configure power management
https://bugs.kde.org/show_bug.cgi?id=364649 Bug ID: 364649 Summary: Unable to configure power management Product: Powerdevil Version: unspecified Platform: openSUSE RPMs OS: Linux Status: UNCONFIRMED Severity: major Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: wguy4...@comcast.net I am using KDE 4.14.18 with powerdevil 5.5.5-9.1 and there is no power management daemon in the Service Manager list and no power management configuration in in the system settings list; as a result, i cannot configure poer management. Reproducible: Always Steps to Reproduce: 1. Use KDE 2. 3. Actual Results: No power management Expected Results: Ability to manage power, including auto hibernation I am using SuSE Leap 42.1 on a desktop, i.e. it is always plugged in, but i use power management to automatically hibernate if not used for too long. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 4 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 22 Jun 2016 18:00:53 + Build duration: 6 min 21 sec CHANGE SET Revision 6df109ac61700f05012782759a8d8f4d5ddfb266 by scripty: (SVN_SILENT made messages (after extraction)) change: edit org.kde.plasmashell.metainfo.xml ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D1976: Image of the Day wallpaper plugin
bgupta added a reviewer: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bgupta, #plasma Cc: plasma-devel, #plasma, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 788 lines] D1976: Image of the Day wallpaper plugin
bgupta created this revision. bgupta added a subscriber: Plasma. bgupta set the repository for this revision to rKDEPLASMAADDONS Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch adds a wallpaper plugin to Plasma, which fetches an "Image of the Day", or a random image, from an Internet source. Current sources include: - Bing - NASA Astronomy Picture of the Day - Random featured image from Unsplash.com Sources can be enabled and disabled, and a fallback default image can be specified, which is displayed if an image cannot be fetched from the Internet. The image change interval can be configured to be anything between 15 minutes to 23 hours and 59 minutes. A logo for the source and credit text is superimposed on the bottom right corner of the wallpaper. TEST PLAN This was tested manually while being written. I use this plugin as my wallpaper. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 AFFECTED FILES wallpapers/CMakeLists.txt wallpapers/iotd/CREDITS wallpapers/iotd/README wallpapers/iotd/contents/assets/bing.svg wallpapers/iotd/contents/assets/default.svg wallpapers/iotd/contents/assets/nasa.svg wallpapers/iotd/contents/assets/unsplash.svg wallpapers/iotd/contents/config/main.xml wallpapers/iotd/contents/ui/config.qml wallpapers/iotd/contents/ui/main.qml wallpapers/iotd/contents/ui/sources.js wallpapers/iotd/metadata.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bgupta Cc: plasma-devel, #plasma, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 4 lines] D1974: Don't set both font and pixel size in DigitalClock
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Digital Clock sets fontSizeMode, this scales the font to fit between a tiny size and a the given size. In older Qt this used to be between 0 and pixel size - but because Plasma.Components.Label already set the pointSize we had to set both. In Qt 5.6 it seems to handle either type of font size being set, so we can keep with just one. TEST PLAN Clock still scales to fill space Clock still switches into compact mode if needed REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1974 AFFECTED FILES applets/digital-clock/package/contents/ui/DigitalClock.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 371 lines] D1973: Support for syncing the clipboard from X11 to Wayland and vice versa
graesslin created this revision. graesslin added reviewers: Plasma on Wayland, KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The clipboard sync is done by a dedicated helper binary launched by KWin. This helper binary is forced to xcb platform to picky-back on Qt's implementation of the X11 clipboard. In addition it implements the Wayland clipboard - which is much simpler. Reading the Wayland clipboard is based on the implementation in QtWayland. KWin internally knows the DataDeviceInterface belonging to the helper application. Whenever an xwayland client is focussed, this DataDevice is allowed to set the selection and KWin manually updates the current selection in the SeatInterface. By that the sync from X11 to Wayland is implemented. When afterwards a Wayland client is selected, it's sent the current selection which references the X clipboard and a data transfer can be initiated in the normal Wayland way. For the other direction KWin sends the current selection to the helper's DataDevice whenever an xwayland window is focused. The helper application reads the Wayland clipboard and sets it on the X11 clipboard. Thus the Wayland clipboard is synced to X11. The approach used here will also be useful for implementing a clipboard manager (aka klipper). Currently the implementation is not yet fully completed. We need to make sure that the helper application gets restarted in case of a crash. TEST PLAN Test cases still missing. I'm not exactly sure how I can test this. But running the code currently and happily copy/paste. REPOSITORY rKWIN KWin BRANCH xclipboard-syncer REVISION DETAIL https://phabricator.kde.org/D1973 AFFECTED FILES CMakeLists.txt config-kwin.h.cmake helpers/CMakeLists.txt helpers/xclipboardsync/CMakeLists.txt helpers/xclipboardsync/main.cpp helpers/xclipboardsync/waylandclipboard.cpp helpers/xclipboardsync/waylandclipboard.h keyboard_input.cpp wayland_server.cpp wayland_server.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, #kwin Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D1973: Support for syncing the clipboard from X11 to Wayland and vice versa
graesslin added a dependency: D1972: [server] Add support for setting the clipboard selection DataDeviceInterface manually. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1973 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, #kwin Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D1972: [server] Add support for setting the clipboard selection DataDeviceInterface manually
graesslin added a dependent revision: D1973: Support for syncing the clipboard from X11 to Wayland and vice versa. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1972 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 66 lines] D1972: [server] Add support for setting the clipboard selection DataDeviceInterface manually
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY So far SeatInterface handled automatically which DataDeviceInterface holds the current clipboard selection. While this works fine and is currect it doesn't support use cases like a clipboard manager where the clipboard is hold by a different ClientConnection than the one from the focused keyboard. This change allows to manually set the selected DataDeviceInterface to override the automatic selection, though the automatic selection is still in place. Thus the next update of a selection will override the manually set selection again. REPOSITORY rKWAYLAND KWayland BRANCH selection REVISION DETAIL https://phabricator.kde.org/D1972 AFFECTED FILES autotests/client/test_datadevice.cpp autotests/client/test_wayland_seat.cpp src/server/seat_interface.cpp src/server/seat_interface.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1780: Expose the transientFor relationship to PlasmaWindowInterface
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH transient-for-plasma-window REVISION DETAIL https://phabricator.kde.org/D1780 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, hein, #plasma_on_wayland, sebas Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 3 lines] D1811: UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This ensures that resizing a panel updates the client area. On X11 there is an event when the struts change, but on Wayland the struts are implied from window type (panel) and the panel behavior, so we need to trigger it manually. REPOSITORY rKWIN KWin BRANCH update-struts-on-geometry-change REVISION DETAIL https://phabricator.kde.org/D1811 AFFECTED FILES shell_client.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, hardening, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 39 lines] D1808: Introduce a RequestGeometryBlocker in ShellClient
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The idea is to not send multiple resize requests to a client when we know that we might have multiple geometry changes. E.g. when going from maximized to restored the borders change and trigger a resize in addition to the resize from switching to restored. The implementation is inspired by the GeometryUpdateBlocker. REPOSITORY rKWIN KWin BRANCH request-geometry-blocker REVISION DETAIL https://phabricator.kde.org/D1808 AFFECTED FILES autotests/wayland/maximize_test.cpp shell_client.cpp shell_client.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, hardening, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1805: Pass the maximized signal to DecoratedClient
broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> maximize_test.cpp:141
> #define CLEANUP(name) \
> if (name) { \
> delete name; \
Not related to this patch but delete nullptr is totally fine and if it's a
dangling pointer the check won't help you anyway.
REPOSITORY
rKWIN KWin
BRANCH
decoration-pass-maximized-signal
REVISION DETAIL
https://phabricator.kde.org/D1805
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: broulik, plasma-devel, kwin, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 59 lines] D1805: Pass the maximized signal to DecoratedClient
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. REPOSITORY rKWIN KWin BRANCH decoration-pass-maximized-signal REVISION DETAIL https://phabricator.kde.org/D1805 AFFECTED FILES autotests/wayland/maximize_test.cpp decorations/decoratedclient.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 6 lines] D1780: Expose the transientFor relationship to PlasmaWindowInterface
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Compiles REPOSITORY rKWIN KWin BRANCH transient-for-plasma-window REVISION DETAIL https://phabricator.kde.org/D1780 AFFECTED FILES abstract_client.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, hein Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD
colomar added a comment. Martin is right, OSDs are not only about keyboard shortcuts. They are quite difficult to describe clearly without relying on technical terms, however. Maybe "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user interface"? I think that's what they all have in common, because things done in the GUI should never trigger an OSD. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, graesslin Cc: colomar, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Translation of click events to touch events in kwin.
On Wed, Jun 22, 2016 at 1:48 PM, Martin Gräßlin wrote: > I don't like the name KWinApp, though as that can be confused with the > static method kwinApp in KWin. So I'd suggest to rename it. Hello Martin, In sometime i will put the code on phabricator. Regarding name, well it would be really kind if you could give any suggestions for the same. Awaiting for your earliest reply. Thanking you in advance. With Regards, Bhavisha Dhruve ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Translation of click events to touch events in kwin.
Am 2016-06-20 11:32, schrieb Bhavisha Dhruve: On Thu, Jun 9, 2016 at 11:35 AM, Martin Graesslin wrote: So the important things are: * create a KWayland::Server::Display which is setup to use ConnectClientsOnly * it uses createClient on an anonymous socketpair * it needs to create at least the following interfaces: ** shm ** compositor ** seat (with at least touch) ** shell ** output which has a size mapped to the size of the QQuickItem * it starts kwin_wayland with WAYLAND_SOCKET passed to the socket pair Hello Martin, I have made some changes, however at this point I want confirmation if my changes are correct and want to clear confusion on how to start kwin. Here are rough changes I've made : https://paste.kde.org/pv2lvz7af [1] Questions I have are: 1) The changes that i have made so far, are they correct? Yes that seems mostly correct. I don't like the name KWinApp, though as that can be confused with the static method kwinApp in KWin. So I'd suggest to rename it. Otherwise there are a few things I just noticed when reading through the code, but as it's difficult to comment here I'd suggest to put it on phab, so that we can properly annotate the code. 2) How to start kwin_wayland? Using QProcess? Yes, QProcess is just fine. Cheers Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
