[Differential] [Updated] D1989: Introduce QQuickItem to nest kwin_wayland
graesslin added a comment.
I wouldn't put the kwinqml into the qml subdirectory. As it's a plugin I
think the plugins directory is a better target. Maybe
plugins/qtquick/kwinwrapper - not sure about the last part of the path. If you
have better ideas, go for it.
INLINE COMMENTS
> kwinqml.cpp:22-23
> +{
> +}
> +void KWinQml::start()
> +{
empty line please
> kwinqml.cpp:44
> +if (socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, sx) < 0) {
> +QCoreApplication::instance()->exit(1);
> +return;
I wouldn't terminate the application from the QtQuick module. That must be more
graceful.
> kwinqml.cpp:50
> +if (socket == -1) {
> +QCoreApplication::instance()->exit(1);
> +return;
same here
> kwinqml.cpp:56
> +QProcessEnvironment environment =
> QProcessEnvironment::systemEnvironment();
> +environment.insert(QStringLiteral("QT_QPA_PLATFORM"),
> QStringLiteral("wayland"));
> +environment.insert(QStringLiteral("WAYLAND_SOCKET"),
> QString::fromUtf8(QByteArray::number(socket)));
no need to set the QT_QPA_PLATFORM, kwin overrides it anyway.
> kwinqml.cpp:62
> +arguments << "--xwayland";
> +kwinWayland->start("kwin_wayland", arguments);
> +}
we should try to get the install path of kwin_wayland here to make sure our
binary is started and not some PATH overwritten one. An example of how to do
this is in https://phabricator.kde.org/D1973 with the difference that
kwin_wayland is installed to bin instead of libexec
> kwinqml.h:17
> +Q_OBJECT
> +Q_PROPERTY(QString socketName READ socketName WRITE setSocketName NOTIFY
> socketNameChanged)
> +
what's the idea behind the socketName? It's not yet used anywhere.
> kwinqml.h:23-27
> +void setSocketName(const QString socketName)
> +{
> +m_name = "kwin-plasma-emulator-0";
> +emit socketNameChanged(socketName);
> +}
this doesn't set the m_name to socketName
> kwinqml.h:34
> +
> +Q_INVOKABLE void start();
> +
instead of using start which needs to be invoked manually, you could also react
on the initialization completed in the QQuickItem
> kwinqml.h:40
> +private:
> +QString m_name;
> +KWayland::Server::Display *m_display = nullptr;
why m_name and not m_socketName?
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D1989
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, #plasma_on_wayland
Cc: graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/#review96844 --- Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done: 1. KF 5.23.0 2. Plasma 5.6.5 3. MiminizeAll applet latest snapshot from github (May 31, 2016) 4. ShowDesktop applet from Plasma 5.6.5. I added MinimizeAll abd ShowDesktop applets to panel and assigned different keyboard shortcuts to them. ShowDesktop works via shortcut while MinimizeAll doesn't. - Andrey Bondrov On Апрель 28, 2016, 8:11 д.п., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127651/ > --- > > (Updated Апрель 28, 2016, 8:11 д.п.) > > > Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > > ^^ > > > Diffs > - > > applets/CMakeLists.txt e591c81 > applets/minimizeall/CMakeLists.txt PRE-CREATION > applets/minimizeall/Messages.sh PRE-CREATION > applets/minimizeall/package/contents/config/main.xml PRE-CREATION > applets/minimizeall/package/contents/ui/main.qml PRE-CREATION > applets/minimizeall/package/metadata.desktop PRE-CREATION > applets/minimizeall/plugin/minimizeall.h PRE-CREATION > applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION > applets/minimizeall/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127651/diff/ > > > Testing > --- > > > File Attachments > > > Screenshot_20160428_110625.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2dc7f4c9-c10a-4166-95d7-67418ad9ce7f__Screenshot_20160428_110625.png > > > Thanks, > > Anthony Fieroni > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 4 lines] D1998: Make sure to unmute when changing volume with hotkeys
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 364686 REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1998 AFFECTED FILES applet/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D1998: Make sure to unmute when changing volume with hotkeys
drosca added a reviewer: xuetianweng. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1998 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, xuetianweng Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1998: Make sure to unmute when changing volume with hotkeys
xuetianweng accepted this revision. xuetianweng added a comment. This revision is now accepted and ready to land. LGTM tested on my desktop. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1998 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, xuetianweng Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Plasma Workspace Wallpapers] [Bug 364724] New: Workspace and wallpapers misaligned on multiple monitors in portrait rotation
https://bugs.kde.org/show_bug.cgi?id=364724 Bug ID: 364724 Summary: Workspace and wallpapers misaligned on multiple monitors in portrait rotation Product: Plasma Workspace Wallpapers Version: 5.5.5 Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED Severity: major Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: allenwjo...@gmail.com When more than one monitor has been added to the xscreen in portrait rotation, the workspace may remain in landscape mode and overlap to the adjacent monitor(s). I have seen this specifically on my 3x1200x1600 xscreen configuration. If you click on each monitor's background, it is as though the workspace 'comes to surface' and changes the overlap. Sometimes one or more of the workspaces align properly (usually only primary display). Click/Right click in blank areas has no effect compared to click/right click into visible areas. Mouse pointer can access blank areas and windows/fullscreen is not prohibited from those areas. Reproducible: Always Steps to Reproduce: 1. Configure multiple monitors from Display Manager or NVidia Application 2. Reboot and Logon 3. Click around on each monitor 4. Open a window, maximize or move Actual Results: One or more of the workspaces doesn't align with the xscreen configuration and doesn't properly display/align wallpaper. Expected Results: Expected workspace/wallpaper to properly align to xscreen configuration. Initial login screen is in landscape rotation which makes logon sideways, but all screens are properly aligned in that rotation. Locking the workspace and logging in can sometimes align all screens but doesn't last if rebooted. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 4 lines] D2000: Make it possible to adjust volume even if it's muted
xuetianweng created this revision. xuetianweng added a reviewer: drosca. xuetianweng added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Do not disable the slider if it's muted. It would be more convinient if it's possible to change muted item volume, just like other mixers. Also unmute the device/stream if it's muted at the same time. Unfortunately, I didn't find a way to pretend to be visually disabled, thus here we use opacity to get the similar visual feedback. TEST PLAN test on my desktop REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2000 AFFECTED FILES applet/contents/ui/ListItemBase.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 7 lines] D2000: Make it possible to adjust volume even if it's muted
xuetianweng updated this revision to Diff 4714. xuetianweng added a comment. also do the same thing to kcm's slider REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2000?vs=4713&id=4714 BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2000 AFFECTED FILES applet/contents/ui/ListItemBase.qml src/kcm/package/contents/ui/VolumeSlider.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, drosca Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 217 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/217/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 24 Jun 2016 23:15:21 + Build duration: 17 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1972/5303 (37%)CONDITIONAL 1382/5460 (25%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3029 (5%)CONDITIONAL 88/3187 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
