[Breeze] [Bug 365264] The color of the border in the bottom of the panel is very bright.

[ELAV via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365264

--- Comment #1 from ELAV  ---
Created attachment 99957
  --> https://bugs.kde.org/attachment.cgi?id=99957=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 365264] New: The color of the border in the bottom of the panel is very bright.

[ELAV via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365264

Bug ID: 365264
   Summary: The color of the border in the bottom of the panel is
very bright.
   Product: Breeze
   Version: 5.7.0
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: elavdevelo...@gmail.com

The color of the border in the bottom of the panel is very bright. I think it
should be darker or may not be present when a maximized application gets the
focus.

Reproducible: Always

Steps to Reproduce:
1. Set the theme Breeze-Dark.
2. Plasma panel put on top.


Actual Results:  
A border is displayed at the bottom of the panel with a color that bothers
according to the color used for the issue of KWin.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Big font and icon sizes on master

[Jan Kundrát]

Hi,
after my recent upgrade of all of KF5 and Plasma to git master from git 
master from around 2016-06-21, the icon sizes in the System Tray and the 
font size in my clock applet are now huge -- see the attached image.


Please note that my panel is vertical, on the right edge of the display. I 
also tend to switch screens, but the wrong size is present also right after 
login.


(Please let me know if you would prefer me to submit this over bugzilla, 
trello, phabricator or IRC, I don't really care about the channel.)


Cheers,
Jan

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Marco Martin]

> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote:
> > Visual aspects should stay under the theme's control. Therefore, from the 
> > usability perspective, there should be no user option, instead the look & 
> > feel theme should be able to control the icon size.
> 
> John Salatas wrote:
> I don't think that currently the theme controls it. It scales to follow 
> the panel's size up to a certain size which is hardcoded: 
> units.iconSizes.medium
> 
> Why units.iconSizes.medium and not units.iconSizes.smallMedium? Is this a 
> design decision or just a random pickup? :\
> 
> What I'm proposing here is let the user choose instead of having an 
> arbitrary maximum size hardcoded. :\

i do think smallmedium would be a better default.
in order to do as Thomas suggests, it can have the configuration value, but not 
exposed from the config dialog (and yeah, defaulting to smallmedium).
then, look and feel packages can contain default setups for applets, it would 
be that one that make it theme-controlled.

Also, i would save in the config smallmedium/medium etc, instead of a pixel 
size value, in order to still survive DPI changes, screen migration etc.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97212
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote:
> > Visual aspects should stay under the theme's control. Therefore, from the 
> > usability perspective, there should be no user option, instead the look & 
> > feel theme should be able to control the icon size.

I don't think that currently the theme controls it. It scales to follow the 
panel's size up to a certain size which is hardcoded: units.iconSizes.medium

Why units.iconSizes.medium and not units.iconSizes.smallMedium? Is this a 
design decision or just a random pickup? :\

What I'm proposing here is let the user choose instead of having an arbitrary 
maximum size hardcoded. :\


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97212
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 3 lines] D2121: DesktopView: Don't call ensureWindowType on FocusIn event

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Fixes desktop window losing the keep-below flag.
  
  BUG: 365014

TEST PLAN
  The real issue is probably some race between KWindowSystem and Qt xcb,
  but this fixes the issue and it really seems unnecessary to refresh the 
window flags
  on each focus in event.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2121

AFFECTED FILES
  shell/desktopview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 242 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/242/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 08 Jul 2016 12:20:47 +
Build duration: 28 min

CHANGE SET
Revision 6c3ca3d71e920fc797c7d70d72d5cb866d5fdaff by sitter: (add neon mapping)
  change: edit drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5299 
(37%)CONDITIONAL 1382/5446 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3024 (5%)CONDITIONAL 
88/3173 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2118: add neon mapping

[sitter (Harald Sitter)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE6c3ca3d71e92: add neon mapping (authored by 
sitter).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2118?vs=5017=5019

REVISION DETAIL
  https://phabricator.kde.org/D2118

AFFECTED FILES
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, apol
Cc: #neon, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2118: add neon mapping

[apol (Aleix Pol Gonzalez)]

apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2118

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, apol
Cc: #neon, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2 lines] D2118: add neon mapping

[sitter (Harald Sitter)]

sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  add neon mapping to bug report dialog (why is that stuff not queried from 
server? :|)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2118

AFFECTED FILES
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D2118: add neon mapping

[sitter (Harald Sitter)]

sitter added a subscriber: Neon.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2118

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter
Cc: #neon, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97212
---



Visual aspects should stay under the theme's control. Therefore, from the 
usability perspective, there should be no user option, instead the look & feel 
theme should be able to control the icon size.

- Thomas Pfeiffer


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D2117: Consider the primary screen as default screen

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added a reviewer: Plasma.
apol added a subscriber: Neon.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We used to append them, but that didn't work well and was crashing plasmashell
  on fresh start.
  A default desktop would be created alongside with the one provided by the
  layout instead of replacing it.
  If a layout wants to provide an additional screen for a desktop in the 
secondary
  screen, it should specify the screen.

TEST PLAN
  Now the plasmashell tests pass. In fact I noticed it was broken due to an 
e-mail
  Jonathan sent me that the test on neon was timing out. The test in neon will
  freeze when the test crashes. Probably something to look into.
  It can be reproduced by running:
  
xvfb-run -a --server-args="-screen 0 1024x768x24" dbus-launch 
--exit-with-session 
  
  Where `exec` is the process we need to run.
  
  Now the test passes.
  It's a crash that I had reproduced locally in the past. I can't now.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2117

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: plasma-devel, #neon, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Gregor Mi]

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
> well, depending from the monitor means it should depend from the monitor 
> dpi, rather than the user (and yes, medium size was definitely too big, but i 
> don't think it grants an option to explicitly control this)
> 
> Kai Uwe Broulik wrote:
> iconSizes are scaled with DPI, no?
> 
> Marco Martin wrote:
> yes they are
> 
> John Salatas wrote:
> My "problem" that medium size seems to be too large for me and according 
> to the bug #364431 this doesn't seem to be the case for all users. So I 
> though that it would be better if the size was controled by the user :\
> 
> FYI: I have two monitors: one 15 inch and one 24 Inch both with 1920x1080 
> resolution and the medium size icons seems too large in both of them :\
> 
> Kai Uwe Broulik wrote:
> It can be controlled, by changing the panel size. If the size changed 
> between Plasma 5.6 and 5.7 that's a bug. If it was large before already then 
> this is expected and as it should be.
> 
> John Salatas wrote:
> Indeed, there was a change from 5.6 to 5.7 (it was large before). 
> 
> In any case, can't we just consider what I'm proposing here (the ability 
> to change the icon size in the systray) as a new feature? :)

On my system (openSUSE 42.1 laptop with external monitor), I also noticed the 
change from 5.6 to 5.7. The tray icons are now smaller. I found the larger ones 
more comfortable to deal with.


- Gregor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

[Kai Uwe Broulik]

> On Juli 8, 2016, 9:35 vorm., Kai Uwe Broulik wrote:
> > -1
> > 
> > What I would instead like is the ability to re-arrange and hide individual 
> > tabs, see Bug 361210, but not a corner-case solution for just the favorites.
> 
> John Salatas wrote:
> Yes! That would be great! Not sure if I can implement it through drag and 
> drop, but I could give it a try :\
> 
> Kai Uwe Broulik wrote:
> As a first step already having the infrastructure in the applet, ie. a 
> stringlist setting favorites,applications,history,... and 
> the applet placing the tabs as configured would be nice.
> 
> A fancy settings UI with drag and drop could be added at a later stage.
> 
> David Edmundson wrote:
> Or should we just hide if a model is empty?
> 
> We have an existing bug on the leave tab existing even if all the entries 
> are disabled with kiosk.

I made a patch for that a while ago (eg. hide History tab when empty) but it 
was rejected for... "performance" reasons.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
---


On Juli 8, 2016, 6:35 vorm., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated Juli 8, 2016, 6:35 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide Favorites from the kickoff
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

[David Edmundson]

> On July 8, 2016, 9:35 a.m., Kai Uwe Broulik wrote:
> > -1
> > 
> > What I would instead like is the ability to re-arrange and hide individual 
> > tabs, see Bug 361210, but not a corner-case solution for just the favorites.
> 
> John Salatas wrote:
> Yes! That would be great! Not sure if I can implement it through drag and 
> drop, but I could give it a try :\
> 
> Kai Uwe Broulik wrote:
> As a first step already having the infrastructure in the applet, ie. a 
> stringlist setting favorites,applications,history,... and 
> the applet placing the tabs as configured would be nice.
> 
> A fancy settings UI with drag and drop could be added at a later stage.

Or should we just hide if a model is empty?

We have an existing bug on the leave tab existing even if all the entries are 
disabled with kiosk.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
---


On July 8, 2016, 6:35 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated July 8, 2016, 6:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide Favorites from the kickoff
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

[Kai Uwe Broulik]

> On Juli 8, 2016, 9:35 vorm., Kai Uwe Broulik wrote:
> > -1
> > 
> > What I would instead like is the ability to re-arrange and hide individual 
> > tabs, see Bug 361210, but not a corner-case solution for just the favorites.
> 
> John Salatas wrote:
> Yes! That would be great! Not sure if I can implement it through drag and 
> drop, but I could give it a try :\

As a first step already having the infrastructure in the applet, ie. a 
stringlist setting favorites,applications,history,... and 
the applet placing the tabs as configured would be nice.

A fancy settings UI with drag and drop could be added at a later stage.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
---


On Juli 8, 2016, 6:35 vorm., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated Juli 8, 2016, 6:35 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide Favorites from the kickoff
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

> On July 8, 2016, 9:45 a.m., Heiko Tietze wrote:
> > Please add a screenshot. But actually I wonder why size matters. Aren't 
> > icons adjusted according the panel height anymore? That would by a minus 
> > one.
> 
> Kai Uwe Broulik wrote:
> They are. For system tray only up to a certain point, though, at which it 
> will become two or more rows, like with task manager, so the tray doesn't 
> fill half the panel width. This patch adds a setting to define the maximum 
> size for the icons.

https://bugsfiles.kde.org/attachment.cgi?id=99911

The upper one is with medium size which I find it too big.

I would preffer the smallMedium size (lower one).


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97202
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Kai Uwe Broulik]

> On Juli 8, 2016, 9:45 vorm., Heiko Tietze wrote:
> > Please add a screenshot. But actually I wonder why size matters. Aren't 
> > icons adjusted according the panel height anymore? That would by a minus 
> > one.

They are. For system tray only up to a certain point, though, at which it will 
become two or more rows, like with task manager, so the tray doesn't fill half 
the panel width. This patch adds a setting to define the maximum size for the 
icons.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97202
---


On Juli 8, 2016, 8:56 vorm., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated Juli 8, 2016, 8:56 vorm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

[John Salatas]

> On July 8, 2016, 9:35 a.m., Kai Uwe Broulik wrote:
> > -1
> > 
> > What I would instead like is the ability to re-arrange and hide individual 
> > tabs, see Bug 361210, but not a corner-case solution for just the favorites.

Yes! That would be great! Not sure if I can implement it through drag and drop, 
but I could give it a try :\


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
---


On July 8, 2016, 6:35 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated July 8, 2016, 6:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide Favorites from the kickoff
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Heiko Tietze]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97202
---



Please add a screenshot. But actually I wonder why size matters. Aren't icons 
adjusted according the panel height anymore? That would by a minus one.

- Heiko Tietze


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
> well, depending from the monitor means it should depend from the monitor 
> dpi, rather than the user (and yes, medium size was definitely too big, but i 
> don't think it grants an option to explicitly control this)
> 
> Kai Uwe Broulik wrote:
> iconSizes are scaled with DPI, no?
> 
> Marco Martin wrote:
> yes they are
> 
> John Salatas wrote:
> My "problem" that medium size seems to be too large for me and according 
> to the bug #364431 this doesn't seem to be the case for all users. So I 
> though that it would be better if the size was controled by the user :\
> 
> FYI: I have two monitors: one 15 inch and one 24 Inch both with 1920x1080 
> resolution and the medium size icons seems too large in both of them :\
> 
> Kai Uwe Broulik wrote:
> It can be controlled, by changing the panel size. If the size changed 
> between Plasma 5.6 and 5.7 that's a bug. If it was large before already then 
> this is expected and as it should be.

Indeed, there was a change from 5.6 to 5.7 (it was large before). 

In any case, can't we just consider what I'm proposing here (the ability to 
change the icon size in the systray) as a new feature? :)


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
---



-1

What I would instead like is the ability to re-arrange and hide individual 
tabs, see Bug 361210, but not a corner-case solution for just the favorites.

- Kai Uwe Broulik


On Juli 8, 2016, 6:35 vorm., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated Juli 8, 2016, 6:35 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide Favorites from the kickoff
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Kai Uwe Broulik]

> On Juli 8, 2016, 7:21 vorm., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
> well, depending from the monitor means it should depend from the monitor 
> dpi, rather than the user (and yes, medium size was definitely too big, but i 
> don't think it grants an option to explicitly control this)
> 
> Kai Uwe Broulik wrote:
> iconSizes are scaled with DPI, no?
> 
> Marco Martin wrote:
> yes they are
> 
> John Salatas wrote:
> My "problem" that medium size seems to be too large for me and according 
> to the bug #364431 this doesn't seem to be the case for all users. So I 
> though that it would be better if the size was controled by the user :\
> 
> FYI: I have two monitors: one 15 inch and one 24 Inch both with 1920x1080 
> resolution and the medium size icons seems too large in both of them :\

It can be controlled, by changing the panel size. If the size changed between 
Plasma 5.6 and 5.7 that's a bug. If it was large before already then this is 
expected and as it should be.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On Juli 8, 2016, 8:56 vorm., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated Juli 8, 2016, 8:56 vorm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
> well, depending from the monitor means it should depend from the monitor 
> dpi, rather than the user (and yes, medium size was definitely too big, but i 
> don't think it grants an option to explicitly control this)
> 
> Kai Uwe Broulik wrote:
> iconSizes are scaled with DPI, no?
> 
> Marco Martin wrote:
> yes they are

My "problem" that medium size seems to be too large for me and according to the 
bug #364431 this doesn't seem to be the case for all users. So I though that it 
would be better if the size was controled by the user :\

FYI: I have two monitors: one 15 inch and one 24 Inch both with 1920x1080 
resolution and the medium size icons seems too large in both of them :\


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Which applications does the Plasma team recommend to use with Plasma?

[Luca Beltrame]

In data venerdì 8 luglio 2016 10:34:52 CEST, Marco Martin ha scritto:

> I was referring to cantata as having under the hood problems (using mpd)
> does clementine use gstreamer? (that would be the most distro-blessed
> option)

IIRC, Clementine has no Qt5 port officially released.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Marco Martin]

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
> well, depending from the monitor means it should depend from the monitor 
> dpi, rather than the user (and yes, medium size was definitely too big, but i 
> don't think it grants an option to explicitly control this)
> 
> Kai Uwe Broulik wrote:
> iconSizes are scaled with DPI, no?

yes they are


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Kai Uwe Broulik]

> On Juli 8, 2016, 7:21 vorm., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
> well, depending from the monitor means it should depend from the monitor 
> dpi, rather than the user (and yes, medium size was definitely too big, but i 
> don't think it grants an option to explicitly control this)

iconSizes are scaled with DPI, no?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On Juli 8, 2016, 8:56 vorm., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated Juli 8, 2016, 8:56 vorm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Marco Martin]

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\

well, depending from the monitor means it should depend from the monitor dpi, 
rather than the user (and yes, medium size was definitely too big, but i don't 
think it grants an option to explicitly control this)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/
---

(Updated July 8, 2016, 8:41 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

I didn't like the recent changes in systray icon size related to bug #364431, 
so I created this patch in order to make the systray's icon size user 
configurable


Diffs (updated)
-

  applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
  applets/systemtray/package/contents/config/main.xml 65a7029 
  applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
  applets/systemtray/package/contents/ui/main.qml a66ea69 

Diff: https://git.reviewboard.kde.org/r/128400/diff/


Testing
---

Tested in KDE Neon Developer Stable (as of July 7, 2016)


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97191
---



I really don't want an option for this :(

- Marco Martin


On July 8, 2016, 4:29 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 4:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigIcons.qml PRE-CREATION 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Which applications does the Plasma team recommend to use with Plasma?

[Marco Martin]

On Friday 08 July 2016 09:47:15 Gregor Mi wrote:
> On 07.07.2016 22:42, Marco Martin wrote:
> > On Thursday 07 July 2016 11:29:15 Ivan Čukić wrote:
> >> I also find Cantata a strange choice (even though I do use it :) ).
> >> Was Clementine-qt5 considered?
> > 
> > i liked the proposal as i consider it as the only qt based music player
> > that has a kida good UI, but yeah, it does have problems underneath
> 
> Hi,
> 
> I am currently using clementine and thought about to propose it here. I did
> not look under the hood... What kind of problems does it have?

I was referring to cantata as having under the hood problems (using mpd) does 
clementine use gstreamer? (that would be the most distro-blessed option)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Anthony Fieroni]

> On Юли 8, 2016, 9:57 преди обяд, Anthony Fieroni wrote:
> > About me, size of systray icons must depend on panel size. Same for space 
> > between items.
> 
> John Salatas wrote:
> Well... I guess it's just a matter of personal taste. I'm using a rather 
> high panel and the default icon size (units.iconSizes.medium) seems rather 
> big. I would prefer units.iconSizes.smallMedium instead. 
> 
> You can compare the two choices in the screenshot I uploaded in bug 
> #364431 (https://bugsfiles.kde.org/attachment.cgi?id=99911): the upper is the 
> default size (units.iconSizes.medium) and the lower which I prefer is 
> units.iconSizes.smallMedium

Yeah, i saw the comparison. I don't see any reason icons in systray to be 
treated different from any other. They must be scaled to systray size.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97184
---


On Юли 8, 2016, 7:29 преди обяд, John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated Юли 8, 2016, 7:29 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigIcons.qml PRE-CREATION 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Which applications does the Plasma team recommend to use with Plasma?

[Gregor Mi]

On 07.07.2016 22:42, Marco Martin wrote:
> On Thursday 07 July 2016 11:29:15 Ivan Čukić wrote:
>> I also find Cantata a strange choice (even though I do use it :) ).
>> Was Clementine-qt5 considered?
> 
> i liked the proposal as i consider it as the only qt based music player that 
> has a kida good UI, but yeah, it does have problems underneath
> 

Hi,

I am currently using clementine and thought about to propose it here. I did not 
look under
the hood... What kind of problems does it have?

Gregor
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve added a comment.


  In https://phabricator.kde.org/D1989#38844, @graesslin wrote:
  
  > Looks good now and I think we can look into the next steps: rendering the 
KWin instance you launch. The launched KWin instance connects to your Wayland 
server, binds to the Shell and will create a ShellSurface. That you will get 
through a signal on m_shell - compare wayland_server.cpp:148. I would as a next 
step try to hook into this and see whether the surface gets created. Once you 
have that you can look into rendering it.
  >
  > For that the ShellSurfaceInterface is connected to a SurfaceInterface. The 
rendering happens on the SurfaceInterface. There's a damaged signal which you 
should use to trigger a repaint of your QQuickItem. When rendering you can 
access the buffer on the SurfaceInterface. If KWin uses KWIN_COMPOSE=Q you can 
access the buffer as a QImage and just render it. Pretty straight forward - 
hopefully. But first try to see whether you get the ShellSurface created. If 
not we need to look into what goes wrong.
  
  
  I've added the slot for checking if surface gets created but signal doesn't 
get emitted. Would you please show me the way to proceed further now.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, #plasma_on_wayland, graesslin
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---



Thanks for your patch!

However, I don't think there should be such an option. There's no other applet 
which has this and applets in the panel usually follow the panel size 
indefinitely. Perhaps add the "usability" group to have them decide.

Also, I don't think this single option deserves a separage page, it would fit 
just fine at the top of the "General" page imho.


applets/systemtray/package/contents/ui/ConfigIcons.qml (lines 2 - 3)


This is not you



applets/systemtray/package/contents/ui/ConfigIcons.qml (line 31)


Whitespace.

You have lots of whitespace errors all over the place.



applets/systemtray/package/contents/ui/ConfigIcons.qml (line 38)


Isn't a Slider a better control for this? See FolderView icon size setting.



applets/systemtray/package/contents/ui/ConfigIcons.qml (line 67)


Use onActivated instead which is only emitted when the user himself 
explicitly changes the index, ie.
onActivated: cfg_iconSize = model[index].name

("index" is the parameter of the signal, currentIndex isn't updated at the 
time this signal is fired unfortunately)



applets/systemtray/package/contents/ui/main.qml (line 44)


You could just do units.iconSizes[plasmoid.configuration.iconSize]



applets/systemtray/package/contents/ui/main.qml 


Unrelated change


- Kai Uwe Broulik


On Juli 8, 2016, 4:29 vorm., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated Juli 8, 2016, 4:29 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigIcons.qml PRE-CREATION 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 253 lines] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve updated this revision to Diff 5014.
bdhruve added a comment.


  Fixed issues mentioned by @graesslin and connect to surfaceCreated.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1989?vs=4972=5014

BRANCH
  kwinqml

REVISION DETAIL
  https://phabricator.kde.org/D1989

AFFECTED FILES
  config-kwin.h.cmake
  plugins/CMakeLists.txt
  plugins/qml/CMakeLists.txt
  plugins/qml/kwinqml/CMakeLists.txt
  plugins/qml/kwinqml/kwinplugin.cpp
  plugins/qml/kwinqml/kwinplugin.h
  plugins/qml/kwinqml/kwinqml.cpp
  plugins/qml/kwinqml/kwinqml.h
  plugins/qml/kwinqml/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, #plasma_on_wayland, graesslin
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

> On July 8, 2016, 6:57 a.m., Anthony Fieroni wrote:
> > About me, size of systray icons must depend on panel size. Same for space 
> > between items.

Well... I guess it's just a matter of personal taste. I'm using a rather high 
panel and the default icon size (units.iconSizes.medium) seems rather big. I 
would prefer units.iconSizes.smallMedium instead. 

You can compare the two choices in the screenshot I uploaded in bug #364431 
(https://bugsfiles.kde.org/attachment.cgi?id=99911): the upper is the default 
size (units.iconSizes.medium) and the lower which I prefer is 
units.iconSizes.smallMedium


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97184
---


On July 8, 2016, 4:29 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 4:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigIcons.qml PRE-CREATION 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97184
---



About me, size of systray icons must depend on panel size. Same for space 
between items.

- Anthony Fieroni


On Юли 8, 2016, 7:29 преди обяд, John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated Юли 8, 2016, 7:29 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigIcons.qml PRE-CREATION 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128402: Kickoff: Add option to hide Favorites tab

[John Salatas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab 
in kickoff is somewhat redundant, as I have added launchers for all of my 
favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide Favorites from the kickoff


Diffs
-

  applets/kickoff/package/contents/config/main.xml 2de73ba 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 

Diff: https://git.reviewboard.kde.org/r/128402/diff/


Testing
---

Tested in KDE Neon Developer Stable (as of July 7, 2016)


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel