[Differential] [Closed] D2170: Port ActivityPager applet away from LibLegacyTaskManager API.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKDEPLASMAADDONS650b4352c202: Port ActivityPager applet away 
from LibLegacyTaskManager API. (authored by hein).

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2170?vs=5165=5198

REVISION DETAIL
  https://phabricator.kde.org/D2170

AFFECTED FILES
  CMakeLists.txt
  applets/activitypager/CMakeLists.txt
  applets/activitypager/plugin/activitypager.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2169: Port Pager applet away from LibLegacyTaskManager API.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP461b9a1c7c4c: Port Pager applet away from 
LibLegacyTaskManager API. (authored by hein).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2169?vs=5164=5197

REVISION DETAIL
  https://phabricator.kde.org/D2169

AFFECTED FILES
  CMakeLists.txt
  applets/pager/CMakeLists.txt
  applets/pager/plugin/pager.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
hein marked an inline comment as done.
Closed by commit rPLASMAWORKSPACE15af96200fac: Move code to extract legacy 
window ids from (drop) MIME data into libtm-ng. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2168?vs=5163=5195

REVISION DETAIL
  https://phabricator.kde.org/D2168

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2171: Drop liblegacytaskmanager and the tasks data engine.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE49213f778186: Drop liblegacytaskmanager and 
the tasks data engine. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2171?vs=5166=5196

REVISION DETAIL
  https://phabricator.kde.org/D2171

AFFECTED FILES
  CMakeLists.txt
  dataengines/CMakeLists.txt
  dataengines/tasks/CMakeLists.txt
  dataengines/tasks/plasma-dataengine-tasks.desktop
  dataengines/tasks/taskjob.cpp
  dataengines/tasks/taskjob.h
  dataengines/tasks/tasks.operations
  dataengines/tasks/tasksengine.cpp
  dataengines/tasks/tasksengine.h
  dataengines/tasks/taskservice.cpp
  dataengines/tasks/taskservice.h
  dataengines/tasks/taskwindowjob.cpp
  dataengines/tasks/taskwindowjob.h
  dataengines/tasks/taskwindowservice.cpp
  dataengines/tasks/taskwindowservice.h
  dataengines/tasks/virtualdesktopssource.cpp
  dataengines/tasks/virtualdesktopssource.h
  dataengines/tasks/windowtasks.operations
  liblegacytaskmanager/CMakeLists.txt
  liblegacytaskmanager/LibLegacyTaskManagerConfig.cmake.in
  liblegacytaskmanager/Mainpage.dox
  liblegacytaskmanager/Messages.sh
  liblegacytaskmanager/abstractgroupableitem.cpp
  liblegacytaskmanager/abstractgroupableitem.h
  liblegacytaskmanager/abstractgroupingstrategy.cpp
  liblegacytaskmanager/abstractgroupingstrategy.h
  liblegacytaskmanager/abstractsortingstrategy.cpp
  liblegacytaskmanager/abstractsortingstrategy.h
  liblegacytaskmanager/groupmanager.cpp
  liblegacytaskmanager/groupmanager.h
  liblegacytaskmanager/launcherconfig.cpp
  liblegacytaskmanager/launcherconfig.h
  liblegacytaskmanager/launcherconfig.ui
  liblegacytaskmanager/launcheritem.cpp
  liblegacytaskmanager/launcheritem.h
  liblegacytaskmanager/launcherproperties.cpp
  liblegacytaskmanager/launcherproperties.h
  liblegacytaskmanager/launcherproperties.ui
  liblegacytaskmanager/legacytaskmanager.cpp
  liblegacytaskmanager/legacytaskmanager.h
  liblegacytaskmanager/legacytaskmanagerrulesrc
  liblegacytaskmanager/startup.cpp
  liblegacytaskmanager/startup.h
  liblegacytaskmanager/strategies/activitysortingstrategy.cpp
  liblegacytaskmanager/strategies/activitysortingstrategy.h
  liblegacytaskmanager/strategies/alphasortingstrategy.cpp
  liblegacytaskmanager/strategies/alphasortingstrategy.h
  liblegacytaskmanager/strategies/desktopsortingstrategy.cpp
  liblegacytaskmanager/strategies/desktopsortingstrategy.h
  liblegacytaskmanager/strategies/manualgroupingstrategy.cpp
  liblegacytaskmanager/strategies/manualgroupingstrategy.h
  liblegacytaskmanager/strategies/manualsortingstrategy.cpp
  liblegacytaskmanager/strategies/manualsortingstrategy.h
  liblegacytaskmanager/strategies/programgroupingstrategy.cpp
  liblegacytaskmanager/strategies/programgroupingstrategy.h
  liblegacytaskmanager/task.cpp
  liblegacytaskmanager/task.h
  liblegacytaskmanager/task_p.h
  liblegacytaskmanager/task_win.cpp
  liblegacytaskmanager/task_x11.cpp
  liblegacytaskmanager/taskactions.cpp
  liblegacytaskmanager/taskactions.h
  liblegacytaskmanager/taskactions_p.h
  liblegacytaskmanager/taskgroup.cpp
  liblegacytaskmanager/taskgroup.h
  liblegacytaskmanager/taskitem.cpp
  liblegacytaskmanager/taskitem.h
  liblegacytaskmanager/tasksmodel.cpp
  liblegacytaskmanager/tasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[Martin Gräßlin]

graesslin added a comment.


  Looks good to me

INLINE COMMENTS

> outputgrid_2x3.json:129
> +]
> \ No newline at end of file


nitpick

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  For now I didnt notice any problems (with version 1 of the patch), at least 
no regressions (notice that I wasn't able to reproduce the issue described in 
the bug since a long time).
  
  Is there any difference worth testing in the new revision?

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[Sebastian Kügler]

sebas added a comment.


  @lbeltrame Does it work for you?
  
  If you can try this patch, that'd be awesome (also if it already works for 
you, to check if the patch breaks anything).

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[Sebastian Kügler]

sebas added a comment.


  @davidedmundson Sure.
  
  With this patch
  
  - we detect the case when multiple identical outputs are connected (same hash)
  - each of the duplicate outputs also gets matched against the output name
  
  The problem I'm fixing is that currently (without my patch) the ordering of 
outputs matters, so if an output appears later on, it ends up in a different 
place in the list. This may confuse the current algorithm which relies on the 
ordering of config->connectedOutputs() since it'll match the first and remove 
that -- there's no guarantee that the first match is the right one, however. It 
works in the most likely case, when all outputs are added the same order as in 
the config file, but breaks once I mix up this ordering.
  
  The config file also holds the output's name, and since that's usually the 
connector's name and likely to be unique, it's a good indicator for identifying 
an output.
  
  If you look at the config file in https://bugs.kde.org/show_bug.cgi?id=325277 
(grep for e7d18f), this becomes perhaps a bit clearer.
  
  In the second iteration of this patch, I've tightened up the continue 
condition a bit (and fixed it, I used the wrong json object), so it's less 
likely to skip outputs when the name is empty.
  
  I've added an autotest which sets up a 3x2 video wall and loads the config 
from the bugreport. This test fails without the change in findOutputs() and 
passes with it. I've played a bit around with it, and if I add the output 
programmatically in the same order as the config file has them (alphanumeric) 
it works without my patch, changing the ordering makes the tests fail without, 
and pass with my patch.
  
  tl,dr; I think your patch makes it work in the most likely cases, but may not 
be enough when displays are being added in a different order.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 269 lines] D2156: improve output identification

[Sebastian Kügler]

sebas updated this revision to Diff 5194.
sebas added a comment.


  fix checks and add autotests
  
  - autotest for videowall bug
  - improve and fix checks
  - randomize order in autotest

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2156?vs=5140=5194

BRANCH
  identicalmonitors

REVISION DETAIL
  https://phabricator.kde.org/D2156

AFFECTED FILES
  kded/serializer.cpp
  tests/kded/serializerdata/outputgrid_2x3.json
  tests/kded/serializertest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128431: Fix race condition when new applications open

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128431/#review97412
---


Ship it!




Ship It!

- David Edmundson


On July 12, 2016, 9:22 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128431/
> ---
> 
> (Updated July 12, 2016, 9:22 p.m.)
> 
> 
> Review request for Plasma and John Tapsell.
> 
> 
> Bugs: 261255
> https://bugs.kde.org/show_bug.cgi?id=261255
> 
> 
> Repository: libksysguard
> 
> 
> Description
> ---
> 
> When opening and closing an application quickly it sometimes got "stuck" in 
> ksysguard because it was added by ProcessModel while 
> Processes::processesUpdated() was running, so Processes never processed it.
> 
> 
> Diffs
> -
> 
>   processui/ProcessModel.cpp c55cea6 
> 
> Diff: https://git.reviewboard.kde.org/r/128431/diff/
> 
> 
> Testing
> ---
> 
> It doesn't happen anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

[mart (Marco Martin)]

mart added a comment.


  code seems ok, seems some pixel measures here and there, that i guess are ok.
  can you add a screenshot as well?

INLINE COMMENTS

> CategorizedView.cpp:30
>  setWordWrap( true );
> +setViewportMargins(20,0,20,0);
> +QPalette pal(palette());

does this give problemswith different dpis? (i guess with the scaling of the 
painter approach that qwidget does should be fine?)

REPOSITORY
  rSYSTEMSETTINGS System Settings

REVISION DETAIL
  https://phabricator.kde.org/D2173

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> hein wrote in xwindowtasksmodel.h:211
> No, because this is X11-specific code that is never run on Wayland and not 
> built if X11 is not available at build time.
> 
> Now, we don't have a solution yet for dragging Wayland windows by reference. 
> Whether we can find a solution that works on both or need different 
> codepaths: Time will tell. For now this is just something we can do on X11 
> but not on Wayland, like many others - and it's not a new thing, this is old 
> code just moved here.
> 
> Note that once the Pager is ported to libtaskmanager both sides will go 
> through libtaskmanager and the TM appley already uses a generic data role 
> (AbstractTasksModel::MimeData) when starting a drag, so we'll have some 
> freedom to design a solution.
> 
> For now it's just keeping something already working working while allowing us 
> to drop liblegacytaskmanager and make forward progress :)

ok, thx

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2171: Drop liblegacytaskmanager and the tasks data engine.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  finally \o/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2171

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2177: Actually connect the filter bar in holidays plugin

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2177

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2176: Removing the Activity wrapper class from the Shell

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2176

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, mart, bshah, davidedmundson, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2176: Removing the Activity wrapper class from the Shell

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2176

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, mart, bshah, davidedmundson, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 10 lines] D2177: Actually connect the filter bar in holidays plugin

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 365621

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2177

AFFECTED FILES
  plasmacalendarintegration/HolidaysConfig.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 380 lines] D2176: Removing the Activity wrapper class from the Shell

[Ivan Čukić]

ivan created this revision.
ivan added reviewers: Plasma, mart, davidedmundson, bshah.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  After the previous patch which removed the unused
  Activity class related events, it started becoming clear that
  said class is only really used to store the name of the
  containment plugin that should be loaded for an activity.
  
  Instead of keeping a map of these objects (QObjects) with
  all their baggage, the shells now only keep the map of
  activity IDs and corresponding plugin names.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2176

AFFECTED FILES
  shell/CMakeLists.txt
  shell/activity.cpp
  shell/activity.h
  shell/scripting/scriptengine.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/standaloneappcorona.cpp
  shell/standaloneappcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, davidedmundson, bshah
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 365690] New: kaccessibleapp icon

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365690

Bug ID: 365690
   Summary: kaccessibleapp icon
   Product: Breeze
   Version: 5.6.5
  Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: john.k...@vfemail.net

Dear Developer,

The kaccessibleapp icon on a default panel (36 size) is bigger than blue
underlining of a status & notifications menu.

There is also i think probably  a bug with the panel size. When installed on a
new system it is smaller than a new default panel which size is 36.

Also when changing fonts DPI to a higher value (HiDPI)  the panel size doesn't
change.
The QT_AUTO_SCREEN_SCALE_FACTOR environment variable is set to 1.

Best wishes,
John 

Reproducible: Always

Steps to Reproduce:
I think it is clear from "Details". 

Actual Results:  
Written in "Details" 

Expected Results:  
The icon is smaller. 
The panel size is the same. The panel changes with DPI. 

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 260 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/260/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 17:31:35 +
Build duration: 15 min

CHANGE SET
Revision ada43d447ccf51844bf6c2a99023d69d264a3c16 by ivan.cukic: (Removing dead 
code - activity-event-handling private slots)
  change: edit shell/shellcorona.h
  change: edit shell/shellcorona.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5305 
(37%)CONDITIONAL 1382/5456 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3030 (5%)CONDITIONAL 
88/3183 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2174: Removing dead code - activity-event-handling private slots

[Ivan Čukić]

This revision was automatically updated to reflect the committed changes.
ivan marked an inline comment as done.
Closed by commit rPLASMAWORKSPACEada43d447ccf: Removing dead code - 
activity-event-handling private slots (authored by ivan).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2174?vs=5172=5173

REVISION DETAIL
  https://phabricator.kde.org/D2174

AFFECTED FILES
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, sebas, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 364849] Tooltip Text in several qt apps such as Amarok and Krusader is unreadable (white on white) with the Breeze/Breeze Dark color schemes

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364849

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 CC||hugo.pereira.da.costa@gmail
   ||.com

--- Comment #2 from Hugo Pereira Da Costa  ---
Can you post a screenshot ? 
Here it looks just fine: 
http://wstaw.org/m/2016/07/14/plasma-desktopmp8175.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365318

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 CC||hugo.pereira.da.costa@gmail
   ||.com

--- Comment #13 from Hugo Pereira Da Costa  ---
Hi, Chiming in.
From the screenshots of k3b, ktorrent and okular, it does seem that Qt is set
to use the QT-Gtk theme (which converts a gtk theme into a Qt theme), and then
gtk set to use breeze (breeze-dark ?).
This configuration is not supported. 

I would recommand try to set the Qt theme to use breeze directly (and
breeze-dark as a color theme). this should make (e.g.) okular, look like this: 

http://wstaw.org/m/2016/07/14/plasma-desktopDS8175.png

Which is fine

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-community] Usage of QNetworkAccessManager

[Thiago Macieira]

On quinta-feira, 14 de julho de 2016 18:33:37 PDT Ben Cooksley wrote:
> Hi all,
> 
> Just my regular reminder regarding usage of QNetworkAccessManager in
> your applications and libraries, especially when it comes to
> interacting with kde.org infrastructure.
> 
> Unfortunately, from it's first iteration in Qt 4 QNetworkAccessManager
> was shipped with a severe and fundamental defect in that it does not
> follow HTTP redirects by default. Due to Qt behavioural and other
> compatibility promises they can never change this behaviour, not even
> in Qt 6.
> 
> Please therefore ensure your application handles redirects
> appropriately (the form of the code will depend on the version of Qt
> in use) if you decide to use QNAM.

You do that by setting the attribute FollowRedirectsAttribute in your 
QNetworkRequests.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

[Thomas Lübking]

luebking added a comment.


  In https://phabricator.kde.org/D2164#40170, @graesslin wrote:
  
  > - fixed logic error with platform check
  
  
  See? ;-)
  
  Looks good otherwise.

INLINE COMMENTS

> panelview.cpp:926
>  
> -//Extended struts against a screen edge near to another screen are 
> really harmful, so windows maximized under the panel is a lesser pain
> -//TODO: force "windows can cover" in those cases?
> -const int numScreens = corona()->numScreens();
> -for (int i = 0; i < numScreens; ++i) {
> -if (i == containment()->screen()) {
> -continue;
> -}
> -
> -const QRect otherScreen = corona()->screenGeometry(i);
> -if (!otherScreen.isValid()) {
> -continue;
> -}
> -
> -switch (location())
> -{
> -case Plasma::Types::TopEdge:
> -if (otherScreen.bottom() <= thisScreen.top()) {
> -KWindowSystem::setExtendedStrut(winId(), 0, 0, 0, 0, 0, 
> 0, 0, 0, 0, 0, 0, 0);
> -return;
> -}
> -break;
> -case Plasma::Types::BottomEdge:
> -if (otherScreen.top() >= thisScreen.bottom()) {
> -KWindowSystem::setExtendedStrut(winId(), 0, 0, 0, 0, 0, 
> 0, 0, 0, 0, 0, 0, 0);
> -return;
> -}
> -break;
> -case Plasma::Types::RightEdge:
> -if (otherScreen.left() >= thisScreen.right()) {
> -KWindowSystem::setExtendedStrut(winId(), 0, 0, 0, 0, 0, 
> 0, 0, 0, 0, 0, 0, 0);
> -return;
> -}
> -break;
> -case Plasma::Types::LeftEdge:
> -if (otherScreen.right() <= thisScreen.left()) {
> -KWindowSystem::setExtendedStrut(winId(), 0, 0, 0, 0, 0, 
> 0, 0, 0, 0, 0, 0, 0);
> -return;
> -}
> -break;
> -default:
> -return;
> -}
> +if (!canSetStrut()) {
> +KWindowSystem::setExtendedStrut(winId(), 0, 0, 0, 0, 0, 0, 0, 0, 
> 0, 0, 0, 0);

this could go up (spare crashy virtualSize() calls ;-)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2164

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: mart, luebking, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2174: Removing dead code - activity-event-handling private slots

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2174

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, sebas, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

[Ivan Čukić]

ivan marked an inline comment as done.
ivan added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shellcorona.cpp:1588
> we use this one
> 
> you've even updated the line that's using it in this very patch.

It is using activityRemoved(QString), not activityRemoved(), It would not 
compile otherwise after the change to Qt5 connect syntax :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2174

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, sebas, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2174: Removing dead code - activity-event-handling private slots

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> shellcorona.cpp:1588
> -
> -void ShellCorona::activityRemoved()
> -{

we use this one

you've even updated the line that's using it in this very patch.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2174

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, sebas, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

[Ivan Čukić]

ivan updated the summary for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2174

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, sebas, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 37 lines] D2174: Removing dead code - activity-event-handling private slots

[Ivan Čukić]

ivan created this revision.
ivan added reviewers: Plasma, mart, sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A few private slots handling the events of Activity objects
  
have been lingering in ShellCorona never to be called.
I've grepped both plasma-desktop and plasma-workspace for these
(even though they are private slots) and they seem not to be
used anywhere.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2174

AFFECTED FILES
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, sebas, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2156: improve output identification

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  I have identical screens so can test when I'm back (Tuesday) if you give me 
some specific thing to test.
  
  Mine's mostly been working since I did 
https://phabricator.kde.org/rKSCREENb8b2126dbfb1d0cf5c771baf23a29e1130a70fba in 
kscreen which also makes sure we don't match the same output twice.
  
  Can you talk through what your patch is doing.
  I think I'm missing something as - if the names are also identical you'll 
surely skip both screens when trying to match an output - and if they're not 
the same, you'll not acheive anything?

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 259 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/259/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 15:02:48 +
Build duration: 12 min

CHANGE SET
Revision 95e3c59606b3b6b9b0ac458a5c372cc24e180ab0 by ivan.cukic: (The 
connection to a lambda should get disconnected when the shell is)
  change: edit shell/shellcorona.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5305 
(37%)CONDITIONAL 1382/5456 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3030 (5%)CONDITIONAL 
88/3183 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

[hein (Eike Hein)]

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> mart wrote in xwindowtasksmodel.h:211
> would this cause problems in wayland?

No, because this is X11-specific code that is never run on Wayland and not 
built if X11 is not available at build time.

Now, we don't have a solution yet for dragging Wayland windows by reference. 
Whether we can find a solution that works on both or need different codepaths: 
Time will tell. For now this is just something we can do on X11 but not on 
Wayland, like many others - and it's not a new thing, this is old code just 
moved here.

Note that once the Pager is ported to libtaskmanager both sides will go through 
libtaskmanager and the TM appley already uses a generic data role 
(AbstractTasksModel::MimeData) when starting a drag, so we'll have some freedom 
to design a solution.

For now it's just keeping something already working working while allowing us 
to drop liblegacytaskmanager and make forward progress :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2169: Port Pager applet away from LibLegacyTaskManager API.

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2169

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 380 lines] D2173: WIP: New System Settings delegate design

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Based on VDG design
  
  Icon mode lists all submodules which can be accessed directly
  This removes the need for tooltips and a layer of navigation

TEST PLAN
  Ran it and clicked on things..

REPOSITORY
  rSYSTEMSETTINGS System Settings

BRANCH
  davidedmundson/newdesign

REVISION DETAIL
  https://phabricator.kde.org/D2173

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  icons/CategorizedView.cpp
  icons/CategorizedView.h
  icons/CategoryDrawer.cpp
  icons/IconMode.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Reopened] D2111: User interface for adding launchers as global shortcuts

[mart (Marco Martin)]

mart reopened this revision.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2111

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 111 lines] D2164: Allow struts on panels between screen edges if WM is KWin

[Martin Gräßlin]

graesslin updated this revision to Diff 5170.
graesslin added a comment.


  - fixed logic error with platform check
  - changed name to canSetStrut to prevent negation in method name
  - qstricmp
  - move the setExtendedStrut call with no strut into PanelView::updateStruts

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2164?vs=5152=5170

BRANCH
  struts-shared-panels

REVISION DETAIL
  https://phabricator.kde.org/D2164

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: luebking, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

[mart (Marco Martin)]

mart added a comment.


  fine with me.
  we are not "officially" supporting other window managers for libplasma anyways

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2164

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: mart, luebking, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2170: Port ActivityPager applet away from LibLegacyTaskManager API.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2170

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> xwindowtasksmodel.h:211
> + */
> +static WId winIdFromMimeData(const QMimeData *mimeData, bool *ok = 0);
> +

would this cause problems in wayland?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 332 lines] D2111: User interface for adding launchers as global shortcuts

[mart (Marco Martin)]

mart updated this revision to Diff 5167.
mart added a comment.


  - new layout, without combobox
  - categorize launchers and other shortcuts

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2111?vs=5161=5167

BRANCH
  mart/kserviceaction

REVISION DETAIL
  https://phabricator.kde.org/D2111

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/select_application.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

[Painless Roaster]

> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote:
> > It seems to work fairly well, but the editor margins are not symmetric on 
> > the left and right with respect to the item delegate frame:
> > 
> > ![Screenshot](http://i.imgur.com/2JhUtp4.png)
> 
> Painless Roaster wrote:
> It is OK. The vertical scroller is dynamically added if need. His 
> addition preserves text position and text wrapping. Therefore scroller is 
> slightly to the right.
> Try edit short text and add next characters until show scroller. You will 
> see that this is good.
> 
> Eike Hein wrote:
> It would be nicer if the overall editor would resize once the scrollbar 
> appears so the margins are still symmetric, avoiding the broken appearance in 
> the screenshot.

Thank you for your review. But horizontal center of editbox with scroller is 
not good idea. My main idea is 'the same text position and wrap in label and 
edit box'. If edit box show/hide vertical scroller, position of text must 
remain in place. Movement with editbox is disturbing for user (if user inserted 
char for show scroller or remove char for hide scroller).


- Painless


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97371
---


On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128423/
> ---
> 
> (Updated Čec. 13, 2016, 1:13 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=361097
> 
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> fix rename file (or folder) in folder plugin (and desktop in folder mode)
>  - enable multiline edit
>  - fix size and position
>  - fix escape from edit if user pressed Esc
>  - fix suppress open file (or folder) if user clicked in editbox
>  - fix size and position in popup mode
> 
> 
> Diffs
> -
> 
>   containments/desktop/package/contents/ui/FolderView.qml ced3507 
> 
> Diff: https://git.reviewboard.kde.org/r/128423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Painless Roaster
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 193 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 13:55:05 +
Build duration: 14 min

CHANGE SET
Revision 49eec39d11e7f689a763e837bc82869bb08db4df by David Faure: (Add button 
quot;Disable sounds for all of these eventsquot;.)
  change: edit kcms/knotify/knotify.h
  change: edit kcms/knotify/knotify.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2290/3367 
(68%)CONDITIONAL 1556/3768 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 252/350 (72%)CONDITIONAL 
82/189 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 193 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 13:55:05 +
Build duration: 14 min

CHANGE SET
Revision 49eec39d11e7f689a763e837bc82869bb08db4df by David Faure: (Add button 
quot;Disable sounds for all of these eventsquot;.)
  change: edit kcms/knotify/knotify.h
  change: edit kcms/knotify/knotify.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2290/3367 
(68%)CONDITIONAL 1556/3768 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 252/350 (72%)CONDITIONAL 
82/189 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 258 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/258/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 13:36:00 +
Build duration: 22 min

CHANGE SET
Revision 6f31fafd167e3b54f8bee05841205f9c15db3645 by hein: (Port Switch Window 
containment action to libtaskmanager-ng.)
  change: edit containmentactions/switchwindow/CMakeLists.txt
  change: edit containmentactions/switchwindow/switch.h
  change: edit containmentactions/switchwindow/switch.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5305 
(37%)CONDITIONAL 1382/5456 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3030 (5%)CONDITIONAL 
88/3183 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2169: Port Pager applet away from LibLegacyTaskManager API.

[hein (Eike Hein)]

hein added a dependent revision: D2171: Drop liblegacytaskmanager and the tasks 
data engine..

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2169

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 12,882 lines] D2171: Drop liblegacytaskmanager and the tasks data engine.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added dependencies: D2170: Port ActivityPager applet away from 
LibLegacyTaskManager API., D2169: Port Pager applet away from 
LibLegacyTaskManager API..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  They're deprecated and now unused.
  
  Depends on https://phabricator.kde.org/D2169, 
https://phabricator.kde.org/D2170.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2171

AFFECTED FILES
  CMakeLists.txt
  dataengines/CMakeLists.txt
  dataengines/tasks/CMakeLists.txt
  dataengines/tasks/plasma-dataengine-tasks.desktop
  dataengines/tasks/taskjob.cpp
  dataengines/tasks/taskjob.h
  dataengines/tasks/tasks.operations
  dataengines/tasks/tasksengine.cpp
  dataengines/tasks/tasksengine.h
  dataengines/tasks/taskservice.cpp
  dataengines/tasks/taskservice.h
  dataengines/tasks/taskwindowjob.cpp
  dataengines/tasks/taskwindowjob.h
  dataengines/tasks/taskwindowservice.cpp
  dataengines/tasks/taskwindowservice.h
  dataengines/tasks/virtualdesktopssource.cpp
  dataengines/tasks/virtualdesktopssource.h
  dataengines/tasks/windowtasks.operations
  liblegacytaskmanager/CMakeLists.txt
  liblegacytaskmanager/LibLegacyTaskManagerConfig.cmake.in
  liblegacytaskmanager/Mainpage.dox
  liblegacytaskmanager/Messages.sh
  liblegacytaskmanager/abstractgroupableitem.cpp
  liblegacytaskmanager/abstractgroupableitem.h
  liblegacytaskmanager/abstractgroupingstrategy.cpp
  liblegacytaskmanager/abstractgroupingstrategy.h
  liblegacytaskmanager/abstractsortingstrategy.cpp
  liblegacytaskmanager/abstractsortingstrategy.h
  liblegacytaskmanager/groupmanager.cpp
  liblegacytaskmanager/groupmanager.h
  liblegacytaskmanager/launcherconfig.cpp
  liblegacytaskmanager/launcherconfig.h
  liblegacytaskmanager/launcherconfig.ui
  liblegacytaskmanager/launcheritem.cpp
  liblegacytaskmanager/launcheritem.h
  liblegacytaskmanager/launcherproperties.cpp
  liblegacytaskmanager/launcherproperties.h
  liblegacytaskmanager/launcherproperties.ui
  liblegacytaskmanager/legacytaskmanager.cpp
  liblegacytaskmanager/legacytaskmanager.h
  liblegacytaskmanager/legacytaskmanagerrulesrc
  liblegacytaskmanager/startup.cpp
  liblegacytaskmanager/startup.h
  liblegacytaskmanager/strategies/activitysortingstrategy.cpp
  liblegacytaskmanager/strategies/activitysortingstrategy.h
  liblegacytaskmanager/strategies/alphasortingstrategy.cpp
  liblegacytaskmanager/strategies/alphasortingstrategy.h
  liblegacytaskmanager/strategies/desktopsortingstrategy.cpp
  liblegacytaskmanager/strategies/desktopsortingstrategy.h
  liblegacytaskmanager/strategies/manualgroupingstrategy.cpp
  liblegacytaskmanager/strategies/manualgroupingstrategy.h
  liblegacytaskmanager/strategies/manualsortingstrategy.cpp
  liblegacytaskmanager/strategies/manualsortingstrategy.h
  liblegacytaskmanager/strategies/programgroupingstrategy.cpp
  liblegacytaskmanager/strategies/programgroupingstrategy.h
  liblegacytaskmanager/task.cpp
  liblegacytaskmanager/task.h
  liblegacytaskmanager/task_p.h
  liblegacytaskmanager/task_win.cpp
  liblegacytaskmanager/task_x11.cpp
  liblegacytaskmanager/taskactions.cpp
  liblegacytaskmanager/taskactions.h
  liblegacytaskmanager/taskactions_p.h
  liblegacytaskmanager/taskgroup.cpp
  liblegacytaskmanager/taskgroup.h
  liblegacytaskmanager/taskitem.cpp
  liblegacytaskmanager/taskitem.h
  liblegacytaskmanager/tasksmodel.cpp
  liblegacytaskmanager/tasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2170: Port ActivityPager applet away from LibLegacyTaskManager API.

[hein (Eike Hein)]

hein added a dependent revision: D2171: Drop liblegacytaskmanager and the tasks 
data engine..

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D2170

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

[hein (Eike Hein)]

hein added a dependent revision: D2170: Port ActivityPager applet away from 
LibLegacyTaskManager API..

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 22 lines] D2170: Port ActivityPager applet away from LibLegacyTaskManager API.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added a dependency: D2168: Move code to extract legacy window ids from 
(drop) MIME data into libtm-ng..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Depends on https://phabricator.kde.org/D2168.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2170

AFFECTED FILES
  CMakeLists.txt
  applets/activitypager/CMakeLists.txt
  applets/activitypager/plugin/activitypager.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

[Thomas Lübking]

luebking added inline comments.

INLINE COMMENTS

> graesslin wrote in panelview.cpp:857
> > also, how does this react when the WM is replaced?
> 
> tricky. I think it's a corner case which could be ignored. We don't really 
> have a way to detect it. I would say only "experienced" users know how to do 
> that, they should be prepared for impact.

One would require another signal in KWindowSystem - ultimately, it's only 
monitoring _NET_SUPPORTING_WM_CHECK on the root window

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2164

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: luebking, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

[hein (Eike Hein)]

hein added a dependent revision: D2169: Port Pager applet away from 
LibLegacyTaskManager API..

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 24 lines] D2169: Port Pager applet away from LibLegacyTaskManager API.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added a dependency: D2168: Move code to extract legacy window ids from 
(drop) MIME data into libtm-ng..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Depends on https://phabricator.kde.org/D2168.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2169

AFFECTED FILES
  CMakeLists.txt
  applets/pager/CMakeLists.txt
  applets/pager/plugin/pager.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 111 lines] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This is remaining (still) useful code from liblegacytaskmanager.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2168

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2165: Port Switch Window containment action to libtaskmanager-ng.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE6f31fafd167e: Port Switch Window containment 
action to libtaskmanager-ng. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2165?vs=5155=5162

REVISION DETAIL
  https://phabricator.kde.org/D2165

AFFECTED FILES
  containmentactions/switchwindow/CMakeLists.txt
  containmentactions/switchwindow/switch.cpp
  containmentactions/switchwindow/switch.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2165: Port Switch Window containment action to libtaskmanager-ng.

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2165

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> luebking wrote in panelview.cpp:857
> qstricmp?
> also, how does this react when the WM is replaced?

> also, how does this react when the WM is replaced?

tricky. I think it's a corner case which could be ignored. We don't really have 
a way to detect it. I would say only "experienced" users know how to do that, 
they should be prepared for impact.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2164

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: luebking, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2111: User interface for adding launchers as global shortcuts

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPba021bc947d8: a dialog to add applications 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2111?vs=5005=5161#toc

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2111?vs=5005=5161

REVISION DETAIL
  https://phabricator.kde.org/D2111

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/kglobalshortcutseditor.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128445: add a subsection for removable devices

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128445/
---

(Updated July 14, 2016, 1:03 p.m.)


Review request for Plasma and Thomas Pfeiffer.


Changes
---

now with automatic mounting

the docbook I will update when everything is finished but there is some 
renaming still open.


Repository: systemsettings


Description
---

now we have some kcm modules which are not connected to an subgroup the 
following kcm modules will be added to the subgroup removable devices when the 
patch was submitted

hardware
- removable devices
  - removable devices
  - digital camera
  - device actions

how it will look like when I add the patch for the different kcm's
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png

this patch don't change anything it's only an preparation.


Diffs (updated)
-

  categories/CMakeLists.txt 9bc8307 
  categories/old/settings-removable-devices.desktop 00098ad 

Diff: https://git.reviewboard.kde.org/r/128445/diff/


Testing
---


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D2164: Allow struts on panels between screen edges if WM is KWin

[Thomas Lübking]

luebking added inline comments.

INLINE COMMENTS

> panelview.cpp:848
>  
> +bool PanelView::shouldNotSetStrut() const
> +{

API sanity:

"if (!shouldNotSetStrut())" ...

double negations make people dizzy ;-)

> panelview.cpp:857
> +NETRootInfo rootInfo(QX11Info::connection(), NET::Supported | 
> NET::SupportingWMCheck);
> +if (qstrcmp(rootInfo.wmName(), "KWin") == 0) {
> +// KWin since 5.7 can handle this fine, so only exclude for other 
> window managers

qstricmp?
also, how does this react when the WM is replaced?

> panelview.cpp:863
> +const QRect thisScreen = screen()->geometry();
> +const int numScreens = corona()->numScreens();
> +for (int i = 0; i < numScreens; ++i) {

if (numScreens < 2) return false; (ie. true for the switched API - already 
confused?)

> panelview.cpp:878
> +if (otherScreen.bottom() <= thisScreen.top()) {
> +KWindowSystem::setExtendedStrut(winId(), 0, 0, 0, 0, 0, 0, 
> 0, 0, 0, 0, 0, 0);
> +return true;

the query has a side effect - the strut update should be in the calling branch, 
yesno?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2164

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: luebking, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 192 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 12:45:51 +
Build duration: 3 min 8 sec

CHANGE SET
Revision d444c0dc8347f89259cafce5fccbf467252f5f47 by kainz.a: (rename some kcm 
desktop files REVIEW: 128434)
  change: edit kcms/translations/translations.desktop
  change: edit kcms/standard_actions/standard_actions.desktop
  change: edit kcms/ksmserver/kcmsmserver.desktop
  change: edit doc/kcontrol/translations/index.docbook
  change: edit doc/kcontrol/keys/index.docbook
  change: edit kcms/keys/keys.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/
---

(Updated July 14, 2016, 12:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit d444c0dc8347f89259cafce5fccbf467252f5f47 by andreas kainz 
to branch master.


Repository: plasma-desktop


Description
---

change see in the diff


Diffs
-

  doc/kcontrol/keys/index.docbook 242e8ce 
  doc/kcontrol/translations/index.docbook a13e8cf 
  kcms/keys/keys.desktop ac6afb6 
  kcms/ksmserver/kcmsmserver.desktop 8ed358b 
  kcms/standard_actions/standard_actions.desktop a454dbd 
  kcms/translations/translations.desktop daf9469 

Diff: https://git.reviewboard.kde.org/r/128434/diff/


Testing
---


File Attachments


adjustments
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128446: KCM move removable devices and device actions into subsection removable-device

[Thomas Pfeiffer]

> On July 14, 2016, 10:52 a.m., Thomas Pfeiffer wrote:
> > Yes, makes sense!

Strike that.
Please change the name to "Removable Storage Media" (or "Removable Storage" if 
the first one is too long), because printers, most input devices and external 
monitors are "removable" just the same.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128446/#review97387
---


On July 14, 2016, 10:39 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128446/
> ---
> 
> (Updated July 14, 2016, 10:39 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> with this patch https://git.reviewboard.kde.org/r/128445/ I add an subgroup 
> removabel devices and now I move the kcm's device actions and removable 
> devices into the new subgroup.
> 
> 
> Diffs
> -
> 
>   kcms/solid_actions/solid-actions.desktop c4850a8 
>   solid-device-automounter/kcm/device_automounter_kcm.desktop 442e41c 
> 
> Diff: https://git.reviewboard.kde.org/r/128446/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128445: add a subsection for removable devices

[Thomas Pfeiffer]

> On July 14, 2016, 12:33 p.m., Thomas Pfeiffer wrote:
> > I just realized that we should rename the sub-group to "Removable Storage" 
> > (or "Removable Storage Media" if that isn't too long) and just treat 
> > cameras as storage media (because that's basically what they act like when 
> > connected to a PC).
> > I'll add that to the other review request.
> > With that name, this change is fine.

And please rename the "Removable Devices" KCM to "Automatic Mounting", because 
that's all it does configure.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128445/#review97396
---


On July 14, 2016, 10:39 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128445/
> ---
> 
> (Updated July 14, 2016, 10:39 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> now we have some kcm modules which are not connected to an subgroup the 
> following kcm modules will be added to the subgroup removable devices when 
> the patch was submitted
> 
> hardware
> - removable devices
>   - removable devices
>   - digital camera
>   - device actions
> 
> how it will look like when I add the patch for the different kcm's
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> this patch don't change anything it's only an preparation.
> 
> 
> Diffs
> -
> 
>   categories/CMakeLists.txt 9bc8307 
>   categories/old/settings-removable-devices.desktop 00098ad 
> 
> Diff: https://git.reviewboard.kde.org/r/128445/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97399
---


Ship it!




Thanks for the patience, looking good now!

- Sebastian Kügler


On July 14, 2016, 12:25 p.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated July 14, 2016, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/keys/index.docbook 242e8ce 
>   doc/kcontrol/translations/index.docbook a13e8cf 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> adjustments
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128445: add a subsection for removable devices

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128445/#review97396
---



I just realized that we should rename the sub-group to "Removable Storage" (or 
"Removable Storage Media" if that isn't too long) and just treat cameras as 
storage media (because that's basically what they act like when connected to a 
PC).
I'll add that to the other review request.
With that name, this change is fine.

- Thomas Pfeiffer


On July 14, 2016, 10:39 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128445/
> ---
> 
> (Updated July 14, 2016, 10:39 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> now we have some kcm modules which are not connected to an subgroup the 
> following kcm modules will be added to the subgroup removable devices when 
> the patch was submitted
> 
> hardware
> - removable devices
>   - removable devices
>   - digital camera
>   - device actions
> 
> how it will look like when I add the patch for the different kcm's
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> this patch don't change anything it's only an preparation.
> 
> 
> Diffs
> -
> 
>   categories/CMakeLists.txt 9bc8307 
>   categories/old/settings-removable-devices.desktop 00098ad 
> 
> Diff: https://git.reviewboard.kde.org/r/128445/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/
---

(Updated July 14, 2016, 12:25 p.m.)


Review request for Plasma.


Changes
---

update the docbook


Repository: plasma-desktop


Description
---

change see in the diff


Diffs (updated)
-

  doc/kcontrol/keys/index.docbook 242e8ce 
  doc/kcontrol/translations/index.docbook a13e8cf 
  kcms/keys/keys.desktop ac6afb6 
  kcms/ksmserver/kcmsmserver.desktop 8ed358b 
  kcms/standard_actions/standard_actions.desktop a454dbd 
  kcms/translations/translations.desktop daf9469 

Diff: https://git.reviewboard.kde.org/r/128434/diff/


Testing
---


File Attachments


adjustments
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2160: [System Tray] Round item size to icon size

[hein (Eike Hein)]

hein added a comment.


  Tray icons still larger than conventional panel icons, here comparing Volume 
Control in tray vs. standalone widget:
  
  F179972: Screenshot_20160714_210106.png 

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2160

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: hein, mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2159: [src/server] Verify that surface has a resource before sending pointer enter

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND92036ba9169d: [src/server] Verify that surface has a 
resource before sending pointer enter (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2159?vs=5144=5157

REVISION DETAIL
  https://phabricator.kde.org/D2159

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/pointer_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] WindowMetadata framework fundamentals

[Sebastian Kügler]

On Thursday, July 14, 2016 6:46:36 PM CEST Eike Hein wrote:
> > looking at the code i see it's still based on window ids, any idea how to 
> > solve that/how to identify windows?
[...]
> That means no more global ids - the object name itself becomes the
> handle.

Right. Will need a bit more code, as the curent code assumes int window ids 
(not that they're actually used right now or useful...)
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] WindowMetadata framework fundamentals

[Martin Graesslin]

On Thursday, July 14, 2016 1:52:26 PM CEST Sebastian Kügler wrote:
> On Thursday, July 14, 2016 1:41:54 PM CEST Martin Graesslin wrote:
> > > > - currently open document
> > > 
> > > Don't most applications expose that in their window title, anyway?
> > 
> > Some do, some don't. Some put it at the start of their title, some at the
> > end.  Some add some character that the data is changed, some don't. Some
> > put the file name in brackets, some the complete path. Some have a config
> > option to control that.
> > 
> > What comes out of it is that the outside applications have no way to
> > gather
> > what the data is.
> 
> That struck me as well. The title field is actually just an example
> (probably a useful one), but of course we can expose more useful
> information, such as the path to the currently opened document, through
> this mechanism.
> 
> What information would be useful here?
> 
> - Title
> - Status
> - Document

- url
- mime/type 



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] WindowMetadata framework fundamentals

[Sebastian Kügler]

On Wednesday, July 13, 2016 5:10:25 PM CEST Thomas Pfeiffer wrote:
> The caveat that writing text into the thumbnail is problematic is a pretty
> big  problem
> from my perspective. For example in a text editor, I don't see how relevant 
> information
> can be represented by a "pretty picture". I'd rather put e.g. the first X 
> characters into
> the thumbnail there, so that even if the document does not have a name yet,
> it can be recognized by its context.
> Or in a terminal I'd show the last output line or something.
> Outside of graphics applications or media players, I don't see how anything 
> without text
> is supposed to transport meaningful information.

These can be conveyed by text properties, though.

> Isn't there any way to work around the DPI problem?

I've thought long and hard about it, one possibility would be to tell the 
client what DPI is expected. The problem is that all the painting takes the 
current screen's DPI and uses that. Shifting a different DPI in there is 
complicated to get right, too complicated that any user of the API will get it 
right.

Text, on the other hand can be filtered, laid out consistently across tasks, 
and can be painted over the preview by the server in the correct DPI. The test 
application contains some example code that overlays the text over the 
thumbnail.

> If not, I'd suggest to allow the application to choose whether it wants a 
> thumbnail or text
> to be shown. Then graphical applications could render a thumbnail, while
> most others would just make it show text.

That's the idea, anyway. Applications don't *have to* supply a thumbnail. All 
of this is optional.

> I'm super-excited to see the window metadata idea come to life, as it
> promises  tons of
> possibilities. It would be sad if we'd limit these possibilities by
> restricting  ourselves to
> "pretty pictures". The goal is to create actually useful thumbnails, after
> all.
> 
> Hope that helps!

It does, thanks.
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 257 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/257/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 11:38:57 +
Build duration: 17 min

CHANGE SET
Revision 2e40cf776db230a9d68cbe3577aa9d5afc91fccd by ivan.cukic: 
(Memory-optimizing Activity object not to keep duplicate data)
  change: edit shell/activity.h
  change: edit shell/activity.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5305 
(37%)CONDITIONAL 1382/5456 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3030 (5%)CONDITIONAL 
88/3183 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Sebastian Kügler]

> On July 14, 2016, 11:41 a.m., Sebastian Kügler wrote:
> > Looks good to me.
> > 
> > Have you checked if any documentation needs updating? (I.e. are any of the 
> > names referred to in docbooks?)
> 
> Andreas Kainz wrote:
> where are the docbooks?

under doc/* in the same repository. Just check whether any of the names have 
been referenced, if so, change them as well.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97392
---


On July 14, 2016, 10:15 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated July 14, 2016, 10:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> adjustments
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2160: [System Tray] Round item size to icon size

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  would have to be only for 5.7 branch tough

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2160

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2159: [src/server] Verify that surface has a resource before sending pointer enter

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  server-check-surface-resource-on-enter

REVISION DETAIL
  https://phabricator.kde.org/D2159

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2149: [platforms/fbdev] Handle error conditions more gracefully

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINf0aeda073835: [platforms/fbdev] Handle error conditions 
more gracefully (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2149?vs=5114=5156

REVISION DETAIL
  https://phabricator.kde.org/D2149

AFFECTED FILES
  plugins/platforms/fbdev/fb_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] WindowMetadata framework fundamentals

[Sebastian Kügler]

On Thursday, July 14, 2016 1:41:54 PM CEST Martin Graesslin wrote:
> > > - currently open document
> >
> > Don't most applications expose that in their window title, anyway?
> 
> Some do, some don't. Some put it at the start of their title, some at the
> end.  Some add some character that the data is changed, some don't. Some
> put the file name in brackets, some the complete path. Some have a config
> option to control that.
> 
> What comes out of it is that the outside applications have no way to gather 
> what the data is.

That struck me as well. The title field is actually just an example (probably 
a useful one), but of course we can expose more useful information, such as 
the path to the currently opened document, through this mechanism.

What information would be useful here?

- Title
- Status
- Document
- ... ?

-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Andreas Kainz]

> On Juli 14, 2016, 11:41 vorm., Sebastian Kügler wrote:
> > Looks good to me.
> > 
> > Have you checked if any documentation needs updating? (I.e. are any of the 
> > names referred to in docbooks?)

where are the docbooks?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97392
---


On Juli 14, 2016, 10:15 vorm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated Juli 14, 2016, 10:15 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> adjustments
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 37 lines] D2165: Port Switch Window containment action to libtaskmanager-ng.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Unfortunately this alone won't make it work on Wayland, as it's
  still based around storing X11 window ids in QActions.
  
  For it to work on Wayland, it should store model indices instead.
  However that requires us to be able to refresh contextualActions()
  while the menu is open, which the Plasma framework does not yet
  allow.
  
  We obviously need to address this later. For now, let's drop
  the old backend and save some CPU and memory.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2165

AFFECTED FILES
  containmentactions/switchwindow/CMakeLists.txt
  containmentactions/switchwindow/switch.cpp
  containmentactions/switchwindow/switch.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[Martin Gräßlin]

graesslin added a comment.


  asking the evil question ;-) Can we autotest this?

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] WindowMetadata framework fundamentals

[Martin Graesslin]

On Wednesday, July 13, 2016 5:10:25 PM CEST Thomas Pfeiffer wrote:
> Hi sebas,
> 
> On 13.07.2016 02:18, Sebastian Kügler wrote:
> > During the Plasma sprint in March, we've been fleshing out plans to create
> > a mechanisms for apps to be represented by the shell.
> > 
> > The goals it to achieve a richer integration between apps and the
> > workspace. The idea is that windows can announce a richer set of metadata
> > that can be used to enhance the window's representation in the
> > workspace/shell. Think of
> > 
> > - task switchers with more meaningful thumbnails of better quality
> 
> Exciting times :)
> 
> > - server-side decoration actions to "remote-control" the app
> > - user-visible features similar to the mpris-controls in the task bar
> 
> So does that mean that parts (or all) of the DWD ideas will be implemented
> using WindowMetadata?

Yes that was always the idea. WindowMetadata is the framework which powers 
DWD.

> 
> > - currently open document
> 
> Don't most applications expose that in their window title, anyway?

Some do, some don't. Some put it at the start of their title, some at the end. 
Some add some character that the data is changed, some don't. Some put the file 
name in brackets, some the complete path. Some have a config option to control 
that.

What comes out of it is that the outside applications have no way to gather 
what the data is.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128434: rename some kcm desktop files

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128434/#review97392
---



Looks good to me.

Have you checked if any documentation needs updating? (I.e. are any of the 
names referred to in docbooks?)

- Sebastian Kügler


On July 14, 2016, 10:15 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128434/
> ---
> 
> (Updated July 14, 2016, 10:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> change see in the diff
> 
> 
> Diffs
> -
> 
>   kcms/keys/keys.desktop ac6afb6 
>   kcms/ksmserver/kcmsmserver.desktop 8ed358b 
>   kcms/standard_actions/standard_actions.desktop a454dbd 
>   kcms/translations/translations.desktop daf9469 
> 
> Diff: https://git.reviewboard.kde.org/r/128434/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> adjustments
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 256 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/256/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 11:19:01 +
Build duration: 16 min

CHANGE SET
Revision 7f060403a2d44fc76b2b14fc9ebf43ee272d1c54 by Marco Martin: 
(Configuration option for System Tray#039;s icon size)
  change: edit applets/systemtray/package/contents/config/main.xml
  change: edit applets/systemtray/package/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5305 
(37%)CONDITIONAL 1382/5456 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3030 (5%)CONDITIONAL 
88/3183 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2162: Memory-optimizing Activity object not to keep duplicate data

[Ivan Čukić]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE2e40cf776db2: Memory-optimizing Activity 
object not to keep duplicate data (authored by ivan).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2162?vs=5153=5154

REVISION DETAIL
  https://phabricator.kde.org/D2162

AFFECTED FILES
  shell/activity.cpp
  shell/activity.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2162: Memory-optimizing Activity object not to keep duplicate data

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2162

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 145 lines] D2162: Memory-optimizing Activity object not to keep duplicate data

[Ivan Čukić]

ivan updated this revision to Diff 5153.
ivan added a comment.


  Removing the mutex since Activity objects should reside in the same thread

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2162?vs=5151=5153

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2162

AFFECTED FILES
  shell/activity.cpp
  shell/activity.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2164: Allow struts on panels between screen edges if WM is KWin

[Martin Gräßlin]

graesslin updated the summary for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2164

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 255 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/255/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 11:04:15 +
Build duration: 13 min

CHANGE SET
Revision 56ea0f5947ac3ef285acca2981324c9afbb1c5ec by hein: (Adjust indices in 
manual sort map by removal delta after removal, not)
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5305 
(37%)CONDITIONAL 1382/5456 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3030 (5%)CONDITIONAL 
88/3183 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 106 lines] D2164: Allow struts on panels between screen edges if WM is KWin

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KWin starting with 5.7 supports struts on panels between screen edges.
  Thus we can start setting struts on such panels, it won't exclude a
  complete screen. But we don't know how other window managers handle it
  and it's in general a rather "dangerous" change.
  
  Thus to not affect other window managers, we check whether KWin is
  running and only allow struts on thus panels if KWin is running.
  Unfortunately we need to test this every time we go into the code path
  as the WM might have changed.
  
  In case the user replaces the window manager at runtime this still can
  result in a bad situation.
  
  BUG: 71086
  FIXED-IN: 5.8.0

TEST PLAN
  Tested whether it works in general in X11. Further testing
  needed by X11, multi-screen users.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  struts-shared-panels

REVISION DETAIL
  https://phabricator.kde.org/D2164

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 40 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 14 Jul 2016 11:03:45 +
Build duration: 58 sec

CHANGE SET
Revision 56ea0f5947ac3ef285acca2981324c9afbb1c5ec by hein: (Adjust indices in 
manual sort map by removal delta after removal, not)
  change: edit libtaskmanager/tasksmodel.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/
---

(Updated July 14, 2016, 11:04 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 7f060403a2d44fc76b2b14fc9ebf43ee272d1c54 by Marco Martin 
to branch master.


Repository: plasma-workspace


Description
---

Configuration option for system tray's icon sizes in order to be handled by 
look & feel themes/packages.


Diffs
-

  applets/systemtray/package/contents/config/main.xml 65a7029 
  applets/systemtray/package/contents/ui/main.qml a66ea69 

Diff: https://git.reviewboard.kde.org/r/128400/diff/


Testing
---

Tested in KDE Neon Developer Stable (as of July 7, 2016)


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[Marco Martin]

> On July 14, 2016, 10:33 a.m., Viorel-Cătălin Răpițeanu wrote:
> > Is there any status update on this commit? Should it be integrated?
> 
> John Salatas wrote:
> I'm done with it. Hopefully someone will commit to git as I don't have 
> commit rights in order to do it myself.

i an commit it, but if oyu are interested, you can request for commit rights :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97384
---


On July 12, 2016, 8:29 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 12, 2016, 8:29 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Configuration option for system tray's icon sizes in order to be handled by 
> look & feel themes/packages.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 142 lines] D2162: Memory-optimizing Activity object not to keep duplicate data

[Ivan Čukić]

ivan created this revision.
ivan added reviewers: mart, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Activity object kept all the data that KActivities::Info keeps,
  
and an instance of KActivities::Info object. It is now just a thin
wrapper for the Info class.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2162

AFFECTED FILES
  shell/activity.cpp
  shell/activity.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128446: KCM move removable devices and device actions into subsection removable-device

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128446/#review97387
---



Yes, makes sense!

- Thomas Pfeiffer


On July 14, 2016, 10:39 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128446/
> ---
> 
> (Updated July 14, 2016, 10:39 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> with this patch https://git.reviewboard.kde.org/r/128445/ I add an subgroup 
> removabel devices and now I move the kcm's device actions and removable 
> devices into the new subgroup.
> 
> 
> Diffs
> -
> 
>   kcms/solid_actions/solid-actions.desktop c4850a8 
>   solid-device-automounter/kcm/device_automounter_kcm.desktop 442e41c 
> 
> Diff: https://git.reviewboard.kde.org/r/128446/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

> On July 14, 2016, 10:33 a.m., Viorel-Cătălin Răpițeanu wrote:
> > Is there any status update on this commit? Should it be integrated?

I'm done with it. Hopefully someone will commit to git as I don't have commit 
rights in order to do it myself.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97384
---


On July 12, 2016, 8:29 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 12, 2016, 8:29 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Configuration option for system tray's icon sizes in order to be handled by 
> look & feel themes/packages.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

[John Salatas]

> On July 10, 2016, 8:49 p.m., Thomas Pfeiffer wrote:
> > Nice feature, but the UI unnecessarily mixes two different interaction 
> > patterns: Checkboxes and drag
> > What I'd prefer to do (and we should introduce that as a general paradigm 
> > for such things): Put a box "Hidden tabs" below the visualization of the 
> > active tabs and allow to add and remove via drag and drop. 
> > The visualization would be:
> > 
> > ---
> > Visible Tabs:
> > [ ] [ ] [ ] (ideally visualized like the actual Plasmoid)
> > 
> > "Hidden Tabs"
> > [ ] [ ]
> > 
> > Drag tabs between the boxes to show/hide them, or reorder the visible tabs 
> > by dragging. 
> > 
> > ---
> > That way reaordering and show/hide would work in the same way, and the 
> > "Visible Tabs" box would always exactly represent reality.

Updated as per your suggestions.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97267
---


On July 14, 2016, 10:42 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated July 14, 2016, 10:42 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 361210
> https://bugs.kde.org/show_bug.cgi?id=361210
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide any menu and also 
> according to bug 361210 to reorganize them.
> 
> In the attached screenshot you can see
> 
> 1) the configuration options: These are just the menu buttons than can be 
> rearranged or hidden/shown via drag n drop
> 2) The Kickoff menu with just 3 menu items (the other two are hidden).
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
>   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> ested in KDE Neon Developer Stable (as of July 14, 2016)
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

[John Salatas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/
---

(Updated July 14, 2016, 10:42 a.m.)


Review request for Plasma.


Bugs: 361210
https://bugs.kde.org/show_bug.cgi?id=361210


Repository: plasma-desktop


Description (updated)
---

I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab 
in kickoff is somewhat redundant, as I have added launchers for all of my 
favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide any menu and also according 
to bug 361210 to reorganize them.

In the attached screenshot you can see

1) the configuration options: These are just the menu buttons than can be 
rearranged or hidden/shown via drag n drop
2) The Kickoff menu with just 3 menu items (the other two are hidden).


Diffs (updated)
-

  applets/kickoff/package/contents/config/main.xml 2de73ba 
  applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
  applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128402/diff/


Testing (updated)
---

ested in KDE Neon Developer Stable (as of July 14, 2016)


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128447: KCM move digital camera into subsection removable-device

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128447/
---

Review request for Plasma and Thomas Pfeiffer.


Repository: kamera


Description
---

with this patch https://git.reviewboard.kde.org/r/128445/ I add an subgroup 
removabel devices and now I move the kcm digital camera into the new subgroup.


Diffs
-

  kcontrol/kamera.desktop 0b35db8 

Diff: https://git.reviewboard.kde.org/r/128447/diff/


Testing
---


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128446: KCM move removable devices and device actions into subsection removable-device

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128446/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

with this patch https://git.reviewboard.kde.org/r/128445/ I add an subgroup 
removabel devices and now I move the kcm's device actions and removable devices 
into the new subgroup.


Diffs
-

  kcms/solid_actions/solid-actions.desktop c4850a8 
  solid-device-automounter/kcm/device_automounter_kcm.desktop 442e41c 

Diff: https://git.reviewboard.kde.org/r/128446/diff/


Testing
---


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel