Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Roman Gilg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/
---

(Updated Okt. 17, 2016, 9:02 vorm.)


Review request for Plasma and Martin Gräßlin.


Bugs: 367685
http://bugs.kde.org/show_bug.cgi?id=367685


Repository: plasma-framework


Description (updated)
---

# The new Meta-key support for launcher opening doesn't work for closing at the 
moment. My analysis of the problem was as follows:

- KWin calls Applet::activated() over DBus
- Applet::activated() is connected to AppletInterface::activated()
- AppletInterface::activated() is connected to setExpanded(true), which can 
only expand the launcher, but not the other way around

# Q: Why is Alt+F1 working though?
A: The launchers seem to inherit the reimplemented function 
Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
the focusOutEvent(..) as a global shortcut.

# Q: Why is it working with the Dashboard though?
A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
connects directly to the AppletInterface::activated() signal and shows/hides an 
independent widget when this signal gets triggered.

# Solution:
Create new toggled() signal chain in KWin, Applet, AppletInterface, which tests 
the current expanded state and sets it afterwards accordingly to the opposite. 
This diff here in plasma-framework is the first one, which the others depend 
on. The others are on Phabricator:

- kwin: https://phabricator.kde.org/D3077
- plasma-workspace: https://phabricator.kde.org/D3078
- plasma-desktop: https://phabricator.kde.org/D3079

# Need feedback regarding:

- Should we remove the activated() signal chain? Is it used somewhere else than 
KWin?
- Could a race condition occur if we deexpand the applet while at the same time 
setting the visibility to false through focusOutEvent()? My tests until now 
don't suggest it, but I haven't yet looked into it extensively.


Diffs
-

  src/plasma/applet.h 89498ea 
  src/scriptengines/qml/plasmoid/appletinterface.h a1e2cd7 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 

Diff: https://git.reviewboard.kde.org/r/129204/diff/


Testing
---


Thanks,

Roman Gilg

[Differential] [Closed] D3059: [effects] Make screenshot effect work with multiple output rendering

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINeadfcb3d4f12: [effects] Make screenshot effect work with 
multiple output rendering (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3059?vs=7396&id=7448

REVISION DETAIL
  https://phabricator.kde.org/D3059

AFFECTED FILES
  effects/screenshot/screenshot.cpp
  effects/screenshot/screenshot.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3058: Pass the current output geometry to ScreenPaintData

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN359224a5dcf9: Pass the current output geometry to 
ScreenPaintData (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3058?vs=7395&id=7449

REVISION DETAIL
  https://phabricator.kde.org/D3058

AFFECTED FILES
  autotests/test_screen_paint_data.cpp
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h
  scene.cpp
  scene.h
  scene_opengl.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3047: Support custom color scheme for Wayland windows

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINf41b610608a4: Support custom color scheme for Wayland 
windows (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3047?vs=7370&id=7445

REVISION DETAIL
  https://phabricator.kde.org/D3047

AFFECTED FILES
  shell_client.cpp
  shell_client.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3023: Set icon to wayland if desktop file is not found

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN8201def97fcc: Set icon to wayland if desktop file is not 
found (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3023?vs=7308&id=7444

REVISION DETAIL
  https://phabricator.kde.org/D3023

AFFECTED FILES
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts

[Differential] [Closed] D3050: Use new PlasmaWindowInterface::setIcon

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN05d21b6b25ce: Use new PlasmaWindowInterface::setIcon 
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3050?vs=7377&id=7447

REVISION DETAIL
  https://phabricator.kde.org/D3050

AFFECTED FILES
  abstract_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, hein, subdiff
Cc: subdiff, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3056: Fix glBlitFramebuffer for per-output rendering

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN4e9a1eeb5036: Fix glBlitFramebuffer for per-output 
rendering (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3056?vs=7392&id=7446

REVISION DETAIL
  https://phabricator.kde.org/D3056

AFFECTED FILES
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  scene_opengl.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/
---

(Updated Oct. 17, 2016, 7:35 a.m.)


Review request for Plasma.


Changes
---

Drop changing the Qt Requirement for the framework, applied an extended patch 
based on another review


Repository: plasma-framework


Description
---

Being a newbie, following build instruction from the wiki, I could not build 
plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).

Two of the changes are coding issues.

The change in CMakeLists.txt comes from a wrong required version, also stated 
here: https://git.reviewboard.kde.org/r/128763/. 

For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.


Diffs (updated)
-

  src/declarativeimports/core/windowthumbnail.cpp 0453c09 
  src/plasmaquick/dialog.cpp eac9ee5 
  src/plasmaquick/dialogshadows.cpp eb67926 

Diff: https://git.reviewboard.kde.org/r/129203/diff/


Testing
---

Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial


Thanks,

Alberto Curro

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

> On Oct. 17, 2016, 4:51 a.m., Anthony Fieroni wrote:
> > CMakeLists.txt, line 47
> > 
> >
> > You can't increase minimum deps only for this framework. It's done 
> > automatically for all and when it's needed. Just try this patch 
> > https://git.reviewboard.kde.org/r/129065/ give 'ship it' if works correctly

I see, the original patch was not enough, there are 2 usings of 
QQuickWindow::NoStage, so I've updated the patch.


- Alberto


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100058
---


On Oct. 17, 2016, 1:37 a.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 1:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3c0eaee 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

[Differential] [Commented On] D3009: Fix logout translation message

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Do you have commit access?

REVISION DETAIL
  https://phabricator.kde.org/D3009

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma_workspaces, mart
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3055: Small polishing changes to the lockscreen lookandfeel package

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3055

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, davidedmundson
Cc: eliasp, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100067
---




src/scriptengines/qml/plasmoid/appletinterface.cpp (line 151)


Because AppletInterface::activated is a signal, applets could connect to to 
do extra actions on external activation; we're not emitting that with this 
signal.

and this isn't just hypothetical as kicker does.

kicker/package/contents/ui/CompactRepresentation.qml:   
plasmoid.activated.connect(function()

(ironically to do toggling on the dash window)

By introducing a new signal, this breaks existing applets.

We could maybe simply add 
if (activate) emit activated();

and it'd work.

Question:
the current global shortcuts seem to toggle, and they only connect to 
activate(), how do they work?


- David Edmundson


On Oct. 17, 2016, 7:02 a.m., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Oct. 17, 2016, 7:02 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time setting the visibility to false through focusOutEvent()? My tests until 
> now don't suggest it, but I haven't yet looked into it extensively.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.h 89498ea 
>   src/scriptengines/qml/plasmoid/appletinterface.h a1e2cd7 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 
> 
> Diff: https://git.reviewboard.kde.org/r/129204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[David Edmundson]

> On Oct. 17, 2016, 8:26 a.m., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151
> > 
> >
> > Because AppletInterface::activated is a signal, applets could connect 
> > to to do extra actions on external activation; we're not emitting that with 
> > this signal.
> > 
> > and this isn't just hypothetical as kicker does.
> > 
> > kicker/package/contents/ui/CompactRepresentation.qml:   
> > plasmoid.activated.connect(function()
> > 
> > (ironically to do toggling on the dash window)
> > 
> > By introducing a new signal, this breaks existing applets.
> > 
> > We could maybe simply add 
> > if (activate) emit activated();
> > 
> > and it'd work.
> > 
> > Question:
> > the current global shortcuts seem to toggle, and they only connect to 
> > activate(), how do they work?

sorry, you literally have a sentence for that in your description. Ignore my 
last comment.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100067
---


On Oct. 17, 2016, 7:02 a.m., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Oct. 17, 2016, 7:02 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time setting the visibility to false through focusOutEvent()? My tests until 
> now don't suggest it, but I haven't yet looked into it extensively.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.h 89498ea 
>   src/scriptengines/qml/plasmoid/appletinterface.h a1e2cd7 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 
> 
> Diff: https://git.reviewboard.kde.org/r/129204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

[Differential] [Accepted] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3078

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, davidedmundson
Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  This breaks the normal keyboard shortcut working at all.
  
  You either need to connect to both or
  
  if we put in the addition emit I suggest in 
https://git.reviewboard.kde.org/r/129204/
  and then you don't need this change.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3079

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, broulik
Cc: davidedmundson, plasma-devel, #plasma, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 129203: Fixes for building plasma-framework

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100069
---




src/declarativeimports/core/windowthumbnail.cpp (line 231)


FWIW: https://git.reviewboard.kde.org/r/129065/


- David Edmundson


On Oct. 17, 2016, 7:35 a.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 7:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

[Differential] [Commented On] D3009: Fix logout translation message

[guoyunhe (Yunhe Guo)]

guoyunhe added a comment.


  In https://phabricator.kde.org/D3009#57056, @davidedmundson wrote:
  
  > Do you have commit access?
  
  
  No, I do not have.

REVISION DETAIL
  https://phabricator.kde.org/D3009

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma_workspaces, mart
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Kai Uwe Broulik]

> On Okt. 17, 2016, 8:26 vorm., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151
> > 
> >
> > Because AppletInterface::activated is a signal, applets could connect 
> > to to do extra actions on external activation; we're not emitting that with 
> > this signal.
> > 
> > and this isn't just hypothetical as kicker does.
> > 
> > kicker/package/contents/ui/CompactRepresentation.qml:   
> > plasmoid.activated.connect(function()
> > 
> > (ironically to do toggling on the dash window)
> > 
> > By introducing a new signal, this breaks existing applets.
> > 
> > We could maybe simply add 
> > if (activate) emit activated();
> > 
> > and it'd work.
> > 
> > Question:
> > the current global shortcuts seem to toggle, and they only connect to 
> > activate(), how do they work?
> 
> David Edmundson wrote:
> sorry, you literally have a sentence for that in your description. Ignore 
> my last comment.

> the current global shortcuts seem to toggle, and they only connect to 
> activate(), how do they work?

>From what I can tell, technically the Meta behavior is actually the correct 
>one. As far as I understood, KGlobalAccel registers a "soft grab" on the 
>global shortcuts. When they are pressed, X grabs them, and KGlobalAccel 
>ungrabs them again; this causes the window to lose focus and it closes.

You can observe this when you e.g. change volume while any Plasma popup is 
open, behavior is the same. I don't know how it behaves on Wayland, though, and 
what we should do with the Meta key to improve the situation.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100067
---


On Okt. 17, 2016, 7:02 vorm., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Okt. 17, 2016, 7:02 vorm.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time setting the visibility to false through focusOutEvent()? My tests until 
> now don't suggest it, but I haven't yet looked into it extensively.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.h 89498ea 
>   src/scriptengines/qml/plasmoid/appletinterface.h a1e2cd7 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 
> 
> Diff: https://git.reviewboard.kde.org/r/129204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

[subdiff (Roman Gilg)]

subdiff added a comment.


  In https://phabricator.kde.org/D3079#57067, @davidedmundson wrote:
  
  > This breaks the normal keyboard shortcut working at all.
  >
  > You either need to connect to both or
  >
  > if we put in the addition emit I suggest in 
https://git.reviewboard.kde.org/r/129204/
  >  and then you don't need this change.
  
  
  Does it not work on your system? Have you also applied the other diffs on 
phab mentioned in the reviewboard diff? It shouldn't break the normal keyboard 
shortcut. It works on my system.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3079

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, broulik
Cc: davidedmundson, plasma-devel, #plasma, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

> On Sept. 15, 2016, 7:28 vorm., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both 
> > modules can be available at the same time? This is the problem of the 
> > missing support for kcontrol5
> > 
> > It was already done some time ago and I had to revert it:
> > https://marc.info/?t=14207454037&r=1&w=1
> > https://marc.info/?l=kde-i18n-doc&m=142076318528227&w=1
> 
> Burkhard Lück wrote:
> Sure we can make them co-installable, we just need to decide how to do it
> so far in kf5 we install to ${HTML_INSTALL_DIR}/en SUBDIR kcontrol/ = 
> same subdir as kde4/kde-runtime
> all kcontrol docbooks have the same name in kf5 + kde4 except for 
> cddbretrieval (kde4) / cddbretrieval5 (kf5) and ebrowsing (kde4) / 
> webshortcuts (kf5)
> 
> Options for co-installable:
> 
> 1) append a "5" to every kcm docbook name
> 2) install every kcm docbook to SUBDIR kcontrol5
> 
> Both options require mass renaming X-DocPath, CMakeLists.txt, translation 
> catalogs etc.
> 
> For kioslave docbooks we already use SUBDIR kioslave5, so we should use 
> SUBDIR kcontrol5 to keep consistency

Regarding co-installable:

frameworks/kdelibs4support has docs/kcontrol/kcm_ssl/index.docbook since 5.0.0
debian testing (stretch) and ubuntu 16.10 (yakkety) install 
kcm_ssl/index.docbook in
/usr/share/doc/kde/HTML/en/kcontrol/ from package kde-runtime-data
and
/usr/share/doc/HTML/en/kcontrol/ from package libkf5kdelibs4support-data
i.e. distinguished using an additional subdir "kde" in the install path from 
package kde-runtime-data

So we have apparently no conflict in debian based distributions and apparently 
no conflict in builds from sources (no one complained since frameworks 5.0.0)

Is this really a conflict in rpm based systems e.g. SuSe, RedHat ?


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99183
---


On Sept. 15, 2016, 9:09 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

[Differential] [Request, 370 lines] D3080: Panel auto hide support for Wayland panels

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, bshah.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  This change implements auto-hide support for Wayland panels. To properly
  test the screenedgeshowtest is reworked to support both X11 and Wayland
  windows.

REPOSITORY
  rKWIN KWin

BRANCH
  panel-autohide-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3080

AFFECTED FILES
  shell_client.cpp
  shell_client.h
  tests/CMakeLists.txt
  tests/screenedgeshowtest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

[Martin Gräßlin]

graesslin added a dependent revision: D3080: Panel auto hide support for 
Wayland panels.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  panel-auto-hide

REVISION DETAIL
  https://phabricator.kde.org/D3007

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, #plasma_on_wayland
Cc: sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Updated] D3080: Panel auto hide support for Wayland panels

[Martin Gräßlin]

graesslin added a dependency: D3007: Add auto-hiding panel support to 
PlasmaShellSurface interface.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3080

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

[mart (Marco Martin)]

mart added a comment.


  shouldn't be completely removed then?

REPOSITORY
  rUSERMANAGER User Manager

REVISION DETAIL
  https://phabricator.kde.org/D3062

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3071: Port away from KDELibs4Support

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rUSERMANAGER User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3071

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: System Settings KCM cleanup (KIO)

[Sebastian Kügler]

On zaterdag 15 oktober 2016 13:32:35 CEST kainz.a wrote:
> there are some KCM's the default user didn't need, some of them are also
> broken. It need some time to realize that the KCM's are from KIO.
> 
> connectivity -> Samba Shares (didn't work)

Then it should be fixed...

> some kcm's are available but only needed if you install a kde browser. So
> please activate this KCM's not by default. maybe when you install a KDE
> browser the KCM's should be added (or you can change the setting in the
> browser) - browser
> - cookies
> - SSL Settings
> - web shortcuts
> - net preferences
> - useragent
> 
> so from the KIO kcm's I think only the proxy kcm should be installed by
> default (if it work, never use it)
> 
> I think a cleanup by default is needed and have KCM's you can't change
> anything cause the user use firefox would help nobody.

They're used, though, for KIO. (I tend to agree that they should not be all 
shown in systemsettings, that has been confusing me as well.)

The web shortcuts perhaps is an exemption, as that's also used by krunner, 
iirc.
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Martin Gräßlin]

> On Oct. 17, 2016, 10:26 a.m., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151
> > 
> >
> > Because AppletInterface::activated is a signal, applets could connect 
> > to to do extra actions on external activation; we're not emitting that with 
> > this signal.
> > 
> > and this isn't just hypothetical as kicker does.
> > 
> > kicker/package/contents/ui/CompactRepresentation.qml:   
> > plasmoid.activated.connect(function()
> > 
> > (ironically to do toggling on the dash window)
> > 
> > By introducing a new signal, this breaks existing applets.
> > 
> > We could maybe simply add 
> > if (activate) emit activated();
> > 
> > and it'd work.
> > 
> > Question:
> > the current global shortcuts seem to toggle, and they only connect to 
> > activate(), how do they work?
> 
> David Edmundson wrote:
> sorry, you literally have a sentence for that in your description. Ignore 
> my last comment.
> 
> Kai Uwe Broulik wrote:
> > the current global shortcuts seem to toggle, and they only connect to 
> activate(), how do they work?
> 
> From what I can tell, technically the Meta behavior is actually the 
> correct one. As far as I understood, KGlobalAccel registers a "soft grab" on 
> the global shortcuts. When they are pressed, X grabs them, and KGlobalAccel 
> ungrabs them again; this causes the window to lose focus and it closes.
> 
> You can observe this when you e.g. change volume while any Plasma popup 
> is open, behavior is the same. I don't know how it behaves on Wayland, 
> though, and what we should do with the Meta key to improve the situation.

> You can observe this when you e.g. change volume while any Plasma popup is 
> open, behavior is the same. I don't know how it behaves on Wayland, though, 
> and what we should do with the Meta key to improve the situation.

On Wayland global shortcut doesn't result in losing focus. I just tried alt+f1 
-> kickoff opens, Alt+F1 again -> kickoff doesn't close


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100067
---


On Oct. 17, 2016, 9:02 a.m., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Oct. 17, 2016, 9:02 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time setting the visibility to false through focusOutEvent()? My tests until 
> now don't suggest it, but I haven't yet looked into it extensively.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.h 89498ea 
>   src/scriptengines/qml/plasmoid/appletinterface.h a1e2cd7 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 
> 
> Diff: https://git.reviewboard.kde.org/r/129204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Gilg
> 

Re: Review Request 129203: Fixes for building plasma-framework

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100077
---


Ship it!




Do you have commit access?

- David Edmundson


On Oct. 17, 2016, 7:35 a.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 7:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100072
---




src/scriptengines/qml/plasmoid/appletinterface.h (line 408)


it would be nice a bool paramenter here with the new value of expanded


- Marco Martin


On Oct. 17, 2016, 7:02 a.m., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Oct. 17, 2016, 7:02 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time setting the visibility to false through focusOutEvent()? My tests until 
> now don't suggest it, but I haven't yet looked into it extensively.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.h 89498ea 
>   src/scriptengines/qml/plasmoid/appletinterface.h a1e2cd7 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 
> 
> Diff: https://git.reviewboard.kde.org/r/129204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review100078
---


Ship it!




Ship It!

- Marco Martin


On Sept. 15, 2016, 9:09 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 129157: Desktop Settings Tweaks

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129157/#review100079
---


Ship it!




Ship It!

- Marco Martin


On Oct. 12, 2016, 11:29 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129157/
> ---
> 
> (Updated Oct. 12, 2016, 11:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> In the desktop dialogue section tweaks is written:
> 
> Tweaks are experimental options that may become defaults depending on your 
> feedback.
> 
> as all "experimental" settins are activated by default this settings aren't 
> experimental any more or?
> 
> So please don't say we add experimental settings by default to the 
> (beta)users.
> 
> 
> Diffs
> -
> 
>   containments/desktop/package/contents/ui/ConfigTweaks.qml 280c24e 
> 
> Diff: https://git.reviewboard.kde.org/r/129157/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Luigi Toscano]

> On Sept. 15, 2016, 9:28 a.m., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both 
> > modules can be available at the same time? This is the problem of the 
> > missing support for kcontrol5
> > 
> > It was already done some time ago and I had to revert it:
> > https://marc.info/?t=14207454037&r=1&w=1
> > https://marc.info/?l=kde-i18n-doc&m=142076318528227&w=1
> 
> Burkhard Lück wrote:
> Sure we can make them co-installable, we just need to decide how to do it
> so far in kf5 we install to ${HTML_INSTALL_DIR}/en SUBDIR kcontrol/ = 
> same subdir as kde4/kde-runtime
> all kcontrol docbooks have the same name in kf5 + kde4 except for 
> cddbretrieval (kde4) / cddbretrieval5 (kf5) and ebrowsing (kde4) / 
> webshortcuts (kf5)
> 
> Options for co-installable:
> 
> 1) append a "5" to every kcm docbook name
> 2) install every kcm docbook to SUBDIR kcontrol5
> 
> Both options require mass renaming X-DocPath, CMakeLists.txt, translation 
> catalogs etc.
> 
> For kioslave docbooks we already use SUBDIR kioslave5, so we should use 
> SUBDIR kcontrol5 to keep consistency
> 
> Burkhard Lück wrote:
> Regarding co-installable:
> 
> frameworks/kdelibs4support has docs/kcontrol/kcm_ssl/index.docbook since 
> 5.0.0
> debian testing (stretch) and ubuntu 16.10 (yakkety) install 
> kcm_ssl/index.docbook in
> /usr/share/doc/kde/HTML/en/kcontrol/ from package kde-runtime-data
> and
> /usr/share/doc/HTML/en/kcontrol/ from package libkf5kdelibs4support-data
> i.e. distinguished using an additional subdir "kde" in the install path 
> from package kde-runtime-data
> 
> So we have apparently no conflict in debian based distributions and 
> apparently no conflict in builds from sources (no one complained since 
> frameworks 5.0.0)
> 
> Is this really a conflict in rpm based systems e.g. SuSe, RedHat ?

Yes, it is. Other distributions used the default value, which is 
/usr/share/doc/HTML/.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99183
---


On Sept. 15, 2016, 11:09 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 11:09 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 129150: Use less deprecated API

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129150/#review100081
---


Ship it!




Ship It!

- Marco Martin


On Oct. 11, 2016, 1:48 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129150/
> ---
> 
> (Updated Oct. 11, 2016, 1:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Make it easier to look at the compilation output.
> 
> 
> Diffs
> -
> 
>   src/plasma/containment.cpp 1c49f05 
>   src/plasma/scripting/appletscript.cpp a2342a3 
>   src/plasmaquick/appletquickitem.cpp 2f100b8 
>   src/plasmaquick/configview.cpp 73e4974 
>   src/plasmaquick/containmentview.cpp 43f0fdd 
>   src/plasmaquick/view.cpp 6ab0012 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 160cdd7 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 173573e 
> 
> Diff: https://git.reviewboard.kde.org/r/129150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Plasma Sprint vs FOSDEM

[Kai Uwe Broulik]

Hi all,

I decided on 6 February through 12 February for the Plasma sprint. Although 
there was a thread on the ml and nobody objected, there were concerns now that 
it might conflict with FOSDEM which is on 4/5 February. 

‎Is this an issue for anyone? 

Cheers, 
Kai Uwe ‎

Re: Plasma Sprint vs FOSDEM

[Sebastian Kügler]

On maandag 17 oktober 2016 12:33:32 CEST Kai Uwe Broulik wrote:
> I decided on 6 February through 12 February for the Plasma sprint. Although
> there was a thread on the ml and nobody objected, there were concerns now
> that it might conflict with FOSDEM which is on 4/5 February.
> 
> ‎Is this an issue for anyone?

Not for me, I'm not planning to go to FOSDEM. Would re-scheduling to a week 
later be a problem at all, or just a little bit inconvenient?
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: Plasma Sprint vs FOSDEM

[Jonathan Riddell]

KDE road trip!  David fancy a drive?

Jonathan


On 17 October 2016 at 11:35, Sebastian Kügler  wrote:
> On maandag 17 oktober 2016 12:33:32 CEST Kai Uwe Broulik wrote:
>> I decided on 6 February through 12 February for the Plasma sprint. Although
>> there was a thread on the ml and nobody objected, there were concerns now
>> that it might conflict with FOSDEM which is on 4/5 February.
>>
>> ‎Is this an issue for anyone?
>
> Not for me, I'm not planning to go to FOSDEM. Would re-scheduling to a week
> later be a problem at all, or just a little bit inconvenient?
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129091/#review100083
---



should those be themed in the plasma theme?
shouldn't them just go in the regular breeze icon theme?

- Marco Martin


On Oct. 6, 2016, 6:03 p.m., Yunhe Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129091/
> ---
> 
> (Updated Oct. 6, 2016, 6:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This patch adds icons for Fcitx system tray icon. Fcitx is the default input 
> method framework in most Chinese GNU/Linux desktop system. These icons will 
> make Fcitx looks better in system tray.
> 
> ime.svgz
> 
> - ime-fullwidth
> - ime-halfwidth
> - ime-punctuation-fullwidth
> - ime-punctuation-halfwidth
> - ime-chinese-simplified
> - ime-chinese-traditional
> - ime-remind-on
> - ime-remind-off
> - ime-handwriting-on
> - ime-handwriting-off
> - ime-erbi
> - ime-googlepinyin
> - ime-libpinyin-pinyin
> - ime-libpinyin-quanpin
> - ime-libpinyin-shuangpin
> - ime-pinyin
> - ime-quanpin
> - ime-shuangpin
> - ime-sunpinyin
> - ime-wubi
> - ime-wubipinyin
> - ime-ziranma
> - ime-bopomofo
> - ime-cangjie
> - ime-chewing
> - ime-libpinyin-bopomofo
> - ime-libpinyin-chewing
> - ime-rime
> - ime-anthy
> - ime-libkkc
> - ime-libskk
> - ime-hangul
> - ime-unikey
> - ime-emoji
> 
> fcitx.svgz
> 
> - fcitx
> - fcitx-kbd
> - fcitx-vk-active
> - fcitx-vk-inactive
> - fcitx-remind-active
> - fcitx-remind-inactive
> - fcitx-chntran-active
> - fcitx-chntran-inactive
> - fcitx-fullwidth-active
> - fcitx-fullwidth-inactive
> - fcitx-punc-active
> - fcitx-punc-inactive
> - fcitx-pinyin
> - fcitx-shuangpin
> - fcitx-wubi
> - fcitx-pinyin-libpinyin
> - fcitx-shuangpin-libpinyin
> - fcitx-bopomofo
> - fcitx-sunpinyin
> - fcitx-googlepinyin
> - fcitx-emoji
> - ...
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION 
>   src/desktoptheme/breeze/icons/ime.svgz PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129091/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Spectacle.Et8101.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png
> Spectacle.AD8101.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png
> Screenshot_20161006_201118.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/9b51635d-7461-40b4-9c59-27d07407a475__Screenshot_20161006_201118.png
> Spectacle.Zb3480.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/74a7126d-f917-4be0-864c-9f5f5253d448__Spectacle.Zb3480.png
> 
> 
> Thanks,
> 
> Yunhe Guo
> 
>

Re: Review Request 129098: Add keyboard icons for kimpanel

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129098/#review100084
---


Ship it!




Ship It!

- Marco Martin


On Oct. 6, 2016, 5:56 p.m., Yunhe Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129098/
> ---
> 
> (Updated Oct. 6, 2016, 5:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> input.svgz
> 
> - input-keyboard
> - input-keyboard-virtual-on
> - input-keyboard-virtual-off
> 
> keyboard.svgz:
> - 32-32-keyboard-layout
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/input.svgz 
> ef7ba12c12427d2171ad31ebe5886c9665e4cdf0 
>   src/desktoptheme/breeze/icons/keyboard.svgz 
> 7b6d5926b181f0c6770d7c1938d63222adaf1e76 
> 
> Diff: https://git.reviewboard.kde.org/r/129098/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/04/6647cc3d-3e86-43fa-aa20-a716d5af85d1__37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png
> keyboard.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/07/73c4298a-243c-4589-9f35-db878def245a__keyboard.png
> input.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/07/a0698fa5-8cf0-4091-88f1-ac718ac3b0e0__input.png
> 
> 
> Thanks,
> 
> Yunhe Guo
> 
>

Re: Review Request 129157: Desktop Settings Tweaks

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129157/
---

(Updated Oct. 17, 2016, 10:42 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit a9db2cc6b21e0f4df5d9ca45dce234d3b3feedde by andreas kainz 
to branch master.


Repository: plasma-desktop


Description
---

In the desktop dialogue section tweaks is written:

Tweaks are experimental options that may become defaults depending on your 
feedback.

as all "experimental" settins are activated by default this settings aren't 
experimental any more or?

So please don't say we add experimental settings by default to the (beta)users.


Diffs
-

  containments/desktop/package/contents/ui/ConfigTweaks.qml 280c24e 

Diff: https://git.reviewboard.kde.org/r/129157/diff/


Testing
---


Thanks,

Andreas Kainz

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

[Yunhe Guo]

> On 十月 17, 2016, 10:38 a.m., Marco Martin wrote:
> > should those be themed in the plasma theme?
> > shouldn't them just go in the regular breeze icon theme?

I have discussed with Breeze icon team. They suggest to move these icons to 
plasma theme since they are mostly used in system tray/widget.


- Yunhe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129091/#review100083
---


On 十月 6, 2016, 6:03 p.m., Yunhe Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129091/
> ---
> 
> (Updated 十月 6, 2016, 6:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This patch adds icons for Fcitx system tray icon. Fcitx is the default input 
> method framework in most Chinese GNU/Linux desktop system. These icons will 
> make Fcitx looks better in system tray.
> 
> ime.svgz
> 
> - ime-fullwidth
> - ime-halfwidth
> - ime-punctuation-fullwidth
> - ime-punctuation-halfwidth
> - ime-chinese-simplified
> - ime-chinese-traditional
> - ime-remind-on
> - ime-remind-off
> - ime-handwriting-on
> - ime-handwriting-off
> - ime-erbi
> - ime-googlepinyin
> - ime-libpinyin-pinyin
> - ime-libpinyin-quanpin
> - ime-libpinyin-shuangpin
> - ime-pinyin
> - ime-quanpin
> - ime-shuangpin
> - ime-sunpinyin
> - ime-wubi
> - ime-wubipinyin
> - ime-ziranma
> - ime-bopomofo
> - ime-cangjie
> - ime-chewing
> - ime-libpinyin-bopomofo
> - ime-libpinyin-chewing
> - ime-rime
> - ime-anthy
> - ime-libkkc
> - ime-libskk
> - ime-hangul
> - ime-unikey
> - ime-emoji
> 
> fcitx.svgz
> 
> - fcitx
> - fcitx-kbd
> - fcitx-vk-active
> - fcitx-vk-inactive
> - fcitx-remind-active
> - fcitx-remind-inactive
> - fcitx-chntran-active
> - fcitx-chntran-inactive
> - fcitx-fullwidth-active
> - fcitx-fullwidth-inactive
> - fcitx-punc-active
> - fcitx-punc-inactive
> - fcitx-pinyin
> - fcitx-shuangpin
> - fcitx-wubi
> - fcitx-pinyin-libpinyin
> - fcitx-shuangpin-libpinyin
> - fcitx-bopomofo
> - fcitx-sunpinyin
> - fcitx-googlepinyin
> - fcitx-emoji
> - ...
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION 
>   src/desktoptheme/breeze/icons/ime.svgz PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129091/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Spectacle.Et8101.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png
> Spectacle.AD8101.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png
> Screenshot_20161006_201118.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/9b51635d-7461-40b4-9c59-27d07407a475__Screenshot_20161006_201118.png
> Spectacle.Zb3480.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/74a7126d-f917-4be0-864c-9f5f5253d448__Spectacle.Zb3480.png
> 
> 
> Thanks,
> 
> Yunhe Guo
> 
>

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/#review100087
---


Ship it!




Ship It!

- Marco Martin


On Sept. 29, 2016, 11:50 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129065/
> ---
> 
> (Updated Sept. 29, 2016, 11:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
> in earlier Qt.
> 
> This shouldn't have any behavioural effect.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 0453c092f7a7144f04fdacc81b031e8c352fa23b 
> 
> Diff: https://git.reviewboard.kde.org/r/129065/diff/
> 
> 
> Testing
> ---
> 
> Ran on my nvidia machine and moused over the taskbar.
> 
> I got thumbnails as expected, but also Nvidia-settings shows "user dedicated 
> memory" remaining constant
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

[Marco Martin]

> On Oct. 17, 2016, 10:38 a.m., Marco Martin wrote:
> > should those be themed in the plasma theme?
> > shouldn't them just go in the regular breeze icon theme?
> 
> Yunhe Guo wrote:
> I have discussed with Breeze icon team. They suggest to move these icons 
> to plasma theme since they are mostly used in system tray/widget.

ok, then fine for me (on the plus side, being all in a single file should 
create a less svg renderers in memory when there is a cache miss)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129091/#review100083
---


On Oct. 6, 2016, 6:03 p.m., Yunhe Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129091/
> ---
> 
> (Updated Oct. 6, 2016, 6:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This patch adds icons for Fcitx system tray icon. Fcitx is the default input 
> method framework in most Chinese GNU/Linux desktop system. These icons will 
> make Fcitx looks better in system tray.
> 
> ime.svgz
> 
> - ime-fullwidth
> - ime-halfwidth
> - ime-punctuation-fullwidth
> - ime-punctuation-halfwidth
> - ime-chinese-simplified
> - ime-chinese-traditional
> - ime-remind-on
> - ime-remind-off
> - ime-handwriting-on
> - ime-handwriting-off
> - ime-erbi
> - ime-googlepinyin
> - ime-libpinyin-pinyin
> - ime-libpinyin-quanpin
> - ime-libpinyin-shuangpin
> - ime-pinyin
> - ime-quanpin
> - ime-shuangpin
> - ime-sunpinyin
> - ime-wubi
> - ime-wubipinyin
> - ime-ziranma
> - ime-bopomofo
> - ime-cangjie
> - ime-chewing
> - ime-libpinyin-bopomofo
> - ime-libpinyin-chewing
> - ime-rime
> - ime-anthy
> - ime-libkkc
> - ime-libskk
> - ime-hangul
> - ime-unikey
> - ime-emoji
> 
> fcitx.svgz
> 
> - fcitx
> - fcitx-kbd
> - fcitx-vk-active
> - fcitx-vk-inactive
> - fcitx-remind-active
> - fcitx-remind-inactive
> - fcitx-chntran-active
> - fcitx-chntran-inactive
> - fcitx-fullwidth-active
> - fcitx-fullwidth-inactive
> - fcitx-punc-active
> - fcitx-punc-inactive
> - fcitx-pinyin
> - fcitx-shuangpin
> - fcitx-wubi
> - fcitx-pinyin-libpinyin
> - fcitx-shuangpin-libpinyin
> - fcitx-bopomofo
> - fcitx-sunpinyin
> - fcitx-googlepinyin
> - fcitx-emoji
> - ...
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION 
>   src/desktoptheme/breeze/icons/ime.svgz PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129091/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Spectacle.Et8101.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png
> Spectacle.AD8101.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png
> Screenshot_20161006_201118.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/9b51635d-7461-40b4-9c59-27d07407a475__Screenshot_20161006_201118.png
> Spectacle.Zb3480.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/74a7126d-f917-4be0-864c-9f5f5253d448__Spectacle.Zb3480.png
> 
> 
> Thanks,
> 
> Yunhe Guo
> 
>

Re: Review Request 129103: Generate metadata.json file at build time

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129103/#review100089
---


Ship it!




Ship It!

- Marco Martin


On Oct. 4, 2016, 11:31 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129103/
> ---
> 
> (Updated Oct. 4, 2016, 11:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> In plasma-framework internally we use a QJsonObject for reading the metadata. 
> Providing the metadata in desktop only makes the system have to parse 
> metadata.desktop and then convert it internally into a QJsonObject. 
> Furthermore, to do so we use a desktop file parser that is not very 
> performant (at least in comparison to KConfig's).
> 
> As part of #129102, we made sure that plasma supports `metadata.json`. This 
> patch leverages it moving the weight of converting desktop to json at compile 
> time.
> 
> It could even make sense to convert to binary json as well, I wonder whether 
> that would improve at all.
> 
> 
> Diffs
> -
> 
>   KF5PackageMacros.cmake 335fc81 
> 
> Diff: https://git.reviewboard.kde.org/r/129103/diff/
> 
> 
> Testing
> ---
> 
> Ran RR 129102 without any metdata.desktop files on my system.
> 
> Nope, hold the ship its, still needs work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Plasma Sprint vs FOSDEM

[Marco Martin]

On Monday 17 October 2016, Kai Uwe Broulik wrote:
> Hi all,
> 
> I decided on 6 February through 12 February for the Plasma sprint. Although
> there was a thread on the ml and nobody objected, there were concerns now
> that it might conflict with FOSDEM which is on 4/5 February. 
> 
> ‎Is this an issue for anyone? 

not planning to fosdem as well

-- 
Marco Martin

Re: System Settings KCM cleanup (KIO)

[Burkhard Lück]

Am Samstag, 15. Oktober 2016, 13:32:35 CEST schrieb kainz.a:
> Hi,
> 
> there are some KCM's the default user didn't need, some of them are also
> broken. It need some time to realize that the KCM's are from KIO.
> 
> connectivity -> Samba Shares (didn't work)
> 
> some kcm's are available but only needed if you install a kde browser. So
> please activate this KCM's not by default. maybe when you install a KDE
> browser the KCM's should be added (or you can change the setting in the
> browser)
> - browser
> - cookies
> - SSL Settings
> - web shortcuts
> - net preferences
> - useragent
> 
> so from the KIO kcm's I think only the proxy kcm should be installed by
> default (if it work, never use it)
> 
> I think a cleanup by default is needed and have KCM's you can't change
> anything cause the user use firefox would help nobody.
> 
I have started to clean up the kcontrol docbook locations in cases where the 
kcm code is in a different repository than the corresponding docbook, which I 
consider as wrong.

See e.g:
https://git.reviewboard.kde.org/r/128912/  (cache, proxy, useragent, cookies, 
netpref, ebrowsing, smb docbooks in plasma-desktop)

https://git.reviewboard.kde.org/r/128914/ (filetypes kcm docbook in plasma-
desktop)

https://git.reviewboard.kde.org/r/128907/ (Konqueror kcm docbooks in plasma-
desktop)

-- 
Burkhard Lück

Re: Review Request 129150: Use less deprecated API

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129150/
---

(Updated Oct. 17, 2016, 11:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 9e54853ac89f3eb0e0f71d4a0491ba83db0c7709 by Aleix Pol on 
behalf of Aleix Pol Gonzalez to branch master.


Repository: plasma-framework


Description
---

Make it easier to look at the compilation output.


Diffs
-

  src/plasma/containment.cpp 1c49f05 
  src/plasma/scripting/appletscript.cpp a2342a3 
  src/plasmaquick/appletquickitem.cpp 2f100b8 
  src/plasmaquick/configview.cpp 73e4974 
  src/plasmaquick/containmentview.cpp 43f0fdd 
  src/plasmaquick/view.cpp 6ab0012 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 160cdd7 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 173573e 

Diff: https://git.reviewboard.kde.org/r/129150/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

Re: Plasma Sprint vs FOSDEM

[Aleix Pol]

On Mon, Oct 17, 2016 at 12:33 PM, Kai Uwe Broulik  
wrote:
> Hi all,
>
> I decided on 6 February through 12 February for the Plasma sprint. Although 
> there was a thread on the ml and nobody objected, there were concerns now 
> that it might conflict with FOSDEM which is on 4/5 February.
>
> ‎Is this an issue for anyone?

I was thinking about going to both FOSDEM and the sprint.
Note FOSDEM is a good opportunity to talk to people who are on the
business but who aren't the same people we usually meet at Akademy.

Rescheduling isn't necessary for me.

Aleix

[Differential] [Request, 20 lines] D3083: Mute volume when decreasing volume to zero

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When decreasing the volume to minimal value (zero) with global
  shortcuts, the OSD shows the volume as muted.
  This change actually mutes the volume in this case.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D3083

AFFECTED FILES
  applet/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 45 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Oct 2016 12:54:34 +
Build duration: 8 min 33 sec

CHANGE SET
Revision d888c454192ee5c5683c42f40be1193692376ef5 by hein: (Test the 
QMetaObject::Connection instead of using Qt::UniqueConnection.)
  change: edit applets/pager/plugin/pagermodel.cpp

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 46 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Oct 2016 13:05:39 +
Build duration: 6 min 10 sec

CHANGE SET
Revision 7b2f1624126f1a014f7aa30c31d0964efe028935 by hein: (Disconnect instead.)
  change: edit applets/pager/plugin/pagermodel.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1552/3774 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 46 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Oct 2016 13:05:39 +
Build duration: 6 min 10 sec

CHANGE SET
Revision 7b2f1624126f1a014f7aa30c31d0964efe028935 by hein: (Disconnect instead.)
  change: edit applets/pager/plugin/pagermodel.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1552/3774 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Differential] [Updated] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

[bshah (Bhushan Shah)]

bshah added a dependent revision: D3084: [shell] Support autohide panel on 
wayland.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  panel-auto-hide

REVISION DETAIL
  https://phabricator.kde.org/D3007

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, #plasma_on_wayland
Cc: sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Request, 7 lines] D3084: [shell] Support autohide panel on wayland

[bshah (Bhushan Shah)]

bshah created this revision.
bshah added reviewers: Plasma, graesslin.
bshah added a dependency: D3007: Add auto-hiding panel support to 
PlasmaShellSurface interface.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This makes use of requests to hide and show autohide panels from
  kwayland
  
  Depends on https://phabricator.kde.org/D3007

TEST PLAN
  autohide panel now works, with https://phabricator.kde.org/D3083 in kwin, but 
windows can
  cover panel still needs work

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  panel-autohide

REVISION DETAIL
  https://phabricator.kde.org/D3084

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 7 lines] D3084: [shell] Support autohide panel on wayland

[bshah (Bhushan Shah)]

bshah updated this revision to Diff 7459.
bshah added a comment.


  update commit message

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3084?vs=7458&id=7459

BRANCH
  panel-autohide

REVISION DETAIL
  https://phabricator.kde.org/D3084

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 171 lines] D3085: RFC: Use DBusMenu if available

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAINTEGRATION Integration 
for Qt applications in Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is part one in a series to restore global menu support in Plasma.
  
  Since we inherit from QPlatformTheme we do not get the global menu support 
for free like Qt's own platform themes inheriting from QGenericUnixTheme would, 
hence the use of private headers.

TEST PLAN
  - platform integration cmake thing is from kwin
  - checkDBusGlobalMenuAvailable() et al are from Qt's upstream
  - requires Qt 5.7
  
  - in KXMLGui applications you still get a traditional menu bar in addition to 
the global menu, it seems it explicitly sets visible true on the menu bar - in 
VLC it hides its own menu bar.
  
  Upcoming patches will:
  
  - restore and cleanup kappmenu (the kded module that acts as a registrar for 
Qt apps, so they will actually start exporting their menus)

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  cmake/modules/FindQt5PlatformSupport.cmake
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kdeplatformtheme.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 7 lines] D3084: [shell] Support autohide panel on wayland

[bshah (Bhushan Shah)]

bshah updated this revision to Diff 7460.
bshah updated the test plan for this revision.
bshah added a comment.


  edit message for real

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3084?vs=7459&id=7460

BRANCH
  panel-autohide

REVISION DETAIL
  https://phabricator.kde.org/D3084

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3080: Panel auto hide support for Wayland panels

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.


  Looks good

REPOSITORY
  rKWIN KWin

BRANCH
  panel-autohide-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3080

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, #plasma_on_wayland, #kwin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Roman Gilg]

> On Okt. 17, 2016, 10:26 vorm., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151
> > 
> >
> > Because AppletInterface::activated is a signal, applets could connect 
> > to to do extra actions on external activation; we're not emitting that with 
> > this signal.
> > 
> > and this isn't just hypothetical as kicker does.
> > 
> > kicker/package/contents/ui/CompactRepresentation.qml:   
> > plasmoid.activated.connect(function()
> > 
> > (ironically to do toggling on the dash window)
> > 
> > By introducing a new signal, this breaks existing applets.
> > 
> > We could maybe simply add 
> > if (activate) emit activated();
> > 
> > and it'd work.
> > 
> > Question:
> > the current global shortcuts seem to toggle, and they only connect to 
> > activate(), how do they work?
> 
> David Edmundson wrote:
> sorry, you literally have a sentence for that in your description. Ignore 
> my last comment.
> 
> Kai Uwe Broulik wrote:
> > the current global shortcuts seem to toggle, and they only connect to 
> activate(), how do they work?
> 
> From what I can tell, technically the Meta behavior is actually the 
> correct one. As far as I understood, KGlobalAccel registers a "soft grab" on 
> the global shortcuts. When they are pressed, X grabs them, and KGlobalAccel 
> ungrabs them again; this causes the window to lose focus and it closes.
> 
> You can observe this when you e.g. change volume while any Plasma popup 
> is open, behavior is the same. I don't know how it behaves on Wayland, 
> though, and what we should do with the Meta key to improve the situation.
> 
> Martin Gräßlin wrote:
> > You can observe this when you e.g. change volume while any Plasma popup 
> is open, behavior is the same. I don't know how it behaves on Wayland, 
> though, and what we should do with the Meta key to improve the situation.
> 
> On Wayland global shortcut doesn't result in losing focus. I just tried 
> alt+f1 -> kickoff opens, Alt+F1 again -> kickoff doesn't close

We could do the emit activated() approach or replace the activated() signal in 
Applet::setGlobalShortcut(const QKeySequence &shortcut) with toggled(), which 
would make more sense regarding Wayland and Martin's comment. The question is: 
Are there possibly any other applets than the launchers, which rely on the 
activationAction to only trigger their activation, but not their deactivation?


- Roman


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100067
---


On Okt. 17, 2016, 9:02 vorm., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Okt. 17, 2016, 9:02 vorm.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time set

[Differential] [Request, 2,180 lines] D3086: RFC: Clean up KAppMenu

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is part two in a series to restore global menu support in Plasma.
  
  Massively cleanup KAppMenu by removing outdated and unused code. The global 
menu has been removed as it will eventually be provided by a plasmoid (famous 
last words). Also many of the workarounds (like the unity about to show hack) 
have been removed and will only get re-introduced if they are in fact still 
neccessary.

TEST PLAN
  Added the following to ~/.config/kdeglobals
  
[Appmenu Style]
Style=ButtonVertical
  
  Applications like Kwrite, Dolphin, as well as VLC start exporting their manus 
on DBus now. The "showMenu" method on the org.kde.kappmenu dbus interface can 
be used to show the application menu.
  
  The about to show hack seemed to have been neccessary for the global menu 
which is updated as soon as the active menu changes; right now calling showMenu 
does work with Firefox.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3086

AFFECTED FILES
  appmenu/CMakeLists.txt
  appmenu/appmenu.cpp
  appmenu/appmenu.h
  appmenu/glowbar.cpp
  appmenu/glowbar.h
  appmenu/kdbusimporter.h
  appmenu/menubar.cpp
  appmenu/menubar.h
  appmenu/menubutton.cpp
  appmenu/menubutton.h
  appmenu/menuimporter.cpp
  appmenu/menuimporter.h
  appmenu/menuwidget.cpp
  appmenu/menuwidget.h
  appmenu/shadows.cpp
  appmenu/shadows.h
  appmenu/topmenubar.cpp
  appmenu/topmenubar.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

> On Oct. 17, 2016, 8:37 a.m., David Edmundson wrote:
> > src/declarativeimports/core/windowthumbnail.cpp, line 231
> > 
> >
> > FWIW: https://git.reviewboard.kde.org/r/129065/

I've changed the code, given a comment in your own review, to choose the right 
RenderStage based on the version of Qt available. Please check the updated 
patch.


- Alberto


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100069
---


On Oct. 17, 2016, 7:35 a.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 7:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/
---

(Updated Oct. 17, 2016, 2:53 p.m.)


Review request for Plasma.


Changes
---

Updated the selection of right RenderStage depending on version of Qt available.


Repository: plasma-framework


Description
---

Being a newbie, following build instruction from the wiki, I could not build 
plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).

Two of the changes are coding issues.

The change in CMakeLists.txt comes from a wrong required version, also stated 
here: https://git.reviewboard.kde.org/r/128763/. 

For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.


Diffs (updated)
-

  src/declarativeimports/core/windowthumbnail.cpp 0453c09 

Diff: https://git.reviewboard.kde.org/r/129203/diff/


Testing
---

Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial


Thanks,

Alberto Curro

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

> On Oct. 17, 2016, 10:20 a.m., David Edmundson wrote:
> > Do you have commit access?

I don't think so, it's my first patch and I'm newbie to the KDE development 
team :)


- Alberto


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100077
---


On Oct. 17, 2016, 2:53 p.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 2:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

[Differential] [Updated] D3084: [shell] Support autohide panel on wayland

[Martin Gräßlin]

graesslin added a comment.


  Wayland side looks good to me.

INLINE COMMENTS

> panelview.cpp:651
>  xcb_change_property(c, XCB_PROP_MODE_REPLACE, winId(), atom->atom, 
> XCB_ATOM_CARDINAL, 32, 1, &value);
>  KWindowEffects::slideWindow(winId(), slideLocation, -1);
>  }

do we also need to request the slide for the panel on WAyland?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3084

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[David Edmundson]

> On Oct. 17, 2016, 8:26 a.m., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 151
> > 
> >
> > Because AppletInterface::activated is a signal, applets could connect 
> > to to do extra actions on external activation; we're not emitting that with 
> > this signal.
> > 
> > and this isn't just hypothetical as kicker does.
> > 
> > kicker/package/contents/ui/CompactRepresentation.qml:   
> > plasmoid.activated.connect(function()
> > 
> > (ironically to do toggling on the dash window)
> > 
> > By introducing a new signal, this breaks existing applets.
> > 
> > We could maybe simply add 
> > if (activate) emit activated();
> > 
> > and it'd work.
> > 
> > Question:
> > the current global shortcuts seem to toggle, and they only connect to 
> > activate(), how do they work?
> 
> David Edmundson wrote:
> sorry, you literally have a sentence for that in your description. Ignore 
> my last comment.
> 
> Kai Uwe Broulik wrote:
> > the current global shortcuts seem to toggle, and they only connect to 
> activate(), how do they work?
> 
> From what I can tell, technically the Meta behavior is actually the 
> correct one. As far as I understood, KGlobalAccel registers a "soft grab" on 
> the global shortcuts. When they are pressed, X grabs them, and KGlobalAccel 
> ungrabs them again; this causes the window to lose focus and it closes.
> 
> You can observe this when you e.g. change volume while any Plasma popup 
> is open, behavior is the same. I don't know how it behaves on Wayland, 
> though, and what we should do with the Meta key to improve the situation.
> 
> Martin Gräßlin wrote:
> > You can observe this when you e.g. change volume while any Plasma popup 
> is open, behavior is the same. I don't know how it behaves on Wayland, 
> though, and what we should do with the Meta key to improve the situation.
> 
> On Wayland global shortcut doesn't result in losing focus. I just tried 
> alt+f1 -> kickoff opens, Alt+F1 again -> kickoff doesn't close
> 
> Roman Gilg wrote:
> We could do the emit activated() approach or replace the activated() 
> signal in Applet::setGlobalShortcut(const QKeySequence &shortcut) with 
> toggled(), which would make more sense regarding Wayland and Martin's 
> comment. The question is: Are there possibly any other applets than the 
> launchers, which rely on the activationAction to only trigger their 
> activation, but not their deactivation?

>Are there possibly any other applets than the launchers, which rely on the 
>activationAction to only trigger their activation, but not their deactivation?

The icon plasmoid in plasma-workspace opens the relevant application on 
activation. It's not a toggleable thing.
Also, potentially there are more plasmoids on kde-look, or even just unique 
plasmoids on people's personal systems that we don't know what they do.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100067
---


On Oct. 17, 2016, 7:02 a.m., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Oct. 17, 2016, 7:02 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-fram

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

[Martin Gräßlin]

graesslin added a comment.


  Overall significant less code than I expected - nice :-)

INLINE COMMENTS

> CMakeLists.txt:46
>  
> +find_package(Qt5PlatformSupport REQUIRED)
> +

version 5.7?

> FindQt5PlatformSupport.cmake:1
> +#.rst:
> +# FindQt5PlatformSupport

given that it has my copyright I assume you copied from kwin - that would be a 
reason to move it to ecm. We have two users.

> kdeplatformtheme.cpp:59
> +{
> +static bool dbusGlobalMenuAvailable = checkDBusGlobalMenuAvailable();
> +return dbusGlobalMenuAvailable;

can we really make that static? What about runtime changes?

> kdeplatformtheme.cpp:310
> +{
> +if (isDBusGlobalMenuAvailable()) {
> +return new QDBusMenuBar();

what happens if it becomes unavailable at runtime?

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D3084: [shell] Support autohide panel on wayland

[bshah (Bhushan Shah)]

bshah marked an inline comment as done.
bshah added inline comments.

INLINE COMMENTS

> graesslin wrote in panelview.cpp:651
> do we also need to request the slide for the panel on WAyland?

I don't think so.. because from my testing panel sliding seems to work normally.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3084

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

5.9 Kickoff Meeting Notes

[Jonathan Riddell]

Here's some notes from the 5.9 Kickoff meeting
https://notes.kde.org/p/PlasmaKickoff5.9

I'll post about the breakout topics in following e-mails

Sebas will write a blog of this up today

Plasma 5.9 Kickoff Meeting

present: Riddell, sebas, d_ed, jens, mgraesslin, bshah, llucas,
notmart, alex-l, romangg, sho, others

5.8 Evaluation

- Went well, bugfixing discipline is good
- Very well received by both users and distros
- Attracts new contributors
- cycle timing works well

Plasma's General Direction
- professional tool, reliable workhorse and elegant at getting the job done
- new LTS release in summer 2018 (proposed by sebas)
- stabilize and improve Wayland session, but don't make it default
before it's 101% good, perhaps summer 2017?
- more web services support (?), e.g. file storage cloud services
(own/nextcloud, gdrive, etc.); Freedom services first; good UX for it
- I want plasma to be a thing that doesn't get in your way of doing things
- I want plasma both a solid platform/framework and a no-nonsense
desktop system by default that users would want to chose over others
for being qualitatively better/faster/getting less in the way

  - Make Plasma a unified whole, a tool to be used, used easily and
pleasantly by people who actually need it. (Scientific, Students and
Professional Settings)

  - make something completely new (not just convergent design like
Discover but convergant workflows and innovations that make sense)


Biggest Pain Points
* QLocale regressions vs Klocale ( https://bugs.kde.org/show_bug.cgi?id=340982 )
* Way too little KDE developers test their apps on Wayland
* System Settings: newbies don't like it (too unwieldy, messy, little
consistency across modules)
* I think our biggest is still quality - Plasma regularly fails the
"10 minute test", I see people trying it and something doesn't work
right in the first 10 minutes
* good text input support and localization for Asian languages and scripts
* regressions between feature releases
* hybrid systems/convertables badly supported, no touch screen
gestures, no auto rotate, etc.
* multiscreen behavior: How should the system exactly behave?
* getting new developers
* still stability issues (a lot unfortunately still related to Qt/Qml
* startup performance/memory usage: we improved massively (we are
already a bit less than an empty gnome session, ohyeah, but we can
still improve
* things that are the same; look and behave differently and things
that should stick out, are hidden and behave the same. Which makes the
user distrust the DE and gets us questions about what should be fairly
easy actions
* we are lackluster in applications that tie into the DE as a whole -
there is also a big empty spot where convergence should be where we
can

Individual Plans
sebas:
* making kscreen wayland-complete,
* kscreen UI revamp ("experimental" for 5.9 perhaps installing
alongside the current one, but hidden (for testing))
* windowmetadata advancements
mgraesslin:
* multi-screen rendering on Wayland (some effects already fixed,
blur still broken)
* improve input stack (relative pointer, pointer confinement,
touchpad gestures, wacom tablet, clipboard manager aka Klipper)
* X-free kwin project (at least startup without hard X dependency
would be nice)
alex-l:
* I plan to work on Breeze and Oxygen themes+icons. Theme for Firefox is wip
Sho:
* grow the KDE community in Asia, and the biggest impediment for
that is good text input support and localization - stuff like the
keyboard KCM I mentioned above
* Work toward Wayland completeness, to free up dev resources for
things like that again
* as mentioned, really interested in somehow working with sysadmin
to get infra for performance measurements (We'd need a dedicated
benchmark runner system)
* We want to grow the widget ecosystem on the store, so I'm
working on putting Netrunner's Simple Menu there - this needs more
upstreaming of Kicker backend mods, and probably moving the backend to
p-w 5.8 I mean
* Virtual desktop API in kwayland, and making the TM+Pager applets use it
* A (lightweight) widget gallery in Dashboard, for the same reason
as why apps in Dashboard - sometimes it's nicer fullscreen
* A rewrite of the Yakuake UI, with a new theming system
bshah:
* plasma mobile stuff.. I want to stabilize it and make it perfect.
* I want to work on some kind of integration testing / regression
testing for plasma and plasma mobile stuff combined
d_ed:

* I want to get back into SDDM

* I'd quite like to do the wayland high DPI

* plus the backlog of other SDDM tasks

* rootless Xorg,

* multi seat,

* accountsservice

* and of course ... bugs

* startup time improvements

notmart:
  * ~6 months: integration with QQuickControls2, dependencies in look
and feel packages, probably some tweaks in breeze qwidget style
  * 12 months: beside above pojnts, more work in performance
department, try to load by default even less
  * 2 yea

Minutes Monday Plasma Meeting

[Sebastian Kügler]

Plasma Meeting 17th October, 2016, 12:00, via IRC

present: mgraesslin, notmart, romangg, bshah, kbroulik, d_ed, Riddell, Sho, 
sebas

mgraesslin:
* send pointer events to all wl_pointer (D3016)
  Diff 3016 "[server] Send pointer events to all wl_pointer resources of a 
client" [Closed] https://phabricator.kde.org/D3016
* Add api to get a KWayland::Client::ShellSurface from QWindow (D3018)
  Diff 3018 "[client] Add methods to get ShellSurface from a QWindow" [Closed] 
https://phabricator.kde.org/D3018
* Implemented the generic window property in 
KWayland::Server::QtSurfaceExtension (D3045)
  Diff 3045 "[server] Implement the generic window property in 
QtSurfaceExtension" [Closed] https://phabricator.kde.org/D3045
* Protocol extension to pass icons from KWin to Plasma (D3049, D3050)
  Diff 3049 "Support passing generic QIcon through PlasmaWindow interface" 
[Closed] https://phabricator.kde.org/D3049
  Diff 3050 "Use new PlasmaWindowInterface::setIcon" [Closed] https://
phabricator.kde.org/D3050
* Set color scheme X property in plasma-integration to support all windows and 
don't restrict to Kstyle-based widget styles (D3044)
  Diff 3044 "Set color scheme X property in the X11Integration" [Closed] 
https://phabricator.kde.org/D3044
* Support color schemes hint on Wayland through a generic window property 
(D3046, D3047)
  Diff 3046 "Pass color scheme hint to Wayland compositor using window 
property" [Closed] https://phabricator.kde.org/D3046
* Fix shortcut triggering with shift+letter on Wayland (D3015)
* window icon is set to generic wayland icon if we cannot find the desktop 
file (D3023)
  Diff 3047 "Support custom color scheme for Wayland windows" [Closed] 
https://phabricator.kde.org/D3047
* Fix glBlitFramebuffer for per-output rendering (D3056)
* Pass the current output geometry to ScreenPaintData (D3058)
  Diff 3015 "Fix shortcut triggering with shift+letter" [Closed] https://
phabricator.kde.org/D3015
* Make screenshot effect work with multiple output rendering (D3059)
  Diff 3023 "Set icon to wayland if desktop file is not found" [Closed] 
https://phabricator.kde.org/D3023
  Diff 3056 "Fix glBlitFramebuffer for per-output rendering" [Closed] https://
phabricator.kde.org/D3056
  Diff 3058 "Pass the current output geometry to ScreenPaintData" [Closed] 
https://phabricator.kde.org/D3058
  Diff 3059 "[effects] Make screenshot effect work with multiple output 
rendering" [Closed] https://phabricator.kde.org/D3059
things not yet merged:
* move windows in widget style (D3019)
  Diff 3019 "[kstyle] Implement window moving on Wayland" [Needs Review] 
https://phabricator.kde.org/D3019
* auto-hiding panels on Wayland (D3007, D3080)
  Diff 3007 "Add auto-hiding panel support to PlasmaShellSurface interface" 
[Accepted] https://phabricator.kde.org/D3007
  Diff 3080 "Panel auto hide support for Wayland panels" [Needs Review] 
https://phabricator.kde.org/D3080
* make Wayland panels take focus (D3035, D3036, D3037)
  Diff 3035 "Add request to have focus in a PlasmaShellSurface of Role Panel" 
[Accepted] https://phabricator.kde.org/D3035
  Diff 3036 "Support forceActiveWindow for Panels" [Accepted] https://
phabricator.kde.org/D3036
* make KRunner a panel (D3038)
  Diff 3037 "Support docks which take input" [Accepted] https://
phabricator.kde.org/D3037
  Diff 3038 "[krunner] Make KRunner on Wayland a Panel" [Accepted] https://
phabricator.kde.org/D3038

notmart:
* another plasmashell multiscreen bugfix: fix when screen ids are bigger then 
screen count
* fix "default" color scheme kcm setting everything black
* Wayland: Doalog implements shadows and moves itself with plasmashell 
protocol, ugly hack in plasmashell to inject kwayland usage gone (as kwayland 
is a framework now, so libplasma can optionally depend on it)
* triaging
* fixed svg wallpaper thumbnails
* support for panel size/offset/alignment in new javascript api
* kwayland support for Dialog (position and shadows) move from hack into 
plasma-workspace to plasma-framework
** Kirigami2: continue with the Desktop theme QQC2
** prototype of scrollbars "looking desktop but not too much, working with 
VDG" https://www.youtube.com/watch?v=jTa2NBUxYVY
** components now themed:
** Button.qml
** CheckBox.qml
** CheckIndicator.qml
** Label.qml
** ProgressBar.qml
** RadioButton.qml
** RadioIndicator.qml
** ScrollBar.qml
** Slider.qml
** SwitchIndicator.qml
** Switch.qml
** TextField.qml

romangg:
- talks with vdg about a frame redesign of the taskbar tooltip (frames only)
- lockscreen/switchsession subpage improvements. already merged or already 
accepted and about to merge
- many bug reports (in particular wayland stuff): https://goo.gl/HfeJhz
- fix for meta not closing launchers: https://git.reviewboard.kde.org/r/
129204/
- working on solving the issue raised by d_ed https://phabricator.kde.org/
D3079

bshah:
- work on boot.img to eliminate lxc stuff
- this week I would like to finish this boot.img stuff, meaning plain rootfs, 
no container
- worked on panel au

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  It's not much code on our side because Qt has the code nowadays. :)

INLINE COMMENTS

> graesslin wrote in FindQt5PlatformSupport.cmake:1
> given that it has my copyright I assume you copied from kwin - that would be 
> a reason to move it to ecm. We have two users.

+1 to that.

I had one issue regarding the include path, though, but I can't reproduce it 
anymore and I forgot what I actually did but the path I need is

  /usr/include/x86_64-linux-gnu/qt5/QtPlatformSupport/5.7.0/QtPlatformSupport/

but I sometimes got

  /usr/include/x86_64-linux-gnu/qt5/QtPlatformSupport/5.7.0/

but I'm sure we can figur that out.

> graesslin wrote in kdeplatformtheme.cpp:59
> can we really make that static? What about runtime changes?

That's what Qt does and I don't think Qt is equipped to re-create a platform 
menu at runtime; at least that's what I was told when I raised the very same 
concern in the upstream Qt codereview that added this.

We could perhaps do it for newly created menus but when the service becomes 
unavailable at runtime there's no way for us to re-create existing menus.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 129203: Fixes for building plasma-framework

[Marco Martin]

> On Oct. 17, 2016, 10:20 a.m., David Edmundson wrote:
> > Do you have commit access?
> 
> Alberto Curro wrote:
> I don't think so, it's my first patch and I'm newbie to the KDE 
> development team :)

you a re welcome to get one
https://community.kde.org/Infrastructure/Get_a_Developer_Account


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100077
---


On Oct. 17, 2016, 2:53 p.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 2:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Review Request 129210: port everything to QCDebug/QCWarning

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

mostly janitorial patch: port every terminal output to appropriate 
QCdebug/QCwarning, each different binary has its own logging category now, so 
it's possible to enable/disable them selectively.
this should also make plasmashell a bit more quiet on terminal by default


Diffs
-

  autotests/CMakeLists.txt d6ed24d 
  autotests/sortfiltermodeltest.cpp da0e393 
  src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
  src/declarativeimports/calendar/calendar.cpp 790833b 
  src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
  src/declarativeimports/core/CMakeLists.txt 689a4b6 
  src/declarativeimports/core/datamodel.cpp 06b64e4 
  src/declarativeimports/core/datasource.cpp f60e2cc 
  src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
  src/declarativeimports/core/iconitem.cpp 8f29ee2 
  src/declarativeimports/core/windowthumbnail.cpp 0453c09 
  src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
  src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
  src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
  src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
  src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
  src/declarativeimports/platformcomponents/application.cpp 1326a7b 
  src/plasmapkg/CMakeLists.txt 7d3df5d 
  src/plasmapkg/plasmapkg.cpp 3724ae8 
  src/plasmaquick/CMakeLists.txt 8aaa77a 
  src/plasmaquick/configmodel.cpp 03beac7 
  src/plasmaquick/configview.cpp e8627c9 
  src/plasmaquick/containmentview.cpp 309a2cb 
  src/plasmaquick/dialog.cpp 9afdf60 
  src/plasmaquick/dialogshadows.cpp 10b5ed9 
  src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
  src/plasmaquick/view.cpp ca6ae6f 
  src/scriptengines/qml/CMakeLists.txt fd953d6 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 

Diff: https://git.reviewboard.kde.org/r/129210/diff/


Testing
---

builds, still works


Thanks,

Marco Martin

Re: Review Request 129104: Remove unused member var

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129104/
---

(Updated Oct. 17, 2016, 3:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 07c978f6198feb2a4296f27951b74d1d79603816 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Remove unused member var


Diffs
-

  src/plasma/pluginloader.cpp db2b2c91d7b313053811583cf41bcdf0e1e141ce 

Diff: https://git.reviewboard.kde.org/r/129104/diff/


Testing
---

compiles.


Thanks,

David Edmundson

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/
---

(Updated Oct. 17, 2016, 3:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit f82d76eb2b915d5097f41a22a9f218e0bb23bb03 by David 
Edmundson on behalf of Alberto Curro to branch master.


Repository: plasma-framework


Description
---

QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
in earlier Qt.

This shouldn't have any behavioural effect.


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 
0453c092f7a7144f04fdacc81b031e8c352fa23b 

Diff: https://git.reviewboard.kde.org/r/129065/diff/


Testing
---

Ran on my nvidia machine and moused over the taskbar.

I got thumbnails as expected, but also Nvidia-settings shows "user dedicated 
memory" remaining constant


Thanks,

David Edmundson

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/
---

(Updated Oct. 17, 2016, 3:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit f82d76eb2b915d5097f41a22a9f218e0bb23bb03 by David 
Edmundson on behalf of Alberto Curro to branch master.


Repository: plasma-framework


Description
---

Being a newbie, following build instruction from the wiki, I could not build 
plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).

Two of the changes are coding issues.

The change in CMakeLists.txt comes from a wrong required version, also stated 
here: https://git.reviewboard.kde.org/r/128763/. 

For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 0453c09 

Diff: https://git.reviewboard.kde.org/r/129203/diff/


Testing
---

Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial


Thanks,

Alberto Curro

[Differential] [Request, 89 lines] D3088: WIP: Restore application menu button

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rKDECORATION Window Decoration 
Library.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  rKDECORATION Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D3088

AFFECTED FILES
  autotests/mockclient.cpp
  autotests/mockclient.h
  src/decoratedclient.cpp
  src/decoratedclient.h
  src/decoration.cpp
  src/decoration.h
  src/decorationbutton.cpp
  src/private/decoratedclientprivate.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 286 lines] D3089: WIP: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rKWIN KWin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

TEST PLAN
  Together with the other three patches gives you an application menu button in 
the title bar.
  
  What doesn't work is pressing Alt in an app and have the global menu open. 
There basically the app tells kwin to show the menu which then tells the 
decoration which gets the offset from the button and passes that back to kwin 
which then opens the menu ……… I suppose?
  
  F367907: Screenshot_20161017_124159.png 

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  config-kwin.h.cmake
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

2017 Plasma Release Schedule

[Jonathan Riddell]

I've updated our release schedule through to the end of 2017 from
discussion at the kickoff meeting today

https://community.kde.org/Schedules/Plasma_5
https://calendar.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com&ctz=Europe/London

The pattern is the one we have used for the last few releases, repo
freeze after the previous .5 release, same day beta on Thursday a
couple weeks after that, tagging for final a couple of weeks after
that with release on the Tuesday and bugfix releases on Tuesdays
following that in fibbonachi sequence.

It continues the 5.8 LTS series until middle of 2018 as planned.

It schedules 5.9 at the end of January, 5.10 end of May and 5.11 end
of September.  This puts 5.9.0 on 31 January 2017 which is a few days
before FOSDEM and the week before the proposed sprint of 6-12
February.

If we choose to adopt this calendar for 2017 we can still make
adjustments as necessary if it clashes with e.g. Akademy dates.

I would suggest keeping to a 4 month release schedule as it fits
nicely with the year calendar and making releases each January, May
and September.

Please take a look and let me know what you think

Jonathan

Re: Review Request 129210: port everything to QCDebug/QCWarning

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/#review100103
---


Ship it!




Though in future, I wouldn't bother putting a logging category on an autotest.

- David Edmundson


On Oct. 17, 2016, 3:28 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129210/
> ---
> 
> (Updated Oct. 17, 2016, 3:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> mostly janitorial patch: port every terminal output to appropriate 
> QCdebug/QCwarning, each different binary has its own logging category now, so 
> it's possible to enable/disable them selectively.
> this should also make plasmashell a bit more quiet on terminal by default
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt d6ed24d 
>   autotests/sortfiltermodeltest.cpp da0e393 
>   src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
>   src/declarativeimports/calendar/calendar.cpp 790833b 
>   src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
>   src/declarativeimports/core/CMakeLists.txt 689a4b6 
>   src/declarativeimports/core/datamodel.cpp 06b64e4 
>   src/declarativeimports/core/datasource.cpp f60e2cc 
>   src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
>   src/declarativeimports/core/iconitem.cpp 8f29ee2 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
>   src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
>   src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
>   src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
>   src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
>   src/declarativeimports/platformcomponents/application.cpp 1326a7b 
>   src/plasmapkg/CMakeLists.txt 7d3df5d 
>   src/plasmapkg/plasmapkg.cpp 3724ae8 
>   src/plasmaquick/CMakeLists.txt 8aaa77a 
>   src/plasmaquick/configmodel.cpp 03beac7 
>   src/plasmaquick/configview.cpp e8627c9 
>   src/plasmaquick/containmentview.cpp 309a2cb 
>   src/plasmaquick/dialog.cpp 9afdf60 
>   src/plasmaquick/dialogshadows.cpp 10b5ed9 
>   src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
>   src/plasmaquick/view.cpp ca6ae6f 
>   src/scriptengines/qml/CMakeLists.txt fd953d6 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 
> 
> Diff: https://git.reviewboard.kde.org/r/129210/diff/
> 
> 
> Testing
> ---
> 
> builds, still works
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Re: Review Request 129210: port everything to QCDebug/QCWarning

[Marco Martin]

> On Oct. 17, 2016, 4:07 p.m., David Edmundson wrote:
> > Though in future, I wouldn't bother putting a logging category on an 
> > autotest.

that was done because the aytotest statically links to a model from imports, so 
it needs it in order to still link correctly


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/#review100103
---


On Oct. 17, 2016, 3:28 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129210/
> ---
> 
> (Updated Oct. 17, 2016, 3:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> mostly janitorial patch: port every terminal output to appropriate 
> QCdebug/QCwarning, each different binary has its own logging category now, so 
> it's possible to enable/disable them selectively.
> this should also make plasmashell a bit more quiet on terminal by default
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt d6ed24d 
>   autotests/sortfiltermodeltest.cpp da0e393 
>   src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
>   src/declarativeimports/calendar/calendar.cpp 790833b 
>   src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
>   src/declarativeimports/core/CMakeLists.txt 689a4b6 
>   src/declarativeimports/core/datamodel.cpp 06b64e4 
>   src/declarativeimports/core/datasource.cpp f60e2cc 
>   src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
>   src/declarativeimports/core/iconitem.cpp 8f29ee2 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
>   src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
>   src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
>   src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
>   src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
>   src/declarativeimports/platformcomponents/application.cpp 1326a7b 
>   src/plasmapkg/CMakeLists.txt 7d3df5d 
>   src/plasmapkg/plasmapkg.cpp 3724ae8 
>   src/plasmaquick/CMakeLists.txt 8aaa77a 
>   src/plasmaquick/configmodel.cpp 03beac7 
>   src/plasmaquick/configview.cpp e8627c9 
>   src/plasmaquick/containmentview.cpp 309a2cb 
>   src/plasmaquick/dialog.cpp 9afdf60 
>   src/plasmaquick/dialogshadows.cpp 10b5ed9 
>   src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
>   src/plasmaquick/view.cpp ca6ae6f 
>   src/scriptengines/qml/CMakeLists.txt fd953d6 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 
> 
> Diff: https://git.reviewboard.kde.org/r/129210/diff/
> 
> 
> Testing
> ---
> 
> builds, still works
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Re: Review Request 129210: port everything to QCDebug/QCWarning

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/
---

(Updated Oct. 17, 2016, 6:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit acd7ab7815a2a1f9a65f1dbf2cb53123c86da58b by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

mostly janitorial patch: port every terminal output to appropriate 
QCdebug/QCwarning, each different binary has its own logging category now, so 
it's possible to enable/disable them selectively.
this should also make plasmashell a bit more quiet on terminal by default


Diffs
-

  autotests/CMakeLists.txt d6ed24d 
  autotests/sortfiltermodeltest.cpp da0e393 
  src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
  src/declarativeimports/calendar/calendar.cpp 790833b 
  src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
  src/declarativeimports/core/CMakeLists.txt 689a4b6 
  src/declarativeimports/core/datamodel.cpp 06b64e4 
  src/declarativeimports/core/datasource.cpp f60e2cc 
  src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
  src/declarativeimports/core/iconitem.cpp 8f29ee2 
  src/declarativeimports/core/windowthumbnail.cpp 0453c09 
  src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
  src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
  src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
  src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
  src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
  src/declarativeimports/platformcomponents/application.cpp 1326a7b 
  src/plasmapkg/CMakeLists.txt 7d3df5d 
  src/plasmapkg/plasmapkg.cpp 3724ae8 
  src/plasmaquick/CMakeLists.txt 8aaa77a 
  src/plasmaquick/configmodel.cpp 03beac7 
  src/plasmaquick/configview.cpp e8627c9 
  src/plasmaquick/containmentview.cpp 309a2cb 
  src/plasmaquick/dialog.cpp 9afdf60 
  src/plasmaquick/dialogshadows.cpp 10b5ed9 
  src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
  src/plasmaquick/view.cpp ca6ae6f 
  src/scriptengines/qml/CMakeLists.txt fd953d6 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 

Diff: https://git.reviewboard.kde.org/r/129210/diff/


Testing
---

builds, still works


Thanks,

Marco Martin

Breakout: System Settings Improvements

[Jonathan Riddell]

We had a discussion on System Settings at the meeting today which
merited its own thread:

 * system settings direction and improvements (alex-l, ...)
 the most complained part for me is System Settings:
newbies don't like it
 I like some of what Andreas is doing
 the lots of papercuts
 Note on SySe: Daniel Foré from Elementary OS had the
idea to introduce a cross-DE URI scheme to let apps open precise
system settings module. If SySe will adopt it, its complexity would be
reduced and users would be able to find easily the settings related to
the app they are using. As always the question is: there would be the
manpower to implement it?
 but the problem is that the "let's fix system settings"
attempts i see are always vague and high-level and end up being a
rearrangement of marbles, instead of purpose-directed. for example,
here's a real thing we need to fix in settings: the keyboard layout
kcm needs to become an input languages kcm, so people can set up an
IME in there easily to actually be able to type their lang. that's
something we suck at that Gnome/Windows/Mac do well. but instead it's
"maybe we
mgraesslin thinks that part of the problem is that we constantly
move things around because we think we finally found the ultimate
solution

Go ahead and discuss...

Breakout: UI and user vision for cloud services

[Jonathan Riddell]

 * Services integration - I see more and more users who have
data locked up in clouds (GDrive, etc.) and rely on accessing it
 Gnome has GDrive integration, we need to do more on getting
cloud filesystems into our software too, but we dropped the ball on
KAccounts etc. for now
 but withth tings like proprietary services is like a
dangerous soul tradeoff..
 dangerous or not, even our cloud support for Free services is
sub-par (next/owncloud, for example)
 eventually boudhayan could work on it, related to caldav/carddav
for spacebar
  Sho_: we have kio slave for gdrive now, but
needs integration with kaccounts indeed.
 kio gdrive is the technology, but do we know how we fit it into
our "UI Story", so users find it?

discuss...

Breakout: regression / integration testing

[Jonathan Riddell]

* regression / integration testing (possibly with openQA)
(Riddell, bshah, einar77, ...)
 I want to work on some kind of integration testing /
regression testing for plasma and plasma mobile stuff combined
 bshah: openQA is good for integration testing, yes
Iknow I'm biased, but showed bugs during the betas
 i agree that openQA is worth spending time on, we need
better full integration tests for the quality pain points

Discuss!

Breakout: * multiscreen behaviour: how should Plasma exactly behave in different scenarios?

[Jonathan Riddell]

 biggest pain point from bugzilla is mostly still
multiscreen. I'm not sure we have a solid plan of what /should/ happen
in each situation.
 panel gets added to screen 1 and 2, you disconnect screen
2. How many panels do you have on screen 1
 btw, this is meta, but I feel the amount of feedback we get
on multiscreen is really telling about our audience - many people who
use KDE have multiple screens it seems, and only certain kinds of
people and usage scenarios involve multiple screens (enthusiast home
users, office professionals ..)
 Multiscreen is also connecting to a projector for
a movie, not only multiple displazs on the desk
 d_ed: multiscreen on sddm on X11 is something I reported,
it doesn't work terribly well as in: you get overlapping sddms if you
have overlapping screens etc.


discuss!

Breakout: how to attract new contributors?

[Jonathan Riddell]

 we need more contributors, junior jobs are best way to get started
 the most critical thing we can do for developer recruitment
 is change the way we publish/blog
 our blogs are mostly work notes aimed at users, we need to
write more blog posts that engineers like to read
 mgraesslin: the interesting thing is that among the best and
brightest fresh young open source contributors, we have quite a few
users - e.g. in the Rust community quite a few use Plasma, because C++
is the next best thing - but we don't publish anything they like to
read so we don't convert

discuss!

[no subject]

[Jonathan Riddell]

what Qt version will 5.9 require? 5.6 still or 5.7?

breakout: store and dependencies: to both plasma and other apps versions

[Jonathan Riddell]

 llucas`: on one hand, we need to figure out the dependency
system on KPackage, then we can look whether anything is needed on the
discover side, which shouldn't be needed
 apol what about   * store and dependencies: to both
plasma and other apps versions (for i.e. simplemenu, Dolphin service
menus) and to other store items (i.e. look&feel packages)  and
integration with discover?
 About KDE Store: I noticed that i.e. Dolphin Service
Menus doesn't display KDE Store contents. The previous domains point
to store.kde.org now but the new contents on KDE Store are not aleays
displayed like in Dolphin
 Riddell: I need basic version dependency handling - if I
put Simple Menu on the Store today, say, it won't work for anyone
because it needs 5.9 stuff


discuss!

breakout: what Qt version will 5.9 require? 5.6 still or 5.7?

[Jonathan Riddell]

no discussion on this on during the meeting, do we need 5.7, are
distros happy with 5.7?

Breakout: what can go in 5.8 LTS? only bugs or some features?

[Jonathan Riddell]

there was discussion on this after the meeting which I think concluded with:
 - bugfixes only. small features can sometimes be considered
bugfixes if e.g. they're missing compared to plasma 4
 - ask release team for exceptions

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Roman Gilg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/
---

(Updated Okt. 17, 2016, 8:40 nachm.)


Review request for Plasma and Martin Gräßlin.


Changes
---

Changed structure completely in order to support legacy applets and the asynced 
releases of Plasma and Frameworks. The new structure also reduces the extent of 
changes to other components. For example we don't need any changes anymore in 
KWin and Plasma-Workspace. The solution now works like this:

- A qml based applet can decide if it wants to use legacy behaviour of 
activation, which means while being activated it will NOT trigger shrinking or 
if it wants to let the shortcut work like a switch of the expanded state
- The default value of this behaviour is false in order to not break legacy 
applets
- The launchers set it to true, in case of kicker only if it's not in Dash mode 
(maybe we could use the new system here too, but it shouldn't be part of this 
diff)


Bugs: 367685
http://bugs.kde.org/show_bug.cgi?id=367685


Repository: plasma-framework


Description
---

# The new Meta-key support for launcher opening doesn't work for closing at the 
moment. My analysis of the problem was as follows:

- KWin calls Applet::activated() over DBus
- Applet::activated() is connected to AppletInterface::activated()
- AppletInterface::activated() is connected to setExpanded(true), which can 
only expand the launcher, but not the other way around

# Q: Why is Alt+F1 working though?
A: The launchers seem to inherit the reimplemented function 
Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
the focusOutEvent(..) as a global shortcut.

# Q: Why is it working with the Dashboard though?
A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
connects directly to the AppletInterface::activated() signal and shows/hides an 
independent widget when this signal gets triggered.

# Solution:
Create new toggled() signal chain in KWin, Applet, AppletInterface, which tests 
the current expanded state and sets it afterwards accordingly to the opposite. 
This diff here in plasma-framework is the first one, which the others depend 
on. The others are on Phabricator:

- kwin: https://phabricator.kde.org/D3077
- plasma-workspace: https://phabricator.kde.org/D3078
- plasma-desktop: https://phabricator.kde.org/D3079

# Need feedback regarding:

- Should we remove the activated() signal chain? Is it used somewhere else than 
KWin?
- Could a race condition occur if we deexpand the applet while at the same time 
setting the visibility to false through focusOutEvent()? My tests until now 
don't suggest it, but I haven't yet looked into it extensively.


Diffs (updated)
-

  src/plasmaquick/appletquickitem.h 943e227 
  src/plasmaquick/appletquickitem.cpp 2f100b8 
  src/plasmaquick/private/appletquickitem_p.h 1436935 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 

Diff: https://git.reviewboard.kde.org/r/129204/diff/


Testing
---


Thanks,

Roman Gilg

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Roman Gilg]

> On Okt. 17, 2016, 12:22 nachm., Marco Martin wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.h, line 408
> > 
> >
> > it would be nice a bool paramenter here with the new value of expanded

Dropped because the new structure doesn't use any toggled() signal anymore.


- Roman


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100072
---


On Okt. 17, 2016, 8:40 nachm., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Okt. 17, 2016, 8:40 nachm.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time setting the visibility to false through focusOutEvent()? My tests until 
> now don't suggest it, but I haven't yet looked into it extensively.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 943e227 
>   src/plasmaquick/appletquickitem.cpp 2f100b8 
>   src/plasmaquick/private/appletquickitem_p.h 1436935 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 
> 
> Diff: https://git.reviewboard.kde.org/r/129204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

Re:

[Marco Martin]

On Monday 17 October 2016, Jonathan Riddell wrote:
> what Qt version will 5.9 require? 5.6 still or 5.7?

would like 5.7 to allow preliminary use of QtQuickControls2, if there aren't 
significant drawbacks

-- 
Marco Martin

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100106
---




src/plasmaquick/appletquickitem.h (line 86)


i would prefer a different wording, like togglesOnActivation or 
activationTogglesExpanded or something like that


- Marco Martin


On Oct. 17, 2016, 6:40 p.m., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Oct. 17, 2016, 6:40 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time setting the visibility to false through focusOutEvent()? My tests until 
> now don't suggest it, but I haven't yet looked into it extensively.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 943e227 
>   src/plasmaquick/appletquickitem.cpp 2f100b8 
>   src/plasmaquick/private/appletquickitem_p.h 1436935 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 
> 
> Diff: https://git.reviewboard.kde.org/r/129204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

Re:

[Kai Uwe Broulik]

Global menu stuff also requires 5.7

‎+1 for that, with 5.8 being LTS‎, it's a good choice for those who want to 
stick with Qt 5.6.

[Differential] [Updated, 25 lines] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[subdiff (Roman Gilg)]

subdiff updated this revision to Diff 7472.
subdiff added a comment.


  Adjustements to second revision of the Diff in Plasma-Frameworks on 
Reviewboard: https://git.reviewboard.kde.org/r/129204/
  
  But it reverts all changes here, since no changes are necessary anymore in 
Plasma-Workspace. In the end I will abandon this Diff, if the concept of the 
second revision of the Plasma-Frameworks Diff is accepted.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3078?vs=7439&id=7472

REVISION DETAIL
  https://phabricator.kde.org/D3078

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, davidedmundson
Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 6 lines] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

[subdiff (Roman Gilg)]

subdiff updated this revision to Diff 7474.
subdiff added a comment.


  Adjustements to second revision of the Diff in Plasma-Frameworks on 
Reviewboard: https://git.reviewboard.kde.org/r/129204/

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3079?vs=7442&id=7474

REVISION DETAIL
  https://phabricator.kde.org/D3079

AFFECTED FILES
  applets/kicker/package/contents/ui/CompactRepresentation.qml
  applets/kicker/package/contents/ui/main.qml
  applets/kickoff/package/contents/ui/Kickoff.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, broulik
Cc: davidedmundson, plasma-devel, #plasma, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Breakout: System Settings Improvements

[kainz.a]

Hi,

as we discuss this already a long time now I think we should start from
scratch with a complete new idea. cause if our ideas in the past would be
good, we had finalized it.

I'd like to discuss it in the VDG IRC / Telegram channel and add the
results to
https://notes.kde.org/p/SystemSettings

thanks
Andreas


Am 17.10.2016 18:48 schrieb "Jonathan Riddell" :

> We had a discussion on System Settings at the meeting today which
> merited its own thread:
>
>  * system settings direction and improvements (alex-l, ...)
>  the most complained part for me is System Settings:
> newbies don't like it
>  I like some of what Andreas is doing
>  the lots of papercuts
>  Note on SySe: Daniel Foré from Elementary OS had the
> idea to introduce a cross-DE URI scheme to let apps open precise
> system settings module. If SySe will adopt it, its complexity would be
> reduced and users would be able to find easily the settings related to
> the app they are using. As always the question is: there would be the
> manpower to implement it?
>  but the problem is that the "let's fix system settings"
> attempts i see are always vague and high-level and end up being a
> rearrangement of marbles, instead of purpose-directed. for example,
> here's a real thing we need to fix in settings: the keyboard layout
> kcm needs to become an input languages kcm, so people can set up an
> IME in there easily to actually be able to type their lang. that's
> something we suck at that Gnome/Windows/Mac do well. but instead it's
> "maybe we
> mgraesslin thinks that part of the problem is that we constantly
> move things around because we think we finally found the ultimate
> solution
>
> Go ahead and discuss...
>

Re:

[Sebastian Kügler]

On maandag 17 oktober 2016 20:50:37 CEST Kai Uwe Broulik wrote:
> Global menu stuff also requires 5.7
> 
> ‎+1 for that, with 5.8 being LTS‎, it's a good choice for those who want to
> stick with Qt 5.6.

I agree.
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: Breakout: * multiscreen behaviour: how should Plasma exactly behave in different scenarios?

[Martin Klapetek]

On Mon, Oct 17, 2016 at 12:59 PM, Jonathan Riddell  wrote:

>  biggest pain point from bugzilla is mostly still
> multiscreen. I'm not sure we have a solid plan of what /should/ happen
> in each situation.
>  panel gets added to screen 1 and 2, you disconnect screen
> 2. How many panels do you have on screen 1
>

(speaking from being in a work environment where I regularly switch
between various screens/tvs and screen setups multiple times a day)

Ideally containments are tied to screens as a whole and no "merge"
of panels is happening. So in the case above, one panel. (I don't
remember if panels are part of the containments, but I'll assume it is)

Thinking about it a bit more, I think the concept of primary screen
is important here. When I have only my laptop, its screen is obviously
the primary one. Now if I plug in a screen(s) and I set any other screen
as primary, I'd expect the containment from my laptop to go to that
primary screen, creating new one/restoring old one for the laptop screen.

Now at this point this is the setup (where * is primary):
[laptop] [*screen1]

If I add another panel to [laptop] (both screens now have bottom panel),
I would want that panel (and containment) to appear again only in this same
setup.
Ie. unplugging [screen1] makes [laptop] primary again and thus moving
the containment from [screen1] back to [laptop], unloading the other
containment completely.

Ie: [laptop] [*screen1] --unplug screen--> [*laptop]

That primary setting should also be remembered by a screen I think,
because if I'm plugging to a projector or big room TV, I don't think I want
all my laptop screen suddenly jumping to the other screen for everyone
to see. In other words, I never set that TV or projector as primary and
therefore plasma shouldn't automatically assume "any external screen
equals move primary screen".

Ie: [*laptop] --plug TV--> [*laptop] [TV]

If I explicitly set the TV as primary, then it should again be remembered.

Ie: [*laptop] --plug TV--> [laptop] [*TV]

The reasoning for this^ is that, presumably, for privacy and/or comfort
I'd be moving the primary screen from the TV back to my laptop.
But then when I come back to my desk and plug in my screen,
I'd need to again set the primary screen to the external screen, which
is just annoying.

So...my CA$ 0.02 :)

Cheers
-- 
Martin Klapetek

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in kdeplatformtheme.cpp:59
> That's what Qt does and I don't think Qt is equipped to re-create a platform 
> menu at runtime; at least that's what I was told when I raised the very same 
> concern in the upstream Qt codereview that added this.
> 
> We could perhaps do it for newly created menus but when the service becomes 
> unavailable at runtime there's no way for us to re-create existing menus.

hmm then we need to make sure that changing the option cannot be done at 
runtime - it has to require a session restart.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas