[Differential] [Closed] D3095: Implement cursor shape tracking on Wayland

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN5b9da55e75e1: Implement cursor shape tracking on Wayland 
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3095?vs=7499=7558

REVISION DETAIL
  https://phabricator.kde.org/D3095

AFFECTED FILES
  cursor.cpp
  cursor.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3093: Add a PlatformCursorImage to Platform and EffectsHandler

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINea52ef9e572b: Add a PlatformCursorImage to Platform and 
EffectsHandler (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3093?vs=7491=7557

REVISION DETAIL
  https://phabricator.kde.org/D3093

AFFECTED FILES
  autotests/mock_effectshandler.h
  effects.cpp
  effects.h
  effects/screenshot/screenshot.cpp
  effects/zoom/zoom.cpp
  libkwineffects/CMakeLists.txt
  libkwineffects/kwineffects.h
  libkwineffects/kwinglobals.h
  platform.cpp
  platform.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 129230: Count only applications in memory usage

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129230/
---

(Updated Oct. 19, 2016, 10:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 346b492b362a1ee74ea809de80c0cdaa60ef1dda by David 
Edmundson on behalf of Miklós Máté to branch Plasma/5.8.


Repository: kdeplasma-addons


Description
---

This restores the behavior of the widget to match the original C++ version. 
Buffers and cached do not really contribute to memory usage, because file 
system cache gets dropped, if applications need more memory. See MemFree vs. 
MemAvailable in /proc/cpuinfo.


Diffs
-

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9b2ad1e 

Diff: https://git.reviewboard.kde.org/r/129230/diff/


Testing
---


Thanks,

Miklós Máté

[Differential] [Request, 237 lines] D3117: allow changing an output's modelist at runtimeThis should fix running Plasma in a windowed virtual machine, when the window is resized, the mode list changes

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: Plasma.
sebas added a subscriber: graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - make Output::modes() non CONSTANT, add modesChanged() signal
  - compare the mode lists and set the new one
  - queue an outputChanged signal when applied
  - autotest for modelist changes
  - update the mode list on RRNotify events
  
  BUG:356864

TEST PLAN
  - for library part, autotests are added
  - for xrandr backends, we can't sensibly autotest this :(

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/modelistchange

REVISION DETAIL
  https://phabricator.kde.org/D3117

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/testmodelistchange.cpp
  backends/xrandr/xrandroutput.cpp
  src/output.cpp
  src/output.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 129230: Count only applications in memory usage

[Miklós Máté]

> On Oct. 19, 2016, 8:45 p.m., David Edmundson wrote:
> > Thanks
> > 
> > Do you have commit access?
> > Also there's a bug report on this that should be closed with this commit.

I don't have commit access. Do you mean bug #366342 ?


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129230/#review100147
---


On Oct. 19, 2016, 8:35 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129230/
> ---
> 
> (Updated Oct. 19, 2016, 8:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This restores the behavior of the widget to match the original C++ version. 
> Buffers and cached do not really contribute to memory usage, because file 
> system cache gets dropped, if applications need more memory. See MemFree vs. 
> MemAvailable in /proc/cpuinfo.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9b2ad1e 
> 
> Diff: https://git.reviewboard.kde.org/r/129230/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129230: Count only applications in memory usage

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129230/#review100147
---


Ship it!




Thanks

Do you have commit access?
Also there's a bug report on this that should be closed with this commit.

- David Edmundson


On Oct. 19, 2016, 8:35 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129230/
> ---
> 
> (Updated Oct. 19, 2016, 8:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This restores the behavior of the widget to match the original C++ version. 
> Buffers and cached do not really contribute to memory usage, because file 
> system cache gets dropped, if applications need more memory. See MemFree vs. 
> MemAvailable in /proc/cpuinfo.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9b2ad1e 
> 
> Diff: https://git.reviewboard.kde.org/r/129230/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Review Request 129230: Count only applications in memory usage

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129230/
---

Review request for Plasma.


Repository: kdeplasma-addons


Description
---

This restores the behavior of the widget to match the original C++ version. 
Buffers and cached do not really contribute to memory usage, because file 
system cache gets dropped, if applications need more memory. See MemFree vs. 
MemAvailable in /proc/cpuinfo.


Diffs
-

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9b2ad1e 

Diff: https://git.reviewboard.kde.org/r/129230/diff/


Testing
---


Thanks,

Miklós Máté

[Differential] [Closed] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

[subdiff (Roman Gilg)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP05c3125cd831: Launchers set new bool in 
plasma-frameworks to toggle expanded (authored by subdiff).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3079?vs=7515=7552

REVISION DETAIL
  https://phabricator.kde.org/D3079

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kickoff/package/contents/ui/Kickoff.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Roman Gilg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/
---

(Updated Oct. 19, 2016, 7:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
---

Submitted with commit 65706d3878d556c7a1eac18984ec41b1a1d96d56 by Roman Gilg to 
branch master.


Bugs: 367685
http://bugs.kde.org/show_bug.cgi?id=367685


Repository: plasma-framework


Description
---

# The new Meta-key support for launcher opening doesn't work for closing at the 
moment. My analysis of the problem was as follows:

- KWin calls Applet::activated() over DBus
- Applet::activated() is connected to AppletInterface::activated()
- AppletInterface::activated() is connected to setExpanded(true), which can 
only expand the launcher, but not the other way around

# Q: Why is Alt+F1 working though?
A: The launchers seem to inherit the reimplemented function 
Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
the focusOutEvent(..) as a global shortcut.

# Q: Why is it working with the Dashboard though?
A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
connects directly to the AppletInterface::activated() signal and shows/hides an 
independent widget when this signal gets triggered.

# Solution:
Create new toggled() signal chain in KWin, Applet, AppletInterface, which tests 
the current expanded state and sets it afterwards accordingly to the opposite. 
This diff here in plasma-framework is the first one, which the others depend 
on. The others are on Phabricator:

- kwin: https://phabricator.kde.org/D3077
- plasma-workspace: https://phabricator.kde.org/D3078
- plasma-desktop: https://phabricator.kde.org/D3079

# Need feedback regarding:

- Should we remove the activated() signal chain? Is it used somewhere else than 
KWin?
- Could a race condition occur if we deexpand the applet while at the same time 
setting the visibility to false through focusOutEvent()? My tests until now 
don't suggest it, but I haven't yet looked into it extensively.


Diffs
-

  src/plasmaquick/appletquickitem.h 943e227 
  src/plasmaquick/appletquickitem.cpp 2f100b8 
  src/plasmaquick/private/appletquickitem_p.h 1436935 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 

Diff: https://git.reviewboard.kde.org/r/129204/diff/


Testing
---


Thanks,

Roman Gilg

[Differential] [Accepted] D3114: [Session Model] Show new session entry only if we actually can

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3114

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D3114: [Session Model] Show new session entry only if we actually can

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When canStartNewSession is false showNewSessionEntry doesn't make any sense.

TEST PLAN
[KDE Action Restrictions]
action/start_new_session=false
  
  No longer get a "New Session" entry.
  When I remove it again the entry shows up again.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3114

AFFECTED FILES
  components/sessionsprivate/sessionsmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3085: RFC: Use DBusMenu if available

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 1,622 lines] D3085: RFC: Use DBusMenu if available

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7549.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3085?vs=7457=7549

REVISION DETAIL
  https://phabricator.kde.org/D3085

AFFECTED FILES
  CMakeLists.txt
  COPYING.LGPL-2
  COPYING.LGPL-3
  COPYING.LIB
  autotests/CMakeLists.txt
  cmake/modules/FindQt5PlatformSupport.cmake
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kdeplatformtheme.h
  src/platformtheme/qdbusmenubar.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3093: Add a PlatformCursorImage to Platform and EffectsHandler

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  platform-cursor-image

REVISION DETAIL
  https://phabricator.kde.org/D3093

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3095: Implement cursor shape tracking on Wayland

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  cursor-tracking-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3095

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> broulik wrote in ContextMenu.qml:413
> Imho this should be a regular function() like the others

I didn't want to pollute the outside world - it should be as efficient as if it 
was a regular function (if qt jit is sane - it could even be inlined).

> broulik wrote in ContextMenu.qml:422
>   result.checked = activities.some(function(activity) {
>   return activity === id
>   })

Thanks for this. The last time I tried 'modern' JS features in Qt, they did not 
work, and I stopped re-testing. It is nice to know this works, JS is a bit less 
ugly now ;)

> broulik wrote in ContextMenu.qml:442
> Don't you keep adding a connection everytime you call refresh()?

Fixed

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3106

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, hein, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 87 lines] D3106: Replaced the launcher pinning action with a per-activity meny

[Ivan Čukić]

ivan updated this revision to Diff 7548.
ivan marked 3 inline comments as done.
ivan added a comment.


  - Created a special case for when there is only one activity

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3106?vs=7525=7548

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3106

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, hein, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3113: Pass transient parent window to KToolTipWindow

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKINFOCENTER KInfoCenter

BRANCH
  wayland-fix-tooltips

REVISION DETAIL
  https://phabricator.kde.org/D3113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3079

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 22 lines] D3113: Pass transient parent window to KToolTipWindow

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This fixes tooltips on Wayland. We need the relationship to the
  transient parent window - tooltips are positioned relative to their
  parent window. Also on X11 this is an important information which was
  completely lacking.
  
  Before the change the tooltips got randomly positioned by the Wayland
  compositor as it thought that it is a new toplevel window. With the
  change the tooltip gets shown where it is supposed to be shown.

TEST PLAN
  Run kinfocenter with --platform wayland and xcb

REPOSITORY
  rKINFOCENTER KInfoCenter

BRANCH
  wayland-fix-tooltips

REVISION DETAIL
  https://phabricator.kde.org/D3113

AFFECTED FILES
  ToolTips/ktooltip.cpp
  ToolTips/ktooltip.h
  ToolTips/tooltipmanager.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3112: Pass transient parent window to KToolTipWindow

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rSYSTEMSETTINGS System Settings

BRANCH
  wayland-fix-tooltips

REVISION DETAIL
  https://phabricator.kde.org/D3112

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bcooksley, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 22 lines] D3112: Pass transient parent window to KToolTipWindow

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This fixes tooltips on Wayland. We need the relationship to the
  transient parent window - tooltips are positioned relative to their
  parent window. Also on X11 this is an important information which was
  completely lacking.
  
  Before the change the tooltips got randomly positioned by the Wayland
  compositor as it thought that it is a new toplevel window. With the
  change the tooltip gets shown where it is supposed to be shown.

TEST PLAN
  Run systemsettings with --platform wayland and xcb

REPOSITORY
  rSYSTEMSETTINGS System Settings

BRANCH
  wayland-fix-tooltips

REVISION DETAIL
  https://phabricator.kde.org/D3112

AFFECTED FILES
  app/ToolTips/ktooltip.cpp
  app/ToolTips/ktooltip.h
  app/ToolTips/tooltipmanager.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3112: Pass transient parent window to KToolTipWindow

[Martin Gräßlin]

graesslin added a reviewer: bcooksley.

REPOSITORY
  rSYSTEMSETTINGS System Settings

REVISION DETAIL
  https://phabricator.kde.org/D3112

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, bcooksley
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  >> probably in that case there should be the simple "add launcher when not 
running"
  > 
  > Yes, and adding to all activities would be the smartest choice I'd say.
  
  +1

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3106

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, hein, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

[Ivan Čukić]

ivan added a comment.


  > probably in that case there should be the simple "add launcher when not 
running"
  
  Yes, and adding to all activities would be the smartest choice I'd say.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3106

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, hein, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 519 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/519/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Oct 2016 11:04:38 +
Build duration: 15 min

CHANGE SET
Revision 59733c21a4bb0d04bb76367995aa611e66f5f3e5 by Martin Gräßlin: ([shell] 
Create panelshadow in surfacecreated event instead of show event)
  change: edit shell/panelview.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.launchertasksmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 13/13 (100%)FILES 53/73 (73%)CLASSES 53/73 (73%)LINE 2102/5593 
(38%)CONDITIONAL 1444/5538 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 101/135 (75%)CONDITIONAL 
36/66 (55%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/20 (30%)CLASSES 6/20 (30%)LINE 194/3245 (6%)CONDITIONAL 
119/3197 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 49/69 (71%)CONDITIONAL 
17/64 (27%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/39 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

[Martin Gräßlin]

graesslin added a comment.


  Trying to apply the patch results in conflicts in autotests/CMakeLists.txt
  
  Trying to compile nevertheless without autotests gives me a compile error:
  

/home/martin/src/kf5/kde/workspace/plasma-integration/src/platformtheme/kdeplatformtheme.cpp:47:36:
 fatal error: private/qdbusmenubar_p.h: No such file or directory
 #include 
^
compilation terminated.
src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/build.make:62: 
recipe for target 
'src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/kdeplatformtheme.cpp.o'
 failed
make[2]: *** 
[src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/kdeplatformtheme.cpp.o]
 Error 1
CMakeFiles/Makefile2:136: recipe for target 
'src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/all' failed

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D3100: Expose GLRenderTarget::virtualScreenGeometry

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINf4627e38f182: Expose 
GLRenderTarget::virtualScreenGeometry (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3100?vs=7510=7544

REVISION DETAIL
  https://phabricator.kde.org/D3100

AFFECTED FILES
  libkwineffects/kwinglutils.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3101: Adjust blur and contrast for multi-output rendering on Wayland

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINbef9c9c8c589: Adjust blur and contrast for multi-output 
rendering on Wayland (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3101?vs=7511=7545

REVISION DETAIL
  https://phabricator.kde.org/D3101

AFFECTED FILES
  effects/backgroundcontrast/contrast.cpp
  effects/backgroundcontrast/contrast.h
  effects/blur/blur.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN1708278a451e: Fix viewport restore in 
GLRenderTarget::popRenderTarget (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3099?vs=7509=7543

REVISION DETAIL
  https://phabricator.kde.org/D3099

AFFECTED FILES
  libkwineffects/kwinglutils.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3109: [shell] Create panelshadow in surfacecreated event instead of show event

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE59733c21a4bb: [shell] Create panelshadow in 
surfacecreated event instead of show event (authored by graesslin).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3109?vs=7536=7542

REVISION DETAIL
  https://phabricator.kde.org/D3109

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in kwinglutils.cpp:1181
> I don't understand the maths, why is the "x" the negative 
> virtualScreenGeometry and "y" some formula?

OpenGL has a different coordinate system. The 0/0 is on the bottom left corner 
unlike our own coordinate system which has 0/0 as the top left.

The virtualScreenGeometry contains the geometry of the output we are currently 
rendering to in our coordinate system. E.g. two screens:

- 0,0x1920,1080
- 1280,0x1280,1024

Now we need to map that into the coordinate system of OpenGL which has for the 
first screen a window of size 1920,1080 and for the second screen a window of 
1280,1024 - both windows have the coordinate system start at 0/0 at the bottom 
left.

What we try to do here is to map the rendering to the OpenGL window. Everything 
of the first screen needs to end up on the first OpenGL window, everything on 
the second screen needs to end up on the second OpenGL window. In both cases we 
need to adjust so that it becomes 0/0 from bottom left corner.

Thus for x we need to take the negative. For the left most screen nothing 
changes, 0 is 0. For the right screen we need to ensure that 1920 gets mapped 
to 0. So negative x it is.

Height is similarly adjusted, but is a little bit more complex as it also swaps 
the coordinate system. Always a mess.

REPOSITORY
  rKWIN KWin

BRANCH
  render-target-viewport

REVISION DETAIL
  https://phabricator.kde.org/D3099

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> kwinglutils.cpp:1181
>  } else {
> -glViewport (0, 0, s_virtualScreenSize.width(), 
> s_virtualScreenSize.height());
> +glViewport (-s_virtualScreenGeometry.x(), 
> s_virtualScreenGeometry.height() - s_virtualScreenSize.height() - 
> s_virtualScreenGeometry.y(),
> +   s_virtualScreenSize.width(), 
> s_virtualScreenSize.height());

I don't understand the maths, why is the "x" the negative virtualScreenGeometry 
and "y" some formula?

REPOSITORY
  rKWIN KWin

BRANCH
  render-target-viewport

REVISION DETAIL
  https://phabricator.kde.org/D3099

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  render-target-viewport

REVISION DETAIL
  https://phabricator.kde.org/D3099

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D3102: Do not ask for root permissions when it's unnecessary

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> accountmodel.cpp:165
>  
> -m_dbus->UncacheUser(acc->userName()).waitForFinished();
> -m_dbus->CacheUser(acc->userName());

is there absolutely nothing left needing this?

REPOSITORY
  rUSERMANAGER User Manager

REVISION DETAIL
  https://phabricator.kde.org/D3102

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129204/#review100131
---


Ship it!




Ship It!

- Marco Martin


On Oct. 18, 2016, 5:20 p.m., Roman Gilg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129204/
> ---
> 
> (Updated Oct. 18, 2016, 5:20 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 367685
> http://bugs.kde.org/show_bug.cgi?id=367685
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> # The new Meta-key support for launcher opening doesn't work for closing at 
> the moment. My analysis of the problem was as follows:
> 
> - KWin calls Applet::activated() over DBus
> - Applet::activated() is connected to AppletInterface::activated()
> - AppletInterface::activated() is connected to setExpanded(true), which can 
> only expand the launcher, but not the other way around
> 
> # Q: Why is Alt+F1 working though?
> A: The launchers seem to inherit the reimplemented function 
> Dialog::focusOutEvent(..). Atleast when you delete line 1094 in dialog.cpp, 
> which sets the visibility to false, it's not working anymore. Alt+F1 triggers 
> the focusOutEvent(..) as a global shortcut.
> 
> # Q: Why is it working with the Dashboard though?
> A: The dashboard doesn't use the expanded feature of the plasmoid, but rather 
> connects directly to the AppletInterface::activated() signal and shows/hides 
> an independent widget when this signal gets triggered.
> 
> # Solution:
> Create new toggled() signal chain in KWin, Applet, AppletInterface, which 
> tests the current expanded state and sets it afterwards accordingly to the 
> opposite. This diff here in plasma-framework is the first one, which the 
> others depend on. The others are on Phabricator:
> 
> - kwin: https://phabricator.kde.org/D3077
> - plasma-workspace: https://phabricator.kde.org/D3078
> - plasma-desktop: https://phabricator.kde.org/D3079
> 
> # Need feedback regarding:
> 
> - Should we remove the activated() signal chain? Is it used somewhere else 
> than KWin?
> - Could a race condition occur if we deexpand the applet while at the same 
> time setting the visibility to false through focusOutEvent()? My tests until 
> now don't suggest it, but I haven't yet looked into it extensively.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 943e227 
>   src/plasmaquick/appletquickitem.cpp 2f100b8 
>   src/plasmaquick/private/appletquickitem_p.h 1436935 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 
> 
> Diff: https://git.reviewboard.kde.org/r/129204/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

[Differential] [Updated] D3106: Replaced the launcher pinning action with a per-activity meny

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3106#57642, @broulik wrote:
  
  > What happens if there is only one activity? I don't use activities and I 
don't want a complicated submenu for pinning applications in this case.
  
  
  probably in that case there should be the simple "add launcher when not 
running"
  now, i don't know wether that action should add to the current or to all of 
them.
  to all is probably safest for new users

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3106

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, hein, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3109: [shell] Create panelshadow in surfacecreated event instead of show event

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3109#57649, @broulik wrote:
  
  > Works on X11 as well.
  >
  > plasma-frameworks dialog probably also needs this treatment (also does it 
in showEvent)
  
  
  for whatever reason it works with dialogs *shrug*

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  panel-shadow-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3109

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: KCM for network configuration

[Heiko Tietze]

On 10/13/2016 10:57 AM, Jan Grulich wrote:
> So what do you think?
> 
> [1] - https://jgrulich.fedorapeople.org/kcm_network.png

Awesome, really nice! 

A few nitpicks: 
* a little bit more vertical space between the controls
* the checkbox needs a label like "[ ] Enable" or better "Visibility: [ ] 
Hidden Network"
* Random has ellipsis indicating that there is more interaction; not sure if 
that's true for generation of a random number

And remarks:
* years ago we had the goal to get rid of tabs
* I wonder how you deal with the not so happy paths; left list is unexpected 
concise

But good work anyway. Most users will likely be very happy with your solution.

Cheers,
Heiko



signature.asc
Description: OpenPGP digital signature

Re: KCM for network configuration

[Björn Balazs]

Am Donnerstag, 13. Oktober 2016, 16:03:51 CEST schrieb Heiko Tietze:
> On 10/13/2016 10:57 AM, Jan Grulich wrote:
> > So what do you think?
> > 
> > [1] - https://jgrulich.fedorapeople.org/kcm_network.png
> 
> Awesome, really nice!
> 
> A few nitpicks:
> * a little bit more vertical space between the controls
> * the checkbox needs a label like "[ ] Enable" or better "Visibility: [ ]
> Hidden Network" * Random has ellipsis indicating that there is more
> interaction; not sure if that's true for generation of a random number
> 
> And remarks:
> * years ago we had the goal to get rid of tabs
> * I wonder how you deal with the not so happy paths; left list is unexpected
> concise
> 
> But good work anyway. Most users will likely be very happy with your
> solution.

I totally agree with Heiko. This is a good step. The real work waits when it 
comes to consolidate the actual content of the Tabs (additional to what Heiko 
said e.g. do we need an extra Tab for Security?)...

Cheers,
Björn



signature.asc
Description: This is a digitally signed message part.

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  What happens if there is only one activity? I don't use activities and I 
don't want a complicated submenu for pinning applications in this case.

INLINE COMMENTS

> ContextMenu.qml:413
> +
> +var createNewItem = function(id, title, url, activities) {
> +var result = menu.newMenuItem(activitiesLaunchersMenu);

Imho this should be a regular function() like the others

> ContextMenu.qml:422
> +
> +for (var j = 0; j < activities.length; ++j) {
> +if (id == activities[j]) {

result.checked = activities.some(function(activity) {
  return activity === id
  })

> ContextMenu.qml:442
> +
> +menu.onVisualParentChanged.connect(function() {
> +

Don't you keep adding a connection everytime you call refresh()?

> ContextMenu.qml:464
> +
> +for (var i = 0; i < runningActivities.length; ++i) {
> +var id = runningActivities[i];

runningActivities.forEach(function(activity) {
  createNewItem(activity, name, ...)
  })

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3106

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, hein
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3109: [shell] Create panelshadow in surfacecreated event instead of show event

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  Works on X11 as well.
  
  plasma-frameworks dialog probably also needs this treatment (also does it in 
showEvent)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  panel-shadow-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3109

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Breakout: UI and user vision for cloud services

[Elvis Angelaccio]

On Wed, Oct 19, 2016 at 5:17 AM, Martin Klapetek
 wrote:
> On Mon, Oct 17, 2016 at 12:54 PM, Jonathan Riddell  wrote:
>>
>>  * Services integration - I see more and more users who have
>> data locked up in clouds (GDrive, etc.) and rely on accessing it
>>  Gnome has GDrive integration, we need to do more on getting
>> cloud filesystems into our software too, but we dropped the ball on
>> KAccounts etc. for now
>
>
> As the former KAccounts maintainer, I'd like to share some insights on this.
>
> The tech is there. It's proven by real world usage in Ubuntu (incl. Phone),
> Meego before that (iirc) and to some extent also Gnome, which has its own
> fork of the same thing (I guess they just really don't like Qt anywhere).
> Also
> Elementary is using one of these, but I don't remember which. And if I'm
> not mistaken, also Jolla in their phones.
>
> So we have the tech, but what we're missing are two things, really.
>
> 1) Things actually using it. We've had KAccounts for a while but there was
> nothing taking advantage of it, except KDE Telepathy, which migrated fully
> to it. So it sort of became a synonym for KTp accounts config. On the other
> hand, there was nothing much else that would actually need it. There was
> an OwnCloud lib or Plasma thingy at some point where I pleaded to have the
> account setup done through (K)Accounts to boost the adoption, but it never
> happened. Related to that is...
>
> 2) Buy in from PIM. I mean, let's face it, the real accounts user in the
> system
> is PIM, with all the emails and calendars and contacts and what not. This
> obviously requires quite some large effort to actually migrate everything to
> it and sadly the PIM team is long time understaffed. Now with the new Sink
> thing, this could have been a chance, but, again, after asking couple times
> about the accounts plan, (K)Accounts was never in the picture. And that's
> a problem.
>
> And so now we have this system that nobody in/around KDE wants to use.
> My take on it is that people (devs) don't really understand how that system
> works and how to take advantage of it, which is partly my fault. It is
> fairly
> complex system on the inside with lots of points of possible breakages, but
> also allows for great flexibility all around.
>
> So, imho, in order to successfully follow literally every other desktop
> these
> days, it needs a proper full integration in all things using accounts. And
> it really
> shouldn't be just an afterthought. It needs to be put right at the core of
> those
> things and workflows should be redesigned to take that into account (heh).
> It
> needs to be a conscious community-wide effort, like Frameworks was.
> Otherwise
> KAccounts will stay exactly where it is now - a promising (egg-)shell that
> has no
> real use.
>
> Unfortunately if the past two years are any indication, especially with
> Sink,
> the road ahead is not very bright.
>
> I'm happy to try my best to answer any possible future questions about the
> system
> you might have. Friedrich Kossebau was also writing a tutorial about it at
> some
> point, but I'm not sure where it ended up (if at all; I also failed to
> follow up on that).


Hi Martin,
I'm planning to integrate KAccounts with kio-gdrive, so your email is
very much appreciated.
What exactly is "Kaccounts" in the first place? Are we talking about
the kaccounts-integration repo?
A tutorial would be great, but maybe is enough to look at the KDE
Telepathy usage. Could you share more details about this?

>
> Cheers
> --
> Martin Klapetek

Cheers
Elvis

[Differential] [Request, 2 lines] D3109: [shell] Create panelshadow in surfacecreated event instead of show event

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In the show event the Wayland implementation does not pick up the shadow
  at all.
  
  BUG: 368885

TEST PLAN
  Shadow on Wayland, not tested on X11

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  panel-shadow-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3109

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas