[Differential] [Updated] D3335: Move resolving glxSwapIntervalMesa into platform plugin

[Martin Gräßlin]

graesslin updated the test plan for this revision.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3335

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3335: Move resolving glxSwapIntervalMesa into platform plugin

[Martin Gräßlin]

graesslin added a dependency: D3332: Move querying glx extensions into the 
platform plugin.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3335

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3332: Move querying glx extensions into the platform plugin

[Martin Gräßlin]

graesslin added a dependent revision: D3335: Move resolving glxSwapIntervalMesa 
into platform plugin.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-extensions-to-platform

REVISION DETAIL
  https://phabricator.kde.org/D3332

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Request, 65 lines] D3335: Move resolving glxSwapIntervalMesa into platform plugin

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  No need to resolve glx methods through the shared lib. At the moment
  this duplicates some code, but will be cleaned up with a follow up
  change.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-resolve-in-platform

REVISION DETAIL
  https://phabricator.kde.org/D3335

AFFECTED FILES
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  libkwineffects/kwinglutils_funcs.cpp
  libkwineffects/kwinglutils_funcs.h
  plugins/platforms/x11/standalone/glxbackend.cpp
  plugins/platforms/x11/standalone/glxbackend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D3329: Move glx version check functionality to platform plugin

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> glxbackend.cpp:253
> +glXQueryVersion(display(), , );
> +return kVersionNumber(major, minor) >= kVersionNumber(1, 3);
> +}

Just fyi: QVersionNumber is public since Qt 5.6

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3329

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D3332: Move querying glx extensions into the platform plugin

[Martin Gräßlin]

graesslin added a dependency: D3329: Move glx version check functionality to 
platform plugin.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-extensions-to-platform

REVISION DETAIL
  https://phabricator.kde.org/D3332

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D3329: Move glx version check functionality to platform plugin

[Martin Gräßlin]

graesslin added a dependent revision: D3332: Move querying glx extensions into 
the platform plugin.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3329

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3332: Move querying glx extensions into the platform plugin

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in scene_opengl.h:648
> QVector?

yes and no. I would love to use QVector here and that was what I wanted to use 
in the first place. But it will always be filled from a QByteArray::split and 
that returns a QList. So I don't think we gain much if we convert 
this into a QVector.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-extensions-to-platform

REVISION DETAIL
  https://phabricator.kde.org/D3332

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

Re: Review Request 129358: Return SurfaceInterface::size in surface normal co-ordinates

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129358/#review100769
---



unrelated: you could have used phab for the request :-)

I'm not completely sure whether it's a good idea to change the semantics of the 
method, on the other hand I seem to have added a todo for that in the past.


src/server/surface_interface.h (line 117)


"in surface normal"? What do you mean by that?



src/server/surface_interface.cpp (lines 338 - 340)


please add a test case to test this condition.



src/server/surface_interface.cpp (line 642)


this should also be covered in the autotests


- Martin Gräßlin


On Nov. 10, 2016, 4:56 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129358/
> ---
> 
> (Updated Nov. 10, 2016, 4:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> Return SurfaceInterface::size in surface normal co-ordinates
> 
> 
> Diffs
> -
> 
>   src/server/surface_interface.h de74ef336aa7d17c1bd95ba453b8d4f620e416ec 
>   src/server/surface_interface.cpp 157907210254c550e85d24eaa19637f933872ea7 
> 
> Diff: https://git.reviewboard.kde.org/r/129358/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

[xuetianweng (Xuetian Weng)]

xuetianweng added inline comments.

INLINE COMMENTS

> mart wrote in wcpotdprovider.cpp:54
> other copy of invalid url

emm.. I thought I fixed. nvm.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3183

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 571 lines] D3183: Port potd (picture of the day) dataengine to KF5.

[xuetianweng (Xuetian Weng)]

xuetianweng updated this revision to Diff 8083.
xuetianweng marked 8 inline comments as done.
xuetianweng added a comment.


  Update flickr api key and wiki potd url

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3183?vs=7710=8083

BRANCH
  arcpatch-D3183

REVISION DETAIL
  https://phabricator.kde.org/D3183

AFFECTED FILES
  CMakeLists.txt
  dataengines/CMakeLists.txt
  dataengines/potd/CMakeLists.txt
  dataengines/potd/PoTD-list.txt
  dataengines/potd/apodprovider.cpp
  dataengines/potd/cachedprovider.cpp
  dataengines/potd/epodprovider.cpp
  dataengines/potd/flickrprovider.cpp
  dataengines/potd/flickrprovider.h
  dataengines/potd/natgeoprovider.cpp
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.desktop
  dataengines/potd/noaaprovider.h
  dataengines/potd/oseiprovider.cpp
  dataengines/potd/oseiprovider.desktop
  dataengines/potd/oseiprovider.h
  dataengines/potd/plasma_potd_export.h
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.h
  dataengines/potd/wcpotdprovider.cpp
  wallpapers/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D3210#62062, @mart wrote:
  
  >
  
  
  
  
  > sorry for the late reply
  >  ok, so if i understood correctly:
  >  I'll remove those 2 options, and have instead both showing the scrollbar 
on hover *and* the scrollbar size depend uniquely for the global enabled state 
of animations?
  
  Yes, that is the idea.
  
  - When animations are off, always show the scrollbar with the same size it 
currently has
  - When animations are on, show the slim scrollbar by default and make it big 
on mouseover
  
  Would that work?

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Review Request 129373: Plasma Framework changes for #129372

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129373/#review100765
---




src/declarativeimports/core/tooltipdialog.cpp (line 109)


there's a bug in this logic

 - Display Tooltip Dialog
 - Move mouse over the dialog
 - Move Tooltip Dialog

contains mouse will still be true even though you're not containing the 
mouse; and you won't get a leave event until you mouse in and out again.


- David Edmundson


On Nov. 10, 2016, 8:47 p.m., René Fürst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129373/
> ---
> 
> (Updated Nov. 10, 2016, 8:47 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Plasma Framework changes for #129372
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.h d38c49b 
>   src/declarativeimports/core/tooltip.cpp ffe1064 
>   src/declarativeimports/core/tooltipdialog.h d4e0ff0 
>   src/declarativeimports/core/tooltipdialog.cpp 28ba9be 
> 
> Diff: https://git.reviewboard.kde.org/r/129373/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> René Fürst
> 
>

Re: Review Request 129372: Delay Tooltip in Task Manager

[René Fürst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129372/
---

(Updated Nov. 10, 2016, 9:03 nachm.)


Review request for Plasma and Eike Hein.


Bugs: 358930
https://bugs.kde.org/show_bug.cgi?id=358930


Repository: plasma-desktop


Description
---

This patch introduces a delay before changing the tooltip when hovering other 
tasks in task manager (see bug 358930).


Diffs (updated)
-

  applets/taskmanager/package/contents/ui/Task.qml 81d93f1 
  applets/taskmanager/package/contents/ui/main.qml b76bff3 

Diff: https://git.reviewboard.kde.org/r/129372/diff/


Testing
---

Only IconTasks mode - probably some more testing needed.


Thanks,

René Fürst

Re: Review Request 129372: Delay Tooltip in Task Manager

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129372/#review100764
---



There doesn't seem to be a patch attached, check the "Update Diff" button on 
the top right (I think)

Reviews for Plasma-desktop, plasma-workspace, and the like should be put on 
https://phabricator.kde.org/ nowadays. KDE Frameworks, and with it 
plasma-framework, is still on reviewboard.

- Kai Uwe Broulik


On Nov. 10, 2016, 8:48 nachm., René Fürst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129372/
> ---
> 
> (Updated Nov. 10, 2016, 8:48 nachm.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Bugs: 358930
> https://bugs.kde.org/show_bug.cgi?id=358930
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch introduces a delay before changing the tooltip when hovering other 
> tasks in task manager (see bug 358930).
> 
> 
> Diffs
> -
> 
> 
> Diff: https://git.reviewboard.kde.org/r/129372/diff/
> 
> 
> Testing
> ---
> 
> Only IconTasks mode - probably some more testing needed.
> 
> 
> Thanks,
> 
> René Fürst
> 
>

Re: Review Request 129373: Plasma Framework changes for #129372

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129373/#review100763
---



Thanks for your patch!

I'm not fully sure about this, but let's wait for other Plasma developer 
feedback :) Especially, since I couldn't yet look at your patch that actually 
makes use of this API in icontasks.


src/declarativeimports/core/tooltip.h (line 106)


This won't work when tooltip is "interactive: false" (the default) because 
then mouse events pass right through it



src/declarativeimports/core/tooltip.h (line 128)


I know it's been wrong in the other property already but "if a tooltip will 
show".

Also, clarify when, "automatically show when the mouse hovers" or sth like 
that



src/declarativeimports/core/tooltip.h (line 147)


Regardless of the rest of this patch, I like this. For example, in 
Application Dashboard we could use a single ToolTip instance and set the title 
and manually show it, just like we only have one global MouseArea in there as 
well.



src/declarativeimports/core/tooltip.cpp (line 162)


You're connecting to this signal every time you do showToolTip(), use 
Qt::UniqueConnection



src/declarativeimports/core/tooltip.cpp (line 332)


Coding style, brace on next line for functions:

void Foo()
{
...
}



src/declarativeimports/core/tooltip.cpp (line 350)


Coding style: Space after if:

if (foo) {



src/declarativeimports/core/tooltip.cpp (line 358)


I just wanted to complain about it not being keepAlive but that's been 
already there before :)



src/declarativeimports/core/tooltipdialog.cpp (line 153)


can probably be const QObject *



src/declarativeimports/core/tooltipdialog.cpp (line 155)


Coding style



src/declarativeimports/core/tooltipdialog.cpp (line 162)


Coding style


- Kai Uwe Broulik


On Nov. 10, 2016, 8:47 nachm., René Fürst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129373/
> ---
> 
> (Updated Nov. 10, 2016, 8:47 nachm.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Plasma Framework changes for #129372
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.h d38c49b 
>   src/declarativeimports/core/tooltip.cpp ffe1064 
>   src/declarativeimports/core/tooltipdialog.h d4e0ff0 
>   src/declarativeimports/core/tooltipdialog.cpp 28ba9be 
> 
> Diff: https://git.reviewboard.kde.org/r/129373/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> René Fürst
> 
>

Review Request 129373: Plasma Framework changes for #129372

[René Fürst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129373/
---

Review request for Plasma and Eike Hein.


Repository: plasma-framework


Description
---

Plasma Framework changes for #129372


Diffs
-

  src/declarativeimports/core/tooltip.h d38c49b 
  src/declarativeimports/core/tooltip.cpp ffe1064 
  src/declarativeimports/core/tooltipdialog.h d4e0ff0 
  src/declarativeimports/core/tooltipdialog.cpp 28ba9be 

Diff: https://git.reviewboard.kde.org/r/129373/diff/


Testing
---


Thanks,

René Fürst

Review Request 129372: Delay Tooltip in Task Manager

[René Fürst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129372/
---

Review request for Plasma and Eike Hein.


Summary (updated)
-

Delay Tooltip in Task Manager


Bugs: 358930
https://bugs.kde.org/show_bug.cgi?id=358930


Repository: plasma-desktop


Description (updated)
---

This patch introduces a delay before changing the tooltip when hovering other 
tasks in task manager (see bug 358930).


Diffs
-


Diff: https://git.reviewboard.kde.org/r/129372/diff/


Testing (updated)
---

Only IconTasks mode - probably some more testing needed.


Thanks,

René Fürst

[Differential] [Commented On] D3333: merge

[Sebastian Kügler]

sebas added a comment.


  Bah, https://phabricator.kde.org/D2155 is the relevant review this push 
should have closed. Sorry for noise & possible confusion. :/

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2155: kded: fix up invalid current mode before saving

[Sebastian Kügler]

sebas abandoned this revision.
sebas added a comment.


  I've screwed up a rebase and accidentally pushed this patch as 
https://phabricator.kde.org/D . I'll abandon this review, but the change 
was really pushed.
  
  Sorry for the noise and possible confusion.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2155

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3334: [Notifications] Check if we're assigned a containment()

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  That won't fix the crash report linked.
  
  That's a crash in PlasmaQuick::ContainmentView::containment()
  
  which you're still calling in exactly the same way, no?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3334

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 4 lines] D3334: [Notifications] Check if we're assigned a containment()

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This function is not only called in response to Containment screenChanged but 
also KWindowSystem workAreaChanged and when the applet shifts around because a 
screen goes away, there might not be a containment.
  
  BUG: 372297
  FIXED-IN: 5.8.4

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3334

AFFECTED FILES
  applets/notifications/lib/notificationsapplet.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3332: Move querying glx extensions into the platform plugin

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> scene_opengl.h:648
> +
> +QList m_extensions;
>  };

QVector?

REPOSITORY
  rKWIN KWin

BRANCH
  glx-extensions-to-platform

REVISION DETAIL
  https://phabricator.kde.org/D3332

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3265: Make it possible for 5.8 to compile against the last AppStreamQt

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rDISCOVERc52df7007183: Make it possible for 5.8 to compile 
against the last AppStreamQt (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3265?vs=8010=8080#toc

REPOSITORY
  rDISCOVER Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3265?vs=8010=8080

REVISION DETAIL
  https://phabricator.kde.org/D3265

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp
  libdiscover/backends/PackageKitBackend/CMakeLists.txt
  libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp
  libdiscover/backends/PackageKitBackend/PackageKitBackend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, rdieter, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3333: merge

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREEN23006c1b9bc6: merge (authored by sebas).

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D?vs=8078=8079

REVISION DETAIL
  https://phabricator.kde.org/D

AFFECTED FILES
  kded/daemon.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 10 lines] D3333: merge

[Sebastian Kügler]

sebas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  rKSCREEN KScreen

BRANCH
  fixupmodeid

REVISION DETAIL
  https://phabricator.kde.org/D

AFFECTED FILES
  kded/daemon.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129358: Return SurfaceInterface::size in surface normal co-ordinates

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129358/
---

(Updated Nov. 10, 2016, 3:56 p.m.)


Review request for Plasma.


Changes
---

Avoid emitting sizeChanged when we don't have a size or are going to emit it 
twice.


Repository: kwayland


Description
---

Return SurfaceInterface::size in surface normal co-ordinates


Diffs (updated)
-

  src/server/surface_interface.h de74ef336aa7d17c1bd95ba453b8d4f620e416ec 
  src/server/surface_interface.cpp 157907210254c550e85d24eaa19637f933872ea7 

Diff: https://git.reviewboard.kde.org/r/129358/diff/


Testing
---


Thanks,

David Edmundson

[Differential] [Accepted] D3332: Move querying glx extensions into the platform plugin

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-extensions-to-platform

REVISION DETAIL
  https://phabricator.kde.org/D3332

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 64 lines] D3332: Move querying glx extensions into the platform plugin

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  Glx extensions are only interesting to the glxbackend. Given that
  querying can be moved there.
  
  In order to simplify the extensions can be stored in the OpenGLBackend
  which also provides the convenience check as before.
  
  The egl platforms should also be adjusted to query in that way and
  remove it from the kwinglutils.
  
  There is still a usage of the glxextensions inside kwinglutils to
  resolve one function. That should also be moved into the platform.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-extensions-to-platform

REVISION DETAIL
  https://phabricator.kde.org/D3332

AFFECTED FILES
  debug_console.cpp
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  plugins/platforms/x11/standalone/glxbackend.cpp
  plugins/platforms/x11/standalone/glxbackend.h
  scene_opengl.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

[Jiri Tyr]

https://bugs.kde.org/show_bug.cgi?id=357288

--- Comment #8 from Jiri Tyr  ---
I'm suffering from the same issue. The screen power management doesn't work
properly when the screen is locked. This is the log from xset -q:

$ while [ true ]; do echo -n '['$(date +%T)']'; xset -q | grep -A2 Standby |
xargs -I'{}' echo -n ' {};' | sed -r 's/\s+/ /g'; echo -e "\r"; sleep 1; done
# I locked the screen
[13:02:15] Standby: 120 Suspend: 180 Off: 240; DPMS is Enabled; Monitor is On;
...
[13:22:39] Standby: 120 Suspend: 180 Off: 240; DPMS is Enabled; Monitor is On;
[13:22:40] Standby: 120 Suspend: 180 Off: 240; DPMS is Enabled; Monitor is in
Standby;
...
[14:41:52] Standby: 120 Suspend: 180 Off: 240; DPMS is Enabled; Monitor is in
Standby;
# Here I unlocked the screen
[14:41:53] Standby: 120 Suspend: 180 Off: 240; DPMS is Enabled; Monitor is On;
...
[14:42:02] Standby: 120 Suspend: 180 Off: 240; DPMS is Enabled; Monitor is On;
# Flickering between the DPMS is Enabled/Disabled occurs even if the screen is
unlocked
[14:42:03] Standby: 0 Suspend: 0 Off: 0; DPMS is Disabled;
...
[14:42:14] Standby: 0 Suspend: 0 Off: 0; DPMS is Disabled;
[14:42:15] Standby: 120 Suspend: 180 Off: 240; DPMS is Enabled; Monitor is On;
...

It would be really great if this could be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3210#61533, @colomar wrote:
  
  > Whoa okay, that is complex...
  >  Given that I failed to understand what the proposed checkboxes were 
supposed to mean, I fear it will be the same for users.
  >  Therefore maybe not gibing the option at all is indeed the better 
solution, and your suggestion to turn the feature off when animations are 
turned off makes sense to me as well.
  
  
  sorry for the late reply
  ok, so if i understood correctly:
  I'll remove those 2 options, and have instead both showing the scrollbar on 
hover *and* the scrollbar size depend uniquely for the global enabled state of 
animations?

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 58 lines] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 8074.
broulik added a comment.


  Fix import

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3330?vs=8073=8074

REVISION DETAIL
  https://phabricator.kde.org/D3330

AFFECTED FILES
  desktopswitchers/previews/contents/ui/main.qml
  windowswitchers/big_icons/contents/ui/main.qml
  windowswitchers/compact/contents/ui/main.qml
  windowswitchers/informative/contents/ui/main.qml
  windowswitchers/present_windows/contents/ui/main.qml
  windowswitchers/small_icons/contents/ui/main.qml
  windowswitchers/text/contents/ui/main.qml
  windowswitchers/thumbnails/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> main.qml:21-22
>  import QtQuick 2.0
>  import org.kde.plasma.core 2.0 as PlasmaCore
> +import org.kde.plasma.core 2.0 as PlasmaComponents
>  import org.kde.kquickcontrolsaddons 2.0

this looks slightly wrong. Copy and paste error?

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3330

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 58 lines] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, graesslin.
broulik set the repository for this revision to rKDEPLASMAADDONS Plasma Addons.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The former uses native text rendering which respects anti-aliasing and 
hinting settings. It also automatically follows theme colors.
  Unfortunately it breaks the font.bold binding, so using font.weight here 
instead.
  
  BUG: 372218
  FIXED-IN: 5.8.4
  
  CHANGELOG: Font rendering in window/desktop switchers now follows 
anti-aliasing and hinting settings

TEST PLAN
  Verified that all switchers still worked. Also verified that items used 
plasma colortheme (e.g. white text on dark background on Breeze dark) were 
properly bolded (initially / when active / always, depending on the layout) and 
italicized (when minimized).
  
  The QML in there could be significantly cleaned up now that we have 
TextMetrics and Layouts in QML but this code is 5 years old ;)

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3330

AFFECTED FILES
  desktopswitchers/previews/contents/ui/main.qml
  windowswitchers/big_icons/contents/ui/main.qml
  windowswitchers/compact/contents/ui/main.qml
  windowswitchers/informative/contents/ui/main.qml
  windowswitchers/present_windows/contents/ui/main.qml
  windowswitchers/small_icons/contents/ui/main.qml
  windowswitchers/text/contents/ui/main.qml
  windowswitchers/thumbnails/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 23 lines] D3329: Move glx version check functionality to platform plugin

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  Glx version is only required once in the standalone x11 platform. No
  need to have that in the shared kwinglutils library.
  
  Removes one xlib usage from shared kwin.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-version-check-platform

REVISION DETAIL
  https://phabricator.kde.org/D3329

AFFECTED FILES
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  plugins/platforms/x11/standalone/glxbackend.cpp
  plugins/platforms/x11/standalone/glxbackend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

[subdiff (Roman Gilg)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP77463a0143d8: [Touchpad KCM] Prevent save dialog 
if no touchpad was found (authored by subdiff).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3324?vs=8064=8067

REVISION DETAIL
  https://phabricator.kde.org/D3324

AFFECTED FILES
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/kcm/touchpadconfig.cpp
  kcms/touchpad/src/touchpadbackend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, graesslin
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3324

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, graesslin
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 358 lines] D3327: VirtualDesktopGrid operates on VirtualDesktop objects

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, hein.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The VirtualDesktopGrid is ported to the new VirtualDesktop objects. The
  grid consists now of QVector rows and a QVector of
  those rows.
  
  This change requires to adjust the code using the VirtualDesktopGrid.
  This mostly affects VirtualDesktopManger. The methods for toLeft, above,
  next, etc are now all operating on VirtualDesktop with the uint variants
  
  - if still present - only delegating to the new method. The Functor
  
  objects are also adjusted, though mostly still providing the old API for
  compatibility.
  
  In KWin core only one now ambiguous call is adjusted (useractions) and
  the desktop grid usage in EffectsHandlerImpl is adjusted. Other usages
  are not yet adjusted and need porting to fully get rid of the old
  uint-based API.

TEST PLAN
  VD test still passes

REPOSITORY
  rKWIN KWin

BRANCH
  vd-grid

REVISION DETAIL
  https://phabricator.kde.org/D3327

AFFECTED FILES
  autotests/test_virtual_desktops.cpp
  effects.cpp
  useractions.cpp
  virtualdesktops.cpp
  virtualdesktops.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, hein
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Abandoned] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[Martin Gräßlin]

graesslin abandoned this revision.
graesslin added a comment.


  Change is reverted. That just doesn't work with style sheets.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, broulik, hpereiradacosta, #plasma, ivan
Cc: ivan, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 5 lines] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

[subdiff (Roman Gilg)]

subdiff updated this revision to Diff 8064.
subdiff marked an inline comment as done.
subdiff added a comment.


  Adjusted name.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3324?vs=8058=8064

REVISION DETAIL
  https://phabricator.kde.org/D3324

AFFECTED FILES
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/kcm/touchpadconfig.cpp
  kcms/touchpad/src/touchpadbackend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D3319: Load screenpool at the same time as we connect to screenchanged signals

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE7154fb681adc: Load screenpool at the same time 
as we connect to screenchanged signals (authored by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3319?vs=8060=8063

REVISION DETAIL
  https://phabricator.kde.org/D3319

AFFECTED FILES
  shell/autotests/screenpooltest.cpp
  shell/screenpool.cpp
  shell/screenpool.h
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, rwooninck, fvogt, cfeck, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3323: Make it possible for plasmashell to log into kscreen.log

[cfeck (Christoph Feck)]

cfeck added a comment.


  Sorry, my fault. I was completely unaware that Plasma does not even use 
kscreen. Now that I have seen how it works, I am no longer disappointed to not 
find Plasma steps in the kscreen logs.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3323

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, mart
Cc: cfeck, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3319: Load screenpool at the same time as we connect to screenchanged signals

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D3319

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, rwooninck, fvogt, cfeck, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2155: kded: fix up invalid current mode before saving

[Sebastian Kügler]

sebas added a comment.


  Merging it as I've asked for reviews repeatedly but nobody dares. I'm daring!

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2155

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 14 lines] D3319: Load screenpool at the same time as we connect to screenchanged signals

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 8060.
davidedmundson added a comment.


  sort out the unused line

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3319?vs=8041=8060

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D3319

AFFECTED FILES
  shell/autotests/screenpooltest.cpp
  shell/screenpool.cpp
  shell/screenpool.h
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, rwooninck, fvogt, cfeck, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Breeze] [Bug 371422] Breeze-Theme for sddm and Intel Graphics HD 530

[Stefan Schmid]

https://bugs.kde.org/show_bug.cgi?id=371422

Stefan Schmid  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Stefan Schmid  ---
This error only occurs when Qt uses GLES instead of OpenGL.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Abandoned] D3323: Make it possible for plasmashell to log into kscreen.log

[Sebastian Kügler]

sebas abandoned this revision.
sebas added a comment.


  We may already have fixed the most pressing problem needing this, so 
postponing/abandoning it for now.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3323

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, mart
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3319: Load screenpool at the same time as we connect to screenchanged signals

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3319#61870, @fvogt wrote:
  
  > A quick question: This changes what the ScreenPool constructor does, are 
there any potential users of ScreenPool that now miss a call to ->load(), as it 
was done implicitly before? Wouldn't it be safer to call load() in the 
constructor as well?
  
  
  shellcorona should be the only user so far, so that shouldn't be an issue
  even just constructing screenpool later, should be fine

INLINE COMMENTS

> cfeck wrote in screenpool.cpp:37
> This line does nothing. What was the intention?

i guess was to reset it, so would be m_primaryConnector.clear() or something?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3319

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, rwooninck, fvogt, cfeck, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3290: Introduce a VirtualDesktop class

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN4f4d9d5cfe40: Introduce a VirtualDesktop class (authored 
by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3290?vs=7986=8059

REVISION DETAIL
  https://phabricator.kde.org/D3290

AFFECTED FILES
  virtualdesktops.cpp
  virtualdesktops.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, hein
Cc: hein, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas