[Differential] [Closed] D3363: Support interactive window selection through the Platform

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN7b464cf28498: Support interactive window selection 
through the Platform (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3363?vs=8150=8249#toc

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3363?vs=8150=8249

REVISION DETAIL
  https://phabricator.kde.org/D3363

AFFECTED FILES
  killwindow.cpp
  killwindow.h
  platform.cpp
  platform.h
  plugins/platforms/x11/standalone/CMakeLists.txt
  plugins/platforms/x11/standalone/windowselector.cpp
  plugins/platforms/x11/standalone/windowselector.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h
  utils.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3391: [kwinglutils] Drop eglResolveFunctions

[Martin Gräßlin]

graesslin added a dependent revision: D3396: Move querying the egl extensions 
into the AbstractEglBackend.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3391

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 55 lines] D3396: Move querying the egl extensions into the AbstractEglBackend

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Instead of having the egl extensions in the global kwinglutils lib it
  becomes private to the AbstractEglBackend. Just like on glx the
  glxextensions are moved into the platform.
  
  The extensions are queried from initEglAPI, that is as early as possible
  after initializing the EGLDisplay. This ensures that any implementing
  subclass can access the extensions early enough.
  
  As a note: the EglOnXBackend had a potentially wrong sequence for
  initializing the buffer age extension. It is now moved to the correct
  place where the result is needed for the first time.
  
  From the global API eglExtensions are removed from hasGLExtension and
  the eglExtensions function is dropped. As by that initEGL did not do
  anything it is also dropped.

TEST PLAN
  Tested nested kwin on Wayland, still works, extensions shown
  in debug console

REPOSITORY
  rKWIN KWin

BRANCH
  drop-init-egl

REVISION DETAIL
  https://phabricator.kde.org/D3396

AFFECTED FILES
  abstract_egl_backend.cpp
  debug_console.cpp
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  platform.cpp
  plugins/platforms/x11/common/eglonxbackend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

[Zren (Chris Holland)]

Zren added a comment.


  The Instantiator pattern will not work.
  
  https://i.imgur.com/CVKMnnU.png
  
  "content" is PlasmaComponent.ContextMenu's " default property (the list of 
child objects like MenuItem).
  
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmacomponents/qmenu.h#L73

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2314

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Zren, #plasma, #plasma:_design
Cc: davidedmundson, drosca, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

[Elmo R]

https://bugs.kde.org/show_bug.cgi?id=362988

--- Comment #8 from Elmo R  ---
I just tested in Tumbleweed a couple of days ago (OpenSuSE's rolling version)
and the problem of four clicks before "Loading... " freeze per window per
non-cached entry (a place you haven't visited in your previous three clicks)
does not exist.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [Help please] - What is missing in the following QML plugin?

[Aleix Pol]

On Wed, Nov 16, 2016 at 11:20 PM, Michail Vourlakos
 wrote:
> found it...
>
> it needed,
>
> set(CMAKE_AUTOMOC ON)
>
> in CMakeLists.txt
>
>
>
> On 16/11/2016 05:38 μμ, Michail Vourlakos wrote:
>
> Hello everyone,
>
>
> can please help me with this qml plugin? Even though it is compiled and
> installed in the correct path... Trying to use it through a plasma panel by
> calling:
>
> import org.kde.nowdock 0.1
>
>
> creates an error:
>
> "
> file:///usr/share/plasma/plasmoids/org.kde.store.nowdock.panel/contents/ui/main.qml:28:1:
> plugin cannot be loaded for module "org.kde.nowdock": Plugin verification
> data mismatch in '/usr/lib64/qt5/qml/org/kde/nowdock/libnowdockplugin.so'"
>
>
> regards,
>
> michail
>
>

That possibly means you're not integrating properly with ECM, this
should be taken care of.

Aleix

Re: [Help please] - What is missing in the following QML plugin?

[Michail Vourlakos]

found it...

it needed,

set(CMAKE_AUTOMOC ON)

in CMakeLists.txt



On 16/11/2016 05:38 μμ, Michail Vourlakos wrote:


Hello everyone,


can please help me with this qml plugin? Even though it is compiled 
and installed in the correct path... Trying to use it through a plasma 
panel by calling:


import org.kde.nowdock 0.1


creates an error:

"file:///usr/share/plasma/plasmoids/org.kde.store.nowdock.panel/contents/ui/main.qml:28:1: 
plugin cannot be loaded for module "org.kde.nowdock": Plugin 
verification data mismatch in 
'/usr/lib64/qt5/qml/org/kde/nowdock/libnowdockplugin.so'"



regards,

michail

[Differential] [Commented On] D3355: add maskArea in panel view

[mvourlakos (Michail Vourlakos)]

mvourlakos added a comment.


  found it... I had to add,
  
set(CMAKE_AUTOMOC ON)
  
  in CMakeLists.txt

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

[Albert Astals Cid]

El dimecres, 16 de novembre de 2016, a les 10:28:06 CET, Marco Martin va 
escriure:
> On Tuesday 15 November 2016 22:13:07 Albert Astals Cid wrote:
> > > I'm booking the various stuff now, so as usual questions about the
> > > terrible reimbursements.kde.org ...
> > 
> > Ahh, the old let's complain but without any specifics to make sure we
> > motivate people to work on it!
> 
> as concrete suggestion, probably a simple text field when creating the event
> in which one can enter event description (and rules) would help a lot

Isn't that the description field? I see whoever created the event already 
filled it in, no?

Cheers,
  Albert

kirigami meeting for 16 november

[Marco Martin]

Hi all,
we decided to try to reinstate weekly meetings about kirigami 
with me, Aleix and Thomas present, discussion went mostly about Kirigami2 
work:
* last week kirigami2 got a separed namespace (import org.kde.kirigami 2.0)
* kirigami 1 and 2 should co-install without conflicts (still needing more 
thorough testing)
* api is pretty much done
* identifying a release date for kirigami2
* getting some test application ported to kirigami2 (test case: discover)
* early ported applications would be used to iron out problems

updates on this, on next meeting (and, if a tentative release date surfaces), 
on next wednesday, 19:00 CEST

-- 
Marco Martin

[Differential] [Updated] D3391: [kwinglutils] Drop eglResolveFunctions

[Martin Gräßlin]

graesslin added a dependency: D3390: [kwinglutils] Drop hasEGLVersion function.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3391

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3390: [kwinglutils] Drop hasEGLVersion function

[Martin Gräßlin]

graesslin added a dependent revision: D3391: [kwinglutils] Drop 
eglResolveFunctions.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3390

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 7 lines] D3391: [kwinglutils] Drop eglResolveFunctions

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Method doesn't do anything. If at some point we want to resolve egl
  functions again, it should be done in the Platform, just like
  glxResolveFunctions is nowadays done in the platform.

REPOSITORY
  rKWIN KWin

BRANCH
  drop-eglResolveRunctions

REVISION DETAIL
  https://phabricator.kde.org/D3391

AFFECTED FILES
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils_funcs.cpp
  libkwineffects/kwinglutils_funcs.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 12 lines] D3390: [kwinglutils] Drop hasEGLVersion function

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  It's unused in KWin and absolutely not needed as the call to
  eglInitialize, which every platform does, also gives the version for
  free. So no need to do any caching in a global method.

REPOSITORY
  rKWIN KWin

BRANCH
  drop-hasEGLVersion

REVISION DETAIL
  https://phabricator.kde.org/D3390

AFFECTED FILES
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng closed this revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng updated the summary for this revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng updated the summary for this revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D3337: Remove KWin::display from kwinglobals

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN346619aa36c3: Remove KWin::display from kwinglobals 
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3337?vs=8086=8233

REVISION DETAIL
  https://phabricator.kde.org/D3337

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/mock_effectshandler.h
  autotests/test_client_machine.cpp
  autotests/test_screen_edges.cpp
  autotests/test_xcb_size_hints.cpp
  autotests/test_xcb_window.cpp
  autotests/test_xcb_wrapper.cpp
  kcmkwin/kwinrules/main.cpp
  libkwineffects/CMakeLists.txt
  libkwineffects/kwinglobals.h
  main_x11.cpp
  plugins/platforms/x11/common/eglonxbackend.cpp
  plugins/platforms/x11/common/eglonxbackend.h
  plugins/platforms/x11/standalone/glxbackend.cpp
  plugins/platforms/x11/standalone/glxbackend.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h
  plugins/platforms/x11/standalone/xinputintegration.cpp
  plugins/platforms/x11/standalone/xinputintegration.h
  tests/screenedgeshowtest.cpp
  utils.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3379: Add a keyboard tab to the debug console

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN327ccffcf477: Add a keyboard tab to the debug console 
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3379?vs=8207=8234

REVISION DETAIL
  https://phabricator.kde.org/D3379

AFFECTED FILES
  debug_console.cpp
  debug_console.h
  debug_console.ui
  keyboard_input.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts

[Differential] [Closed] D3336: Pass function ptr to resolve glFunctions to initGL

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINd7fa82764487: Pass function ptr to resolve glFunctions to 
initGL (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3336?vs=8200=8232

REVISION DETAIL
  https://phabricator.kde.org/D3336

AFFECTED FILES
  abstract_egl_backend.cpp
  libkwineffects/CMakeLists.txt
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  libkwineffects/kwinglutils_funcs.cpp
  libkwineffects/kwinglutils_funcs.h
  plugins/platforms/x11/standalone/glxbackend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts

[Differential] [Commented On] D3379: Add a keyboard tab to the debug console

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3379#63250, @sebas wrote:
  
  > Ordering looks a bit random, perhaps group the input-related tabs?
  
  
  yes sure it's random by me adding new tabs always at the end ;-) Not sure 
whether we really need to reorder as it's just a debug tool...

REPOSITORY
  rKWIN KWin

BRANCH
  debug-console-keyboard-tab

REVISION DETAIL
  https://phabricator.kde.org/D3379

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts

[Differential] [Accepted] D3367: [effects] Add interactive window selection mode to ScreenshotEffect

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> screenshot.h:58
> +/**
> + * Starts an interactive window screenshot session. The user can select 
> a window for
> + * screenshot.

... a window to screenshot.

REPOSITORY
  rKWIN KWin

BRANCH
  screenshot-interactive-selection

REVISION DETAIL
  https://phabricator.kde.org/D3367

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts

[Differential] [Accepted] D3379: Add a keyboard tab to the debug console

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.


  Ordering looks a bit random, perhaps group the input-related tabs?

REPOSITORY
  rKWIN KWin

BRANCH
  debug-console-keyboard-tab

REVISION DETAIL
  https://phabricator.kde.org/D3379

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts

[Differential] [Accepted] D3365: Implement interactive window selection for Wayland platforms

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  interactive-window-selection-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3363: Support interactive window selection through the Platform

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  interactive-window-selection

REVISION DETAIL
  https://phabricator.kde.org/D3363

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Help please] - What is missing in the following QML plugin?

[Michail Vourlakos]

Hello everyone,


can please help me with this qml plugin? Even though it is compiled and 
installed in the correct path... Trying to use it through a plasma panel 
by calling:


import org.kde.nowdock 0.1


creates an error:

"file:///usr/share/plasma/plasmoids/org.kde.store.nowdock.panel/contents/ui/main.qml:28:1: 
plugin cannot be loaded for module "org.kde.nowdock": Plugin 
verification data mismatch in 
'/usr/lib64/qt5/qml/org/kde/nowdock/libnowdockplugin.so'"



regards,

michail



libnowdock.tar.gz
Description: application/gzip

[Differential] [Accepted] D3336: Pass function ptr to resolve glFunctions to initGL

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.


  nice, much cleaner that way.

REPOSITORY
  rKWIN KWin

BRANCH
  initgl-with-resolve-function

REVISION DETAIL
  https://phabricator.kde.org/D3336

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts

[Differential] [Accepted] D3295: [server] Reduce overhead of pointersForSurface

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  pointers-for-surface-overhead

REVISION DETAIL
  https://phabricator.kde.org/D3295

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129358: Return SurfaceInterface::size in global compositor space

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129358/
---

(Updated Nov. 16, 2016, 3:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 49cbe7b23c54352e84ef127961a0d3123e3ef2f6 by David 
Edmundson to branch master.


Repository: kwayland


Description
---

Return SurfaceInterface::size in global compositor space;
i.e the buffer is divided by the scale factor to give a device independent size


Diffs
-

  autotests/client/test_wayland_surface.cpp 
d13db9a8f52a2aebf656f6770c761850a078dad5 
  src/server/surface_interface.h de74ef336aa7d17c1bd95ba453b8d4f620e416ec 
  src/server/surface_interface.cpp 157907210254c550e85d24eaa19637f933872ea7 

Diff: https://git.reviewboard.kde.org/r/129358/diff/


Testing
---


Thanks,

David Edmundson

Re: Review Request 129358: Return SurfaceInterface::size in global compositor space

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129358/#review100881
---


Ship it!




Ship It!

- Martin Gräßlin


On Nov. 16, 2016, 3:25 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129358/
> ---
> 
> (Updated Nov. 16, 2016, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> Return SurfaceInterface::size in global compositor space;
> i.e the buffer is divided by the scale factor to give a device independent 
> size
> 
> 
> Diffs
> -
> 
>   autotests/client/test_wayland_surface.cpp 
> d13db9a8f52a2aebf656f6770c761850a078dad5 
>   src/server/surface_interface.h de74ef336aa7d17c1bd95ba453b8d4f620e416ec 
>   src/server/surface_interface.cpp 157907210254c550e85d24eaa19637f933872ea7 
> 
> Diff: https://git.reviewboard.kde.org/r/129358/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Closed] D3384: Drop EffectsHandler::effectsConfig

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN1c819c5e86bc: Drop EffectsHandler::effectsConfig 
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3384?vs=8218=8225

REVISION DETAIL
  https://phabricator.kde.org/D3384

AFFECTED FILES
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3383: Use KWin's KSharedConfigPtr in ScriptedEffect

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINaf83401b838f: Use KWin's KSharedConfigPtr in 
ScriptedEffect (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3383?vs=8217=8224

REVISION DETAIL
  https://phabricator.kde.org/D3383

AFFECTED FILES
  autotests/integration/effects/translucency_test.cpp
  scripting/scriptedeffect.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 129358: Return SurfaceInterface::size in global compositor space

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129358/
---

(Updated Nov. 16, 2016, 2:25 p.m.)


Review request for Plasma.


Summary (updated)
-

Return SurfaceInterface::size in global compositor space


Repository: kwayland


Description (updated)
---

Return SurfaceInterface::size in global compositor space;
i.e the buffer is divided by the scale factor to give a device independent size


Diffs (updated)
-

  autotests/client/test_wayland_surface.cpp 
d13db9a8f52a2aebf656f6770c761850a078dad5 
  src/server/surface_interface.h de74ef336aa7d17c1bd95ba453b8d4f620e416ec 
  src/server/surface_interface.cpp 157907210254c550e85d24eaa19637f933872ea7 

Diff: https://git.reviewboard.kde.org/r/129358/diff/


Testing
---


Thanks,

David Edmundson

[Differential] [Commented On] D3355: add maskArea in panel view

[mvourlakos (Michail Vourlakos)]

mvourlakos added a comment.


  In https://phabricator.kde.org/D3355#63086, @mart wrote:
  
  > only advice i can give is, don't get discouraged :)
  
  
  I am... :) but we will see...
  I tried to create my own libnowdock in order to follow your suggestions
  
  F510151: libnowdock.tar.gz 
  
  but by trying to use it in my qml with:
  import org.kde.nowdock 0.1
  
  I get the following error:
  
  > 
file:///usr/share/plasma/plasmoids/org.kde.store.nowdock.panel/contents/ui/main.qml:28:1:
 plugin cannot be loaded for module "org.kde.nowdock": Plugin verification data 
mismatch in '/usr/lib64/qt5/qml/org/kde/nowdock/libnowdockplugin.so'
  
  do you have any ideas?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3385: Remove unused method

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN9a582f6dbeac: Remove unused method (authored by 
davidedmundson).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3385?vs=8219=8221

REVISION DETAIL
  https://phabricator.kde.org/D3385

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_backend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3385: Remove unused method

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3385

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3376: [effects] Show a notification when a screenshot got saved to file

[andreaska (Andreas Kainz)]

andreaska added a comment.


  I think so to, use the spectacle icon as it is now.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3376

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, #vdg, mart
Cc: andreaska, mart, andreask, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas

[Differential] [Request, 9 lines] D3385: Remove unused method

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  This isn't used and if it was would give the wrong value.
  Actual correct size can be determined via Screens object.

TEST PLAN
  Grepped it's not overriding anything
  Compiles

REPOSITORY
  rKWIN KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3385

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_backend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3384: Drop EffectsHandler::effectsConfig

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  drop-effects-config

REVISION DETAIL
  https://phabricator.kde.org/D3384

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3384: Drop EffectsHandler::effectsConfig

[Martin Gräßlin]

graesslin added a dependency: D3383: Use KWin's KSharedConfigPtr in 
ScriptedEffect.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3384

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 11 lines] D3384: Drop EffectsHandler::effectsConfig

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The effectsConfig is no longer used by any Effect. ScriptedEffects use
  KWin's KSharedConfigPtr and the builtin effects all have a kcfg with
  kwinrc being hard coded.
  
  The effectsConfig had the big disadvantage that it hardcoded kwinrc
  while the rest of kwin uses a KSharedConfigPtr which might not point to
  kwinrc.

REPOSITORY
  rKWIN KWin

BRANCH
  drop-effects-config

REVISION DETAIL
  https://phabricator.kde.org/D3384

AFFECTED FILES
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3383: Use KWin's KSharedConfigPtr in ScriptedEffect

[Martin Gräßlin]

graesslin added a dependent revision: D3384: Drop EffectsHandler::effectsConfig.

REPOSITORY
  rKWIN KWin

BRANCH
  scripted-effect-ksharedconfig

REVISION DETAIL
  https://phabricator.kde.org/D3383

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3383: Use KWin's KSharedConfigPtr in ScriptedEffect

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  scripted-effect-ksharedconfig

REVISION DETAIL
  https://phabricator.kde.org/D3383

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 6 lines] D3383: Use KWin's KSharedConfigPtr in ScriptedEffect

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  So far ScriptedEffect used EffectsHandler::effectConfig to get the
  KConfigGroup for the ScriptedEffect. This has the disadvantage that the
  config file name is hardcoded to kwinrc in EffectsHandler::effectConfig.
  
  Inside KWin a KSharedConfigPtr is used which can point to somwhere else
  than kwinrc. If that was the case the ScriptedEffects were not able to
  pick up this customized config and instead continued to read values from
  kwinrc.
  
  With this change the ScriptedEffects use the KSharedConfigPtr provided
  by KWin. Thus in e.g. autotests we can use the general way to configure
  the effects and don't need to write to the config.

REPOSITORY
  rKWIN KWin

BRANCH
  scripted-effect-ksharedconfig

REVISION DETAIL
  https://phabricator.kde.org/D3383

AFFECTED FILES
  autotests/integration/effects/translucency_test.cpp
  scripting/scriptedeffect.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3376: [effects] Show a notification when a screenshot got saved to file

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINadfaac4d6033: [effects] Show a notification when a 
screenshot got saved to file (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3376?vs=8201=8212#toc

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3376?vs=8201=8212

REVISION DETAIL
  https://phabricator.kde.org/D3376

AFFECTED FILES
  effects/CMakeLists.txt
  effects/screenshot/screenshot.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, #vdg, mart
Cc: mart, andreask, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3374: [effects] Introduce kcfg for FallApart effect

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN10f641d5d969: [effects] Introduce kcfg for FallApart 
effect (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3374?vs=8195=8211

REVISION DETAIL
  https://phabricator.kde.org/D3374

AFFECTED FILES
  effects/CMakeLists.txt
  effects/fallapart/fallapart.cpp
  effects/fallapart/fallapart.kcfg
  effects/fallapart/fallapartconfig.kcfgc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3376: [effects] Show a notification when a screenshot got saved to file

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> screenshot.cpp:249
> +i18nc("Notification caption that a screenshot got 
> saved to file", "Screenshot"),
> +i18nc("Notification with path to screenshot file", 
> "Screenshot saved to %1", temp.fileName()),
> +QStringLiteral("spectacle"));

I think for this thing, spectacle is the right icon, as it's the only thing 
that is presented to the user "this makes a screenshot"

REPOSITORY
  rKWIN KWin

BRANCH
  screenshot-show-notification

REVISION DETAIL
  https://phabricator.kde.org/D3376

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, #vdg, mart
Cc: mart, andreask, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3374: [effects] Introduce kcfg for FallApart effect

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  fall-apart-kcfgc

REVISION DETAIL
  https://phabricator.kde.org/D3374

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3375: [effects] Introduce kcfg for SlidingPopups

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  slidingpopups-kcfgc

REVISION DETAIL
  https://phabricator.kde.org/D3375

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3370: KillWindow support for Wayland windows

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  kill-window-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3370

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: cfeck, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

Re: Review Request 129412: Fix an issue with the `wifi-setup` script for plasma mobile, where certain psk's are not properly added with `nmcli`

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129412/#review100873
---



Thanks for patch, I've submitted it and will be available when 
plasma-phone-settings get rebuilt next.

- Bhushan Shah


On Nov. 16, 2016, 4:38 p.m., Konrad Feldmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129412/
> ---
> 
> (Updated Nov. 16, 2016, 4:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-phone-settings
> 
> 
> Description
> ---
> 
> Fix wifi-setup fails when psk contains spaces
> 
> Given a wifi password such as `this is my psk`, prior to this
> change `wifi-setup` sent the command:
> 
> nmcli c modify MYSSID wifi-sec.psk this is my psk
> 
> which would fail with a complaint about `this` not being a valid psk.
> 
> 
> Diffs
> -
> 
>   usr/bin/wifi-setup a2dac78 
> 
> Diff: https://git.reviewboard.kde.org/r/129412/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Konrad Feldmeier
> 
>

Re: Review Request 129412: Fix an issue with the `wifi-setup` script for plasma mobile, where certain psk's are not properly added with `nmcli`

[Konrad Feldmeier]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129412/
---

(Updated Nov. 16, 2016, 6:08 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c844d95baa920f9558c3e41d7b3bf20e7ba3241b by Bhushan Shah 
on behalf of Konrad Feldmeier to branch master.


Repository: plasma-phone-settings


Description
---

Fix wifi-setup fails when psk contains spaces

Given a wifi password such as `this is my psk`, prior to this
change `wifi-setup` sent the command:

nmcli c modify MYSSID wifi-sec.psk this is my psk

which would fail with a complaint about `this` not being a valid psk.


Diffs
-

  usr/bin/wifi-setup a2dac78 

Diff: https://git.reviewboard.kde.org/r/129412/diff/


Testing
---


Thanks,

Konrad Feldmeier

[Differential] [Commented On] D3355: add maskArea in panel view

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3355#62820, @mvourlakos wrote:
  
  > I can understand the concerns but being honest... I think that this is a 
lot above my programming expertise and taking the fact how many things must be 
adjusted by the fact that this is going to be a fake panel above a real panel, 
it looks enormous and advance for me... Exhausted only to think it...
  >
  > I will probably leave it that way if anyone wants to try any future 
roadmaps...
  
  
  only advice i can give is, don't get discouraged :)
  
  btw, i tried to hack up very quickly something
  http://notmart.org/misc/org.kde.hackypanel.tar.bz2
  
  and seems to work quite good, even if not perfect
  the advantage is that would use all the native controls for sizing the panel, 
sizing the icons in the panel etc, the bigger window would just be a 
presentation

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129412: Fix an issue with the `wifi-setup` script for plasma mobile, where certain psk's are not properly added with `nmcli`

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129412/#review100872
---


Ship it!




Ship It!

- Bhushan Shah


On Nov. 16, 2016, 3:50 p.m., Konrad Feldmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129412/
> ---
> 
> (Updated Nov. 16, 2016, 3:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-phone-settings
> 
> 
> Description
> ---
> 
> Fix wifi-setup fails when psk contains spaces
> 
> Given a wifi password such as `this is my psk`, prior to this
> change `wifi-setup` sent the command:
> 
> nmcli c modify MYSSID wifi-sec.psk this is my psk
> 
> which would fail with a complaint about `this` not being a valid psk.
> 
> 
> Diffs
> -
> 
>   usr/bin/wifi-setup a2dac78 
> 
> Diff: https://git.reviewboard.kde.org/r/129412/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Konrad Feldmeier
> 
>

[Differential] [Closed] D3378: default to no arrows

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rBREEZEa9d954682f09: default to no arrows (authored by mart).

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3378?vs=8206=8208

REVISION DETAIL
  https://phabricator.kde.org/D3378

AFFECTED FILES
  kstyle/breeze.kcfg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3379: Add a keyboard tab to the debug console

[Martin Gräßlin]

graesslin added a comment.


  F509791: kwin_screenshot_PA1402.png 

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3379

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 200 lines] D3379: Add a keyboard tab to the debug console

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  A little bit debug information about the current keyboard state is
  useful. Thus a new tab is added to show information about xkbcommon.
  
  It shows:
  
  - layouts in the keymap
  - currently active layout
  - supported modifiers in key map
  - currently active modifiers in state
  - supported leds in key map
  - currently active leds in state
  
  Whenever a key is pressed/released the complete ui is updated to reflect
  the latest state. That is pressing/releasing a modifier is directly
  reflected in the ui.
  
  This UI can extended as needed for further debug information about the
  keymap state.

REPOSITORY
  rKWIN KWin

BRANCH
  debug-console-keyboard-tab

REVISION DETAIL
  https://phabricator.kde.org/D3379

AFFECTED FILES
  debug_console.cpp
  debug_console.h
  debug_console.ui
  keyboard_input.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3378: default to no arrows

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks !

REPOSITORY
  rBREEZE Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3378

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 129412: Fix an issue with the `wifi-setup` script for plasma mobile, where certain psk's are not properly added with `nmcli`

[Konrad Feldmeier]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129412/
---

Review request for Plasma.


Repository: plasma-phone-settings


Description
---

Fix wifi-setup fails when psk contains spaces

Given a wifi password such as `this is my psk`, prior to this
change `wifi-setup` sent the command:

nmcli c modify MYSSID wifi-sec.psk this is my psk

which would fail with a complaint about `this` not being a valid psk.


Diffs
-

  usr/bin/wifi-setup a2dac78 

Diff: https://git.reviewboard.kde.org/r/129412/diff/


Testing
---


Thanks,

Konrad Feldmeier

[Differential] [Updated] D3378: default to no arrows

[mart (Marco Martin)]

mart added reviewers: hpereiradacosta, VDG.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3378

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, hpereiradacosta, #vdg
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D3378: default to no arrows

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  as the last part of the new design, try to not have arrows
  in the scrollbars by default (just change of default,
  all the functionality is there)

TEST PLAN
  default is correctly picked up

REPOSITORY
  rBREEZE Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3378

AFFECTED FILES
  kstyle/breeze.kcfg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3210: make scrollbar size configurable

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rBREEZE850ed6dd0a77: make scrollbar size configurable 
(authored by mart).

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3210?vs=8204=8205

REVISION DETAIL
  https://phabricator.kde.org/D3210

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 46 lines] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart updated this revision to Diff 8204.
mart added a comment.


  - Merge branch 'master' into arcpatch-D3210

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3210?vs=8202=8204

BRANCH
  arcpatch-D3210

REVISION DETAIL
  https://phabricator.kde.org/D3210

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 45 lines] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart updated this revision to Diff 8202.
mart added a comment.


  - move the metrics back to the breeze.h header

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3210?vs=8152=8202

BRANCH
  arcpatch-D3210

REVISION DETAIL
  https://phabricator.kde.org/D3210

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3372: Remove Webkit usage in potd data engine.

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks a lot for taking care of this so quickly!
  
  I can confirm that both NOAA and NatGeo still work with this change.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

[Marco Martin]

On Tuesday 15 November 2016 20:33:45 Lydia Pintscher wrote:
> Use the regular price it gives you now if possible.
> 
> > accomodation: do we have to put that in the reimbursment app as well?
> > (if so i guess just half of us would need to if we take all doubles)
> 
> If you pay it individually then yes. If it is a group booking that the
> board approved separately with the sprint organizer then no.

how is in this case? Kai Uwe?

-- 
Marco Martin

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

[Marco Martin]

On Tuesday 15 November 2016 22:13:07 Albert Astals Cid wrote:
> > I'm booking the various stuff now, so as usual questions about the
> > terrible reimbursements.kde.org ...
> 
> Ahh, the old let's complain but without any specifics to make sure we
> motivate people to work on it!

as concrete suggestion, probably a simple text field when creating the event in 
which one can enter event description (and rules) would help a lot

-- 
Marco Martin

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

[Toralf Förster]

https://bugs.kde.org/show_bug.cgi?id=362988

--- Comment #7 from Toralf Förster  ---
(In reply to Toralf Förster from comment #4)
> https://git.reviewboard.kde.org/r/129134/diff/1#index_header

had to apply this to 16.08.3 again - so it is not in mainline currently, right
?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Accepted] D3210: make scrollbar size configurable

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  As far as I am concern,  I think we are safe: new design, but same 
functionality. I am ready to answer bug reports and justify the change if 
needed. And if there are two many complains, we can re-introduce the large 
scrollbars later. Last comment before ship-it: please move scrollBar_Extend and 
company back to Breeze::Metrics and remove the now unnecessary methods from 
Breeze::Helper. 
  Note that I can also do it myself once this is committed, if it is too much 
of a hassle.
  
  Hugo

REPOSITORY
  rBREEZE Breeze

BRANCH
  arcpatch-D3210

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D3376: [effects] Show a notification when a screenshot got saved to file

[Martin Gräßlin]

graesslin added a subscriber: andreask.
graesslin added a comment.


  @andreask do we have an icon action/screenshot or something like that?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3376

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, #vdg
Cc: andreask, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Request, 9 lines] D3376: [effects] Show a notification when a screenshot got saved to file

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, VDG.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Inform the user about the path to where a screenshot got saved through a
  notification. This is helpful on the one hand that the user sees that
  the screenshot got saved and from a security perspective that the user
  is informed when a screenshot is taken through the dbus interface. It
  doesn't prevent non-authorized screenshot taking, but at least the user
  is informed about it.

REPOSITORY
  rKWIN KWin

BRANCH
  screenshot-show-notification

REVISION DETAIL
  https://phabricator.kde.org/D3376

AFFECTED FILES
  effects/CMakeLists.txt
  effects/screenshot/screenshot.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, #vdg
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3336: Pass function ptr to resolve glFunctions to initGL

[Martin Gräßlin]

graesslin marked an inline comment as done.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3336

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 64 lines] D3336: Pass function ptr to resolve glFunctions to initGL

[Martin Gräßlin]

graesslin updated this revision to Diff 8200.
graesslin added a comment.


  Removed outdated comment

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3336?vs=8085=8200

BRANCH
  initgl-with-resolve-function

REVISION DETAIL
  https://phabricator.kde.org/D3336

AFFECTED FILES
  abstract_egl_backend.cpp
  libkwineffects/CMakeLists.txt
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  libkwineffects/kwinglutils_funcs.cpp
  libkwineffects/kwinglutils_funcs.h
  plugins/platforms/x11/standalone/glxbackend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3296: [effects] Improve interaction between Glide and SlidingPopups effect

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN40ad7ef4e953: [effects] Improve interaction between Glide 
and SlidingPopups effect (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3296?vs=7977=8197

REVISION DETAIL
  https://phabricator.kde.org/D3296

AFFECTED FILES
  effects/glide/glide.cpp
  effects/glide/glide.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3335: Move resolving glxSwapIntervalMesa into platform plugin

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINfeac312ee020: Move resolving glxSwapIntervalMesa into 
platform plugin (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3335?vs=8084=8199

REVISION DETAIL
  https://phabricator.kde.org/D3335

AFFECTED FILES
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  libkwineffects/kwinglutils_funcs.cpp
  libkwineffects/kwinglutils_funcs.h
  plugins/platforms/x11/standalone/glxbackend.cpp
  plugins/platforms/x11/standalone/glxbackend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3297: [libkwineffects] Remove EffectsHandler::registerPropertyType

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN4783e45ab76a: [libkwineffects] Remove 
EffectsHandler::registerPropertyType (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3297?vs=7978=8198#toc

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3297?vs=7978=8198

REVISION DETAIL
  https://phabricator.kde.org/D3297

AFFECTED FILES
  autotests/mock_effectshandler.h
  effects.h
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 31 lines] D3375: [effects] Introduce kcfg for SlidingPopups

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Uses the normal animationTime kcfg settings.

REPOSITORY
  rKWIN KWin

BRANCH
  slidingpopups-kcfgc

REVISION DETAIL
  https://phabricator.kde.org/D3375

AFFECTED FILES
  effects/CMakeLists.txt
  effects/slidingpopups/slidingpopups.cpp
  effects/slidingpopups/slidingpopups.kcfg
  effects/slidingpopups/slidingpopupsconfig.kcfgc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas