[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=373668

Kai Uwe Broulik  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||k...@privat.broulik.de
 Resolution|--- |DUPLICATE

--- Comment #1 from Kai Uwe Broulik  ---


*** This bug has been marked as a duplicate of bug 370220 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

[Pavel]

https://bugs.kde.org/show_bug.cgi?id=366299

--- Comment #6 from Pavel  ---
(In reply to Wolfgang Bauer from comment #5)
> (In reply to Pavel from comment #4)
> > but as far as I remember, there was a scrollbar on the right side
> > of the window, so I was able to scroll the frame with settings controls by
> > using this scrollbar or using touch pad with multi-touch option. But I don't
> > see this scrollbar at the moment and area with controls is not scrollable at
> > all. 
> 
> I don't remember if this is true (as I personally never use this these
> settings, or run kcmshell5 manually), but it doesn't matter anyway.
> 
> For now, just open the settings in systemsettings5 ("Configure Desktop" in
> openSUSE), and they will have the scrollbar if the display is too small.
Main settings window has scrollbar, but Power Manager settings window - hasn't 

> Or use the previously mentioned workaround: Press and hold the 'Alt' key and
> click on the window (and hold the mouse button), this way you can move it
> wherever you want and be able to reach the buttons or other options.
Yes, I know about it and I'm using it. This feature one of the best in Linux
DEs :) Sometimes I need it in Windows, but unfortunately, it hasn't such
feature.

Thank you for the reply.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 373668] New: Tiny keyboard layout indicator is the Lock Screen

[Anton]

https://bugs.kde.org/show_bug.cgi?id=373668

Bug ID: 373668
   Summary: Tiny keyboard layout indicator is the Lock Screen
   Product: Breeze
   Version: 5.8.4
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: anton.b...@gmail.com
  Target Milestone: ---

I was absolutely sure that the indicator is not there at all. It is almost
invisible in that left button corner, especially on big screen monitors.

Please move it back, next to login buttons.

p.s. There are few false positive bug reports already and I almost filled a new
one:
 https://bugs.kde.org/show_bug.cgi?id=370220

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=366299

--- Comment #5 from Wolfgang Bauer  ---
(In reply to Pavel from comment #4)
> but as far as I remember, there was a scrollbar on the right side
> of the window, so I was able to scroll the frame with settings controls by
> using this scrollbar or using touch pad with multi-touch option. But I don't
> see this scrollbar at the moment and area with controls is not scrollable at
> all. 

I don't remember if this is true (as I personally never use this these
settings, or run kcmshell5 manually), but it doesn't matter anyway.

For now, just open the settings in systemsettings5 ("Configure Desktop" in
openSUSE), and they will have the scrollbar if the display is too small.

Or use the previously mentioned workaround: Press and hold the 'Alt' key and
click on the window (and hold the mouse button), this way you can move it
wherever you want and be able to reach the buttons or other options.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Requested Changes To] D2687: [Icon Widget] Bring back properties dialog

[dfaure (David Faure)]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> iconapplet.cpp:242
> +{
> +new KRun(QUrl::fromLocalFile(m_localPath), nullptr);
> +}

Just wondering, why is the parent widget nullptr here, while it's 
QApplication::desktop() in other code further down? Not that it changes 
anything at runtime, I suppose.

> iconapplet.cpp:268
> +
> +const QString  = m_url.toLocalFile();
> +

This variable name confused me. It's called "something URL" but it's not a URL, 
it's a local path.

> iconapplet.cpp:306
> +foreach (const QUrl , urls) {
> +params.append(url.toString());
> +}

This for loop can be written in one line with

  const QStringList params = QUrl::toStringList(urls);

(I added that to QUrl for Qt 5.1)

> iconapplet.cpp:309
> +
> +QProcess::startDetached(m_url.path(), params);
> +

Surely this should be m_url.toLocalFile() ?

(only makes a difference on Windows, but it's the right method for getting a 
local path out of a URL)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129308: Calendar: clear selection on opening

[David Edmundson]

> On Nov. 2, 2016, 2:49 p.m., David Edmundson wrote:
> > do you have commit access?
> 
> Miklós Máté wrote:
> I don't have commit access.
> 
> Miklós Máté wrote:
> I noticed that this hasn't been committed yet. Is there something wrong 
> with the patch?

Done, sorry about that. Thanks for the patch.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100506
---


On Dec. 14, 2016, 11:15 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Dec. 14, 2016, 11:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/
---

(Updated Dec. 14, 2016, 11:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c30edd9bedfd13459eecdf110fcb61d8f465523a by David 
Edmundson on behalf of Miklós Máté to branch Plasma/5.8.


Repository: plasma-workspace


Description
---

When opening the calendar popup of the digital clock plasmoid, the selection is 
on the day the popup was last opened -- possibly days or weeks ago. This patch 
fixes that.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 

Diff: https://git.reviewboard.kde.org/r/129308/diff/


Testing
---


Thanks,

Miklós Máté

[Differential] [Updated, 9 lines] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

[subdiff (Roman Gilg)]

subdiff updated this revision to Diff 9025.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3667?vs=9024=9025

REVISION DETAIL
  https://phabricator.kde.org/D3667

AFFECTED FILES
  dataengines/mpris2/playercontainer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: davidedmundson, broulik, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 129308: Calendar: clear selection on opening

[Miklós Máté]

> On Nov. 2, 2016, 3:49 p.m., David Edmundson wrote:
> > do you have commit access?
> 
> Miklós Máté wrote:
> I don't have commit access.

I noticed that this hasn't been committed yet. Is there something wrong with 
the patch?


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100506
---


On Nov. 2, 2016, 1:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 1:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

[Differential] [Updated, 6 lines] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

[subdiff (Roman Gilg)]

subdiff updated this revision to Diff 9024.
subdiff added a comment.


  Using David's superior method. With this method it's also possible to have in 
the VLC case, where they don't append the pid, atleast the one controllable 
media player instance identified.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3667?vs=8974=9024

REVISION DETAIL
  https://phabricator.kde.org/D3667

AFFECTED FILES
  dataengines/mpris2/playercontainer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: davidedmundson, broulik, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

[franckarrecot (Franck Arrecot)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:cd78b8ca4926: Make kirigami.qrc ressource path relative 
to CMAKE_CURRENT_SOURCE_DIR (authored by franckarrecot).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3649?vs=8937=9019

REVISION DETAIL
  https://phabricator.kde.org/D3649

AFFECTED FILES
  src/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: franckarrecot, mart, apol
Cc: apol, plasma-devel

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

[Pavel]

https://bugs.kde.org/show_bug.cgi?id=366299

Pavel  changed:

   What|Removed |Added

 CC||zol...@gmail.com

--- Comment #4 from Pavel  ---
I don't remember whether power management settings was fit to window height (in
case if we are talking about low screen resolution, for me it is 1366x768), but
as far as I remember, there was a scrollbar on the right side of the window, so
I was able to scroll the frame with settings controls by using this scrollbar
or using touch pad with multi-touch option. But I don't see this scrollbar at
the moment and area with controls is not scrollable at all. 
OpenSUSE Tumbleweed x64, Plasma 5.8.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > use apparmor at some future point
  
  and from what I understand DBus access can be restricted on a 
per-interface/service basis with that? Dunno if it can do wildcards, though.
  
  > Kai, can you expand on your use cases
  
  At Randa I was listening to music, then when I locked my screen to get some 
more coffee, I always forgot to pause my music and since Plasma encourages you 
to be lazy usually, that's when I really wanted that feature and even built a 
hack into media controller applet for the rest of the week.
  
  > I think after a suspend movie should always be paused
  
  I like that, what about me adding a checkbox to PowerDevil to have it pause 
music on suspend? That would fix [1] (I know we forward media keys but I still 
liked that scene in that video).
  
  [1] https://www.youtube.com/watch?v=cQoQE_HDG8g=32m6s

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: oliverhenshaw, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[Martin Gräßlin]

graesslin added a comment.


  > Having the movie contiue before you've logged back in is a state I've been 
in.
  
  Arguable that could also be handled by the media players by doing a temp 
inhibit to pause the movie. But yes that makes sense, but maybe more in 
powermanagement than in lock screen. I think after a suspend movie should 
always be paused, whether the screen is locked or not.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: oliverhenshaw, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  > But for the sake of argument let's assume the usecase is valid.
  
  No assumption is needed, it *is* valid. Assuming you have lock on suspend, 
which is the default:
  
  Case 1:
  You run out of power.
  
  Case 2:
  You close the lid
  
  Having the movie contiue before you've logged back in is a state I've been in.
  
  Separate video/audio settings is a good comment though.
  
  Kai, can you expand on your use cases, especially as it's an RFC, you need to 
have a much longer description than a title. 
  I'm having to guess what problem you were solving, which probably means 
everyone else is too.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: oliverhenshaw, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[Martin Gräßlin]

graesslin added a comment.


  > So, about proper media controls, would re-using the mpris data engine in 
Plasma from QML be an option or should it rather be some implementation in 
ksldapp given you wanted to disable dbus access for the locker?
  
  reusing the existing engine is fine. For disabling dbus access I rather hope 
that we can use apparmor at some future point and lock with that.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: oliverhenshaw, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3674#68838, @davidedmundson wrote:
  
  > > The feature like that doesn't make sense IMHO.
  >
  > Why?
  >
  > Media controls doesn't help with this usecase. You come back, you press 
resume, your movie resumes...whilst your screen is still locked.
  
  
  Video should inhibit screen locker.
  
  But for the sake of argument let's assume the usecase is valid. Yes for 
movies I agree, but for audio I disagree. I would find it highly annoying if 
audio stops on screen lock. And I would find it even more annoying to have to 
change the settings depending on the kind of media I'm interacting with.
  
  the mpris interface supports video and audio - I don't think that one option 
can handle both.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: oliverhenshaw, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[oliverhenshaw (Oliver Henshaw)]

oliverhenshaw added a comment.


  Surely the ideal world is one where the movie player realises the screen is 
locked and makes the decision to pause by itself? Media controls might still be 
a better option for audio players, but I wonder whether volume controls are 
better than that?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: oliverhenshaw, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  > The feature like that doesn't make sense IMHO.
  
  Why?
  
  Media controls doesn't help with this usecase. You come back, you press 
resume, your movie resumes...whilst your screen is still locked.
  And if you unlock first..then you don't have the controls visible to press 
resume.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Abandoned] D3674: RFC: Allow pausing media players when screen is locked

[broulik (Kai Uwe Broulik)]

broulik abandoned this revision.
broulik added a comment.


  IMHO this feature is completely orthogonal to "proper" media controls. But I 
respect your decision.
  
  So, about proper media controls, would re-using the mpris data engine in 
Plasma from QML be an option or should it rather be some implementation in 
ksldapp given you wanted to disable dbus access for the locker?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D3674: RFC: Allow pausing media players when screen is locked

[Martin Gräßlin]

graesslin added a comment.


  Like Marco I would prefer proper media controls. The feature like that 
doesn't make sense IMHO.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D3681: Fix KAuthActionReply usage

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  setting an errorDescription on an object then replacing an object
  doesn't do anything.

TEST PLAN
  None

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3681

AFFECTED FILES
  libmuonapt/AddRepositoryHelper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129603: TextFieldStyle: Fix implicitHeight value so the text cursor is centered

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129603/
---

(Updated Dec. 14, 2016, 3:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit d1f4b5322abacd258ae8d633667cdf391071b7e7 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

This makes the TextField slightly bigger, but cursor is now correctly centered.


Diffs
-

  src/declarativeimports/plasmastyle/TextFieldStyle.qml 6174220 

Diff: https://git.reviewboard.kde.org/r/129603/diff/


Testing
---


File Attachments


before.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/02/9aa4f7fd-96b3-42a8-8938-cc1ab2d6ee66__before.png
after.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/02/dadf758a-9298-4ed8-872e-947c308bcedb__after.png


Thanks,

David Rosca

[Differential] [Closed] D3680: Don't list separately plasmoids from metadata.desktop and .json

[apol (Aleix Pol Gonzalez)]

apol closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D3680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3680: Don't list separately plasmoids from metadata.desktop and .json

[apol (Aleix Pol Gonzalez)]

apol marked an inline comment as done.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 12 lines] D3680: Don't list separately plasmoids from metadata.desktop and .json

[apol (Aleix Pol Gonzalez)]

apol updated this revision to Diff 9014.
apol added a comment.


  {} for marco

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3680?vs=9012=9014

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3680

AFFECTED FILES
  src/kpackage/packageloader.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Seems sensible. +1
  
  As it's an RFC, it's a shame we have so much duplicated code for media player 
management; but I don't think there's any existing simple way round that.  Any 
thoughts on how we collectively can fix that?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3680: Don't list separately plasmoids from metadata.desktop and .json

[mart (Marco Martin)]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> packageloader.cpp:251
> +
> +if (dirs.contains(dir))
> +continue;

use { }

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[mart (Marco Martin)]

mart added a comment.


  I would rather have media controls in the greeter.
  I don't like yet another option that does something rather weird :/

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 11 lines] D3680: Don't list separately plasmoids from metadata.desktop and .json

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Plasma, Frameworks, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Since recently we're also listing the metadata.desktop file which is the code
  path we wanted to avoid altogether. This patch tries to solve that.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3680

AFFECTED FILES
  src/kpackage/packageloader.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3679: Introduce undefined fields

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7b5f5b57b0cf: Introduce undefined fields (authored by 
apol).

REPOSITORY
  R242 Plasma Frameworks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3679?vs=9010=9011

REVISION DETAIL
  https://phabricator.kde.org/D3679

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3679: Introduce undefined fields

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Frameworks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3679

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 6 lines] D3679: Introduce undefined fields

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  less warnings when compiling plasma-workspace

REPOSITORY
  R242 Plasma Frameworks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3679

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/#review101439
---



sorry, I submitted this yesterday, I just forgot to add the REVIEW tag. 

It's as 
f4b5dfbc36d707d8dd76c4dd8b90a1b3877a393d/1507afa007a668f7797a89031efe241ce78322b7
 in p-w

- David Edmundson


On Dec. 14, 2016, 1:52 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129528/
> ---
> 
> (Updated Dec. 14, 2016, 1:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The sddm breeze theme battery icon is trying to access the battery
> percent. In a batteryless system it produces the syslog message:
> Nov 14 22:28:23 samd sddm-greeter[3210]: 
> file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to 
> assign [undefined] to int
> 
> Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016
> 
> Debian-Bug: https://bugs.debian.org/844194
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/Battery.qml 
> c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 
> 
> Diff: https://git.reviewboard.kde.org/r/129528/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/
---

(Updated Dec. 14, 2016, 1:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

The sddm breeze theme battery icon is trying to access the battery
percent. In a batteryless system it produces the syslog message:
Nov 14 22:28:23 samd sddm-greeter[3210]: 
file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to 
assign [undefined] to int

Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016

Debian-Bug: https://bugs.debian.org/844194


Diffs
-

  lookandfeel/contents/components/Battery.qml 
c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 

Diff: https://git.reviewboard.kde.org/r/129528/diff/


Testing
---


Thanks,

Maximiliano Curia

[Differential] [Request, 204 lines] D3674: RFC: Allow pausing media players when screen is locked

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, graesslin.
broulik set the repository for this revision to R133 KScreenLocker.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ... and unpause those that were playing before when unlocking.
  
  BUG: 373641
  FIXED-IN: 5.9.0

TEST PLAN
  Locked screen, VLC stopped, unlocked screen, VLC continued playing
  
  Default is off, ie. keep playing
  
  F719087: Screenshot_20161214_144521.png 

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

AFFECTED FILES
  CMakeLists.txt
  kcfg/kscreenlockersettings.kcfg
  kcm/kcm.ui
  ksldapp.cpp
  ksldapp.h
  mpris.cpp
  mpris.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129642: Introduce org.kde.kconfig QML import with KAuthorized

[Dan Leinir Turthra Jensen]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129642/#review101438
---


Ship it!




Ship It!

- Dan Leinir Turthra Jensen


On Dec. 12, 2016, 3:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129642/
> ---
> 
> (Updated Dec. 12, 2016, 3:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Dan Leinir Turthra Jensen.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This allows to query KAuthorized restrictions declaratively.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/CMakeLists.txt 8a506df 
>   src/qmlcontrols/kconfig/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kconfig/kauthorizedproxy.h PRE-CREATION 
>   src/qmlcontrols/kconfig/kauthorizedproxy.cpp PRE-CREATION 
>   src/qmlcontrols/kconfig/kconfigplugin.h PRE-CREATION 
>   src/qmlcontrols/kconfig/kconfigplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kconfig/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129642/diff/
> 
> 
> Testing
> ---
> 
> import org.kde.kconfig 1.0
> 
> Button {
> visible: KAuthorized.authorize("ghns")
> }
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129603: TextFieldStyle: Fix implicitHeight value so the text cursor is centered

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129603/#review101436
---


Ship it!




Ship It!

- Marco Martin


On Dec. 2, 2016, 9:05 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129603/
> ---
> 
> (Updated Dec. 2, 2016, 9:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes the TextField slightly bigger, but cursor is now correctly 
> centered.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 6174220 
> 
> Diff: https://git.reviewboard.kde.org/r/129603/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> before.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/02/9aa4f7fd-96b3-42a8-8938-cc1ab2d6ee66__before.png
> after.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/02/dadf758a-9298-4ed8-872e-947c308bcedb__after.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

Re: Review Request 129642: Introduce org.kde.kconfig QML import with KAuthorized

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129642/#review101435
---


Ship it!




Ship It!

- Marco Martin


On Dec. 12, 2016, 3:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129642/
> ---
> 
> (Updated Dec. 12, 2016, 3:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Dan Leinir Turthra Jensen.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This allows to query KAuthorized restrictions declaratively.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/CMakeLists.txt 8a506df 
>   src/qmlcontrols/kconfig/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kconfig/kauthorizedproxy.h PRE-CREATION 
>   src/qmlcontrols/kconfig/kauthorizedproxy.cpp PRE-CREATION 
>   src/qmlcontrols/kconfig/kconfigplugin.h PRE-CREATION 
>   src/qmlcontrols/kconfig/kconfigplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kconfig/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129642/diff/
> 
> 
> Testing
> ---
> 
> import org.kde.kconfig 1.0
> 
> Button {
> visible: KAuthorized.authorize("ghns")
> }
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/#review101434
---


Ship it!




Ship It!

- Marco Martin


On Nov. 22, 2016, 1:04 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129528/
> ---
> 
> (Updated Nov. 22, 2016, 1:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The sddm breeze theme battery icon is trying to access the battery
> percent. In a batteryless system it produces the syslog message:
> Nov 14 22:28:23 samd sddm-greeter[3210]: 
> file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to 
> assign [undefined] to int
> 
> Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016
> 
> Debian-Bug: https://bugs.debian.org/844194
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/Battery.qml 
> c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 
> 
> Diff: https://git.reviewboard.kde.org/r/129528/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

Re: Review Request 129652: update network, smb, thumbnail ioslave docbooks

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129652/#review101433
---


Ship it!




Ship It!

- Marco Martin


On Dec. 14, 2016, 5:55 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129652/
> ---
> 
> (Updated Dec. 14, 2016, 5:55 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> bump date + releaseinfo (do we need releaseinfo here?)
> network: use double slash (//)
> smb: fix systemsettings modul, remove para about really old samba version
> thumbnail: add dolphin, fix link to sources
> 
> 
> Diffs
> -
> 
>   doc/kioslave/network/index.docbook 697d366 
>   doc/kioslave/smb/index.docbook aef3adb 
>   doc/kioslave/thumbnail/index.docbook 334bf6d 
> 
> Diff: https://git.reviewboard.kde.org/r/129652/diff/
> 
> 
> Testing
> ---
> 
> checkXML5 index.docbook
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

[Differential] [Closed] D3666: Test the variable type without warning

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:cec5bb27f111: Test the variable type without warning 
(authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3666?vs=8977=8997

REVISION DETAIL
  https://phabricator.kde.org/D3666

AFFECTED FILES
  src/controls/private/DefaultListItemBackground.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Closed] D3658: Set Automatic login flag to adjust SDDM config directly

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:b154c7522b63: Set Automatic login flag to adjust SDDM 
config directly (authored by davidedmundson).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3658?vs=8957=8996

REVISION DETAIL
  https://phabricator.kde.org/D3658

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/account.ui
  src/lib/accountmodel.cpp
  src/lib/accountmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:4761ae39b60d: Hide "automatic login" button in 
UserAccounts since is does absolutely nothing (authored by davidedmundson).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3062?vs=7402=8995

REVISION DETAIL
  https://phabricator.kde.org/D3062

AFFECTED FILES
  src/account.ui
  src/accountinfo.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3658: Set Automatic login flag to adjust SDDM config directly

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3658

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3660: Plasma 5.9 "Canopee" Wallpaper

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3660

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kvermette, #plasma, broulik
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3660: Plasma 5.9 "Canopee" Wallpaper

[broulik (Kai Uwe Broulik)]

broulik closed this revision.
broulik added a comment.


  Committed into master in 
https://cgit.kde.org/breeze.git/commit/?id=ab984d2ed689322c3b11be6042053bcfd33f3807

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3660

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kvermette, #plasma, broulik
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas