Re: Review Request 129696: Fixes, popups from docks that use masking are misplaced

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129696/#review101569
---



Is it possible to get a test to make sure these things work properly? It seems 
flaky as is.

- Aleix Pol Gonzalez


On Dec. 24, 2016, 10:55 p.m., Michail Vourlakos wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129696/
> ---
> 
> (Updated Dec. 24, 2016, 10:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 374127
> http://bugs.kde.org/show_bug.cgi?id=374127
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fixes, popups from docks that use masking are misplaced
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp 6e2041a 
> 
> Diff: https://git.reviewboard.kde.org/r/129696/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michail Vourlakos
> 
>

Re: Review Request 129696: Fixes, popups from docks that use masking are misplaced

[Michail Vourlakos]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129696/
---

(Updated Δεκ. 24, 2016, 9:55 μμ.)


Review request for Plasma.


Changes
---

add a reference to the bug report


Bugs: 374127
http://bugs.kde.org/show_bug.cgi?id=374127


Repository: plasma-framework


Description
---

Fixes, popups from docks that use masking are misplaced


Diffs
-

  src/plasmaquick/dialog.cpp 6e2041a 

Diff: https://git.reviewboard.kde.org/r/129696/diff/


Testing
---


Thanks,

Michail Vourlakos

[Differential] [Commented On] D3777: notice when the only screen changes

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3777#71262, @davidedmundson wrote:
  
  > > so, is this workaround ok with a message to remove when/if we depend from 
a qt with a proper solution to https://bugreports.qt.io/browse/QTBUG-57785 ?
  >
  > Based on this I still don't really get why we're not just using a native 
event filter on xrandr configure events as I asked on IRC. You might need to 
the processing in a Qt
  
  
  yep, you are right, at the beginning i tought this was a qscreen problen on 
top of the xcb qpa, but it turns out is x11 specific, so the nativeeventfilter 
is more correct

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D3777

REVISION DETAIL
  https://phabricator.kde.org/D3777

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3777: notice when the only screen changes

[mart (Marco Martin)]

mart added a comment.


  this is an attempt so use the native event filter approach (can't test yet, 
as i'm away and don't have an external screen handy)
  
  will proper test tomorrow (too bad it's getting really tight for release:/)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D3777

REVISION DETAIL
  https://phabricator.kde.org/D3777

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 46 lines] D3777: notice when the only screen changes

[mart (Marco Martin)]

mart updated this revision to Diff 9352.
mart added a comment.


  - use a native event filter over XCB_RANDR_NOTIFY

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3777?vs=9327=9352

BRANCH
  arcpatch-D3777

REVISION DETAIL
  https://phabricator.kde.org/D3777

AFFECTED FILES
  shell/desktopview.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3777: notice when the only screen changes

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  > so, is this workaround ok with a message to remove when/if we depend from a 
qt with a proper solution to https://bugreports.qt.io/browse/QTBUG-57785 ?
  
  Based on this I still don't really get why we're not just using a native 
event filter on xrandr configure events as I asked on IRC. You might need to 
the processing in a Qt queued connection, but it'd still be a billion times 
simpler, and you could put the logic in screenpool, where it logically should 
be.
  
  You said it was because of wayland, but that doesn't hold true , because even 
if the Qt wayland QPA does the same thing (and a quick grep for the word "fake" 
implies it doesn't) we're the ones that control what order the QPA gets output 
events so could avoid the situation anyway.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/screenheuristic

REVISION DETAIL
  https://phabricator.kde.org/D3777

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3777: notice when the only screen changes

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/screenheuristic

REVISION DETAIL
  https://phabricator.kde.org/D3777

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[kio-extras] [Bug 372860] MTP not usable : connects, then disconnects, then connects...

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=372860

Elvis Angelaccio  changed:

   What|Removed |Added

Product|dolphin |kio-extras
  Component|general |default
Version|16.08.2 |unspecified
   Assignee|dolphin-bugs-n...@kde.org   |plasma-devel@kde.org
 CC||elvis.angelac...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129697: Figure out software center integration on the menus

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/
---

(Updated Dec. 24, 2016, 12:30 p.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
---

So far we had a (commented out) entry that was called `Remove ` that would open the configured application.

* Instead of looking up the service files in PackageKit, it does so on 
AppStream, allowing for a faster and sync approach.
* Renames the action to `Open `.
* Uses `appstream://` URI scheme, allowing for the system to decide which 
application handles it rather than an awkward configuration entry.
* Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt 
dependency instead.

This also means that applications coming from other sources than the packaging 
system (i.e. Snappy, Flatpak or AppImage) would also be supported, as long as 
it's supported by the package manager.


Diffs (updated)
-

  CMakeLists.txt 90aaa03e 
  applets/kicker/CMakeLists.txt 2e112e42 
  applets/kicker/package/contents/config/main.xml bfd0d2db 
  applets/kicker/plugin/appentry.cpp 5efdb0d0 
  applets/kicker/plugin/findpackagenamejob.h 9905182c 
  applets/kicker/plugin/findpackagenamejob.cpp aa3fd549 
  applets/kickoff/package/contents/config/main.xml d7c51624 
  config-workspace.h.cmake d0b48b94 

Diff: https://git.reviewboard.kde.org/r/129697/diff/


Testing
---

Manual testing, opened few applications, all worked fine.


Thanks,

Aleix Pol Gonzalez

[Differential] [Request, 123 lines] D3806: Reduce code duplication for processing input events

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  For every input event we have similar code. We go through all
  InputFilters, invoke a method with some arguments and check whether
  the filter returns true.
  
  Instead of duplicating that logic everywhere, there is now one method
  in InputRedirection which takes a std::function to call on the input
  filters. The std::function is supposed to be generated with a std::bind
  on the InputFilter::method with all the required arguments.

REPOSITORY
  R108 KWin

BRANCH
  input-filters

REVISION DETAIL
  https://phabricator.kde.org/D3806

AFFECTED FILES
  input.cpp
  input.h
  keyboard_input.cpp
  pointer_input.cpp
  touch_input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3777: notice when the only screen changes

[mart (Marco Martin)]

mart added a comment.


  so, is this workaround ok with a message to remove when/if we depend from a 
qt with a proper solution to https://bugreports.qt.io/browse/QTBUG-57785  ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3777

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3777: notice when the only screen changes

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3777#71209, @davidedmundson wrote:
  
  > Oh! I think I now see why we have this bug.
  >
  > We get a disconnect then connect, which from Qt5.5 goes:
  >
  > Old Real Screen
  >  Fake Screen
  >  New Real Screen
  >
  > You never get any signals when you're going to or from the fake screen (by 
design), but implicitly that means we miss a real change.
  >
  > Is that the conclusion you had reached from debug?
  
  
  yes, I think what's happening, when the output switches the chain of events is
  QXcbConnection::destroyScreen()
  if (virtualDesktop->screens().count() == 1) {
  
// If there are no other screens on the same virtual desktop,
// then transform the physical screen into a fake screen.
  
  then the new output is enabled:
  QXcbConnection::updateScreens()
  ...
  } else if (!screen && output.connection == XCB_RANDR_CONNECTION_CONNECTED) {
  ...
  // Transform the fake screen into a physical screen
  screen->setOutput(output.output, outputInfo.data());
  
  and in this, no primaryScreenChanged, not screenAdded/screenRemoved got 
emitted, because the only qscreen pointer was massaged into being fake, then 
real again, but the instance is always there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3777

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Review Request 129697: Figure out software center integration on the menus

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/#review101564
---



very neat :-) I especially like the red ration in the review request.


applets/kicker/plugin/appentry.cpp (line 155)


please use an i18nc. I don't really get what Manage is supposed to do, so 
that needs help for translators ;-)


- Martin Gräßlin


On Dec. 23, 2016, 4:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129697/
> ---
> 
> (Updated Dec. 23, 2016, 4:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> So far we had a (commented out) entry that was called `Remove  package>` that would open the configured application.
> 
> * Instead of looking up the service files in PackageKit, it does so on 
> AppStream, allowing for a faster and sync approach.
> * Renames the action to `Open `.
> * Uses `appstream://` URI scheme, allowing for the system to decide which 
> application handles it rather than an awkward configuration entry.
> * Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt 
> dependency instead.
> 
> This also means that applications coming from other sources than the 
> packaging system (i.e. Snappy, Flatpak or AppImage) would also be supported, 
> as long as it's supported by the package manager.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 90aaa03e 
>   applets/kicker/CMakeLists.txt 2e112e42 
>   applets/kicker/package/contents/config/main.xml bfd0d2db 
>   applets/kicker/plugin/appentry.cpp 5efdb0d0 
>   applets/kicker/plugin/findpackagenamejob.h 9905182c 
>   applets/kicker/plugin/findpackagenamejob.cpp aa3fd549 
>   applets/kickoff/package/contents/config/main.xml d7c51624 
>   config-workspace.h.cmake d0b48b94 
> 
> Diff: https://git.reviewboard.kde.org/r/129697/diff/
> 
> 
> Testing
> ---
> 
> Manual testing, opened few applications, all worked fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

[Differential] [Closed] D3803: Add support for on-screen-message to kwineffects

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ab456596777a: Add support for on-screen-message to 
kwineffects (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3803?vs=9343=9349

REVISION DETAIL
  https://phabricator.kde.org/D3803

AFFECTED FILES
  autotests/mock_effectshandler.h
  effects.cpp
  effects.h
  effects/colorpicker/colorpicker.cpp
  effects/colorpicker/colorpicker.h
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas