[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> iconapplet.cpp:159
>  
> -return;
> +if (name.isEmpty() && 
> url.scheme().startsWith(QLatin1String("http"))) {
> +name = url.host();

Why only http?

This would be useful for FTP, SMB and many other things, no?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dfaure wrote in iconapplet.cpp:159
> Why only http?
> 
> This would be useful for FTP, SMB and many other things, no?

There you would usually have a filename that makes sense.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> broulik wrote in iconapplet.cpp:159
> There you would usually have a filename that makes sense.

No, not necessarily. You can point to the root of a FTP server with 
ftp://ftp.kde.org/  and you can even point to your home dir on an FTP server 
with ftp://user@host (and no trailing slash).

Similarly there's smb://workgroup or smb://host (I forgot the exact syntax for 
workgroups), no filename.

Why not handle any case without a filename in the same way, http or not?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dfaure wrote in iconapplet.cpp:159
> No, not necessarily. You can point to the root of a FTP server with 
> ftp://ftp.kde.org/  and you can even point to your home dir on an FTP server 
> with ftp://user@host (and no trailing slash).
> 
> Similarly there's smb://workgroup or smb://host (I forgot the exact syntax 
> for workgroups), no filename.
> 
> Why not handle any case without a filename in the same way, http or not?

I see. Still when I do http://www.kde.org/index.php I would get "index.php" as 
name which is non-descript.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[David Faure]

dfaure added a comment.


  But then every HTTP URL, even with a filename, will the host as filename? 
  Useful if you have only one link to a given website, but what if you have 5 
links to different pages on that website?
  
  Or maybe I didn't understand the order you wanted to use.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

[Jonathan Marten]

marten added a comment.


  Agreed that a decision needs to be made, but I'm not an expert on the 
KPackage system and so wasn't sure whether the warning may be useful to package 
developers in some cases - in which case leaving it commented out would make it 
easier to reinstate than removing it entirely.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D4188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik added a comment.


  Ok, I'll put it after
  
if (name.isEmpty()) {
name = url.path();
}
  
  and do a
  
if (name.isEmpty() || url.scheme().startsWith(QLatin1String("http"))) {
name = url.host();
}

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D4198: Require Qt 5.7

[Luigi Toscano]

ltoscano added a subscriber: Sysadmin.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4198

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: #sysadmin, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 165 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik updated the summary for this revision.
broulik updated this revision to Diff 10348.
broulik added a comment.


  - Improve default naming logic
  
  file:/// → "/" (would be neat to also ask kfileplaces at some point)
  ftp://www.somehost.com/ → "www.somehost.com"
  ftp://www.somehost.com/foo/bar/ → "bar"
  
  (I think showing domain for websites always by default is fine, if user 
really has multiple links he or she can still change the name)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4157?vs=10253&id=10348

REVISION DETAIL
  https://phabricator.kde.org/D4157

AFFECTED FILES
  applets/icon/iconapplet.cpp
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[David Faure]

dfaure added a comment.


  What I used to do about all this is to turn every '/' into a unicode fraction 
slash (so that it still looks like a '/' to the user, but can be used in a 
filename), and name the link with the full URL like 
"ftp://www.somehost.com/foo/bar/";.
  
  See KIO::encodeFileName (and copyjob.cpp:813, i.e. if you use KIO::link() 
this happens automatically in KIO).
  
  But maybe that's because I like URLs :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4198: Require Qt 5.7

[Bhushan Shah]

bshah added a comment.


  Yes we do have Qt 5.7 on CI - 
https://build.kde.org/view/QT/job/qt5%205.7%20kf5-qt5/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4198

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: bshah, #sysadmin, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 19 lines] D4199: [Style KCM] Make sure to enable kappmenu kded module

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ivan.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The old KCM enabled and disabled the kded (both autoloading and 
load/unloadModule) depending on global menu setting.
  Since we never had global menu in 5.x before, it would disable the menu when 
you hit Apply.
  This will break global menu for users without an obvious reason why.

TEST PLAN
  Unloaded global menu module, hit apply, module was loaded.
  Disabled global menu autoloading, hit apply, module autoloading was enabled 
and module was loaded.
  
  This obviously overwrites when users disable this service but then, the 
service could/should always be running. It won't register a com canonical 
appmenu registrar service if it's not enabled, so apps will work just fine with 
kappmenu service running.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4199

AFFECTED FILES
  kcms/style/kcmstyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, ivan
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: plasma-integration/5.9 fails on build.kde.org

[Rik Mills]

On 18/01/17 17:05, David Edmundson wrote:
> I'm on it.
> 
> David


Master branch in kubuntu CI now fails with

/<>/plasma-integration-5.8.5+p17.04+git20170119.0940/src/platformtheme/kdeplatformsystemtrayicon.cpp
CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o:
In function `KdePlatformTheme::createPlatformMenuBar() const':
./obj-x86_64-linux-gnu/autotests/./src/platformtheme/kdeplatformtheme.cpp:333:
undefined reference to `QDBusMenuBar::windowChanged(QWindow*, QWindow*)'
collect2: error: ld returned 1 exit status
autotests/CMakeFiles/kdeplatformtheme_unittest.dir/build.make:385:
recipe for target 'autotests/kdeplatformtheme_unittest' failed
make[4]: *** [autotests/kdeplatformtheme_unittest] Error 1
make[4]: Leaving directory
'/<>/plasma-integration-5.8.5+p17.04+git20170119.0940/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:427: recipe for target
'autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all' failed
make[3]: *** [autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all]
Error 2
make[3]: *** Waiting for unfinished jobs

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

[Toralf Förster]

https://bugs.kde.org/show_bug.cgi?id=362988

--- Comment #10 from Toralf Förster  ---
(In reply to Toralf Förster from comment #7)
> (In reply to Toralf Förster from comment #4)
> > https://git.reviewboard.kde.org/r/129134/diff/1#index_header
> 
> had to apply this to 16.08.3 again - so it is not in mainline currently,
> right ?

in 16.12 it wasn't needed, but after upgrading to kde framework 5.30.1 I had to
re-apply the patch to the package kio-extras at this Gentoo Linux again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 19 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 10:14:43 +
Build duration: 13 min

CHANGE SET
Revision 75faab156461dbc928a749fda580de29f8e95bfa by Marco Martin: (use 
Q_FOREACH in this branch)
  change: edit kuiserver/jobview.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5944 
(39%)CONDITIONAL 1597/5890 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3295 (6%)CONDITIONAL 
119/3231 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Accepted] D4198: Require Qt 5.7

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  +1
  maybe to other repos as well, at least plasma-desktop?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4198

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, bshah, #sysadmin, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 692 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/692/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 10:14:43 +
Build duration: 24 min

CHANGE SET
Revision 75faab156461dbc928a749fda580de29f8e95bfa by Marco Martin: (use 
Q_FOREACH in this branch)
  change: edit kuiserver/jobview.cpp
Revision b3c0cb946569f06b56e81be9e32b0a10044928c6 by Marco Martin: (Revert 
"use Q_FOREACH in this branch")
  change: edit kuiserver/jobview.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5944 
(39%)CONDITIONAL 1597/5890 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3295 (6%)CONDITIONAL 
119/3231 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Accepted] D4199: [Style KCM] Make sure to enable kappmenu kded module

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4199

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, ivan, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

[Marco Martin]

mart added a comment.


  -1 on this..
  wallpaper packagestructure is indeed very weird (it makes it so that a simple 
jpg is considered as a valid package.. is how the model for thumbnails works, 
which would be a good idea to change a little) , and that's why those warnings

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D4188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=375249

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org
   Assignee|unassigned-b...@kde.org |plasma-devel@kde.org
Product|kio |kio-extras
Version|unspecified |5.8.5
  Component|nfs |default

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129851/#review102095
---


Ship it!




Ship It!

- Christoph Feck


On Jan. 18, 2017, 9:36 p.m., Alexander Volkov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129851/
> ---
> 
> (Updated Jan. 18, 2017, 9:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> QImageReader::setScaledSize() allows to use fast downscaling
> for jpeg images (by setting jpeg_decompress_struct::scale_denom).
> QImageReader::setQuality(0) sets dct_method to JDCT_IFAST and
> do_fancy_upsampling to FALSE, although these parameters don't
> really influence on decoding speed, also as do_block_smoothing
> which is not used by Qt.
> 
> QImageReader::setAutoTransform() allows to apply the rotation
> from EXIF data. It was introduced in Qt 5.5, so bump the
> required Qt version.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt be305274984321b93e05feeeb6d09490b33a43cc 
>   thumbnail/CMakeLists.txt 92eb3c7ae98660eb00e33fbe608de1580ea75912 
>   thumbnail/jpegcreator.h 5cab30ff6a0881863ec66d739063f6dbfb4a48f7 
>   thumbnail/jpegcreator.cpp 9191fbacd21c65c9fc845fd7c77365005cd8df00 
> 
> Diff: https://git.reviewboard.kde.org/r/129851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Volkov
> 
>

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

[Alexander Volkov]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129851/
---

(Updated Jan. 19, 2017, 1:06 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c249f8547f2d1913e0570d78a0240c5f8865c336 by Alexander 
Volkov to branch master.


Repository: kio-extras


Description
---

QImageReader::setScaledSize() allows to use fast downscaling
for jpeg images (by setting jpeg_decompress_struct::scale_denom).
QImageReader::setQuality(0) sets dct_method to JDCT_IFAST and
do_fancy_upsampling to FALSE, although these parameters don't
really influence on decoding speed, also as do_block_smoothing
which is not used by Qt.

QImageReader::setAutoTransform() allows to apply the rotation
from EXIF data. It was introduced in Qt 5.5, so bump the
required Qt version.


Diffs
-

  CMakeLists.txt be305274984321b93e05feeeb6d09490b33a43cc 
  thumbnail/CMakeLists.txt 92eb3c7ae98660eb00e33fbe608de1580ea75912 
  thumbnail/jpegcreator.h 5cab30ff6a0881863ec66d739063f6dbfb4a48f7 
  thumbnail/jpegcreator.cpp 9191fbacd21c65c9fc845fd7c77365005cd8df00 

Diff: https://git.reviewboard.kde.org/r/129851/diff/


Testing
---


Thanks,

Alexander Volkov

[Differential] [Closed] D4199: [Style KCM] Make sure to enable kappmenu kded module

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:af36a54e947f: [Style KCM] Make sure to enable kappmenu 
kded module (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4199?vs=10349&id=10352

REVISION DETAIL
  https://phabricator.kde.org/D4199

AFFECTED FILES
  kcms/style/kcmstyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, ivan, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 16 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 13:17:20 +
Build duration: 10 min

CHANGE SET
Revision af36a54e947f32974a83c4ff1669081899672f96 by kde: ([Style KCM] Make 
sure to enable kappmenu kded module)
  change: edit kcms/style/kcmstyle.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Commented On] D4178: The welcome message is better written now

[Ivan Čukić]

ivan added a comment.


  It is not grammatically correct now.
  
  The smallest change (that I can think of) that would make it correct is 
"Plasma, made by KDE"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4178

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D4198: Require Qt 5.7

[David Edmundson]

davidedmundson added a comment.


  Yeah, will do it to the all the main actively developed ones, just thought 
I'd put one up for review.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4198

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, bshah, #sysadmin, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[plasmashell] [Bug 363860] Slideshow does not cycle if only one image in set directory

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363860

Christoph Feck  changed:

   What|Removed |Added

   Target Milestone|--- |1.0
Version|unspecified |5.8.0
  Component|general |Image Wallpaper
 CC||plasma-b...@kde.org
Product|Plasma Workspace Wallpapers |plasmashell
   Assignee|plasma-devel@kde.org|notm...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Closed] D4197: Delete KCModule before deleting QApplication

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:8e7540a0e00b: Delete KCModule before deleting 
QApplication (authored by davidedmundson).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4197?vs=10344&id=10354

REVISION DETAIL
  https://phabricator.kde.org/D4197

AFFECTED FILES
  kcmshell/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, jgrulich
Cc: jgrulich, jsalatas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D4198: Require Qt 5.7

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D4198#78620, @davidedmundson wrote:
  
  > Yeah, will do it to the all the main actively developed ones, just thought 
I'd put one up for review.
  
  
  For KWin I'll take care of as it allows me to drop some code ;-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4198

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, bshah, #sysadmin, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4198: Require Qt 5.7

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cb2803900fa5: Require Qt 5.7 (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4198?vs=10345&id=10355

REVISION DETAIL
  https://phabricator.kde.org/D4198

AFFECTED FILES
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, bshah, #sysadmin, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4196: Fix clang address sanitiser error in SNI memcpy.

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:24a7f4e3ba72: Fix clang address sanitiser error in SNI 
memcpy. (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4196?vs=10343&id=10356

REVISION DETAIL
  https://phabricator.kde.org/D4196

AFFECTED FILES
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 693 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/693/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 16:01:38 +
Build duration: 7 min 8 sec

CHANGE SET
Revision cb2803900fa53074dc6048aa511b722be7b4cd20 by David Edmundson: (Require 
Qt 5.7)
  change: edit CMakeLists.txt
Revision 24a7f4e3ba72471218fd54decaaddc5baa74482f by David Edmundson: (Fix 
clang address sanitiser error in SNI memcpy.)
  change: edit dataengines/statusnotifieritem/statusnotifieritemsource.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5944 
(39%)CONDITIONAL 1597/5890 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3295 (6%)CONDITIONAL 
119/3231 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Request, 261 lines] D4202: use proper packagestructures

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  as the plasmapkg2 utility is dead, scripts and tabboxes couldn't
  be installed anymore, as plasmapkg2 was launched with an hardcoded
  package type (and had a bunch of custom code for it)
  and no packagestructure for the relevant package types existed.
  
  the port of scripts and tabboxes to kpackage in kwin is quite
  incomplete and somewhat strange (given the fact that was started by
  looking manually for the file as it couldn't link to libplasma)
  
  this makes things a bit better as now scripts and tabboxes have an actual
  package structure, making it installable by kpackagetool5.
  in the future, the port should be completed and replace all the manual lookup
  of files with package::filePath as it should work now given that valid
  structures exist
  
  BUG:374766

TEST PLAN
  tabbox plugins and kwin scripts can be installed from knewstuff
  again and can be successfully loaded

REPOSITORY
  R108 KWin

BRANCH
  phab/packageplugins

REVISION DETAIL
  https://phabricator.kde.org/D4202

AFFECTED FILES
  CMakeLists.txt
  kcmkwin/kwintabbox/main.cpp
  packageplugins/CMakeLists.txt
  packageplugins/scripts/CMakeLists.txt
  packageplugins/scripts/kwin-packagestructure-scripts.desktop
  packageplugins/scripts/scripts.cpp
  packageplugins/scripts/scripts.h
  packageplugins/windowswitcher/CMakeLists.txt
  packageplugins/windowswitcher/kwin-packagestructure-windowswitcher.desktop
  packageplugins/windowswitcher/windowswitcher.cpp
  packageplugins/windowswitcher/windowswitcher.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[kio-extras] [Bug 375305] SFTP file create date is wrong

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=375305

Elvis Angelaccio  changed:

   What|Removed |Added

 Ever confirmed|0   |1
  Component|general |default
Version|16.08.2 |5.8.5
Product|dolphin |kio-extras
   Assignee|dolphin-bugs-n...@kde.org   |plasma-devel@kde.org
 Status|UNCONFIRMED |CONFIRMED
 CC||elvis.angelac...@kde.org

--- Comment #1 from Elvis Angelaccio  ---
Thanks for report, I can reproduce. Moving to kio-extras where sftp:// lives.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 24 lines] D4203: Fix appstream name/summary ends with '.' warning

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, davidedmundson.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Drops the dot on these tags, possibly the right patch would be to fix the
  translation, but the end result is the same.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4203

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 320 lines] D4204: Added max size restrictions handlers for plasmoids

[Konstantin Shtepa]

konstantinshtepa created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Signed-off-by: Konstantin Shtepa 
  
  first step
  
  release commit. Bugs fixed, plasmoid behaves as expected.
  
  Signed-off-by: Konstantin Shtepa 
  
  fixed handle width bug
  
  Signed-off-by: Konstantin Shtepa 
  
  Fixed bug with plasmoid geometry not saved properly
  
  Signed-off-by: Konstantin Shtepa 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasmoid_size_restraints

REVISION DETAIL
  https://phabricator.kde.org/D4204

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D4205: Add missing descriptions on the trashcan and appmenubar plasmoids

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Was missing, error appstreamtest and appeared empty on the Widget
  explorer.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4205

AFFECTED FILES
  applets/trash/package/metadata.desktop
  layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4202: use proper packagestructures

[Martin Gräßlin]

graesslin added a comment.


  I assume that should go into the 5.9 branch?
  
  what about window decoration themes (aka aurorae)? Does that also need 
adjustment?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4202

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Changed Policy] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa changed the visibility from "konstantinshtepa (Konstantin 
Shtepa)" to "Public (No Login Required)".
konstantinshtepa changed the edit policy from "konstantinshtepa (Konstantin 
Shtepa)" to "All Users".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[David Edmundson]

davidedmundson added a comment.


  That's quite a huge patch.
  
  Can you give a much bigger explanation on exactly what it's doing and why.
  
  "Fixes bug N" doesn't really explain what the original problem was.

INLINE COMMENTS

> AppletAppearance.qml:61
>  
> -property int minimumHeight: Math.max(root.layoutManager.cellSize.height,
> -appletContainer.minimumHeight +
> -appletItem.contents.anchors.topMargin +
> -appletItem.contents.anchors.bottomMargin)
> +property int minimumHeight
> +Binding on minimumHeight {

why do you do

property int foo
Binding on foo {
value: Math.max()
}

instead of just

property int foo: Math.max

?

> AppletAppearance.qml:226
>  
> +QtObject {
> +id: d

Point is a native QML type.
http://doc.qt.io/qt-5/qml-point.html

property point lastPoint

then use that in your logic above.
It can be better because you then get one signal when it changes not two.

> AppletAppearance.qml:445
> +var maxInt = 100; // dirty hack
> +if (size.width > maxInt)
> +size.width = maxInt;

if maximum is infinite, (so undefined in QtQuick.Layouts) set it to 100

why?
It's far easier to test for isFinite() in other bits of code than a random big 
init

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 694 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/694/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 19:52:38 +
Build duration: 5 min 55 sec

CHANGE SET
Revision ea29025d7e7b6c03ffb0997aa394cb0786cb5ef8 by Alexander Potashev: 
(applets/icon: Set i18n domain (patch by 
Victor<victorr2...@narod.ru>))
  change: edit applets/icon/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5944 
(39%)CONDITIONAL 1597/5890 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3295 (6%)CONDITIONAL 
119/3231 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 19:52:08 +
Build duration: 15 min

CHANGE SET
Revision ea29025d7e7b6c03ffb0997aa394cb0786cb5ef8 by Alexander Potashev: 
(applets/icon: Set i18n domain (patch by 
Victor<victorr2...@narod.ru>))
  change: edit applets/icon/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5944 
(39%)CONDITIONAL 1597/5890 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3295 (6%)CONDITIONAL 
119/3231 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Commented On] D4202: use proper packagestructures

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4202#78684, @graesslin wrote:
  
  > I assume that should go into the 5.9 branch?
  
  
  quite a big backport.. but yeah, may make sense as 5.9 release would be kinda 
broken otherwise
  
  > what about window decoration themes (aka aurorae)? Does that also need 
adjustment?
  
  aurorae seems to not use kpackage at all, tarballs are uncompressed directly, 
so they keep installing fine

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4202

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added a comment.


  In https://phabricator.kde.org/D4204#78701, @davidedmundson wrote:
  
  > That's quite a huge patch.
  >  Can you give a much bigger explanation on exactly what it's doing and why.
  >  "Fixes bug N" doesn't really explain what the original problem was.
  
  
  Sorry, diff not supposed to be send here today and in that kind of state. And 
I don't see here any way to delete this diff and close this theme. Because of 
this information is not fully ready.
  I would tomorrow add comments to code about what code does and why.

INLINE COMMENTS

> davidedmundson wrote in AppletAppearance.qml:61
> why do you do
> 
> property int foo
> Binding on foo {
> value: Math.max()
> }
> 
> instead of just
> 
> property int foo: Math.max
> 
> ?

Binding on properties used because these properties assigned in JS(in handlers 
onMinimumWidthChanged and others) as lvalue and it breaks normal bindings. If 
someone could bring better idea how to handle situation when minimum size > 
maximum size without these bindings then they can be removed.

> davidedmundson wrote in AppletAppearance.qml:226
> Point is a native QML type.
> http://doc.qt.io/qt-5/qml-point.html
> 
> property point lastPoint
> 
> then use that in your logic above.
> It can be better because you then get one signal when it changes not two.

You can go without links. I know Qt, commited there.
One signal when it doesn't have any handlers or bindings wouldn't change any 
weather in QML. Point too have it's negative sides because it needs 
inverpretation "lastPoint.x". The question here is maybe I should have used int 
too as a base to properties(to maintain policy of int-based sizes).

> davidedmundson wrote in AppletAppearance.qml:445
> if maximum is infinite, (so undefined in QtQuick.Layouts) set it to 100
> 
> why?
> It's far easier to test for isFinite() in other bits of code than a random 
> big init

Just a few lines below this size is assigned for property with int as a base. 
Then this property is used in operations with others int-based kde sizes. And 
keep it as double is not a option because of default Qt 
maximumSize(Number.POSITIVE_INFINITY). So there goes 100. Is there better 
way?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: plasma-integration/5.9 fails on build.kde.org

[Rik Mills]

Reported that issue as:

https://bugs.kde.org/show_bug.cgi?id=375290

On 19/01/17 10:00, Rik Mills wrote:
> On 18/01/17 17:05, David Edmundson wrote:
>> I'm on it.
>>
>> David
> 
> 
> Master branch in kubuntu CI now fails with
> 
> /<>/plasma-integration-5.8.5+p17.04+git20170119.0940/src/platformtheme/kdeplatformsystemtrayicon.cpp
> CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o:
> In function `KdePlatformTheme::createPlatformMenuBar() const':
> ./obj-x86_64-linux-gnu/autotests/./src/platformtheme/kdeplatformtheme.cpp:333:
> undefined reference to `QDBusMenuBar::windowChanged(QWindow*, QWindow*)'
> collect2: error: ld returned 1 exit status
> autotests/CMakeFiles/kdeplatformtheme_unittest.dir/build.make:385:
> recipe for target 'autotests/kdeplatformtheme_unittest' failed
> make[4]: *** [autotests/kdeplatformtheme_unittest] Error 1
> make[4]: Leaving directory
> '/<>/plasma-integration-5.8.5+p17.04+git20170119.0940/obj-x86_64-linux-gnu'
> CMakeFiles/Makefile2:427: recipe for target
> 'autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all' failed
> make[3]: *** [autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all]
> Error 2
> make[3]: *** Waiting for unfinished jobs
> 

[Differential] [Request, 4 lines] D4208: Deal with missing drawers

[Kevin Ottens]

ervin created this revision.
ervin added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise the ActionButton is unusable if no drawer is attached to the
  ApplicationWindow. The rest of the code in that handler is checking the
  references, but not the first two lines.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D4208

AFFECTED FILES
  src/controls/private/ActionButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ervin, mart
Cc: plasma-devel, apol

[Differential] [Request, 16 lines] D4214: Make sure we display enabled ListItem on hover

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  I just realized there was a weird workaround in plasma-nm where it gets
  checked so it's shown.
  Properly use the declarative API instead of listening to a ton of signals.

TEST PLAN
  Tested with plasma-nm and org.kde.plasma.notifications plasmoids

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4214

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 42 lines] D4215: Make notifications execute the "default" action on click.

[Albert Vaca Cintora]

albertvaka created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This uses the feature introduced here [1] on KNotifications, so default
  actions don't appear as a regular action button. Instead, they are
  activated by clicking on the notification itself.
  
  If the default action is not set, it uses the previous behavior of close
  on click.
  
  This changes both the notification popup and the notifications inside the
  plasmoid.
  
  [1] https://phabricator.kde.org/D4142

TEST PLAN
  Manual testing.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4215

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/Notifications.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D4215: Make notifications execute the "default" action on click.

[Albert Vaca Cintora]

albertvaka added a reviewer: Plasma.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

[David Edmundson]

davidedmundson added a comment.


  Concept seems fine. New binding has some typos

INLINE COMMENTS

> ListItem.qml:97
> +prefix: (listItem.sectionDelegate ? "section" :
> +(background.pressed || listItem.checked || 
> listItem.containsMouse) ? "pressed" : "normal")
>  

why are you now following containsMouse. That's a behavioural change

How can background.pressed be true. I don't see where it exists?
do you mean itemMouse.pressed?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 61 lines] D4217: Remove unused feature "favorite" from PlasmaAppletItemModel

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There was no role exposed for isFavorite and it has no other impact.
  Removing it not only cleans up the code but also saves us parsing a
  config file for no reason.
  
  I don't think it's worth putting in the UI; no-one is adding so many
  plasmoids that they would go out of their way to mark one as a favourite
  for quicker future access.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4217

AFFECTED FILES
  components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h
  components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp
  components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 21 lines] D4218: Remove pointless QObject inheritance in model item

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We don't emit anything or use properties or anything else that requires
  MOC. We want to keep model items light.
  
  The emitDataChanged in setRunning still works because that's part of
  QStandardItem. Memory management is the same beacuse the
  QStandardItemModel takes ownership in appendRow().

TEST PLAN
  Opened widget explorer.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4218

AFFECTED FILES
  components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp
  components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D4214: Make sure we display enabled ListItem on hover

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ListItem.qml:97
> why are you now following containsMouse. That's a behavioural change
> 
> How can background.pressed be true. I don't see where it exists?
> do you mean itemMouse.pressed?

Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain...

It's barely a behavioral change, in fact it's what it was supposed to happen in 
the first place: give feedback on hover when the item is clickable.
Note that at the moment we're dimming the opacity for the invisible background 
we have.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 16 lines] D4214: Make sure we display enabled ListItem on hover

[Aleix Pol Gonzalez]

apol updated this revision to Diff 10379.
apol marked an inline comment as done.
apol added a comment.


  Address David's comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4214?vs=10372&id=10379

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4214

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in ListItem.qml:97
> Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain...
> 
> It's barely a behavioral change, in fact it's what it was supposed to happen 
> in the first place: give feedback on hover when the item is clickable.
> Note that at the moment we're dimming the opacity for the invisible 
> background we have.

> in fact it's what it was supposed to happen in the first place

We have the highlight for the item under mouse. 
Why should the delegate change too?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 562 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/562/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 20 Jan 2017 05:22:43 +
Build duration: 9 min 52 sec

CHANGE SET
Revision aa6cce82a9c398e1d84bafcdd99f4a622c33ea9f by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit kcms/colors/colorschemes.knsrc
  change: edit kcms/desktoptheme/plasma-themes.knsrc


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 695 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/695/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 20 Jan 2017 05:23:03 +
Build duration: 8 min 39 sec

CHANGE SET
Revision e2c7cd3b8c57f22bb74498ce45dd078b09d12221 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit wallpapers/image/wallpaper.knsrc
  change: edit components/shellprivate/widgetexplorer/plasmoids.knsrc
  change: edit applets/appmenu/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5944 
(39%)CONDITIONAL 1597/5890 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3295 (6%)CONDITIONAL 
119/3231 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Accepted] D4202: use proper packagestructures

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  phab/packageplugins

REVISION DETAIL
  https://phabricator.kde.org/D4202

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Request, 123 lines] D4220: Add a basic SNI for keyboard layout

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  On X11 the SNI for keyboard layout is provided by the keyboard kded.
  On Wayland that kded has no real access to the layouts and cannot
  properly implement switching. Given that it's better to integrate the
  SNI directly in KWin.
  
  The implementation of the SNI is largly based on the existing SNI from
  plasma-desktop/kcms/keyboard. The implementation so far supports:
  
  - Switching to next layout on toggle
  - Presenting all layouts in a context menu
  - Switching to a specific layout through the context menu
  - Opening the keyboard layout configuration module
  
  Not yet supported are:
  
  - config option whether to show the SNI
  - scroll on SNI
  - flags and/or short text for the layouts
  
  The last point needs more explanation. On X11 the layout name is
  something like "de" or "us". This can be directly mapped to a flag and
  can be added as a short note.
  
  Xkbcommon does not provide this information directly. Instead it provides
  us the full name of the layout, e.g. "German" or "English (us)". There is
  no way in the API to go from "German" to "de".
  
  Instead we need to parse the evdev.xml file to gather all information
  about layouts. This is already done in the keyboard kcm to configure
  layouts. The implementation needs to be split out into a small helper
  library.

REPOSITORY
  R108 KWin

BRANCH
  keyboard-layout-sni

REVISION DETAIL
  https://phabricator.kde.org/D4220

AFFECTED FILES
  keyboard_input.cpp
  keyboard_input.h
  keyboard_layout.cpp
  keyboard_layout.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

[Martin Gräßlin]

graesslin added a comment.


  F2090291: keyboard-kded.png 

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 20 Jan 2017 07:04:30 +
Build duration: 8 min 59 sec

CHANGE SET
Revision ecc280bfd24526a7d00fc82983d7bdd39c16d1ac by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit wallpapers/image/wallpaper.knsrc
  change: edit components/shellprivate/widgetexplorer/plasmoids.knsrc
  change: edit applets/appmenu/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5944 
(39%)CONDITIONAL 1597/5890 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3295 (6%)CONDITIONAL 
119/3231 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 20 Jan 2017 07:04:10 +
Build duration: 10 min

CHANGE SET
Revision 01a7be1d73bc81ef77bb947a94be08322d530d88 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit kcms/colors/colorschemes.knsrc


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)