[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs
dfaure added inline comments.
INLINE COMMENTS
> iconapplet.cpp:108
> +if (desiredDesktopFileName.isEmpty()) {
> +desiredDesktopFileName =
> QString::fromLatin1(QCryptographicHash::hash(m_url.toDisplayString().toUtf8(),
> QCryptographicHash::Md5).toHex());
> +}
Not convinced that KIO::encodeFileName would be better than a MD5 filename,
then?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4157
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 25 Jan 2017 06:34:02 + Build duration: 17 min CHANGE SET Revision d4a25ca56d46cfd962b52e96ed56757c299188fa by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop change: edit applets/trash/package/metadata.desktop change: edit applets/icontasks/metadata.desktop JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 (67%)CONDITIONAL 1548/3798 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 619/1711 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 432/1112 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 93/219 (42%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 38/104 (37%)
[Differential] [Accepted] D4269: VolumeSlider: Ignore all value changes until Component is completed
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4269 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D4269: VolumeSlider: Ignore all value changes until Component is completed
drosca added inline comments. INLINE COMMENTS > davidedmundson wrote in ListItemBase.qml:176 > can you not just add > > if (Component.status != Ready) to the top of this method > > and get rid of the bool? No, because `Component.status` is not attached property and so is not accessible from there. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4269 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D4269: VolumeSlider: Ignore all value changes until Component is completed
davidedmundson added inline comments.
INLINE COMMENTS
> ListItemBase.qml:176
>
> onValueChanged: {
> if (!ignoreValueChange) {
can you not just add
if (Component.status != Ready) to the top of this method
and get rid of the bool?
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D4269
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: drosca, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas
[Differential] [Accepted] D3571: [effects] Use arg="true" in the kcfg files
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH effects-singleton-arg REVISION DETAIL https://phabricator.kde.org/D3571 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Accepted] D4074: Add workaround for touch input offset for decorated windows
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH touch-input-deco-workaround REVISION DETAIL https://phabricator.kde.org/D4074 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, #kwin, davidedmundson Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas
[Differential] [Accepted] D4091: Add support for skip close animation to OnScreenMessage
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. BRANCH osm-skip-close-animation REVISION DETAIL https://phabricator.kde.org/D4091 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, davidedmundson Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas
[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout
davidedmundson added a comment. One comment, but otherwise ship it. That contextMenu thing will come back to haunt us in the future, but hopefully SNI will be fixed by then. INLINE COMMENTS > keyboard_layout.cpp:142 > m_layout = m_xkb->currentLayout(); > +initNotifierItem(); > +updateNotifier(); You only want this in ::reconfigure() before resetLayout and not here. You're calling this method from reconfigure and in processKeymapChange, from keyboard_input - that won't affect whether you're showing or hiding it. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4220 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: davidedmundson, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas
[Differential] [Changed Subscribers] D4241: Support modifier-only-shortcuts when capslock is on
davidedmundson added inline comments. INLINE COMMENTS > modifier_only_shortcut_test.cpp:281 > // currently caps lock is on > -// shift is ignored > +// shift still triggers > kwinApp()->platform()->keyboardKeyPressed(modifier, timestamp++); I don't get this change: This is the " // this test verifies that Capslock does not trigger the shift shortcut" part of the test. Shift has been released on line 276, so triggeredSpy shouldn't be going up. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4241 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
Re: Review Request 129872: [lookandfeel] Support changing window decoration
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 24, 2017, 10 след обяд) Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco Martin. Changes --- Correct rebase Repository: plasma-desktop Description --- ^^ Diffs (updated) - kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de kcms/lookandfeel/kcm.h c27b7f3d kcms/lookandfeel/kcm.cpp 6ea3d050 Diff: https://git.reviewboard.kde.org/r/129872/diff/ Testing --- Thanks, Anthony Fieroni
KDE_INSTALL_LOCALEDIR - where should point?
I have the following situation and I would like you to clarify it in order to open a bug in the distro that should fix this... KDE_INSTALL_LOCALEDIR for CMAKE in openSUSE points to /usr/share/locale but the translations are in /usr/share/locale/kf5 and in Arch points to /usr/share/locale and the translations are in /usr/share/locale 1) the question is for Plasma 5 where should the translations should be placed? (for example the plasmashell.mo and for the plasmoids) 2) where should KDE_INSTALL_LOCALEDIR point? thanks a lot !!! regards, michail
Re: Review Request 129872: [lookandfeel] Support changing window decoration
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 24, 2017, 9:40 след обяд) Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco Martin. Changes --- Rebase to 5.9 Repository: plasma-desktop Description --- ^^ Diffs (updated) - kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de kcms/lookandfeel/kcm.h c27b7f3d kcms/lookandfeel/kcm.cpp 6ea3d050 Diff: https://git.reviewboard.kde.org/r/129872/diff/ Testing --- Thanks, Anthony Fieroni
[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.
broulik added a comment. OK, let's go with this then, ie. do nothing if no default action is set. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4215 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #plasma, colomar Cc: broulik, apol, mck182, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.
colomar added a comment. +1 from me, with clicking on a notification that does not define a default action doing nothing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4215 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #plasma, colomar Cc: broulik, apol, mck182, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.
mck182 added a comment. Thanks, that's a nice list. I think real examples using actual native apps would provide better insight (like calendar, low battery or music player notification), but that'd be like a weekend project, so it's ok. **macOS**: Clicking a notification popup will in most cases bring up the app with the details - eg. calendar reminder will bring up calendar with the event details opened, f.lux "You're waking up in 8 hours" will bring the settings dialog and low battery notification will do nothing on click. I'm fine with the proposed behavior then, just that clicking the popup with no action should **not** do anything. This is however a 180 degrees turn in the behavior, so it should be at least noted in the release notes. Final +2 decision should be up to Kai and/or Thomas though. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4215 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #plasma, colomar Cc: broulik, apol, mck182, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D4214: Make sure we display enabled ListItem on hover
This revision was automatically updated to reflect the committed changes. Closed by commit R242:54e87fe879ba: Make sure we display enabled ListItem on hover (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4214?vs=10489&id=10498 REVISION DETAIL https://phabricator.kde.org/D4214 AFFECTED FILES src/declarativeimports/plasmacomponents/qml/ListItem.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 26 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Jan 2017 13:29:42 + Build duration: 21 min CHANGE SET Revision ad66dc81817ea7b7d4bf98dd772ddf99107a4202 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit applets/appmenu/package/metadata.desktop change: edit components/shellprivate/widgetexplorer/plasmoids.knsrc change: edit wallpapers/image/wallpaper.knsrc JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5946 (39%)CONDITIONAL 1597/5892 (27%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3297 (6%)CONDITIONAL 119/3233 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 93/204 (46%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 40/74 (54%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 23 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Jan 2017 13:29:12 + Build duration: 22 min CHANGE SET Revision 1cddd0f28845057e6b6713bb97f4f618b7a056a2 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop change: edit kcms/desktoptheme/plasma-themes.knsrc change: edit kcms/cursortheme/xcursor/xcursor.knsrc change: edit kcms/lookandfeel/lookandfeel.knsrc change: edit kcms/colors/colorschemes.knsrc JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 (67%)CONDITIONAL 1548/3798 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 619/1711 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 432/1112 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 93/219 (42%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 38/104 (37%)
[Differential] [Updated] D4140: Rework playing of volume feedback
drosca updated the summary for this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4140 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 35 lines] D4140: Rework playing of volume feedback
drosca updated this revision to Diff 10495. drosca added a comment. Make sure not to play feedback for volume changes that comes outside widget REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4140?vs=10175&id=10495 BRANCH feedback-rework (branched from Plasma/5.8) REVISION DETAIL https://phabricator.kde.org/D4140 AFFECTED FILES applet/contents/ui/main.qml src/qml/volumefeedback.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D4214: Make sure we display enabled ListItem on hover
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4214 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 18 lines] D4269: VolumeSlider: Ignore all value changes until Component is completed
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 375495 FIXED-IN: 5.9.0 TEST PLAN Mute is no longer changed on first open of popup, feedback is also no longer played in this case. REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4269 AFFECTED FILES applet/contents/ui/ListItemBase.qml src/kcm/package/contents/ui/VolumeSlider.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D4104: Fix compare for undefined argument in playFeedback()
This revision was automatically updated to reflect the committed changes. Closed by commit R115:2b87302d9d01: Fix compare for undefined argument in playFeedback() (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4104?vs=10102&id=10493#toc REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4104?vs=10102&id=10493 REVISION DETAIL https://phabricator.kde.org/D4104 AFFECTED FILES applet/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D4105: Pass correct index to playFeedback
This revision was automatically updated to reflect the committed changes. Closed by commit R115:27c8c9aa84b4: Pass correct index to playFeedback (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4105?vs=10104&id=10492 REVISION DETAIL https://phabricator.kde.org/D4105 AFFECTED FILES applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, sebas Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover
davidedmundson added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4214 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 567 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/567/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Jan 2017 11:54:18 + Build duration: 23 min CHANGE SET Revision 4f1bfd58696bc8d9fda243e2dc54947db2e92832 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop change: edit kcms/desktoptheme/plasma-themes.knsrc change: edit kcms/lookandfeel/lookandfeel.knsrc change: edit kcms/colors/colorschemes.knsrc change: edit kcms/cursortheme/xcursor/xcursor.knsrc JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 (67%)CONDITIONAL 1528/3757 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 93/219 (42%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 38/104 (37%)
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 702 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/702/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Jan 2017 11:54:58 + Build duration: 5 min 54 sec CHANGE SET Revision 4065c6958b112e7da1f33c55a205a23784b87718 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit applets/appmenu/package/metadata.desktop change: edit wallpapers/image/wallpaper.knsrc change: edit components/shellprivate/widgetexplorer/plasmoids.knsrc JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5946 (39%)CONDITIONAL 1597/5892 (27%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3297 (6%)CONDITIONAL 119/3233 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 93/204 (46%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 40/74 (54%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
[Differential] [Accepted] D4105: Pass correct index to playFeedback
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4105 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, sebas Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon
https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #9 from Mahendra Tallur --- I just bothered the right persons ;) Rog came up with the location of the issue. -- You are receiving this mail because: You are the assignee for the bug.
[Differential] [Updated, 17 lines] D4214: Make sure we display enabled ListItem on hover
apol updated this revision to Diff 10489. apol added a comment. Removed hover state as requested by David and Marco REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4214?vs=10379&id=10489 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4214 AFFECTED FILES src/declarativeimports/plasmacomponents/qml/ListItem.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon
https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #8 from Kai Uwe Broulik --- Thanks for your investigation, was the right spot in the code you found :) -- You are receiving this mail because: You are the assignee for the bug.
[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs
broulik added a comment. So, should we go with this now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4157 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart, dfaure Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon
https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #7 from Mahendra Tallur --- What a quick fix ! Thank you, you made my day :-) -- You are receiving this mail because: You are the assignee for the bug.
[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon
https://bugs.kde.org/show_bug.cgi?id=375333 Kai Uwe Broulik changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kio ||-extras/2524fc27f31af744b0d ||8bfbb7662ab5f2bd13ec0 Resolution|--- |FIXED --- Comment #6 from Kai Uwe Broulik --- Git commit 2524fc27f31af744b0d8bfbb7662ab5f2bd13ec0 by Kai Uwe Broulik. Committed on 24/01/2017 at 11:11. Pushed by broulik into branch 'master'. [Folder thumbnailer] Use custom folder icon if set CHANGELOG: Folder thumbnails now respect custom folder icons Differential Revision: https://phabricator.kde.org/D4222 M +4-6thumbnail/thumbnail.cpp https://commits.kde.org/kio-extras/2524fc27f31af744b0d8bfbb7662ab5f2bd13ec0 -- You are receiving this mail because: You are the assignee for the bug.
[Differential] [Closed] D4208: Deal with missing drawers
This revision was automatically updated to reflect the committed changes. Closed by commit R169:6bcf5405a217: Deal with missing drawers (authored by ervin). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4208?vs=10366&id=10483 REVISION DETAIL https://phabricator.kde.org/D4208 AFFECTED FILES src/controls/private/ActionButton.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ervin, mart Cc: plasma-devel, apol
[Differential] [Accepted] D4208: Deal with missing drawers
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D4208 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ervin, mart Cc: plasma-devel, apol
