[Differential] [Request, 24 lines] D4402: Always check if context is valid when calling pa functions

2017-02-02 Thread David Rosca
drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If pa_context is null, pulseaudio aborts.
  
  BUG: 375872

TEST PLAN
  I can't reproduce the crash myself, but from backtrace this
  should fix it.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D4402

AFFECTED FILES
  src/context.cpp
  src/context.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-02 Thread Ben Cooksley
Hi all,

As a starting point: keeping the software itself running is a
non-starting option from my perspective. It's going to be shutdown.
This is purely to reduce the amount of maintenance effort we have to
expend in keeping our systems running.

There is an enormous amount of software and other systems deployed on
our infrastructure, and the value of continuing to maintain software,
including associated security updates, major upgrades to ensure we're
able to continue running it on modern distributions, etc for something
which is no longer in active use is questionable at best. Bitrot and
decay is almost guaranteed to erode the value of it as a historical
archive in the long run in any case.

For those who dismiss decay as an issue - problems with previous
Reviewboard upgrades not taking cleanly have resulted in some reviews
being damaged, causing their diffs to become unavailable. These sorts
of problems do happen.

Whether some kind of read only archive is retained is another topic altogether.

Reviewboard has a WebAPI which should be usable by anyone interested
to extract all the information regarding reviews, including their
comments and the diff itself. This could be used to create a static
snapshot of each review.

Regards,
Ben


Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-02 Thread René J . V . Bertin
Could this be of any help?
https://www.cloudpipes.com/integrations/phabricator/reviewboard
A paying service, but if the integration allows migration of existing 
ReviewBoard stuff into Phabricator a well-timed 2-month trial (or multiple 
thereof ;)) might suffice?

There's also this:
https://secure.phabricator.com/T3179


On Thursday February 2 2017 22:09:34 Ben Cooksley wrote:

>For those who dismiss decay as an issue - problems with previous
>Reviewboard upgrades not taking cleanly have resulted in some reviews
>being damaged, causing their diffs to become unavailable. These sorts
>of problems do happen.

Yes, I bet they do, and I bet there are ways to prevent them from happening.
Bitrot should not be an issue with the ready availability of ZFS (on Linux or 
BSD, FreeNAS etc) and btrfs, and 

>Reviewboard has a WebAPI which should be usable by anyone interested
>to extract all the information regarding reviews, including their
>comments and the diff itself. This could be used to create a static
>snapshot of each review.

Is it just me or does this convey a suggestion that projects that would like to 
be able to use review procedures the way Francis described better run their own 
service if they want reliability and not have to cope with essentially random 
transitions that discard entire histories?

R


[Differential] [Accepted] D4402: Always check if context is valid when calling pa functions

2017-02-02 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D4402

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Closed] D4301: [System Tray] SNI fallback to context menu on failing Activate

2017-02-02 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5d5518455d10: [System Tray] SNI fallback to context menu 
on failing Activate (authored by subdiff).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4301?vs=10713&id=10846

REVISION DETAIL
  https://phabricator.kde.org/D4301

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  dataengines/statusnotifieritem/statusnotifieritemjob.cpp
  dataengines/statusnotifieritem/statusnotifieritemjob.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp
  dataengines/statusnotifieritem/statusnotifieritemsource.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, davidedmundson, #plasma
Cc: anthonyfieroni, broulik, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 716 - Still Unstable!

2017-02-02 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/716/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 02 Feb 2017 13:26:00 +
Build duration: 19 min

CHANGE SET
Revision 5d5518455d10406292495c6e6874eeeb7c4534f1 by subdiff: ([System Tray] 
SNI fallback to context menu on failing Activate)
  change: edit dataengines/statusnotifieritem/statusnotifieritemsource.h
  change: edit 
applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  change: edit dataengines/statusnotifieritem/statusnotifieritemjob.h
  change: edit dataengines/statusnotifieritem/statusnotifieritemsource.cpp
  change: edit dataengines/statusnotifieritem/statusnotifieritemjob.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Closed] D4402: Always check if context is valid when calling pa functions

2017-02-02 Thread David Rosca
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:1c1a76775cb5: Always check if context is valid when 
calling pa functions (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4402?vs=10841&id=10847

REVISION DETAIL
  https://phabricator.kde.org/D4402

AFFECTED FILES
  src/context.cpp
  src/context.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 4 lines] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan created this revision.
astan added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of always adding space for the sorting indicator in item view
  headers, only add it if sorting is enabled. Without this fix, operations
  such as QTreeView::resizeColumnToContents(..) will not result in a snug
  fit when the header section is wider than all items in the column.

TEST PLAN
  #include

  #include 
  #include 
  #include 
  
  int main(int argc, char *argv[])
  {
  
QApplication app(argc, argv);

// Test model
QStandardItemModel model(3, 2);
model.setHorizontalHeaderLabels({ "Header 1", "Header 2" });
for (int row = 0; row < 3; ++row) {
for (int column = 0; column < 2; ++column) {
model.setItem(row, column, new QStandardItem("Foo"));
}
}

// View with sorting disabled
QTreeView view;
view.setWindowTitle("Sorting Disabled");
view.setModel(&model);
view.show();
view.resizeColumnToContents(0);

// View with sorting enabled
QTreeView viewWithSorting;
viewWithSorting.setWindowTitle("Sorting Enabled");
viewWithSorting.setModel(&model);
viewWithSorting.setSortingEnabled(true);
viewWithSorting.show();
viewWithSorting.resizeColumnToContents(0);

return app.exec();
  
  }
  
  Notice how before applying this fix, there's space reserved for the sorting
  indicator even on the QTreeView that has sorting disabled.

REPOSITORY
  R31 Breeze

BRANCH
  fix-unsortable-item-view-header-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4406

AFFECTED FILES
  kstyle/breezestyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan updated the summary for this revision.
astan updated the test plan for this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4406

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan updated the test plan for this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4406

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Christoph Feck
cfeck added a comment.


  QCommonStyle also adds the margins only when a sort indicator is needed, so +1

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4406

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze
Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan added a comment.


  @cfeck: Right, and so does Fusion. After a long hiatus from KDE, this is the 
first time I use Phabricator (really like it!): Is a +1 enough to push, or is 
there a more formal approval mechanism?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4406

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze
Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Changed Subscribers] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Christoph Feck
cfeck added a subscriber: hpereiradacosta.
cfeck added a comment.


  I have added Hugo (Breeze and Oxygen style maintainer).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4406

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze
Cc: hpereiradacosta, cfeck, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Accepted] D4396: Specify NoDisplay type

2017-02-02 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4396

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D4398: Don't generate appdata if it's marked as NoDisplay

2017-02-02 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision.
hpereiradacosta added a reviewer: hpereiradacosta.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks for the patch ! Ship it !
  Also, it would be great if you could see if it also applies to oxygen

REPOSITORY
  R31 Breeze

BRANCH
  fix-unsortable-item-view-header-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4406

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze, hpereiradacosta
Cc: hpereiradacosta, cfeck, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Closed] D4396: Specify NoDisplay type

2017-02-02 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6659517bce2d: Specify NoDisplay type (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4396?vs=10825&id=10852

REVISION DETAIL
  https://phabricator.kde.org/D4396

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Closed] D4398: Don't generate appdata if it's marked as NoDisplay

2017-02-02 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:102f68a42760: Don't generate appdata if it's marked as 
NoDisplay (authored by apol).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4398?vs=10827&id=10853

REVISION DETAIL
  https://phabricator.kde.org/D4398

AFFECTED FILES
  KF5PackageMacros.cmake
  src/kpackagetool/kpackagetool.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 6 lines] D4408: Fix i18n extraction: xgettext doesn't recognize single quotes

2017-02-02 Thread Alexander Potashev
aspotashev created this revision.
aspotashev added a subscriber: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  i18n-single-quotes

REVISION DETAIL
  https://phabricator.kde.org/D4408

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigGeneral.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev
Cc: plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas


[Differential] [Updated] D4408: Fix i18n extraction: xgettext doesn't recognize single quotes

2017-02-02 Thread Alexander Potashev
aspotashev added a reviewer: davidedmundson.
aspotashev removed a subscriber: davidedmundson.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4408

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Accepted] D4408: Fix i18n extraction: xgettext doesn't recognize single quotes

2017-02-02 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  i18n-single-quotes

REVISION DETAIL
  https://phabricator.kde.org/D4408

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Closed] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan closed this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4406

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze, hpereiradacosta
Cc: hpereiradacosta, cfeck, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Request, 4 lines] D4410: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan created this revision.
astan added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This fixes the same problem as described in https://phabricator.kde.org/D4406 
for Breeze.

TEST PLAN
#include 
#include 
#include 
#include 

int main(int argc, char *argv[])
{
QApplication app(argc, argv);

// Test model
QStandardItemModel model(3, 2);
model.setHorizontalHeaderLabels({ "Header 1", "Header 2" });
for (int row = 0; row < 3; ++row) {
for (int column = 0; column < 2; ++column) {
model.setItem(row, column, new QStandardItem("Foo"));
}
}

// View with sorting disabled
QTreeView view;
view.setWindowTitle("Sorting Disabled");
view.setModel(&model);
view.show();
view.resizeColumnToContents(0);

// View with sorting enabled
QTreeView viewWithSorting;
viewWithSorting.setWindowTitle("Sorting Enabled");
viewWithSorting.setModel(&model);
viewWithSorting.setSortingEnabled(true);
viewWithSorting.show();
viewWithSorting.resizeColumnToContents(0);

return app.exec();
}

REPOSITORY
  R113 Oxygen Theme

BRANCH
  fix-unsortable-item-view-header-size

REVISION DETAIL
  https://phabricator.kde.org/D4410

AFFECTED FILES
  kstyle/oxygenstyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D4410: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan updated the test plan for this revision.
astan removed a reviewer: Breeze.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D4410

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D4410: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan added a reviewer: Breeze.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D4410

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Elvis Stansvik
astan added a comment.


  @hpereiradacosta: The problem and fix was the same in Oxygen. I opened 
https://phabricator.kde.org/D4410 for that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4406

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze, hpereiradacosta
Cc: hpereiradacosta, cfeck, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Request, 621 lines] D4414: don't regenerate frames when setting every property

2017-02-02 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  give frameSvg the concept of repaintBlocked(), that enables and
  disables the regeneration of the frame data when a property is set.
  the use case is when often, a lot of properties are set one after
  the other (such as prefix, enabled borders, size)
  collapse the formely similar, but a bit different logic of frame
  regeneration is a single function for better maintanability.
  QML FrameSvgItem sets repaintblocked when it starts and releases it just on 
oncomponentCompleted

TEST PLAN
  plasmashell still starts, autotests still work, all frames are rendered 
correctly
  the destruction of old frames is cutted by 50%. in the qml profiler
  the creation time of a framesvgitem slightly improved, on this machine from 
around 26 msecs to around 21, can still be improved, but at least the code is a 
bit simpler

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  mart/FrameSvgTransactions

REVISION DETAIL
  https://phabricator.kde.org/D4414

AFFECTED FILES
  autotests/data/background.svgz
  autotests/framesvgtest.cpp
  autotests/framesvgtest.h
  src/declarativeimports/core/framesvgitem.cpp
  src/declarativeimports/core/framesvgitem.h
  src/plasma/framesvg.cpp
  src/plasma/framesvg.h
  src/plasma/private/framesvg_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Request, 64 lines] D4415: make services disqualification much stricter

2017-02-02 Thread Harald Sitter
sitter created this revision.
sitter added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  after the recent set of changes to disqualification we ended up with a bit
  too lax disqualification. if we saw the exec OR the storageid we'd
  hence forth disqualify a service with either of them being equal.
  
  in case of system settings this causes a match problem. systemsettings
  has two desktop files one !KDE and one OnlyKDE they are however exactly
  the same except for a different name and storageid. as a result if the !KDE
  one is encountered first it will be disqualified on account of
  noDisplay=true and marked as seen. when the OnlyKDE systemsettings is then
  iterated it will already have the Exec entry in the seen list and be
  disqualified on account of that.
  
  to prevent this type of confusion make it a requirement to match both
  storageid AND exec before disqualifying.
  
  it may actually be suitable to drop the exec altogether. say I copy firefox
  into the user local applications dir and set it NoDisplay=true but change
  the exec. this would still lead to the system-wide firefox being found as
  it is not getting disqualified. long story short: maybe we should
  disqualify services solely on the storageid?

TEST PLAN
  - new autotest case
  - fails without changes
  - passes with changes

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4415

AFFECTED FILES
  runners/services/autotests/fixtures/kdesystemsettings.desktop
  runners/services/autotests/fixtures/systemsettings.desktop
  runners/services/autotests/servicerunnertest.cpp
  runners/services/servicerunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Breeze] [Bug 375909] New: Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

2017-02-02 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=375909

Bug ID: 375909
   Summary: Breeze SDDM wallpaper was reset in KDE Neon 5.9 update
   Product: Breeze
   Version: 5.9.0
  Platform: Neon Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: zrenf...@gmail.com
  Target Milestone: ---

Not 100% if this is the fault of KDE Neon for probably deleting
`/usr/share/sddm/themes/breeze/` then unzipping the update, or if it's
intentional for theme.conf.user and the wallpaperFilename.ext to reset every
update.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D4317: Make it possible to change icon themes from elsewhere in kns

2017-02-02 Thread Aleix Pol Gonzalez
apol added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4317

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

2017-02-02 Thread Aleix Pol Gonzalez
apol added a comment.


  Changes are in KNS now, can someone please review the patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4307

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, whiting, leinir, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D4307: Introduce an adoption command in the wallpaper knsrc file

2017-02-02 Thread Aleix Pol Gonzalez
apol retitled this revision from "[RFC] Introduce an adoption command in the 
wallpaper knsrc file" to "Introduce an adoption command in the wallpaper knsrc 
file".
apol edited reviewers, added: Plasma; removed: Frameworks.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4307

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, whiting, leinir, mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated, 64 lines] D4415: make services disqualification much stricter

2017-02-02 Thread Harald Sitter
sitter updated this revision to Diff 10865.
sitter added a comment.


  dont ignore setenv's return value, verify it

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4415?vs=10863&id=10865

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4415

AFFECTED FILES
  runners/services/autotests/fixtures/kdesystemsettings.desktop
  runners/services/autotests/fixtures/systemsettings.desktop
  runners/services/autotests/servicerunnertest.cpp
  runners/services/servicerunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D4322: Adjust KeyboardLayout to non-kded DBus service

2017-02-02 Thread Martin Gräßlin
graesslin added a comment.


  ping!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4322

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
eliasp, sebas


[Differential] [Accepted] D4322: Adjust KeyboardLayout to non-kded DBus service

2017-02-02 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  keyboard-layout-dbus

REVISION DETAIL
  https://phabricator.kde.org/D4322

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
eliasp, sebas


[Differential] [Request, 4 lines] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-02 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  It's one of the new hints added in the gnome-only version of the
  notification specification.
  
  Adding it will help our interopability there and it might prove more
  useful for Plasma in future than the current x-kde-appname.

TEST PLAN
  Ran dbus-monitor
  Emitted signal from konversation

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4416

AFFECTED FILES
  src/notifybypopup.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Closed] D4322: Adjust KeyboardLayout to non-kded DBus service

2017-02-02 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1b8bb904763b: Adjust KeyboardLayout to non-kded DBus 
service (authored by graesslin).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4322?vs=10654&id=10867

REVISION DETAIL
  https://phabricator.kde.org/D4322

AFFECTED FILES
  components/keyboardlayout/keyboardlayout.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
eliasp, sebas


Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 717 - Still Unstable!

2017-02-02 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/717/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 02 Feb 2017 19:58:49 +
Build duration: 5 min 43 sec

CHANGE SET
Revision 1b8bb904763b649ac1650ad6c0133b04453b0129 by Martin Gräßlin: (Adjust 
KeyboardLayout to non-kded DBus service)
  change: edit components/keyboardlayout/keyboardlayout.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

2017-02-02 Thread David R . Bergstein
https://bugs.kde.org/show_bug.cgi?id=375909

David R. Bergstein  changed:

   What|Removed |Added

 CC||david.r.bergst...@gmail.com

--- Comment #1 from David R. Bergstein  ---
Noticed this issue after upgrading to KDE 5.9.0 User Edition.  I was unable to
reset the wallpaper from systemsettings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

2017-02-02 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=375909

--- Comment #2 from Chris Holland  ---
Huh you're right David. Just checked that it's still blue by opening a new
session.

I didn't actually check to see if the theme.conf.user and wallpaper was
deleted. Guess they might have just been ignored, like they are now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Closed] D4408: Fix i18n extraction: xgettext doesn't recognize single quotes

2017-02-02 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8c174b9c1e0b: Fix i18n extraction: xgettext doesn't 
recognize single quotes (authored by aspotashev).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4408?vs=10854&id=10875

REVISION DETAIL
  https://phabricator.kde.org/D4408

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigGeneral.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 588 - Still Unstable!

2017-02-02 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/588/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 02 Feb 2017 21:12:21 +
Build duration: 6 min 10 sec

CHANGE SET
Revision 8c174b9c1e0b1b1be141eb9280ca260886f0e2cb by Alexander Potashev: (Fix 
i18n extraction: xgettext doesn't recognize single quotes)
  change: edit applets/kickoff/package/contents/ui/ConfigGeneral.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 45 - Still Unstable!

2017-02-02 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 02 Feb 2017 21:11:31 +
Build duration: 17 min

CHANGE SET
Revision 8c174b9c1e0b1b1be141eb9280ca260886f0e2cb by Alexander Potashev: (Fix 
i18n extraction: xgettext doesn't recognize single quotes)
  change: edit applets/kickoff/package/contents/ui/ConfigGeneral.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Accepted] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-02 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4416

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-02 Thread Aleix Pol Gonzalez
apol added a comment.


  Same was done with the transient hint, btw. Maybe it would make sense to add 
a comment pointing to the documentation this refers to?

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4416

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-02 Thread Nicolás Alvarez
2017-02-02 7:23 GMT-03:00 René J.V. Bertin :
> On Thursday February 2 2017 22:09:34 Ben Cooksley wrote:
>
>>For those who dismiss decay as an issue - problems with previous
>>Reviewboard upgrades not taking cleanly have resulted in some reviews
>>being damaged, causing their diffs to become unavailable. These sorts
>>of problems do happen.
>
> Yes, I bet they do, and I bet there are ways to prevent them from happening.
> Bitrot should not be an issue with the ready availability of ZFS (on Linux or 
> BSD, FreeNAS etc) and btrfs, and

You missed the point. This "bit rot" is not about disk damage but
about software incompatibility. ZFS doesn't help with that...

-- 
Nicolás


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 589 - Still Unstable!

2017-02-02 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/589/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 05:19:08 +
Build duration: 7 min 7 sec

CHANGE SET
Revision d7d899e07f897275bc885a9677c7453b3b296c98 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/componentchooser/componentchooser.desktop
  change: edit kcms/style/style.desktop
  change: edit kcms/standard_actions/standard_actions.desktop
  change: edit kcms/autostart/autostart.desktop
  change: edit kcms/componentchooser/componentservices/kcm_kemail.desktop
  change: edit kcms/keys/keys.desktop
  change: edit kcms/componentchooser/componentservices/kcm_browser.desktop
  change: edit kcms/componentchooser/componentservices/kcm_terminal.desktop
  change: edit applets/kickoff/package/metadata.desktop
  change: edit applets/kicker/package/metadata.desktop
  change: edit kcms/launch/kcmlaunch.desktop
  change: edit applets/icontasks/metadata.desktop
  change: edit applets/taskmanager/package/metadata.desktop
  change: edit kcms/componentchooser/componentservices/kcm_filemanager.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 718 - Still Unstable!

2017-02-02 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/718/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 05:19:38 +
Build duration: 18 min

CHANGE SET
Revision 3949d990a46109042a5bf27573b9b7d23e15795a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit runners/kill/plasma-runner-kill.desktop
  change: edit dataengines/apps/plasma-dataengine-apps.desktop
  change: edit runners/services/plasma-runner-services.desktop
  change: edit menu/desktop/kf5-internet-terminal.directory
  change: edit phonon/platform_kde/phonon.notifyrc
  change: edit dataengines/notifications/plasma-dataengine-notifications.desktop
  change: edit applets/systemtray/container/package/metadata.desktop
  change: edit menu/desktop/kf5-more.directory
  change: edit plasma-windowed/plasma-windowed.desktop
  change: edit 
containmentactions/applauncher/plasma-containmentactions-applauncher.desktop
  change: edit 
dataengines/applicationjobs/plasma-dataengine-applicationjobs.desktop
  change: edit appmenu/appmenu.desktop
  change: edit runners/kill/plasma-runner-kill_config.desktop
  change: edit menu/desktop/kf5-system-terminal.directory
  change: edit 
dataengines/statusnotifieritem/plasma-dataengine-statusnotifieritem.desktop
  change: edit ktimezoned/ktimezoned.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 46 - Still Unstable!

2017-02-02 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 07:03:29 +
Build duration: 8 min 23 sec

CHANGE SET
Revision 837acf6995b3ffd0f1f3c10aed2601be62080f6a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/componentchooser/componentservices/kcm_kemail.desktop
  change: edit kcms/autostart/autostart.desktop
  change: edit applets/icontasks/metadata.desktop
  change: edit applets/kickoff/package/metadata.desktop
  change: edit kcms/componentchooser/componentservices/kcm_filemanager.desktop
  change: edit kcms/componentchooser/componentservices/kcm_terminal.desktop
  change: edit applets/taskmanager/package/metadata.desktop
  change: edit kcms/style/style.desktop
  change: edit kcms/componentchooser/componentchooser.desktop
  change: edit kcms/componentchooser/componentservices/kcm_browser.desktop
  change: edit kcms/standard_actions/standard_actions.desktop
  change: edit applets/kicker/package/metadata.desktop
  change: edit kcms/launch/kcmlaunch.desktop
  change: edit kcms/keys/keys.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)