[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

[Stuart Morgan]

https://bugs.kde.org/show_bug.cgi?id=358957

--- Comment #17 from Stuart Morgan  ---

I completely understand the volunteer nature of the project, I've been an open
source contributor for well over 10 years now. However no-one wants to waste
their time working on a solution when there is one already in progress by
someone in the core team.

I'm going to take it from your response that it isn't currently the case, so
yes, time permitting (and it generally doesn't these days), I will work on it
myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=358957

--- Comment #16 from Martin Gräßlin  ---
> If no-one currently active on the project is able (too busy) or 
> interested in
> implementing this, then please tell us now so that one of us from the 
> community
> can step up and do it instead.

we are a community of mostly volunteers. One of the base principals is 
scratch your own itch. If you want to have this feature: work on it. 
Don't wait for anyone telling you, that you should work on it. Just do.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

[Stuart Morgan]

https://bugs.kde.org/show_bug.cgi?id=358957

Stuart Morgan  changed:

   What|Removed |Added

 CC||stu...@tase.co.uk

--- Comment #15 from Stuart Morgan  ---
The lack of hybrid suspend support in KDE/Plasma has been discussed for several
years now. Instead of getting bogged down in implementation details, just add
the option in any form, it can always be improved later. Laptop users need the
option now, not in another 5 years when someone finally makes an executive
decision.

If no-one currently active on the project is able (too busy) or interested in
implementing this, then please tell us now so that one of us from the community
can step up and do it instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D4689: IconItem: Add roundToIconSize property

[David Edmundson]

davidedmundson added a comment.


  Makes sense and the code is fine +1 from me.
  
  I assume you have an intended usage in mind?

INLINE COMMENTS

> iconitem.h:101
> +/**
> + * If set, icon will round the painted size to defined icon sizes
> + */

add the line "the default is true"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4689

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: KMS backlight ABI proposition

[Thierry Reding]

Cc'ing Daniel, Lee and Jingoo, the backlight subsystem maintainers.

On 17/02/17 14:58, Martin Peres wrote:
> Hey everyone,
> 
> We have been working towards exposing the backlight as a KMS property
> instead of relying on the backlight drivers. We have CC:ed the people we
> have found to be the more likely to be interested in the discussion but
> please add everyone you think would have some experience with this issue.

First off, I welcome this effort, because I think we really need
something like this.

However, I had attempted to tackle this around the time of FOSDEM 2014
and even had a working prototype, but when discussing this on IRC there
were a couple of senior DRM maintainers that objected to the idea and
said it couldn't be done. I don't remember the exact details, but I
think the objection was that my prototype was hooking up backlights
essentially from devicetree links (via panels, in that case) and at the
time the general opinion had been that it couldn't be done on x86 and
therefore we weren't supposed to have it at all.

You might want to check with Dave and Daniel explicitly to make sure
they're on board this time. It seems like the general opinion might have
changed in the meantime, so I'll keep my fingers crossed.

> == Introduction ==
> 
> We are trying to bring the same level of support for the backlight on
> both the xf86-video-intel and -modesetting DDX.
> 
> Looking into the situation of the backlight, we identified these
> problems which are almost show-stoppers for -modesetting and wayland
> compositors:
> 
>  - There is no mapping between the backlight driver and DRM-connectors.
> This means that, in case there are multiple backlight drivers, the
> userspace has to have knowledge of the machine to know which driver
> should be used. See the priority list for the intel driver [0].

This is a fairly trivial issue for ARM (and other device tree based
architectures) because we explicitly link the backlight to the panel
already. The prototype that I had would look at the panel and see if
brightness support was implemented and expose that as a connector
property.

>  - The luminance curve of the backlight drivers is not specified, which
> can lead to a bad user experience: Little changes in the highest levels
> but drastic changes in the low levels.

I think this is something that the backlight framework should specify.
It's fairly unlikely that you could get this right every time in the
display driver. I suppose for something like x86 this might actually
work, but I don't think it'll work on something like ARM where you'd
have to encode this based on what backlight driver was actually being
used.

>  - Writing to the backlight driver still requires root rights. Given
> that the xserver and wayland compositors are now running root-less, this
> means we would need a complex dance involving a setuid helper [1].
> 
> Hans de Goede has already given a presentation about these issues at
> XDC2014. The slides are a good read[2].
> 
> [0]
> https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/backlight.c#n259
> 
> 
> [1]
> https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/backlight.c#n348
> 
> 
> [2]
> https://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/backlight.pdf
> 
> == Proposal ==
> 
> Since David Hermann already worked on this and proposed what I consider
> being greats foundations for building towards a solution addressing the
> issues above, I will just ask you to read his original words:
> 
> https://lists.freedesktop.org/archives/dri-devel/2014-September/067984.html
> 
> == Open issues ==
> 
> Here are the open issues we have identified with the solution proposed
> by David:
> 
>   1) Backlight device interoperability: How far should we support
>  mixing the backlight device and brightness property? Should it be
>  unidirectional or bi-directional? What about the start-up value
>  exposed by the brightness property?
> 
>   2) How many steps should be exposed: fixed or driver-dependent?
> 
>   3) Expected output curve: power? luminance? Simply monotonically
>  increasing?
> 
>   4) Should the userspace be able to turn off the backlight? If so, how
>  should it do it? What can we do to let the userspace distinguish
>  between backlight off or on?
> 
>   5) Should we expose to the userspace what is the current backlight
>  power?
> 
> Here is our current point of view on the matter:
> 
> === 1) Backlight device interoperability ===
> 
> Since we need to keep backward compatibility of the backlight, we have
> to keep the current backlight drivers.
> 
> Here are possible options:
> 
>  - Exclusive access: Unregister a backlight device when the drm
> brightness property is requested/used;
>  - Unidirectional access: When writing to the backlight property, update
> the backlight device;
>  - Bi-directional access: Propagate back changes from the backlight
> device to the property's value.
> 
> Being bi-directional would be

Re: KMS backlight ABI proposition

[Daniel Thompson]

On 20/02/17 12:46, Martin Peres wrote:

+plasma-devel, as suggested by Martin Gräßlin.


This reply also adds the current drivers/video/backlight maintainers (I 
forwarded the original mail to them separately, so I've been pretty 
brutal with the delete key when quoting the original mail).




On 17/02/17 14:58, Martin Peres wrote:

=== 1) Backlight device interoperability ===

Since we need to keep backward compatibility of the backlight, we have
to keep the current backlight drivers.

Here are possible options:

 - Exclusive access: Unregister a backlight device when the drm
brightness property is requested/used;
 - Unidirectional access: When writing to the backlight property, update
the backlight device;
 - Bi-directional access: Propagate back changes from the backlight
device to the property's value.

Being bi-directional would be of course the best, but this requires that
both drivers have the same number of steps, otherwise, we may write a
value to the property, but get another one when reading it right after,
due to the non-bijective nature of the transformation.


I don't accept that bi-directional transfer requires the step range to 
be the same. Isn't all that is required is acceptance that both sides 
maintain a copy of the current value in their own number range and that 
if X is written to then Y may change value (i.e. when mapping between 
0..100 and 0..10 then if 0..100 is at 11 and 0..10 gets 1 written then 
0..100 is allowed to change to 10).


I'd note also that the mechanisms inside backlight to support 
sysfs_notify would mean *implementing* bi-directional comms isn't too 
bloated even if the two sides used different number ranges.




Uni-directional would work in all cases, with the caveat that mixing
calls to the KMS property and the backlight device will not be supported
(changes mades through the sysfs interface of the backlight driver will
not be reflected in the KMS property). At boot time, we should however
initialize the value of the backlight property with a value close to
what is currently set in the backlight driver.

Giving exclusive access does not sound very good to me, as it would be
hard for the userspace to deal with disappearing drivers...


+1  :-)



== Current KMS ABI proposal ==

The current ABI proposal has mostly been proposed by Jani Nikula, as a
result of his experience and our discussions.

It takes the following approach:

 - Fixed number of steps (I think we should change it to expose the same
number of steps)


Fixing a large number of steps over an inflexible (lets say 8 level) 
backlight device creates a new problem. User actions to 
increase/decrease the backlight don't work unless the userspace knows 
the hardware step size...


The 0..100 proposal below will encourage the userspace to implement 
hotkeys that jump by 9 (because 0 is reserved with a special meaning). 
and thus there will be deadspots where the hot key has no effect.




 - Uni-directional: KMS -> backlight


See above.



 - Do not deal yet with 3) and 4): I have ideas, but I have been
procrastinating long-enough to send this email and we already have much
to discuss!


Do any of those ideas involve adding *new* API to provide information to 
userspace to help it correct the curves (e.g. somewhat like ALSA)?


It's not that I object to such an approach but I consider it pointless 
to present fixed range brightness levels if the userspace were to end up 
responsible for curve correction.




 - Does not expose the current backlight power as we want to let the
kernel deal with DPMS on its own

>>

=== ABI proposal ===

The brightness property MUST have values 0...100 inclusive.


I'm somewhat unconvinced by re-ranging the hardware capability but if 
this is the way we want to go perhaps consider -1..100 as the range. 
There's a risk of bikeshedding here but -1 is a more obvious "special" 
value and it offers more flexibility for natural hotkey strides.




The display brightness MUST be a monotonically increasing function of
the brightness property.

Brightness property value 1 MUST mean the minimum supported visible
brightness.

Brightness property value 100 MUST mean the maximum supported
brightness.

Brightness property value 0 SHOULD mean backlight off or equivalent for
non-backlight brightness adjustment, typically completely
black. Brightness property value 0 MUST NOT switch the display or pipe
off [1].

If the hardware is not capable of supporting zero brightness, and the
driver knows this, value 0 MUST be equal to value 1.

If the driver does not know whether the hardware is capable of
supporting zero brightness, the driver SHOULD err on the side of 0 not
being off rather than 1 meaning off. In this case, value 0 is likely
different from value 1, and the minimum brightness can only be reached
via property value 0 [2].

If the brightness gets changed outside of the property interface,
reading the property value MAY be out of sync with the actual brightness
[3].


Already discuss

[Differential] [Updated] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

[Peter Palaga]

ppalaga retitled this revision from "Task Manager: Make maximum text lines and 
minimum line length configurable for task buttons." to "Task Manager: Make the 
icon size configurable for task buttons in a vertical task manager".
ppalaga edited the summary of this revision.
ppalaga edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4550

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ppalaga, davidedmundson, hein, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated, 57 lines] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

[Peter Palaga]

ppalaga updated this revision to Diff 11562.
ppalaga added a comment.


  New or noteworthy about the second iteration:
  
  (1) It implements the proposal c) of Eike.
  
  (2) There is is just one "Icon size" control in the configuration dialog, 
instead of two controls in the previous iteration.
  F2516001: pasted_file 
  
  (2) The "Icon size" combo and its label are visible only if the task manager 
is positioned vertically
  
  (3) The "Icon size" preference is effective only for vertical task managers. 
It basically limits the size the icon is allowed to stretch to. See the changes 
in preferredMaxHeight() function.
  
  (4) The "5 literal" meaning the number of 'm' characters whose joint width 
must be available in the task button label so that the button text is rendered 
at all was refactored to minimumMColumns() function in layout.js. 
minimumMColumns() returns 5 for horizontal layouts and 3 for vertical layouts.
  
  (5) The present proposal does not change the behavior of horizontal task 
manager in any way.
  
  (6) The present proposal reaches the goal of making it possible to show some 
text in a vertical task manager through choosing a smaller icon size in the 
configuration. OTOH, users interested in icon-only layouts may reach their aim 
by selecting larger icons or narrower vertical task manager.
  
  Is the present proposal acceptable?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4550?vs=11175&id=11562

REVISION DETAIL
  https://phabricator.kde.org/D4550

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/Task.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ppalaga, davidedmundson, hein, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Reclaimed] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

[Peter Palaga]

ppalaga reclaimed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4550

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ppalaga, davidedmundson, hein, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Abandoned] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

[Peter Palaga]

ppalaga abandoned this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4550

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ppalaga, davidedmundson, hein, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 629 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/629/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 18:24:46 +
Build duration: 5 min 37 sec

CHANGE SET
Revision cc8c82ac1b43161ac670dfddc7b4afd8af3d0920 by Luigi Toscano: (Touchpad 
KCM: simplify few UI strings)
  change: edit kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Closed] D4671: Touchpad KCM: simplify few UI strings

[Luigi Toscano]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cc8c82ac1b43: Touchpad KCM: simplify few UI strings 
(authored by ltoscano).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4671?vs=11511&id=11561

REVISION DETAIL
  https://phabricator.kde.org/D4671

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, subdiff, davidedmundson
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D3530: Import plasma-workspace kioslaves

[Elvis Angelaccio]

elvisangelaccio removed a dependent revision: D3531: Drop remote ioslave, will 
be in KIO 5.32.

REVISION DETAIL
  https://phabricator.kde.org/D3530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #frameworks, #plasma, dfaure
Cc: mart, aacid, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D3531: Drop remote ioslave, will be in KIO 5.32

[Elvis Angelaccio]

elvisangelaccio edited dependencies, added: D4690: Import remote ioslave from 
plasma-workspace; removed: D3530: Import plasma-workspace kioslaves.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3531

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma, davidedmundson
Cc: bshah, lbeltrame, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Requested Review] D3531: Drop remote ioslave, will be in KIO 5.32

[Elvis Angelaccio]

elvisangelaccio requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3531

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma, davidedmundson
Cc: bshah, lbeltrame, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D3531: Drop remote ioslave, will be in KIO 5.32

[Elvis Angelaccio]

elvisangelaccio retitled this revision from "Drop kioslave folder, will be in 
KIO 5.30" to "Drop remote ioslave, will be in KIO 5.32".
elvisangelaccio edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3531

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, davidedmundson, #plasma
Cc: bshah, lbeltrame, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated, 899 lines] D3531: Drop kioslave folder, will be in KIO 5.30

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 11556.
elvisangelaccio added a comment.


  Only drop `remote:/`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3531?vs=8573&id=11556

REVISION DETAIL
  https://phabricator.kde.org/D3531

AFFECTED FILES
  CMakeLists.txt
  kioslave/CMakeLists.txt
  kioslave/remote/CMakeLists.txt
  kioslave/remote/Messages.sh
  kioslave/remote/kdedmodule/CMakeLists.txt
  kioslave/remote/kdedmodule/remotedirnotify.cpp
  kioslave/remote/kdedmodule/remotedirnotify.desktop
  kioslave/remote/kdedmodule/remotedirnotify.h
  kioslave/remote/kdedmodule/remotedirnotifymodule.cpp
  kioslave/remote/kdedmodule/remotedirnotifymodule.h
  kioslave/remote/kio_remote.cpp
  kioslave/remote/kio_remote.h
  kioslave/remote/remote.protocol
  kioslave/remote/remoteimpl.cpp
  kioslave/remote/remoteimpl.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, davidedmundson, #plasma
Cc: bshah, lbeltrame, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Abandoned] D3530: Import plasma-workspace kioslaves

[Elvis Angelaccio]

elvisangelaccio abandoned this revision.
elvisangelaccio added a comment.


  I've decided to keep it simple and only move `remote:/` for now. Please 
continue in https://phabricator.kde.org/D4690.

REVISION DETAIL
  https://phabricator.kde.org/D3530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #frameworks, #plasma, dfaure
Cc: mart, aacid, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 56 lines] D4689: IconItem: Add roundToIconSize property

[David Rosca]

drosca created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Disabling this property makes it possible to show icon of arbitrary size.

TEST PLAN
  Test passed

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4689

AFFECTED FILES
  autotests/iconitemtest.cpp
  autotests/iconitemtest.h
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D4688: [FrameSvgItemMargins] Don't update on repaintNeeded

[David Rosca]

drosca added a comment.


  Looks fine, but unfortunately it doesn't help with anything, the issue with 
networkmanager applet delegates is still there.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4688

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson, drosca
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4688: [FrameSvgItemMargins] Don't update on repaintNeeded

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4688

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, drosca, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Request, 1 line] D4688: [FrameSvgItemMargins] Don't update on repaintNeeded

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  FrameSvgItem already updates the margins in response to that.

TEST PLAN
  `FrameSvgItem` has
  
connect(m_frameSvg, SIGNAL(repaintNeeded()), this, SLOT(doUpdate()));
  
  and in doUpdate does
  
m_margins->update();
m_fixedMargins->update();
  
  I still get tons of binding loop warnings on e.g. "topMargin" in Plasma

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4688

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, drosca
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 15:29:47 +
Build duration: 10 min

CHANGE SET
Revision 0bfbecfc99e4e1939b79bb9be36d8151cb9ad332 by Jonathan Riddell: (Update 
version number for 5.9.1 GIT_SILENT)
  change: edit CMakeLists.txt
Revision d47c8c0b81c85de5ee8ae3e92c48ce9897f6c88c by Jonathan Riddell: (Update 
version number for 5.9.2 GIT_SILENT)
  change: edit CMakeLists.txt
Revision 8ff5388c22e07420dff970c5a33cf9dc81c58a5b by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit data/kde32b1.khotkeys
Revision bf57c786f01feee3737545c9c08882a2057ffbb8 by Marco Martin: (Fix build 
with -fno-operator-names)
  change: edit kcm_hotkeys/hotkeys_model.cpp
  change: edit libkhotkeysprivate/action_data/action_data_group.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 15:29:47 +
Build duration: 10 min

CHANGE SET
Revision 0bfbecfc99e4e1939b79bb9be36d8151cb9ad332 by Jonathan Riddell: (Update 
version number for 5.9.1 GIT_SILENT)
  change: edit CMakeLists.txt
Revision d47c8c0b81c85de5ee8ae3e92c48ce9897f6c88c by Jonathan Riddell: (Update 
version number for 5.9.2 GIT_SILENT)
  change: edit CMakeLists.txt
Revision 8ff5388c22e07420dff970c5a33cf9dc81c58a5b by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit data/kde32b1.khotkeys
Revision bf57c786f01feee3737545c9c08882a2057ffbb8 by Marco Martin: (Fix build 
with -fno-operator-names)
  change: edit kcm_hotkeys/hotkeys_model.cpp
  change: edit libkhotkeysprivate/action_data/action_data_group.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

[Differential] [Closed] D4687: Add page property that tells if the page is currently selected

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c5adb75fab0f: Add page property that tells if the page is 
currently selected (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4687?vs=11548&id=11549#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4687?vs=11548&id=11549

REVISION DETAIL
  https://phabricator.kde.org/D4687

AFFECTED FILES
  src/controls/Page.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

I've left the VDG group on Phabricator

[Thomas Pfeiffer]

Hi everyone,
just a heads-up: I have just left the VDG group on Phabricator.
This does not mean that I have a problem with the VDG or that I don’t identify 
as part of it anymore, but I have realized that I simply do not have the time 
and energy to keep up with the influx Phabricator requests anymore, and just 
disabling email notification would have meant lying to myself and everyone else.
If you need input on something specifically from me (e.g. if it’s a topic that 
I have been involved in in the past or one I’ve explicitly expressed interest 
in), please add me personally to it and I will reply, if there are not many of 
those.
The other requests will have to be handled by other VDG members.
Sorry about this, but me getting all the emails and ignoring them all won’t 
help anybody.
Cheers,
Thomas
 

[Differential] [Accepted] D4687: Add page property that tells if the page is currently selected

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> Page.qml:205
> + *
> + * Specifies if it's the currently selected page in the window's pages 
> row.
> + */

add @since 2.1

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Request, 7 lines] D4687: Add page property that tells if the page is currently selected

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Useful to be able to visually react to the page having the focus

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4687

AFFECTED FILES
  src/controls/Page.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

[Anthony Fieroni]

anthonyfieroni added a comment.


  Move mouse over taskmanager :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Accepted] D4671: Touchpad KCM: simplify few UI strings

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, subdiff, davidedmundson
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

[Harald Sitter]

sitter added a comment.


  Still does not crash.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated] D4671: Touchpad KCM: simplify few UI strings

[Luigi Toscano]

ltoscano added a reviewer: subdiff.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, subdiff
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 628 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/628/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 14:24:01 +
Build duration: 17 min

CHANGE SET
Revision 8aa83dff8e0fbb2e682fb7b861cedb4906584dc1 by scripty: (GIT_SILENT made 
messages (after extraction))
  change: edit org.kde.plasmashell.metainfo.xml
Revision aaabfdfe7180264b89300c60851dd008c5ba8a13 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/colors/colors.desktop
Revision c40fe1f37ba591eed32f8484a2a69c85ce24f059 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/colors/colorschemes.knsrc
  change: edit applets/trash/package/metadata.desktop
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit kcms/colors/colors.desktop
Revision 5db71b1ea6b5ff5693cb6647c7940720dfb2f0a6 by scripty: (GIT_SILENT made 
messages (after extraction))
  change: edit org.kde.plasmashell.metainfo.xml
Revision df0f9687b9f7978bf8a691067c2b3c49c0b0dbf2 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/useraccount/kcm_useraccount.desktop
  change: edit kcms/style/kcmstyle.notifyrc
  change: edit kcms/colors/colors.desktop
Revision c9a7741f2b8082f025b5eb2e53c3c489a95e1da8 by hein: (Use icon center for 
vertical hitscan on drop.)
  change: edit containments/desktop/package/contents/ui/FolderView.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 77 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/77/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 14:20:26 +
Build duration: 5 min 59 sec

CHANGE SET
Revision 8aa83dff8e0fbb2e682fb7b861cedb4906584dc1 by scripty: (GIT_SILENT made 
messages (after extraction))
  change: edit org.kde.plasmashell.metainfo.xml
Revision aaabfdfe7180264b89300c60851dd008c5ba8a13 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/colors/colors.desktop
Revision 5db71b1ea6b5ff5693cb6647c7940720dfb2f0a6 by scripty: (GIT_SILENT made 
messages (after extraction))
  change: edit org.kde.plasmashell.metainfo.xml
Revision df0f9687b9f7978bf8a691067c2b3c49c0b0dbf2 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/style/kcmstyle.notifyrc
  change: edit kcms/colors/colors.desktop
  change: edit kcms/useraccount/kcm_useraccount.desktop
Revision c9a7741f2b8082f025b5eb2e53c3c489a95e1da8 by hein: (Use icon center for 
vertical hitscan on drop.)
  change: edit containments/desktop/package/contents/ui/FolderView.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Updated, 4 lines] D4683: Use icon center for vertical hitscan on drop.

[Eike Hein]

hein updated this revision to Diff 11539.
hein added a comment.


  Remove missed debug.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4683?vs=11537&id=11539

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4683

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Closed] D4683: Use icon center for vertical hitscan on drop.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c9a7741f2b80: Use icon center for vertical hitscan on 
drop. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4683?vs=11539&id=11541

REVISION DETAIL
  https://phabricator.kde.org/D4683

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4683: Use icon center for vertical hitscan on drop.

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4683

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 6 lines] D4683: Use icon center for vertical hitscan on drop.

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Previously the delegate center was used, which can cause drops to
  land in lower grid cells than expected based on the key visual,
  which is the icon.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4683

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 79 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/79/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 13:17:14 +
Build duration: 14 min

CHANGE SET
Revision 513ad12b76a96d2919e1bbfae1c64ba9cfe72770 by kde: (Map StartupWMClass 
for Chrome apps instead of RegExp'ing the name)
  change: edit libtaskmanager/xwindowtasksmodel.cpp
  change: edit libtaskmanager/taskmanagerrulesrc


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5963 
(39%)CONDITIONAL 1631/5916 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3297 (6%)CONDITIONAL 
119/3239 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Closed] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:513ad12b76a9: Map StartupWMClass for Chrome apps instead 
of RegExp'ing the name (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4680?vs=11531&id=11535#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4680?vs=11531&id=11535

REVISION DETAIL
  https://phabricator.kde.org/D4680

AFFECTED FILES
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 1 line] D4681: [Logout Screen] Show suspend button only if supported

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 376601
  FIXED-IN: 5.8.7

TEST PLAN
  Button still shows up here since I can suspend. Changed value to false in 
ksmserver and it no longer showed up. Didn't actually try a polkit restriction. 
Key nav also works properly (ignoring the item) when it is hidden as per 
`KeyNavigation` docs.
  
  > If the item to which the focus is switching is not enabled or visible, an 
attempt will be made to skip this item and focus on the next.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4681

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Re: KMS backlight ABI proposition

[Martin Peres]

+plasma-devel, as suggested by Martin Gräßlin.


On 17/02/17 14:58, Martin Peres wrote:

Hey everyone,

We have been working towards exposing the backlight as a KMS property
instead of relying on the backlight drivers. We have CC:ed the people we
have found to be the more likely to be interested in the discussion but
please add everyone you think would have some experience with this issue.

== Introduction ==

We are trying to bring the same level of support for the backlight on
both the xf86-video-intel and -modesetting DDX.

Looking into the situation of the backlight, we identified these
problems which are almost show-stoppers for -modesetting and wayland
compositors:

 - There is no mapping between the backlight driver and DRM-connectors.
This means that, in case there are multiple backlight drivers, the
userspace has to have knowledge of the machine to know which driver
should be used. See the priority list for the intel driver [0].

 - The luminance curve of the backlight drivers is not specified, which
can lead to a bad user experience: Little changes in the highest levels
but drastic changes in the low levels.

 - Writing to the backlight driver still requires root rights. Given
that the xserver and wayland compositors are now running root-less, this
means we would need a complex dance involving a setuid helper [1].

Hans de Goede has already given a presentation about these issues at
XDC2014. The slides are a good read[2].

[0]
https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/backlight.c#n259


[1]
https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/backlight.c#n348


[2]
https://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/backlight.pdf

== Proposal ==

Since David Hermann already worked on this and proposed what I consider
being greats foundations for building towards a solution addressing the
issues above, I will just ask you to read his original words:

https://lists.freedesktop.org/archives/dri-devel/2014-September/067984.html

== Open issues ==

Here are the open issues we have identified with the solution proposed
by David:

  1) Backlight device interoperability: How far should we support
 mixing the backlight device and brightness property? Should it be
 unidirectional or bi-directional? What about the start-up value
 exposed by the brightness property?

  2) How many steps should be exposed: fixed or driver-dependent?

  3) Expected output curve: power? luminance? Simply monotonically
 increasing?

  4) Should the userspace be able to turn off the backlight? If so, how
 should it do it? What can we do to let the userspace distinguish
 between backlight off or on?

  5) Should we expose to the userspace what is the current backlight
 power?

Here is our current point of view on the matter:

=== 1) Backlight device interoperability ===

Since we need to keep backward compatibility of the backlight, we have
to keep the current backlight drivers.

Here are possible options:

 - Exclusive access: Unregister a backlight device when the drm
brightness property is requested/used;
 - Unidirectional access: When writing to the backlight property, update
the backlight device;
 - Bi-directional access: Propagate back changes from the backlight
device to the property's value.

Being bi-directional would be of course the best, but this requires that
both drivers have the same number of steps, otherwise, we may write a
value to the property, but get another one when reading it right after,
due to the non-bijective nature of the transformation.

Uni-directional would work in all cases, with the caveat that mixing
calls to the KMS property and the backlight device will not be supported
(changes mades through the sysfs interface of the backlight driver will
not be reflected in the KMS property). At boot time, we should however
initialize the value of the backlight property with a value close to
what is currently set in the backlight driver.

Giving exclusive access does not sound very good to me, as it would be
hard for the userspace to deal with disappearing drivers...

=== 2) How many steps should be exposed ===

If the KMS property exposes the same number of steps as the backlight
driver, it allows us to get a bijective function between the two
interfaces, and allow a bi-directional communication. The downside of
this is that it forces the userspace to deal with a variable number of
steps which can range from 4 to 1k+. Also, the userspace would be able
to handle the case where there are less steps than it would like to expose.

If the KMS property exposes a fixed number of steps (say 100), it
becomes easy for the userspace to express the wanted brightness.
However, on drivers exposing less than these 100 steps, we cannot
guarantee that any change in the value will produce any change. If there
is only one possible value (on or off), the user may be trying the
change the brightness, a GUI would show what is the expected backlight
state,

[Differential] [Accepted] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  And I guess the rule is only for apps and not Chrome's .desktop itself which 
distros may fuck up.
  
  OK then ... fine for 5.9 by me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

[Kai Uwe Broulik]

broulik added a comment.


  According to Chromium source code in `shell_integration_linux.cc` in 
`CreateAppListDesktopShortcut` (called by `CreateShortcuts`) it calls 
`GetDesktopFileContentsForCommand` which always ends up doing 
`g_key_file_set_string(key_file, kDesktopEntry, "StartupWMClass", 
wmclass.c_str());`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

[Eike Hein]

hein added a comment.


  How certain are you that .desktop files for Chrome usually specify a 
StartupWMClass?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 21 lines] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We only matched for the "Default" suffix which is the default profile but 
this breaks when having apps installed in different profiles where they get 
e.g. "Profile_1" suffix.
  
  BUG: 376695
  FIXED-IN: 5.10.0

TEST PLAN
  Could go into 5.9.3?
  
  My normal Chrome apps still work and I created a new second profile and its 
app now properly groups as separate app. Normale Chrome browser windows 
continue to work normally.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4680

AFFECTED FILES
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 78 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 12:07:58 +
Build duration: 14 min

CHANGE SET
Revision 2a3b74df75123678577161e4ea6b9549246ffdf0 by Elvis Angelaccio: 
([kioslave/remote] Fix broken kded module)
  change: edit kioslave/remote/kdedmodule/remotedirnotify.h
  change: edit kioslave/remote/kdedmodule/remotedirnotify.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5961 
(39%)CONDITIONAL 1631/5914 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3295 (6%)CONDITIONAL 
119/3237 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Closed] D4573: [kioslave/remote] Fix broken kded module

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2a3b74df7512: [kioslave/remote] Fix broken kded module 
(authored by elvisangelaccio).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4573?vs=11231&id=11529

REVISION DETAIL
  https://phabricator.kde.org/D4573

AFFECTED FILES
  kioslave/remote/kdedmodule/remotedirnotify.cpp
  kioslave/remote/kdedmodule/remotedirnotify.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4573: [kioslave/remote] Fix broken kded module

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4573

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4648: try harder to make the selected wallpaper visible

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4648#87129, @hein wrote:
  
  > I've used multiple techniques to do similar "do stuff when positioning is 
complete". One is using PropertyChange in populate transitions to change a prop 
when populate is done.
  >
  > I think Qt 5.9 will actually have an onPositioningComplete (at least for 
Flow).
  
  
  seems is only for positioners tough, not views (in which i guess it would be 
harder as the model can start to move things around at any moment)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4648

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 627 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/627/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 11:28:08 +
Build duration: 14 min

CHANGE SET
Revision 151bfb728ce8eed923f8e32ae39e345441af2f7b by Marco Martin: (use 
folderview as default containment)
  change: edit desktoppackage/contents/defaults


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

[Anthony Fieroni]

anthonyfieroni added a comment.


diff --git a/applets/taskmanager/plugin/backend.h 
b/applets/taskmanager/plugin/backend.h
index 87037c6..ef47344 100644
--- a/applets/taskmanager/plugin/backend.h
+++ b/applets/taskmanager/plugin/backend.h
@@ -104,6 +104,7 @@ class Backend : public QObject
 private:
 void updateWindowHighlight();
 
+int *abi_break = new int{1};
 QQuickItem *m_taskManagerItem;
 QQuickItem *m_toolTipItem;
 QQuickWindow *m_groupDialog;
make -j4
sudo cp libtaskmanagerplugin.so $(locate 
private/taskmanager/libtaskmanagerplugin.so)
  
  I don't want to make a crashes just for fun, i try to make hard to happen :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #vdg, dfaure, aacid
Cc: ltoscano, davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Updated, 127 lines] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Kai Uwe Broulik]

broulik updated this revision to Diff 11528.
broulik added a comment.


  - Drop Message.sh change

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4614?vs=11350&id=11528

REVISION DETAIL
  https://phabricator.kde.org/D4614

AFFECTED FILES
  src/CMakeLists.txt
  src/filepropertiesplugin/CMakeLists.txt
  src/filepropertiesplugin/baloofilepropertiesplugin.cpp
  src/filepropertiesplugin/baloofilepropertiesplugin.desktop
  src/filepropertiesplugin/baloofilepropertiesplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #vdg, dfaure, aacid
Cc: ltoscano, davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Minutes Monday Plasma Meeting

[Sebastian Kügler]

The meeting today was great.

It. Was. Great.

It really was!
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 20-02-2017

Present: romangg, d_ed, notmart, Sho_, kbroulik, bshah, sebas

romangg:
* last week I mainly worked on my SoK project: https://phabricator.kde.org/D4539
  Diff 4539 "[WIP][Drm Backend] Direct Buffer Scanout and Atomic Modesetting 
improvements" [Needs Review] https://phabricator.kde.org/D4539
* There's also this additional cursor, which needs a review: 
https://phabricator.kde.org/D4358
  Diff 4358 "[cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow 
Cursors" [Needs Review] https://phabricator.kde.org/D4358
* I made a task to imrpvoe Plasma PA applet and KCM: 
https://phabricator.kde.org/T5412
  Task 5412 "Improve Plasma PA usability" [Open,Needs Triage] {Plasma,VDG} 
https://phabricator.kde.org/T5412

d_ed:
* I did progress with my wayland compositor in a QQuickItem project, for making 
a QtQuick system settings
* I've pushed it here kde:scrach/david/waylandcompositoritem (just now, so 
might take a while)
* I managed to get sub windows (like a file open dialog) to render outside the 
compositor, but proxying that surface upwards

notmart:
* work on drop menus merge:
** KIO: -> merged
** plasma-desktop -> merged
** plasma-framework -> merged
* fixed loading kpackages directly from tarball -> merged
* folderview as default -> merged
* plasma themed QQC2: https://phabricator.kde.org/D4508
Diff 4508 "[WIP] Plasma controls based on QtQuickControls2" [Needs Review] 
https://phabricator.kde.org/D4508
* preview thumbnail for the disk quota plasmoid in the breeze icon theme -> 
merged
* https://phabricator.kde.org/D4648 try harder at a workaroundfor proper item 
visible on wallpaper config
Diff 4648 "try harder to make the selected wallpaper visible" [Needs Review] 
https://phabricator.kde.org/D4648
* Kirigami2:
** fixed pull to refresh when a listview has a custom header: needed for how 
discover does headers, that may soon become a standard component in kirigami
correction on last point: discover-style listview headers did become a standard 
component, didn't notice it was slightly outdated

kbroulik:
* We now have media controls on the lock screen \o/
* Backported to 5.8 a fix for a notification popup placement glitch
* We now have "Jump List Actions" in Task Manager for Dolphin (any app that has 
"FileManager" category) that list your Places (e.g. Downloads folder)
* Found an interesting article wrt (perceived) security 
https://medium.com/@cassidyjames/secure-by-default-689abcac6c66#.fmejj9o7d has 
some nice ideas we could evaluate for Plasma

Sho:
* [TM] Fixed regression breaking manual reordering of pinned apps, happened 
with the per-activity launcher rework
* [TM] Fixed a crash when switching between activities with different 
launchers/windows
* [TM] Finished and merged user-requested overhaul of alphabetic sorting 
behavior
* [TM] Fixed a super obscure crash in libtm's transients-demanding-attention 
handling that needed weird wine app custom notification bubbles to root out
* [TM] While doing the above optimized transient handling for performance, 
saving model data changes and excessive loops
* [TM] Fixed regression causing tasks to be pinned while doing manual resorting 
via DND
** Lately I fix a lot of bugs introduced by other people's commits - somehow I 
need to improve my review performance to catch it earlier
* [Launchers] Reviewed Ivan's per-activity favorites work
* [Launchers] Still looking into Maui's problems with KServiceGroup 
childCount() handling for menu categories affected by .kmenu exclude directives
* [FV] Currently reworking the economics of icon DND on the desktop a bit to 
better match expectations for where things end up on drops
* [Other] Bunch of smaller bugfix things in the pipe, weekend tickets and the 
like

bshah:
* Getting systemd working inside android lxc container
* and also today morning working on fixing the issue of the flashtool

sebas:
- Was in contact with a phone maker, we talked and I explained, they may show 
up on the Plasma list for questions
- They asked to keep details outside of the public, so I'm channeling info to 
the right people
- checking on a large scale enterprise Plasma setup to see if they're doing OK, 
together with Kai
- Nothing else directly Plasma related to report, not sure this changes this 
week
- need to finish the dot story




IRC Log:
[11:59:30]  Meeting... :)
[11:59:34]  Who'
[11:59:36]  s there?
[12:01:05]  I'm here
[12:01:09] <-- nowrep (~david@kde/developer/drosca) has quit (Quit: 
Konversation terminated!)
[12:01:14]  I'm also here
[12:01:18]  here
[12:01:24]  can I go first. need to leave early.
[12:01:56]  sure, romangg't turn
[12:02:02]  and hey guys
[12:02:47]  hello! :) last week I mainly worked on my SoK project: 
https://phabricator.kde.org/D4539
[12:02:48]  Diff 4539 "[WIP][Drm Backend] Direct Buffer Scanout and 
Atomic Modesetting improvements" [Needs Review] 

[Differential] [Closed] D4678: use folderview as default containment

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:151bfb728ce8: use folderview as default containment 
(authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4678?vs=11524&id=11527

REVISION DETAIL
  https://phabricator.kde.org/D4678

AFFECTED FILES
  desktoppackage/contents/defaults

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 11 lines] D4679: [ConfigView] Honor KIOSK Control Module restrictions

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

TEST PLAN
  Placed the following in kdeglobals
  
[KDE Control Module Restrictions]
kcm_pulseaudio.desktop=false
  
  No longer got "Volume" thing in volume applet settings.
  
  Plasma doesn't find KCMs when you add `.desktop` to the applet's metadata 
file, so always appending `.desktop` is fine imho.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4679

AFFECTED FILES
  src/plasmaquick/configview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Updated, 47 lines] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

[David Rosca]

drosca updated this revision to Diff 11525.
drosca added a comment.


  Use cache everywhere

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4674?vs=11515&id=11525

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4674

AFFECTED FILES
  src/streamrestore.cpp
  src/streamrestore.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4675: Applet: Add configure button next to tabbar

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  applet-settings-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> streamrestore.cpp:154
>  vol.values[channel] = volume;
>  writeChanges(vol, m_channelMap, m_muted, m_device);
>  }

You can see here what the problem is, I forgot to add the same logic here (it 
doesn't use cache).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

[David Rosca]

drosca added a comment.


  > why does that make it broke?
  
  From QML side, we call:
  
stream.setVolume(0);
stream.setMuted(true);
  
  and on the C++ side it turns to
  
// Lets say the current state of C++ object is: muted = false, vol = 20
setVolume(0) -> writeChanges(vol = 0, ..., muted = false, ...);
setMuted(true) -> writeChanges(vol = 20, ..., muted = true);
  
  The problem is that on the C++ side, we only hold values received from 
pulseaudio, not intermediate values set from the QML side.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

[David Edmundson]

davidedmundson added a comment.


  > Fixes correctly muting Notification Sounds stream in KCM when moving
  
  slider to 0 value, because in that moment the KCM first sets volume to 0
  and then immediately mute to true.
  
  Sorry to be a noob, why does that make it broke?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4678: use folderview as default containment

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/folderviewdef

REVISION DETAIL
  https://phabricator.kde.org/D4678

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 626 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/626/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 10:24:25 +
Build duration: 6 min 20 sec

CHANGE SET
Revision 239e2be33fa08a703473c6178c39b940f3bf1f36 by Marco Martin: ([WIP]: 
unify file drop menu and containment)
  change: edit containments/desktop/plugins/folder/foldermodel.h
  change: edit containments/desktop/package/contents/ui/FolderView.qml
  change: edit containments/desktop/plugins/folder/foldermodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Request, 2 lines] D4678: use folderview as default containment

[Marco Martin]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  now it's possible to do as the drop menu is unified

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/folderviewdef

REVISION DETAIL
  https://phabricator.kde.org/D4678

AFFECTED FILES
  desktoppackage/contents/defaults

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Closed] D4576: integrate drop menu and filecopy drop menu

[Marco Martin]

mart closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4576

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, hein
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D4576: integrate drop menu and filecopy drop menu

[Marco Martin]

mart retitled this revision from "[WIP]: integrate drop menu and filecopy drop 
menu" to "integrate drop menu and filecopy drop menu".

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D4576

REVISION DETAIL
  https://phabricator.kde.org/D4576

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, hein
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4620: allow to add application actions on an open menu

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c1bbe00181b0: allow to add application actions on an open 
menu (authored by mart).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4620?vs=11521&id=11522

REVISION DETAIL
  https://phabricator.kde.org/D4620

AFFECTED FILES
  src/widgets/dropjob.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure
Cc: dfaure, hein, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4574: [WIP]: unify file drop menu and containment

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:239e2be33fa0: [WIP]: unify file drop menu and containment 
(authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4574?vs=11370&id=11523

REVISION DETAIL
  https://phabricator.kde.org/D4574

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, hein, #plasma
Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated, 23 lines] D4620: allow to add application actions on an open menu

[Marco Martin]

mart updated this revision to Diff 11521.
mart added a comment.


  don't remove separators
  
  qmenu collpapses them and previous code might have assert

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4620?vs=11402&id=11521

BRANCH
  arcpatch-D4620

REVISION DETAIL
  https://phabricator.kde.org/D4620

AFFECTED FILES
  src/widgets/dropjob.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure
Cc: dfaure, hein, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 24 lines] D4677: Applet: Show info message when no devices found / applications playing audio

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  May probably need change of wording a bit

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  applet-no-streams-msg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4677

AFFECTED FILES
  applet/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4677: Applet: Show info message when no devices found / applications playing audio

[David Rosca]

drosca added a comment.


  F2514343: Spectacle.VEa651.png 
  
  F2514345: Spectacle.bhc651.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4677

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4676: Applet: Remember last active tab

[David Rosca]

drosca added a comment.


  The devices tab is now always visible when user first opens the applet. But 
in the basic use-case where you have just one output device and you control its 
volume with global volume shortcuts, you want to adjust volume of applications 
when you open the applet. So it either should be configurable which tab to make 
default, or remember the last tab.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: bshah, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4676: Applet: Remember last active tab

[Bhushan Shah]

bshah added a comment.


  -1, I believe this can be super annoying if it remembers the active tab from 
last session.. and in general it is more like "magic" behavior.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: bshah, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated, 33 lines] D4675: Applet: Add configure button next to tabbar

[David Rosca]

drosca updated this revision to Diff 11519.
drosca added a comment.


  Fixed issues

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4675?vs=11516&id=11519

BRANCH
  applet-settings-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4675

AFFECTED FILES
  applet/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Request, 19 lines] D4676: Applet: Remember last active tab

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  switched to apps -> restarted plasmashell -> apps was current tab

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  remember-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4676

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

[Eike Hein]

hein added a comment.


  It's worth keeping in mind KDE stuff has never supported runtime updates. 
Consider e.g. kconf_update, which runs while apps run, and apps can undo its 
changes on quit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4600: TaskManager: add icon to cache after painfully querying it over XCB/NETWM.

[Eike Hein]

hein added a comment.


  Yep. The first string is called "Instance" and the second is called "Class". 
I.e. the latter is supposed to represent the application, the former is 
supposed to represent a unique instance of it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4600

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Changed Subscribers] D4675: Applet: Add configure button next to tabbar

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:299
> +Layout.alignment: Qt.AlignBottom
> +tooltip: i18n("Configure Volume Settings...")
> +iconSource: "configure"

Just use

  plasmoid.action("configure").text

> main.qml:300
> +tooltip: i18n("Configure Volume Settings...")
> +iconSource: "configure"
> +onClicked: {

Rather use `iconName`?

> main.qml:304
> +}
>  }
>  }

Please also add e.g.

  Accessible.text: tooltip

since the button has no text

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4675: Applet: Add configure button next to tabbar

[David Rosca]

drosca added a comment.


  F2514281: Spectacle.b20805.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

[Harald Sitter]

sitter added a comment.


  Provide a diff so we can reproduce?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 32 lines] D4675: Applet: Add configure button next to tabbar

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 365282
  FIXED-IN: 5.10

TEST PLAN
  Clicked button, opened settings

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  applet-settings-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4675

AFFECTED FILES
  applet/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

[Anthony Fieroni]

anthonyfieroni added a comment.


  I'm a bit pretty harsh, add other private variable and handcopy newly plugin 
e.g. sudo cp libtaskmanagerplugin.so $(locate 
private/taskmanager/libtaskmanagerplugin.so)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4140: Rework playing of volume feedback

[David Rosca]

drosca added a comment.


  Ping. The issue pointed by @broulik have now been fixed, it only plays 
feedback for volume changes made by the applet.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4140

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Abandoned] D4138: Only update mute state after volume change is signalled from PA

[David Rosca]

drosca abandoned this revision.
drosca added a comment.


  Replaced with https://phabricator.kde.org/D4674

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4138

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 36 lines] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  pa_ext_stream_restore have only one function to change all its
  properties, so we need to cache values between clients changing
  StreamRestore properties and pulseaudio actually signaling the property
  was changed.
  
  Fixes correctly muting Notification Sounds stream in KCM when moving
  slider to 0 value, because in that moment the KCM first sets volume to 0
  and then immediately mute to true.

TEST PLAN
  Changing notification sounds volume with slider works correctlu now

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4674

AFFECTED FILES
  src/streamrestore.cpp
  src/streamrestore.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[plasmashell] [Bug 370464] On reboot desktop wallpaper settings are forgotten

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=370464

Harald Sitter  changed:

   What|Removed |Added

Product|Plasma Workspace Wallpapers |plasmashell
   Target Milestone|--- |1.0
  Component|general |Image Wallpaper
   Assignee|plasma-devel@kde.org|notm...@gmail.com
 CC||plasma-b...@kde.org,
   ||sit...@kde.org

--- Comment #2 from Harald Sitter  ---
Wrong product "Wallpapers shipping with Plasma 5" != wallpaper settings.

Moving to plasmashell

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Plasma Workspace Wallpapers] [Bug 370464] On reboot desktop wallpaper settings are forgotten

[davidblunkett]

https://bugs.kde.org/show_bug.cgi?id=370464

--- Comment #1 from davidblunkett  ---
Anyone?

Where are the desktop wallpapers settings stored? I'm pretty sick of this bug
and would happily hard-wire the wallpaper at this point...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

[Harald Sitter]

sitter added a comment.


  You could just build an autotest maybe? 👅
  
  So, let's try with the previously mentioned 
https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9&id=dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e
  
  I am doing:
  
git clone --branch Plasma/5.9 kde:plasma-desktop
git revert dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e
cmake && make && make install
kquitapp plasmashell
git revert HEAD # revert the revert to apply the change again
make && make install
  
  I do not observe a crash with this. Nor would I expect one because, as 
davidedmundson pointed out, the new plugin library would not get loaded until 
plasmashell is restarted. Maybe I am testing incorrectly though.
  
  But to verify the file loading let's check the process map. This is loaded at 
first:
  
$ pmap -X -p `pidof plasmashell` | grep 
private/taskmanager/libtaskmanagerplugin
7f1723dd8000 r-xp    00:15 10808567 152152152   
 152 0  0  0   00   0  
0 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
7f1723dfe000 ---p  00026000  00:15 108085672048  0  0   
   0 0  0  0   00   0  
0 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
7f1723ffe000 r--p  00026000  00:15 10808567   4  4  4   
   4 4  0  0   00   0  
0 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
7f1723fff000 rw-p  00027000  00:15 10808567   4  4  4   
   4 4  0  0   00   0  
0 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
  
  Notably, the file is inode `10808567`. So, I bring back the change and 
install again:
  
$ pmap -X -p `pidof plasmashell` | grep 
private/taskmanager/libtaskmanagerplugin
7f1723dd8000 r-xp    00:15 10808567 152152152   
 152 0  0  0   00   0  
0 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
 (deleted)
7f1723dfe000 ---p  00026000  00:15 108085672048  0  0   
   0 0  0  0   00   0  
0 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
 (deleted)
7f1723ffe000 r--p  00026000  00:15 10808567   4  4  4   
   4 4  0  0   00   0  
0 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
 (deleted)
7f1723fff000 rw-p  00027000  00:15 10808567   4  4  4   
   4 4  0  0   00   0  
0 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
 (deleted)
  
  As indicated by pmap we still have the same library loaded and as indicated 
the backing file is now deleted from disk.
  
  Checking the newly installed file we'll also see it having a different inode.
  
$ ls -li 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
10808655 -rw-r--r-- 1 root root 2259408 Feb 20 09:30 
/usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
  
  So, clearly the new library was not loaded, and I honestly fail to imagine a 
scenario where it would get loaded even though we have the file loaded already.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol