Re: Plasma 5.9.4

[Tobias C. Berner]

Hi

it seems the tarballs were respun after the announcement. Could you in the
future, please give a little notice of that?


mfg Tobias

On 21 March 2017 at 15:53, Jonathan Riddell  wrote:

> Out now
> https://www.kde.org/announcements/plasma-5.9.4.php
>

D5144: Change the volume icon/mute button into a ToolButton

[Roman Gilg]

subdiff added a reviewer: Plasma.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[Roman Gilg]

subdiff added subscribers: drosca, subdiff.
subdiff accepted this revision.
subdiff added a comment.
This revision is now accepted and ready to land.


  Looks very nice. I also don't think that the hover line looks weird. It's 
just a little bit stupid, that for these small buttons we always have to use 
the workaround with the IconItem. Can't we introduce a parameter in ToolButton 
to reduce the margins from its native icon? But this is unrelated to this 
patch. So accepted from my side. @drosca ?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: Plasma 5.9.4

[Jonathan Riddell]

There was no respin after the announcement, what makes you think there was?

Jonathan


On Thu, Mar 23, 2017 at 08:16:42AM +0100, Tobias C. Berner wrote:
> Hi
> 
> it seems the tarballs were respun after the announcement. Could you in the
> future, please give a little notice of that?
> 
> 
> mfg Tobias
> 
> On 21 March 2017 at 15:53, Jonathan Riddell  wrote:
> 
> Out now
> https://www.kde.org/announcements/plasma-5.9.4.php
> 
> 

Re: Plasma 5.9.4

[Tobias C. Berner]

Hi

Well, I definitely had changes here.

The file size and checksums of discover kactivitymanagerd kde-cli-tools
kdeplasma-addons ksysguard kwayland-integration plasma-desktop
plasma-workspace-wallpapers powerdevil user-manager changed:
https://src.mouf.net/area51/revision/?rev=13790
and plasma-desktop and plasma-powerdevil bumped so-versions from the 5.9.3
to 5.9.4:
https://src.mouf.net/area51/revision/?rev=13791


So at least for some time, there were different tarballs there.


mfg Tobias


On 23 March 2017 at 09:57, Jonathan Riddell  wrote:

>
> There was no respin after the announcement, what makes you think there was?
>
> Jonathan
>
>
> On Thu, Mar 23, 2017 at 08:16:42AM +0100, Tobias C. Berner wrote:
> > Hi
> >
> > it seems the tarballs were respun after the announcement. Could you in
> the
> > future, please give a little notice of that?
> >
> >
> > mfg Tobias
> >
> > On 21 March 2017 at 15:53, Jonathan Riddell  wrote:
> >
> > Out now
> > https://www.kde.org/announcements/plasma-5.9.4.php
> >
> >
>

Re: Plasma 5.9.4

[Rik Mills]

Re-spun *before* the announcement email @ 14:53 UTC if I recall from IRC.

If you grabbed the tarballs beforehand, then yes you may the have ones
prior to the respin?

On 23/03/17 07:16, Tobias C. Berner wrote:
> Hi
> 
> it seems the tarballs were respun after the announcement. Could you in
> the future, please give a little notice of that?
> 
> 
> mfg Tobias
> 
> On 21 March 2017 at 15:53, Jonathan Riddell  > wrote:
> 
> Out now
> https://www.kde.org/announcements/plasma-5.9.4.php
> 
> 
> 

Re: Plasma 5.9.4

[Tobias C. Berner]

Well, I started to update this only *after* I read the announcement mail
(according to my memory 16:30-ish CET).
1490110785 is 03/21/2017 15:39 (UTC)... so well after that :

So probably the mirror used to fetch the files was not yet synced?

On 23 March 2017 at 10:28, Rik Mills  wrote:

> Re-spun *before* the announcement email @ 14:53 UTC if I recall from IRC.
>
> If you grabbed the tarballs beforehand, then yes you may the have ones
> prior to the respin?
>
> On 23/03/17 07:16, Tobias C. Berner wrote:
> > Hi
> >
> > it seems the tarballs were respun after the announcement. Could you in
> > the future, please give a little notice of that?
> >
> >
> > mfg Tobias
> >
> > On 21 March 2017 at 15:53, Jonathan Riddell  > > wrote:
> >
> > Out now
> > https://www.kde.org/announcements/plasma-5.9.4.php
> > 
> >
> >
>
>

D5145: Mark "all categories missing" kns sources as invalid

[Dan Leinir Turthra Jensen]

leinir created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KNS being, at times, a little twitchy means that we have to handle
  such things a bit more gracefully. As such, without this code,
  the KNS backend would remain in a perpetial search state after
  startup, which would result in inconsistencies.
  
  Implement UI feedback for long-running searches, and no-results
  
  If a search takes longer than a couple of seconds, a spinner
  will face-and-slide in from the bottom of the view. If it then
  takes a while longer, a text saying "Still looking" will fade in
  very slowly. If the search is near-instant (the general case),
  the spinner does not show up.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5145

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5145: Mark "all categories missing" kns sources as invalid

[Dan Leinir Turthra Jensen]

leinir abandoned this revision.
leinir added a comment.


  That, apparently, is not how arc works. Very sorry.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5145

To: leinir
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5137: Add support for screenedge touchscreen events through XInput 2.2

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in xinputintegration.cpp:132
> I think we want to always update m_lastTouchPositions outside of 
> if (e->detail == m_trackingTouchId)
> 
> otherwise if we get:
> 
> TouchBegin
> TouchUpdate
> TouchOwnership
> 
> we start the gesture in the wrong position

Sorry that's not quite what i meant

m_lastTouchPositions now needs to use e->detail

And the gestureRecognizer stuff should still be inside the if.

REVISION DETAIL
  https://phabricator.kde.org/D5137

To: graesslin, #plasma, #kwin
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5146: Implement UI feedback for long-running searches, and no-results

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If a search takes longer than a couple of seconds, a spinner will 
face-and-slide in from the bottom of the view. If it then takes a while longer, 
a text saying "Still looking" will fade in very slowly. If the search is 
near-instant (the general case), the spinner does not show up.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5146

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: leinir, apol, #vdg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5147: Mark "all categories missing" kns sources as invalid

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KNS being, at times, a little twitchy means that we have to handle such 
things a bit more gracefully. As such, without this code, the KNS backend would 
remain in a perpetial search state after startup, which would result in 
inconsistencies.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5147

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5148: Use the back function, rather than pop, when pressing Escape

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This stops things suddenly just disappearing and leaving us with a grey 
central area. It also ensures that the functionality will both look and feel 
more like how the back functionality (which would be how the visual 
implementation would be done) would eventually end up.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5148

AFFECTED FILES
  discover/qml/DiscoverPage.qml

To: leinir, apol, #discover_software_store
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5149: Cache screenshots to avoid downloading them over and over

[Jan Grulich]

jgrulich added a reviewer: apol.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5149

To: jgrulich, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5149: Cache screenshots to avoid downloading them over and over

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This makes screenshots to be stored in cache and used next time from cache. 
Right
  now the backend downloads them over and over, which sometimes take a while 
and also
  saves data usage.

REPOSITORY
  R134 Discover Software Store

BRANCH
  screenshot-caching

REVISION DETAIL
  https://phabricator.kde.org/D5149

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
  libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp
  libdiscover/resources/AbstractResource.cpp
  libdiscover/resources/AbstractResource.h

To: jgrulich
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  I don't like it, the context menu button is enough hacks for one applet. Also 
it doesn't have spacing so it looks wrong compared to other ToolButtons (contex 
menu have spacing, but the icon size is still iconSizes.small).
  If we want to use ToolButtons in this way, it should be fixed in ToolButton.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5086: Applet: Add Raise maximum volume action to context menu

[David Rosca]

drosca added a comment.


  > There's one issue I want to point out that I dealt with, is that other 
instances of the widget won't be in the "raised" state (eg: other screens).
  
  Multiple instances have also separate settings, so I don't see this as an 
issue.
  
  However, it is possible that other apps raise volume above 100% (eg. vlc) and 
you won't be able to change it (only lower down to maximum - 100% or according 
to applet settings), so this should be taken care of (raise temporarily as long 
as the value is above maximum). But this should go in another commit.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5086

To: drosca, #plasma
Cc: Zren, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

T5412: Improve Plasma PA usability

[David Rosca]

drosca added a comment.


  > Breeze's 16px small microphone-sensitivity-[low/medium/high] icons do not 
follow the color scheme.
  
  https://bugs.kde.org/show_bug.cgi?id=377012

TASK DETAIL
  https://phabricator.kde.org/T5412

To: drosca
Cc: davidk, vpilo, Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mbohlender

D5127: Switch to newer KDevelop API

[Jonathan Riddell]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:4a24c7d3ca10: Switch to newer KDevelop API (authored by 
jriddell).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5127?vs=12680&id=12724

REVISION DETAIL
  https://phabricator.kde.org/D5127

AFFECTED FILES
  plasmate/plugins/savesystemview/git.cpp

To: jriddell, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[Roman Gilg]

subdiff added a comment.


  > I don't like it, the context menu button is enough hacks for one applet.
  
  The "hack" is consistent with the one of context menu button.
  
  I think the improved discoverability outweighs your objections. We can use 
this here until someone diggs deeper and improves ToolButton in this regard.
  
  @Zren: Can you tell me why your icon looks different from mine and why on my 
I still have a small (and nice) margin:
  F3149213: tempmicro.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[David Rosca]

drosca added a comment.


  > The "hack" is consistent with the one of context menu button.
  
  It's not, context menu button have spacing
  
  > I think the improved discoverability outweighs your objections. We can use 
this here until someone diggs deeper and improves ToolButton in this regard.
  
  If we go with this, it must be moved into a separate item, let's say 
SmallToolButton.qml
  
  > @Zren: Can you tell me why your icon looks different from mine and why on 
my I still have a small (and nice) margin:
  
  Because you use scaling and 22px version of the icon has bigger margins.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5149: Cache screenshots to avoid downloading them over and over

[Aleix Pol Gonzalez]

apol added a comment.


  Please try using QNetworkDiskCache.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5149

To: jgrulich, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5149: Cache screenshots to avoid downloading them over and over

[Aleix Pol Gonzalez]

apol requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5149

To: jgrulich, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5146: Implement UI feedback for long-running searches, and no-results

[Marco Martin]

mart added a comment.


  just an heads up: ui reviews with VDG as reviewers should have a screenshot 
attached

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5146

To: leinir, apol, #vdg
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5147: Mark "all categories missing" kns sources as invalid

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> KNSBackend.cpp:111
>  // Setting setFetching to false when we get an error ensures we don't 
> end up in an eternally-fetching state
> -connect(m_engine, &KNSCore::Engine::signalError, this, [this](const 
> QString &error) { this->setFetching(false); qWarning() << "kns error" << 
> objectName() << error; });
> +connect(m_engine, &KNSCore::Engine::signalError, this, [this](const 
> QString &error) {
> +if(error == QLatin1Literal("All categories are missing")) {

Could be moved into a proper slot?

> KNSBackend.cpp:200
>  }
> -// qDebug() << "received" << this << m_page << m_resourcesByName.count();
> +// qDebug() << "received" << objectName() << this << m_page << 
> m_resourcesByName.count();
>  if (!m_responsePending) {

Unrelated change

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5147

To: leinir, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5147: Mark "all categories missing" kns sources as invalid

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5147

To: leinir, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5148: Use the back function, rather than pop, when pressing Escape

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5148

To: leinir, apol, #discover_software_store
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5146: Implement UI feedback for long-running searches, and no-results

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5146

To: leinir, apol, #vdg
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5147: Mark "all categories missing" kns sources as invalid

[Dan Leinir Turthra Jensen]

leinir closed this revision.
leinir added a comment.


  Closed by commit 1db3b40cc4f979cc8c50dcfc1a41cddcce973ae7

INLINE COMMENTS

> apol wrote in KNSBackend.cpp:111
> Could be moved into a proper slot?

It /is/ starting to be more than trivial code in there, that'd make sense, 
yeah. i'm sure this won't be the last time changes happen to the kns error 
handling code, i'll move it into a proper slot next time 'round :)

> apol wrote in KNSBackend.cpp:200
> Unrelated change

Ah, yes, so it is! Was tracking where things were breaking and whatnot, and 
thought it'd probably be useful to keep that modification for future similar 
tracking of things :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5147

To: leinir, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5146: Implement UI feedback for long-running searches, and no-results

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In https://phabricator.kde.org/D5146#97069, @mart wrote:
  
  > just an heads up: ui reviews with VDG as reviewers should have a screenshot 
attached
  
  
  Ah, thank you yes - there /is/ a video which some of the VDG has already seen 
on the Discover telegram group, but it turns out that posting such a thing 
isn't quite as straightforward as i'd hoped it would be... imgur does not allow 
for a straightforward upload of videos like that ;) i will just pop it up on my 
own host and link it in the description.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5146

To: leinir, apol, #vdg
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5146: Implement UI feedback for long-running searches, and no-results

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5146

To: leinir, apol, #vdg
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5148: Use the back function, rather than pop, when pressing Escape

[Dan Leinir Turthra Jensen]

leinir closed this revision.
leinir added a comment.


  Closed by commit efe7d505eb294b11cc6d513ed8448cd5b8eab668

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5148

To: leinir, apol, #discover_software_store
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4969: open applet handles when the toolbox is open

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/toolboxeditmode

REVISION DETAIL
  https://phabricator.kde.org/D4969

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

cleaning up phabricator

[Marco Martin]

Hi all,
I'm seeing a lot of old reviews for plasma in phabricator, a lot of them seems 
abandoned since several months, i would like to keep it reasonably clean, 
especially to not risk to lose potentially useful work.
Can i ask a thing to everybody that has reviews in phab, look at all their 
requests (in query, query on open and for yourself as author) and for all ones 
especially if not touched for more than a couple of weeks, either abandon them 
if they are not valid anymore, or adapt them to current master and continue 
the workflow, if the reviews are still valid/still make sense (even just write 
so in the review comments that it should be good to continue and don't need to 
be updated/adapted yet)
thx :)
-- 
Marco Martin

D4969: open applet handles when the toolbox is open

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e635931e433c: open applet handles when the toolbox is 
open (authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4969?vs=12269&id=12731

REVISION DETAIL
  https://phabricator.kde.org/D4969

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/main.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 672 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/672/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 23 Mar 2017 13:08:41 +
Build duration: 6 min 13 sec

CHANGE SET
Revision e635931e433cb31d1fe23e40c8af625a8f7c24f2 by Marco Martin: (open applet 
handles when the toolbox is open)
  change: edit containments/desktop/package/contents/ui/main.qml
  change: edit toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  change: edit toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  change: edit toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  change: edit containments/desktop/package/contents/ui/AppletAppearance.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 856 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/856/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 23 Mar 2017 13:17:21 +
Build duration: 12 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

D5153: add a new property in containment, for an edit mode

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  used for opening the handles when the toolbox is open
  or potentially other places

TEST PLAN
  handles open

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editMode

REVISION DETAIL
  https://phabricator.kde.org/D5153

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: mart, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5154: use new property plasmoid.editMode

[Marco Martin]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  toolboxes set editmode by themselves
  possible for toerh things to trigger edit mode now

TEST PLAN
  handles open correctly

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/editmode

REVISION DETAIL
  https://phabricator.kde.org/D5154

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma, davidedmundson
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5153: add a new property in containment, for an edit mode

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editMode

REVISION DETAIL
  https://phabricator.kde.org/D5153

To: mart, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5154: use new property plasmoid.editMode

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/editmode

REVISION DETAIL
  https://phabricator.kde.org/D5154

To: mart, #plasma, davidedmundson
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5154: use new property plasmoid.editMode

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c8181c9fe8eb: use new property plasmoid.editMode 
(authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5154?vs=12734&id=12736

REVISION DETAIL
  https://phabricator.kde.org/D5154

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma, davidedmundson
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5153: add a new property in containment, for an edit mode

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:244baaf92864: add a new property in containment, for an 
edit mode (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5153?vs=12733&id=12735

REVISION DETAIL
  https://phabricator.kde.org/D5153

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: mart, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 673 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/673/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 23 Mar 2017 14:23:59 +
Build duration: 16 min

CHANGE SET
Revision c8181c9fe8ebaf45a5fdbadc3ad6d76059d91f82 by Marco Martin: (use new 
property plasmoid.editMode)
  change: edit containments/desktop/package/contents/ui/AppletAppearance.qml
  change: edit toolboxes/paneltoolbox/contents/ui/main.qml
  change: edit toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 857 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/857/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 23 Mar 2017 14:41:55 +
Build duration: 8 min 20 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 857 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/857/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 23 Mar 2017 14:41:55 +
Build duration: 8 min 20 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

D5149: Cache screenshots to avoid downloading them over and over

[Jan Grulich]

jgrulich abandoned this revision.
jgrulich added a comment.


  Using more simple and different approach.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5149

To: jgrulich, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

rikmills added a comment.


  I note that in recent Breeze, the native scrollbar are a fair amount thinner, 
so maybe a reduction in width here by 2 px may look/match better?
  
  e.g.
  
  F3154031: a87f589636.png 

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5128

To: rikmills, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[Chris Holland]

Zren added a comment.


  Yeah, it's probably dpi scaling.
  
  And I didn't want to mess with the height of the ListItemBase. On further 
testing, it seems adding smallSpacing margins isn't as bad as I thought.
  
  Back and Forth Gif: https://streamable.com/0ld55
  
  F3154040: 2017-03-23___11-12-55.png 
  F3154037: 2017-03-23___11-14-42.png 
  
  If the increase in height is acceptable, I'll make a SmallToolButton
  
PlasmaComponents.ToolButton {
id: smallToolButton
property int iconSize: units.iconSizes.small
property int padding: units.smallSpacing
implicitWidth: iconSize + padding * 2
implicitHeight: iconSize + padding * 2
Layout.preferredWidth: implicitWidth
Layout.preferredHeight: implicitHeight
property alias icon: icon.source

PlasmaCore.IconItem {
id: icon
anchors.fill: parent
anchors.margins: parent.padding
visible: false

// From Plasma's ToolButtonStyle:
active: parent.hovered
colorGroup: parent.hovered ? PlasmaCore.Theme.ButtonColorGroup : 
PlasmaCore.ColorScope.colorGroup
}
}

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[Chris Holland]

Zren added a comment.


  Ah, ignore the `visible: false` in that, was testing which variables 
ToolButton uses (iconSource. iconName).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[Chris Holland]

Zren added a comment.


  Another thing we could do to keep things small vertically is set `spacing: 0` 
in the `ColumnLayout { id: column }`.
  
  F3154383: 2017-03-23___11-50-47.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[Chris Holland]

Zren updated this revision to Diff 12746.
Zren added a comment.


  Create a reusuble SmallToolButton class.
  Add smallSpacing around the mute button.
  Remove spacing between the two rows to counter the increase in height.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5144?vs=12713&id=12746

REVISION DETAIL
  https://phabricator.kde.org/D5144

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/SmallToolButton.qml

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> SmallToolButton.qml:11
> +property int padding: units.smallSpacing
> +Layout.preferredWidth: iconSize + padding * 2
> +Layout.preferredHeight: iconSize + padding * 2

This won't work when not in Layout, I think you can use implicitWidth/Height to 
have the same effect.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

[Chris Holland]

Zren added a comment.


  Before tackling the implicitWidth/height stuff, I noticed that my 
microphone's Heading label was getting moved on the first click. Adding 
`height: contextMenuButton.height` fixes it but that doesn't feel right.
  
  https://streamable.com/07hc0

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5156: Inject mouse clicks from SNI to xembedded icons with XTest

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A certain toolkit doesn't register for mouse press release events
  because it now uses XI2 only.
  
  Injecting those directly to the window is too difficult, fortunately in
  the GTK3 case we can use XTest to send an event. Something I had
  previously chosen against using because it didn't work with something
  else (can't remember what). I now have a bit of code choosing which
  method to use, which will hopefully cover all cases.
  
  Code is a bit convuluted because the xcb version of xtest doesn't have
  the high-level method I want to use in it's API, so I just used Xlib
  version.
  
  CCBUG: 375017
  CCBUG: 362941

TEST PLAN
  Ran my usual bunch of test apps:
  
  - xchat
  - a GTK3 systray demo I made
  - skype (A Qt4 app without SNI patches)
  
  All worked as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5156

AFFECTED FILES
  xembed-sni-proxy/CMakeLists.txt
  xembed-sni-proxy/sniproxy.cpp
  xembed-sni-proxy/sniproxy.h
  xembed-sni-proxy/xtestsender.cpp
  xembed-sni-proxy/xtestsender.h

To: davidedmundson, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5137: Add support for screenedge touchscreen events through XInput 2.2

[Martin Gräßlin]

graesslin updated this revision to Diff 12748.
graesslin added a comment.


  Try two :-)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5137?vs=12714&id=12748

BRANCH
  screenedge-touch-xinput

REVISION DETAIL
  https://phabricator.kde.org/D5137

AFFECTED FILES
  gestures.h
  plugins/platforms/x11/standalone/xinputintegration.cpp

To: graesslin, #plasma, #kwin
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5156: Inject mouse clicks from SNI to xembedded icons with XTest

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> sniproxy.cpp:81
> +m_windowId(wid),
> +m_injectMode(XTest)
>  {

You mean Direct here, no?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5156

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5157: Add support for emergency message show on Wayland

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When playing with the lockscreen I noticed that the emergency show does
  not work on Wayland and one only gets a black screen if the system fails.
  
  This change adds a property to the QWindow (in ksld), so that KWin can
  read this and now that this is a window to be shown on the lock screen.
  In addition the geometry of the background window gets adjusted correctly
  on Wayland.
  
  The change needs a small part also in KWin.

REPOSITORY
  R133 KScreenLocker

BRANCH
  emergency-show-wayland

REVISION DETAIL
  https://phabricator.kde.org/D5157

AFFECTED FILES
  abstractlocker.cpp
  waylandlocker.cpp
  waylandlocker.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5157: Add support for emergency message show on Wayland

[Martin Gräßlin]

graesslin added a comment.


  F3164981: emergency-wayland.png  
emergency show on a nested Wayland compositor.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D5157

To: graesslin, #kwin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5158: Support the emergency show property on ksld's lock screen window

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The emergency show window should be considered as a lock screen window
  and be shown while the screen is locked. This is the KWin part to 
https://phabricator.kde.org/D5157.

REPOSITORY
  R108 KWin

BRANCH
  emergency-show

REVISION DETAIL
  https://phabricator.kde.org/D5158

AFFECTED FILES
  shell_client.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5160: Set implicit size from source size for image/SVG URL sources.

[Eike Hein]

hein created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This allows users of IconItem to know the aspect ratio of the
  source document, which can be used to size the item or set
  applet size hints to accomodate non-square images better.
  
  This will be used in a patch to Kicker/Dashboard that ports
  a use of Image in its CompactRepresentation to IconItem to
  get the hover highlight effect even for a custom button image.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5160

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5160: Set implicit size from source size for image/SVG URL sources.

[Eike Hein]

hein added a dependent revision: D5162: Port custom image mode to IconItem..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5160

To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5162: Port custom image mode to IconItem.

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Simplifies compact representation to always using IconItem, now
  that IconItem supports displaying non-square image sources.
  
  Fixes missing hover highlight effect for custom image launcher
  buttons.
  BUG:377652
  
  Depends on https://phabricator.kde.org/D5160 in plasma-framework to work 
correctly, enabling
  it to learn image source aspect ratio from the IconItem's implicit
  size.
  
  A good follow-up would be aligning Kickoff and Kicker compact
  representation sizing behavior and config UI now.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5162

AFFECTED FILES
  applets/kicker/package/contents/ui/CompactRepresentation.qml

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5160: Set implicit size from source size for image/SVG URL sources.

[Eike Hein]

hein added a comment.


  That was me being sleepy and trying to be smart and cunning and avoid 
busywork :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5160

To: hein, #plasma, mart, davidedmundson
Cc: drosca, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5160: Set implicit size from source size for image/SVG URL sources.

[Eike Hein]

hein updated this revision to Diff 12755.
hein added a comment.


  Always update implicit size.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5160?vs=12752&id=12755

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5160

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: hein, #plasma, mart, davidedmundson
Cc: drosca, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5160: Set implicit size from source size for image/SVG URL sources.

[David Rosca]

drosca added a comment.


  You don't reset the implicitSize anywhere, so if you do setSource(QImage) and 
then setSource(QIcon) it will still have the implicitSize of the previously set 
QImage.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5160

To: hein, #plasma, mart, davidedmundson
Cc: drosca, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5162: Port custom image mode to IconItem.

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CompactRepresentation.qml:30
> +readonly property bool useCustomButtonImage: 
> (plasmoid.configuration.useCustomButtonImage
> +&& plasmoid.configuration.customButtonImage != "")
>  property QtObject dashWindow: null

I've read several times that it's more efficient to check empty strings by 
doing `something.length != 0`.

I don't have data, but it kind of makes sense.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5162

To: hein, #plasma, broulik
Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

D5156: Inject mouse clicks from SNI to xembedded icons with XTest

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  meh

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5156

To: davidedmundson, #plasma, graesslin
Cc: graesslin, anthonyfieroni, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Plasma 5.9.4

[Ben Cooksley]

On Thu, Mar 23, 2017 at 10:39 PM, Tobias C. Berner  wrote:
> Well, I started to update this only *after* I read the announcement mail
> (according to my memory 16:30-ish CET).
> 1490110785 is 03/21/2017 15:39 (UTC)... so well after that :
>
> So probably the mirror used to fetch the files was not yet synced?

Packagers shouldn't be fetching our tarballs from mirrors.
They're given special access to the master to avoid things like this.

Cheers,
Ben

>
> On 23 March 2017 at 10:28, Rik Mills  wrote:
>>
>> Re-spun *before* the announcement email @ 14:53 UTC if I recall from IRC.
>>
>> If you grabbed the tarballs beforehand, then yes you may the have ones
>> prior to the respin?
>>
>> On 23/03/17 07:16, Tobias C. Berner wrote:
>> > Hi
>> >
>> > it seems the tarballs were respun after the announcement. Could you in
>> > the future, please give a little notice of that?
>> >
>> >
>> > mfg Tobias
>> >
>> > On 21 March 2017 at 15:53, Jonathan Riddell > > > wrote:
>> >
>> > Out now
>> > https://www.kde.org/announcements/plasma-5.9.4.php
>> > 
>> >
>> >
>>
>