D5301: Introduce support for keyboard layout switching policies

2017-04-05 Thread Martin Gräßlin
graesslin added a dependent revision: D5315: Add support for keyboard layout 
switching policy "window".

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5301

To: graesslin, #kwin, #plasma
Cc: hein, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol


D5315: Add support for keyboard layout switching policy "window"

2017-04-05 Thread Martin Gräßlin
graesslin added a dependency: D5301: Introduce support for keyboard layout 
switching policies.

REVISION DETAIL
  https://phabricator.kde.org/D5315

To: graesslin, #kwin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5315: Add support for keyboard layout switching policy "window"

2017-04-05 Thread Martin Gräßlin
graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This policy stores the layout for each window which becomes active
  and restores the layout once it gets activated again.

TEST PLAN
  Added test case

BRANCH
  keyboard-layout-policy-window

REVISION DETAIL
  https://phabricator.kde.org/D5315

AFFECTED FILES
  autotests/integration/keyboard_layout_test.cpp
  keyboard_layout_switching.cpp
  keyboard_layout_switching.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5158: Support the emergency show property on ksld's lock screen window

2017-04-05 Thread Martin Gräßlin
graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in shell_client.cpp:989
> Should this not fall-through rather than always returning if m_internalWindow?

if m_internalWindow is true the next condition can never be true. Due to that I 
use a direct return.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5158

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol


Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 111 - Still Unstable!

2017-04-05 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/111/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 06 Apr 2017 03:06:22 +
Build duration: 6 min 23 sec

CHANGE SET
Revision 1c1ad2b2e4c061651ea0541694b803ce7b688c5b by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/colors/colors.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 700 - Still Unstable!

2017-04-05 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/700/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 05 Apr 2017 22:32:09 +
Build duration: 5 min 31 sec

CHANGE SET
Revision d97f34c3bbb6944ef4de876a2f185de3a4906004 by wengxt: (kimpanel: fix 
crash. first argument of qapp need to be reference.)
  change: edit applets/kimpanel/backend/ibus/launcher.cpp
  change: edit applets/kimpanel/backend/ibus/ibus15/app.cpp
  change: edit applets/kimpanel/backend/ibus/ibus15/app.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5309: Hoist the actions overlay out of the frame loader.

2017-04-05 Thread Eike Hein
hein updated this revision to Diff 13126.
hein added a comment.


  Fix ltr :D

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5309?vs=13125=13126

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5309

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5309: Hoist the actions overlay out of the frame loader.

2017-04-05 Thread Eike Hein
hein updated this revision to Diff 13125.
hein added a comment.


  Fix rtl.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5309?vs=13111=13125

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5309

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


[kio-extras] [Bug 372860] MTP not usable : connects, then disconnects, then connects...

2017-04-05 Thread Vlastimil Kriz
https://bugs.kde.org/show_bug.cgi?id=372860

Vlastimil Kriz  changed:

   What|Removed |Added

 CC||vlastimil.k...@seznam.cz

--- Comment #1 from Vlastimil Kriz  ---
I have the same problem ...

-- 
You are receiving this mail because:
You are the assignee for the bug.

D3552: Remove quoting from kscreen-console json-output (Bug 354534)

2017-04-05 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:ab1f2c9a3bc4: Remove quoting from kscreen-console 
json-output (authored by jbraun, committed by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3552?vs=8674=13122#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3552?vs=8674=13122

REVISION DETAIL
  https://phabricator.kde.org/D3552

AFFECTED FILES
  console/console.cpp

To: jbraun, sebas
Cc: aacid, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 699 - Still Unstable!

2017-04-05 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/699/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 05 Apr 2017 21:37:54 +
Build duration: 5 min 29 sec

CHANGE SET
Revision 4046be3cb7bebe44b41c753e2697d6555ce596b1 by wengxt: (kimpanel: try to 
workaround some qt/glib issue and fix memory leak)
  change: edit applets/kimpanel/backend/ibus/ibus15/panel.cpp
  change: edit applets/kimpanel/backend/ibus/ibus15/app.h
  change: edit applets/kimpanel/backend/ibus/ibus15/app.cpp
  change: edit applets/kimpanel/backend/ibus/ibus15/main.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 698 - Still Unstable!

2017-04-05 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/698/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 05 Apr 2017 20:51:53 +
Build duration: 6 min 1 sec

CHANGE SET
Revision 6e03b6f5465a5df6135be1795b33f8fd50483ced by wengxt: (kimpanel: add a 
ibus panel launcher.)
  change: edit dataengines/kimpanel/kimpanelagent.cpp
  change: edit applets/kimpanel/backend/ibus/ibus15/app.cpp
  change: edit dataengines/kimpanel/CMakeLists.txt
  change: edit dataengines/kimpanel/kimpaneldataengine.cpp
  change: edit dataengines/kimpanel/org.kde.impanel.xml
  change: edit applets/kimpanel/backend/CMakeLists.txt
  change: add dataengines/kimpanel/config-kimpanel.h.cmake
  change: edit applets/kimpanel/backend/ibus/CMakeLists.txt
  change: edit applets/kimpanel/backend/ibus/ibus15/app.h
  change: add applets/kimpanel/backend/ibus/launcher.cpp
  change: edit dataengines/kimpanel/kimpanelagent.h
  change: add applets/kimpanel/backend/ibus/config-kimpanel.h.cmake
Revision a418979bf1073c1a0b2b825d31d6abf495cb242a by wengxt: (kimpanel: be 
prepared for plasma shell with highdpi flag.)
  change: edit applets/kimpanel/plugin/screen.cpp
  change: edit applets/kimpanel/plugin/screen.h
  change: edit applets/kimpanel/package/contents/ui/InputPanel.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5158: Support the emergency show property on ksld's lock screen window

2017-04-05 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> shell_client.cpp:989
> +if (m_internalWindow) {
> +return m_internalWindow->property("org_kde_ksld_emergency").toBool();
> +}

Should this not fall-through rather than always returning if m_internalWindow?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5158

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol


D5309: Hoist the actions overlay out of the frame loader.

2017-04-05 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> FolderItemDelegate.qml:455
> +top: frameLoader.top
> +leftMargin: root.useListViewMode ? (icon.x + (icon.width 
> / 2)) - (width / 2) : 0
> +topMargin: root.useListViewMode ? (icon.y + (icon.height 
> / 2)) - (height / 2)  : 0

Can you verify this (`icon.x` in conjunction with auto-mirroring left anchor) 
works fine in RTL mode?

> FolderItemDelegate.qml:459
> +
> +width: implicitWidth
> +height: implicitHeight

Shouldn't be neccessary

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5309

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


[Powerdevil] [Bug 378471] New: Energy Saving ignore configuration!

2017-04-05 Thread Rogério Queiroz
https://bugs.kde.org/show_bug.cgi?id=378471

Bug ID: 378471
   Summary: Energy Saving ignore configuration!
   Product: Powerdevil
   Version: 5.8.6
  Platform: Neon Packages
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: rogerio...@gmail.com
  Target Milestone: ---

Energy Saving, in tab On AC Power, even deselecting the Screen Energy Saving
option, the notebook enters lookScreen, so I have to enter my password again!
It is bad when in presentations with datashow for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasma-workspace] /: Merge the AppStream runner into the Plasma Workspace

2017-04-05 Thread Aleix Pol
Git commit a59b9e61897887ea93cf736aff99243facdc45d9 by Aleix Pol.
Committed on 05/04/2017 at 17:41.
Pushed by apol into branch 'master'.

Merge the AppStream runner into the Plasma Workspace

CCMAIL: sit...@kde.org
CCMAIL: plasma-devel@kde.org

M  +7-0CMakeLists.txt
M  +5-1runners/CMakeLists.txt
A  +5-0runners/appstream/CMakeLists.txt
A  +125  -0runners/appstream/appstreamrunner.cpp [License: GPL (v2/3)]
A  +13   -0runners/appstream/appstreamrunner.desktop
A  +47   -0runners/appstream/appstreamrunner.h [License: GPL (v2/3)]

https://commits.kde.org/plasma-workspace/a59b9e61897887ea93cf736aff99243facdc45d9

diff --git a/CMakeLists.txt b/CMakeLists.txt
index d20a3adc..4f03ba05 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -93,6 +93,13 @@ if(X11_FOUND AND XCB_XCB_FOUND)
   set(HAVE_X11 1)
 endif()
 
+find_package(AppStreamQt 0.10.4)
+set_package_properties(AppStreamQt PROPERTIES DESCRIPTION "Access metadata for 
listing available software"
+   URL 
"https://www.freedesktop.org/wiki/Distributions/AppStream/;
+  TYPE OPTIONAL
+  )
+
+
 include(ConfigureChecks.cmake)
 
 include_directories("${CMAKE_CURRENT_BINARY_DIR}")
diff --git a/runners/CMakeLists.txt b/runners/CMakeLists.txt
index d7656c82..a1feee07 100644
--- a/runners/CMakeLists.txt
+++ b/runners/CMakeLists.txt
@@ -12,7 +12,11 @@ add_subdirectory(shell)
 # add_subdirectory(solid)
 add_subdirectory(webshortcuts)
 add_subdirectory(windowedwidgets)
-#
+
+if(AppStreamQt_FOUND)
+add_subdirectory(appstream)
+endif()
+
 if(NOT WIN32)
  add_subdirectory(powerdevil)
  add_subdirectory(sessions)
diff --git a/runners/appstream/CMakeLists.txt b/runners/appstream/CMakeLists.txt
new file mode 100644
index ..271e8c8c
--- /dev/null
+++ b/runners/appstream/CMakeLists.txt
@@ -0,0 +1,5 @@
+add_library(appstreamrunner MODULE appstreamrunner.cpp)
+target_link_libraries(appstreamrunner PUBLIC KF5::Runner KF5::I18n 
KF5::Service AppStreamQt)
+
+install(TARGETS appstreamrunner DESTINATION ${PLUGIN_INSTALL_DIR})
+install(FILES appstreamrunner.desktop DESTINATION ${SERVICES_INSTALL_DIR})
diff --git a/runners/appstream/appstreamrunner.cpp 
b/runners/appstream/appstreamrunner.cpp
new file mode 100644
index ..a8aa9d2a
--- /dev/null
+++ b/runners/appstream/appstreamrunner.cpp
@@ -0,0 +1,125 @@
+/***
+ *   Copyright © 2016 Aleix Pol Gonzalez *
+ * *
+ *   This program is free software; you can redistribute it and/or *
+ *   modify it under the terms of the GNU General Public License as*
+ *   published by the Free Software Foundation; either version 2 of*
+ *   the License or (at your option) version 3 or any later version*
+ *   accepted by the membership of KDE e.V. (or its successor approved *
+ *   by the membership of KDE e.V.), which shall act as a proxy*
+ *   defined in Section 14 of version 3 of the license.*
+ * *
+ *   This program is distributed in the hope that it will be useful,   *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of*
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the *
+ *   GNU General Public License for more details.  *
+ * *
+ *   You should have received a copy of the GNU General Public License *
+ *   along with this program.  If not, see . *
+ ***/
+
+#include "appstreamrunner.h"
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+K_EXPORT_PLASMA_RUNNER(installer, InstallerRunner)
+
+InstallerRunner::InstallerRunner(QObject *parent, const QVariantList )
+: Plasma::AbstractRunner(parent, args)
+{
+Q_UNUSED(args)
+
+setObjectName("Installation Suggestions");
+setPriority(AbstractRunner::HighestPriority);
+
+addSyntax(Plasma::RunnerSyntax(":q:", i18n("Looks for non-installed 
components according to :q:")));
+}
+
+InstallerRunner::~InstallerRunner()
+{
+}
+
+static QIcon componentIcon(const AppStream::Component )
+{
+QIcon ret;
+const auto icons = comp.icons();
+if (icons.isEmpty()) {
+ret = QIcon::fromTheme(QStringLiteral("package-x-generic"));
+} else foreach(const AppStream::Icon , icons) {
+QStringList stock;
+switch(icon.kind()) {
+case AppStream::Icon::KindLocal:
+ret.addFile(icon.url().toLocalFile(), icon.size());
+break;
+case AppStream::Icon::KindCached:
+

Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2017-04-05 Thread Michail Vourlakos


On 05/04/2017 01:01 μμ, Marco Martin wrote:


yeah, "the xcb windowing system"



playing around a bit with our crashes in wayland but here it is, wayland 
painting for Latte...
but of course we cant yet position our docks and get infos for the 
active window so this is the reason for the ping of the thread in order 
to open the discussion concerning external docks for plasma in wayland 
world...


https://cloud.githubusercontent.com/assets/2216474/24711791/a6082e10-1a29-11e7-94d5-9f5cc920b478.png


D3805: Per-activity favorites (Final, again?)

2017-04-05 Thread Marco Martin
mart added a comment.


  In https://phabricator.kde.org/D3805#99934, @hein wrote:
  
  > Personally I think the simplest behavior is to keep the ordering separate 
for every activity and make no attempt to sync the order. When a new activity 
is created, the order should probably be copied from the currently active 
activity.
  
  
  +1, ordering sounds more like a view thing to me

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5221: [desktop:/ KIO] Add descriptive name for root item

2017-04-05 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d6121f3f5c25: [desktop:/ KIO] Add descriptive name for 
root item (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5221?vs=12946=13115

REVISION DETAIL
  https://phabricator.kde.org/D5221

AFFECTED FILES
  kioslave/desktop/CMakeLists.txt
  kioslave/desktop/Messages.sh
  kioslave/desktop/kio_desktop.cpp

To: broulik, #plasma, hein, elvisangelaccio, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D3805: Per-activity favorites (Final, again?)

2017-04-05 Thread Eike Hein
hein added a comment.


  In my latest round of testing the behavior is much better and I can't run 
into issues as easily anymore.
  
  I'm still a bit distrustful of the way ordering changes work though. One time 
during testing, I drag-reordered a favorite on all activities to a new 
position, and when I switched activities it had moved position on the other 
activity as well. Later the same favorite suddenly moved to the end of the list 
(or maybe the original position, not sure) on both activities. Other times, 
ordering changes of favorites shared by activities aren't synched across 
activities and fully independent.
  
  Personally I think the simplest behavior is to keep the ordering separate for 
every activity and make no attempt to sync the order. When a new activity is 
created, the order should probably be copied from the currently active activity.

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D3805: Per-activity favorites (Final, again?)

2017-04-05 Thread Eike Hein
hein added a comment.


  > echo "delete from ResourceLink" | sqlite3 
~/.local/share/kactivitymanagerd/resources/database
  
  This gets me "incomplete SQL", please update~

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5310: Don't close popup when spring-load dragging into it.

2017-04-05 Thread Eike Hein
hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  I'm not sure how this regression came about. It might be due to mouse
  handling changes on the Qt 5.9 branch. I'd appreciate it if someone
  tests spring loading with this patch and older Qts.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5310

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5309: Hoist the actions overlay out of the frame loader.

2017-04-05 Thread Eike Hein
hein updated this revision to Diff 13111.
hein added a comment.


  Add back the visible property expression, it's still needed for
  the spring-loading case after all.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5309?vs=13110=13111

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5309

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5309: Hoist the actions overlay out of the frame loader.

2017-04-05 Thread Eike Hein
hein added a comment.


  Hold on - I just found a small regression during further testing, this needs 
some more work.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5309

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5309: Hoist the actions overlay out of the frame loader.

2017-04-05 Thread Eike Hein
hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This fixes a race condition causing the actions overlay to sometimes
  appear in the drag pixmap attached to the DND cursor, as grabToImage
  is run against the frame loader.
  
  As a bonus it simplifies the code and save some cycles as it's no
  longer necessary to turn the overlay column invisible during drags.

TEST PLAN
  We used to have a problem with the actions overlay not
  repositioning properly in popup Folder Views when switching them
  between list and icon view mode, which partly shaped the old code
  (the anchor state changes). I verified this didn't regress with the
  new simplified code.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5309

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: hein, #plasma, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5240: Stop perpetual search state for StaticXml KNS stuff

2017-04-05 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:a8031fead6a6: Stop perpetual search state for StaticXml 
KNS stuff (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5240?vs=12966=13109

REVISION DETAIL
  https://phabricator.kde.org/D5240

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5240: Stop perpetual search state for StaticXml KNS stuff

2017-04-05 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5240

To: leinir, #discover_software_store, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 697 - Still unstable!

2017-04-05 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/697/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 05 Apr 2017 10:28:02 +
Build duration: 6 min 2 sec

CHANGE SET
Revision 45bea58f9bfeedcc06ec8ed086215287c2737155 by kde: ([Folder View] Rename 
on clicking outside)
  change: edit containments/desktop/package/contents/ui/FolderView.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5305: [Folder View] Rename on clicking outside

2017-04-05 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:45bea58f9bfe: [Folder View] Rename on clicking outside 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5305?vs=13102=13108

REVISION DETAIL
  https://phabricator.kde.org/D5305

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


D5305: [Folder View] Rename on clicking outside

2017-04-05 Thread Eike Hein
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5305

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2017-04-05 Thread Marco Martin
On Wednesday 05 April 2017, Michail Vourlakos wrote:
> > to see if it's due to xwayland, you can try to do
> > export QT_QPA_PLATFORM=wayland
> > 
> > then launch it from the same terminal and see what happens
> 
> I forgot the link with the screenshot:
> 
> https://drive.google.com/file/d/0B98NarVO5dq1LThERmNRUEV3c2M/view?usp=shari
> ng

yeah, "the xcb windowing system"

-- 
Marco Martin


Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2017-04-05 Thread Michail Vourlakos



to see if it's due to xwayland, you can try to do
export QT_QPA_PLATFORM=wayland

then launch it from the same terminal and see what happens




Hello Marco!

in x session, if I use your guidelines an error message occurs that such 
display can not be found


in wayland session, if I use your guidelines Latte is starting but 
before creating the dock windows is crashing... I suppose this is 
because we havent enabled yet the wayland surfaces creation yet


in wayland session, if I just run the app it runs ok... the following 
screenshot shows the about windows of dolphin and latte in a wayland 
session... the first one is using wayland and the second xcb...


I suppose this means that we use xwayland

https://drive.google.com/file/d/0B98NarVO5dq1LThERmNRUEV3c2M/view?usp=sharing





Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2017-04-05 Thread Michail Vourlakos



to see if it's due to xwayland, you can try to do
export QT_QPA_PLATFORM=wayland

then launch it from the same terminal and see what happens




I forgot the link with the screenshot:

https://drive.google.com/file/d/0B98NarVO5dq1LThERmNRUEV3c2M/view?usp=sharing


Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2017-04-05 Thread Michail Vourlakos



to see if it's due to xwayland, you can try to do
export QT_QPA_PLATFORM=wayland

then launch it from the same terminal and see what happens




Hello Marco!

in x session, if I use your guidelines an error message occurs that such 
display can not be found


in wayland session, if I use your guidelines Latte is starting but 
before creating the dock windows is crashing... I suppose this is 
because we havent enabled yet the wayland surfaces creation yet


in wayland session, if I just run the app it runs ok... the following 
screenshot shows the about windows of dolphin and latte in a wayland 
session... the first one is using wayland and the second xcb...


I suppose this means that we use xwayland






D5245: Desaturate non-responsive windows

2017-04-05 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1eb950a98514: Desaturate non-responsive windows (authored 
by broulik).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5245?vs=12992=13104

REVISION DETAIL
  https://phabricator.kde.org/D5245

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  autotests/test_scripted_effectloader.cpp
  client.cpp
  effects.cpp
  effects/CMakeLists.txt
  effects/frozenapp/CMakeLists.txt
  effects/frozenapp/package/CMakeLists.txt
  effects/frozenapp/package/contents/code/main.js
  effects/frozenapp/package/metadata.desktop
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h

To: broulik, #vdg, graesslin, #kwin, #plasma
Cc: fredrik, luebking, kvermette, graesslin, plasma-devel, kwin, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol


Re: appstreamrunner in plasma-workspace

2017-04-05 Thread Marco Martin
On Wednesday 05 April 2017, Aleix Pol wrote:
> > Note that we're already using AppStream in other places of Plasma,
> > such as Plasma Desktop and Discover.
> 
> Taking silence as agreement.
> I'll be getting the runner in plasma-workspace during this week.
> 
> Aleix
+1

-- 
Marco Martin


Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2017-04-05 Thread Marco Martin
On Wednesday 05 April 2017, Michail Vourlakos wrote:
> ping...
> 
> Hello everyone...
> 
> Merging Now Dock with Candil Dock we managed to release
> Latte Dock the last weekend and we are more than happy to use only
> kde and plasma technologies!! :) In the next phase of Latte development we
> are
> trying to make a plan for supporting wayland... Yesterday I managed to open
> a
> wayland session in openSUSE Tumbleweed for plasma 5.9
> (it just run with the official packages with no adjustments) and tried to
> run
> Latte just for fun in it, so it opened and it looked fantastic! :) I
> suppose it uses
> the xwayland to achieve this... you can see a screenchot for it  at:

to see if it's due to xwayland, you can try to do
export QT_QPA_PLATFORM=wayland

then launch it from the same terminal and see what happens


-- 
Marco Martin


D5305: [Folder View] Rename on clicking outside

2017-04-05 Thread Kai Uwe Broulik
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When renaming a file and clicking elsewhere, actually rename instead of 
canceling. This is what Dolphin and other file managers do.
  When pressing Escape, closing the popup, or starting to scroll, the rename 
operation is cancelled as before.
  
  BUG: 378447

TEST PLAN
  Selected a file, pressed F2, changed its name, clicked elsewherre, file was 
renamed. Pressing Return also accepts the renaming.
  Pressing Escape, closing the popup, or starting to scroll cancels the rename 
as before.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5305

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol


Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2017-04-05 Thread Michail Vourlakos
ping...

Hello everyone...

Merging Now Dock with Candil Dock we managed to release
Latte Dock the last weekend and we are more than happy to use only
kde and plasma technologies!! :) In the next phase of Latte development we
are
trying to make a plan for supporting wayland... Yesterday I managed to open
a
wayland session in openSUSE Tumbleweed for plasma 5.9
(it just run with the official packages with no adjustments) and tried to
run
Latte just for fun in it, so it opened and it looked fantastic! :) I
suppose it uses
the xwayland to achieve this... you can see a screenchot for it  at:

https://cloud.githubusercontent.com/assets/2216474/24677245/c9f422de-198e-11e7-802a-8e489484556c.png

we havent added yet any wayland specific code and we were expecting crashes
etc. but this
didnt happen... many kudos for everyone working around wayland porting
etc!!!

Being in that point we would like please an update concerning the use of
kwayland from
external apps like Latte...

What is the situation in plasma 5.9, is there a way to access these
privileged apis?
if not, are there any plans when such support may be possible?

thank you very much once more !!!

regards,
michail




2016-12-21 21:16 GMT+02:00 Martin Gräßlin 

> send from wrong address...(or kmail is broken)
>
> Am 2016-12-21 20:15, schrieb Martin Gräßlin:
>
>> Hi,
>>
>> currently every window gets access. This will change soon. The
>> implementation for authorization is already on the whiteboard left to
>> me :-)
>>
>> Basically the required interface will be restricted. The
>> identification will be based on process ids with a root (!) owned
>> global configuration file.
>>
>> At runtime any access without authorization will simply abort the
>> application. It will raise a Wayland protocol error which will result
>> in application termination.
>>
>> There might be a protocol added to ask the user for authorization. But
>> that will be runtime, that is every time the user restarts the
>> application it will be asked again. But that's a secondary step. The
>> first will be to just shut down any access to these privileged
>> interface.
>>
>> Most likely this will be introduced with Plasma 5.10 or 5.11.
>>
>> Cheers
>> Martin
>>
>>>
>>>