D5520: [platforms/x11] Do not grab touch events

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Grabbing the touch events seems to cause issues. It seems to also grab
  pointer events from touchpad and breaks touch input on other events.
  
  Also testing shows that we don't need it and get touch ownership events
  for our screenedge windows reported.
  
  BUG: 378951

TEST PLAN
  Triggered touch screen edge, normal system usage on X11

REPOSITORY
  R108 KWin

BRANCH
  no-touch-grab

REVISION DETAIL
  https://phabricator.kde.org/D5520

AFFECTED FILES
  plugins/platforms/x11/standalone/xinputintegration.cpp

To: graesslin, #plasma, #kwin
Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D4893: Layout and animations on the on screen keyboard

[Martin Gräßlin]

graesslin added a comment.


  I fear this change caused regressions. I now don't have the virtual keyboard 
button on the layout anymore (X11 and Wayland) and on Wayland it's impossible 
to unlock the screen.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4893

To: mart, #plasma, broulik, graesslin
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 123 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/123/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 03:29:43 +
Build duration: 18 min

CHANGE SET
Revision 1e031b905565204aeb15ecd870cb705462def3ff by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/colors/colors.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 862 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/862/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 02:18:44 +
Build duration: 36 min

CHANGE SET
Revision e9e3ea254124538ff5165366adb7a31095743cfa by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit runners/appstream/appstreamrunner.desktop


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.klipper-testHistory

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2304/5979 
(39%)CONDITIONAL 1624/5952 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL 
56/90 (62%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390 
(66%)CONDITIONAL 113/216 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL 
349/820 (43%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3304 (6%)CONDITIONAL 
122/3251 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 721 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/721/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 02:18:29 +
Build duration: 9 min 32 sec

CHANGE SET
Revision 0463667e5a82058550d71cbafc9f5917428ae36a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/colors/colors.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5464: Nextcloud Upload Purpose Plugin

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:ef8548fadc39: Nextcloud upload purpose plugin (authored 
by Lim Yuen Hoe ).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5464?vs=13598=13619

REVISION DETAIL
  https://phabricator.kde.org/D5464

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/nextcloud/CMakeLists.txt
  src/plugins/nextcloud/Messages.sh
  src/plugins/nextcloud/nextcloud-upload.service.in
  src/plugins/nextcloud/nextcloudjob.cpp
  src/plugins/nextcloud/nextcloudjob.h
  src/plugins/nextcloud/nextcloudplugin.cpp
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/nextcloud/nextcloudplugin_config.qml

To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D4712: Ungrab mouse on menu close

[David Edmundson]

davidedmundson added a comment.


  Well, now that I understand the bug, I would say this isn't right.
  
  If I dismiss the menu by clicking something else in the original qtquick 
scene, the events won't happen in the order you want.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4712

To: anthonyfieroni, #plasma, mart, broulik
Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5464: Nextcloud Upload Purpose Plugin

[Yuen Hoe Lim]

yuenlim added a comment.


  Sure! I was planning to.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D5464

To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 122 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/122/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 20:12:25 +
Build duration: 17 min

CHANGE SET
Revision 076091e8ee8be54e6c92c1026ff30d87a8286a22 by kde: ([Folder View] Fix 
backport of wrapping fix)
  change: edit containments/desktop/package/contents/ui/FolderItemDelegate.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Powerdevil] [Bug 378976] New: Crash after resume from suspend

[Thomas Mitterfellner]

https://bugs.kde.org/show_bug.cgi?id=378976

Bug ID: 378976
   Summary: Crash after resume from suspend
   Product: Powerdevil
   Version: 5.9.4
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: tho...@mitterfellner.at
  Target Milestone: ---

I'm not 100% sure why it happened, all that I know is that I had the my system
suspended for quite some time and maybe the battery was drained. When I
resumed, I saw a crash symbol in the system tray and shortly after that
plasmashell also crashed.

Backtrace:

#0  0x7f7c858f28d7 in __GI_raise (sig=11) at
../sysdeps/unix/sysv/linux/raise.c:55
#1  0x7f7c876e8b14 in KCrash::defaultCrashHandler(int) () at
/usr/lib64/libKF5Crash.so.5
#2  0x7f7c858f2950 in  () at /lib64/libc-2.22.so
#3  0x7f7c874b54d3 in QHash::erase(QHash::const_iterator) (this=this@entry=0x1fad390, it=it@entry=...)
at /usr/include/qt5/QtCore/qhash.h:857
#4  0x7f7c874ade5e in PowerDevil::Core::onResumingFromIdle() (i=...,
this=0x1fad390)
at /usr/include/qt5/QtCore/qset.h:197
#5  0x7f7c874ade5e in PowerDevil::Core::onResumingFromIdle() (i=...,
this=0x1fad390)
at /usr/include/qt5/QtCore/qset.h:193
#6  0x7f7c874ade5e in PowerDevil::Core::onResumingFromIdle()
(this=this@entry=0x1fad310)
at /usr/src/debug/powerdevil-5.9.4/daemon/powerdevilcore.cpp:798
#7  0x7f7c874b0218 in PowerDevil::Core::loadProfile(bool)
(this=this@entry=0x1fad310, force=force@entry=false) at
/usr/src/debug/powerdevil-5.9.4/daemon/powerdevilcore.cpp:346
#8  0x7f7c874b3cb8 in
PowerDevil::Core::onAcAdapterStateChanged(PowerDevil::BackendInterface::AcAdapterState)
(this=0x1fad310, state=PowerDevil::BackendInterface::Plugged)
at /usr/src/debug/powerdevil-5.9.4/daemon/powerdevilcore.cpp:624
#9  0x7f7c874cf15b in PowerDevil::Core::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) (_o=, _c=,
_id=, _a=)
at
/usr/src/debug/powerdevil-5.9.4/build/daemon/powerdevilcore_automoc.dir/moc_powerdevilcore_SR3RJSZTCRXVIY.cpp:226
#10 0x7f7c862780d5 in QMetaObject::activate(QObject*, int, int, void**) ()
at /usr/lib64/libQt5Core.so.5.8.0
#11 0x7f7c874ce06e in
PowerDevil::BackendInterface::acAdapterStateChanged(PowerDevil::BackendInterface::AcAdapterState)
(this=this@entry=0x1fdef30,
_t1=_t1@entry=PowerDevil::BackendInterface::Plugged)
at
/usr/src/debug/powerdevil-5.9.4/build/daemon/powerdevilcore_automoc.dir/moc_powerdevilback_I25NWGJZD7ADF4.cpp:250
#12 0x7f7c874ab0bb in
PowerDevil::BackendInterface::setAcAdapterState(PowerDevil::BackendInterface::AcAdapterState)
(this=this@entry=0x1fdef30,
state=state@entry=PowerDevil::BackendInterface::Plugged)
at
/usr/src/debug/powerdevil-5.9.4/daemon/powerdevilbackendinterface.cpp:142
#13 0x7f7c701d4251 in PowerDevilUPowerBackend::slotPropertyChanged()
(this=0x1fdef30)
at
/usr/src/debug/powerdevil-5.9.4/daemon/backends/upower/powerdevilupowerbackend.cpp:640
#14 0x7f7c701d4399 in PowerDevilUPowerBackend::onPropertiesChanged(QString
const&, QMap const&, QStringList const&) (this=, ifaceName=..., changedProps=..., invalidatedProps=...)
at
/usr/src/debug/powerdevil-5.9.4/daemon/backends/upower/powerdevilupowerbackend.cpp:652
#15 0x7f7c701e3814 in PowerDevilUPowerBackend::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) (_o=_o@entry=0x1fdef30,
_c=_c@entry=QMetaObject::InvokeMetaMethod, _id=_id@entry=12,
_a=_a@entry=0x7ffc9b0f0810)
at
/usr/src/debug/powerdevil-5.9.4/build/daemon/backends/powerdevilupowerbackend_automoc.dir/moc_powerdevilupow_HYK6MXZV2XCI6O.cpp:144
#16 0x7f7c701e3ee3 in
PowerDevilUPowerBackend::qt_metacall(QMetaObject::Call, int, void**)
(this=0x1fdef30, _c=QMetaObject::InvokeMetaMethod, _id=12, _a=0x7ffc9b0f0810)
at
/usr/src/debug/powerdevil-5.9.4/build/daemon/backends/powerdevilupowerbackend_automoc.dir/moc_powerdevilupow_HYK6MXZV2XCI6O.cpp:205
#17 0x7f7c866c249b in  () at /usr/lib64/libQt5DBus.so.5
#18 0x7f7c86279886 in QObject::event(QEvent*) () at
/usr/lib64/libQt5Core.so.5.8.0
#19 0x7f7c8625030c in QCoreApplication::notify(QObject*, QEvent*) () at
/usr/lib64/libQt5Core.so.5.8.0
#20 0x7f7c86250245 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
()
at /usr/lib64/libQt5Core.so.5.8.0
#21 0x7f7c862522a3 in QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) ()
at /usr/lib64/libQt5Core.so.5.8.0
#22 0x7f7c8629f043 in postEventSourceDispatch(_GSource*, int (*)(void*),
void*) ()
at /usr/lib64/libQt5Core.so.5.8.0
#23 0x7f7c7fcbc134 in g_main_context_dispatch () at
/usr/lib64/libglib-2.0.so.0
#24 0x7f7c7fcbc388 in  () at /usr/lib64/libglib-2.0.so.0
#25 0x7f7c7fcbc42c in g_main_context_iteration () at

D5515: Update the ungrabMouse hack for Qt 5.8

[Anthony Fieroni]

anthonyfieroni added a comment.


  https://phabricator.kde.org/D4712
  https://phabricator.kde.org/D4711
  It has one unfixible case, dismiss context menu by clicking on onther window.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5515

To: davidedmundson, #plasma
Cc: anthonyfieroni, mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5515: Update the ungrabMouse hack for Qt 5.8

[Michail Vourlakos]

mvourlakos added a comment.


  I had reported qts faulty behavior concerning centextmenus at: 
https://bugreports.qt.io/browse/QTBUG-59044
  
  I think it is the mentioned case...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5515

To: davidedmundson, #plasma
Cc: mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5515: Update the ungrabMouse hack for Qt 5.8

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  There was an unidentified bug where when opening a context menu in
  response to a mousePress event led to the next click events not being
  registered. The mouse got grabbed by the item in the mousePressEvent,
  but when we open a menu it didn't get released. The next click goes to
  the currently grabbed item.
  
  A workaround was added back in 2015 (and copied into various other parts
  of Plasma) to ungrab the mouse after launching the context menu inside
  our rightClickEvent. This doesn't work because qquickwindow code is
  shuffled. It now sends the event and then grabs the mouse.
  
  qquickwindow.cpp:653 on Qt5.8.0
  
  Which means we're now trying to do the ungrab, before QWindow has set
  our item as the grabber. That obviously doesn't work.
  
  This real bug needs fixing in Qt, (I now know the root cause!)
  but we have a workaround here already, we may as well make it work.
  
  Note: This also needs doing in a bajillion (6) places in p-w/p-d.
  
  FWIW, the root cause of all of these bugs is:
  
  - QtQuick internally keeps track of which item has "grabbed" the mouse
  - It's weirdly a singleton between windows, but that should be fine
  - It relies on the fact that when we get an X mouse press event we
  
  should always get a mouse release event. X is surprisingly smart and
  will send this even if you change window focus.
  
  - However - context menus are evil bastards. They do a low level grab
  
  (completely different type of grab than the one above) and grab all
  mouse events at the X level
  
  - Our original QtQuickItem which was handling the right click event no
  
  longer gets our release event
  
  - The reason it's only somtimes is we have a "race" between being
  
  created and the grab going through X, and the user actually releasing
  the mouse.

TEST PLAN
  Had 1 reproducible case
  Added this. No longer could reproduce

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5515

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4806: [greeter] Send the auth result through the server instead return value

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:d666fe879d46: [greeter] Send the auth result through the 
server instead return value (authored by graesslin).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4806?vs=11848=13602

REVISION DETAIL
  https://phabricator.kde.org/D4806

AFFECTED FILES
  greeter/authenticator.cpp
  greeter/autotests/fakekcheckpass.c
  kcheckpass/kcheckpass-enums.h
  kcheckpass/kcheckpass.c

To: graesslin, #plasma, subdiff
Cc: subdiff, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:5e3c7b337c95: Use seccomp for implementing a sandbox for 
kscreenlocker_greet (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5029?vs=13189=13604#toc

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5029?vs=13189=13604

REVISION DETAIL
  https://phabricator.kde.org/D5029

AFFECTED FILES
  CMakeLists.txt
  cmake/FindSeccomp.cmake
  config-kscreenlocker.h.cmake
  greeter/CMakeLists.txt
  greeter/autotests/CMakeLists.txt
  greeter/autotests/seccomp_test.cpp
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/main.cpp
  greeter/seccomp_filter.cpp
  greeter/seccomp_filter.h

To: graesslin, #plasma
Cc: subdiff, broulik, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D4997: Support for long running kcheckpass supporting multiple authentications

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:07d38ba65adc: Support for long running kcheckpass 
supporting multiple authentications (authored by graesslin).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4997?vs=13188=13603

REVISION DETAIL
  https://phabricator.kde.org/D4997

AFFECTED FILES
  greeter/authenticator.cpp
  greeter/authenticator.h
  greeter/autotests/authenticatortest.cpp
  greeter/greeterapp.cpp
  kcheckpass/kcheckpass-enums.h
  kcheckpass/kcheckpass.c
  tests/kcheckpass_test.cpp

To: graesslin, #plasma
Cc: subdiff, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: Make xdg-desktop-portal-kde part of Plasma release

[Harald Sitter]

+1

On Wed, Apr 19, 2017 at 2:08 PM, Jan Grulich  wrote:
> Hi,
>
> I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into
> Plasma to have it released with Plasma 5.10 and so on.
>
> What is xdg-desktop-portal-kde:
> It's a KDE implementation of Flatpak portals backend [2], currently with
> support of AppChooser, FileChooser, Notification and Print portals.
>
> How it works:
> An app running in sandbox communicates with outside world using
> org.freedesktop.portal.Foo interfaces (each of them is one portal). These
> interfaces are registered by xdg-desktop-portal (on DBus as
> org.freedesktop.portal.Desktop service). This requires support in library to
> make widgets etc. do calls to o.f.p.Foo interfaces instead of doing what they
> usually do. This is already implemented in KNotifications and for Qt part we
> have flatpak platform plugin. Then xdg-desktop-portal calls desktop specific
> implementations to present native dialogs and have proper integration. That's
> where xdg-desktop-portal-kde takes place. It exposes it's implementation on
> DBus as org.freedesktop.impl.portal.desktop.kde service. Then in case of KDE
> when user requests a file dialog from a sandboxed application, Qt platform
> plugin does a dbus call to xdg-desktop-portal instead of showing a dialog and
> xdg-desktop-portal forwards this to our backend implementation and we show a
> native dialog to the user, this time this dialog is not running in sandbox and
> user can open a file which is outside the sandboxed application. Same way it
> works with opening URLs, notifications etc.
>
> What do you think?
>
> [1] - https://cgit.kde.org/xdg-desktop-portal-kde.git/
> [2] - 
> http://flatpak.org/xdg-desktop-portal/portal-docs.html#idm140258860052032
>
> Regards,
> Jan
> --
> Jan Grulich,
> Software Engineer, Desktop Team
> Red Hat

D5510: Improve how we set up the flatpak backend

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Remove the scope semantic and make the installation part of each resource.

REPOSITORY
  R134 Discover Software Store

BRANCH
  flatpak-installations

REVISION DETAIL
  https://phabricator.kde.org/D5510

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakBackend.h
  libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
  libdiscover/backends/FlatpakBackend/FlatpakResource.h
  libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.h

To: apol, jgrulich
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5464: Nextcloud Upload Purpose Plugin

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Okay, let's integrate it and then we see how it works.
  
  Can you maybe blog about it so the world knows?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D5464

To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

[Eike Hein]

hein added a comment.


  Will fix lukas' error tomorrow, please review past it in the meantime in case 
there's more :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5505

To: hein, #plasma, davidedmundson, lukas
Cc: lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 861 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/861/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 13:46:38 +
Build duration: 14 min

CHANGE SET
Revision e72aedace91651eefc711912cede12ae0492b1be by kde: ([Media Controller] 
nly fold hours (to get rid of them) when track is)
  change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.klipper-testHistory

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2304/5979 
(39%)CONDITIONAL 1624/5952 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL 
56/90 (62%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390 
(66%)CONDITIONAL 113/216 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL 
349/820 (43%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3304 (6%)CONDITIONAL 
122/3251 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Re: Make xdg-desktop-portal-kde part of Plasma release

[Aleix Pol]

On Wed, Apr 19, 2017 at 3:35 PM, Jonathan Riddell  wrote:
> On Wed, Apr 19, 2017 at 02:08:52PM +0200, Jan Grulich wrote:
>> Hi,
>>
>> I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into
>> Plasma to have it released with Plasma 5.10 and so on.
>
> why the name xdg-desktop-portal? Isn't flatpak-something more appropriate?

That's what this is implementing:
https://github.com/flatpak/xdg-desktop-portal

Also as said, snappy will possibly end up using it.

Aleix

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 860 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/860/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 13:30:41 +
Build duration: 15 min

CHANGE SET
Revision 4d3760c8aa9d6a99e5239019fb9a29aab2e22896 by kde: ([Media Controller] 
Enforce PlainText format)
  change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  change: edit applets/mediacontroller/contents/ui/main.qml
Revision ecbcf6f831020b415325fb36acb2efb957457e75 by kde: ([Media Controller] 
Enforce PlainText format)
  change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.klipper-testHistory

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2304/5979 
(39%)CONDITIONAL 1624/5952 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL 
56/90 (62%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390 
(66%)CONDITIONAL 113/216 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL 
349/820 (43%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3304 (6%)CONDITIONAL 
122/3251 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 114 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/114/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 13:36:35 +
Build duration: 5 min 44 sec

CHANGE SET
Revision ecbcf6f831020b415325fb36acb2efb957457e75 by kde: ([Media Controller] 
Enforce PlainText format)
  change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2333/5967 
(39%)CONDITIONAL 1634/5924 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3301 (6%)CONDITIONAL 
122/3247 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 113 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/113/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 13:27:45 +
Build duration: 6 min 35 sec

CHANGE SET
Revision 4d3760c8aa9d6a99e5239019fb9a29aab2e22896 by kde: ([Media Controller] 
Enforce PlainText format)
  change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  change: edit applets/mediacontroller/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2333/5967 
(39%)CONDITIONAL 1634/5924 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3301 (6%)CONDITIONAL 
122/3247 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Re: Make xdg-desktop-portal-kde part of Plasma release

[Jonathan Riddell]

On Wed, Apr 19, 2017 at 02:08:52PM +0200, Jan Grulich wrote:
> Hi,
> 
> I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into 
> Plasma to have it released with Plasma 5.10 and so on. 

why the name xdg-desktop-portal? Isn't flatpak-something more appropriate?

Jonathan

D5464: Nextcloud Upload Purpose Plugin

[Yuen Hoe Lim]

yuenlim updated this revision to Diff 13598.
yuenlim added a comment.


  Oops minor mistake. Forgot to remove the declaration of createTargetUrl

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5464?vs=13596=13598

REVISION DETAIL
  https://phabricator.kde.org/D5464

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/nextcloud/CMakeLists.txt
  src/plugins/nextcloud/Messages.sh
  src/plugins/nextcloud/nextcloud-upload.service.in
  src/plugins/nextcloud/nextcloudjob.cpp
  src/plugins/nextcloud/nextcloudjob.h
  src/plugins/nextcloud/nextcloudplugin.cpp
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/nextcloud/nextcloudplugin_config.qml

To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5464: Nextcloud Upload Purpose Plugin

[Yuen Hoe Lim]

yuenlim marked 2 inline comments as done.
yuenlim added a comment.


  Hope the translation domain part is correct. I only found it in the 
phabricator plugin's CMakeLists, most of the other plugins don't seem to have 
it.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D5464

To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5464: Nextcloud Upload Purpose Plugin

[Yuen Hoe Lim]

yuenlim updated this revision to Diff 13596.
yuenlim added a comment.


  Addressed comments!

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5464?vs=13470=13596

REVISION DETAIL
  https://phabricator.kde.org/D5464

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/nextcloud/CMakeLists.txt
  src/plugins/nextcloud/Messages.sh
  src/plugins/nextcloud/nextcloud-upload.service.in
  src/plugins/nextcloud/nextcloudjob.cpp
  src/plugins/nextcloud/nextcloudjob.h
  src/plugins/nextcloud/nextcloudplugin.cpp
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/nextcloud/nextcloudplugin_config.qml

To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Make xdg-desktop-portal-kde part of Plasma release

[Jonathan Riddell]

On 19 April 2017 at 13:08, Jan Grulich  wrote:
> I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into
> Plasma to have it released with Plasma 5.10 and so on.
>
> What is xdg-desktop-portal-kde:
> It's a KDE implementation of Flatpak portals backend [2], currently with
> support of AppChooser, FileChooser, Notification and Print portals.
>
> How it works:
> An app running in sandbox communicates with outside world using
> org.freedesktop.portal.Foo interfaces (each of them is one portal). These
> interfaces are registered by xdg-desktop-portal (on DBus as
> org.freedesktop.portal.Desktop service). This requires support in library to
> make widgets etc. do calls to o.f.p.Foo interfaces instead of doing what they
> usually do. This is already implemented in KNotifications and for Qt part we
> have flatpak platform plugin. Then xdg-desktop-portal calls desktop specific
> implementations to present native dialogs and have proper integration. That's
> where xdg-desktop-portal-kde takes place. It exposes it's implementation on
> DBus as org.freedesktop.impl.portal.desktop.kde service. Then in case of KDE
> when user requests a file dialog from a sandboxed application, Qt platform
> plugin does a dbus call to xdg-desktop-portal instead of showing a dialog and
> xdg-desktop-portal forwards this to our backend implementation and we show a
> native dialog to the user, this time this dialog is not running in sandbox and
> user can open a file which is outside the sandboxed application. Same way it
> works with opening URLs, notifications etc.

Works for me, please put it through the kdereview process

I see that it includes a private header from QtPrintSupport, I'm
against doing this as it breaks any ABI assumptions.

Jonathan

Re: Make xdg-desktop-portal-kde part of Plasma release

[Aleix Pol]

On Wed, Apr 19, 2017 at 2:08 PM, Jan Grulich  wrote:
> Hi,
>
> I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into
> Plasma to have it released with Plasma 5.10 and so on.
>
> What is xdg-desktop-portal-kde:
> It's a KDE implementation of Flatpak portals backend [2], currently with
> support of AppChooser, FileChooser, Notification and Print portals.
>
> How it works:
> An app running in sandbox communicates with outside world using
> org.freedesktop.portal.Foo interfaces (each of them is one portal). These
> interfaces are registered by xdg-desktop-portal (on DBus as
> org.freedesktop.portal.Desktop service). This requires support in library to
> make widgets etc. do calls to o.f.p.Foo interfaces instead of doing what they
> usually do. This is already implemented in KNotifications and for Qt part we
> have flatpak platform plugin. Then xdg-desktop-portal calls desktop specific
> implementations to present native dialogs and have proper integration. That's
> where xdg-desktop-portal-kde takes place. It exposes it's implementation on
> DBus as org.freedesktop.impl.portal.desktop.kde service. Then in case of KDE
> when user requests a file dialog from a sandboxed application, Qt platform
> plugin does a dbus call to xdg-desktop-portal instead of showing a dialog and
> xdg-desktop-portal forwards this to our backend implementation and we show a
> native dialog to the user, this time this dialog is not running in sandbox and
> user can open a file which is outside the sandboxed application. Same way it
> works with opening URLs, notifications etc.
>
> What do you think?
>
> [1] - https://cgit.kde.org/xdg-desktop-portal-kde.git/
> [2] - 
> http://flatpak.org/xdg-desktop-portal/portal-docs.html#idm140258860052032

Hi Jan,
+1

FWIW this was also discussed in a Neon bug report:
https://bugs.kde.org/show_bug.cgi?id=378919

Also note that while this is currently only used by Flatpak, it seems
like snap is on their way to adopt something along the lines.

Just one note. This is integrating kde frameworks currently, but maybe
it would make more sense to have it renamed as
xdg-desktop-portal-plasma?

Aleix

Make xdg-desktop-portal-kde part of Plasma release

[Jan Grulich]

Hi,

I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into 
Plasma to have it released with Plasma 5.10 and so on. 

What is xdg-desktop-portal-kde:
It's a KDE implementation of Flatpak portals backend [2], currently with 
support of AppChooser, FileChooser, Notification and Print portals. 

How it works:
An app running in sandbox communicates with outside world using 
org.freedesktop.portal.Foo interfaces (each of them is one portal). These 
interfaces are registered by xdg-desktop-portal (on DBus as 
org.freedesktop.portal.Desktop service). This requires support in library to 
make widgets etc. do calls to o.f.p.Foo interfaces instead of doing what they 
usually do. This is already implemented in KNotifications and for Qt part we 
have flatpak platform plugin. Then xdg-desktop-portal calls desktop specific 
implementations to present native dialogs and have proper integration. That's 
where xdg-desktop-portal-kde takes place. It exposes it's implementation on 
DBus as org.freedesktop.impl.portal.desktop.kde service. Then in case of KDE 
when user requests a file dialog from a sandboxed application, Qt platform 
plugin does a dbus call to xdg-desktop-portal instead of showing a dialog and 
xdg-desktop-portal forwards this to our backend implementation and we show a 
native dialog to the user, this time this dialog is not running in sandbox and 
user can open a file which is outside the sandboxed application. Same way it 
works with opening URLs, notifications etc.

What do you think? 

[1] - https://cgit.kde.org/xdg-desktop-portal-kde.git/
[2] - http://flatpak.org/xdg-desktop-portal/portal-docs.html#idm140258860052032

Regards,
Jan
-- 
Jan Grulich,
Software Engineer, Desktop Team
Red Hat

D5504: Introduce a HasLauncher data role.

[David Edmundson]

davidedmundson added a comment.


  appsMatch depends on AppId and LauncherURLWithoutIcon
  
  You're handling launcherTasksModel changing, but can we rely on this data 
being static for a proxyIndex?
  
  If not, we need to connect to TasksModel::dataChanged for those roles and 
potentially then emit that HasLauncher changed.
  
  -
  
  Having read your other patch you could argue that you don't need to signal 
this role as you (currently) only use this role from method calls triggered by 
other eventsbut if you take that POV, there's no point doing the 
launcherListChanged connect.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5504

To: hein, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

[Lukáš Tinkl]

lukas requested changes to this revision.
lukas added a comment.
This revision now requires changes to proceed.


  See the inline comment

INLINE COMMENTS

> main.qml:92
> +property int logicalLauncherCount: {
> +if (plasmoid.configuration.seperateLaunchers) {
> +return launcherCount;

/!\ Evil typo spotted

seperateLaunchers -> separateLaunchers

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5505

To: hein, #plasma, davidedmundson, lukas
Cc: lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5507: Don't even try to scale images that we created ad-hoc

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5507

AFFECTED FILES
  src/desktopicon.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, apol

D5497: Improved Suggestions Model

[Aleix Pol Gonzalez]

apol added a comment.


  Okay, well, you know your code, but it all looks fishy.
  Maybe it would be interesting for you to have upstream mycroft people 
involved.

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D5497

To: Aiix
Cc: apol, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

D5464: Nextcloud Upload Purpose Plugin

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  +1
  Please look at David's comments and we'll integrate it.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D5464

To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  When "Keep launchers seperate" is disabled, startup notifications
  replace launchers at their original position. This changes the
  layout for this mode to keep the startup notification item the size
  of the launcher item it replaces (the visual result being a throbber
  on the launcher instead of the launcher being replaced by a "task"
  with a throbber - iow, the expansion to task size is delayed until
  a window appears).
  
  This helps the minimize the jarring visual fallout in cases where
  we can match the startup notification to the launcher, but not the
  window to the startup notification (due to broken/missing window
  metadata), as no longer will two task-sized items co-exist - instead
  the throbber comes and goes on the launcher, seperate from the task
  item for the unidentified window. It also minimizes visual fallout
  if app startup fails or the app merely creates an SNI instead of a
  window.
  
  This change was suggested by Netrunner Linux, which ships a Task
  Manager with "Keep launchers seperate" disabled by default.
  
  Depends on https://phabricator.kde.org/D5504.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5505

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/ui/main.qml

To: hein, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5504: Introduce a HasLauncher data role.

[Eike Hein]

hein added a dependent revision: D5505: Keep startup notifications 
launcher-sized when inserting at launcher position..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5504

To: hein, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5504: Introduce a HasLauncher data role.

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This is implemented by TasksModel and allows clients to reliably
  query whether a row has an associated launcher. Useful for things
  like Pin/Unpin action state or layout decisions.
  
  Previously clients would have to reimplement something like
  TaskTools::appsMatch on top of the model, which we absolutely do
  not want to do - there should only be one copy of the app matching
  logic for consistency's sake. In practice clients would do things
  like fetch LauncherUrl and run it by launcherPosition(), which
  omits appsMatch's AppId comparision, as an example of such unwated
  drift. This approach also avoids the large performance overhead
  involved.
  
  The role is not implemented by the single-type or munging tasks
  models as it has no use there.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5504

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/tasksmodel.cpp

To: hein, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 112 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/112/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 10:38:04 +
Build duration: 20 min

CHANGE SET
Revision e34b0064d6ff787270127d261be65c3b6780b31f by hein: (Fix off-by-one.)
  change: edit libtaskmanager/abstractwindowtasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2333/5967 
(39%)CONDITIONAL 1634/5924 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3301 (6%)CONDITIONAL 
122/3247 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 859 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/859/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 10:38:49 +
Build duration: 9 min 14 sec

CHANGE SET
Revision e34b0064d6ff787270127d261be65c3b6780b31f by hein: (Fix off-by-one.)
  change: edit libtaskmanager/abstractwindowtasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtestFailed: 
TestSuite.klipper-testHistoryFailed: TestSuite.testdesktop

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 13/13 (100%)FILES 52/72 (72%)CLASSES 52/72 (72%)LINE 2110/5751 
(37%)CONDITIONAL 1531/5790 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390 
(66%)CONDITIONAL 113/216 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL 
349/820 (43%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3304 (6%)CONDITIONAL 
122/3251 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 720 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/720/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 07:17:34 +
Build duration: 7 min 32 sec

CHANGE SET
Revision df9cee28e120167414a5ae79e4835c8b6533f807 by fAnDrEs Fabian: (Fix new 
checkbox for file content indexing in kcm_baloofile)
  change: edit kcms/baloo/kcm.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 940 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/940/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 04:07:02 +
Build duration: 9 min 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 940 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/940/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Apr 2017 04:07:02 +
Build duration: 9 min 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

D5499: Fix new checkbox for file content indexing in kcm_baloofile

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:df9cee28e120: Fix new checkbox for file content indexing 
in kcm_baloofile (authored by fvogt).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5499?vs=13578=13587

REVISION DETAIL
  https://phabricator.kde.org/D5499

AFFECTED FILES
  kcms/baloo/kcm.cpp

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5381: Add brightness control using ddcutil lib

[Dorian Vogel]

dvogel updated this revision to Diff 13586.
dvogel added a comment.


  Addition of a QTimer set by default to 1 sec to filter setBrightness calls: 
the actual DDC communication happens 1 sec after the last setBrightness() call.
  This solves brightness flickering when scrolling quickly on the battery icon, 
and communication failure over DDC when waking the monitor from power-save mode 
(Dell U2212HM wakes up in less than 1 sec).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5381?vs=13395=13586

REVISION DETAIL
  https://phabricator.kde.org/D5381

AFFECTED FILES
  daemon/backends/CMakeLists.txt
  daemon/backends/upower/ddcutilbrightness.cpp
  daemon/backends/upower/ddcutilbrightness.h
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/powerdevilupowerbackend.h

To: dvogel, broulik
Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol