D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Michail Vourlakos
mvourlakos added a comment.


  Just to add that because of this way of implementation all plasmoids are 
bound totally to plasma design decisions and cant be used elsewhere e.g. Latte. 
So the plasmoids are bound to plasma paradigm.
  
  I hope only that the user will be able to set the panel iconsizehints to 
greater values than the icon theme provides, at least by editing manually the 
plasma files...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5950

To: hein, #plasma, mart, broulik
Cc: mvourlakos, ivan, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Ivan Čukić
ivan added a comment.


  It would be nicer if we had a better way to do this instead of having a chunk 
of code copy-pasted all over the place.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5950

To: hein, #plasma, mart, broulik
Cc: ivan, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5953: Implement the new panel icon size ceiling also for Input Method Panel.

2017-05-23 Thread Eike Hein
hein added a comment.


  This is a good first start but creates some new problems due to the 
convoluted layout code in the applet: When the panel is really small and forces 
things to be smaller than the preferred size, the icons shrink further but the 
spacing between them doesn't adjjust anymore.
  
  Weng please finish this patch for me since you know your code better. 
Basically, the goal is that in a panel, the icons don't grow beyond System 
Settings -> Icons -> Advanced -> Panel -> Size as we've implemented elsewhere 
for 5.10.
  
  We tag 5.10 on Thursday so there's not much time if we want kimpanel to 
behave well.
  
  For 5.11/12 we should finally look into fixing all of this - instead of being 
a standalone applet kimpanel should create SNIs for every Status Icon that go 
into the system tray, and have a suitable distinct category so we can sort them 
correctly in the tray layout. Then hiding can be done via the tray settings etc 
etc.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5953

To: hein, #plasma, xuetianweng, mart, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5953: Implement the new panel icon size ceiling also for Input Method Panel.

2017-05-23 Thread Eike Hein
hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  It was done for various other applets but not this.
  
  BUG:378443

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5953

AFFECTED FILES
  applets/kimpanel/package/contents/ui/main.qml

To: hein, #plasma, xuetianweng, mart, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Eike Hein
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a8d9038a592e: Implement the new panel icon size ceiling 
also for Activities. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5950?vs=14786&id=14791

REVISION DETAIL
  https://phabricator.kde.org/D5950

AFFECTED FILES
  applets/showActivityManager/package/contents/ui/main.qml

To: hein, #plasma, mart, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b45cb75675c9: Implement the new panel icon size ceiling 
also for Kickoff. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5949?vs=14785&id=14790

REVISION DETAIL
  https://phabricator.kde.org/D5949

AFFECTED FILES
  applets/kickoff/package/contents/ui/Kickoff.qml

To: hein, #plasma, mart, broulik
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5951: Implement the new panel icon size ceiling also for Bluetooth.

2017-05-23 Thread Eike Hein
hein updated this revision to Diff 14788.
hein added a comment.


  Fix.

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5951?vs=14787&id=14788

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5951

AFFECTED FILES
  src/applet/package/contents/ui/CompactRepresentation.qml

To: hein, #plasma, mart, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein added a comment.


  They seem to use the default compact repr and already work.
  
  Trickier question is what to do about Folder View, and also Kimpanel is 
really broken still and a lot more complex to fix.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5949

To: hein, #plasma, mart, broulik
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5951: Implement the new panel icon size ceiling also for Bluetooth.

2017-05-23 Thread Eike Hein
hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  It was done for various other applets but not this.
  
  BUG:378443

REPOSITORY
  R97 Bluedevil

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5951

AFFECTED FILES
  src/applet/package/contents/ui/BluetoothApplet.qml

To: hein, #plasma, mart, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Kai Uwe Broulik
broulik added a comment.


  Indeed, might need a concept of some softer limit, so it won't grow the icon 
(which is what we're trying here) but still has it expand above a given 
threshold. I don't think Kickoff was that usable (or nice to look at, rather) 
in a panel, so fine with me on 5.10.
  
  Btw show desktop (on the default panel setup too I think) and minimize all 
might also need similar treatment.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5949

To: hein, #plasma, mart, broulik
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein added a comment.


  Thx for the accept.
  
  I think it may be possible to write smarter code that does something like 
"look at the switchWidth/switchHeight, and if without the size limit they would 
be reached, drop the limit" or something ... and manage the content and the 
layout sizes indepedently for it. I think we should try to fix this better for 
5.11 for sure.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5949

To: hein, #plasma, mart, broulik
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Kai Uwe Broulik
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5950

To: hein, #plasma, mart, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Fine with me, was just wondering.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5949

To: hein, #plasma, mart, broulik
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Eike Hein
hein added a comment.


  NOTE: We are tagging 5.10 very soon. If this is accepted (and it should be, 
as it is in plasma-desktop and we're advertising this in the release notes) and 
I am for some reason unavailable and not doing it, please make sure and take 
care of pushing this into the 5.10 branch before tagging.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5950

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein added a comment.


  It doesn't, and so far the consensus on 
https://phabricator.kde.org/tag/plasma/ when discussing this has been that we 
care more about fixing the usual vertical panel use case than a Kickoff 
sidebar. It's probably also good for Latte Dock where they have problems with 
the parabolic zoom causing repr switches.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5949

To: hein, #plasma, mart
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Eike Hein
hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  It was done for various other applets but not this.
  
  BUG:378443

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5950

AFFECTED FILES
  applets/showActivityManager/package/contents/ui/main.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Kai Uwe Broulik
broulik added a comment.


  Can you verify that a thick (vertical) panel still gives you an expanded 
Kickoff? That was the reason I didn't implement this for FolderView.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5949

To: hein, #plasma, mart
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein added a comment.


  NOTE: We are tagging 5.10 very soon. If this is accepted (and it should be, 
as this is the default launcher, and this is a feature we're advertising in the 
release notes) and I am for some reason unavailable and not doing it, please 
make sure and take care of pushing this into the 5.10 branch before tagging.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5949

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  It was done for various other applets but not this.
  
  BUG:378443

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5949

AFFECTED FILES
  applets/kickoff/package/contents/ui/Kickoff.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #45 from maxp...@gmail.com ---
I have discovered that konqueror works fine. I can make folders with it, change
names etc. Nothing is greyed out in the root share.

This is without any patch or anything.

Interestingly enough konquerors file management is supposedly provided by
dolphin:

https://forum.kde.org/viewtopic.php?f=22&t=127884#p374651

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Luca Beltrame
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #44 from Luca Beltrame  ---
(In reply to madcatx from comment #43)

> Is it just me or is there currently no obvious way how to get a phabricator
> account? Thanks...

Please register on identity.kde.org, then you can use the "Login with LDAP"
form of Phabricator.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #43 from madc...@atlas.cz ---
(In reply to Luca Beltrame from comment #30)
> If you want the developers to look at the patch, please submit it to
> https://phabricator.kde.org. Patches in Bugzilla unfortunately tend to get
> lost.

Is it just me or is there currently no obvious way how to get a phabricator
account? Thanks...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #42 from madc...@atlas.cz ---
I've done a bit more thorough investigation to see how the access permissions
on UDSEntry actually propagate. Here is what I can tell so far:

Current behavior:
When browsing a Windows network in Dolphin, you can:
 - Rightclick a Workgroup, Server or Share. You will get a context menu with
the "Create new" item greyed out.
 - Rightclick anywhere in the empty space, this should give you the same menu
with the "Create new" item available.
 - When things break, the "Create new" item will be greyed out even when you
rightclick into the empty space with a Share's root open in Dolphin. This is a
result of Dolphin thinking that the location is not writable. Any other means
of writing into that location (drag-n-drop, CTRL+C - CTRL+V, ...) will not work
either. This is the problem we are trying to solve here.

Behavior with my patch:
 - Rightclicking a Share shall give you a menu with the "Create new" item
accessible. Creating a file in the Share this way or dropping a file onto the
Share should work.
 - If you open the Share and try to write into it, it will still be broken.

What you can test:
 1) Apply the patch and navigate to the list of Shares on your server in
Dolphin.
 2) Rightclick one of your "unwritable" shares, go to "Create new->Text file"
and check if you can write into the share this way. Alternatively you can drop
a file onto the Share. If you do it like this you should have write access.
 - If your Share requires a valid username/pass combo, *enter the Share first*,
wait until you are asked for the login credentials, authenticate yourself, go
one level up and only then try to write into the share. Yes, really.

These findings are valid for a Fedora 25 client (kio-extras 16.12 with no Red
Hat clever patches) and CentOS 7 samba 4.4 server with user accounts checked
against Windows AD.

Bottomline: smb_kio will benefit from my patch but it does not really fix the
issue at hand as it seems to be a Dolphin bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Plasma Vault

2017-05-23 Thread Ivan Čukić
> Good. I didn't catch the "instead", that worried me.
> Now I'm back to Zen. :)

You know I'm not sane, but I'm not that insane either ;)


[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #41 from tempel.jul...@gmail.com ---
Would this patch also fix the behavior that files like large videos are first
copied to the client system before they can be watched?
This is another _HUGE_ restriction of the current Samba share support of KDE.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5757: add requestToggleKeepAbove/below

2017-05-23 Thread Eike Hein
hein accepted this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5757

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5757: add requestToggleKeepAbove/below

2017-05-23 Thread Marco Martin
mart added a comment.


  ping?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5757

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D5012: Delay notifications until desktop session has loaded

2017-05-23 Thread Fabian Vogt
fvogt added a comment.


  In https://phabricator.kde.org/D5012#111331, @davidedmundson wrote:
  
  > There's no need for the .service file to match the dbus service name
  >
  > We change that, we get no file colision.
  >  I wrote a patch on Friday when someone told me on irc, but hadn't tested 
because I had to rebuild something.
  >  I'm back tomorrow, will upload then.
  
  
  This is not a real fix.
  
  Quoting the specification 
(https://dbus.freedesktop.org/doc/dbus-specification.html#message-bus-starting-services):
  
  > On the well-known session bus, if two .service files in the same directory 
offer the same service name, the result is undefined. Distributors should avoid 
this situation, for instance by naming session services' .service files 
according to their service name.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, 
dfaure, graesslin
Cc: fvogt, lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, 
plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5942: Check if plymouth file is known to update-alternatives before setting

2017-05-23 Thread Leszek Lesner
leszeklesner updated this revision to Diff 14776.
leszeklesner added a comment.


  Fixed qDebug typo.

REPOSITORY
  R258 Plymouth KCM

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5942?vs=14772&id=14776

REVISION DETAIL
  https://phabricator.kde.org/D5942

AFFECTED FILES
  src/helper.cpp

To: leszeklesner, mart
Cc: fvogt, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5942: Check if plymouth file is known to update-alternatives before setting

2017-05-23 Thread Fabian Vogt
fvogt added inline comments.

INLINE COMMENTS

> helper.cpp:70
> +QByteArray data;
> +qDebug() << "Running update-initramfs --list default.plymouth now";
> +checkProcess.start("update-alternatives --list default.plymouth");

Should be `update-alternatives` here.

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D5942

To: leszeklesner, mart
Cc: fvogt, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D5927: improve positioning for highlight in systray

2017-05-23 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:40cc6c359cb5: improve positioning for highlight in 
systray (authored by mvourlakos).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5927?vs=14766&id=14775

REVISION DETAIL
  https://phabricator.kde.org/D5927

AFFECTED FILES
  applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

To: mvourlakos, #plasma, mart, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


Re: kdereview: qqc2-desktop-style

2017-05-23 Thread Marco Martin
On Sun, May 21, 2017 at 7:16 PM, Albert Astals Cid  wrote:
> if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_BINARY_DIR}")
>message(FATAL_ERROR "climbinggrades bla bla bla.")
> endif()
>
> This is not climbinggrades ;)



thanks, fixed

--
Marco Martin


Plasma 5.8.7 LTS

2017-05-23 Thread Jonathan Riddell
Plasma 5.8.7 LTS tars are available now with three months' worth of bug fixes

https://www.kde.org/announcements/plasma-5.8.7.php


D5012: Delay notifications until desktop session has loaded

2017-05-23 Thread David Edmundson
davidedmundson added a comment.


  There's no need for the .service file to match the dbus service name
  
  We change that, we get no file colision.
  I wrote a patch on Friday when someone told me on irc, but hadn't tested 
because I had to rebuild something.
  I'm back tomorrow, will upload then.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, 
dfaure, graesslin
Cc: lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, 
plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5937: No longer build Plasmate by default

2017-05-23 Thread Jonathan Riddell
jriddell added a comment.


  rather than disable the build I've put it into a separate repo kde:plasmate 
and removed it from kde:plasma-sdk both Plasma/5.10 and master branches

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D5937

To: kossebau, #plasma, sandroandrade, jriddell, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5937: No longer build Plasmate by default

2017-05-23 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision.
kossebau added a comment.


  Plasmate got moved into own repo now, discarding.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D5937

To: kossebau, #plasma, sandroandrade, jriddell, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5012: Delay notifications until desktop session has loaded

2017-05-23 Thread Valerio Pilo
vpilo added a comment.


  In https://phabricator.kde.org/D5012#110815, @lbeltrame wrote:
  
  > Months later, it turns out that notify-osd ships a 
org.freedesktop.Notifications.service already, so it conflicts with the one 
made by this patch.
  
  
  I wouldn't know what course of action would be best to follow in this case. 
@davidedmundson ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, 
dfaure, graesslin
Cc: lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, 
plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


Minutes Monday Plasma Meeting

2017-05-23 Thread Sebastian Kügler
We met, and I almost forgot to send the minutes! Here we go!
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Meeting 21-35-2017

Present: notmart, Sho, bshah, sebas

notmart:
* fix kirigami2 pagerow tests https://phabricator.kde.org/D5868
  Diff 5868 "make pagerow test pass" [Closed] https://phabricator.kde.org/D5868
* fix a crash caused by kxmlgui menu patch
* request keepabove/below https://phabricator.kde.org/D5757
  Diff 5757 "add requestToggleKeepAbove/below" [Needs Review] 
https://phabricator.kde.org/D5757
* krunner: workaround for wayland positioning (the qt bug) 
https://phabricator.kde.org/D5748
  Diff 5748 "workaround for correct wayland positioning" [Needs Review] 
https://phabricator.kde.org/D5748
* fix shadows in popup menus in wayland
* upstream issue for popupmenu bug https://bugreports.qt.io/browse/QTBUG-60932
* set transientparent for some more menus [pushed]

Sho:
* [TM] Investigated a serious bug causing launchers specific to an activity 
other than the current one to be lost when rearranging launchers on the current 
activity; handed investigation results to Ivan, have his Phab to review today
* [Wayland] Working on VD protocol
* [General] Trying to figure out what to do about libinput wheel acceleration 
breaking mousewheel stuff in Plasma (page flips, tab switches, etc. happening 
spuriously due to extra mouse events)
* [FV] Currently looking into some icon selection state buggery in the beta 
someone told me about yesterday
* [Other] Anyone seen Kai lately?

bshah:
- Halium initial prototype shows sign of life : 
https://pbs.twimg.com/media/DAQ8cI8UQAArc9F.jpg:large
- We have systemd + android container working now
- Working on fixing up libhybris tests

Riddell:
* Plasma 5.8.7 is tomorrow! -- get your LTS bug fixes in pronto
* 5.10.0 is tarred on Thursday and released on tuesday
* do eye over the release announce 
https://www.kde.org/announcements/plasma-5.10.0.php

sebas:
* was at marketing meeting in Berlin last week, discussed some strategies and 
background for marketing KDE and specifically Plasma, experiences, what worked, 
what didn't, how the KDE 4.0 backlash was handled, etc.
* added pid information to the Plasma wayland procotol
* worked on a regression in the PlasmaWindow Wayland protocol, eventually fixed 
by d_ed
* kscreen triaging
* working on fixed configuration for kscreen for flaky outputs to not change 
the whole config (WIP)


[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Martin Samek
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #40 from Martin Samek  ---
For some reason in my case attempt to access smb share eats 4 cores at 100%

 3317 marsark   20   0  527504  26620  22188 R 100,0  0,2   0:32.47 smb.so  
 3305 marsark   20   0  527500  26616  22188 R  99,7  0,2   0:32.56 smb.so  
 3306 marsark   20   0  527504  26620  22188 R  99,7  0,2   0:32.60 smb.so  
 3318 marsark   20   0  527500  26616  22188 R  99,7  0,2   0:32.51 smb.so 

I successfully build kio-extra with debug patch. I will test it against my
Synology NAS.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5937: No longer build Plasmate by default

2017-05-23 Thread Jonathan Riddell
jriddell added a comment.


  There is a new git repo intended for this, kde:plasmate, I'll ask on mailing 
list if it's better to use that or just disable

REPOSITORY
  R118 Plasma SDK

BRANCH
  dontbuildplasmatebydefault

REVISION DETAIL
  https://phabricator.kde.org/D5937

To: kossebau, #plasma, sandroandrade, jriddell, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5943: Set kauth timeout to timeout for the update-initramfs -u process

2017-05-23 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D5943

To: leszeklesner, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5942: Check if plymouth file is known to update-alternatives before setting

2017-05-23 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D5942

To: leszeklesner, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5927: improve positioning for highlight in systray

2017-05-23 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systray

REVISION DETAIL
  https://phabricator.kde.org/D5927

To: mvourlakos, #plasma, mart, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


Re: Plasma Vault

2017-05-23 Thread Sebastian Kügler
On dinsdag 23 mei 2017 10:26:01 CEST Ivan Čukić wrote:
> > will still make kded5 spin at 100%, and we're planning to release that
> > code?
> 
> Of course not - as I said, it will print out the proper message
> instead of making CPUs burn.

Good. I didn't catch the "instead", that worried me. Now I'm back to Zen. :)
-- 
sebas

http://www.kde.org | http://vizZzion.org


D5937: No longer build Plasmate by default

2017-05-23 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R118 Plasma SDK

BRANCH
  dontbuildplasmatebydefault

REVISION DETAIL
  https://phabricator.kde.org/D5937

To: kossebau, #plasma, sandroandrade, jriddell, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5943: Set kauth timeout to timeout for the update-initramfs -u process

2017-05-23 Thread Leszek Lesner
leszeklesner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We need to set the timeout for kauth to at least the same as that for the 
update-initramfs -u process (which is 6msec) otherwise DBUS timesout too 
early.

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D5943

AFFECTED FILES
  src/kcm.cpp

To: leszeklesner, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #39 from madc...@atlas.cz ---
(In reply to Christoph Feck from comment #37)
> > kio_smb sets the permissions on the UDSEntries correctly but Dolphin seems 
> > to have a mind of its own.
> 
> In other words, using Dolphin copying fails, but using "kioclient5 cp" works?

I just got it to happen again and yes, this is exactly the case. The patch to
set the UDSEntry access still seems to be needed but it is not the only issue
at play here.

It seems that it may have something to do with login credentials. This is how I
managed to trigger the problem:

I accessed a share that is usually unwritable. In this particular instance
everything seemed to be OK and I could write into it through Dolphin. I opened
a directory in that share and got asked for my login credentials again for some
reason. Until I OK'ed the creds prompt, the "Create new" item in the rightclick
menu in Dolphin was greyed out. When I returned back to the share's root, the
write access to it from Dolphin was gone by kioclient worked. Weird...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #38 from madc...@atlas.cz ---
Created attachment 105687
  --> https://bugs.kde.org/attachment.cgi?id=105687&action=edit
Debugging patch

If there is anybody able to reproduce the problem reliably, there is a small
testing patch that dumps the access permissions set by smb_kio into the system
log.

In order to see the debugging info, launch "kdebugdialog5", make sure that
"kio_smb" is checked, restart Dolphin, try to access your samba shares and post
the output of "journalctl -b | grep kio_smb". systemd-less distributions might
dump the info into the terminal instead.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #37 from Christoph Feck  ---
> kio_smb sets the permissions on the UDSEntries correctly but Dolphin seems to 
> have a mind of its own.

In other words, using Dolphin copying fails, but using "kioclient5 cp" works?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #36 from madc...@atlas.cz ---
Thanks, I figured that the logs are dumped through systemd already. This still
does not answer the question where does Dolphin get the access permissions info
from. Either some other layer messes with them along the way or the
UDSEntry::ACCESS is not the source of access permissions used by Dolphin. As
far as the debug output tells me, kio_smb with my patch sets the access
permissions correctly.

I believe that this is the actual root cause of the problem. I gave it a quick
spin on another machine at work where this has been acting up and somehow
miraculously I could write into the usually unwritable share this morning. Note
that the machine runs vanilla Fedora 25 with no custom patches anywhere.

As far as I can tell *something* randomly makes the root share look unwritable
for whatever reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #35 from Elvis Angelaccio  ---
(In reply to madcatx from comment #27)
> Created attachment 105682 [details]
> Allow write access to root samba share
> 
> The code still does not work entirely as expected - I am allowed to try to
> write into server shares or workgroup listing which is obviously nonsensical
> and the code seems to try to prevent that, it just does not work. I cannot
> investigate this any further unless I can pry some debugging output out of
> the smb_kio plugin.

kio_smb's debug output comes from kdeinit5. You should be able to get it from
journalctl, but you need to enable it first: make sure you add

[Rules]
kio_smb.debug=true

in ~/.config/QtProject/qtlogging.ini

Then "journalctl -b | grep kio_smb" should give you what you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5942: Check if plymouth file is known to update-alternatives before setting

2017-05-23 Thread Leszek Lesner
leszeklesner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If the plymouth theme is not known to update-alternatives trying to execute 
update-alternatives --set will always fail. 
  As plymouth kcm shows all plymouth themes in themes directory but not all are 
necessarily known to update-alternatives we need to check if they are known and 
if not use the update-alternatives --install instead of --set.

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D5942

AFFECTED FILES
  src/helper.cpp

To: leszeklesner, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-05-23 Thread Martin Flöser
graesslin added a comment.


  I wouldn't call it color correction as we used to have a mechanism called 
color correction in the past which did something very different. Personal 
suggestion: gamma correction or color temperature correction.
  
  Sorry cannot do a full review for the next few weeks.
  
  Personally I do not mind whether the functionality is in KWin or extern. The 
argument of first frane after suspend is a good one. I didn't check the code in 
detail so ignote if it doesn't matter: in long term I want to forbid KWin to 
have Internet access. So the geolocation neefs to happen outside of KWin.
  
  And congrats for top item on r/linux :-P

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5928

To: subdiff, #kwin
Cc: graesslin, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, hein, lukas


Re: Plasma Vault

2017-05-23 Thread Ivan Čukić
> It could still benefit from a cmake message of missing runtime dependencies.

I agree. Will see to add it soon.

Cheers,
Ivan

-- 
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3  45DF C9C5 77AF 0A37 240A


Re: Plasma Vault

2017-05-23 Thread Jonathan Riddell
On Mon, May 22, 2017 at 07:08:48PM +0200, Ivan Čukić wrote:
> Thanks for this. I had problems with the docker image, so I succeeded
> in reproducing the issue in VBox.
> 
> I'll push the fix soon. Mind that it will still not work in Neon (old
> version of encfs and no version of cryfs in main repos), but at least
> it will print out the proper message.

Thanks that seems to have sorted it with a user friendly message on running it.

It could still benefit from a cmake message of missing runtime dependencies.

Jonathan


[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #34 from madc...@atlas.cz ---
There has got to be something else going in. kio_smb sets the permissions on
the UDSEntries correctly but Dolphin seems to have a mind of its own.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Plasma Vault

2017-05-23 Thread Ivan Čukić
> will still make kded5 spin at 100%, and we're planning to release that
> code?

Of course not - as I said, it will print out the proper message
instead of making CPUs burn.

Cheers,
Ivan



-- 
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3  45DF C9C5 77AF 0A37 240A


[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Bronson
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #33 from Bronson  ---
ok ive ran the makepkg command(assuming this also will install the package).
Rebooted, and still have the same bug present in dolphin...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Bronson
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #32 from Bronson  ---
cant edit my last comment. Got around it with:
gpg --recv-keys 3A6A4DB839EAA6D7

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Bronson
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #31 from Bronson  ---
(In reply to madcatx from comment #28)
> Created attachment 105683 [details]
> Patched Arch Linux PKGBUILG
> 
> Archers are welcome to try this patched PKGBUILD.

I get the following error with the PKGBUILD (just running makepkg from cmd):
kio-extras-17.04.1.tar.xz ... FAILED (unknown public key 3A6A4DB839EAA6D7)
==> ERROR: One or more PGP signatures could not be verified!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Luca Beltrame
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #30 from Luca Beltrame  ---
If you want the developers to look at the patch, please submit it to
https://phabricator.kde.org. Patches in Bugzilla unfortunately tend to get
lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

madc...@atlas.cz changed:

   What|Removed |Added

 Attachment #105680|0   |1
is obsolete||

--- Comment #29 from madc...@atlas.cz ---
Comment on attachment 105680
  --> https://bugs.kde.org/attachment.cgi?id=105680
Allow write access to root samba share

>diff --git a/smb/kio_smb_browse.cpp b/smb/kio_smb_browse.cpp
>index 67e2fa09..7092e41c 100644
>--- a/smb/kio_smb_browse.cpp
>+++ b/smb/kio_smb_browse.cpp
>@@ -381,7 +381,7 @@ void SMBSlave::listDir( const QUrl& kurl )
>udsentry.insert( KIO::UDSEntry::UDS_FILE_TYPE, S_IFDIR );
> 
>// Set permissions
>-   udsentry.insert(KIO::UDSEntry::UDS_ACCESS, (S_IRUSR | S_IRGRP 
>| S_IROTH | S_IXUSR | S_IXGRP | S_IXOTH));
>+   udsentry.insert(KIO::UDSEntry::UDS_ACCESS, (S_IRWXU | S_IRWXG 
>| S_IROTH | S_IXOTH));
> 
>if (dirp->smbc_type == SMBC_SERVER) {
>// QString workgroup = m_current_url.host().toUpper();

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #28 from madc...@atlas.cz ---
Created attachment 105683
  --> https://bugs.kde.org/attachment.cgi?id=105683&action=edit
Patched Arch Linux PKGBUILG

Archers are welcome to try this patched PKGBUILD.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #27 from madc...@atlas.cz ---
Created attachment 105682
  --> https://bugs.kde.org/attachment.cgi?id=105682&action=edit
Allow write access to root samba share

The code still does not work entirely as expected - I am allowed to try to
write into server shares or workgroup listing which is obviously nonsensical
and the code seems to try to prevent that, it just does not work. I cannot
investigate this any further unless I can pry some debugging output out of the
smb_kio plugin. The problem of unwritable share root seems to be gone though.

-- 
You are receiving this mail because:
You are the assignee for the bug.