D6041: Port a bunch of classes away from Plasma::Package

2017-05-30 Thread Aleix Pol Gonzalez 
apol created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Ported away some classes, removes many unneeded casts that happen when 
starting.

TEST PLAN
  Tests still pass, plasma starts properly

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6041

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/packageurlinterceptortest.cpp
  autotests/packageurlinterceptortest.h
  src/plasma/pluginloader.cpp
  src/plasma/pluginloader.h
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/appletquickitem.h
  src/plasmaquick/configview.cpp
  src/plasmaquick/containmentview.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/private/appletquickitem_p.h
  src/plasmaquick/view.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: apol, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

[plasmashell] [Bug 380374] WindowList should group by Activity

2017-05-30 Thread Christoph Feck 
https://bugs.kde.org/show_bug.cgi?id=380374

Christoph Feck  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 380374] New: WindowList should group by Activity

2017-05-30 Thread Don Nguyen 
https://bugs.kde.org/show_bug.cgi?id=380374

Bug ID: 380374
   Summary: WindowList should group by Activity
   Product: plasmashell
   Version: master
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: Window List
  Assignee: plasma-devel@kde.org
  Reporter: don78color...@gmail.com
  Target Milestone: 1.0

I would like the WindowList to be grouped first by Activities, then Virtual
Desktops, similar to the KDE4 WindowList-QML. 

For those of us who use KDE Activities, the current WindowList doesn't provide
organization.  The listing is just a huge mess of windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6035: Force KAccess to run under XCB

2017-05-30 Thread David Edmundson 
davidedmundson retitled this revision from "Use right QProcess API" to "Force 
KAccess to run under XCB".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6035

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5994: Force kaccess to run under X

2017-05-30 Thread David Edmundson 
davidedmundson abandoned this revision.
davidedmundson added a comment.


  Fair enough. My rationale was that we might end up running two kaccesses in 
different modes in future, but at that point I'll just make two executables.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5994

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6035: Use right QProcess API

2017-05-30 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KAccess is responsible for:
  
  visual system bell
  stick keys/slow keys
  starting orca
  
  None of this will work in wayland as-is; and when they are done, will
  probably be in kwin anyway.
  
  But, we do still want this set up for xwayland applications.
  
  This sets the platform, so that we have xwayland apps still working the
  same. Making wayland apps work properly is a task for another day.
  
  Primarily this stops the thing crashing on startup.
  
  BUG:372597

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6035

AFFECTED FILES
  kaccess/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

[kio-extras] [Bug 380302] smb:// KIO still tries SMBv1 first which is blocked by modern servers

2017-05-30 Thread Rex Dieter 
https://bugs.kde.org/show_bug.cgi?id=380302

--- Comment #2 from Rex Dieter  ---
Or rather, do other things work as expected, like 'smbclient' ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 380302] smb:// KIO still tries SMBv1 first which is blocked by modern servers

2017-05-30 Thread Rex Dieter 
https://bugs.kde.org/show_bug.cgi?id=380302

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

--- Comment #1 from Rex Dieter  ---
How are you specifying protocol in smb.conf? (I ask because it's non-obvious
and easy to get wrong).

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6028: Use own fork of QQuickStyleItem

2017-05-30 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:9623a35f63d2: Use own fork of QQuickStyleItem (authored 
by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6028?vs=14984=14988#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6028?vs=14984=14988

REVISION DETAIL
  https://phabricator.kde.org/D6028

AFFECTED FILES
  CMakeLists.txt
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckDelegate.qml
  org.kde.desktop/CheckIndicator.qml
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Dial.qml
  org.kde.desktop/Dialog.qml
  org.kde.desktop/Drawer.qml
  org.kde.desktop/Frame.qml
  org.kde.desktop/GroupBox.qml
  org.kde.desktop/ItemDelegate.qml
  org.kde.desktop/Label.qml
  org.kde.desktop/Menu.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/Popup.qml
  org.kde.desktop/ProgressBar.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/RadioDelegate.qml
  org.kde.desktop/RadioIndicator.qml
  org.kde.desktop/RangeSlider.qml
  org.kde.desktop/ScrollBar.qml
  org.kde.desktop/Slider.qml
  org.kde.desktop/SpinBox.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/SwitchDelegate.qml
  org.kde.desktop/SwitchIndicator.qml
  org.kde.desktop/TabBar.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/TextArea.qml
  org.kde.desktop/TextField.qml
  org.kde.desktop/ToolBar.qml
  org.kde.desktop/ToolButton.qml
  org.kde.desktop/ToolTip.qml
  org.kde.desktop/private/DefaultListItemBackground.qml
  plugin/CMakeLists.txt
  plugin/SystemPaletteSingleton.qml
  plugin/TextSingleton.qml
  plugin/kquickpadding_p.h
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h
  plugin/qmldir
  plugin/qqc2desktopstyleplugin.cpp
  plugin/qqc2desktopstyleplugin.h
  plugin/qsgdefaultninepatchnode.cpp
  plugin/qsgdefaultninepatchnode_p.h
  plugin/qsgninepatchnode.cpp
  plugin/qsgninepatchnode.h

To: mart, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6028: Use own fork of QQuickStyleItem

2017-05-30 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  looks good. (well except for how horrible that borrowed Qt class is)
  
  We need to fix the OS X code path. (even if we just comment out the current 
stuff)

INLINE COMMENTS

> kquickstyleitem.cpp:188
> +if (style() == QLatin1String("mac")) {
> +if (platformFont == QPlatformTheme::PushButtonFont)
> +menu->setProperty("__xOffset", 12);

This won't compile; there's not such member var.

(I know this is the bit of code I ported...sorry!)

> kquickstyleitem.cpp:401-402
> +opt->font = font;
> +opt->fontMetrics = QFontMetrics(font);
> +m_font = opt->font;
> +}

I know this is inherited code, but I'm in review mode.

This m_font stuff is (and was) truly broken.

The code in updateHints is:

  initStyleOption();
  updateSizeHint();
  if (m_styleoption->state & QStyle::State_Mini) {
  m_font.setPointSize(9.);

Which means we're changing the font *after* we've set it to the font metrics of 
the QStyleItem.

I'm thinking we could can move it all to be at the top of this method.

m_font = qApp->font(classNameForType());
if (mini) {m_font.setSize(...)

Lets make that a job for later though.

> kquickstyleitem_p.h:4
> +** Copyright (C) 2016 The Qt Company Ltd.
> +** Contact: https://www.qt.io/licensing/
> +**

We should add us here and in the cpp

> kquickstyleitem_p.h:271
> +protected:
> +QWidget *m_dummywidget;
> +QStyleOption *m_styleoption;

unused?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  mart/qquickstyleitemfork

REVISION DETAIL
  https://phabricator.kde.org/D6028

To: mart, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5768: Use the first thumbnail as icon for KNS resources

2017-05-30 Thread Aleix Pol Gonzalez 
apol added a comment.


  @leinir remember to close `BUG: 360675` with this one.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5768

To: leinir, apol
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6028: Use own fork of QQuickStyleItem

2017-05-30 Thread Marco Martin 
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  use a local copy of qqc1 qquickstyleitem, remove all qqc1 usage

TEST PLAN
  all of kirigami gallery works with the new style

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  mart/qquickstyleitemfork

REVISION DETAIL
  https://phabricator.kde.org/D6028

AFFECTED FILES
  CMakeLists.txt
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckDelegate.qml
  org.kde.desktop/CheckIndicator.qml
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Dial.qml
  org.kde.desktop/Dialog.qml
  org.kde.desktop/Drawer.qml
  org.kde.desktop/Frame.qml
  org.kde.desktop/GroupBox.qml
  org.kde.desktop/ItemDelegate.qml
  org.kde.desktop/Label.qml
  org.kde.desktop/Menu.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/Popup.qml
  org.kde.desktop/ProgressBar.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/RadioDelegate.qml
  org.kde.desktop/RadioIndicator.qml
  org.kde.desktop/RangeSlider.qml
  org.kde.desktop/ScrollBar.qml
  org.kde.desktop/Slider.qml
  org.kde.desktop/SpinBox.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/SwitchDelegate.qml
  org.kde.desktop/SwitchIndicator.qml
  org.kde.desktop/TabBar.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/TextArea.qml
  org.kde.desktop/TextField.qml
  org.kde.desktop/ToolBar.qml
  org.kde.desktop/ToolButton.qml
  org.kde.desktop/ToolTip.qml
  org.kde.desktop/private/DefaultListItemBackground.qml
  plugin/CMakeLists.txt
  plugin/SystemPaletteSingleton.qml
  plugin/TextSingleton.qml
  plugin/kquickpadding_p.h
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h
  plugin/qmldir
  plugin/qqc2desktopstyleplugin.cpp
  plugin/qqc2desktopstyleplugin.h
  plugin/qsgdefaultninepatchnode.cpp
  plugin/qsgdefaultninepatchnode_p.h
  plugin/qsgninepatchnode.cpp
  plugin/qsgninepatchnode.h

To: mart, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6027: Use existing parseInt function

2017-05-30 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There's already a QString::toInt() that validates input. We don't need
  to make our own.
  
  Also there was a bug in the current point parsing code if the first was
  invalid but the second valid. Both need to be checked.

TEST PLAN
  Compiles

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6027

AFFECTED FILES
  src/doctor/doctor.cpp
  src/doctor/doctor.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6026: Add setScale option to kscreendoctor

2017-05-30 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Adds set scale option to kscreen doctor. 
  Can I put this in 5.10 branch too please.

TEST PLAN
  Ran it, my screen changed awesomely.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6026

AFFECTED FILES
  src/doctor/doctor.cpp
  src/doctor/doctor.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5768: Use the first thumbnail as icon for KNS resources

2017-05-30 Thread Aleix Pol Gonzalez 
apol added a comment.


  In https://phabricator.kde.org/D5768#112774, @mart wrote:
  
  > In https://phabricator.kde.org/D5768#112114, @apol wrote:
  >
  > > Or we apply it for master and hope Kirigami 2.2 is released before next 
Plasma release.
  >
  >
  > we can make it happen soon.
  >  i just wanted to know if scroll wheel behavior is alright now, then for 
what i'm concerned we can release
  
  
  Eh... scroll isn't great, haven't had time to spend on it though. You can do 
a quick test, you'll see.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5768

To: leinir, apol
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D3650: lower mouse acceleration limit to 0.0

2017-05-30 Thread Aleix Pol Gonzalez 
apol added a comment.


  In https://phabricator.kde.org/D3650#80584, @graesslin wrote:
  
  > According to my comments in the Wayland port: the value 1.0 means no 
acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's 
still a factor. I'm also afraid that putting a 0.0 there could result in a 
devision by 0 value.
  >
  > So in any case your commit message does not match the actual reality. And 
given that I think you are trying to fix the wrong problem. Might it be that 
you use the libinput xorg driver? If yes, that's not yet supported and needs 
porting. But this change has potential of breaking the non-libinput xorg driver 
then.
  >
  > From my side something between -1 and -2 for this change.
  
  
  Does this mean that 0.0 means not moving at all? That doesn't sound right.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3650

To: sitter, plasma-devel
Cc: apol, graesslin, broulik, jensreuterberg, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, abetts, sebas, mart, lukas

Re: Next Plasma LTS and openSUSE

2017-05-30 Thread Sebastian Kügler 
On maandag 29 mei 2017 12:56:49 CEST David Edmundson wrote:
> Stealing this LTS thread, there's something from Qt I'd like to copy:
> >Currently, Qt 5.6 LTS is in the ‘strict’ phase where it only receives
> >selected critical fixes and next it is moving into the ‘very strict’
> >phase. During this final phase, Qt 5.6 LTS will receive important security
> >fixes only.
> I think this phasing is something we should take on, we're making more
> mistakes as it gets further away from master, and it makes it then more
> managemeable to have two LTS releases in parallel.

I agree. I also think that we should limit the period in which we have two LTS 
releases under maintenance to not more than 6 months. That limits the amount 
of releases we have to maintain in parallel, but gives users who want to jump 
from LTS to LTS ample time to upgrade.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: Plasma 5.10.0

2017-05-30 Thread Harald Sitter 
On Tue, May 30, 2017 at 2:13 PM, Jonathan Riddell  wrote:
> Plasma 5.10.0 is now released
> https://www.kde.org/announcements/plasma-5.10.0.php

It's a beauty!

Thanks to everyone ❤

Plasma 5.10.0

2017-05-30 Thread Jonathan Riddell 
Plasma 5.10.0 is now released
https://www.kde.org/announcements/plasma-5.10.0.php

D6024: Fix detection of sys/event.h on FreeBSD < 12

2017-05-30 Thread Tobias C. Berner 
tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Unfortunately I only tested the kevent stuff on FreeBSD 12. FreeBSD < 12 has 
an older clang, which seems to add less headers automatically.
  
  The call to `check_include_file(sys/event.h)` fails as it's missing 
`sys/types.h`.
  So change this to `check_include_files(sys/types.h;sys/event.h)`.

REPOSITORY
  R133 KScreenLocker

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6024

AFFECTED FILES
  CMakeLists.txt

To: tcberner, #freebsd
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5974: Wizard: Use emblem-success and emblem-error icons

2017-05-30 Thread David Rosca 
This revision was automatically updated to reflect the committed changes.
Closed by commit R97:f3b2736856c0: Wizard: Use emblem-success and emblem-error 
icons (authored by drosca).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5974?vs=14857=14970

REVISION DETAIL
  https://phabricator.kde.org/D5974

AFFECTED FILES
  src/wizard/pages/fail.cpp
  src/wizard/pages/fail.ui
  src/wizard/pages/success.cpp
  src/wizard/pages/success.ui

To: drosca, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6020: add session and power mgmt runners to kickoff

2017-05-30 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d73760978877: add session and power mgmt runners to 
kickoff (authored by sitter).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6020?vs=14966=14968

REVISION DETAIL
  https://phabricator.kde.org/D6020

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: sitter, hein, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6020: add session and power mgmt runners to kickoff

2017-05-30 Thread Eike Hein 
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6020

To: sitter, hein, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6020: add session and power mgmt runners to kickoff

2017-05-30 Thread Harald Sitter 
sitter added a comment.


  already in there 
https://phabricator.kde.org/source/plasma-desktop/browse/master/applets/kicker/package/contents/ui/main.qml;7a4fdbbd6124757ccd9d07fabd8e82ac62bc8995$156

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6020

To: sitter, hein, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6020: add session and power mgmt runners to kickoff

2017-05-30 Thread Eike Hein 
hein added a comment.


  Please also add to kicker/dashboard if missing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6020

To: sitter, hein, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6020: add session and power mgmt runners to kickoff

2017-05-30 Thread Harald Sitter 
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It's a bit weird that kickoff's leave tab has power management actions but
  you cannot actually invoke them via a search.
  
  CHANGELOG: Application Launcher supports searching for power actions

TEST PLAN
  changed, searching for shutdown lists the actual shutdown runnable as result

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6020

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: sitter, hein, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D1230: GBM remote access support for KWin

2017-05-30 Thread Oleg Chernovskiy 
Kanedias added inline comments.

INLINE COMMENTS

> davidedmundson wrote in drm_buffer.cpp:131
> If it's deferred it means someone else is doing the gbm_surface_release.
> 
> But we still need to set m_bo to nullptr. Otherwise it's potentially left 
> dangling here after the RemoteAccessManager has deleted it.
> 
> (Alternately: if we changed DrmObjectPlane to store the buffers as 
> QSharedPointers we could just keep a reference to the DrmBuffer in the 
> RemoteAccessManager, which would be IMHO cleaner than doing low level GBM 
> stuff there and having the data released in one of two places. I'll look into 
> that)

I rewrote this part since this change and it doesn't touch buffers now, if you 
want to take a look at it prior to my resubmission, it's there:

https://gitlab.com/Kanedias/kwin/commit/9535f36bd09f8834be3773f25bf2075a720ba1c4

> davidedmundson wrote in remoteaccess_manager.h:49-50
> what's this signal for?

Forgot to get rid of it, thanks

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D1230: GBM remote access support for KWin

2017-05-30 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> drm_buffer.cpp:131
>  #if HAVE_GBM
> +if (m_deferred) {
> +return;

If it's deferred it means someone else is doing the gbm_surface_release.

But we still need to set m_bo to nullptr. Otherwise it's potentially left 
dangling here after the RemoteAccessManager has deleted it.

(Alternately: if we changed DrmObjectPlane to store the buffers as 
QSharedPointers we could just keep a reference to the DrmBuffer in the 
RemoteAccessManager, which would be IMHO cleaner than doing low level GBM stuff 
there and having the data released in one of two places. I'll look into that)

> remoteaccess_manager.h:49-50
> +
> +signals:
> +void bufferNoLongerNeeded(qint32 gbm_handle);
> +

what's this signal for?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5768: Use the first thumbnail as icon for KNS resources

2017-05-30 Thread Marco Martin 
mart added a comment.


  In https://phabricator.kde.org/D5768#112114, @apol wrote:
  
  > Or we apply it for master and hope Kirigami 2.2 is released before next 
Plasma release.
  
  
  we can make it happen soon.
  i just wanted to know if scroll wheel behavior is alright now, then for what 
i'm concerned we can release

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5768

To: leinir, apol
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Re: Plasma 5.10 video NOT FINAL

2017-05-30 Thread Łukasz Sawicki 
Hi,

> I guess it's two different videos pieces together in which those two icons 
> were manually moved between the two.

That indeed was the case,  fixed now.

https://youtu.be/VtdTC2Mh070

I also added subtitles

Cheers,
Łukasz

D1231: Add Remote Access interface to KWayland

2017-05-30 Thread David Edmundson 
davidedmundson added a comment.


  Seaprate question, 
  In wl_surface when we attach a new buffer we also mark what areas are damaged.
  
  Here we're passing an even bigger buffer.
  
  Would it benefit from a series of damage events being sent in the 
org_kde_kwin_remote_buffer before the gbm_handle event?
  Kwin should have all this information available. Or is it best for VNC do 
that sort of thing itself?

INLINE COMMENTS

> remote-access.xml:23
> +
> +
> +

Assuming we do output merging in the client we want an extra arg with the 
wl_output here.

We don't need want it in the request, as each output will get a different 
buffer and therefore a different ID.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D1231: Add Remote Access interface to KWayland

2017-05-30 Thread David Edmundson 
davidedmundson added a comment.
This revision now requires changes to proceed.


  > Also caused by QtWayland not exposing the wl_output in the native interface.
  
  This might have been true at the time of writing,.  It's not the case now.
  
  nativeResourceForScreen will return a wl_output, we can loop through them, 
and then match the wl_output ID to a buffer here.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D5974: Wizard: Use emblem-success and emblem-error icons

2017-05-30 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R97 Bluedevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5974

To: drosca, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D3650: lower mouse acceleration limit to 0.0

2017-05-30 Thread Jens Reuterberg 
jensreuterberg added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3650

To: sitter, plasma-devel
Cc: graesslin, broulik, jensreuterberg, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, abetts, sebas, apol, mart, lukas

D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-30 Thread Eike Hein 
hein closed this revision.
hein added a comment.


  This was committed as 
https://phabricator.kde.org/R119:a8d9038a592e6d3ed87852bc2fb3a0f93449897d, not 
sure why the ticket didn't get closed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5950

To: hein, #plasma, mart, broulik
Cc: mvourlakos, ivan, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas