D6017: Don't leak MimeData object
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6017 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6017: Don't leak MimeData object
hein added a comment. So you're cleaning up the leak the next time the getter is accessed? What if this never happens? REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6017 To: davidedmundson, #plasma, mart Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6017: Don't leak MimeData object
davidedmundson added a comment. > So you're cleaning up the leak the next time the getter is accessed? No? If it's accessed again m_data is not null so we don't get in that branch The main cleanup is implicitly in the DeclarativeDropEvent destructor REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6017 To: davidedmundson, #plasma, mart Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6017: Don't leak MimeData object
hein accepted this revision. hein added a comment. Sounds good REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6017 To: davidedmundson, #plasma, mart, hein Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6017: Don't leak MimeData object
This revision was automatically updated to reflect the committed changes. Closed by commit R296:695f24fb522a: Don't leak MimeData object (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6017?vs=14959&id=15008 REVISION DETAIL https://phabricator.kde.org/D6017 AFFECTED FILES src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h To: davidedmundson, #plasma, mart, hein Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6041: Port a bunch of classes away from Plasma::Package
mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pluginloader.h:208 > + **/ > +PLASMA_DEPRECATED KPluginInfo::List listAppletInfoForMimeType(const > QString &mimetype); > + wow, phab isn't that smart in the diff it makes checking for binary compatibility quite tricky ;) > appletquickitem.h:105 > > -Plasma::Package appletPackage() const; > -void setAppletPackage(const Plasma::Package &package); > +KPackage::Package appletPackage() const; > +void setAppletPackage(const KPackage::Package &package); despite the warning in the header, this ended up being an exported symbol, so binary compatibility rules apply here too. Plasma::Package appletPackage() const; has to stay, eventually deprecated and a new KPackage::Package appletPackage() const; added. > wallpaperinterface.h:26 > > -#include > +#include > +#include why plasma_export.h? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5801: Split XDGTest to allow testing both V5 and V6
davidedmundson abandoned this revision. davidedmundson added a comment. I was hoping to put anything that affected v5 in a separate commits, with v6 separate, but that didn't really happen. Will include with the other stuff. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5801 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6000: Handle differences in PAM headers
jriddell accepted this revision. jriddell added a comment. This revision is now accepted and ready to land. doesn't break the build on Neon REPOSITORY R107 KWallet PAM Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D6000 To: adridg, jriddell, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6000: Handle differences in PAM headers
This revision was automatically updated to reflect the committed changes. Closed by commit R107:38ff660bb81c: Handle differences in PAM headers (authored by adridg). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6000?vs=14912&id=15009 REVISION DETAIL https://phabricator.kde.org/D6000 AFFECTED FILES CMakeLists.txt pam_kwallet.c To: adridg, jriddell, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Plasma Vault 5.9.96
I've made a second testing release of Plasma Vault https://download.kde.org/unstable/plasma-vault/plasma-vault-5.9.96.tar.xz autographed by me Key fingerprint = 2D1D 5B05 8835 7787 DE9E E225 EC94 D18F 7F05 997E It includes a fix to show an error if the encryption process stopped Jonathan
D6046: Workaround non-interactive file/places view on high dpi in multi monitor scenario
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added subscribers: Konqueror, plasma-devel. REVISION SUMMARY See linked bug report and comment in the code for more explanation. CHANGELOG: Fixed issue where file area would become inaccessible in high-dpi multi-screen setup BUG: 363548 FIXED-IN: 17.04.2 TEST PLAN I know this is horrible and Qt must be fixed but this is such a major and weird bug and I'm lucky to at least found some way of working around it, I also couldn't figure out a simpler testcase for reporting a Qt bug. From what I can tell KMail's QtWebEngine view is also affected by this breaking in a similar fashion. Ran `QT_SCREEN_SCALE_FACTORS="2;2" dolphin`, moved Dolphin to my second screen, opened a file, was still able to browse other folders and use the Places panel with this patch. Otherwise it would stop working and only work on the primary monitor. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D6046 AFFECTED FILES src/dolphinviewcontainer.cpp To: broulik, #plasma, #dolphin, kvermette, dfaure, graesslin, emmanuelp Cc: plasma-devel, #konqueror, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6047: WIP: Support XDG v6
davidedmundson created this revision. davidedmundson added projects: Plasma on Wayland, Frameworks. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REVISION SUMMARY To move forward faster I thought we could start reviewing the davidedmundson/xdgv6 branch for the top level whilst I continue the Popup stuff in a new branch. Commits are made by both me and Marco. He did pings + min/max sizes I did most most the rest. The main clever part that's not just boring boiler plate is how we handle the structure change A surface now has an XDGSurface which then has a an Xdg TopLevel or a Xdg Popup We need to fit this into the public API which assumes a surface has a Surface or a Popup. The old Surface is similar to the new TopLevel. The shoehorning works by relying on the fact that a surface without a role is pretty useless. Clients create the surface implicitly with the toplevel or implicitly with the popup. The server only announced it has a new "XdgSurface" when it gets a new zxdg_surface_get_toplevel. Don't write comments about popup code not being implemented... TEST PLAN Current test still passes. REPOSITORY R127 KWayland BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/test_xdg_shell_v6.cpp To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6047: WIP: Support XDG v6
davidedmundson abandoned this revision. davidedmundson added a comment. Flipping phabricator... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"
elvisangelaccio added a comment. Ping? I'm going to push before the 17.04.2 tag, unless there are objections. (for the record, https://codereview.qt-project.org/#/c/195712/ will make this feature configurable). REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D5883 To: elvisangelaccio, #vdg, #plasma, emmanuelp Cc: plasma-devel, #konqueror, #dolphin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R318 Dolphin BRANCH Applications/17.04 REVISION DETAIL https://phabricator.kde.org/D5883 To: elvisangelaccio, #vdg, #plasma, emmanuelp, davidedmundson Cc: plasma-devel, #konqueror, #dolphin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6048: [xembedsniproxy] Fix check whether to use XTest
wbauer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Because of C++'s operator precedence, '!' logically negated all_event_masks only instead of the whole expression. This resulted in the condition always being false and XTest never being used. Adding a pair of brackets fixes it. BUG: 362941 BUG: 375017 TEST PLAN Verifed with debug output that XTest is being used when XCB_EVENT_MASK_BUTTON_PRESS is not set in all_event_masks. Tested with a couple of applications: - mplayerc.exe: wine app, worked before, no XTest, still works - tvbrowser, jedit, jitsi 2.8: java apps, didn't work before, use XTest now and work - ksensors, ksteak, kconnections, klinpopup, ktvschedule: KDE3 apps, worked before, no XTest, still work - wammu: python/wxWidgets app, worked before, no XTest, still works - grip, avidemux2, hexchat: gtk2 apps, worked before, no XTest, still work - audacious, stardict: gtk3 apps, didn't work before (unless GDK_CORE_DEVICE_EVENTS=1 was set), work now using XTest (without GDK_CORE_DEVICE_EVENTS=1) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6048 AFFECTED FILES xembed-sni-proxy/sniproxy.cpp To: wbauer, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6048: [xembedsniproxy] Fix check whether to use XTest
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Oh you hero! I can't believe I wrote the code, tested it, then failed when putting it together. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6048 To: wbauer, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol updated this revision to Diff 15015. apol marked an inline comment as done. apol added a comment. Address Marco's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6041?vs=15003&id=15015 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 AFFECTED FILES autotests/CMakeLists.txt autotests/packageurlinterceptortest.cpp autotests/packageurlinterceptortest.h src/plasma/package.cpp src/plasma/package.h src/plasma/pluginloader.cpp src/plasma/pluginloader.h src/plasmaquick/appletquickitem.cpp src/plasmaquick/appletquickitem.h src/plasmaquick/configview.cpp src/plasmaquick/containmentview.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/private/appletquickitem_p.h src/plasmaquick/view.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.h To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > mart wrote in appletquickitem.h:105 > despite the warning in the header, this ended up being an exported symbol, so > binary compatibility rules apply here too. > Plasma::Package appletPackage() const; has to stay, eventually deprecated and > a new KPackage::Package appletPackage() const; added. Okay, will fix in a next patch. Please note nobody is using these methods and we could possibly scrap altogether the storing of appletPackage and coronaPackage. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
davidedmundson added a comment. Can we wait till after the next release is tagged as that's super soon and this isn't that important. We've had major bugs porting stuff in this area before. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6048: [xembedsniproxy] Fix check whether to use XTest
wbauer added a comment. Is it ok to commit it to the 5.10 branch as well? Btw, I think the whole fix should probably be backported to 5.8 too... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6048 To: wbauer, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6048: [xembedsniproxy] Fix check whether to use XTest
davidedmundson added a comment. > Is it ok to commit it to the 5.10 branch as well? Yes > Btw, I think the whole fix should probably be backported to 5.8 too... It introduces a new dependency :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6048 To: wbauer, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6048: [xembedsniproxy] Fix check whether to use XTest
wbauer added a comment. In https://phabricator.kde.org/D6048#113217, @davidedmundson wrote: > > Btw, I think the whole fix should probably be backported to 5.8 too... > > It introduces a new dependency :/ Really? AFAICS it only additionaly links xembedsniproxy against XTst. But ok, I'm not completely sure about the policies in this regard. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6048 To: wbauer, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5976: Remove code to poll the udev events for brightness
lukas added a comment. Works fine for me in general, with 2 caveats: - the brightness change doesn't animate (but afaik that's expected) - when switching back to AC, the brightness isn't restored (stays at the previous "battery" level) REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D5976 To: bshah, #plasma, broulik Cc: lukas, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D6048: [xembedsniproxy] Fix check whether to use XTest
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7df184afa19f: [xembedsniproxy] Fix check whether to use XTest (authored by wbauer). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6048?vs=15014&id=15017 REVISION DETAIL https://phabricator.kde.org/D6048 AFFECTED FILES xembed-sni-proxy/sniproxy.cpp To: wbauer, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"
This revision was automatically updated to reflect the committed changes. Closed by commit R318:883b908b4b26: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set… (authored by elvisangelaccio). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5883?vs=14588&id=15018 REVISION DETAIL https://phabricator.kde.org/D5883 AFFECTED FILES src/kitemviews/private/kitemlistsmoothscroller.cpp To: elvisangelaccio, #vdg, #plasma, emmanuelp, davidedmundson Cc: plasma-devel, #konqueror, #dolphin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig
davidedmundson added a comment. but as you say, we should never be in here, that's the entire sentiment of the comment above here. // Since we haven't been able to figure out the reason why // this happens, we are adding this debug code to try to // figure out how this happened. As you can concretely reproduce it, can you look at fixing the actual issue? REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6011 To: clutz Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6047: WIP: Support XDG v6
davidedmundson updated this revision to Diff 15020. davidedmundson added a comment. Arc didn't work, I think it was too big. Manually uploading the patch did. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=15013&id=15020 REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol added a comment. Yes sure. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
Touchpad KCM
Hey, Anybody knows if it's possible not to show the touchpad KCM at all if it's not available? It's a bit odd to get it but see it all gray with an error saying "touchpad not found". FWIW this is an issue present in the KDE Slimbook. Aleix
D6054: Use explicit flag values or explicit constructor instead of nullptr
kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has been done with a trick based on pointer types. Which these days of nullptr existing and compilers pushing to use that sadly fired back and, instead of allowing convenient code with commonly understood literal "0" values, resulted in quite some code using "nullptr" to indicate a QFLags-based type value with no flags set, which can be puzzling for humans reading the code. To improve the code again, instead of "nullptr" are used: - enum item representing the 0=no-flag-set value, if existing - explicit default constructor REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 AFFECTED FILES autotests/kstartupinfo_unittest.cpp autotests/kwindowinfox11test.cpp autotests/kwindowsystemx11test.cpp autotests/netwininfotestwm.cpp src/kstartupinfo.cpp src/kwindowinfo.cpp src/kwindowinfo.h src/kwindowsystem.h src/platforms/xcb/kwindowinfo.cpp src/platforms/xcb/kwindowsystem.cpp src/platforms/xcb/netwm.cpp src/platforms/xcb/netwm.h To: kossebau, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6046: Workaround non-interactive file/places view on high dpi in multi monitor scenario
dfaure added a comment. Excellent finding, it helped me reduce further the most annoying Qt bug I'm experiencing right now (in kmail) --> https://bugreports.qt.io/browse/QTBUG-59017 REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D6046 To: broulik, #plasma, #dolphin, kvermette, dfaure, graesslin, emmanuelp Cc: plasma-devel, #konqueror, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
