D6095: [MPRIS Data Engine] Only register global shortcuts when loaded in plasmashell
Zren added a comment. Hmm, just of this after reading a comment on reddit. Latte-Dock uses another process, would this cause keyboard shortcuts to not work for it? I'm not sure if it has a different app name. https://github.com/psifidotos/Latte-Dock/blob/02f247d53fbf8fa2744704fb66c08dff1ced369b/app/main.cpp#L67 https://github.com/KDE/plasma-workspace/blob/fb30ea87e68407515f9be246426dc27ac2630934/shell/main.cpp#L55 I'm not certain what sets `qApp->applicationName()`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6095 To: broulik, #plasma Cc: Zren, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D1231: Add Remote Access interface to KWayland
Kanedias added a dependent revision: D6096: Add Wayland RemoteAccess capabilities to KRfb. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6096: Add Wayland RemoteAccess capabilities to KRfb
Kanedias added a dependency: D1231: Add Remote Access interface to KWayland. REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6096: Add Wayland RemoteAccess capabilities to KRfb
Kanedias created this revision. Kanedias added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Patch for KRfb to work with RemoteAccess Wayland protocol. This does not yet work (I didn't test this), just rebased against latest KRfb source. Works: - Screen - Mouse movement TEST PLAN Launch KWin on DRM screen with KWIN_REMOTE=1 and with preferredFrameBufferPlugin=gbm in krfbrc Try to connect with KRDC. REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 AFFECTED FILES CMakeLists.txt cmake/modules/FindLibdrm.cmake cmake/modules/Findepoxy.cmake cmake/modules/Findgbm.cmake events/CMakeLists.txt events/fakeinput/CMakeLists.txt events/fakeinput/fakeinputevents.cpp events/fakeinput/fakeinputevents.h events/fakeinput/fakeinputeventsplugin.cpp events/fakeinput/fakeinputeventsplugin.h events/fakeinput/krfb_events_fakeinput.desktop events/fakeinput/krfb_events_fakeinput.json events/x11/CMakeLists.txt events/x11/krfb_events_x11.desktop events/x11/krfb_events_x11.json events/x11/x11events.cpp events/x11/x11events.h events/x11/x11eventsplugin.cpp events/x11/x11eventsplugin.h framebuffers/CMakeLists.txt framebuffers/gbm/CMakeLists.txt framebuffers/gbm/gbmframebuffer.cpp framebuffers/gbm/gbmframebuffer.h framebuffers/gbm/gbmframebufferplugin.cpp framebuffers/gbm/gbmframebufferplugin.h framebuffers/gbm/krfb_framebuffer_gbm.json framebuffers/gbm/logging.cpp framebuffers/gbm/logging.h framebuffers/qt/qtframebufferplugin.cpp framebuffers/x11/x11framebufferplugin.cpp krfb/CMakeLists.txt krfb/events.cpp krfb/events.h krfb/eventsmanager.cpp krfb/eventsmanager.h krfb/eventsplugin.cpp krfb/eventsplugin.h krfb/framebuffermanager.cpp krfb/krfb-events.desktop krfb/krfb-events.json krfb/main.cpp krfb/rfbclient.cpp To: Kanedias, davidedmundson, graesslin Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D1230: GBM remote access support for KWin
Kanedias updated this revision to Diff 15146. Kanedias edited projects, added Plasma on Wayland; removed Plasma. Kanedias added a comment. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin. Rebased against latest KWin, corrected implementation REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=2969=15146 REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED FILES input.cpp main_wayland.cpp plugins/platforms/drm/CMakeLists.txt plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_backend.h plugins/platforms/drm/drm_buffer.h plugins/platforms/drm/drm_buffer_gbm.h plugins/platforms/drm/egl_gbm_backend.cpp plugins/platforms/drm/egl_gbm_backend.h plugins/platforms/drm/remoteaccess_manager.cpp plugins/platforms/drm/remoteaccess_manager.h To: Kanedias, graesslin, davidedmundson Cc: kwin, #kwin, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6095: [MPRIS Data Engine] Only register global shortcuts when loaded in plasmashell
davidedmundson added a comment. Heh, literally got a collision on bugzilla as I was looking into it at just the same time. I reached the same conclusion on what the bug is. +1 That solution, and I don't think I need to tell you, is a hack. We can do it for 5.10 so we have something in the .1 release, but I'm not happy with it as a final solution. IMHO we should move the shortcut handling from the dataengine to something else which our MPRIS applet can load. Dataengines should be read only data fetchers; not handling events; it goes against their own design. If no-one does a better fix by the end of tomorrow (I have an idea in mind) go ahead and push this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6095 To: broulik, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6095: [MPRIS Data Engine] Only register global shortcuts when loaded in plasmashell
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Keeps the lock screen from stealing the shortcuts. CHANGELOG: Fixed media keys not working after locking and unlocking the screen BUG: 380526 FIXED-IN: 5.10.1 TEST PLAN Don't have media keys on my laptop so I assigned Meta+P to pause, pressed it, locked screen, still works both on the lock screen and after unlocking. Also keeps plasmoidviewer from stealing them when working on media controller applet REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6095 AFFECTED FILES dataengines/mpris2/multiplexer.cpp To: broulik, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6091: Fixup protocol mismatch between greeter and kcheckpass
This revision was automatically updated to reflect the committed changes. Closed by commit R133:23fa33cedfa5: Fixup protocol mismatch between greeter and kcheckpass (authored by fvogt). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6091?vs=15137=15143 REVISION DETAIL https://phabricator.kde.org/D6091 AFFECTED FILES greeter/authenticator.cpp To: fvogt, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6091: Fixup protocol mismatch between greeter and kcheckpass
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good analysis. If we had a badge for hero of the week, it would go to you. Btw there's a qbytearray.isNull() you can use. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D6091 To: fvogt, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6091: Fixup protocol mismatch between greeter and kcheckpass
fvogt added a comment. The target branch should obviously be Plasma/5.10, but as I'm not sure how to adjust that with arc I can just commit it there instead. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D6091 To: fvogt, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6091: Fixup protocol mismatch between greeter and kcheckpass
fvogt created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
The receiver (kcheckpass) reads a string and if it is !nullptr, reads an int:
msg = GRecvStr ();
if (msg && (GRecvInt() & IsPassword) && !*msg)
The sender (kscreenlocker_greet) sends a string and if it is not empty,
sends an int:
GSendStr(m_password.toUtf8().constData());
if (!m_password.isEmpty()) {
// IsSecret
GSendInt(1);
}
This does not work out for empty strings, as those still have a length of 1,
resulting in kcheckpass waiting indefinitely for an int that does not get
sent.
Testing for a nullptr on the sender side instead of the string length fixes
this.
Also clean up the code duplication and IsSecret (1)/IsPassword (2) mismatch.
BUG: 380491
TEST PLAN
Reproduced the bug without this patch, with this patch it does not
happen anymore. Authentication still works and fails as expected.
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6091
AFFECTED FILES
greeter/authenticator.cpp
To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
D5957: Don't ignore initially selected mime type filter
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH initiallySelectedMime (branched from Plasma/5.10) REVISION DETAIL https://phabricator.kde.org/D5957 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6088: [Folder View] Use a copy of QMimeData in signal handler
This revision was automatically updated to reflect the committed changes. Closed by commit R119:77f1e675178a: [Folder View] Use a copy of QMimeData in signal handler (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6088?vs=15132=15133 REVISION DETAIL https://phabricator.kde.org/D6088 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: broulik, #plasma, hein, fvogt Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6088: [Folder View] Use a copy of QMimeData in signal handler
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6088 To: broulik, #plasma, hein, fvogt Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6088: [Folder View] Use a copy of QMimeData in signal handler
broulik edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6088 To: broulik, #plasma, hein, fvogt Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6088: [Folder View] Use a copy of QMimeData in signal handler
broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6088 To: broulik, #plasma, hein, fvogt Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6088: [Folder View] Use a copy of QMimeData in signal handler
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY By the time we leave the method, the QMimeData is deleted by the DragArea's drop event being destroyed leading to a crash. BUG: 380806 FIXED-IN: 5.10.1 TEST PLAN There's no copy operator. Stackoverflow mentions some weirdness on Windows [1] but that shouldn't affect us. - Can still re-arrange files - Dropping an external file prompts to copy/link/move/create matching applet and all of those options work now without a crash [1] https://stackoverflow.com/questions/13762140/proper-way-to-copy-a-qmimedata-object REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6088 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: broulik, #plasma, hein, fvogt Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5957: Don't ignore initially selected mime type filter
elvisangelaccio added a comment. Ping? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5957 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5114: support for high dpi in aurorae
rikmills added a comment. In https://phabricator.kde.org/D5114#113943, @luebking wrote: > Just saw this because of a bug report. This one I presume: https://bugs.kde.org/show_bug.cgi?id=380524 The bug affects me on 5.10 (I am comment #1) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5114 To: mart, #plasma, graesslin Cc: rikmills, luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D5114: support for high dpi in aurorae
luebking added a comment.
Just saw this because of a bug report.
Why was this patch approved at all?
This line:
scaleFactor = (qreal)dpi / (qreal)96;
is totally nuts. dpi is already qreal, so 96 is implicitly casted and 96.0f
or so would have done.
Overmore and far worse, the result is implicitly casted to int scaleFactor,
ie. truncated - in doubt to 0.
---
--> scaleFactor should be float/qreal, if you want and then the various
paddings etc. should be like
m_borderLeft = qRound(scaleFactor * border.readEntry("BorderLeft",
defaultBorderLeft()));
In addition there should be a sanity check on the dpi return and bonus points
if the dpi is calculated as mean of dpiX and dpiY.
And best invoke Kai Uwe Broulik.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5114
To: mart, #plasma, graesslin
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart,
lukas
