D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added a comment.


  Wait, cursor uses DrmDumbBuffer, which has no GBM BO in it!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson
Cc: kwin, #kwin, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added a comment.


  In https://phabricator.kde.org/D1230#114175, @davidedmundson wrote:
  
  > There is one issue we need to work out how to fix - with this system if 
you're running VNC you won't see the client's mouse.
  
  
  Nice catch, I didn't notice that until you pointed that out!
  
  > - We make kwin render the background + cursor into a new texture
  
  Sounds pretty heavy, we'd need to copy frame on each page flip...
  
  > - We provide the mouse buffer to the RemoteAccess buffer just like we pass 
the outputs. We would need to pass some sort of offset in 
org_kde_kwin_remote_buffer
  
  Offset - you mean, mouse offset, so acceptor knows where to render it?
  
  > - dynamically switch usesSoftwareCursor() in the backend when recording.
  
  Can it break something? As I see DrmBackend never used softwareCursor 
before...
  
  Okay, which option is more preferable here? I tend to think it's №2.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson
Cc: kwin, #kwin, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

Re: Plasma Browser Integration is in kdereview

[Aleix Pol]

On Wed, Jun 7, 2017 at 12:23 AM, David Edmundson
 wrote:
> Install the host part with the normal cmake && make.
> The bit that tries to install into /etc/ does need to go into /etc
>
> Easiest thing then is to then install the extension part from one of the
> links in my original email.

Yes, you are right, it's pretty easy.
That said, a wiki or a README.md would be nice too.

I'm having a crash on Chrome [1], on Chromium it's working perfectly
fine though. Impressive!

Aleix

[1] https://bugs.kde.org/show_bug.cgi?id=380186

Re: Plasma Browser Integration is in kdereview

[David Edmundson]

​Install the host part with the normal cmake && make.
The bit that tries to install into /etc/ does need to go into /etc

Easiest thing then is to then install the extension part from one of the
links in my original email.

D6126: Support fractional scaling in generating the sidebar preview

[Aleix Pol Gonzalez]

apol added a comment.


  +1 would it make sense to add a clazy check that identifies uses of this 
method? Or deprecating the method altogether?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6126

To: davidedmundson, #plasma
Cc: apol, plasma-devel, kwrite-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart, lukas

D6126: Support fractional scaling in generating the sidebar preview

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, kwrite-devel, 
plasma-devel.

REVISION SUMMARY
  QPaintDevice::devicePixelRatio was replaced by devicePixelRatioF when Qt
  supported fractional scaling as the type changed but needed to keep API. 
  Every other call to devicePixelRatio was already a qreal.
  
  The sidebar was already scaled up to the fractional size, but the pixmap
  was generated at the integer version. End result is that it wasn't quite as
  crisp as it could be.

TEST PLAN
  QT_SCALE_FACTOR=1.4 kate
  Opened bug fix and used minimap as before
  My extra assert in QPaintDevice::devicePixelRatio was never fired

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6126

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, kwrite-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366795

--- Comment #32 from vlao...@gmail.com ---
For me (MTP protocol with Nexus 5), action "paste" is disabled only when folder
have no files. I have installed kio-extras 17.0.4 and kio 5.34.0-r2

-- 
You are receiving this mail because:
You are the assignee for the bug.

Plasma 5.10.1

[Jonathan Riddell]

Plasma 5.10.1 is out now with a week's worth of bugfixes

https://www.kde.org/announcements/plasma-5.10.1.php

D6061: prototype of kactivity-based most used modules entries

[Marco Martin]

mart marked 2 inline comments as done.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D6061

To: mart, #plasma, #vdg
Cc: davidedmundson, abetts, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, lukas

5.11 Kickoff Minutes

[Jonathan Riddell]

during a mammoth 2.5 hour meeting we agreed the following minutes

Minutes:
- stick to current schedule for Plasma 5.11, release Sep 21 2017
- Plasma 5.8LTS to get 5.8.8LTS in April and 5.8.9LTS in October
then become very strict update (security fixes only, no translations,
releases as necessary)
- Plasma 5.12 to be LTS on simliar fibbonachi schedule as 5.8LTS,
expected to require Qt 5.9, supported for at least 2 years
- schedule 4 month releases for 2018 to sync with frameworks
- no more new workspace features that would need Wayland porting
unless Wayland version is done first
- bshah to create a meta 5.11 task and add features as dep to that one
- bshah to poke people into filling out itemised to do cards
- riddell to be kicked until adding openqa to neon
- beta time to become three weeks
- promote 
https://community.kde.org/Plasma/Live_Images#Ships_Plasma_5.10_beta
harder at beta time and nudge developers and contributors into running
beta code

D6118: refine layouts for items to be more aligned

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:c3334d0f1401: refine layouts for items to be more aligned 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6118?vs=15216&id=15223#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6118?vs=15216&id=15223

REVISION DETAIL
  https://phabricator.kde.org/D6118

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: mart, #plasma, #vdg, abetts, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6118: refine layouts for items to be more aligned

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Please note that I posted some comments in the previous patch after you 
merged it that I don't want to get missed.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6118

To: mart, #plasma, #vdg, abetts, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Plasma Browser Integration is in kdereview

[Aleix Pol]

On Mon, Jun 5, 2017 at 4:42 PM, David Edmundson
 wrote:
> Hey all,
>
> We'd like to add project plasma-browser-integration into KDE[0].
>
> The goal is to make chrome and firefox integrate better into a Plasma
> desktop environment through browser extensions.
>
> How?:
> Firefox and chrome (and potentially others) allow plugins to talk to a
> native binary host [1]. This binary host is launched by the the browser and
> has a socket to a conventional browser extension. This project consists of
> both parts allowing a chrome extension to make normal DBus calls to services
> just like other apps.
>
> Integrating what?:
> This gives us the following features:
>  - Finding open tabs via krunner
>  - Download progress in the task bar
>  - Showing now playing information with shortcuts (if the website supports
> it)
>  - "Send to KDE Connect" context menu on links
>  - Loading windows on the correct activity (WIP)
>  - An SNI if incognito windows are open with action to close them.
>
> And potentially more in the future. There is a config to enable/disable
> parts as appropriate.
>
> Deployment:
>  This repo consists of two parts. The binary host which should be
> distributed by normal distro means, and the browser extension which is going
> to be different.
>
> The browser extension can be deployed in one of 3 ways.
>  - manually by the user from the code (useful for devs)
>
>  - through the webstore [2][3]
>  - chrome also has a feature where we can ship a text file on the distro
> side that will make the browser automatically fetch an extension from their
> store.
>
> Ideally we want the extension available on the store from an official KDE
> channel.
>
>  - potentially it could also be done by the distro, but it seems like FF
> might be removing that possibility and the digital signing is an issue.
>
> [0] https://cgit.kde.org/plasma-browser-integration.git/
> [1] https://developer.chrome.com/extensions/nativeMessaging
> [2]
> https://chrome.google.com/webstore/detail/plasma-integration/cimiefiiaegbelhefglklhhakcgmhkai
> [3]
> https://addons.mozilla.org/en-US/android/addon/plasma-integration/?src=cb-dl-updated
>
> Regards
>
> David and Kai

General +1 to the features. Really awesome. :)

Do we have any documentation on how to test it?

Aleix

D6111: UI updates for NetworkManager-l2tp 1.2.6

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good to me. I tested it a bit, all properties were saved and loaded 
properly.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D6111

To: dkosovic, jgrulich
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6041: Port a bunch of classes away from Plasma::Package

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:563011436d5f: Port a bunch of classes away from 
Plasma::Package (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6041?vs=15015&id=15220

REVISION DETAIL
  https://phabricator.kde.org/D6041

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/packageurlinterceptortest.cpp
  autotests/packageurlinterceptortest.h
  src/plasma/package.cpp
  src/plasma/package.h
  src/plasma/pluginloader.cpp
  src/plasma/pluginloader.h
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/appletquickitem.h
  src/plasmaquick/configview.cpp
  src/plasmaquick/containmentview.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/private/appletquickitem_p.h
  src/plasmaquick/view.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: apol, #frameworks, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5961: PoC: Generic adoption of KUserFeedback for Discover

[Aleix Pol Gonzalez]

apol updated this revision to Diff 15217.
apol added a comment.


  Adapt to changes in kuserfeedback, make sure more sources are sent

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5961?vs=14805&id=15217

BRANCH
  kuserfeedback

REVISION DETAIL
  https://phabricator.kde.org/D5961

AFFECTED FILES
  CMakeLists.txt
  discover/qml/DiscoverWindow.qml
  discover/qml/SourcesPage.qml

To: apol, #plasma, vkrause
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6113: Update helper docs for --windowed mode of plasmashell

[Marco Martin]

mart added a comment.


  shouldn't be at this point just removed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6113

To: davidedmundson, #plasma
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6118: refine layouts for items to be more aligned

[Marco Martin]

mart added a reviewer: abetts.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D6118

To: mart, #plasma, #vdg, abetts
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6118: refine layouts for items to be more aligned

[Marco Martin]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  as per cdg feedback, remove separator lines in the list,
  tweak sizes of items in the toolbar so that the hamburger icon is centered 
with item icons and the pixel spaces are all the same

TEST PLAN
  tested with different QT_SCALE_FACTOR values

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6118

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: mart, #plasma, #vdg
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6118: refine layouts for items to be more aligned

[Marco Martin]

mart added a comment.


  F3777252: Untitled.png 

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D6118

To: mart, #plasma, #vdg
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6109: [Notifications] Hide job info label for successive jobs

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:149212e79bc4: [Notifications] Hide job info label for 
successive jobs (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6109?vs=15196&id=15213

REVISION DETAIL
  https://phabricator.kde.org/D6109

AFFECTED FILES
  applets/notifications/package/contents/ui/JobDelegate.qml
  applets/notifications/package/contents/ui/Jobs.qml

To: broulik, #plasma, #vdg, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6112: update kcm statistics in kcmshell too

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
mart marked an inline comment as done.
Closed by commit R126:e003e86628be: update kcm statistics in kcmshell too 
(authored by mart).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6112?vs=15207&id=15212

REVISION DETAIL
  https://phabricator.kde.org/D6112

AFFECTED FILES
  CMakeLists.txt
  kcmshell/CMakeLists.txt
  kcmshell/main.cpp

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6112: update kcm statistics in kcmshell too

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6112

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6112: update kcm statistics in kcmshell too

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.cpp:298
> ?

eww, sorry :)

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D6112

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6112: update kcm statistics in kcmshell too

[Marco Martin]

mart updated this revision to Diff 15207.
mart added a comment.


  remove dead code

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6112?vs=15205&id=15207

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6112

AFFECTED FILES
  CMakeLists.txt
  kcmshell/CMakeLists.txt
  kcmshell/main.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6113: Update helper docs for --windowed mode of plasmashell

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  winOption is never read, and even if it did wouldn't really work with
  the way screenspool works.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6113

AFFECTED FILES
  shell/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6112: update kcm statistics in kcmshell too

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.cpp:298
>  
> +/*connect(dlg, &KCMShellMultiDialog::currentPageChanged,
> +this, [this](KPageWidgetItem *old,KPageWidgetItem *new) {

?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D6112

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6112: update kcm statistics in kcmshell too

[Marco Martin]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  also when opening modules with kcmshell (used a lot with krunner)
  the statistics need to be updated to keep the list on systemsettings startup
  up to date and have complete usage data of kcm modules

TEST PLAN
  opened systemsettings and a module with kcmsell, the list gets updated
  on the fly

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6112

AFFECTED FILES
  CMakeLists.txt
  kcmshell/CMakeLists.txt
  kcmshell/main.cpp

To: mart, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6111: UI updates for NetworkManager-l2tp 1.2.6

[Douglas Kosovic]

dkosovic created this revision.
dkosovic added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Could the plasma-nm/vpn/l2tp/ source be updated to support IPsec changes 
introduced with NetworkManager-l2tp version 1.2.6.
  
  A screen shot of the current GNOME IPsec UI can be viewed here:
  
https://github.com/nm-l2tp/network-manager-l2tp/wiki/Screenshots#ipsec-options 

  
  A summary of the changes for NetworkManager-l2tp 1.2.6 include:
  
  Added the following to IPsec UI:
  
  - Phase 1 algorithms
  - Phase 2 algorithms
  - Enforce UDP encapsulation
  
  Removed the following from IPsec UI:
  
  - Group Name
  
  Copied nm-l2tp-service.h from NetworkManager-l2tp 1.2.6
  
  Phase 1 & 2 algorithms UI additions are compatible with NetworkManager-l2tp 
versions 1.2.6 and 1.0.6 (from the 1.0.x series which has the changes 
backported from 1.2.6)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D6111

AFFECTED FILES
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/nm-l2tp-service.h

To: dkosovic, jgrulich
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6061: prototype of kactivity-based most used modules entries

[David Edmundson]

davidedmundson added a comment.


  Make sure you test with --reverse too

INLINE COMMENTS

> mart wrote in SidebarMode.cpp:163
> I need to remove the kcm: part

Right, but I meant don't call sourceModel()->data(mapToSource) when you can 
just call the superclasses data method.

> IntroIcon.qml:32
> +Layout.fillWidth: true
> +
> +onClicked: systemsettings.loadMostUsed(index);

You're making a custom button, it needs

http://doc.qt.io/qt-5/qml-qtquick-accessible.html

stuff

> introPage.qml:55
> +}
> +width: parent.width * 0.8
> +Kirigami.Heading {

Math.round()

> introPage.qml:67
> +Repeater {
> +model: systemsettings.mostUsedModel
> +delegate: IntroIcon {

keyboard nav?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D6061

To: mart, #plasma, #vdg
Cc: davidedmundson, abetts, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, lukas

D6110: fix typo

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:88da02bb1db8: fix typo (authored by sitter).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6110?vs=15201&id=15202

REVISION DETAIL
  https://phabricator.kde.org/D6110

AFFECTED FILES
  CMakeLists.txt

To: sitter, apol, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6109: [Notifications] Hide job info label for successive jobs

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6109

To: broulik, #plasma, #vdg, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6110: fix typo

[Harald Sitter]

sitter updated this revision to Diff 15201.
sitter added a comment.


  fix typo that snuck into typo fix :D

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6110?vs=15200&id=15201

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6110

AFFECTED FILES
  CMakeLists.txt

To: sitter, apol, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6110: fix typo

[Harald Sitter]

sitter marked an inline comment as done.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6110

To: sitter, apol, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6110: fix typo

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6110

To: sitter, apol, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6110: fix typo

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1
> -project(discover)
> +roject(discover)
>  set(PROJECT_VERSION "5.10.0")

?
nope

> CMakeLists.txt:50
>  set_package_properties(KF5Kirigami2 PROPERTIES
> -DESCRIPTION "KDE’s lightweight user interface framework for mobile and 
> convergent applications"
> +DESCRIPTION "KDE's lightweight user interface framework for mobile and 
> convergent applications"
>  URL "https://techbase.kde.org/Kirigami";

okay... xD I must have copied it from somewhere, check other Kirigami apps.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D6110

To: sitter, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6110: fix typo

[Harald Sitter]

sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ’ (U+2019 aka RIGHT SINGLE QUOTATION MARK)
  is not
  ' (U+0027 aka APOSTROPHE)
  
  it's U+0027 in "it's" :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6110

AFFECTED FILES
  CMakeLists.txt

To: sitter, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6061: prototype of kactivity-based most used modules entries

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:1018b86e48db: prototype of kactivity-based most used 
modules entries (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6061?vs=15071&id=15199#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6061?vs=15071&id=15199

REVISION DETAIL
  https://phabricator.kde.org/D6061

AFFECTED FILES
  CMakeLists.txt
  core/CMakeLists.txt
  core/ModuleView.cpp
  sidebar/CMakeLists.txt
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/introPage.qml

To: mart, #plasma, #vdg
Cc: davidedmundson, abetts, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, lukas

D6109: [Notifications] Hide job info label for successive jobs

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When multiple jobs of the same kind are listed, visually group them.
  While this doesn't actively group them (i.e. having a copy, a move, and a 
copy again won't move the second copy job to the first - there's no real model 
underneath, so we cannot just drop a sort proxy model ontop), it still improves 
the most likely situation of copying multiple different things at once.

TEST PLAN
  As per VDG request
  
  Started two copy progresses, only got one heading. Verified that when I quit 
the first job, the title of the second would show up (binding magic)
  
  F3777044: Screenshot_20170606_101557.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6109

AFFECTED FILES
  applets/notifications/package/contents/ui/JobDelegate.qml
  applets/notifications/package/contents/ui/Jobs.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6106: [Notifications Data Engine] Expose desktop entry and application service name icon

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:83ed4da7e383: [Notifications Data Engine] Expose desktop 
entry and application service name… (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6106?vs=15191&id=15195

REVISION DETAIL
  https://phabricator.kde.org/D6106

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6105: [Notification Job Delegate] Slightly optimize summary label

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3d85454fef8d: [Notification Job Delegate] Slightly 
optimize summary label (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6105?vs=15189&id=15194

REVISION DETAIL
  https://phabricator.kde.org/D6105

AFFECTED FILES
  applets/notifications/package/contents/ui/JobDelegate.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6105: [Notification Job Delegate] Slightly optimize summary label

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6105

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Distro integration for Plasma Browser Integration (was: Re: Plasma Browser Integration is in kdereview

[Neal Gompa]

On Mon, Jun 5, 2017 at 11:22 AM, Martin Steigerwald  wrote:
> Hello David.
>
> Thanks for your effort on plasma browser integration.
>
>
> What options are possible to distribute extensions via distro packaging?
>
> I ask cause I think at least for chrome / chromium you need a Google account
> to use the plugin / extension store. Also it would put the extension outside
> of distro security support. Therefore I mostly use xul-ext packages in Debian
> as extensions for Firefox and also a new uBlock origin extension package for
> chromium.
>
> Eventually this would need to be brought up with browser developers. I am
> willing to help there by creating wishlist item / bug report.
>

In Fedora, we have actually packaged an extension for Chrome[1], so it
is possible to package Chrome extensions and have them work with
Chromium / Chrome.

If they are locally installed, Chrome will activate them, and if they
require special permissions, the user will be prompted to grant them.

[1]: 
https://src.fedoraproject.org/cgit/rpms/fedora-user-agent-chrome.git/tree/fedora-user-agent-chrome.spec


-- 
真実はいつも一つ！/ Always, there's only one truth!

D6106: [Notifications Data Engine] Expose desktop entry and application service name icon

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6106

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Distro integration for Plasma Browser Integration (was: Re: Plasma Browser Integration is in kdereview

[Sandro Knauß]

Hey,

> > What options are possible to distribute extensions via distro packaging?

You can package for both browses extensions, that works quite nicely:
Here is one I made for Debian and Firefox:
https://tracker.debian.org/pkg/firefox-kwallet5

For Chrome the debian Wiki tells, that extensions are disabled by default:
https://wiki.debian.org/Chromium#Extensions

Best regards,

sandro


signature.asc
Description: This is a digitally signed message part.