D6145: Massively simplify the class DesktopPortal

[Jan Grulich]

jgrulich added a comment.


  I think I found out why. In documentation [1] all methods starts with capital 
letter, which in our case they don't. This was obviously working before when I 
was doing everything manually. Still my question remains about registering 
additional objects in Inbit.cpp.
  
  [1] - http://flatpak.org/xdg-desktop-portal/portal-docs.html

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6145

To: davidedmundson, #plasma, jgrulich
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D6145: Massively simplify the class DesktopPortal

[Jan Grulich]

jgrulich added a comment.


  I tested it with my test application and it doesn't work. I keep getting 
following warnings from xdg-desktop-portal:
  
  - (/usr/libexec/xdg-desktop-portal:18253): WARNING **: Backend call failed: 
GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such method 'OpenFile' 
in interface 'org.freedesktop.impl.portal.FileChooser' at object path 
'/org/freedesktop/portal/desktop' (signature 'osssa{sv}')
  
  Terminated
  
  I checked it and all services seems to be registered properly, but don't know 
why it doesn't work. Reverting this change makes it immediately working. Also 
please look into Inhibit.cpp where I also register dbus objects, will this 
still work?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6145

To: davidedmundson, #plasma, jgrulich
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D6145: Massively simplify the class DesktopPortal

[Aleix Pol Gonzalez]

apol added a reviewer: jgrulich.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6145

To: davidedmundson, #plasma, jgrulich
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6145: Massively simplify the class DesktopPortal

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> access.h:32
>  public:
> -Access(QObject *parent = nullptr);
> +Access(QObject *parent);
>  ~Access();

explicit (and others)

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6145

To: davidedmundson, #plasma, jgrulich
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D6145: Massively simplify the class DesktopPortal

[David Edmundson]

davidedmundson edited the summary of this revision.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6145

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6145: Massively simplify the class DesktopPortal

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Only one QObject can occupt a DBus path...but that object can have
  multiple adaptors, which is how you've structured it anyway.
  
  It's considerably easier than doing everything manually through a
  QDBusVirtualObject

TEST PLAN
  Checked all ifaces registered in qdbusviewer
  Manually ran AddNotification, debug appeared in xdg-desktop-portal and a 
notification appeared
  
  I haven't actually tested inside flatpak.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6145

AFFECTED FILES
  src/access.cpp
  src/access.h
  src/appchooser.cpp
  src/appchooser.h
  src/desktopportal.cpp
  src/desktopportal.h
  src/email.cpp
  src/email.h
  src/filechooser.cpp
  src/filechooser.h
  src/inhibit.cpp
  src/inhibit.h
  src/notification.cpp
  src/notification.h
  src/print.cpp
  src/print.h
  src/xdg-desktop-portal-kde.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6143: Even on plasma we shouldn't be using plasma icons

[David Edmundson]

davidedmundson added a comment.


  I mean, if we're an application, we should be only using things loaded from 
src/styles/org.kde.desktop   
  and not files in src/styles/Plasma

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6143

To: apol, #kirigami, mart
Cc: davidedmundson, plasma-devel, apol, mart

D6143: Even on plasma we shouldn't be using plasma icons

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D6143#114962, @davidedmundson wrote:
  
  > Why would it be using the Plasma theme then?
  
  
  Kirigami shouldn't AFAIU, that's why I'm setting it to `false`.
  Am I lost in translation?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6143

To: apol, #kirigami, mart
Cc: davidedmundson, plasma-devel, apol, mart

D6143: Even on plasma we shouldn't be using plasma icons

[David Edmundson]

davidedmundson added a comment.


  Why would it be using the Plasma theme then?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6143

To: apol, #kirigami, mart
Cc: davidedmundson, plasma-devel, apol, mart

D6143: Even on plasma we shouldn't be using plasma icons

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We want to use the icons for applications rather than for the shell. It should
  work well with the applications color theme rather than the shell's.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6143

AFFECTED FILES
  src/styles/Plasma/Icon.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

Re: Transient parent for QtWidgets popup menus

[Elvis Angelaccio]

On mercoledì 7 giugno 2017 19:56:59 CEST, Elvis Angelaccio wrote:

On domenica 28 maggio 2017 10:37:40 CEST, Marco Martin wrote:

On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote: ...


Any idea about drop menus? (i.e. QMenus usually created in some 
dropEvent() function). Even if they have a parent, they are 
positioned in the place the drag started, rather than the place 
where the drop happened. It seems that QCursor::pos() (passed to 
QMenu::exec()) is broken if called inside dropEvent(), almost 
like if the app does not realize that the mouse cursor moved?




Possible fix: https://phabricator.kde.org/D6142

D6141: make shadows work for windows 100%width or height

[Michail Vourlakos]

mvourlakos added a comment.


  thank u!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart, lukas

D6141: make shadows work for windows 100%width or height

[Marco Martin]

mart edited the summary of this revision.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart, lukas

D6141: make shadows work for windows 100%width or height

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6141#114932, @mvourlakos wrote:
  
  > @mart does this fix also https://bugs.kde.org/show_bug.cgi?id=380825 ?
  
  
  yes, that's him, thanks

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart, lukas

D5729: #379003: Fix National Geographic POTD provider

[Juri Vitali]

vitali added a comment.


  *ping* :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D5729

To: vitali, sebas
Cc: Zren, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6141: make shadows work for windows 100%width or height

[Michail Vourlakos]

mvourlakos added a comment.


  @mart does this fix also https://bugs.kde.org/show_bug.cgi?id=380825 ?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart, lukas

Re: Transient parent for QtWidgets popup menus

[Elvis Angelaccio]

On domenica 28 maggio 2017 10:37:40 CEST, Marco Martin wrote:

On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote:

   createWinId();

windowHandle()->setTransientParent(parent()->nativeParentWidget()->windowHan
dle());

Does it makes sense? Would it work?


As far i know, if a qmenu is passed a parent in the ctor, then at the right 
moment a transientparent is set as well, that's why most of menus are ok.


for a general solution,  tried to do this in Qt:
https://codereview.qt-project.org/#/c/195704/


Any idea about drop menus? (i.e. QMenus usually created in some dropEvent() 
function). Even if they have a parent, they are positioned in the place the 
drag started, rather than the place where the drop happened. It seems that 
QCursor::pos() (passed to QMenu::exec()) is broken if called inside 
dropEvent(), almost like if the app does not realize that the mouse cursor 
moved?

D6141: make shadows work for windows 100%width or height

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6141#114925, @davidedmundson wrote:
  
  > you're written
  >  max(top, bottom, topRight, topLeft)
  >  +
  >  max (left, right)
  >  +
  >  max(bottomLeft, bottomRight, bottom)
  
  
  no, the intention is
  max(left+right,
  
(max(topLeft,bottomLeft) + max(top,bottom) + max(topright,bottomright))
  
  that is, if topleft+top+topright ==0 and bottomleft+bottom+bottomright == 0,
  then use as pixmap width the width of left+right
  
  (i may even make it more explicit by not doing a max, but just if(width==0) 
width = left+right

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D6140: Standardize the GlobalHeader height

[Jens Reuterberg]

jensreuterberg added a comment.


  I have to agree with Marco (inside) although I am currently wearing a striped 
tanktop and chequered shorts so "good taste" may not apply to me ;)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6140

To: apol, #kirigami, mart
Cc: jensreuterberg, plasma-devel, apol, mart

D6140: Standardize the GlobalHeader height

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:247bd7f46a5c: Standardize the GlobalHeader height 
(authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6140?vs=15259&id=15261

REVISION DETAIL
  https://phabricator.kde.org/D6140

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/ItemViewHeader.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

D6141: make shadows work for windows 100%width or height

[David Edmundson]

davidedmundson added a comment.


  Investigation sounds sensible, the fix is off.
  
  Old code is:
  max(topLeft,topRight)
  +
  max (left, right)
  +
  max(bottomLeft, bottomRight)
  
  --
  
  What you're saying we want is:
  
  max(topLeft,topRight,top)
  +
  max (left, right)
  +
  max(bottomLeft, bottomRight, bottom)
  
  --
  
  you're written
  max(top, bottom, topRight, topLeft)
  +
  max (left, right)
  +
  max(bottomLeft, bottomRight, bottom)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D6140: Standardize the GlobalHeader height

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6140

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

D6140: Standardize the GlobalHeader height

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6140#114909, @apol wrote:
  
  > People with good taste: I'm wondering whether the blue thing should 
actually be outside rather than inside. What do you think?
  
  
  inside.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6140

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

[Powerdevil] [Bug 378498] Power settings missing scrollbar

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=378498

Christoph Feck  changed:

   What|Removed |Added

 CC||pas...@dhermilly.dk

--- Comment #2 from Christoph Feck  ---
*** Bug 380079 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6141: make shadows work for windows 100%width or height

[Marco Martin]

mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  when a window has 100% width or height (common in the panel),
  it disables the shadows on the sides (or top/bottom) and
  since they are used to compute width/height, if all 4 corner
  shadows are disabled, it will think the resulting shadow pixmap
  is null having width or height == 0
  in this case, use the width of left and right pixmaps for the width
  and height of top and bottom for the height, as they will be the only 
elements present

TEST PLAN
  100% width panels now have a shadow in wayland, kickoff also in
  the windowd kwin when it doesn't fit in vertical resolution

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6141

AFFECTED FILES
  scene_opengl.cpp

To: mart, #plasma, #kwin, graesslin
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6140: Standardize the GlobalHeader height

[Aleix Pol Gonzalez]

apol added a comment.


  People with good taste: I'm wondering whether the blue thing should actually 
be outside rather than inside. What do you think?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6140

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

D6140: Standardize the GlobalHeader height

[Aleix Pol Gonzalez]

apol added a comment.


  Examples
  
  Kirigami Gallery on Material
  F3778197: Spectacle.b20708.png 
  
  Kirigami Gallery desktop
  F3778199: Spectacle.M20945.png 
  
  Discover
  F3778201: Spectacle.X21052.png 
  
  Klimbgrades
  F3778203: Spectacle.z21052.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6140

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

D6140: Standardize the GlobalHeader height

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The size becomes static rather than depending on the header image
  form factor.
  Makes sure it has the same height as the list headers

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6140

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/ItemViewHeader.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

D6137: The session is not called KDE

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c1da4a8dce02: The session is not called KDE (authored by 
sebas).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6137?vs=15253&id=15255

REVISION DETAIL
  https://phabricator.kde.org/D6137

AFFECTED FILES
  kcms/autostart/autostart.cpp

To: sebas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5747: add pid to plasma window management protocol

[Sebastian Kügler]

sebas closed this revision.
sebas added a comment.


  Issue has been fixed elsewhere, otherwise code is submitted.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5747

To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
mart, hein, lukas

D6137: The session is not called KDE

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  sebas/autostartkcm

REVISION DETAIL
  https://phabricator.kde.org/D6137

To: sebas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6137: The session is not called KDE

[Sebastian Kügler]

sebas created this revision.
sebas added a project: Plasma.

REVISION SUMMARY
  Kill wrong lingo in autostart kcm, make it more generic

TEST PLAN
  Checked in autostart KCM, new string appears

REPOSITORY
  R119 Plasma Desktop

BRANCH
  sebas/autostartkcm

REVISION DETAIL
  https://phabricator.kde.org/D6137

AFFECTED FILES
  kcms/autostart/autostart.cpp

To: sebas, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6136: The session is not called KDE

[Sebastian Kügler]

sebas abandoned this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6136

To: sebas
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6136: The session is not called KDE

[Sebastian Kügler]

sebas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Kill wrong lingo, make it more generic

REPOSITORY
  R119 Plasma Desktop

BRANCH
  sebas/autostartkcm

REVISION DETAIL
  https://phabricator.kde.org/D6136

AFFECTED FILES
  kcms/autostart/autostart.cpp

To: sebas
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D3484: Center systemmonitor window properly on multi-screen setup

[Sebastian Kügler]

sebas added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ksystemactivitydialog.cpp:78
> 
> 
> > This doesn't work with scaling
> 
> Yes it does.

Right, was actually wondering right after I submitted. In that case, I'm not 
all that opposed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3484

To: valeriymalov, #plasma_workspaces, aacid, mart
Cc: davidedmundson, sebas, aacid, graesslin, plasma-devel, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D3484: Center systemmonitor window properly on multi-screen setup

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> sebas wrote in ksystemactivitydialog.cpp:78
> This doesn't work with scaling, different font settings or different widget 
> themes. Hardcoded sizes are a no-no in general.

> This doesn't work with scaling

Yes it does.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3484

To: valeriymalov, #plasma_workspaces, aacid, mart
Cc: davidedmundson, sebas, aacid, graesslin, plasma-devel, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D3484: Center systemmonitor window properly on multi-screen setup

[Sebastian Kügler]

sebas added inline comments.

INLINE COMMENTS

> ksystemactivitydialog.cpp:78
>  {
> -saveDialogSettings();
> -event->accept();
> -}
> -
> -
> -void KSystemActivityDialog::reject ()
> -{
> -saveDialogSettings();
> -QDialog::reject();
> -}
> -
> -void KSystemActivityDialog::saveDialogSettings()
> -{
> -//When the user closes the dialog, save the position and the KeepAbove 
> state
> -KConfigGroup cg = KSharedConfig::openConfig()->group("TaskDialog");
> -KWindowConfig::saveWindowSize(windowHandle(), cg);
> -m_processList.saveSettings(cg);
> -
> -// Since we default to forcing the window to be KeepAbove, if the user 
> turns this off, remember this
> -// vHanda: Temporarily commented out
> -// bool keepAbove = KWindowSystem::windowInfo(winId(), 
> NET::WMState).hasState(NET::KeepAbove);
> -// KRunnerSettings::setKeepTaskDialogAbove(keepAbove);
> -KSharedConfig::openConfig()->sync();
> +return QSize(650, 420);
>  }

This doesn't work with scaling, different font settings or different widget 
themes. Hardcoded sizes are a no-no in general.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3484

To: valeriymalov, #plasma_workspaces, aacid, mart
Cc: sebas, aacid, graesslin, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D3484: Center systemmonitor window properly on multi-screen setup

[Valeriy Malov]

valeriymalov updated this revision to Diff 15251.
valeriymalov added a comment.


  So I've decided to revisit this and ended up deleting most of the code, dunno 
if I went overboard here.
  
  Replaced resize and setGeometry calls with sizeHint() for the window. I've 
also removed call to minimumSizeHint() that as far as I understand calculates 
minimum size hint, but I don't think we need it anymore since sizeHint is set.
  
  Got rid of code that saves/restores & applies "keep above" to avoid further 
interference with WM, since Kwin can do that on it's own.
  
  Removed timer that was used to set window size and moved dbus registration 
from it to constructor. I know we use dbus to close this window and it doesn't 
break that, but otherwise I don't understand why dbus registration was timed, 
systemmonitor doesn't really export anything special.
  
  So now by default the dialog opens centered on current display on it's own 
for some reason, which is close to original/intended behavior, and should be 
more manageable by kwin.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3484?vs=8469&id=15251

REVISION DETAIL
  https://phabricator.kde.org/D3484

AFFECTED FILES
  systemmonitor/ksystemactivitydialog.cpp
  systemmonitor/ksystemactivitydialog.h

To: valeriymalov, #plasma_workspaces, aacid, mart
Cc: aacid, graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6133: Make --test mode run without spawning kactivitymanagerd or restarting

[Aleix Pol Gonzalez]

apol added a comment.


  +1 LGTM

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6133

To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D6134: Test every plasmoid

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> test.sh.in:2
>  #!/bin/sh
> -plasmashell --test "@CMAKE_CURRENT_BINARY_DIR@/testLayout-@plasmoidName@.js"
> -kactivitymanagerd stop
> +plasmashell --test  "@CMAKE_CURRENT_BINARY_DIR@/testLayout-@plasmoidName@.js"

just added an extra space there?

REPOSITORY
  R527 Integration tests for Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6134

To: davidedmundson, #plasma, mart
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D6134: Test every plasmoid

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R527 Integration tests for Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6134

To: davidedmundson, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6134: Test every plasmoid

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ShellCorona will now abort in test mode if an applet fails to load, even
  without a dedicated script, this test will make sure everything at least
  loads; hopefully preventing the task-manager bug of 5.8.8 and the quickshare 
  bug of 5.10.0
  
  Simplify plasmoid-test loading.

REPOSITORY
  R527 Integration tests for Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6134

AFFECTED FILES
  plasmoid-tests/CMakeLists.txt
  plasmoid-tests/test.sh.in
  plasmoid-tests/testLayout.js.in

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6133: Make --test mode run without spawning kactivitymanagerd or restarting

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This allows us to run the plasma-tests repo on your system without it
  destroying all your real activities. Even though one run tests in a nested
  dbus sessions, kactivities will still load and meddle with your real database
  at the same time as the real daemon is. It's messy and broken.
  
  It also allows us to remove a hack in the plasma-tests script.

TEST PLAN
  Ran normal plasma, everything is the same. 
  Ran plasma-tests everything there now works properly

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6133

AFFECTED FILES
  shell/main.cpp
  shell/shellcorona.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5910: make shadows work on wayland

[Marco Martin]

mart added a comment.


  thanks for fixing, sorry about that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: rikmills, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=366795

Sebastian Kügler  changed:

   What|Removed |Added

 CC||se...@kde.org
   Assignee|plasma-devel@kde.org|plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5910: make shadows work on wayland

[Rik Mills]

rikmills added a comment.


  > ! In https://phabricator.kde.org/D5910#114781, @hpereiradacosta wrote:
  >  Working on fixing it. 
  >  Just a couple of ifdef missing.
  
  The fix you just pushed seems to have done the trick. Thank you.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: rikmills, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5910: make shadows work on wayland

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D5910#114772, @rikmills wrote:
  
  > This breaks builds on Neon and Kubuntu CI (Qt 5.7.1)
  >
  > 
http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console
  >
  > 05:10:59 In file included from 
/workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0,
  >  05:10:59  from 
/workspace/build/build-qt4/kstyle/breeze_automoc.cpp:33:
  >  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:24: 
error: ‘KWayland’ was not declared in this scope
  >  05:10:59  QMap 
_widgetSurfaces;
  >  05:10:59 ^
  >  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:51: 
error: template argument 2 is invalid
  >  05:10:59  QMap 
_widgetSurfaces;
  
  
  Working on fixing it. 
  Just a couple of ifdef missing.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: rikmills, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5910: make shadows work on wayland

[Rik Mills]

rikmills added a comment.


  This breaks builds on Neon and Kubuntu CI (Qt 5.7.1)
  
  
http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console
  
  05:10:59 In file included from 
/workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0,
  05:10:59  from 
/workspace/build/build-qt4/kstyle/breeze_automoc.cpp:33:
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:24: 
error: ‘KWayland’ was not declared in this scope
  05:10:59  QMap _widgetSurfaces;
  05:10:59 ^
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:51: 
error: template argument 2 is invalid
  05:10:59  QMap _widgetSurfaces;

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: rikmills, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5889: Keep QIcon::fromTheme in main thread

[Rik Mills]

rikmills added a comment.


  This breaks build on Neon and Kubuntu CI with Qt 5.7.1
  
  
http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console
  
  05:10:59 In file included from 
/workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0,
  05:10:59  from 
/workspace/build/build-qt4/kstyle/breeze_automoc.cpp:33:
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:24: 
error: ‘KWayland’ was not declared in this scope
  05:10:59  QMap _widgetSurfaces;
  05:10:59 ^
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:51: 
error: template argument 2 is invalid
  05:10:59  QMap _widgetSurfaces;

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5889

To: davidedmundson, #plasma, graesslin
Cc: rikmills, graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas