D6577: Don't autohide panel if a child window is open

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is meant as a more generic fix for the autohide panels, actually
  looking to see what transient windows we have open.
  
  The problem with the current fixes (https://phabricator.kde.org/D6555) being 
posted is that we
  potentially get attentionStatus in a corrupt status as we cache the
  value but it might change externally whilst that window is open.
  
  Also saves duplicating code in a bunch of places.

TEST PLAN
  Set autohide
  Opened a context menu in task manager didn't autohide, till I closed it
  Closing menu whilst keeping mouse in the panel doesn't auto hide it until we 
move out after.
  Hovering over TM tooltip keeps autohide from closing (another fix)
  
  (Need to fix an unrelated bug in AppletAlternativeDialog, it seems it can 
leak..)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6577

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6554: [Plasma Dialog] Fix flag condition

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  There's a bunch more q->flags & Qt::Tooltip, if we're going to change one, we 
should change them all.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D6573

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6569: [client] Track all created ConnectionThreads and add API to access them

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D6569#123081, @davidedmundson wrote:
  
  > I don't think this is necessary.
  >
  > The only times we want need to delete the connection ourselves is when 
client code is creating it via ConnectionThread::fromApplication. If they 
create it themselves, we don't want to, and there's no need to track it.
  >
  > For the one instance in the bug you're fixing we have the ConnectionThread 
object already in kwin as it's in kwin's own QPA.
  
  
  The problem is not the one KWin creates, but the one Breeze creates and the 
one the KWindowSystem plugin creates and the one plasma-integration and so on 
and on...

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6569

To: graesslin, #frameworks, #plasma, #kwin
Cc: davidedmundson, dfaure, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

[Jonathan Marten]

marten updated this revision to Diff 16361.
marten added a comment.


  Use KParts::BrowserExtension::childObject(part) to test for browser part 
(needs to be guarded by part!=NULL).
  Split up the big conditional.
  Use part->widget() as parent for message boxes.

REPOSITORY
  R226 Konqueror

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6573?vs=16347=16361

REVISION DETAIL
  https://phabricator.kde.org/D6573

AFFECTED FILES
  plugins/babelfish/CMakeLists.txt
  plugins/babelfish/plugin_babelfish.cpp
  plugins/babelfish/plugin_babelfish.h

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

[Jonathan Marten]

marten marked 2 inline comments as done.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D6573

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias added a comment.


  Btw, should I bump patches to KWin/KRfb to match this version?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias added a comment.


  @davidedmundson , @graesslin , I cleaned up fake-input handling, fixed 
autotests.
  
  Tested this manually with patched KWin and KRfb version - all works fine 
(only one screen though).
  I'm able to retrieve wl_output from native interface as David suggested.
  
  Regarding damage regions - I don't quite see how this works along with GBM 
buffer passing (as far as I can see we have only whole screens as GBM BOs in 
KWin, 
  but I may be missing something.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 16359.
Kanedias added a comment.


  some -> const modifiers and typos

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=16318=16359

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6565: Query supported OpenGL core profile version on X11, GLX

[Fredrik Höglund]

fredrik added a comment.


  You should use the GLX_MESA_query_renderer extension for this when it is 
available.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6565

To: madcatx, graesslin
Cc: fredrik, graesslin, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: KWin 5.10.3.1 update

[Fredrik Höglund]

On Saturday 08 July 2017, Martin Flöser wrote:
> Am 2017-07-07 15:54, schrieb Maximiliano Curia:
> > ¡Hola Jonathan!
> > 
> > El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió:
> >> KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a 
> >> fix for https://bugs.kde.org/show_bug.cgi?id=381870 Freeze in 
> >> KWin::checkGLError on startup which affects machines with an NVidia 
> >> card.
> > 
> >> The change is 
> >> https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07
> > 
> >> https://www.kde.org/info/plasma-5.10.3.php
> > 
> >> kwin-5.10.3.1 4.4MB 
> >> 199e3a2593e9e66bbd6521ee8a25a012003d15f6b4bf2f102c70b798c9abd03a
> > 
> > Is this fix backportable to the 5.8 branch?
> 
> NO! The fix is for a regression introduced with 5.10.3.
> 
> If there are changes which can be backported we will do. Please do not 
> cherry pick changes, that makes it impossible for us to ensure the 
> quality or investigate bugs.

Technically it is not a regression.  It is just more likely to happen in
5.10.3, but it affects all versions of KWin.

KWin can also crash when a graphics reset has occurred, since it assumes
that glMapBufferRange() never returns NULL, and that is not the case when
the context has been lost.

Fredrik

D6574: [Logout Dialog] Honor "Offer shutdown options"

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:913142c565ec: [Logout Dialog] Honor "Offer shutdown 
options" (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6574?vs=16351=16357

REVISION DETAIL
  https://phabricator.kde.org/D6574

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6575: [Notes applet] Wrap in FocusScope

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:300771464b5a: [Notes applet] Wrap in FocusScope (authored 
by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6575?vs=16355=16356

REVISION DETAIL
  https://phabricator.kde.org/D6575

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6575: [Notes applet] Wrap in FocusScope

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:134
> you've added an extra margin to the bottom.

That's the bottomMargin the fontButtons Row originally had. I moved all the 
margins to the FocusScope and then just anchored the items inside without.

REVISION DETAIL
  https://phabricator.kde.org/D6575

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6575: [Notes applet] Wrap in FocusScope

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Yep, just wanted to check that I'd understood the goal of the patch.

INLINE COMMENTS

> main.qml:134
>  topMargin: verticalMargins
> -
> -bottom: fontButtons.top
> -bottomMargin: Math.round(units.largeSpacing / 2)
> +bottomMargin: verticalMargins
>  }

you've added an extra margin to the bottom.

REVISION DETAIL
  https://phabricator.kde.org/D6575

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R31 Breeze

BRANCH
  wayland-shadow-parent

REVISION DETAIL
  https://phabricator.kde.org/D6572

To: graesslin, #kwin, #plasma, hpereiradacosta, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6569: [client] Track all created ConnectionThreads and add API to access them

[David Edmundson]

davidedmundson added a comment.


  I don't think this is necessary.
  
  The only times we want need to delete the connection ourselves is when client 
code is creating it via ConnectionThread::fromApplication. If they create it 
themselves, we don't want to, and there's no need to track it.
  
  For the one instance in the bug you're fixing we have the ConnectionThread 
object already in kwin as it's in kwin's own QPA.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6569

To: graesslin, #frameworks, #plasma, #kwin
Cc: davidedmundson, dfaure, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6575: [Notes applet] Wrap in FocusScope

[Kai Uwe Broulik]

broulik added a comment.


  Well, it's a lot more compact. All the items that I explicitly checked in the 
previous code are inside the FocusScope now

REVISION DETAIL
  https://phabricator.kde.org/D6575

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6575: [Notes applet] Wrap in FocusScope

[David Edmundson]

davidedmundson added a comment.


  Is this any different from the current opacity binding?

REVISION DETAIL
  https://phabricator.kde.org/D6575

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6575: [Notes applet] Wrap in FocusScope

[Kai Uwe Broulik]

broulik updated this revision to Diff 16355.
broulik added a comment.


  - Be explicit about opacity 1 or 0

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6575?vs=16354=16355

REVISION DETAIL
  https://phabricator.kde.org/D6575

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6575: [Notes applet] Wrap in FocusScope

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Allows to leverage FocusScope's activeFocus property to determin whether we 
the text field or formatting buttons have focus.

TEST PLAN
  Clicked in text field, tabbed through the applet successfully; formatting 
buttons only hid when I clicked outside the applet.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D6575

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6574: [Logout Dialog] Honor "Offer shutdown options"

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6574

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezeshadowhelper.h:187
> Just to make sure (I haven't read the other review request): this change is 
> because Registry now returns QPointer and not raw pointers ? Correct ?

... ignore. 
I guess this is just to have better test on nullptr in case the object pointed 
to by QPointer gets deleted elsewhere (e.g. in kwin)

REPOSITORY
  R31 Breeze

BRANCH
  wayland-shadow-parent

REVISION DETAIL
  https://phabricator.kde.org/D6572

To: graesslin, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  looks good !

INLINE COMMENTS

> breezeshadowhelper.h:187
>  //* The Wayland shadow manager to create Shadows for Surfaces 
> (QWindow)
> -KWayland::Client::ShadowManager* _shadowManager;
> +QPointer _shadowManager;
>  

Just to make sure (I haven't read the other review request): this change is 
because Registry now returns QPointer and not raw pointers ? Correct ?

REPOSITORY
  R31 Breeze

BRANCH
  wayland-shadow-parent

REVISION DETAIL
  https://phabricator.kde.org/D6572

To: graesslin, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6574: [Logout Dialog] Honor "Offer shutdown options"

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  "maysd" stands for "may shut down" apparently.
  Kickoff already removed the options in this case but clicking "Logout" yields 
the new dialog which offers them all again.

TEST PLAN
  Unchecked the option, clicked "Logout" was no longer offered 
Shutdown/Restart. I was too lazy trying whether the buttons actually do 
something when disabled (I don't think they do) but still looks weird.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6574

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

[David Faure]

dfaure added a comment.


  Looks good, just some details.

INLINE COMMENTS

> plugin_babelfish.cpp:225
> +  part->url().scheme().compare(QLatin1String("https"), 
> Qt::CaseInsensitive) == 0 ) &&
> +(part->inherits("KHTMLPart") || part->inherits("KWebKitPart"))) {
>  m_menu->setEnabled(true);

This is missing WebEngine btw, but instead this should be generalized with 
something like
"the part has a browser extension", like this:

  && KParts::BrowserExtension::childObject(part)

> plugin_babelfish.cpp:273
> +if (url.scheme() == "https") {
> +if (KMessageBox::warningContinueCancel(0L,
> +   xi18nc("@info", "\

the 0L should be part->widget() instead.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D6573

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

[Martin Flöser]

graesslin added a dependency: D6571: Delete all Wayland connections by plugins 
prior to own Wayland connection.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6572

To: graesslin, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6569: [client] Track all created ConnectionThreads and add API to access them

[Martin Flöser]

graesslin added a dependent revision: D6571: Delete all Wayland connections by 
plugins prior to own Wayland connection.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6569

To: graesslin, #frameworks, #plasma, #kwin
Cc: dfaure, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

[Martin Flöser]

graesslin added a reviewer: hpereiradacosta.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6572

To: graesslin, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

[Martin Flöser]

graesslin added a dependency: D6569: [client] Track all created 
ConnectionThreads and add API to access them.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6571

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KWin has a problem that breeze crashes it on tear down if the shadow was
  created. This is due to breeze destroying the Wayland connection after
  KWin destroyed it which triggers a crash in libwayland.
  
  https://phabricator.kde.org/D6571 addresses this problem by deleting the 
ConnectionThread created by
  plugins prior to destroying the Wayland server.
  
  By changing the ownership of the registry and the interfaces to be
  children and grandchildren of the ConnectionThread we can ensure that
  KWin can clean up this area properly. For non KWin cases this doesn't
  change anything, everything is still deleted as a child of ShadowHelper.

TEST PLAN
  Ensured that the Registry gets deleted before KWin's own connection

REPOSITORY
  R31 Breeze

BRANCH
  wayland-shadow-parent

REVISION DETAIL
  https://phabricator.kde.org/D6572

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

[Jonathan Marten]

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: Dolphin, plasma-devel.

REVISION SUMMARY
  The plugin originally only allows HTTP URLs to be translated.  With the 
increasing use of automatic redirection to HTTPS, this seriously restricts the 
utility of the plugin - neither www.kde.org nor Wikipedia can be translated.
  
  This change enables the plugin for HTTPS URLs also.  Since this can result in 
secure information being transmitted over the network in clear text and 
received by the online translation service, a warning dialogue (with the option 
to not ask again) is shown.
  
  The change also removes some unused header files and ports KUrl -> QUrl, 
which eliminates the use of KDELibs4Support.

TEST PLAN
  Built konqueror with this change, checked operation of Tools - Translate Web 
Page for www.kde.org and other secure pages.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D6573

AFFECTED FILES
  plugins/babelfish/CMakeLists.txt
  plugins/babelfish/plugin_babelfish.cpp
  plugins/babelfish/plugin_babelfish.h

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6569: [client] Track all created ConnectionThreads and add API to access them

[David Faure]

dfaure added a comment.


  Isn't a mutex needed to protect this data structure that is apparently 
modified by different threads?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6569

To: graesslin, #frameworks, #plasma, #kwin
Cc: dfaure, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Some libraries loaded into KWin (e.g. breeze) also have a Wayland
  connection. If KWin destroyes it's own Wayland connection before the
  libraries destroy theirs, KWin might crash on tear down when the
  libraries call into libwayland with an invalid connection.
  
  This change requires https://phabricator.kde.org/D6569 in KWayland.

REPOSITORY
  R108 KWin

BRANCH
  connection-cleanup

REVISION DETAIL
  https://phabricator.kde.org/D6571

AFFECTED FILES
  wayland_server.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6565: Query supported OpenGL core profile version on X11, GLX

[Michal Malý]

madcatx added a comment.


  Fair enough, I'll give it another go. Would it make sense to follow this with 
a trivial NULL -> nullptr patch to keep the code in this file consistent?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6565

To: madcatx, graesslin
Cc: graesslin, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

[Powerdevil] [Bug 382114] Screen not locking on lid close

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=382114

Martin Flöser  changed:

   What|Removed |Added

Product|kscreenlocker   |Powerdevil
   Assignee|plasma-b...@kde.org |plasma-devel@kde.org
  Component|library |general

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6566: Do not leak XVisualInfo (X11 EGL path)

[Martin Flöser]

graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  An alternative could be to use QScopedPointer or std::unique_ptr with XFree 
as the deleter.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6566

To: madcatx, graesslin
Cc: graesslin, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6565: Query supported OpenGL core profile version on X11, GLX

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I highly suggest to use the new context attribute builder I created for KWin. 
See https://phabricator.kde.org/D6411

INLINE COMMENTS

> opengl.cpp:778
> +   } else {
> +  qDebug() << "Error: glXMakeCurrent failed for core profile\n";
> +   }

Please don't add qDebug in new code, use qCDebug instead. Same of course for 
all the other cases in the change.

> opengl.cpp:788-789
> XVisualInfo *visinfo;
> +   GLXContext ctxCoreProf = NULL;
> +   GLXFBConfig *fbcCoreProf = NULL;
> int width = 100, height = 100;

please use nullptr in new code.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6565

To: madcatx, graesslin
Cc: graesslin, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: KWin 5.10.3.1 update

[Martin Flöser]

Am 2017-07-07 15:54, schrieb Maximiliano Curia:

¡Hola Jonathan!

El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió:
KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a 
fix for https://bugs.kde.org/show_bug.cgi?id=381870 Freeze in 
KWin::checkGLError on startup which affects machines with an NVidia 
card.


The change is 
https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07



https://www.kde.org/info/plasma-5.10.3.php


kwin-5.10.3.1 4.4MB 
199e3a2593e9e66bbd6521ee8a25a012003d15f6b4bf2f102c70b798c9abd03a


Is this fix backportable to the 5.8 branch?


NO! The fix is for a regression introduced with 5.10.3.

If there are changes which can be backported we will do. Please do not 
cherry pick changes, that makes it impossible for us to ensure the 
quality or investigate bugs.


Cheers
Martin

D6569: [client] Track all created ConnectionThreads and add API to access them

[Martin Flöser]

graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is change needed by KWin. KWin has the problem that it destroys its
  internal Wayland connection (KWin as client for KWin as server) before
  shutting down the application. Other external libraries loaded into KWin
  (e.g. breeze window decoration) are unloaded later on, then try to clean
  up their Wayland resources and crash KWin due to accessing a no longer
  valid Wayland connection.
  
  With the help of this new API KWin can access all connections during
  the clean up and destroy them before shutting down the Wayland server and
  thus exit cleanly.

REPOSITORY
  R127 KWayland

BRANCH
  all-connection-threads

REVISION DETAIL
  https://phabricator.kde.org/D6569

AFFECTED FILES
  autotests/client/test_wayland_connection_thread.cpp
  src/client/connection_thread.cpp
  src/client/connection_thread.h

To: graesslin, #frameworks, #plasma, #kwin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein, lukas

D6568: [Image Wallpaper] Allow dropping images and folders into config dialog

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This allows adding images (for image wallpaper) and folders (for slideshow) 
by dragging them into the list of images/folder.

TEST PLAN
  Unfortunately dropping is a bit flaky with the GridView, even though DropArea 
is outside, the cursor changes between acceptable and unacceptable as I move 
the mouse. PrentStealing and z over 9000 didn't help. For folder it's just fine.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6568

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6565: Query supported OpenGL core profile version on X11, GLX

[Christoph Feck]

cfeck added a comment.


  BUG: 373856

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6565

To: madcatx
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6566: Do not leak XVisualInfo (X11 EGL path)

[Kai Uwe Broulik]

broulik added a comment.


  Would it make sense to wrap that in a `QScopedPointer` with a custom deleter 
that calls `XFree`? This way one does not need to remember calling it whenever 
the function is exited.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6566

To: madcatx
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6567: Do not leak XVisualInfo (GLX path)

[Michal Malý]

madcatx created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  XVisualInfo is not released by get_gl_info_glx()

TEST PLAN
  Leak check with valgrind shows that visinfo is no longer leaking.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6567

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: madcatx
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6566: Do not leak XVisualInfo (X11 EGL path)

[Michal Malý]

madcatx created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  XVisualInfo is not released by get_gl_info_egl

TEST PLAN
  Leak check with valgrind shows that visinfo is no longer leaking.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6566

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: madcatx
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6565: Query supported OpenGL core profile version on X11, GLX

[Michal Malý]

madcatx created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Querying OpenGL version on X11 may return only the highest supported OpenGL 
version that provides the deprecated functionality. Since Mesa does not support 
(and will not support) compatibility OpenGL profiles, KInfoCenter may 
incorrectly show only OpenGL 3.0 as the latest supported OpenGL version. This 
patch queries the supported OpenGL core profiles and displays the highest 
supported core profile if such information is available.

TEST PLAN
  The patch works as expected with my Sandy Bridge HD3000 GPU and Mesa 17.0.5. 
KInfoCenter correctly shows that Core profile 3.3 is supported on this GPU. 
Additional Testing was done on Radeon 7730LE, Mesa 17.1rc2. OpenGL 3.0 
compatibility and OpenGL 4.5 core profile support is shown correctly.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6565

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: madcatx
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6551: [Task Manager] Also respect visible property of configure action

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:95efcd389e0e: [Task Manager] Also respect visible 
property of configure action (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6551?vs=16302=16332

REVISION DETAIL
  https://phabricator.kde.org/D6551

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6552: [Folder View] Replay mouse click so left button containment actions work

[Kai Uwe Broulik]

broulik updated this revision to Diff 16330.
broulik retitled this revision from "RFC: [Folder View] Reply mouse click so 
left button containment actions work" to "[Folder View] Replay mouse click so 
left button containment actions work".
broulik added a comment.


  - Use EventGenerator – wow. from a 100 loc patch to 4 lines :D

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6552?vs=16306=16330

REVISION DETAIL
  https://phabricator.kde.org/D6552

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6552: RFC: [Folder View] Reply mouse click so left button containment actions work

[Kai Uwe Broulik]

broulik added a comment.


  Sure, I was thinking about that, but couldn't recall the name of it :D I'll 
have a look

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6552

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6552: RFC: [Folder View] Reply mouse click so left button containment actions work

[Eike Hein]

hein added a comment.


  Wouldn't it make more sense to use or extend EventGenerator than introduce a 
new MouseEventFaker?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6552

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6551: [Task Manager] Also respect visible property of configure action

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6551

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6562: Restrict move resize area only on the screen the strut window is on

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  By allowing panels between screens in 5.8 to have a strut we created a
  "regression" in KWin. KWin always was wrong, just we didn't notice as
  neither Plasma nor previously Kicker set a strut on panels between shared
  screen edges.
  
  The strut is created from the edge of the overall screen setup. This
  means a panel on the left edge of a screen on the right has the strut
  starting from the left screen. KWin uses the strut to restrict the move
  resize area: a window decoration is not allowed to go below a strut. Thus
  it becomes impossible to move the window from the right to the left
  screen.
  
  This change tries to solve this problem by only restricting the move area
  on the screen the window with the strut is on. E.g. if the window is on
  the right screen, the left screen is not affected. Thus it's possible
  again to move a window from one screen to the other as the added test
  case shows.
  
  Unfortunately there are still corner cases where this won't work
  correctly. If the window is on both screens this won't work. It is also a
  rather heavy change for KWin and thus it's targeted for master and not
  for the 5.10 or the 5.8 branch. If we notice that the patch works well
  and doesn't create further issues, it should be considered for
  backporting.
  
  BUG: 371199
  CCBUG: 370510
  FIXED-IN: 5.11

TEST PLAN
  Added test case

REPOSITORY
  R108 KWin

BRANCH
  restricted-move-area-multiple-panels

REVISION DETAIL
  https://phabricator.kde.org/D6562

AFFECTED FILES
  autotests/integration/struts_test.cpp
  geometry.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas