D7174: Add FreeBSD to metainfo.yaml
tcberner created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D7174 AFFECTED FILES metainfo.yaml To: tcberner, #freebsd, mart Cc: plasma-devel, apol, mart
D7168: Handle processId being 0 in ShellClient::killWindow
This revision was automatically updated to reflect the committed changes. Closed by commit R108:00281711d9c4: Handle processId being 0 in ShellClient::killWindow (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7168?vs=17787&id=17798 REVISION DETAIL https://phabricator.kde.org/D7168 AFFECTED FILES shell_client.cpp To: graesslin, #kwin, #plasma, bshah Cc: bshah, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D7168: Handle processId being 0 in ShellClient::killWindow
graesslin added a comment. In https://phabricator.kde.org/D7168#133094, @bshah wrote: > Looks good to me, probably though it's good idea to figure out why it returns 0 as processId? We have a failing auto test for it in KWayland. It looks like libwayland-server is using a linuxism there. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7168 To: graesslin, #kwin, #plasma, bshah Cc: bshah, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D7168: Handle processId being 0 in ShellClient::killWindow
bshah accepted this revision as: bshah. bshah added a comment. This revision is now accepted and ready to land. Looks good to me, probably though it's good idea to figure out why it returns 0 as processId? REPOSITORY R108 KWin BRANCH kill-window-process-0 REVISION DETAIL https://phabricator.kde.org/D7168 To: graesslin, #kwin, #plasma, bshah Cc: bshah, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D7173: Guard every remaining access to rootInfo
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY For a future XFree KWin. Only remaining not guarded usages are in Workspace::init, but that one needs to be refactored anyway for becoming X free. TEST PLAN Compiles REPOSITORY R108 KWin BRANCH rootinfo-guard REVISION DETAIL https://phabricator.kde.org/D7173 AFFECTED FILES geometry.cpp layers.cpp workspace.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D7036: Remove fake dependency on QtScript
This revision was automatically updated to reflect the committed changes. Closed by commit R111:b6ed1afd8a8a: libksysguard does not appear to use QtScript, but just includes it. (authored by carewolf). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7036?vs=17496&id=17790 REVISION DETAIL https://phabricator.kde.org/D7036 AFFECTED FILES CMakeLists.txt processui/CMakeLists.txt processui/scripting.cpp To: carewolf, sandsmark, jriddell, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7168: Handle processId being 0 in ShellClient::killWindow
graesslin added a project: FreeBSD. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7168 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D7168: Handle processId being 0 in ShellClient::killWindow
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY If ClientConnection fails to get the process id (which happens at least on FreeBSD) the process id is 0. We should not try to terminate this pid as it terminates all processes is KWin's process group which is the whole session. TEST PLAN Only compile test REPOSITORY R108 KWin BRANCH kill-window-process-0 REVISION DETAIL https://phabricator.kde.org/D7168 AFFECTED FILES shell_client.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: querying current mouse state
Am 2017-08-05 17:23, schrieb René J. V. Bertin: David Edmundson wrote: In wayland you never query anything, only track events. There are applications for which this isn't good enough but I guess there must be other, low-level ways to query the current state of a given input device or sensor. Short answer: no there isn't. Even libinput does not provide the state of the buttons, but just sends the press events. I'm pretty sure that not even the kernel knows it, otherwise libinput would expose it. What actually do you want to do? I'm toying around with a click-and-hold-opens-the-contextmenu feature (ported from Mac where this makes a bit more sense), based on the TapAndHold gesture. It looks like that event is good demonstration why event tracking isn't 100% reliable. When I activate processing of that gesture on a QToolButton with a menu, it finishes (triggers) even when I am not holding any mouse button. The event filter in which I implement this feature also catches MouseRelease and MouseMove events (to turn off the gesture processing); I'm not getting those either when the QToolButton's menu is open. IOW, when I click once on the button to open its menu, the contextmenu is opened too after the expected delay. The only reliable way I found to prevent this is to check if the mouse button is still pressed when the TapAndHold gesture claims to be finished. For Wayland you can use the KWayland Client library to low level listen to the button press/release events. Example code for how to do this is in breeze kstyle for manual moving of the window. Cheers Martin
D7160: Also specify a default StyleName for fonts
fvogt added a comment. In https://phabricator.kde.org/D7160#132870, @cfeck wrote: > Note that saving the style name is a bug, see https://bugs.kde.org/show_bug.cgi?id=378523 While I'm not 100% sure that is true as that's how the user selects the font in kcm_fonts, I still think this patch is by itself an improvement as the stylenames are provided by the font creators to ship predefined metrics for aesthetics. Possibly related: https://github.com/qt/qtbase/commit/2bb01172a76f14b1f57010b79207f6b9a9bf3f53 So still ok to land? REPOSITORY R135 Integration for Qt applications in Plasma BRANCH stylename REVISION DETAIL https://phabricator.kde.org/D7160 To: fvogt, #plasma, davidedmundson Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7155: Implement sorting of the device tree items
broulik added inline comments. INLINE COMMENTS > devicelisting.cpp:49 > populateListing(); > +setSortingEnabled(true); > } Why disable again? > soldevice.cpp:153 > +const SolDevice * otherDevice = dynamic_cast(&other); > +if (otherDevice != nullptr) > +{ Coding style: brace on the same line, also no need for explicit `nullptr` check: if (otherDevice) { REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma Cc: broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7160: Also specify a default StyleName for fonts
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH stylename REVISION DETAIL https://phabricator.kde.org/D7160 To: fvogt, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7160: Also specify a default StyleName for fonts
cfeck added a comment. Note that saving the style name is a bug, see https://bugs.kde.org/show_bug.cgi?id=378523 REPOSITORY R135 Integration for Qt applications in Plasma BRANCH stylename REVISION DETAIL https://phabricator.kde.org/D7160 To: fvogt, #plasma, davidedmundson Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7160: Also specify a default StyleName for fonts
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY When saving, kcm_fonts adds the default selected StyleName, so it needs to specified here as well to avoid mismatches. BUG: 383191 TEST PLAN Ran pkcon install with no kdeglobals. Without this change: Bold title in the auth dialog With this change: Normal title in the auth dialog REPOSITORY R135 Integration for Qt applications in Plasma BRANCH stylename REVISION DETAIL https://phabricator.kde.org/D7160 AFFECTED FILES src/platformtheme/kfontsettingsdata.cpp src/platformtheme/kfontsettingsdata.h To: fvogt, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running
https://bugs.kde.org/show_bug.cgi?id=358957 Brennan Kinney changed: What|Removed |Added CC||polarathene-signup@hotmail. ||com --- Comment #18 from Brennan Kinney --- What is the status of this support? Is it still only discussed/tracked here? If the feature is not difficult to add/contribute, can an experienced dev familiar with the codebase point out what needs to be done where?(files to change, UI adjustments, etc) >From what I gather reading this, adding the basic functionality to the launcher leave options is trivial?(if so what files/lines? for launcher support) Followed by some UI settings modification(System Settings -> Power Management -> Advanced Settings?) and extra changes elsewhere to support laptop lid behaviour? --- I'm in agreement with getting this 5 year old request(https://bugs.kde.org/show_bug.cgi?id=302968) functional and available, tweak the UI later if there is a need. Even just having it as a launcher option would be nice(I noticed Power Management -> Energy Saving has a dropdown for the power button action supporting hybrid-sleep). While benefits are obvious for laptop users, it's also useful as a desktop user, I would prefer it. -- You are receiving this mail because: You are the assignee for the bug.