D7078: [server] Fix crash when sending selection to a DDI without a DataSource
davidedmundson added a comment. > So from KWayland Server side we have a selection from KWayland server side we have a Seat:selection, we don't check if that has a DDI::selection If a client had called wl_set_selection(dataDevice, nulltptr) the server would still have a registered DDI. If the client has called clearSelection to us, I think we should be sending clearSelection to X. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D1231: Add Remote Access interface to KWayland
Kanedias added a comment. Gentle reminder REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6851: Updated to newer version
This revision was automatically updated to reflect the committed changes. Closed by commit R846:ad23b86c758b: Updated to newer version (authored by Aiix). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6851?vs=17056=18064#toc REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6851?vs=17056=18064 REVISION DETAIL https://phabricator.kde.org/D6851 AFFECTED FILES CMakeLists.txt PACKAGING.readme Readme.md image/breeze-dark/apps/16/mycroft-plasma-appicon.svg image/breeze-dark/apps/32/mycroft-plasma-appicon.svg image/breeze/apps/16/mycroft-plasma-appicon.svg image/breeze/apps/32/mycroft-plasma-appicon.svg mycroft/skills/mycroft-activities-plasma-skill/.directory mycroft/skills/mycroft-activities-plasma-skill/LICENSE mycroft/skills/mycroft-activities-plasma-skill/README.md mycroft/skills/mycroft-activities-plasma-skill/__init__.py mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.create.dialog mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.remove.dialog mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.show.dialog mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.stop.dialog mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.switch.dialog mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample1.intent.json mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample2.intent.json mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample3.intent.json mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample4.intent.json mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample5.intent.json mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesCreateKeyword.voc mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesRemoveKeyword.voc mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesShowKeyword.voc mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesStopKeyword.voc mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesSwitchKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/LICENSE mycroft/skills/mycroft-amarok-player-plasma-skill/README.md mycroft/skills/mycroft-amarok-player-plasma-skill/__init__.py mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.next.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.pause.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.play.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.previous.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.stop.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample1.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample2.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample3.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample4.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample5.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokNextKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokPauseKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokPlayKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokPreviousKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokStopKeyword.voc mycroft/skills/mycroft-internals-plasma-skill/.directory mycroft/skills/mycroft-internals-plasma-skill/LICENSE mycroft/skills/mycroft-internals-plasma-skill/README.md mycroft/skills/mycroft-internals-plasma-skill/__init__.py mycroft/skills/mycroft-internals-plasma-skill/dialog/en-us/internals.lock.dialog mycroft/skills/mycroft-internals-plasma-skill/dialog/en-us/internals.logout.dialog mycroft/skills/mycroft-internals-plasma-skill/dialog/en-us/internals.switchuser.dialog mycroft/skills/mycroft-internals-plasma-skill/test/intent/sample1.intent.json mycroft/skills/mycroft-internals-plasma-skill/test/intent/sample2.intent.json mycroft/skills/mycroft-internals-plasma-skill/test/intent/sample3.intent.json mycroft/skills/mycroft-internals-plasma-skill/vocab/en-us/InternalLockDesktopKeyword.voc mycroft/skills/mycroft-internals-plasma-skill/vocab/en-us/InternalLogoutDesktopKeyword.voc mycroft/skills/mycroft-internals-plasma-skill/vocab/en-us/InternalSwitchUserKeyword.voc mycroft/skills/mycroft-krunner-skill/.directory mycroft/skills/mycroft-krunner-skill/LICENSE mycroft/skills/mycroft-krunner-skill/README.md mycroft/skills/mycroft-krunner-skill/__init__.py mycroft/skills/mycroft-krunner-skill/dialog/en-us/krunner.recent.dialog
D7271: optionally show a history of notifications
davidedmundson added a comment. There's a visual quirk I'd like fixing. Each delegate has a line on the bottom. However, there's no line between the persistent notifications and the history, so it looks weird. Maybe a heading "history" would also work. Also in your last change to my suggestion you've made it so that non persistent items are included in the number in the compact representation. I don't know if we want that or not. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7038: [server] Respect input region of sub-surfaces on pointer surface focus
graesslin added a comment. I like that refactoring - though processAt might not be the best fitting name. Don't have a good name idea, maybe findChildSurfaceAt? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: subdiff, #frameworks, graesslin Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies
graesslin added a comment. In https://phabricator.kde.org/D7273#134905, @bshah wrote: > In https://phabricator.kde.org/D7273#134903, @graesslin wrote: > > > @apol any idea why several of the packages are reported not found? > > > Please try to run `qmlplguindump QtQuick.Controls 1.2` for instance and paste it's output here. I get: QQmlComponent: Component is not ready I'm on neon dev/unstable for the record REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7273 To: graesslin, #kwin, #plasma Cc: bshah, apol, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart, lukas
D7038: [server] Respect input region of sub-surfaces on pointer surface focus
subdiff marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: subdiff, #frameworks, graesslin Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7038: [server] Respect input region of sub-surfaces on pointer surface focus
subdiff updated this revision to Diff 18059. subdiff added a comment. Use function pointers. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=17500=18059 REVISION DETAIL https://phabricator.kde.org/D7038 AFFECTED FILES src/server/pointer_interface.cpp src/server/surface_interface.cpp src/server/surface_interface.h src/server/surface_interface_p.h To: subdiff, #frameworks, graesslin Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies
bshah added a comment. In https://phabricator.kde.org/D7273#134903, @graesslin wrote: > @apol any idea why several of the packages are reported not found? Please try to run `qmlplguindump QtQuick.Controls 1.2` for instance and paste it's output here. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7273 To: graesslin, #kwin, #plasma Cc: bshah, apol, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart, lukas
D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies
graesslin added a subscriber: apol. graesslin added a comment. @apol any idea why several of the packages are reported not found? -- The following RUNTIME packages have not been found: * QtQuick.Controls-QMLModule , QML module 'QtQuick.Controls' is a runtime dependency. * QtQuick.VirtualKeyboard-QMLModule , QML module 'QtQuick.VirtualKeyboard' is a runtime dependency. * org.kde.plasma.core-QMLModule , QML module 'org.kde.plasma.core' is a runtime dependency. * org.kde.plasma.components-QMLModule , QML module 'org.kde.plasma.components' is a runtime dependency. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7273 To: graesslin, #kwin, #plasma Cc: apol, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart, lukas
D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REPOSITORY R108 KWin BRANCH ecmqmlmodules REVISION DETAIL https://phabricator.kde.org/D7273 AFFECTED FILES CMakeLists.txt To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D7271: optionally show a history of notifications
progwolff updated this revision to Diff 18051. progwolff added a comment. - fix property name REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18050=18051 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 AFFECTED FILES applets/notifications/package/contents/config/main.xml applets/notifications/package/contents/ui/NotificationHistoryDelegate.qml applets/notifications/package/contents/ui/Notifications.qml applets/notifications/package/contents/ui/configNotifications.qml applets/notifications/package/contents/ui/main.qml To: progwolff, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7271: optionally show a history of notifications
progwolff updated this revision to Diff 18050. progwolff added a comment. - uncomment unintentionally commented line - rename counters REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18045=18050 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 AFFECTED FILES applets/notifications/package/contents/config/main.xml applets/notifications/package/contents/ui/NotificationHistoryDelegate.qml applets/notifications/package/contents/ui/Notifications.qml applets/notifications/package/contents/ui/configNotifications.qml applets/notifications/package/contents/ui/main.qml To: progwolff, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7271: optionally show a history of notifications
progwolff marked 2 inline comments as done. progwolff added inline comments. INLINE COMMENTS > davidedmundson wrote in Notifications.qml:243 > ? sorry, missed to revert this... > davidedmundson wrote in Notifications.qml:257 > How does this differ to the persistent delegate? > > Can we share most of this? It's almost the same. Only the models differ (NotificationsModel is used in NotificationDelegate, NotificationsHistoryModel is used in NotificationHistoryDelegate). I also thought it might be a good idea to use a seperate delegates here, so that in the future history items might have a different visual representation than persistent notifications. If this is not wanted, we could probably make the model a property of NotificationDelegate. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7271: optionally show a history of notifications
progwolff marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7271: optionally show a history of notifications
davidedmundson added a comment.
Thanks for looking into this.. first round of comments.
INLINE COMMENTS
> Notifications.qml:243
> }
> -onPopupShown: notificationsRoot.popupShown(popup)
> +//onPopupShown: notificationsRoot.popupShown(popup)
> }
?
> Notifications.qml:257
> +model: notificationsHistoryModel
> +delegate: NotificationHistoryDelegate {}
> +}
How does this differ to the persistent delegate?
Can we share most of this?
> main.qml:56
> //notifications + jobs
> property int totalCount: (notifications ? notifications.count : 0) +
> (jobs ? jobs.count : 0)
> +property int historyCount: totalCount + (notifications ?
> notifications.historyCount : 0)
This is now a somewhat confusing name as it's not the total.
Then you have the real total under a new name property below.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
D7271: optionally show a history of notifications
progwolff created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Bug 378032. With these changes, notifications can be configured to always persist in the notifications applet. Todo: filter by application, see https://bugs.kde.org/show_bug.cgi?id=378032#c27 TEST PLAN Open the notification plasmoid's settings. Check 'Show a history of notifications'. Trigger some notifications. They should show up in the applet. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 AFFECTED FILES applets/notifications/package/contents/config/main.xml applets/notifications/package/contents/ui/NotificationHistoryDelegate.qml applets/notifications/package/contents/ui/Notifications.qml applets/notifications/package/contents/ui/configNotifications.qml applets/notifications/package/contents/ui/main.qml To: progwolff, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7197: Move event filtering for overlay window into an X11EventFilter
This revision was automatically updated to reflect the committed changes. Closed by commit R108:a65b2c062cb0: Move event filtering for overlay window into an X11EventFilter (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7197?vs=17864=18043#toc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7197?vs=17864=18043 REVISION DETAIL https://phabricator.kde.org/D7197 AFFECTED FILES composite.cpp composite.h events.cpp plugins/platforms/x11/standalone/overlaywindow_x11.cpp plugins/platforms/x11/standalone/overlaywindow_x11.h To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7093: Implement the shortcut caption suffix for Wayland windows
This revision was automatically updated to reflect the committed changes. Closed by commit R108:bbca8c6677fe: Implement the shortcut caption suffix for Wayland windows (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7093?vs=17627=18041 REVISION DETAIL https://phabricator.kde.org/D7093 AFFECTED FILES abstract_client.cpp abstract_client.h autotests/integration/globalshortcuts_test.cpp client.cpp client.h shell_client.cpp shell_client.h useractions.cpp To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7193: Move the X11 specific OverlayWindow into the platform/x11
This revision was automatically updated to reflect the committed changes. Closed by commit R108:b4a79d30e64f: Move the X11 specific OverlayWindow into the platform/x11 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7193?vs=17842=18042 REVISION DETAIL https://phabricator.kde.org/D7193 AFFECTED FILES overlaywindow.cpp overlaywindow.h platform.cpp platform.h plugins/platforms/x11/common/eglonxbackend.cpp plugins/platforms/x11/standalone/CMakeLists.txt plugins/platforms/x11/standalone/glxbackend.cpp plugins/platforms/x11/standalone/overlaywindow_x11.cpp plugins/platforms/x11/standalone/overlaywindow_x11.h plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/standalone/x11_platform.h scene_xrender.cpp To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D7259: Move QPainter compositor into plugin
graesslin updated this revision to Diff 18039. graesslin added a comment. Add back a debug message which got lost while moving code around CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7259?vs=18022=18039 BRANCH scene-qpainter-plugin REVISION DETAIL https://phabricator.kde.org/D7259 AFFECTED FILES CMakeLists.txt autotests/integration/effects/fade_test.cpp autotests/integration/effects/slidingpopups_test.cpp autotests/integration/effects/translucency_test.cpp autotests/integration/scene_qpainter_test.cpp autotests/integration/x11_client_test.cpp composite.cpp data/org_kde_kwin.categories platformsupport/CMakeLists.txt platformsupport/scenes/CMakeLists.txt platformsupport/scenes/qpainter/CMakeLists.txt platformsupport/scenes/qpainter/backend.cpp platformsupport/scenes/qpainter/backend.h plugins/platforms/drm/CMakeLists.txt plugins/platforms/drm/scene_qpainter_drm_backend.h plugins/platforms/fbdev/CMakeLists.txt plugins/platforms/fbdev/scene_qpainter_fb_backend.h plugins/platforms/virtual/CMakeLists.txt plugins/platforms/virtual/scene_qpainter_virtual_backend.h plugins/platforms/wayland/CMakeLists.txt plugins/platforms/wayland/scene_qpainter_wayland_backend.h plugins/platforms/x11/windowed/CMakeLists.txt plugins/platforms/x11/windowed/scene_qpainter_x11_backend.h plugins/scenes/CMakeLists.txt plugins/scenes/qpainter/CMakeLists.txt plugins/scenes/qpainter/qpainter.json plugins/scenes/qpainter/scene_qpainter.cpp plugins/scenes/qpainter/scene_qpainter.h scene.cpp scene.h scene_qpainter.cpp scene_qpainter.h To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6549: Look for QtGraphicalEffects, so packagers don't forget it
graesslin added a comment. In https://phabricator.kde.org/D6549#134794, @apol wrote: > I was thinking: should I wait for a month so that ECM has been released with it maybe? Otherwise it will be a hard dependency and people won't be able to use the master branch... I think it's totally fine for a framework master to depend on ECM master. At least for KWin I think I'll introduce this ecm_find_qmlmodule without waiting another month ;-) REPOSITORY R169 Kirigami BRANCH arcpatch-D6549 REVISION DETAIL https://phabricator.kde.org/D6549 To: apol, #kirigami, sitter, mart, davidedmundson Cc: graesslin, plasma-devel, apol, mart
D7232: Move SceneXRender into a plugin
graesslin updated this revision to Diff 18038. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Added new debug category to org_kde_kwin.categories REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7232?vs=17968=18038 BRANCH scene-xrender-plugin REVISION DETAIL https://phabricator.kde.org/D7232 AFFECTED FILES CMakeLists.txt composite.cpp data/org_kde_kwin.categories decorations/decorationrenderer.h effects.h plugins/CMakeLists.txt plugins/scenes/CMakeLists.txt plugins/scenes/xrender/CMakeLists.txt plugins/scenes/xrender/scene_xrender.cpp plugins/scenes/xrender/scene_xrender.h plugins/scenes/xrender/xrender.json scene.cpp scene.h scene_xrender.cpp scene_xrender.h shadow.h To: graesslin, #kwin, #plasma Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7267: Add support for moving group members within a group.
davidedmundson added inline comments.
INLINE COMMENTS
> tasksmodel.cpp:1553
> +
> +// If we moved a group parent, consolidate sort map for children.
> +if (groupMode() != GroupDisabled &&
> d->groupingProxyModel->rowCount(groupingRowIndex)) {
This is the only bit that's different from the new code.
Can we share the above and guard this with if(!parent)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7267
To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
D7268: Use new libtm API to enable DND reordering within group dialogs.
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> MouseHandler.qml:102
> +// Reject drags between different TaskList instances.
> +if (tasks.dragSource.parent != above.parent) {
> +return;
We do need this check when moving, but doesn't having this here break item
activation?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7268
To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
