[kio-extras] [Bug 375732] Dolphin fails to sftp to Linux box when not a direct connection

[Wari Wahab]

https://bugs.kde.org/show_bug.cgi?id=375732

Wari Wahab  changed:

   What|Removed |Added

 CC||wari.wa...@gmail.com

--- Comment #1 from Wari Wahab  ---
I can confirm this.


Aug 24 14:20:21 dealio kdeinit5[2438]: log_kio_sftp: file system free space of
QUrl("sftp://dev2-152";)
Aug 24 14:20:21 dealio kdeinit5[2438]: log_kio_sftp: checking cache:
info.username = "" , info.url = "sftp://dev2-152";
Aug 24 14:20:21 dealio kdeinit5[2438]: log_kio_sftp: Creating the SSH session
and setting options
Aug 24 14:20:21 dealio kdeinit5[2438]: log_kio_sftp: Trying to connect to the
SSH server
Aug 24 14:20:21 dealio kdeinit5[2438]: log_kio_sftp: username= "" , host=
"dev2-152" , port= 22
Aug 24 14:20:21 dealio kdeinit5[2438]: log_kio_sftp:
Aug 24 14:20:21 dealio kdeinit5[2438]: log_kio_sftp: connected ? false
username: old= "" new= ""


I can `sftp dev2-152` fine on the command line.

dev2-152 definition on ~/.ssh/config almost the same as OP. Connecting using
`sftp://192.168.2.152` works (that's a direct connection to the server instead
of going through a hop)

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7481: RFC: Batch window changes events on XCB

[Martin Flöser]

graesslin added a comment.


  Window class is not allowed to change by ICCCM. For desktop file we could 
decide that we don't monitor changes as it is our own property.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[Daniel Vrátil]

dvratil added a comment.


  > BTW this change will also accidentally fix your blurry icon issue you 
showed me at Akademy.
  
  This change **is** a fix for the blurry icon which accidentally improves the 
config UI ;-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[Daniel Vrátil]

dvratil updated this revision to Diff 18635.
dvratil added a comment.


  Fix fallback to cfg_icon instead of hardcoded start-here-kde.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7469?vs=18562&id=18635

REVISION DETAIL
  https://phabricator.kde.org/D7469

AFFECTED FILES
  applets/kicker/package/contents/ui/ConfigGeneral.qml

To: dvratil, #plasma
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> hein wrote in ConfigGeneral.qml:123
> This isn't OK - it needs to revert to the actual config default. Some distros 
> change it to their branded icon and are very keen on wanting to override 
> specifically the default rather than pre-setting a deviation. That's one 
> reason why the old config format had cfg_icon and otherwise used 
> cfg_useCustomButtonImage (while your approach here is to migrate everyone to 
> cfg_icon by setting cfg_useCustomButtonImage to false when the UI is used).

we could add a `Q_INVOKABLE QVariant defaultValue()` to KDeclarative 
`ConfigPropertyMap` so we could query this, like we already have an `bool 
isImmutable()`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[David Edmundson]

davidedmundson added a comment.


  > @davidedmundson As Kai Uwe said, this is basically just copy-pasted from 
KickOff configuration code - do you still want me to change it to 1.x control?
  
  No, if Kai says something is fine, it's probably fine.
  
  BTW this change will also accidentally fix your blurry icon issue you showed 
me at Akademy.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[Eike Hein]

hein added a comment.


  Can you also check the following case:
  
  1. Use the old UI to

INLINE COMMENTS

> ConfigGeneral.qml:123
> +cfg_useCustomButtonImage = false;
> +cfg_icon = "start-here-kde";
> +}

This isn't OK - it needs to revert to the actual config default. Some distros 
change it to their branded icon and are very keen on wanting to override 
specifically the default rather than pre-setting a deviation. That's one reason 
why the old config format had cfg_icon and otherwise used 
cfg_useCustomButtonImage (while your approach here is to migrate everyone to 
cfg_icon by setting cfg_useCustomButtonImage to false when the UI is used).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7481: RFC: Batch window changes events on XCB

[Eike Hein]

hein added a comment.


  I'm not sure we only care about the title.
  
  First of, icons: libtm usually ignores NET::WMIcon changes. It only looks at 
them for windows which hit the fallback path of using the WM icon. Of course a 
malicious window might be particularly likely to fall into that category, 
though.
  
  Now, the roles that are generally interesting for ddos purposes are all of 
the roles that contribute to app identification and cause a cache eviction and 
re-running of the app matching heuristic. The heuristic is computationally 
expensive, and changes in the resulting app identity cause more computation 
like re-evaluation of grouping decisions.
  
  Here's all the roles that cause this:
  
  NET::WMName, NET::WMVisibleName, NET::WMPid, NET::WM2DesktopFileName, 
NET::WM2WindowClass
  
  Some of these are non-issues (PID) and some are title. Leaves 
NET::WM2DesktopFileName & NET::WM2WindowClass.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7260: System tray icon's context menu isn't updated properly in plasma/x11

[David Edmundson]

davidedmundson added a comment.


  > Did I miss something?
  
  One of us did.
  
  I did have to redo your patch manually as the diff here doesn't apply to 
either 5.10 or master. It's possible I did it wrong, maybe you can update it?
  
  The only difference is I did right click -> add panel -> application menu bar
  It's important to test it in the mode where Menu A and Menu C are both 
visible in the bar.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7260

To: i.Dark_Templar, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D7475#139003, @luebking wrote:
  
  > I take there's no such support announcement on native wayland at all?
  
  
  It's different. We have dedicated protocols for them and those are announced 
through the Wayland protocol registry.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7475

To: graesslin, #kwin, #plasma, davidedmundson
Cc: luebking, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5377b6b03b8d: kimpanel: change highlight color (authored 
by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7436?vs=18624&id=18628

REVISION DETAIL
  https://phabricator.kde.org/D7436

AFFECTED FILES
  applets/kimpanel/package/contents/ui/CandidateHighlight.qml
  applets/kimpanel/package/contents/ui/InputPanel.qml

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng added a comment.


  That's a bug in breeze. Should be fixed with https://phabricator.kde.org/D7491

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D7436

REVISION DETAIL
  https://phabricator.kde.org/D7436

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Yunhe Guo]

guoyunhe accepted this revision.
guoyunhe added a comment.
This revision is now accepted and ready to land.


  F3874133: Screenshot_20170823_225448.png 

  
  It looks good. Only one small problem: when hovering mouse on selected 
candidate, its height will change.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D7436

REVISION DETAIL
  https://phabricator.kde.org/D7436

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7436

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng updated this revision to Diff 18624.
xuetianweng added a comment.


  Use plasma svg as highlight

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7436?vs=18451&id=18624

BRANCH
  arcpatch-D7436

REVISION DETAIL
  https://phabricator.kde.org/D7436

AFFECTED FILES
  applets/kimpanel/package/contents/ui/CandidateHighlight.qml
  applets/kimpanel/package/contents/ui/InputPanel.qml

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng commandeered this revision.
xuetianweng added a reviewer: guoyunhe.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7436

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[Thomas Lübking]

luebking added a comment.


  I take there's no such support announcement on native wayland at all?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7475

To: graesslin, #kwin, #plasma, davidedmundson
Cc: luebking, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

[Martin Flöser]

graesslin abandoned this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7078

To: graesslin, #kwin, #plasma, #frameworks
Cc: cfeck, anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7474: Remove hard X11 runtime dependency from DBusInterface

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:793624b9a73d: Remove hard X11 runtime dependency from 
DBusInterface (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7474?vs=18579&id=18613

REVISION DETAIL
  https://phabricator.kde.org/D7474

AFFECTED FILES
  dbusinterface.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:651ea26f3c63: Make 
EffectsHandlerImpl::announceSupportProperty work without X11 (authored by 
graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7475?vs=18581&id=18614

REVISION DETAIL
  https://phabricator.kde.org/D7475

AFFECTED FILES
  effects.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: luebking, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D7483: Get rid of warnings about setting both pixel and point sizes

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D7483

To: leinir, #kirigami, mart
Cc: plasma-devel, apol, mart

D7481: RFC: Batch window changes events on XCB

[Martin Flöser]

graesslin added a comment.


  @hein, @davidedmundson if the main concern is too often update of title I 
suggest we implement limiting of updates in KWin. So the batch would happen in 
KWin, taken away stress from KWin and indirectly also from Plasma.
  
  Against updating icons it won't help, though as KWin doesn't set this.

INLINE COMMENTS

> xwindowsystemeventbatcher.cpp:48
> +if (!m_timerId) {
> +m_timerId = startTimer(BATCH_TIME);
> +}

if we can depend on Qt 5.9 you could simplify the BATCH_TIME to either:

  startTimer(std::chrono::milliseconds(10));

or together with C++14 to:

  using namespace std::chrono_literals;
  startTimer(10ms);

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[Martin Flöser]

graesslin added a comment.


  @luebking I don't really follow you. KWin can only talk with one X server. As 
the properties are resolved against the one and only X server there is no 
alignement problem. What might happen in future is that we want to support a 
crashing XWayland server. In this case of cause all cached properties need to 
be discarded.

REPOSITORY
  R108 KWin

BRANCH
  effects-announce-support-property-no-x11

REVISION DETAIL
  https://phabricator.kde.org/D7475

To: graesslin, #kwin, #plasma, davidedmundson
Cc: luebking, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D7481: RFC: Batch window changes events on XCB

[Martin Flöser]

graesslin added a comment.


  > The reason the old lib did this and the reason I'm aware of for wanting 
this is to prevent the TM being ddos'd by a rogue window updating its title 
thousands of times per second. How are we protected from this on Wayland 
currently?
  
  By ensuring KWin does a sane job. If a window can that way ddos Plasma it 
could also ddos KWin, which would be worse. But as KWin is the ultimate source 
to send the caption to KWin, we can limit this to e.g. once per second.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7481: RFC: Batch window changes events on XCB

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D7481#138822, @broulik wrote:
  
  > > Theproblem here is Firefox: that one should be fixed.
  >
  > I can also cause trouble with VLC if I have a repeating playlist with a 
broken file in it, it will continuously cycle between "$title" and "VLC" and 
cause Plasma to freeze. We can't fix all apps…
  
  
  As the window caption is ultimately set by KWin we can limit the update rate.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7488: Fix deprecated usage of ecm_install_icons

[Heiko Becker]

heikobecker created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Fixes a cmake warning.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7488

AFFECTED FILES
  icons/48-actions-kdocumentinfo.png
  icons/CMakeLists.txt
  icons/hi48-actions-kdocumentinfo.png
  icons/hisc-actions-kdocumentinfo.svgz
  icons/sc-actions-kdocumentinfo.svgz

To: heikobecker, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[Daniel Vrátil]

dvratil added a comment.


  @hein Tested that, you can still choose an arbitrary image file in the 
filesystem through the dialog and the image is used correctly
  @davidedmundson As Kai Uwe said, this is basically just copy-pasted from 
KickOff configuration code - do you still want me to change it to 1.x control?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7486: Handle buffer scales changing dynamically

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shell_client.cpp:226
> Explicitly for scale changed?
> 
> Can do, but at that point we may as well have Scene connect to 
> c->surface(), &SurfaceInterface::scaleChanged
> 
> which would also work.
> 
> I'm fine with any.

that sounds lovely.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7486

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7486: Handle buffer scales changing dynamically

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in shell_client.cpp:226
> Should we maybe introduce a dedicated signal?

Explicitly for scale changed?

Can do, but at that point we may as well have Scene connect to 
c->surface(), &SurfaceInterface::scaleChanged

which would also work.

I'm fine with any.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7486

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7486: Handle buffer scales changing dynamically

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> shell_client.cpp:226
> +//we need to rebuild our window quads
> +emit geometryShapeChanged(this, geom);
> +}

Should we maybe introduce a dedicated signal?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7486

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7486: Handle buffer scales changing dynamically

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  Currently when a client changes it's buffer size the result is corrupt
  until we move the window.
  
  When a client buffer scale changes we need to redraw the whole window,
  and most importantly flush the cached window quads, which reference the
  scale.
  
  This is not handled by the doSetGeometry() from the size changing as the
  normalised size of the client remains the same so it no-ops.

TEST PLAN
  Opened gtk3-demo and changed screen scale. It's now perfect.
  Patch for Qt to work correctly incoming.

REPOSITORY
  R108 KWin

BRANCH
  xdgv6

REVISION DETAIL
  https://phabricator.kde.org/D7486

AFFECTED FILES
  shell_client.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7323: Expose Cursor position to DeclarativeScripting

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  I'm not particularly convinced by the arguments, but also don't care enough 
to argue. 
  Might try solving this a different way at a later date.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7323

To: davidedmundson, #plasma, graesslin
Cc: luebking, broulik, graesslin, anthonyfieroni, plasma-devel, kwin, #kwin, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol, mart, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart added a comment.


  now the client part is wrapped too, so no V1 exported (the public facing 
classes should lose "Unstable" probably)
  two more tests to check that importing the same exported in two clients works 
and exporting the same surface two times works as well.
  thanks to david's help most of the random crashes are fixed, there is still 
to solve one crash at exit of the autotest and the warning message:
  wl_display@1: error 0: invalid object 9 in a couple of autotests, which still 
suggests something wrong.
  
  i think it's getting near feature completness to implement the kwin part tough

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart updated this revision to Diff 18596.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - Don't call release twice
  - Correctly set
  - don't call destroy in the destroyed callback
  - add a test exporting a surface two times
  - test importing two times the same surface
  - wrap XdgForeignUnstableV1 to XdgForeignUnstable
  - unexport classes that should be private

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7369?vs=18357&id=18596

BRANCH
  mart/xdgforeign

REVISION DETAIL
  https://phabricator.kde.org/D7369

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_foreign.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-foreign-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgforeign.cpp
  src/client/xdgforeign.h
  src/client/xdgforeign_p.h
  src/client/xdgforeign_v1.cpp
  src/client/xdgforeign_v1.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgforeign_interface.cpp
  src/server/xdgforeign_interface.h
  src/server/xdgforeign_v1_interface.cpp
  src/server/xdgforeign_v1_interface_p.h

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7485: StreamRestore: Always set channel count to 1

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:792248092d25: StreamRestore: Always set channel count to 
1 (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7485?vs=18594&id=18597

REVISION DETAIL
  https://phabricator.kde.org/D7485

AFFECTED FILES
  src/streamrestore.cpp
  src/streamrestore.h

To: drosca, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7485: StreamRestore: Always set channel count to 1

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7485

To: drosca, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7485: StreamRestore: Always set channel count to 1

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is what pavucontrol is doing too.
  
  BUG: 383787
  FIXED-IN: 5.11

TEST PLAN
  Works for me (but it worked also before)

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7485

AFFECTED FILES
  src/streamrestore.cpp
  src/streamrestore.h

To: drosca, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7481: RFC: Batch window changes events on XCB

[Eike Hein]

hein added a comment.


  In https://phabricator.kde.org/D7481#138817, @davidedmundson wrote:
  
  > We don't want it for Wayland.
  >
  > Surfaces are double buffered so all synced. We don't fully do that on the 
XDG side, but most of that is static anyway
  
  
  Can you explain that more? The reason the old lib did this and the reason I'm 
aware of for wanting this is to prevent the TM being ddos'd by a rogue window 
updating its title thousands of times per second. How are we protected from 
this on Wayland currently?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[Thomas Lübking]

luebking added a comment.


  Pretty uninformed consideration:
  When dealing with X11/wayland hybrids, won't one end up with two property 
indexes which are hard -if not impossible- to align (because one will be 
assigned by kwin internally and the other by the casual xwayland server)?
  Might the xwayland property even change over the runtime of kwin (is the 
xwayland server conditionally removed)?
  
  Would it in this case not be required to abstract the property query with a 
mapper in general (or abort x11 properties and always ask kwin via dbus resp. 
the effects API for a purely internally kept property)?
  
  Random sidenote:
  registerPropertyType() has a hash trap (unregistering a non-existing atom 
will insert it forever)

REPOSITORY
  R108 KWin

BRANCH
  effects-announce-support-property-no-x11

REVISION DETAIL
  https://phabricator.kde.org/D7475

To: graesslin, #kwin, #plasma, davidedmundson
Cc: luebking, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D7155: Implement sorting of the device tree items

[Christoph Feck]

cfeck requested changes to this revision.
cfeck added a comment.
This revision now requires changes to proceed.


  Isaac, do you want to work on the requested changes?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7155

To: isaact, #plasma, cfeck
Cc: cfeck, broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7481: RFC: Batch window changes events on XCB

[Kai Uwe Broulik]

broulik added a comment.


  > Theproblem here is Firefox: that one should be fixed.
  
  I can also cause trouble with VLC if I have a repeating playlist with a 
broken file in it, it will continuously cycle between "$title" and "VLC" and 
cause Plasma to freeze. We can't fix all apps…

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7481: RFC: Batch window changes events on XCB

[David Edmundson]

davidedmundson added a comment.


  We don't want it for Wayland.
  
  Surfaces are double buffered so all synced. We don't fully do that on the XDG 
side, but most of that is static anyway

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7481: RFC: Batch window changes events on XCB

[Eike Hein]

hein added a comment.


  I'm in general for this. It's listed in the TODO file as one of the remaining 
open tasks for the lib, as the old lib did this but it got dropped along the 
way.
  
  However, I would like it to be implemented as a proxy pass (e.g. in 
WindowTasksModel) so it can be shared between X11 and Wayland instead of being 
implemented redundantly or encumbering that code, and so it's easy to disable 
when debugging something and having to reason about the code.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[Eike Hein]

hein added a comment.


  This was done intentionally in the past to allow people to pick random images 
and get the proper kind of URL back to feed into the Image (which isn't used 
anymore). Can you verify this workflow still works?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  effects-announce-support-property-no-x11

REVISION DETAIL
  https://phabricator.kde.org/D7475

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7481: RFC: Batch window changes events on XCB

[Martin Flöser]

graesslin added a comment.


  In general I'm against this as we would also need the same in KWin and every 
other user. Theproblem here is Firefox: that one should be fixed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7483: Get rid of warnings about setting both pixel and point sizes

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Without this patch, the QML engine complains that both pixel and point sizes 
are being set, and that it will fall back (correctly, but noisily) to the pixel 
size. This patch results in the same behaviour, but without complaints from the 
engine.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D7483

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml

To: leinir, #kirigami, mart
Cc: plasma-devel, apol, mart

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D7475#138747, @davidedmundson wrote:
  
  > I assume this is all to make xwayland socket activated so 
X11ConnectionChanged will come later.
  
  
  Also. First of all I'm interested in being able to start without X support.
  
  > You're going out of your way to make sure we when we do get an X11 
connection  we register any atoms that had previously called 
announceSupportProperty. Which is great, except it won't work for:
  >  SlidingPopups, KScreen, PresentWindows which all cache the first returned 
atom by this method.
  
  See the description: I'm aware of it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7475

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7482: Automatic scaling selection

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The generator code is run by the KDED when we don't have a profile for a
  monitor setup.
  
  If we don't have a config this sets the screen scaling to 2 when it has
  an DPI > 1.5*normal DPI. The vertical resolution is also checked that it
  matches what you'd find on a high resolution screen to hopefully avoid
  issues with bogus EDID.
  
  We may need to tweak this heuristic based on feedback, especially when
  want to support fractional scaling.

TEST PLAN
  Removed configs.
  Rebooted
  Laptop screen looked like it should.
  Normal screen was 1x

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7482

AFFECTED FILES
  kded/generator.cpp
  kded/generator.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7481: RFC: Batch window changes events on XCB

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In a log from someone talking about high CPU we can see get multiple X
  events for the same window as multiple events, but directly next to each
  other. This causes the TaskManager to process changes multiple times
  instead of just once which is a waste.
  
  I can see this switching tabs in Firefox it gives me the icon updating
  twice. Ideally we only want to have one change go through the model.
  
  This class sits between KWindowSystem and XWindowTasksModel
  transparently buffering the changes.
  
  I'm not super attached to the idea of adding hacks like this, so this is
  as much a RFC as anything.  (it's not the root cause of the issue in the
  bug report)
  
  Also the delay could probably be 0, because that will at least mean we
  read all the pending window system events before proceeding which is all
  I really want.
  
  CCBUG: 378010

TEST PLAN
  I wrote this in April and can't remember why I didn't push it. 
  I'm worried that I might have had a really important reason that I've since 
forgotten...or maybe I just got distracted and forgot.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  pending_queue

REVISION DETAIL
  https://phabricator.kde.org/D7481

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/xwindowsystemeventbatcher.cpp
  libtaskmanager/xwindowsystemeventbatcher.h
  libtaskmanager/xwindowtasksmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[David Edmundson]

davidedmundson added a comment.


  I assume this is all to make xwayland socket activated so 
X11ConnectionChanged will come later.
  
  You're going out of your way to make sure we when we do get an X11 connection 
 we register any atoms that had previously called announceSupportProperty. 
Which is great, except it won't work for:
  SlidingPopups, KScreen, PresentWindows which all cache the first returned 
atom by this method.
  
  They'll need updating to either monitor the x11ConnectionChanged signal 
themselves or to just not cache the atoms themselves.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7475

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7474: Remove hard X11 runtime dependency from DBusInterface

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  dbus-interface-no-x11-dependency

REVISION DETAIL
  https://phabricator.kde.org/D7474

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7476: [Recent Documents Runner] Avoid duplicate results

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 381665

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7476

AFFECTED FILES
  runners/recentdocuments/recentdocuments.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  announceSupportProperty is called from the effects on startup. It
  registers the property on the X11 root window. If we would start
  kwin_wayland without XWayland support this would result in a crash.
  
  This change refactors the code so that it still registers the property,
  but does not try to interact with X11. Once X11 support is available it
  does the actual registering.
  
  But this means that the effects get an incorrect atom returned. This
  needs additional changes. E.g. they could also react to the
  x11ConnectionChanged and register again, then they would get the proper
  atom. This would also support restart of XWayland.

REPOSITORY
  R108 KWin

BRANCH
  effects-announce-support-property-no-x11

REVISION DETAIL
  https://phabricator.kde.org/D7475

AFFECTED FILES
  effects.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7474: Remove hard X11 runtime dependency from DBusInterface

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  KWin's DBusInterface announces the service name on an X11 root window
  property. For this it requires a runtime dependency on X11. If we would
  try to start kwin_wayland without XWayland support this would result in
  a crash.
  
  This change turns the dependency into an optional one by checking
  whether the KWin::Application has support for X11 and registers a
  connection to announce the property as soon as a connection is
  established. Thus it even supports the restart of XWayland now.

TEST PLAN
  Compiles

REPOSITORY
  R108 KWin

BRANCH
  dbus-interface-no-x11-dependency

REVISION DETAIL
  https://phabricator.kde.org/D7474

AFFECTED FILES
  dbusinterface.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7472: Don't elide UserDelegate text when there's only one item

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f7cf3c2a68e6: Don't elide UserDelegate text when there's 
only one item (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7472?vs=18572&id=18576

REVISION DETAIL
  https://phabricator.kde.org/D7472

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/components/UserList.qml
  lookandfeel/contents/logout/Logout.qml

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7473: Remove pointless data copy in lockscreen delegate

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cc8647481095: Remove pointless data copy in lockscreen 
delegate (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7473?vs=18571&id=18575

REVISION DETAIL
  https://phabricator.kde.org/D7473

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

[David Edmundson]

davidedmundson added a comment.


  I'm still against it.
  Passing unexpectedly invalid pointers about all over the place and then 
trying to guard them afterwards is an anti pattern that leads to future 
problems.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7078

To: graesslin, #kwin, #plasma, #frameworks
Cc: cfeck, anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ConfigGeneral.qml:26
> this shouldn't be used in a config module.
> 
> Use QtQuick.Controls 1.x instead

That's fine. Fwict this code is from Kickoff and there we have a QQC Button for 
the icon which inside has a Plasma panel SVG background and IconItem on top, so 
you get a "live preview" of how it looks with your current Plasma theme. We do 
not end up with white icon on white background.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7472: Don't elide UserDelegate text when there's only one item

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7472

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7473: Remove pointless data copy in lockscreen delegate

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7473

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7472: Don't elide UserDelegate text when there's only one item

[David Edmundson]

davidedmundson updated this revision to Diff 18572.
davidedmundson added a comment.


  Comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7472?vs=18570&id=18572

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7472

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/components/UserList.qml
  lookandfeel/contents/logout/Logout.qml

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7472: Don't elide UserDelegate text when there's only one item

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in UserDelegate.qml:141
> We could also just disable eliding and it will overflow?

Yes, but it would overflow to the right not over the centre.
And if I change the anchor to centre, then I need to set a width.

I could do width: parent.width  and then put the ? : on elide. 
But it amounts to the same.

> broulik wrote in UserList.qml:83
> :D

Fricking arc. I definitely didn't stage that hunk. Then it kindly goes and adds 
them back thinking you've accidentally missed them.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7472

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7472: Don't elide UserDelegate text when there's only one item

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> UserDelegate.qml:141
>  text: wrapper.name
>  elide: Text.ElideRight
>  horizontalAlignment: Text.AlignHCenter

We could also just disable eliding and it will overflow?

> UserList.qml:80
> +//if we only have one delegate, we don't need to clip the text as it 
> won't be overlapping with anything
> +constrainText: ListView.view.contentWidth > userItemWidth
> +

Just out of curiosity: why not `count`?

> UserList.qml:83
> +Component.onCompleted: {
> +  console.log("DAVE", ListView.view.children)
> +}

:D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7472

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

[Martin Flöser]

graesslin added a comment.


  I'm still in favor of pushing this one too.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7078

To: graesslin, #kwin, #plasma, #frameworks
Cc: cfeck, anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7473: Remove pointless data copy in lockscreen delegate

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Not sure what I was thinking when I wrote it.

TEST PLAN
  Grepped m is not used in file.
  Grepped it's not used in any other users of the delegate

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7473

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7472: Don't elide UserDelegate text when there's only one item

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In the lock screen the user delegate has to elide the text when there
  are multiple items next to each other, otherwise it will overlap.
  
  When there's only one item (which is quite common) we don't need to 
  and doing so looks weird.

TEST PLAN
  Modified SDDM dummydata/userModel to have one entry with a long name
  and back to multiple entries.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7472

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/components/UserList.qml
  lookandfeel/contents/logout/Logout.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ConfigGeneral.qml:26
> +import org.kde.plasma.core 2.0 as PlasmaCore
> +import org.kde.plasma.components 2.0 as PlasmaComponents
> +

this shouldn't be used in a config module.

Use QtQuick.Controls 1.x instead

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7469

To: dvratil, #plasma
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas