D7715: [Plasma Components 3] Fix RTL in some widgets.

2017-09-09 Thread Safa Alfulaij 
safaalfulaij added a comment.


  It seems that the `TabBar`'s problem is an upstream issue with `ListView` and 
highlighting animation.
  Will report about it soon.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7715

To: safaalfulaij, #plasma, #frameworks, mart
Cc: mart, broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D7715: [Plasma Components 3] Fix RTL in some widgets.

2017-09-09 Thread Safa Alfulaij 
safaalfulaij retitled this revision from "[WIP] Fix RTL in some 
plasmacomponents3 widgets." to "[Plasma Components 3] Fix RTL in some widgets.".

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7715

To: safaalfulaij, #plasma, #frameworks, mart
Cc: mart, broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Breeze] [Bug 384514] Toolbar Segmented Controls do not visually communicate their grouping

2017-09-09 Thread Sebastian Kügler 
https://bugs.kde.org/show_bug.cgi?id=384514

Sebastian Kügler  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7749: Header as one ToolButton for Back action

2017-09-09 Thread Roman Gilg 
subdiff created this revision.
subdiff added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In order to have consistent feedback, create the back button and label as one 
ToolButton.
  
  Before:
  F3904502: Screenshot_20170909_182022.png 

  After:
  F3904501: Screenshot_20170909_181943.png 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D7749

AFFECTED FILES
  sidebar/package/contents/ui/SubCategoryPage.qml

To: subdiff, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D2754: Touchpad KDED: fix metadata warning

2017-09-09 Thread Albert Astals Cid 
aacid added a comment.


  I can try having a look, not a mega expert myself though

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

To: knambiar, #plasma, davidedmundson, mart, aacid
Cc: aacid, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 384514] Toolbar Segmented Controls do not visually communicate their grouping

2017-09-09 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=384514

Nate Graham  changed:

   What|Removed |Added

Summary|Pushbuttons, Toggle |Toolbar Segmented Controls
   |Buttons, and Segmented  |do not visually communicate
   |Controls look nearly or |their grouping
   |actually identical to one   |
   |another |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384514] Pushbuttons, Toggle Buttons, and Segmented Controls look nearly or actually identical to one another

2017-09-09 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=384514

--- Comment #5 from Nate Graham  ---
Created attachment 107772
  --> https://bugs.kde.org/attachment.cgi?id=107772=edit
Real segmented control elsewhere in Gwenview

Since making un-pushed toggle buttons visually distinct from pushbuttons
appears to be more controversial, I'll drop that for now and focus on segmented
controls. Not having a dedicated segmented control concept/UI element is a
major problem. But I see that in Gwenview, we actually do use a button-based
segmented control elsewhere: https://i.imgur.com/pySdLn0.png

Other than the padding issues with text on the middle button, this is ideal,
and clearly communicates at-a-glance the concept that only one of those three
states can be chosen at once. We might consider using this instead, or even
standardizing it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

2017-09-09 Thread Marco Martin 
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> safaalfulaij wrote in ProgressBar.qml:33
> Actually, it’s used in default QQC2 styling and I just stole it from there..
> http://code.qt.io/cgit/qt/qtquickcontrols2.git/tree/src/imports/controls/Slider.qml#n78

I think it's fine

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7715

To: safaalfulaij, #plasma, #frameworks, mart
Cc: mart, broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-09-09 Thread Jay Turner 
jayturner updated this revision to Diff 19334.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7747?vs=19333=19334

REVISION DETAIL
  https://phabricator.kde.org/D7747

AFFECTED FILES
  applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml
  applets/fuzzy-clock/package/contents/ui/configAppearance.qml

To: jayturner
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-09-09 Thread Jay Turner 
jayturner added a comment.


  In https://phabricator.kde.org/D7747#144226, @davidedmundson wrote:
  
  > We can't use words from a trademark in KDE code though. It'll be"kandalf" 
all over again.
  
  
  Arguably 'hobbit' existed before JRR Tolkien, and none of the other words are 
trademarked as far as I'm aware. We can change 'hobbitTime' to 'kobbitTime' or 
'shortPeopleTime' :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D7747

To: jayturner
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-09-09 Thread David Edmundson 
davidedmundson added a comment.


  Given fuzzy time is already a "silly" feature I think this is ok.
  
  We can't use words from a trademark in KDE code though. It'll be"kandalf" all 
over again.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D7747

To: jayturner
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-09-09 Thread Jay Turner 
jayturner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Not 100% serious, a fun little extension for Hobbits.
  
  If you wanted to eat like a hobbit you would have these meals:
  Breakfast - 7am.
  Second breakfast - 9 am.
  Elevenses - 11 am.
  Lunch - 1 pm.
  Afternoon tea - 3pm.
  Dinner - 6 pm.
  Supper - 9 pm.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D7747

AFFECTED FILES
  applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml
  applets/fuzzy-clock/package/contents/ui/configAppearance.qml

To: jayturner
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[Breeze] [Bug 384514] Pushbuttons, Toggle Buttons, and Segmented Controls look nearly or actually identical to one another

2017-09-09 Thread Roman Gilg 
https://bugs.kde.org/show_bug.cgi?id=384514

Roman Gilg  changed:

   What|Removed |Added

 CC||subd...@gmail.com

--- Comment #4 from Roman Gilg  ---
Our toolbar buttons are arbitrarily placeable. The "segmented controls" are in
reality two separate toggle buttons. But when NOT being in active state a
toggle button shouldn't be visually different from a push button, since on its
own its type of action is no different than that of a push button (triggering
something).

The right way under the constraints of toolbar buttons being arbitrarily
placeable is to separate "segmented controls" from other ones by using
separators. Indeed my Gwenview does it this way in the default toolbar
configuration.

But it's not optimal since it can look somewhat weird with many separators.
Maybe we could think of a mechanism to check if toggle buttons with mutually
exclusive functionality are sitting next to each other and in this case paint
your proposed frame around them instead of having the app developers/user use
separators all other the place. Would be a bigger change in code though and I
don't know if it's possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6591: XdgV6 - Kwin side

2017-09-09 Thread Martin Flöser 
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mart wrote in shell_client.cpp:608-609
> the close is actually beaing done at line 244: at the pongReceived (if the 
> ping reason was closewindow, then it closes it there)

That logic I don't understand: why do we ping to close? Why a roundtrip to the 
app, when all we want to do is close it? Just send it a close?

> shell_client.cpp:894-898
> +if (m_xdgShellSurface && rules()->checkAcceptFocus(wantsInput())) {
> +const qint32 pingSerial = static_cast *>(m_xdgShellSurface->global())->ping(m_xdgShellSurface);
> +m_pingSerials.insert(pingSerial, FocusWindow);
>  setActive(true);
>  }

This breaks the existing code: the setActive(true) is now only done for xdg 
shell surfaces, not for wl_shell surfaces.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6591

To: davidedmundson, #plasma, graesslin, mart
Cc: mart, graesslin, kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol