D7831: Use a different key for font DPI on X and Wayland

2017-09-15 Thread Eike Hein 
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  randa/accessibility

REVISION DETAIL
  https://phabricator.kde.org/D7831

To: davidedmundson, #plasma, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7830: Use a separate config value for Wayland font DPI

2017-09-15 Thread Eike Hein 
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  randa/accessibility

REVISION DETAIL
  https://phabricator.kde.org/D7830

To: davidedmundson, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7831: Use a different key for font DPI on X and Wayland

2017-09-15 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fbbdfa100128: Use a different key for font DPI on X and 
Wayland (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7831?vs=19546&id=19550

REVISION DETAIL
  https://phabricator.kde.org/D7831

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: davidedmundson, #plasma, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7830: Use a separate config value for Wayland font DPI

2017-09-15 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:abf54a0a8c44: Use a separate config value for Wayland 
font DPI (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7830?vs=19545&id=19551#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7830?vs=19545&id=19551

REVISION DETAIL
  https://phabricator.kde.org/D7830

AFFECTED FILES
  startkde/startplasmacompositor.cmake

To: davidedmundson, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7834: Sync XRDB DPI to the platform specific setting

2017-09-15 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Even though this sets up the X rdb, we want to use the value the
  user has set to use when under wayland - as X apps will be scaled by the
  compositor.
  
  This ensures when I open firefox on my X or Wayland session it's the
  same size.
  
  Colors KCM part is needed as it includes ../krdb/krdb.cpp

TEST PLAN
  Logged in on X with my normal settings, opened Firefox
  Logged in on Wayland with my normal settings, opened Firefox
  
  Same size on both

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7834

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/krdb/krdb.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7835: Don't show scrollbar steppers

2017-09-15 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  They were re-added in commit 
https://phabricator.kde.org/R98:01a86601804222929441c0c1c8bb0db6d4ee2769 
without explaining why (we don't
  have steppers in breeze-qt scrollbars).

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D7835

AFFECTED FILES
  Breeze-gtk/gtk-3.20/gtk.css

To: elvisangelaccio, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7835: Don't show scrollbar steppers

2017-09-15 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  Before:
  
  F3911870: Before.png 
  
  After:
  
  F3911872: After.png 

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D7835

To: elvisangelaccio, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7836: Fix background-image warning

2017-09-15 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This fixes the following warning:
  
Gtk-WARNING **: Theme parsing error: gtk.css:3139:22: Not a valid image
  
  It was changed by commit 
https://phabricator.kde.org/R98:01a86601804222929441c0c1c8bb0db6d4ee2769 but 
the change is not in https://phabricator.kde.org/D6688 (so
  it looks like a copy-paste error while pushing the revision).

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D7836

AFFECTED FILES
  Breeze-gtk/gtk-3.20/gtk.css

To: elvisangelaccio, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7834: Sync XRDB DPI to the platform specific setting

2017-09-15 Thread Martin Flöser 
graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7834

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7834: Sync XRDB DPI to the platform specific setting

2017-09-15 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b47a841f6f9b: Sync XRDB DPI to the platform specific 
setting (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7834?vs=19554&id=19567

REVISION DETAIL
  https://phabricator.kde.org/D7834

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/krdb/krdb.cpp

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread Martin Flöser 
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  This change introduces a dedicated X11EventFilter for the mouse
  interception on X11. The filter gets created together with the start
  of mouse interception and destroyed again when the mouse interception
  ends. Thus we don't need to check for each event like it was the case
  so far.
  
  Unfortunately the existing methods cannot be removed (yet) as they are
  still used by TabBox. Needs investigation whether this is actually
  needed.

TEST PLAN
  Xephyr+kwin_x11+Present Windows

REPOSITORY
  R108 KWin

BRANCH
  effects-mouse-x11-filter

REVISION DETAIL
  https://phabricator.kde.org/D7842

AFFECTED FILES
  CMakeLists.txt
  effects.cpp
  effects.h
  effects_mouse_interception_x11_filter.cpp
  effects_mouse_interception_x11_filter.h
  events.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread David Edmundson 
davidedmundson added a comment.


  Code does what it says but one comment
  
  1. I would move the m_mouseInterceptionWindow  code with it, that way we have 
RAII on that window, and less X specific things in the EffectsHandler. 
Logically it's grouped
  2. do we even need that fake window given we now have the XI filter?

INLINE COMMENTS

> effects.cpp:707
>  if (kwinApp()->operationMode() != Application::OperationModeX11) {
>  input()->pointer()->removeEffectsOverrideCursor();
>  return;

I know this is the wrong patch to comment on this, but it seems this wayland 
code is wrong.

we setEffectsOverrideCursor() when the effects count goes to 1
we should ony be removing it when it goes to 0.

i.e this should be inside m_grabbedMouseEffects.isEmpty()

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7842

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread Martin Flöser 
graesslin added a comment.


  In https://phabricator.kde.org/D7842#146171, @davidedmundson wrote:
  
  > Code does what it says but one comment
  >
  > 1. I would move the m_mouseInterceptionWindow  code with it, that way we 
have RAII on that window, and less X specific things in the EffectsHandler. 
Logically it's grouped
  
  
  I looked into it as I also thought it's a good idea. But it's not that easy, 
it is used in more areas than just for the mouse motion. It's used in e.g. 
EffectsHandler::defineCursor, EffectsHandler::desktopResized and a few more.
  
  I agree this should be moved out, but I think this needs more work and 
probably a class X11EffectsHandler : public EffectsHandlerImpl together with an 
API hook in the Platform API
  
  > 2. do we even need that fake window given we now have the XI filter?
  
  Yes, otherwise the mouse events would go to the windows below which would be 
urgh ;-) and also needed for setting the cursor shape.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7842

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7843: Move XFixes cursor change tracking into the x11 standalone platform

2017-09-15 Thread Martin Flöser 
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  A dedicated X11EventFilter is added and created from the X11Cursor in
  case we have XFixes. This means some more X11 specific code is now only
  on X11.

TEST PLAN
  Only compile tested.

REPOSITORY
  R108 KWin

BRANCH
  xfixes-cursor-filter

REVISION DETAIL
  https://phabricator.kde.org/D7843

AFFECTED FILES
  cursor.cpp
  cursor.h
  events.cpp
  plugins/platforms/x11/standalone/CMakeLists.txt
  plugins/platforms/x11/standalone/x11cursor.cpp
  plugins/platforms/x11/standalone/x11cursor.h
  plugins/platforms/x11/standalone/xfixes_cursor_event_filter.cpp
  plugins/platforms/x11/standalone/xfixes_cursor_event_filter.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

New widgets to plasma

2017-09-15 Thread Martin Kostolný 
Hi,

I'd like to add some of my widgets to official widget bundle in plasma. Namely:
- redshift-control (https://github.com/kotelnik/plasma-applet-redshift-control)
- active-window-control 
(https://github.com/kotelnik/plasma-applet-active-window-control)
(maybe other if it makes sense)

I realize that they have issues:
- redshift-control is Xorg only and I know that we don't want to add new 
xorg-only stuff
- awc has awfully complicated settings (I'll improve that eventually, but it 
will still be very configurable)

There were some requests from users of various distributions to add these 
widgets as official projects. This would allow them to reach more distros -> 
users.

So my question is - is it a good idea to add them to standard plasma widgets? 
Or does it make more sense to just make them official KDE but completely 
separate single projects? The latter was my initial intention but I was asked 
in incubation request if I queried you guys first, so here I am :-). I will 
also be ok with "no-adding-at-all" answer.

Anyway, thanks for all the great work you do!
Martin

Re: New widgets to plasma

2017-09-15 Thread David Edmundson 
Cool widgets, I've heard some users using them - Thanks for helping build
the Plasma base.

>There were some requests from users of various distributions to add these
widgets as official projects. This would allow them to reach more distros
-> users.

I think that's a problem in itself. The whole base of Plasma is about the
extensibility of 3rd parties, and yet ultimately we hit this every time.

In general I want to break down that perception of everything having to be
"official". Especially as ultimately it ends up with  us being burdened
with being expected to maintain (and in a few years port) a million billion
things.

Also, I do want us (upstream Plasma) to get into a better habbit of writing
proper public API QtQuick imports. Your active window control would be
easier for you to distribute if that wasn't for that C++ libdbusmenu-qt
plugin.
Separate to this discussion, lets fix that regardless.

---

That said, as for your things specifically:

The code's good. I'd love for you to join us as a Plasma dev :)

I think they're maybe too niche for plasma-desktop/plasma-workspace.
Especially the redshift.
but putting them in extragear (either as your separate projects or in
kdeplasma-addons), would be fine with me.

David

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  ok.
  
  Also note that I made a comment about the (untouched) wayland code.

REPOSITORY
  R108 KWin

BRANCH
  effects-mouse-x11-filter

REVISION DETAIL
  https://phabricator.kde.org/D7842

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread Martin Flöser 
graesslin added a comment.


  In https://phabricator.kde.org/D7842#146206, @davidedmundson wrote:
  
  > ok.
  >
  > Also note that I made a comment about the (untouched) wayland code.
  
  
  thanks for the hint, I hadn't noticed it before. Yeah, looks wrong, I guess 
it evolved or something like that ;-)

REPOSITORY
  R108 KWin

BRANCH
  effects-mouse-x11-filter

REVISION DETAIL
  https://phabricator.kde.org/D7842

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

Re: New widgets to plasma

2017-09-15 Thread Martin Kostolný 
Thanks, David, for quick answer.

I agree basically with everything you said.

My aim is to keep up with Plasma versioning and it would be really helpful for 
me not to support multiple versions of Plasma with latest version of widget. 
That is why I find perfect to join kdeplasma-addons. Actually I thought that 
this is already being in core Plasma since kdeplasma-addons carries Plasma 
version.

Being official just for the sake of it was not my intention. It is true that it 
would just add more burden for Plasma devs. Of course I intend to maintain 
added widgets.

I'm still not very familiar with developing Plasma datasources, but I try to 
investigate ways of integrating libdbusmenu as a datasource.

Thanks for inviting me to being Plasma dev. I'd like to join, but I don't know 
what that actually means. I like to help with various stuff but I have (for 
now) non-regular limited time - some evenings, some weekends etc.

Best Regards,
Martin

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread Martin Flöser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:0c6fdeef2db4: Split out the X11 mouse event filtering for 
EffectsHandlerImpl (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7842?vs=19571&id=19579

REVISION DETAIL
  https://phabricator.kde.org/D7842

AFFECTED FILES
  CMakeLists.txt
  effects.cpp
  effects.h
  effects_mouse_interception_x11_filter.cpp
  effects_mouse_interception_x11_filter.h
  events.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7845: Fix position where removeEffectsOverrideCursor is called

2017-09-15 Thread Martin Flöser 
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Should be when there is no more an effect which overrides the cursor,
  not unconditionally.

REPOSITORY
  R108 KWin

BRANCH
  effects-remove-override-cursor-position

REVISION DETAIL
  https://phabricator.kde.org/D7845

AFFECTED FILES
  effects.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart