date:20170927

D8009: [Containment Interface] Don't add containment actions to applet actions on desktop

2017-09-27 Thread Eike Hein

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8009

To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8008: [Folder View] Turn MenuHelper into a singleton type

2017-09-27 Thread Eike Hein

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8008

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7999: Drop workaround for QQC1 QGuiApplication crashes

2017-09-27 Thread Antonio Rojas

arojas added a comment.


  Actually I can't reproduce the QQC1 crashes anymore, even with 
QT_QUICK_CONTROLS_1_STYLE set to Desktop

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7999

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7939: ColorSet concept in Theme

2017-09-27 Thread Marco Martin

mart updated this revision to Diff 20006.
mart added a comment.


  - remove binary file
  - give focus on press by default

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7939?vs=20005&id=20006

BRANCH
  mart/colorcontext

REVISION DETAIL
  https://phabricator.kde.org/D7939

AFFECTED FILES
  CMakeLists.txt
  KF5Kirigami2Config.cmake.in
  KF5Kirigami2Macros.cmake
  autotests/tst_keynavigation.qml
  autotests/tst_listskeynavigation.qml
  autotests/tst_pagerow.qml
  examples/applicationitemapp/main.qml
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/DesktopExampleApp.qml
  examples/gallerydata/contents/ui/ExampleApp.qml
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/ButtonGallery.qml
  examples/gallerydata/contents/ui/gallery/CheckBoxGallery.qml
  examples/gallerydata/contents/ui/gallery/ColorSetGallery.qml
  examples/gallerydata/contents/ui/gallery/ColorsGallery.qml
  examples/gallerydata/contents/ui/gallery/LayersGallery.qml
  examples/gallerydata/contents/ui/gallery/ListViewGallery.qml
  examples/gallerydata/contents/ui/gallery/ListViewHeaderItemsGallery.qml
  examples/gallerydata/contents/ui/gallery/MetricsGallery.qml
  examples/gallerydata/contents/ui/gallery/MiscGallery.qml
  examples/gallerydata/contents/ui/gallery/MultipleColumnsGallery.qml
  examples/gallerydata/contents/ui/gallery/NonScrollableGallery.qml
  examples/gallerydata/contents/ui/gallery/ProgressBarGallery.qml
  examples/gallerydata/contents/ui/gallery/RadioButtonGallery.qml
  examples/gallerydata/contents/ui/gallery/SliderGallery.qml
  examples/gallerydata/contents/ui/gallery/SwitchGallery.qml
  examples/gallerydata/contents/ui/gallery/TabBarGallery.qml
  examples/gallerydata/contents/ui/gallery/TextFieldGallery.qml
  examples/minimalqmake/Page1Form.ui.qml
  examples/minimalqmake/kirigami-icons.qrc
  examples/minimalqmake/main.qml
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/SplitDrawer.qml
  examples/simpleexamples/TabBarHeader.qml
  examples/simpleexamples/customdrawer.qml
  examples/simpleexamples/minimal.qml
  examples/simpleexamples/pushpopclear.qml
  examples/simpleexamples/simpleChatApp.qml
  src/CMakeLists.txt
  src/controls/AbstractApplicationHeader.qml
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/AbstractItemViewHeader.qml
  src/controls/ApplicationItem.qml
  src/controls/ApplicationWindow.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Icon.qml
  src/controls/ItemViewHeader.qml
  src/controls/Label.qml
  src/controls/OverlayDrawer.qml
  src/controls/OverlaySheet.qml
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/ScrollablePage.qml
  src/controls/Separator.qml
  src/controls/Theme.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/Units.qml
  src/controls/plugins.qmltypes
  src/controls/private/ActionButton.qml
  src/controls/private/CornerShadow.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/private/EdgeShadow.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/private/SwipeItemEventFilter.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractListItem.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/private/ScrollView.qml
  src/desktopicon.cpp
  src/desktopicon.h
  src/kirigamiplugin.cpp
  src/libkirigami/CMakeLists.txt
  src/libkirigami/basictheme.cpp
  src/libkirigami/basictheme_p.h
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h
  src/libkirigami/platformthemefactory.cpp
  src/libkirigami/platformthemefactory.h
  src/styles/Material/AbstractListItem.qml
  src/styles/Material/Label.qml
  src/styles/Material/SwipeListItem.qml
  src/styles/Material/Theme.qml
  src/styles/Plasma/Icon.qml
  src/styles/Plasma/Theme.qml
  src/styles/org.kde.desktop/AbstractApplicationHeader.qml
  src/styles/org.kde.desktop/AbstractListItem.qml
  src/styles/org.kde.desktop/ApplicationWindow.qml
  src/styles/org.kde.desktop/OverlayDrawer.qml
  src/styles/org.kde.desktop/SwipeListItem.qml
  src/styles/org.kde.desktop/Theme.qml
  tests/KeyboardListTest.qml
  tests/KeyboardTest.qml

To: mart, #kirigami, hein
Cc: plasma-devel, apol, davidedmundson, mart, hein

D7939: ColorSet concept in Theme

2017-09-27 Thread Marco Martin

mart updated this revision to Diff 20005.
mart added a comment.


  - Merge branch 'master' into mart/colorcontext
  - add a rangeslider to the gallery
  - some comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7939?vs=19797&id=20005

BRANCH
  mart/colorcontext

REVISION DETAIL
  https://phabricator.kde.org/D7939

AFFECTED FILES
  CMakeLists.txt
  KF5Kirigami2Config.cmake.in
  KF5Kirigami2Macros.cmake
  autotests/tst_keynavigation.qml
  autotests/tst_listskeynavigation.qml
  autotests/tst_pagerow.qml
  examples/applicationitemapp/main.qml
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/DesktopExampleApp.qml
  examples/gallerydata/contents/ui/ExampleApp.qml
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/ButtonGallery.qml
  examples/gallerydata/contents/ui/gallery/CheckBoxGallery.qml
  examples/gallerydata/contents/ui/gallery/ColorSetGallery.qml
  examples/gallerydata/contents/ui/gallery/ColorsGallery.qml
  examples/gallerydata/contents/ui/gallery/LayersGallery.qml
  examples/gallerydata/contents/ui/gallery/ListViewGallery.qml
  examples/gallerydata/contents/ui/gallery/ListViewHeaderItemsGallery.qml
  examples/gallerydata/contents/ui/gallery/MetricsGallery.qml
  examples/gallerydata/contents/ui/gallery/MiscGallery.qml
  examples/gallerydata/contents/ui/gallery/MultipleColumnsGallery.qml
  examples/gallerydata/contents/ui/gallery/NonScrollableGallery.qml
  examples/gallerydata/contents/ui/gallery/ProgressBarGallery.qml
  examples/gallerydata/contents/ui/gallery/RadioButtonGallery.qml
  examples/gallerydata/contents/ui/gallery/SliderGallery.qml
  examples/gallerydata/contents/ui/gallery/SwitchGallery.qml
  examples/gallerydata/contents/ui/gallery/TabBarGallery.qml
  examples/gallerydata/contents/ui/gallery/TextFieldGallery.qml
  examples/minimalqmake/Page1Form.ui.qml
  examples/minimalqmake/kirigami-icons.qrc
  examples/minimalqmake/main.qml
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/SplitDrawer.qml
  examples/simpleexamples/TabBarHeader.qml
  examples/simpleexamples/customdrawer.qml
  examples/simpleexamples/minimal.qml
  examples/simpleexamples/pushpopclear.qml
  examples/simpleexamples/simpleChatApp.qml
  src/CMakeLists.txt
  src/controls/AbstractApplicationHeader.qml
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/AbstractApplicationWindow.qmlc
  src/controls/AbstractItemViewHeader.qml
  src/controls/ApplicationItem.qml
  src/controls/ApplicationWindow.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Icon.qml
  src/controls/ItemViewHeader.qml
  src/controls/Label.qml
  src/controls/OverlayDrawer.qml
  src/controls/OverlaySheet.qml
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/ScrollablePage.qml
  src/controls/Separator.qml
  src/controls/Theme.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/Units.qml
  src/controls/plugins.qmltypes
  src/controls/private/ActionButton.qml
  src/controls/private/CornerShadow.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/private/EdgeShadow.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/private/SwipeItemEventFilter.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractListItem.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/private/ScrollView.qml
  src/desktopicon.cpp
  src/desktopicon.h
  src/kirigamiplugin.cpp
  src/libkirigami/CMakeLists.txt
  src/libkirigami/basictheme.cpp
  src/libkirigami/basictheme_p.h
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h
  src/libkirigami/platformthemefactory.cpp
  src/libkirigami/platformthemefactory.h
  src/styles/Material/AbstractListItem.qml
  src/styles/Material/Label.qml
  src/styles/Material/SwipeListItem.qml
  src/styles/Material/Theme.qml
  src/styles/Plasma/Icon.qml
  src/styles/Plasma/Theme.qml
  src/styles/org.kde.desktop/AbstractApplicationHeader.qml
  src/styles/org.kde.desktop/AbstractListItem.qml
  src/styles/org.kde.desktop/ApplicationWindow.qml
  src/styles/org.kde.desktop/OverlayDrawer.qml
  src/styles/org.kde.desktop/SwipeListItem.qml
  src/styles/org.kde.desktop/Theme.qml
  tests/KeyboardListTest.qml
  tests/KeyboardTest.qml

To: mart, #kirigami, hein
Cc: p

D8016: Ensure leave event is send to decoration when a window maximizes

2017-09-27 Thread Martin Flöser

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  When clicking the maximize button without moving the mouse, the maximize
  button stayed in hover state till the mouse moved. The reason for this
  is that the PointerInputRedirection does not perform an update on the
  geometry change of a window.
  
  BUG: 385140
  FIXED-IN: 5.11

TEST PLAN
  Manual testing

REPOSITORY
  R108 KWin

BRANCH
  decoration-maximize-leave-5.11

REVISION DETAIL
  https://phabricator.kde.org/D8016

AFFECTED FILES
  pointer_input.cpp
  pointer_input.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7940: plugin loaded by kirigami to use KColorScheme and KIconLoader

2017-09-27 Thread Marco Martin

mart updated this revision to Diff 20004.
mart added a comment.


  - support inactive palette for inactive windows

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7940?vs=19944&id=20004

BRANCH
  arcpatch-D7940

REVISION DETAIL
  https://phabricator.kde.org/D7940

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kirigami-integration/CMakeLists.txt
  src/kirigami-integration/kirigamiplasmaintegration.json
  src/kirigami-integration/plasmadesktoptheme.cpp
  src/kirigami-integration/plasmadesktoptheme.h
  src/kirigami-integration/plasmadesktopthemefactory.cpp
  src/kirigami-integration/plasmadesktopthemefactory.h

To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, hein

D7925: Generate the appstream metadata of the gallery app

2017-09-27 Thread Aleix Pol Gonzalez

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8e692314428d: Generate the appstream metadata of the 
gallery app (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7925?vs=19993&id=19998

REVISION DETAIL
  https://phabricator.kde.org/D7925

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/gallerydata/metadata.desktop

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D7913: Don't include the control over the bottom decoration

2017-09-27 Thread Nathaniel Graham

ngraham added a comment.


  Oh okay. Wonder what I did wrong. Will investigate.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D7913

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D7925: Generate the appstream metadata of the gallery app

2017-09-27 Thread Marco Martin

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D7925

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-09-27 Thread Aleix Pol Gonzalez

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:ef156a238298: Look for QtGraphicalEffects, so packagers 
don't forget it (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6549?vs=17925&id=19996

REVISION DETAIL
  https://phabricator.kde.org/D6549

AFFECTED FILES
  CMakeLists.txt

To: apol, #kirigami, sitter, mart, davidedmundson
Cc: graesslin, plasma-devel, apol, davidedmundson, mart, hein

D7913: Don't include the control over the bottom decoration

2017-09-27 Thread Aleix Pol Gonzalez

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:190c6dd15054: Don't include the control over the 
bottom decoration (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7913?vs=19739&id=19995

REVISION DETAIL
  https://phabricator.kde.org/D7913

AFFECTED FILES
  src/controls/ItemViewHeader.qml

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in desktopview.cpp:60
> Is it correct to compare to software? What if vulkan get's introduced?

Then we change it..

The reason it's done this way round is currently is that 
setSceneGraph("aaerkwlakrjaldkfj") will result in it being GL.

They seem to be migrating to using enums, which will make life better in the 
future.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8012

To: davidedmundson, #plasma, broulik
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7913: Don't include the control over the bottom decoration

2017-09-27 Thread Aleix Pol Gonzalez

apol added a comment.


  It certainly makes a difference. Please make sure you're not testing against 
the one in the distro.
  
  Before:
  F4186636: Spectacle.M10416.png 
  
  After:
  F4186570: Spectacle.Q10254.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D7913

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D7965: Drop the ObscurringWindow functionality on desktop switching

2017-09-27 Thread Martin Flöser

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:38ce05eaff4f: Drop the ObscurringWindow functionality on 
desktop switching (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7965?vs=19852&id=19994

REVISION DETAIL
  https://phabricator.kde.org/D7965

AFFECTED FILES
  workspace.cpp

To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7925: Generate the appstream metadata of the gallery app

2017-09-27 Thread Aleix Pol Gonzalez

apol updated this revision to Diff 19993.
apol added a comment.


  Right path

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7925?vs=19756&id=19993

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D7925

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/gallerydata/metadata.desktop

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread Martin Flöser

graesslin added inline comments.

INLINE COMMENTS

> desktopview.cpp:60
>  
> -connect(this, &DesktopView::sceneGraphInitialized, this,
> -[this, corona]() {
> -// check whether the GL Context supports OpenGL
> -// Note: hasOpenGLShaderPrograms is broken, see QTBUG--39730
> -if 
> (!QOpenGLShaderProgram::hasOpenGLShaderPrograms(openglContext())) {
> -qWarning() << "GLSL not available, Plasma won't be 
> functional";
> -QMetaObject::invokeMethod(corona, 
> "showOpenGLNotCompatibleWarning", Qt::QueuedConnection);
> -}
> -}, Qt::DirectConnection);
> +if (QQuickWindow::sceneGraphBackend() != QLatin1String("software")) {
> +connect(this, &DesktopView::sceneGraphInitialized, this,

Is it correct to compare to software? What if vulkan get's introduced?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8012

To: davidedmundson, #plasma, broulik
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3eb76ed6c126: Only assert on broken GL when we're 
rendering using GL (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8012?vs=19986&id=19989

REVISION DETAIL
  https://phabricator.kde.org/D8012

AFFECTED FILES
  shell/desktopview.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8013: Fix FrameSVGItem with the software renderer

2017-09-27 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:daef5c8b6b9c: Fix FrameSVGItem with the software renderer 
(authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8013?vs=19987&id=19990

REVISION DETAIL
  https://phabricator.kde.org/D8013

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8014: Don't animate IconItem in software mode

2017-09-27 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:94235482f9ab: Don't animate IconItem in software 
mode (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8014?vs=19988&id=19992

REVISION DETAIL
  https://phabricator.kde.org/D8014

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D4831: Add new component for the greyed out labels in Item Delegates.

2017-09-27 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6df656252bf7: Add new component for the greyed out labels 
in Item Delegates. (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4831?vs=11981&id=19991

REVISION DETAIL
  https://phabricator.kde.org/D4831

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/DescriptiveLabel.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: davidedmundson, #plasma, hein
Cc: hein, sebas, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D8013: Fix FrameSVGItem with the software renderer

2017-09-27 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8013

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8014: Don't animate IconItem in software mode

2017-09-27 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8014

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7913: Don't include the control over the bottom decoration

2017-09-27 Thread Nathaniel Graham

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I tested this and it didn't actually fix 384913. There was no change when I 
recompiled Discover against a patched Kirigami.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D7913

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D8014: Don't animate IconItem in software mode

2017-09-27 Thread David Edmundson

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  IconItem uses a gorgeous shader to fade between two states. This doesn't
  work with software rendering.
  
  Given software rendering is a second class citizen, just skip the
  animation.

TEST PLAN
  Hovered over kickoff.
  Went from one to the other, without temporarily disappearing

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8014

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8012

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8013: Fix FrameSVGItem with the software renderer

2017-09-27 Thread David Edmundson

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Software rendering (at time of writing Qt5.10) doesn't seem to like our
  tiling/stretching in the 9-tiles.
  Also when using QPainter it's arguably faster to create and cache
  pixmaps of the whole frame, which is what the slow path of FrameSVGItem
  does.

TEST PLAN
  Ran FrameSVG test then plasma shell with scene device set

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8013

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7913: Don't include the control over the bottom decoration

2017-09-27 Thread Marco Martin

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7913

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8012: Only assert on broken GL when we're rendering using GL

2017-09-27 Thread David Edmundson

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  set backend. Didn't get an error message

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8012

AFFECTED FILES
  shell/desktopview.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7941: use Kirigami Theme for colors

2017-09-27 Thread Marco Martin

mart updated this revision to Diff 19981.
mart added a comment.


  - use Kirigami Theme for colors
  - clean dead code
  - use kirigami colors
  - get rid of SystemPaletteSingleton and TextSingleton

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7941?vs=19943&id=19981

BRANCH
  mart/kirigamiintegration

REVISION DETAIL
  https://phabricator.kde.org/D7941

AFFECTED FILES
  CMakeLists.txt
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckDelegate.qml
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Dial.qml
  org.kde.desktop/Dialog.qml
  org.kde.desktop/Drawer.qml
  org.kde.desktop/Frame.qml
  org.kde.desktop/GroupBox.qml
  org.kde.desktop/ItemDelegate.qml
  org.kde.desktop/Label.qml
  org.kde.desktop/Menu.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/Popup.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/RadioDelegate.qml
  org.kde.desktop/RangeSlider.qml
  org.kde.desktop/Slider.qml
  org.kde.desktop/SpinBox.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/SwitchDelegate.qml
  org.kde.desktop/TabBar.qml
  org.kde.desktop/TextArea.qml
  org.kde.desktop/TextField.qml
  org.kde.desktop/ToolBar.qml
  org.kde.desktop/ToolButton.qml
  org.kde.desktop/ToolTip.qml
  org.kde.desktop/private/DefaultListItemBackground.qml
  plugin/CMakeLists.txt
  plugin/SystemPaletteSingleton.qml
  plugin/TextSingleton.qml
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h
  plugin/qmldir

To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, hein

D8005: static_cast QPlatformSurfaceEvent instead of dynamic_cast

2017-09-27 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e79bf9e1949f: static_cast QPlatformSurfaceEvent instead 
of dynamic_cast (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8005?vs=19977&id=19980

REVISION DETAIL
  https://phabricator.kde.org/D8005

AFFECTED FILES
  krunner/view.cpp
  ksmserver/shutdowndlg.cpp
  ksmserver/switchuserdialog.cpp
  shell/desktopview.cpp
  shell/panelconfigview.cpp
  shell/panelview.cpp

To: broulik, #plasma, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8005: static_cast QPlatformSurfaceEvent instead of dynamic_cast

2017-09-27 Thread Aleix Pol Gonzalez

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  +1 lgtm

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8005

To: broulik, #plasma, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8009: [Containment Interface] Don't add containment actions to applet actions on desktop

2017-09-27 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  For a panel it makes sense to have panel options easily available on every 
applet but on the desktop you typically have some free space to access the 
containment actions.
  This is especially confusing if you have a Folder View on your Folder View 
desktop and end up with a "Folder View Options" menu that affects the desktop 
behind it rather than the applet.

TEST PLAN
  Right clicked applet on desktop, no longer get "Foldre View Options" submenu. 
On panel I still get "Panel Options" menu

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8009

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8005: static_cast QPlatformSurfaceEvent instead of dynamic_cast

2017-09-27 Thread Kai Uwe Broulik

broulik updated this revision to Diff 19977.
broulik added a comment.


  Drop if check

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8005?vs=19971&id=19977

REVISION DETAIL
  https://phabricator.kde.org/D8005

AFFECTED FILES
  krunner/view.cpp
  ksmserver/shutdowndlg.cpp
  ksmserver/switchuserdialog.cpp
  shell/desktopview.cpp
  shell/panelconfigview.cpp
  shell/panelview.cpp

To: broulik, #plasma, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8005: static_cast QPlatformSurfaceEvent instead of dynamic_cast

2017-09-27 Thread Aleix Pol Gonzalez

apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> view.cpp:225
>  if (event->type() == QEvent::PlatformSurface) {
> -if (auto e = dynamic_cast(event)) {
> +if (auto e = static_cast(event)) {
>  setState = e->surfaceEventType() == 
> QPlatformSurfaceEvent::SurfaceCreated;

Then the if should be removed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8005

To: broulik, #plasma, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8008: [Folder View] Turn MenuHelper into a singleton type

2017-09-27 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It doesn't store any state but just has methods invoked on it.
  Now we create only one MenuHelper instead of one per applet.

TEST PLAN
  Sort by menu is still working, actions still show up in context menu and 
desktop toolbox

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8008

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml
  containments/desktop/plugins/folder/folderplugin.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8006: Add edit button to desktop theme

2017-09-27 Thread David Edmundson

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This option is only visible in plasmathemeexplorer is installed. This
  makes it easy to edit themes, without cluttering the UI of normal users.
  
  Edit button is made similar to the action buttons in the wallpaper
  delegate. (though this is copying an existing bug of of using
  plasmacomponents where they shouldn't be)
  
  MouseArea got collapsed into the parent Item in the delegate as it makes
  for more readable implicit z-ordering to have the button on top.

TEST PLAN
  Clicked on one, explorer for that theme appeared.
  Faked not having theme explorer by temporarily putting a typo in the service 
name. No buttons showed

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8006

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8005: static_cast QPlatformSurfaceEvent instead of dynamic_cast

2017-09-27 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We check for `QEvent::PlatformSurface` so we can assume this is what we get.

TEST PLAN
  Compiles, didn't notice anything unusual

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8005

AFFECTED FILES
  krunner/view.cpp
  ksmserver/shutdowndlg.cpp
  ksmserver/switchuserdialog.cpp
  shell/desktopview.cpp
  shell/panelconfigview.cpp
  shell/panelview.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

38 matches

Mail list logo