D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style
jgrulich added a comment. In https://phabricator.kde.org/D8134#152424, @thorstenb wrote: > The openconnect-plugin is not used for parsing this variable. Maybe it was in the past. > I add my pin in "nm-servie-defines.h" near NM_OPENCONNECT_KEY_USERCERT. It was not used. > I try to add this code in openconnect plugin in first place, but it was not working because the code in openconnect-plugin is not used anymore. Imho only the virtual "need_secrets" method is used from plugin. "connect" and "disconnect" are not used. > So i searched for a different place where all the vpn variables were used. And a fellow told me to have a look on plasma-nm. > I moved my stuff from openconnect plugin to plasma-nm. Now its working. > What else could i say? I am shure openconnect-plugin is not in use, because i renamed userkey in userkey2 in openconnect-plugin. But the connection ist still working. I'm not sure I understand. Let me describe how this is working: 1. You create openconnect connection in our editor (kcm), where only certain properties are allowed to be configured. These properties are defined by NetworkManager openconnect plugin, there is difference between plasma-nm openconnect plugin and NetworkManager plugin. 2. Once this connection is created and you try to activate it, NM plugin uses properties/values you configured through our editor and attempts to connect to a server you specified in "gateway" field in our connection editor 3. Then OpenconnectAuth (from plasma-nm) comes in and tries to establish a connection with the server. In OpenconnectAuthWidget::readConfig() function we read configuration which is stored in NM plugin, which is the same configuration you specified in our editor. Given there is no "pin" property specified (in both plasma-nm plugin and NM plugin), thus the dataMap we attempt to read shouldn't contain any properties which are not defined in NM openconnect plugin. In theory this will work if you manually modify your openconnect connection in /etc/NetworkManager/system-connections, but it's not the way openconnect devs want to handle passing this "pin" property. I will have to probably discuss this deeper with Openconnect devs what would be the correct way to support this. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D8134 To: thorstenb, #plasma, jgrulich Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8077: Fix org.kde.plasma.calendar with Qt 5.10
fvogt added a comment.
In https://phabricator.kde.org/D8077#152371, @broulik wrote:
> Despite just having built p-f from git I still get
>
> > Error loading QML file:
file:///usr/share/plasma/plasmoids/org.kde.plasma.fuzzyclock/contents/ui/main.qml:51:34:
Type PlasmaCalendar.MonthView unavailable
> >
file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/calendar/MonthView.qml:222:22:
DaysCalendar is not a type
>
> Do I need a newer Qt 5.10 snapshot for this?
I just checked and indeed, 930aea8b9ca59a24838cf7f279653e3b2ee40cee in
qtdeclarative ("Fix implicit loading of internal types when using explicit
imports") is also necessary.
I thought I tested it without that commit, but apparently not.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8077
To: fvogt, #plasma, broulik
Cc: broulik, #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style
thorstenb added a comment. What you are missing is the Gui part to store the pin in the network-manager config file. This is correct. I've not implementet a GUI yet. This is just the part for reading the config file values. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D8134 To: thorstenb, #plasma, jgrulich Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8149: Add support for gtk3 theme variant feature.
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D8149 To: xuetianweng, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8146: Don't try to override label heights - PlasmaComponents
mart added a comment. yes, this should stay. this was done in order to have labels automatically vertically align with other controls with just a Row (before RowLayout and Layout.alignment was a thing) as David says, will get rid of those once all is ported to new controls REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Please review 5.11 errata
Any bugs or nasty gotchas in 5.11? Please review this page before release on Tuesday https://community.kde.org/Plasma/5.11_Errata Jonathan
tars up for Plasma 5.11.0
Tars are up for Plasma 5.11.0 on racnoss for packagers to package. Release is on Tuesday As with beta new tars are drkonqi and plasma-vault. Plasma vault has runtime dep on encfs. powerdevil has ddcutil dependency turned off on advise of the author. Do have a look over announce and changelog for things to fix up https://www.kde.org/info/plasma-5.11.0.php https://www.kde.org/announcements/plasma-5.10.5-5.11.0-changelog.php https://www.kde.org/announcements/plasma-5.11.0.php Plasma devs: any last minute bug fixes ask me for a re-roll of tars. Errata https://community.kde.org/Plasma/5.11_Errata (this page hasn't seen much love though so any review welcome). Jonathan
D8146: Don't try to override label heights - PlasmaComponents
nicolasfella abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D7481: RFC: Batch window changes events on XCB
hein added a comment. Yes it is, pending rework. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8149: Add support for gtk3 theme variant feature.
This revision was automatically updated to reflect the committed changes. Closed by commit R98:59c62319781b: Add support for gtk3 theme variant feature. (authored by xuetianweng). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8149?vs=20363&id=20371 REVISION DETAIL https://phabricator.kde.org/D8149 AFFECTED FILES Breeze-gtk/gtk-3.0/gtk-dark.css Breeze-gtk/gtk-3.18/gtk-dark.css Breeze-gtk/gtk-3.20/gtk-dark.css To: xuetianweng, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8152: [platforms/drm] Use a shared pointer for gbm_surface
graesslin created this revision. graesslin added reviewers: KWin, Plasma, subdiff. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it. The DrmSurfaceBuffer is also using it and needs it to destroy the gbm_bo. Now this can become a problem in the following situation: - a page flip is still pending - the EglGbmBackend destroys the gbm_surface -> when the page flip happens the DrmSurfaceBuffer will try to destroy the gbm_bo and crash as the gbm_surface is no longer valid. This situation can happen when switching screens or when switching compositing backend (OpenGL 2 -> OpenGL 3). To address this problem a class GbmSurface is added which wrapps the gbm_surface pointer. The EglGbmBackend creates and holds a shared pointer to the GbmSurface and passes that one to the DrmSurfaceBuffer. So when cleaning up the gbm_surface only the shared pointer is reset and in case the DrmSurfaceBuffer still needs it, it can access it without problems. BUG: 385372 FIXED-IN: 5.11.0 TEST PLAN Not yet REPOSITORY R108 KWin BRANCH shared-gbm-surface-5.11 REVISION DETAIL https://phabricator.kde.org/D8152 AFFECTED FILES plugins/platforms/drm/CMakeLists.txt plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_backend.h plugins/platforms/drm/drm_buffer_gbm.cpp plugins/platforms/drm/drm_buffer_gbm.h plugins/platforms/drm/egl_gbm_backend.cpp plugins/platforms/drm/egl_gbm_backend.h plugins/platforms/drm/gbm_surface.cpp plugins/platforms/drm/gbm_surface.h To: graesslin, #kwin, #plasma, subdiff Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8152: [platforms/drm] Use a shared pointer for gbm_surface
graesslin added a comment. I have no idea why git think I copied from drm_buffer_gbm.h|cpp. I created the files from scratch. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8152 To: graesslin, #kwin, #plasma, subdiff Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. REVISION SUMMARY From kernel 4.13 on, /proc/cpuinfo always reports the static normative CPU clock and not the current one. So try to read the frequency from cpufreq and only fall back to cpuinfo it that fails. BUG: 382561 TEST PLAN Started ksysguard, frequency now changes. If the file is not readable, the frequency is read from cpuinfo as expected. REPOSITORY R106 KSysguard BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D8153 AFFECTED FILES ksysguardd/Linux/cpuinfo.c To: fvogt, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo
fvogt added a comment. I could also open all sysfs files only once and then fseek+fscanf when the value is requested, but that would only exchange a continuous fopen+fclose with fseek+more complexity IMO. I'm fine with both approaches, but I favor KISS here. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D8153 To: fvogt, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8152: [platforms/drm] Use a shared pointer for gbm_surface
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH shared-gbm-surface-5.11 REVISION DETAIL https://phabricator.kde.org/D8152 To: graesslin, #kwin, #plasma, subdiff, davidedmundson Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8152: [platforms/drm] Use a shared pointer for gbm_surface
davidedmundson added a comment. > FIXED-IN: 5.11.0 I'm afraid it won't be. Tag was today. - Patch makes, sense potentially makes that GBM sharing patch cleaner too.. REPOSITORY R108 KWin BRANCH shared-gbm-surface-5.11 REVISION DETAIL https://phabricator.kde.org/D8152 To: graesslin, #kwin, #plasma, subdiff, davidedmundson Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8152: [platforms/drm] Use a shared pointer for gbm_surface
graesslin updated this revision to Diff 20375. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Added test case for new class REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8152?vs=20373&id=20375 BRANCH shared-gbm-surface-5.11 REVISION DETAIL https://phabricator.kde.org/D8152 AFFECTED FILES autotests/CMakeLists.txt autotests/test_gbm_surface.cpp plugins/platforms/drm/CMakeLists.txt plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_backend.h plugins/platforms/drm/drm_buffer_gbm.cpp plugins/platforms/drm/drm_buffer_gbm.h plugins/platforms/drm/egl_gbm_backend.cpp plugins/platforms/drm/egl_gbm_backend.h plugins/platforms/drm/gbm_surface.cpp plugins/platforms/drm/gbm_surface.h To: graesslin, #kwin, #plasma, subdiff, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8152: [platforms/drm] Use a shared pointer for gbm_surface
graesslin added a comment. In https://phabricator.kde.org/D8152#152540, @davidedmundson wrote: > > FIXED-IN: 5.11.0 > > I'm afraid it won't be. Tag was today. Yeah, I already noticed. Basically I arc diffed, opened up my mails and saw that it was tagged. REPOSITORY R108 KWin BRANCH shared-gbm-surface-5.11 REVISION DETAIL https://phabricator.kde.org/D8152 To: graesslin, #kwin, #plasma, subdiff, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8145: Update pointer position whenever a window gets (un)minimized
davidedmundson added a comment. Why isn't the stacking order changing when you minimise the first? Shouldn't it? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8145 To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8145: Update pointer position whenever a window gets (un)minimized
luebking added a comment. Why should it? The stack remains the same, just one window changes its visibility. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8145 To: graesslin, #kwin, #plasma Cc: luebking, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8090: Move WindowRules from Client to AbstractClient
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH windowrules-to-abstractclient REVISION DETAIL https://phabricator.kde.org/D8090 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
