D8090: Move WindowRules from Client to AbstractClient

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:0372fdaf9275: Move WindowRules from Client to 
AbstractClient (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8090?vs=20204=20416

REVISION DETAIL
  https://phabricator.kde.org/D8090

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  client.cpp
  client.h
  manage.cpp
  rules.cpp
  rules.h
  shell_client.cpp
  shell_client.h

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8145: Update pointer position whenever a window gets (un)minimized

[Martin Flöser]

graesslin added a comment.


  yep, I actually checked whether we can use the stacking order changed for 
that, but it's clearly documented as only when the actual layering changes. And 
I fear it would cause problems in other areas where code reacts on stacking 
order changes and gets confused if nothing changes.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8145

To: graesslin, #kwin, #plasma
Cc: luebking, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

[Martin Flöser]

graesslin added a comment.


  Just the DBus protocol is in https://phabricator.kde.org/D8166

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8163

To: graesslin, #kwin, #plasma, mart
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8166: Add DBus protocol to virtual keyboard

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  This change adds a DBus API to query whether the virtual keyboard is
  currently enabled and provides DBus methods to request that the virtual
  keyboard gets enabled/disabled. This is useful for e.g. providing a
  Plasmoid or for convertables where the tablet mode needs to be enabled.

REPOSITORY
  R108 KWin

BRANCH
  virt-keyboard-dbus

REVISION DETAIL
  https://phabricator.kde.org/D8166

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/test_virtualkeyboard_dbus.cpp
  virtualkeyboard.cpp
  virtualkeyboard.h
  virtualkeyboard_dbus.cpp
  virtualkeyboard_dbus.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D8163#152777, @davidedmundson wrote:
  
  > Immediately going for a workaround is.. (and I don't want to use this term 
as you've clearly made a huge patch) lazy.
  
  
  Hey, I discussed this with Marco yesterday afternoon ;-)
  
  If you get it fixed in KNotifications I'm happy to discard this review. I'm 
putting up the export of the DBus protocol nevertheless as it's in general 
useful.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8163

To: graesslin, #kwin, #plasma, mart
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

[David Edmundson]

davidedmundson added a comment.


  Immediately going for a workaround is.. (and I don't want to use this term as 
you've clearly made a huge patch) lazy.
  
  Especially as the current code path in your trace shows we're doing something 
very stupid:
  
  - we go through KStatusNotifierItem
  - we find we don't have SNI in a non blocking way (see frame 11 of your trace)
  - so it falls back to using a QSystemTray
  -  which then checks to see if we have an SNI!
  
  Let me fix KNotifications.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8163

To: graesslin, #kwin, #plasma, mart
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8159: Add API for setting server decoration palettes

[David Edmundson]

davidedmundson added a comment.


  If it does go into wayland-protocols I imagine it would get renamed?
  
  And even if it did get upstreamed and adopted, Steam (for example) would want 
to set the palette.

INLINE COMMENTS

> graesslin wrote in server_decoration_interface.h:147
> Nothing better than looking into the source:
> 
>   m_colorScheme = 
> QStandardPaths::locate(QStandardPaths::GenericConfigLocation, colorScheme);

Nothing better, and it's what I did, but see the more relevant line above.

  : m_colorScheme(QFileInfo(colorScheme).isAbsolute()
  ? colorScheme
  : 
QStandardPaths::locate(QStandardPaths::GenericConfigLocation, colorScheme))

Then only go into the branch you looked at if the scheme is "kdeglobals".

It's both names and paths. Which is what the XML docs and unit test cover.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8159

To: davidedmundson, #plasma
Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D7957: Turn on frames around dock widgets by default

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  I'll see if I can re-work the patch to add separators when frames are off, 
rather than turning on all frames by default.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, mart.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  During startup the StatusNotifierItem can cause a freeze as it might do
  a blocking DBus call while the other side is performing a Wayland
  roundtrip. This freeze is broken when the DBus call times out but then
  the SNI doesn't work either.
  
  By moving the SNI into a dedicated helper process KWin itself does not
  have any blocking calls to DBus. In addition KWin exposes a DBus API to
  enable/disable the virtual keyboard, so that other processes can also
  make use of it to provide e.g. a better UI (e.g. Plasmoid).
  
  BUG: 385371

TEST PLAN
  Started a new session, it did not freeze and I had a SNI which
  worked as expected

REPOSITORY
  R108 KWin

BRANCH
  virt-keyboard-sni

REVISION DETAIL
  https://phabricator.kde.org/D8163

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/test_virtualkeyboard_dbus.cpp
  config-kwin.h.cmake
  helpers/CMakeLists.txt
  helpers/virtualkeyboard/CMakeLists.txt
  helpers/virtualkeyboard/main.cpp
  helpers/virtualkeyboard/sni.cpp
  helpers/virtualkeyboard/sni.h
  virtualkeyboard.cpp
  virtualkeyboard.h
  virtualkeyboard_dbus.cpp
  virtualkeyboard_dbus.h

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7941: use Kirigami Theme for colors

[Ben Cooksley]

bcooksley reopened this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.


  This code introduces a new dependency which has yet to be declared in the 
kde-build-metadata repository.
  As this has been several days now, i'll be reverting this commit and any 
others which interfere in the revert process in 24 hours if this isn't 
corrected.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D7941

To: mart, #plasma, #kirigami, hein
Cc: bcooksley, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein

D8159: Add API for setting server decoration palettes

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in server_decoration_interface.h:147
> I think we support both (doing a KService lookup if no complete path given), 
> imho "name" would also be consistent with what KConfig uses

Nothing better than looking into the source:

  m_colorScheme = QStandardPaths::locate(QStandardPaths::GenericConfigLocation, 
colorScheme);

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8159

To: davidedmundson, #plasma
Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D8159: Add API for setting server decoration palettes

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> graesslin wrote in server_decoration_interface.h:147
> is it a paletteName or palettePath? IIRC we set complete paths?

I think we support both (doing a KService lookup if no complete path given), 
imho "name" would also be consistent with what KConfig uses

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8159

To: davidedmundson, #plasma
Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D8159: Add API for setting server decoration palettes

[Martin Flöser]

graesslin added a comment.


  I'm fine with the change, but when I thought about it, I was wondering 
whether it would be better to have a dedicated interface. There is at least one 
other Wayland compositor out there which implements the protocol and I got 
several requests about upstreaming it. So if at some day it ends up in 
wayland-protocols I think this request would be too Plasma/KWin specific with a 
reference to the KColorScheme path. On the other hand one can consider it a 
point for future as we have to change the code anyway if it ever gets 
upstreamed.

INLINE COMMENTS

> server_decoration.cpp:291
> +Q_ASSERT(d->serversidedecoration.isValid());
> +if(wl_proxy_get_version(d->serversidedecoration) < 
> ORG_KDE_KWIN_SERVER_DECORATION_SET_PALETTE_SINCE_VERSION) {
> +return;

nitpick: missing whitespace

> server_decoration_interface.h:147
> + */
> +void paletteChanged(const QString );
> +

is it a paletteName or palettePath? IIRC we set complete paths?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8159

To: davidedmundson, #plasma
Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D8160: be less aggressive when to disable borders

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Shit it, thanks ! 
  In fact I remember making the same fix some time back in breeze. Must have 
forgotten to backport it to oxygen.

REPOSITORY
  R113 Oxygen Theme

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8160

To: mart, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8160: be less aggressive when to disable borders

[Marco Martin]

mart added a comment.


  F4968746: Spectacle.a23412.png 

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8160

To: mart, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8160: be less aggressive when to disable borders

[Marco Martin]

mart retitled this revision from "ibe less aggressive when to disable borders" 
to "be less aggressive when to disable borders".
mart added reviewers: Plasma, hpereiradacosta.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D8160

To: mart, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8160: ibe less aggressive when to disable borders

[Marco Martin]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  if the control height is
  2*Metrics::LineEdit_FrameWidth + option->fontMetrics.height()
  it means that "it just fits", therefore still draw the frame
  
  the qqc2-desktop style uses that logic to get default line edit
  heights, so they all got disabled by just one pixel

TEST PLAN
  tested qwidget and qml apps

REPOSITORY
  R113 Oxygen Theme

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8160

AFFECTED FILES
  kstyle/oxygenstyle.cpp

To: mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:cbaaf5f4ff54: Try to read CPU clock from 
cpufreq/scaling_cur_freq instead of /proc/cpuinfo (authored by fvogt).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8153?vs=20374=20389

REVISION DETAIL
  https://phabricator.kde.org/D8153

AFFECTED FILES
  ksysguardd/Linux/cpuinfo.c

To: fvogt, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo

[Sebastian Kügler]

sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R106 KSysguard

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D8153

To: fvogt, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8159: Add API for setting server decoration palettes

[David Edmundson]

davidedmundson added a comment.


  In https://phabricator.kde.org/D8159#152648, @broulik wrote:
  
  > > This is getting deprecated
  >
  > yay...
  >
  > global menu also uses it
  
  
  That's next.
  Will make a new protocol for that, it doesn't fit here.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8159

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8159: Add API for setting server decoration palettes

[Kai Uwe Broulik]

broulik added a comment.


  > This is getting deprecated
  
  yay...
  
  global menu also uses it

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8159

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8159: Add API for setting server decoration palettes

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This is currently handled by the QtExtended surface which is an
  arbitrary hashmap. This is getting deprecated, and we should do it
  properly anyway.
  
  This patch adds it into the existing protocol that sets with a client
  surface is decorated or not, as semantically it's very closely related.

TEST PLAN
  Attached unit test
  My wayland windows still are decorated

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8159

AFFECTED FILES
  autotests/client/test_server_side_decoration.cpp
  src/client/protocols/server-decoration.xml
  src/client/registry.cpp
  src/client/server_decoration.cpp
  src/client/server_decoration.h
  src/server/server_decoration_interface.cpp
  src/server/server_decoration_interface.h

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

Latte Dock in review phase

[Michail Vourlakos]

Hello,

Latte Dock entered the review phase in order to be part of extragear in the
future. After some requests I am forwarding you the message sent at
kde-core-devel mailing list in case there are plasma devs that want to
participate in the review...

---

Hello everyone,

we decided to make Latte an active kde project and so now it is in review
phase. I believe the best place to be is extragear because we would like to
keep some independence for the first year concerning releases...

What is Latte Dock?

Latte is a project that is trying to provide a unified solution concering
docks and panels for the user. To achieve this it provides,
the Latte app, a Latte qml library, a Latte containment, a Latte plasmoid,
a Latte shell that uses plasma shell as base and 2 applets (a separator and
a specialized spacer)

for more infos concerning the capabilities of the Latte suite you can find
at:
https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html
https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-tornado-is-coming.html

the project before entering the kde infrastructure could be found at:
https://github.com/psifidotos/Latte-Dock

in review you can find our 0.7.1 version which is our stable version and
the plan is that after we succeed in the review phase to release a 0.7.2
version only through kde infrastructure...

regards,
michail

Re: Latte Dock in review phase

[Michail Vourlakos]

ok, I will forward it there also

2017-10-06 10:19 GMT+03:00 Jonathan Riddell :

> plasma-devel subscribers may be interested in reviewing this
>
>
> -- Forwarded message --
> From: Michail Vourlakos 
> Date: 4 October 2017 at 22:00
> Subject: Latte Dock in review phase
> To: kde-core-de...@kde.org
>
>
> Hello everyone,
>
> we decided to make Latte an active kde project and so now it is in
> review phase. I believe the best place to be is extragear because we
> would like to keep some independence for the first year concerning
> releases...
>
> What is Latte Dock?
>
> Latte is a project that is trying to provide a unified solution
> concering docks and panels for the user. To achieve this it provides,
> the Latte app, a Latte qml library, a Latte containment, a Latte
> plasmoid, a Latte shell that uses plasma shell as base and 2 applets
> (a separator and a specialized spacer)
>
> for more infos concerning the capabilities of the Latte suite you can find
> at:
> https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html
> https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-
> tornado-is-coming.html
>
> the project before entering the kde infrastructure could be found at:
> https://github.com/psifidotos/Latte-Dock
>
> in review you can find our 0.7.1 version which is our stable version
> and the plan is that after we succeed in the review phase to release a
> 0.7.2 version only through kde infrastructure...
>
> regards,
> michail
>

Fwd: Latte Dock in review phase

[Jonathan Riddell]

plasma-devel subscribers may be interested in reviewing this


-- Forwarded message --
From: Michail Vourlakos 
Date: 4 October 2017 at 22:00
Subject: Latte Dock in review phase
To: kde-core-de...@kde.org


Hello everyone,

we decided to make Latte an active kde project and so now it is in
review phase. I believe the best place to be is extragear because we
would like to keep some independence for the first year concerning
releases...

What is Latte Dock?

Latte is a project that is trying to provide a unified solution
concering docks and panels for the user. To achieve this it provides,
the Latte app, a Latte qml library, a Latte containment, a Latte
plasmoid, a Latte shell that uses plasma shell as base and 2 applets
(a separator and a specialized spacer)

for more infos concerning the capabilities of the Latte suite you can find at:
https://psifidotos.blogspot.nl/2017/04/latte-dock-v06-fresh-air.html
https://psifidotos.blogspot.nl/2017/08/latte-dock-v07-tornado-is-coming.html

the project before entering the kde infrastructure could be found at:
https://github.com/psifidotos/Latte-Dock

in review you can find our 0.7.1 version which is our stable version
and the plan is that after we succeed in the review phase to release a
0.7.2 version only through kde infrastructure...

regards,
michail